plugin-agent-orchestrator 1.1.3 → 1.1.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (218) hide show
  1. package/README.md +204 -114
  2. package/dist/client/index.js +1 -1
  3. package/dist/client-v2/117.7565cff57c39318a.js +10 -0
  4. package/dist/client-v2/214.106635011859dede.js +10 -0
  5. package/dist/client-v2/253.59577b40d9875be0.js +10 -0
  6. package/dist/client-v2/264.7ed8bee71fa5935c.js +10 -0
  7. package/dist/client-v2/{41.ba6e080cc0488143.js → 41.3deb9e57a0f64fc4.js} +1 -1
  8. package/dist/client-v2/418.41ed200e7d6da332.js +10 -0
  9. package/dist/client-v2/53.349fff8db80b19d4.js +10 -0
  10. package/dist/client-v2/619.0a2144aaffefe018.js +10 -0
  11. package/dist/client-v2/{70.bda9518881c05360.js → 70.ffff2997c10fd4b0.js} +1 -1
  12. package/dist/client-v2/{794.9bbb8d3a61b2bdf2.js → 794.a67a2614405ba627.js} +1 -1
  13. package/dist/client-v2/981.e4a1f41cfc94a856.js +10 -0
  14. package/dist/client-v2/{993.82778b6fd6db3cb1.js → 993.b0688fdc5ccb000a.js} +1 -1
  15. package/dist/client-v2/index.js +1 -1
  16. package/dist/externalVersion.js +8 -7
  17. package/dist/locale/en-US.json +199 -123
  18. package/dist/locale/vi-VN.json +199 -123
  19. package/dist/locale/zh-CN.json +199 -123
  20. package/dist/server/collections/agent-execution-spans.js +55 -0
  21. package/dist/server/collections/agent-harness-profile-versions.js +56 -0
  22. package/dist/server/collections/agent-harness-profiles.js +12 -0
  23. package/dist/server/collections/agent-loop-action-approvals.js +69 -0
  24. package/dist/server/collections/agent-loop-artifacts.js +55 -0
  25. package/dist/server/collections/agent-loop-circuit-states.js +53 -0
  26. package/dist/server/collections/agent-loop-control-settings.js +51 -0
  27. package/dist/server/collections/agent-loop-events.js +27 -0
  28. package/dist/server/collections/agent-loop-path-locks.js +57 -0
  29. package/dist/server/collections/agent-loop-patterns.js +72 -0
  30. package/dist/server/collections/agent-loop-runs.js +170 -3
  31. package/dist/server/collections/agent-loop-steps.js +76 -0
  32. package/dist/server/collections/agent-loop-usage-buckets.js +52 -0
  33. package/dist/server/collections/agent-loop-worktrees.js +55 -0
  34. package/dist/server/collections/skill-executions.js +8 -0
  35. package/dist/server/migrations/{20260427000000-change-packages-to-text.js → 20260427000002-change-packages-to-text.js} +2 -0
  36. package/dist/server/migrations/20260429000000-add-llm-fields.js +3 -2
  37. package/dist/server/migrations/{20260429000000-fix-inputargs-json-to-text.js → 20260429000001-fix-inputargs-json-to-text.js} +14 -6
  38. package/dist/server/migrations/20260503000000-add-orchestrator-trace-fields.js +2 -1
  39. package/dist/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.js +2 -1
  40. package/dist/server/migrations/20260803010000-backfill-loop-control-plane-data.js +262 -0
  41. package/dist/server/plugin.js +54 -150
  42. package/dist/server/resources/agent-harness-profile.js +117 -0
  43. package/dist/server/resources/agent-knowledge-insights.js +1 -3
  44. package/dist/server/resources/agent-loop-approval.js +108 -0
  45. package/dist/server/resources/agent-loop-artifact.js +86 -0
  46. package/dist/server/resources/agent-loop-events-stream.js +130 -0
  47. package/dist/server/resources/agent-loop.js +183 -139
  48. package/dist/server/resources/resource-helpers.js +63 -0
  49. package/dist/server/resources/tracing.js +121 -107
  50. package/dist/server/services/AgentMemoryContextService.js +34 -0
  51. package/dist/server/services/DurableCircuitBreakerService.js +229 -0
  52. package/dist/server/services/HarnessCompiler.js +175 -0
  53. package/dist/server/services/HarnessProfileService.js +233 -0
  54. package/dist/server/services/HarnessSchema.js +194 -0
  55. package/dist/server/services/LoopBudgetService.js +269 -0
  56. package/dist/server/services/LoopControlService.js +139 -0
  57. package/dist/server/services/LoopPatternSchema.js +195 -0
  58. package/dist/server/services/LoopPatternService.js +132 -0
  59. package/dist/server/services/LoopRunRepository.js +285 -0
  60. package/dist/server/services/LoopRunStateMachine.js +478 -0
  61. package/dist/server/services/LoopSchedulerService.js +193 -0
  62. package/dist/server/services/LoopTriggerService.js +165 -0
  63. package/dist/server/services/LoopWorkerService.js +699 -0
  64. package/dist/server/services/NativeSubAgentObserver.js +165 -23
  65. package/dist/server/services/PathLockService.js +288 -0
  66. package/dist/server/services/PluginAiRuntimeAdapter.js +226 -0
  67. package/dist/server/services/ToolLoopDetectionService.js +210 -0
  68. package/dist/server/services/VerificationSchema.js +59 -0
  69. package/dist/server/services/VerificationService.js +235 -0
  70. package/dist/server/services/harness-runtime-policy.js +139 -0
  71. package/dist/server/skill-hub/actions/git-import.js +13 -7
  72. package/dist/server/skill-hub/plugin.js +36 -3
  73. package/dist/server/skill-hub/services/RegistrySkillSnapshotService.js +1 -5
  74. package/dist/server/skill-hub/tasks/SkillExecutionTask.js +29 -0
  75. package/dist/server/utils/ensure-indexes.js +111 -0
  76. package/dist/server/utils/loop-pattern-context.js +56 -0
  77. package/package.json +53 -53
  78. package/src/client/ApprovalsTab.tsx +2 -0
  79. package/src/client/OrchestratorSettings.tsx +55 -0
  80. package/src/client/skill-hub/components/GitSkillImport.tsx +3 -3
  81. package/src/client/skill-hub/components/SkillMetrics.tsx +15 -10
  82. package/src/client/skill-hub/index.tsx +0 -52
  83. package/src/client-v2/components/AgentRunsTab.tsx +100 -18
  84. package/src/client-v2/components/ApprovalsTab.tsx +337 -0
  85. package/src/client-v2/components/HarnessProfilesTab.tsx +385 -100
  86. package/src/client-v2/components/MemoryInspectorTab.tsx +141 -125
  87. package/src/client-v2/components/TracingTab.tsx +160 -77
  88. package/src/client-v2/hooks/useApiRequest.ts +28 -8
  89. package/src/client-v2/pages/ApprovalsPage.tsx +10 -0
  90. package/src/client-v2/plugin.tsx +6 -6
  91. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +11 -6
  92. package/src/locale/en-US.json +199 -123
  93. package/src/locale/vi-VN.json +199 -123
  94. package/src/locale/zh-CN.json +199 -123
  95. package/src/server/__tests__/circuit-breaker.test.ts +248 -169
  96. package/src/server/__tests__/harness-compiler.test.ts +214 -0
  97. package/src/server/__tests__/harness-profile-service.test.ts +167 -0
  98. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -0
  99. package/src/server/__tests__/harness-tool-plan.test.ts +172 -0
  100. package/src/server/__tests__/loop-approval-decision.test.ts +512 -0
  101. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -0
  102. package/src/server/__tests__/loop-budget-service.test.ts +255 -0
  103. package/src/server/__tests__/loop-control-plane-backfill.test.ts +266 -0
  104. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -0
  105. package/src/server/__tests__/loop-pattern-service.test.ts +148 -0
  106. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -0
  107. package/src/server/__tests__/loop-trigger-service.test.ts +148 -0
  108. package/src/server/__tests__/loop-worker-claim.test.ts +341 -0
  109. package/src/server/__tests__/loop-worker-execution.test.ts +317 -0
  110. package/src/server/__tests__/native-sub-agent-observer.test.ts +288 -4
  111. package/src/server/__tests__/path-lock-service.test.ts +254 -0
  112. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -0
  113. package/src/server/__tests__/smoke.test.ts +162 -121
  114. package/src/server/__tests__/tool-loop-detection.test.ts +275 -0
  115. package/src/server/collections/agent-execution-spans.ts +55 -0
  116. package/src/server/collections/agent-harness-profile-versions.ts +26 -0
  117. package/src/server/collections/agent-harness-profiles.ts +71 -59
  118. package/src/server/collections/agent-loop-action-approvals.ts +39 -0
  119. package/src/server/collections/agent-loop-artifacts.ts +25 -0
  120. package/src/server/collections/agent-loop-circuit-states.ts +23 -0
  121. package/src/server/collections/agent-loop-control-settings.ts +21 -0
  122. package/src/server/collections/agent-loop-events.ts +98 -71
  123. package/src/server/collections/agent-loop-path-locks.ts +27 -0
  124. package/src/server/collections/agent-loop-patterns.ts +42 -0
  125. package/src/server/collections/agent-loop-runs.ts +170 -3
  126. package/src/server/collections/agent-loop-steps.ts +76 -0
  127. package/src/server/collections/agent-loop-usage-buckets.ts +22 -0
  128. package/src/server/collections/agent-loop-worktrees.ts +25 -0
  129. package/src/server/collections/skill-executions.ts +8 -0
  130. package/src/server/migrations/{20260427000000-change-packages-to-text.ts → 20260427000002-change-packages-to-text.ts} +52 -49
  131. package/src/server/migrations/20260429000000-add-llm-fields.ts +47 -46
  132. package/src/server/migrations/{20260429000000-fix-inputargs-json-to-text.ts → 20260429000001-fix-inputargs-json-to-text.ts} +45 -38
  133. package/src/server/migrations/20260503000000-add-orchestrator-trace-fields.ts +33 -32
  134. package/src/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.ts +31 -30
  135. package/src/server/migrations/20260803010000-backfill-loop-control-plane-data.ts +293 -0
  136. package/src/server/plugin.ts +55 -167
  137. package/src/server/resources/agent-harness-profile.ts +94 -0
  138. package/src/server/resources/agent-knowledge-insights.ts +5 -3
  139. package/src/server/resources/agent-loop-approval.ts +84 -0
  140. package/src/server/resources/agent-loop-artifact.ts +56 -0
  141. package/src/server/resources/agent-loop-events-stream.ts +105 -0
  142. package/src/server/resources/agent-loop.ts +204 -143
  143. package/src/server/resources/agent-monitor.ts +482 -482
  144. package/src/server/resources/resource-helpers.ts +33 -0
  145. package/src/server/resources/tracing.ts +266 -258
  146. package/src/server/services/AgentMemoryContextService.ts +44 -0
  147. package/src/server/services/DurableCircuitBreakerService.ts +239 -0
  148. package/src/server/services/ExecutionSpanService.ts +2 -0
  149. package/src/server/services/HarnessCompiler.ts +170 -0
  150. package/src/server/services/HarnessProfileService.ts +239 -0
  151. package/src/server/services/HarnessSchema.ts +194 -0
  152. package/src/server/services/LoopBudgetService.ts +275 -0
  153. package/src/server/services/LoopControlService.ts +124 -0
  154. package/src/server/services/LoopPatternSchema.ts +185 -0
  155. package/src/server/services/LoopPatternService.ts +143 -0
  156. package/src/server/services/LoopRunRepository.ts +336 -0
  157. package/src/server/services/LoopRunStateMachine.ts +529 -0
  158. package/src/server/services/LoopSchedulerService.ts +199 -0
  159. package/src/server/services/LoopTriggerService.ts +157 -0
  160. package/src/server/services/LoopWorkerService.ts +822 -0
  161. package/src/server/services/NativeSubAgentObserver.ts +186 -21
  162. package/src/server/services/PathLockService.ts +321 -0
  163. package/src/server/services/PluginAiRuntimeAdapter.ts +332 -0
  164. package/src/server/services/ToolLoopDetectionService.ts +213 -0
  165. package/src/server/services/VerificationSchema.ts +31 -0
  166. package/src/server/services/VerificationService.ts +264 -0
  167. package/src/server/services/harness-runtime-policy.ts +141 -0
  168. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +15 -1
  169. package/src/server/skill-hub/actions/git-import.ts +9 -3
  170. package/src/server/skill-hub/plugin.ts +41 -3
  171. package/src/server/skill-hub/services/RegistrySkillSnapshotService.ts +235 -239
  172. package/src/server/skill-hub/services/__tests__/RegistrySkillSnapshotService.test.ts +61 -63
  173. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +43 -2
  174. package/src/server/utils/ensure-indexes.ts +96 -0
  175. package/src/server/utils/logging.ts +62 -63
  176. package/src/server/utils/loop-pattern-context.ts +20 -0
  177. package/dist/client-v2/214.79650a549273f163.js +0 -10
  178. package/dist/client-v2/253.9f0537713cee9e6c.js +0 -10
  179. package/dist/client-v2/264.718a107e43fc163c.js +0 -10
  180. package/dist/client-v2/373.f5d5292e53c4e832.js +0 -10
  181. package/dist/client-v2/418.ce8f5b2b8a229d1d.js +0 -10
  182. package/dist/client-v2/53.7c29c28043e9112d.js +0 -10
  183. package/dist/client-v2/619.bd3c5698b40705c3.js +0 -10
  184. package/dist/client-v2/677.a991ce0250ff5c77.js +0 -10
  185. package/dist/client-v2/925.f5370de8f6632d65.js +0 -10
  186. package/dist/server/services/AgentHarness.js +0 -81
  187. package/dist/server/services/AgentLoopController.js +0 -1023
  188. package/dist/server/services/AgentLoopRepository.js +0 -192
  189. package/dist/server/services/AgentLoopService.js +0 -142
  190. package/dist/server/services/AgentPlanValidator.js +0 -99
  191. package/dist/server/services/AgentPlannerService.js +0 -99
  192. package/dist/server/services/CircuitBreaker.js +0 -125
  193. package/dist/server/services/ContextAggregator.js +0 -201
  194. package/dist/server/services/PlanningPromptService.js +0 -95
  195. package/dist/server/tools/agent-loop.js +0 -373
  196. package/dist/server/tools/orchestrator-plan.js +0 -254
  197. package/src/client/AIEmployeeSelect.tsx +0 -47
  198. package/src/client/AIEmployeesContext.tsx +0 -102
  199. package/src/client/RulesTab.tsx +0 -2
  200. package/src/client/TracingTab.tsx +0 -436
  201. package/src/client/skill-hub/components/ExecutionProgress.tsx +0 -51
  202. package/src/client-v2/components/RulesTab.tsx +0 -2
  203. package/src/client-v2/pages/AgentRunsPage.tsx +0 -13
  204. package/src/server/__tests__/agent-loop-controller.test.ts +0 -375
  205. package/src/server/__tests__/context-aggregator.test.ts +0 -222
  206. package/src/server/__tests__/parallel-execution.test.ts +0 -318
  207. package/src/server/__tests__/planning-prompt-service.test.ts +0 -23
  208. package/src/server/services/AgentHarness.ts +0 -67
  209. package/src/server/services/AgentLoopController.ts +0 -1263
  210. package/src/server/services/AgentLoopRepository.ts +0 -178
  211. package/src/server/services/AgentLoopService.ts +0 -177
  212. package/src/server/services/AgentPlanValidator.ts +0 -73
  213. package/src/server/services/AgentPlannerService.ts +0 -80
  214. package/src/server/services/CircuitBreaker.ts +0 -126
  215. package/src/server/services/ContextAggregator.ts +0 -239
  216. package/src/server/services/PlanningPromptService.ts +0 -72
  217. package/src/server/tools/agent-loop.ts +0 -360
  218. package/src/server/tools/orchestrator-plan.ts +0 -255
@@ -0,0 +1,275 @@
1
+ import { describe, expect, it } from 'vitest';
2
+ import type { Database } from '@nocobase/database';
3
+ import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
4
+ import { getRunEventBus } from '../services/RunEventBus';
5
+ import {
6
+ ToolLoopDetectionService,
7
+ countToolRepetitions,
8
+ toolCallSignature,
9
+ toolLoopLevel,
10
+ } from '../services/ToolLoopDetectionService';
11
+ import type { ToolLoopFinding } from '../services/ToolLoopDetectionService';
12
+
13
+ type Row = Record<string, unknown>;
14
+
15
+ const defaultPolicy = loopPatternPolicySchema.parse({});
16
+
17
+ function matches(row: Row, filter: Row): boolean {
18
+ return Object.entries(filter).every(([key, value]) => {
19
+ if (value && typeof value === 'object' && Array.isArray((value as Row).$in)) {
20
+ return ((value as Row).$in as unknown[]).includes(row[key]);
21
+ }
22
+ return row[key] === value;
23
+ });
24
+ }
25
+
26
+ function mockDatabase(options: { steps?: Row[]; messages?: Row[] } = {}) {
27
+ const steps: Row[] = [...(options.steps ?? [])];
28
+ const events: Row[] = [];
29
+ let nextId = 1;
30
+ const database = {
31
+ getRepository(name: string) {
32
+ if (name === 'agentLoopSteps') {
33
+ return {
34
+ find: async ({ filter }: { filter: Row }) => steps.filter((row) => matches(row, filter)),
35
+ findOne: async ({ filter }: { filter: Row }) => steps.find((row) => matches(row, filter)) ?? null,
36
+ create: async ({ values }: { values: Row }) => {
37
+ const row = { id: nextId++, ...values };
38
+ steps.push(row);
39
+ return row;
40
+ },
41
+ };
42
+ }
43
+ if (name === 'aiMessages') {
44
+ return {
45
+ find: async ({ filter }: { filter: Row }) => (options.messages ?? []).filter((row) => matches(row, filter)),
46
+ };
47
+ }
48
+ if (name === 'agentLoopEvents') {
49
+ return {
50
+ create: async ({ values }: { values: Row }) => {
51
+ const row = { id: nextId++, ...values };
52
+ events.push(row);
53
+ return row;
54
+ },
55
+ };
56
+ }
57
+ throw new Error(`Unexpected repository ${name}`);
58
+ },
59
+ } as unknown as Database;
60
+ return { database, steps, events };
61
+ }
62
+
63
+ function message(sessionId: string, calls: Array<{ id: string; name: string; args: unknown }>): Row {
64
+ return { sessionId, role: 'assistant', toolCalls: calls };
65
+ }
66
+
67
+ function finding(overrides: Partial<ToolLoopFinding> = {}): ToolLoopFinding {
68
+ return {
69
+ level: 'warn',
70
+ toolName: 'searchDocs',
71
+ signature: toolCallSignature('searchDocs', { query: 'loop' }),
72
+ count: 3,
73
+ sampleArgs: { query: 'loop' },
74
+ ...overrides,
75
+ };
76
+ }
77
+
78
+ describe('toolCallSignature', () => {
79
+ it('is stable across object key order', () => {
80
+ expect(toolCallSignature('search', { a: 1, b: 2 })).toBe(toolCallSignature('search', { b: 2, a: 1 }));
81
+ });
82
+
83
+ it('separates the tool name from its arguments', () => {
84
+ expect(toolCallSignature('a 1', null)).not.toBe(toolCallSignature('a', '1 null'));
85
+ expect(toolCallSignature('search', { a: 1 })).not.toBe(toolCallSignature('search', { a: 2 }));
86
+ });
87
+
88
+ it('treats missing args the same as null', () => {
89
+ expect(toolCallSignature('ping', undefined)).toBe(toolCallSignature('ping', null));
90
+ });
91
+ });
92
+
93
+ describe('countToolRepetitions', () => {
94
+ it('counts identical calls and separates differing args', () => {
95
+ const counts = countToolRepetitions([
96
+ { name: 'search', args: { q: 'x' } },
97
+ { name: 'search', args: { q: 'x' } },
98
+ { name: 'search', args: { q: 'y' } },
99
+ { name: 'write', args: { q: 'x' } },
100
+ { name: '', args: {} },
101
+ ]);
102
+
103
+ expect(counts.size).toBe(3);
104
+ const repeated = [...counts.values()].find((entry) => entry.count === 2);
105
+ expect(repeated?.toolName).toBe('search');
106
+ expect(repeated?.sampleArgs).toEqual({ q: 'x' });
107
+ });
108
+ });
109
+
110
+ describe('toolLoopLevel', () => {
111
+ it('maps counts onto the policy thresholds', () => {
112
+ const detection = defaultPolicy.loopDetection;
113
+ expect(toolLoopLevel(2, detection)).toBe('none');
114
+ expect(toolLoopLevel(3, detection)).toBe('warn');
115
+ expect(toolLoopLevel(5, detection)).toBe('block');
116
+ expect(toolLoopLevel(8, detection)).toBe('escalate');
117
+ expect(toolLoopLevel(100, detection)).toBe('escalate');
118
+ });
119
+
120
+ it('returns none when detection is disabled', () => {
121
+ expect(toolLoopLevel(100, { ...defaultPolicy.loopDetection, enabled: false })).toBe('none');
122
+ });
123
+ });
124
+
125
+ describe('ToolLoopDetectionService.scanRun', () => {
126
+ it('returns the most repeated signature across every pass session of the run', async () => {
127
+ const { database } = mockDatabase({
128
+ steps: [
129
+ { runId: 1, sessionId: 's1' },
130
+ { runId: 1, sessionId: 's2' },
131
+ { runId: 2, sessionId: 'other-run' },
132
+ ],
133
+ messages: [
134
+ message('s1', [
135
+ { id: 'c1', name: 'searchDocs', args: { query: 'loop' } },
136
+ { id: 'c2', name: 'searchDocs', args: { query: 'loop' } },
137
+ ]),
138
+ message('s2', [
139
+ { id: 'c3', name: 'searchDocs', args: { query: 'loop' } },
140
+ { id: 'c4', name: 'readFile', args: { path: '/tmp/a' } },
141
+ ]),
142
+ message('other-run', [
143
+ { id: 'c5', name: 'searchDocs', args: { query: 'loop' } },
144
+ { id: 'c6', name: 'searchDocs', args: { query: 'loop' } },
145
+ ]),
146
+ ],
147
+ });
148
+ const service = new ToolLoopDetectionService(database);
149
+
150
+ const result = await service.scanRun(1, defaultPolicy);
151
+
152
+ expect(result).toMatchObject({ level: 'warn', toolName: 'searchDocs', count: 3 });
153
+ });
154
+
155
+ it('returns null while the run stays under the warn threshold', async () => {
156
+ const { database } = mockDatabase({
157
+ steps: [{ runId: 1, sessionId: 's1' }],
158
+ messages: [
159
+ message('s1', [
160
+ { id: 'c1', name: 'searchDocs', args: { query: 'loop' } },
161
+ { id: 'c2', name: 'searchDocs', args: { query: 'loop' } },
162
+ ]),
163
+ ],
164
+ });
165
+ const service = new ToolLoopDetectionService(database);
166
+
167
+ expect(await service.scanRun(1, defaultPolicy)).toBeNull();
168
+ });
169
+
170
+ it('returns null when detection is disabled', async () => {
171
+ const { database } = mockDatabase({
172
+ steps: [{ runId: 1, sessionId: 's1' }],
173
+ messages: [
174
+ message('s1', [
175
+ { id: 'c1', name: 'searchDocs', args: { query: 'loop' } },
176
+ { id: 'c2', name: 'searchDocs', args: { query: 'loop' } },
177
+ { id: 'c3', name: 'searchDocs', args: { query: 'loop' } },
178
+ ]),
179
+ ],
180
+ });
181
+ const service = new ToolLoopDetectionService(database);
182
+ const policy = loopPatternPolicySchema.parse({ loopDetection: { enabled: false } });
183
+
184
+ expect(await service.scanRun(1, policy)).toBeNull();
185
+ });
186
+
187
+ it('returns null when no pass session recorded tool calls', async () => {
188
+ const { database } = mockDatabase({ steps: [{ runId: 1, sessionId: 's1' }], messages: [] });
189
+ const service = new ToolLoopDetectionService(database);
190
+
191
+ expect(await service.scanRun(1, defaultPolicy)).toBeNull();
192
+ expect(await service.scanRun(99, defaultPolicy)).toBeNull();
193
+ });
194
+
195
+ it('ignores malformed tool call entries', async () => {
196
+ const { database } = mockDatabase({
197
+ steps: [{ runId: 1, sessionId: 's1' }],
198
+ messages: [
199
+ {
200
+ sessionId: 's1',
201
+ role: 'assistant',
202
+ toolCalls: [
203
+ { id: 'c1', args: { query: 'loop' } },
204
+ { id: 'c2', name: 'searchDocs', args: { query: 'loop' } },
205
+ 'not-an-object',
206
+ ],
207
+ },
208
+ ],
209
+ });
210
+ const service = new ToolLoopDetectionService(database);
211
+
212
+ expect(await service.scanRun(1, defaultPolicy)).toBeNull();
213
+ });
214
+ });
215
+
216
+ describe('ToolLoopDetectionService.recordFinding', () => {
217
+ it('records one guard step and one event per signature and emits on the run bus', async () => {
218
+ const { database, steps, events } = mockDatabase({ steps: [{ runId: 42, sessionId: 's1' }] });
219
+ const service = new ToolLoopDetectionService(database);
220
+ const seen: unknown[] = [];
221
+ const unsubscribe = getRunEventBus().subscribe(42, (event) => seen.push(event));
222
+ const context = {
223
+ runId: 42,
224
+ role: 'leader',
225
+ username: 'lead',
226
+ runStatus: 'running',
227
+ actorType: 'worker',
228
+ actorIdentity: 'worker-a',
229
+ };
230
+
231
+ try {
232
+ expect(await service.recordFinding(context, finding())).toBe(true);
233
+ expect(await service.recordFinding(context, finding())).toBe(false);
234
+ } finally {
235
+ unsubscribe();
236
+ }
237
+
238
+ const guardSteps = steps.filter((step) => step.kind === 'guard');
239
+ expect(guardSteps).toHaveLength(1);
240
+ expect(guardSteps[0]).toMatchObject({
241
+ runId: 42,
242
+ type: 'tool_loop',
243
+ toolName: 'searchDocs',
244
+ status: 'succeeded',
245
+ });
246
+ expect(events).toHaveLength(1);
247
+ expect(events[0]).toMatchObject({ runId: 42, type: 'tool_loop_detected', status: 'running' });
248
+ expect(seen).toHaveLength(1);
249
+ });
250
+ });
251
+
252
+ describe('ToolLoopDetectionService.existingNotices', () => {
253
+ it('rebuilds notices from recorded guard steps', async () => {
254
+ const { database } = mockDatabase({
255
+ steps: [
256
+ {
257
+ runId: 7,
258
+ kind: 'guard',
259
+ toolName: 'searchDocs',
260
+ metadata: { level: 'warn', count: 3 },
261
+ },
262
+ { runId: 7, kind: 'guard', toolName: '', metadata: { count: 5 } },
263
+ { runId: 7, kind: 'invocation', toolName: 'other', metadata: {} },
264
+ ],
265
+ });
266
+ const service = new ToolLoopDetectionService(database);
267
+
268
+ const notices = await service.existingNotices(7);
269
+
270
+ expect(notices).toHaveLength(1);
271
+ expect(notices[0]).toContain('<tool_loop_warning>');
272
+ expect(notices[0]).toContain('searchDocs');
273
+ expect(notices[0]).toContain('3 times');
274
+ });
275
+ });
@@ -23,11 +23,54 @@ export default defineCollection({
23
23
  length: 100,
24
24
  allowNull: false,
25
25
  },
26
+ {
27
+ name: 'agentLoopRunId',
28
+ type: 'bigInt',
29
+ },
30
+ {
31
+ name: 'agentLoopStepId',
32
+ type: 'bigInt',
33
+ },
34
+ {
35
+ name: 'patternId',
36
+ type: 'bigInt',
37
+ },
38
+ {
39
+ name: 'role',
40
+ type: 'string',
41
+ length: 30,
42
+ },
43
+ {
44
+ name: 'harnessProfileTag',
45
+ type: 'string',
46
+ length: 100,
47
+ },
48
+ {
49
+ name: 'harnessProfileVersion',
50
+ type: 'integer',
51
+ },
52
+ {
53
+ name: 'policyDecision',
54
+ type: 'json',
55
+ defaultValue: {},
56
+ },
57
+ {
58
+ name: 'approvalId',
59
+ type: 'bigInt',
60
+ },
26
61
  {
27
62
  name: 'parentSpanId',
28
63
  type: 'string',
29
64
  length: 100,
30
65
  },
66
+ {
67
+ // Delegation depth of a sub-agent span: 1 for a sub-agent dispatched from a top-level
68
+ // conversation, parent depth + 1 below that. Persisted so a resumed child can never reset
69
+ // its depth, and the harness delegation.maxDepth cap is enforceable across restarts.
70
+ name: 'depth',
71
+ type: 'integer',
72
+ defaultValue: 0,
73
+ },
31
74
  {
32
75
  name: 'source',
33
76
  type: 'string',
@@ -186,5 +229,17 @@ export default defineCollection({
186
229
  {
187
230
  fields: ['userId'],
188
231
  },
232
+ {
233
+ fields: ['agentLoopRunId'],
234
+ },
235
+ {
236
+ fields: ['agentLoopStepId'],
237
+ },
238
+ {
239
+ fields: ['patternId'],
240
+ },
241
+ {
242
+ fields: ['approvalId'],
243
+ },
189
244
  ],
190
245
  });
@@ -0,0 +1,26 @@
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentHarnessProfileVersions',
5
+ title: 'Agent Harness Profile Versions',
6
+ fields: [
7
+ { name: 'id', type: 'bigInt', autoIncrement: true, primaryKey: true },
8
+ { name: 'profileId', type: 'bigInt', allowNull: false },
9
+ {
10
+ name: 'profile',
11
+ type: 'belongsTo',
12
+ target: 'agentHarnessProfiles',
13
+ foreignKey: 'profileId',
14
+ allowNull: false,
15
+ },
16
+ { name: 'version', type: 'integer', allowNull: false },
17
+ { name: 'schemaVersion', type: 'integer', allowNull: false, defaultValue: 1 },
18
+ { name: 'status', type: 'string', length: 20, allowNull: false, defaultValue: 'draft' },
19
+ { name: 'settings', type: 'json', allowNull: false, defaultValue: {} },
20
+ { name: 'publishedBy', type: 'belongsTo', target: 'users', foreignKey: 'publishedById' },
21
+ { name: 'publishedAt', type: 'date' },
22
+ { name: 'createdAt', type: 'date' },
23
+ { name: 'updatedAt', type: 'date' },
24
+ ],
25
+ indexes: [{ unique: true, fields: ['profileId', 'version'] }, { fields: ['profileId', 'status'] }],
26
+ });
@@ -1,59 +1,71 @@
1
- import { defineCollection } from '@nocobase/database';
2
-
3
- export default defineCollection({
4
- name: 'agentHarnessProfiles',
5
- title: 'Agent Harness Profiles',
6
- fields: [
7
- {
8
- name: 'id',
9
- type: 'bigInt',
10
- autoIncrement: true,
11
- primaryKey: true,
12
- },
13
- {
14
- name: 'tag',
15
- type: 'string',
16
- length: 100,
17
- allowNull: false,
18
- unique: true,
19
- comment: 'Stable policy profile tag used by native sub-agent observer and context injection.',
20
- },
21
- {
22
- name: 'title',
23
- type: 'string',
24
- length: 200,
25
- },
26
- {
27
- name: 'description',
28
- type: 'text',
29
- },
30
- {
31
- name: 'enabled',
32
- type: 'boolean',
33
- defaultValue: true,
34
- },
35
- {
36
- name: 'settings',
37
- type: 'json',
38
- defaultValue: {},
39
- comment: 'Policy settings such as native observer enablement, memory scopes, and tracing retention.',
40
- },
41
- {
42
- name: 'createdAt',
43
- type: 'date',
44
- },
45
- {
46
- name: 'updatedAt',
47
- type: 'date',
48
- },
49
- ],
50
- indexes: [
51
- {
52
- unique: true,
53
- fields: ['tag'],
54
- },
55
- {
56
- fields: ['enabled'],
57
- },
58
- ],
59
- });
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentHarnessProfiles',
5
+ title: 'Agent Harness Profiles',
6
+ fields: [
7
+ {
8
+ name: 'id',
9
+ type: 'bigInt',
10
+ autoIncrement: true,
11
+ primaryKey: true,
12
+ },
13
+ {
14
+ name: 'tag',
15
+ type: 'string',
16
+ length: 100,
17
+ allowNull: false,
18
+ unique: true,
19
+ comment: 'Stable policy profile tag used by native sub-agent observer and context injection.',
20
+ },
21
+ {
22
+ name: 'title',
23
+ type: 'string',
24
+ length: 200,
25
+ },
26
+ {
27
+ name: 'description',
28
+ type: 'text',
29
+ },
30
+ {
31
+ name: 'enabled',
32
+ type: 'boolean',
33
+ defaultValue: true,
34
+ },
35
+ {
36
+ name: 'schemaVersion',
37
+ type: 'integer',
38
+ allowNull: false,
39
+ defaultValue: 1,
40
+ },
41
+ {
42
+ name: 'currentVersion',
43
+ type: 'belongsTo',
44
+ target: 'agentHarnessProfileVersions',
45
+ foreignKey: 'currentVersionId',
46
+ },
47
+ {
48
+ name: 'settings',
49
+ type: 'json',
50
+ defaultValue: {},
51
+ comment: 'Policy settings such as native observer enablement, memory scopes, and tracing retention.',
52
+ },
53
+ {
54
+ name: 'createdAt',
55
+ type: 'date',
56
+ },
57
+ {
58
+ name: 'updatedAt',
59
+ type: 'date',
60
+ },
61
+ ],
62
+ indexes: [
63
+ {
64
+ unique: true,
65
+ fields: ['tag'],
66
+ },
67
+ {
68
+ fields: ['enabled'],
69
+ },
70
+ ],
71
+ });
@@ -0,0 +1,39 @@
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentLoopActionApprovals',
5
+ title: 'Agent Loop Action Approvals',
6
+ fields: [
7
+ { name: 'id', type: 'bigInt', autoIncrement: true, primaryKey: true },
8
+ { name: 'runId', type: 'bigInt', allowNull: false },
9
+ { name: 'run', type: 'belongsTo', target: 'agentLoopRuns', foreignKey: 'runId', allowNull: false },
10
+ { name: 'step', type: 'belongsTo', target: 'agentLoopSteps', foreignKey: 'stepId' },
11
+ { name: 'span', type: 'belongsTo', target: 'agentExecutionSpans', foreignKey: 'spanId' },
12
+ { name: 'toolCallId', type: 'string', length: 200, allowNull: false },
13
+ { name: 'toolName', type: 'string', length: 200, allowNull: false },
14
+ { name: 'actionType', type: 'string', length: 80 },
15
+ { name: 'proposedInput', type: 'json', defaultValue: {} },
16
+ { name: 'editedInput', type: 'json' },
17
+ { name: 'inputHash', type: 'string', length: 128, allowNull: false },
18
+ { name: 'paths', type: 'json', defaultValue: [] },
19
+ { name: 'policyDecision', type: 'json', defaultValue: {} },
20
+ { name: 'reason', type: 'text' },
21
+ { name: 'decisionNote', type: 'text' },
22
+ { name: 'status', type: 'string', length: 20, defaultValue: 'pending' },
23
+ { name: 'requestedBy', type: 'belongsTo', target: 'users', foreignKey: 'requestedById' },
24
+ { name: 'assignedToId', type: 'bigInt' },
25
+ { name: 'assignedTo', type: 'belongsTo', target: 'users', foreignKey: 'assignedToId' },
26
+ { name: 'decidedBy', type: 'belongsTo', target: 'users', foreignKey: 'decidedById' },
27
+ { name: 'requestedAt', type: 'date' },
28
+ { name: 'decidedAt', type: 'date' },
29
+ { name: 'expiresAt', type: 'date' },
30
+ { name: 'consumedAt', type: 'date' },
31
+ { name: 'createdAt', type: 'date' },
32
+ { name: 'updatedAt', type: 'date' },
33
+ ],
34
+ indexes: [
35
+ { unique: true, fields: ['runId', 'toolCallId', 'inputHash'] },
36
+ { fields: ['status', 'assignedToId'] },
37
+ { fields: ['runId'] },
38
+ ],
39
+ });
@@ -0,0 +1,25 @@
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentLoopArtifacts',
5
+ title: 'Agent Loop Artifacts',
6
+ fields: [
7
+ { name: 'id', type: 'bigInt', autoIncrement: true, primaryKey: true },
8
+ { name: 'runId', type: 'bigInt', allowNull: false },
9
+ { name: 'run', type: 'belongsTo', target: 'agentLoopRuns', foreignKey: 'runId', allowNull: false },
10
+ { name: 'stepId', type: 'bigInt' },
11
+ { name: 'step', type: 'belongsTo', target: 'agentLoopSteps', foreignKey: 'stepId' },
12
+ { name: 'span', type: 'belongsTo', target: 'agentExecutionSpans', foreignKey: 'spanId' },
13
+ { name: 'kind', type: 'string', length: 40, allowNull: false },
14
+ { name: 'title', type: 'string', length: 500 },
15
+ { name: 'uri', type: 'string', length: 2000 },
16
+ { name: 'contentHash', type: 'string', length: 128 },
17
+ { name: 'sizeBytes', type: 'bigInt', defaultValue: 0 },
18
+ { name: 'producerRole', type: 'string', length: 30 },
19
+ { name: 'producerUsername', type: 'string', length: 100 },
20
+ { name: 'metadata', type: 'json', defaultValue: {} },
21
+ { name: 'createdAt', type: 'date' },
22
+ { name: 'updatedAt', type: 'date' },
23
+ ],
24
+ indexes: [{ fields: ['runId', 'kind'] }, { fields: ['contentHash'] }, { fields: ['stepId'] }],
25
+ });
@@ -0,0 +1,23 @@
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentLoopCircuitStates',
5
+ title: 'Agent Loop Circuit States',
6
+ fields: [
7
+ { name: 'id', type: 'bigInt', autoIncrement: true, primaryKey: true },
8
+ { name: 'patternId', type: 'bigInt', allowNull: false },
9
+ { name: 'pattern', type: 'belongsTo', target: 'agentLoopPatterns', foreignKey: 'patternId', allowNull: false },
10
+ { name: 'scopeKey', type: 'string', length: 300, allowNull: false },
11
+ { name: 'state', type: 'string', length: 20, defaultValue: 'closed' },
12
+ { name: 'attempts', type: 'integer', defaultValue: 0 },
13
+ { name: 'consecutiveFailures', type: 'integer', defaultValue: 0 },
14
+ { name: 'errorSignature', type: 'string', length: 300 },
15
+ { name: 'repeatedErrorCount', type: 'integer', defaultValue: 0 },
16
+ { name: 'lastRunId', type: 'bigInt' },
17
+ { name: 'openedAt', type: 'date' },
18
+ { name: 'retryAt', type: 'date' },
19
+ { name: 'createdAt', type: 'date' },
20
+ { name: 'updatedAt', type: 'date' },
21
+ ],
22
+ indexes: [{ unique: true, fields: ['patternId', 'scopeKey'] }, { fields: ['state', 'retryAt'] }],
23
+ });
@@ -0,0 +1,21 @@
1
+ import { defineCollection } from '@nocobase/database';
2
+
3
+ export default defineCollection({
4
+ name: 'agentLoopControlSettings',
5
+ title: 'Agent Loop Control Settings',
6
+ fields: [
7
+ { name: 'id', type: 'bigInt', autoIncrement: true, primaryKey: true },
8
+ { name: 'key', type: 'string', length: 40, allowNull: false, unique: true, defaultValue: 'global' },
9
+ { name: 'acceptNewRuns', type: 'boolean', defaultValue: true },
10
+ { name: 'state', type: 'string', length: 20, defaultValue: 'running' },
11
+ { name: 'reason', type: 'text' },
12
+ { name: 'changedBy', type: 'belongsTo', target: 'users', foreignKey: 'changedById' },
13
+ { name: 'changedAt', type: 'date' },
14
+ { name: 'globalMaxConcurrency', type: 'integer', defaultValue: 5 },
15
+ { name: 'dailyMaxTokens', type: 'integer' },
16
+ { name: 'dailyMaxCost', type: 'float' },
17
+ { name: 'createdAt', type: 'date' },
18
+ { name: 'updatedAt', type: 'date' },
19
+ ],
20
+ indexes: [{ unique: true, fields: ['key'] }],
21
+ });