plugin-agent-orchestrator 1.1.3 → 1.1.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (218) hide show
  1. package/README.md +204 -114
  2. package/dist/client/index.js +1 -1
  3. package/dist/client-v2/117.7565cff57c39318a.js +10 -0
  4. package/dist/client-v2/214.106635011859dede.js +10 -0
  5. package/dist/client-v2/253.59577b40d9875be0.js +10 -0
  6. package/dist/client-v2/264.7ed8bee71fa5935c.js +10 -0
  7. package/dist/client-v2/{41.ba6e080cc0488143.js → 41.3deb9e57a0f64fc4.js} +1 -1
  8. package/dist/client-v2/418.41ed200e7d6da332.js +10 -0
  9. package/dist/client-v2/53.349fff8db80b19d4.js +10 -0
  10. package/dist/client-v2/619.0a2144aaffefe018.js +10 -0
  11. package/dist/client-v2/{70.bda9518881c05360.js → 70.ffff2997c10fd4b0.js} +1 -1
  12. package/dist/client-v2/{794.9bbb8d3a61b2bdf2.js → 794.a67a2614405ba627.js} +1 -1
  13. package/dist/client-v2/981.e4a1f41cfc94a856.js +10 -0
  14. package/dist/client-v2/{993.82778b6fd6db3cb1.js → 993.b0688fdc5ccb000a.js} +1 -1
  15. package/dist/client-v2/index.js +1 -1
  16. package/dist/externalVersion.js +8 -7
  17. package/dist/locale/en-US.json +199 -123
  18. package/dist/locale/vi-VN.json +199 -123
  19. package/dist/locale/zh-CN.json +199 -123
  20. package/dist/server/collections/agent-execution-spans.js +55 -0
  21. package/dist/server/collections/agent-harness-profile-versions.js +56 -0
  22. package/dist/server/collections/agent-harness-profiles.js +12 -0
  23. package/dist/server/collections/agent-loop-action-approvals.js +69 -0
  24. package/dist/server/collections/agent-loop-artifacts.js +55 -0
  25. package/dist/server/collections/agent-loop-circuit-states.js +53 -0
  26. package/dist/server/collections/agent-loop-control-settings.js +51 -0
  27. package/dist/server/collections/agent-loop-events.js +27 -0
  28. package/dist/server/collections/agent-loop-path-locks.js +57 -0
  29. package/dist/server/collections/agent-loop-patterns.js +72 -0
  30. package/dist/server/collections/agent-loop-runs.js +170 -3
  31. package/dist/server/collections/agent-loop-steps.js +76 -0
  32. package/dist/server/collections/agent-loop-usage-buckets.js +52 -0
  33. package/dist/server/collections/agent-loop-worktrees.js +55 -0
  34. package/dist/server/collections/skill-executions.js +8 -0
  35. package/dist/server/migrations/{20260427000000-change-packages-to-text.js → 20260427000002-change-packages-to-text.js} +2 -0
  36. package/dist/server/migrations/20260429000000-add-llm-fields.js +3 -2
  37. package/dist/server/migrations/{20260429000000-fix-inputargs-json-to-text.js → 20260429000001-fix-inputargs-json-to-text.js} +14 -6
  38. package/dist/server/migrations/20260503000000-add-orchestrator-trace-fields.js +2 -1
  39. package/dist/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.js +2 -1
  40. package/dist/server/migrations/20260803010000-backfill-loop-control-plane-data.js +262 -0
  41. package/dist/server/plugin.js +54 -150
  42. package/dist/server/resources/agent-harness-profile.js +117 -0
  43. package/dist/server/resources/agent-knowledge-insights.js +1 -3
  44. package/dist/server/resources/agent-loop-approval.js +108 -0
  45. package/dist/server/resources/agent-loop-artifact.js +86 -0
  46. package/dist/server/resources/agent-loop-events-stream.js +130 -0
  47. package/dist/server/resources/agent-loop.js +183 -139
  48. package/dist/server/resources/resource-helpers.js +63 -0
  49. package/dist/server/resources/tracing.js +121 -107
  50. package/dist/server/services/AgentMemoryContextService.js +34 -0
  51. package/dist/server/services/DurableCircuitBreakerService.js +229 -0
  52. package/dist/server/services/HarnessCompiler.js +175 -0
  53. package/dist/server/services/HarnessProfileService.js +233 -0
  54. package/dist/server/services/HarnessSchema.js +194 -0
  55. package/dist/server/services/LoopBudgetService.js +269 -0
  56. package/dist/server/services/LoopControlService.js +139 -0
  57. package/dist/server/services/LoopPatternSchema.js +195 -0
  58. package/dist/server/services/LoopPatternService.js +132 -0
  59. package/dist/server/services/LoopRunRepository.js +285 -0
  60. package/dist/server/services/LoopRunStateMachine.js +478 -0
  61. package/dist/server/services/LoopSchedulerService.js +193 -0
  62. package/dist/server/services/LoopTriggerService.js +165 -0
  63. package/dist/server/services/LoopWorkerService.js +699 -0
  64. package/dist/server/services/NativeSubAgentObserver.js +165 -23
  65. package/dist/server/services/PathLockService.js +288 -0
  66. package/dist/server/services/PluginAiRuntimeAdapter.js +226 -0
  67. package/dist/server/services/ToolLoopDetectionService.js +210 -0
  68. package/dist/server/services/VerificationSchema.js +59 -0
  69. package/dist/server/services/VerificationService.js +235 -0
  70. package/dist/server/services/harness-runtime-policy.js +139 -0
  71. package/dist/server/skill-hub/actions/git-import.js +13 -7
  72. package/dist/server/skill-hub/plugin.js +36 -3
  73. package/dist/server/skill-hub/services/RegistrySkillSnapshotService.js +1 -5
  74. package/dist/server/skill-hub/tasks/SkillExecutionTask.js +29 -0
  75. package/dist/server/utils/ensure-indexes.js +111 -0
  76. package/dist/server/utils/loop-pattern-context.js +56 -0
  77. package/package.json +53 -53
  78. package/src/client/ApprovalsTab.tsx +2 -0
  79. package/src/client/OrchestratorSettings.tsx +55 -0
  80. package/src/client/skill-hub/components/GitSkillImport.tsx +3 -3
  81. package/src/client/skill-hub/components/SkillMetrics.tsx +15 -10
  82. package/src/client/skill-hub/index.tsx +0 -52
  83. package/src/client-v2/components/AgentRunsTab.tsx +100 -18
  84. package/src/client-v2/components/ApprovalsTab.tsx +337 -0
  85. package/src/client-v2/components/HarnessProfilesTab.tsx +385 -100
  86. package/src/client-v2/components/MemoryInspectorTab.tsx +141 -125
  87. package/src/client-v2/components/TracingTab.tsx +160 -77
  88. package/src/client-v2/hooks/useApiRequest.ts +28 -8
  89. package/src/client-v2/pages/ApprovalsPage.tsx +10 -0
  90. package/src/client-v2/plugin.tsx +6 -6
  91. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +11 -6
  92. package/src/locale/en-US.json +199 -123
  93. package/src/locale/vi-VN.json +199 -123
  94. package/src/locale/zh-CN.json +199 -123
  95. package/src/server/__tests__/circuit-breaker.test.ts +248 -169
  96. package/src/server/__tests__/harness-compiler.test.ts +214 -0
  97. package/src/server/__tests__/harness-profile-service.test.ts +167 -0
  98. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -0
  99. package/src/server/__tests__/harness-tool-plan.test.ts +172 -0
  100. package/src/server/__tests__/loop-approval-decision.test.ts +512 -0
  101. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -0
  102. package/src/server/__tests__/loop-budget-service.test.ts +255 -0
  103. package/src/server/__tests__/loop-control-plane-backfill.test.ts +266 -0
  104. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -0
  105. package/src/server/__tests__/loop-pattern-service.test.ts +148 -0
  106. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -0
  107. package/src/server/__tests__/loop-trigger-service.test.ts +148 -0
  108. package/src/server/__tests__/loop-worker-claim.test.ts +341 -0
  109. package/src/server/__tests__/loop-worker-execution.test.ts +317 -0
  110. package/src/server/__tests__/native-sub-agent-observer.test.ts +288 -4
  111. package/src/server/__tests__/path-lock-service.test.ts +254 -0
  112. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -0
  113. package/src/server/__tests__/smoke.test.ts +162 -121
  114. package/src/server/__tests__/tool-loop-detection.test.ts +275 -0
  115. package/src/server/collections/agent-execution-spans.ts +55 -0
  116. package/src/server/collections/agent-harness-profile-versions.ts +26 -0
  117. package/src/server/collections/agent-harness-profiles.ts +71 -59
  118. package/src/server/collections/agent-loop-action-approvals.ts +39 -0
  119. package/src/server/collections/agent-loop-artifacts.ts +25 -0
  120. package/src/server/collections/agent-loop-circuit-states.ts +23 -0
  121. package/src/server/collections/agent-loop-control-settings.ts +21 -0
  122. package/src/server/collections/agent-loop-events.ts +98 -71
  123. package/src/server/collections/agent-loop-path-locks.ts +27 -0
  124. package/src/server/collections/agent-loop-patterns.ts +42 -0
  125. package/src/server/collections/agent-loop-runs.ts +170 -3
  126. package/src/server/collections/agent-loop-steps.ts +76 -0
  127. package/src/server/collections/agent-loop-usage-buckets.ts +22 -0
  128. package/src/server/collections/agent-loop-worktrees.ts +25 -0
  129. package/src/server/collections/skill-executions.ts +8 -0
  130. package/src/server/migrations/{20260427000000-change-packages-to-text.ts → 20260427000002-change-packages-to-text.ts} +52 -49
  131. package/src/server/migrations/20260429000000-add-llm-fields.ts +47 -46
  132. package/src/server/migrations/{20260429000000-fix-inputargs-json-to-text.ts → 20260429000001-fix-inputargs-json-to-text.ts} +45 -38
  133. package/src/server/migrations/20260503000000-add-orchestrator-trace-fields.ts +33 -32
  134. package/src/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.ts +31 -30
  135. package/src/server/migrations/20260803010000-backfill-loop-control-plane-data.ts +293 -0
  136. package/src/server/plugin.ts +55 -167
  137. package/src/server/resources/agent-harness-profile.ts +94 -0
  138. package/src/server/resources/agent-knowledge-insights.ts +5 -3
  139. package/src/server/resources/agent-loop-approval.ts +84 -0
  140. package/src/server/resources/agent-loop-artifact.ts +56 -0
  141. package/src/server/resources/agent-loop-events-stream.ts +105 -0
  142. package/src/server/resources/agent-loop.ts +204 -143
  143. package/src/server/resources/agent-monitor.ts +482 -482
  144. package/src/server/resources/resource-helpers.ts +33 -0
  145. package/src/server/resources/tracing.ts +266 -258
  146. package/src/server/services/AgentMemoryContextService.ts +44 -0
  147. package/src/server/services/DurableCircuitBreakerService.ts +239 -0
  148. package/src/server/services/ExecutionSpanService.ts +2 -0
  149. package/src/server/services/HarnessCompiler.ts +170 -0
  150. package/src/server/services/HarnessProfileService.ts +239 -0
  151. package/src/server/services/HarnessSchema.ts +194 -0
  152. package/src/server/services/LoopBudgetService.ts +275 -0
  153. package/src/server/services/LoopControlService.ts +124 -0
  154. package/src/server/services/LoopPatternSchema.ts +185 -0
  155. package/src/server/services/LoopPatternService.ts +143 -0
  156. package/src/server/services/LoopRunRepository.ts +336 -0
  157. package/src/server/services/LoopRunStateMachine.ts +529 -0
  158. package/src/server/services/LoopSchedulerService.ts +199 -0
  159. package/src/server/services/LoopTriggerService.ts +157 -0
  160. package/src/server/services/LoopWorkerService.ts +822 -0
  161. package/src/server/services/NativeSubAgentObserver.ts +186 -21
  162. package/src/server/services/PathLockService.ts +321 -0
  163. package/src/server/services/PluginAiRuntimeAdapter.ts +332 -0
  164. package/src/server/services/ToolLoopDetectionService.ts +213 -0
  165. package/src/server/services/VerificationSchema.ts +31 -0
  166. package/src/server/services/VerificationService.ts +264 -0
  167. package/src/server/services/harness-runtime-policy.ts +141 -0
  168. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +15 -1
  169. package/src/server/skill-hub/actions/git-import.ts +9 -3
  170. package/src/server/skill-hub/plugin.ts +41 -3
  171. package/src/server/skill-hub/services/RegistrySkillSnapshotService.ts +235 -239
  172. package/src/server/skill-hub/services/__tests__/RegistrySkillSnapshotService.test.ts +61 -63
  173. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +43 -2
  174. package/src/server/utils/ensure-indexes.ts +96 -0
  175. package/src/server/utils/logging.ts +62 -63
  176. package/src/server/utils/loop-pattern-context.ts +20 -0
  177. package/dist/client-v2/214.79650a549273f163.js +0 -10
  178. package/dist/client-v2/253.9f0537713cee9e6c.js +0 -10
  179. package/dist/client-v2/264.718a107e43fc163c.js +0 -10
  180. package/dist/client-v2/373.f5d5292e53c4e832.js +0 -10
  181. package/dist/client-v2/418.ce8f5b2b8a229d1d.js +0 -10
  182. package/dist/client-v2/53.7c29c28043e9112d.js +0 -10
  183. package/dist/client-v2/619.bd3c5698b40705c3.js +0 -10
  184. package/dist/client-v2/677.a991ce0250ff5c77.js +0 -10
  185. package/dist/client-v2/925.f5370de8f6632d65.js +0 -10
  186. package/dist/server/services/AgentHarness.js +0 -81
  187. package/dist/server/services/AgentLoopController.js +0 -1023
  188. package/dist/server/services/AgentLoopRepository.js +0 -192
  189. package/dist/server/services/AgentLoopService.js +0 -142
  190. package/dist/server/services/AgentPlanValidator.js +0 -99
  191. package/dist/server/services/AgentPlannerService.js +0 -99
  192. package/dist/server/services/CircuitBreaker.js +0 -125
  193. package/dist/server/services/ContextAggregator.js +0 -201
  194. package/dist/server/services/PlanningPromptService.js +0 -95
  195. package/dist/server/tools/agent-loop.js +0 -373
  196. package/dist/server/tools/orchestrator-plan.js +0 -254
  197. package/src/client/AIEmployeeSelect.tsx +0 -47
  198. package/src/client/AIEmployeesContext.tsx +0 -102
  199. package/src/client/RulesTab.tsx +0 -2
  200. package/src/client/TracingTab.tsx +0 -436
  201. package/src/client/skill-hub/components/ExecutionProgress.tsx +0 -51
  202. package/src/client-v2/components/RulesTab.tsx +0 -2
  203. package/src/client-v2/pages/AgentRunsPage.tsx +0 -13
  204. package/src/server/__tests__/agent-loop-controller.test.ts +0 -375
  205. package/src/server/__tests__/context-aggregator.test.ts +0 -222
  206. package/src/server/__tests__/parallel-execution.test.ts +0 -318
  207. package/src/server/__tests__/planning-prompt-service.test.ts +0 -23
  208. package/src/server/services/AgentHarness.ts +0 -67
  209. package/src/server/services/AgentLoopController.ts +0 -1263
  210. package/src/server/services/AgentLoopRepository.ts +0 -178
  211. package/src/server/services/AgentLoopService.ts +0 -177
  212. package/src/server/services/AgentPlanValidator.ts +0 -73
  213. package/src/server/services/AgentPlannerService.ts +0 -80
  214. package/src/server/services/CircuitBreaker.ts +0 -126
  215. package/src/server/services/ContextAggregator.ts +0 -239
  216. package/src/server/services/PlanningPromptService.ts +0 -72
  217. package/src/server/tools/agent-loop.ts +0 -360
  218. package/src/server/tools/orchestrator-plan.ts +0 -255
@@ -0,0 +1,317 @@
1
+ import type { Database } from '@nocobase/database';
2
+ import type { Application } from '@nocobase/server';
3
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
4
+ import { compileHarness } from '../services/HarnessCompiler';
5
+ import type { CompiledHarness } from '../services/HarnessCompiler';
6
+ import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
7
+
8
+ type Row = Record<string, unknown>;
9
+
10
+ type InvokeCall = {
11
+ username: string;
12
+ systemMessage: string;
13
+ prompt: string;
14
+ harness: CompiledHarness;
15
+ };
16
+
17
+ const invokeCalls: InvokeCall[] = [];
18
+ const verifyCalls: Array<{ makerSummary: string; makerUsernames: string[] }> = [];
19
+ let onInvoke: ((call: InvokeCall) => Promise<void>) | null = null;
20
+
21
+ vi.mock('../services/PluginAiRuntimeAdapter', () => ({
22
+ PluginAiRuntimeAdapter: class {
23
+ async createConversation() {
24
+ return 'session-1';
25
+ }
26
+ async invoke(input: InvokeCall) {
27
+ invokeCalls.push(input);
28
+ if (onInvoke) await onInvoke(input);
29
+ return { sessionId: 'session-1', messageId: 'message-1', interrupted: [], content: `${input.username} done` };
30
+ }
31
+ },
32
+ }));
33
+
34
+ vi.mock('../services/VerificationService', () => ({
35
+ VerificationService: class {
36
+ async verifyAndFinalize(input: { makerSummary: string; makerUsernames: string[] }) {
37
+ verifyCalls.push({ makerSummary: input.makerSummary, makerUsernames: input.makerUsernames });
38
+ return { verdict: { verdict: 'pass' }, finalStatus: 'succeeded' as const };
39
+ }
40
+ },
41
+ }));
42
+
43
+ const { LoopWorkerService } = await import('../services/LoopWorkerService');
44
+
45
+ class MemoryRepository {
46
+ private nextId = 1;
47
+
48
+ constructor(readonly rows: Row[] = []) {
49
+ this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
50
+ }
51
+
52
+ async find(options: Row = {}) {
53
+ const filter = (options.filter as Row | undefined) || {};
54
+ return this.rows.filter((row) =>
55
+ Object.entries(filter).every(([key, value]) => {
56
+ if (value && typeof value === 'object' && Array.isArray((value as Row).$in)) {
57
+ return ((value as Row).$in as unknown[]).includes(row[key]);
58
+ }
59
+ return row[key] === value;
60
+ }),
61
+ );
62
+ }
63
+
64
+ async findOne(options: Row) {
65
+ if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
66
+ return (await this.find(options))[0] || null;
67
+ }
68
+
69
+ async create(options: Row) {
70
+ const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
71
+ this.rows.push(row);
72
+ return row;
73
+ }
74
+
75
+ async update(options: Row) {
76
+ const values = (options.values as Row | undefined) || {};
77
+ for (const row of this.rows) {
78
+ if (row.id === options.filterByTk) Object.assign(row, values);
79
+ }
80
+ }
81
+ }
82
+
83
+ function harnessSnapshot(allow: string[]) {
84
+ return { effective: compileHarness([{ source: 'test', settings: { tools: { allow } } }]) };
85
+ }
86
+
87
+ const policy = loopPatternPolicySchema.parse({ maxConcurrency: 1 });
88
+
89
+ function createWorker(run: Row) {
90
+ const repositories = new Map<string, MemoryRepository>([
91
+ [
92
+ 'agentLoopControlSettings',
93
+ new MemoryRepository([{ id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 }]),
94
+ ],
95
+ ['agentLoopRuns', new MemoryRepository([{ ...run }])],
96
+ ['agentLoopEvents', new MemoryRepository()],
97
+ ['agentLoopSteps', new MemoryRepository()],
98
+ ['aiMessages', new MemoryRepository()],
99
+ ['agentLoopUsageBuckets', new MemoryRepository()],
100
+ ['agentLoopCircuitStates', new MemoryRepository()],
101
+ ['agentLoopPathLocks', new MemoryRepository()],
102
+ ['agentLoopArtifacts', new MemoryRepository()],
103
+ ]);
104
+ const database = {
105
+ getRepository(name: string) {
106
+ const repository = repositories.get(name);
107
+ if (!repository) throw new Error(`Unexpected repository ${name}`);
108
+ return repository;
109
+ },
110
+ sequelize: {
111
+ transaction<T>(callback: (value: { LOCK: { UPDATE: string } }) => Promise<T>) {
112
+ return callback({ LOCK: { UPDATE: 'UPDATE' } });
113
+ },
114
+ },
115
+ };
116
+ const app = {
117
+ name: 'test',
118
+ logger: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
119
+ log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
120
+ lockManager: { runExclusive: <T>(_key: string, operation: () => Promise<T>) => operation() },
121
+ };
122
+ const worker = new LoopWorkerService(app as unknown as Application, database as unknown as Database);
123
+ return { repositories, worker: worker as unknown as WorkerInternals, service: worker };
124
+ }
125
+
126
+ type WorkerInternals = {
127
+ execute(claimed: { run: Row; leaseToken: string; leaseUntil: Date }): Promise<void>;
128
+ heartbeat(runId: number, leaseToken: string): Promise<void>;
129
+ };
130
+
131
+ function claimedRun(run: Row) {
132
+ return { run, leaseToken: 'worker-a:lease', leaseUntil: new Date(Date.now() + 60_000) };
133
+ }
134
+
135
+ function baseRun(overrides: Row = {}) {
136
+ return {
137
+ id: 1,
138
+ runtimeVersion: 'control-plane-v2',
139
+ patternId: 1,
140
+ status: 'preparing',
141
+ lockedBy: 'worker-a:lease',
142
+ lockedUntil: new Date(Date.now() + 60_000),
143
+ goal: 'Ship the feature',
144
+ autonomyLevel: 'L1',
145
+ policySnapshot: policy,
146
+ roleBindingsSnapshot: { leader: 'lead', makers: ['maker-one', 'maker-two'], verifier: 'checker' },
147
+ leaderHarnessSnapshot: harnessSnapshot(['readFile']),
148
+ makerHarnessSnapshot: {
149
+ 'maker-one': harnessSnapshot(['editFile']),
150
+ 'maker-two': harnessSnapshot(['runTests']),
151
+ },
152
+ verifierHarnessSnapshot: harnessSnapshot(['readFile']),
153
+ repositoryKey: '',
154
+ actingOn: [],
155
+ ...overrides,
156
+ };
157
+ }
158
+
159
+ beforeEach(() => {
160
+ invokeCalls.length = 0;
161
+ verifyCalls.length = 0;
162
+ onInvoke = null;
163
+ });
164
+
165
+ describe('LoopWorkerService maker execution', () => {
166
+ it('invokes every maker with its own compiled harness snapshot', async () => {
167
+ const run = baseRun();
168
+ const { worker } = createWorker(run);
169
+
170
+ await worker.execute(claimedRun(run));
171
+
172
+ // Before the fix the worker went leader -> verifier and `makerHarnessSnapshot` was never read,
173
+ // so per-maker tool grants had no runtime effect at all.
174
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
175
+ expect(invokeCalls[1].harness.tools.allow).toEqual(['editFile']);
176
+ expect(invokeCalls[2].harness.tools.allow).toEqual(['runTests']);
177
+ expect(invokeCalls[1].prompt).toContain('lead done');
178
+ });
179
+
180
+ it('aggregates every maker report into the summary handed to the verifier', async () => {
181
+ const run = baseRun();
182
+ const { worker } = createWorker(run);
183
+
184
+ await worker.execute(claimedRun(run));
185
+
186
+ expect(verifyCalls).toHaveLength(1);
187
+ expect(verifyCalls[0].makerUsernames).toEqual(['maker-one', 'maker-two']);
188
+ expect(verifyCalls[0].makerSummary).toContain('# maker-one');
189
+ expect(verifyCalls[0].makerSummary).toContain('# maker-two');
190
+ });
191
+
192
+ it('fails the run when a bound maker has no harness snapshot', async () => {
193
+ const run = baseRun({ makerHarnessSnapshot: { 'maker-one': harnessSnapshot(['editFile']) } });
194
+ const { repositories, worker } = createWorker(run);
195
+
196
+ await worker.execute(claimedRun(run));
197
+
198
+ // A missing snapshot must not silently skip the maker: that would run the loop with fewer
199
+ // participants than the pattern declared.
200
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('failed');
201
+ expect(String(repositories.get('agentLoopRuns')?.rows[0].summary)).toContain('maker-two');
202
+ expect(verifyCalls).toHaveLength(0);
203
+ });
204
+ });
205
+
206
+ describe('LoopWorkerService path lock lifecycle', () => {
207
+ it('renews the path lock on the same beat as the worker lease', async () => {
208
+ const run = baseRun({ repositoryKey: 'repo', actingOn: ['src/a/**'] });
209
+ const { repositories, worker } = createWorker(run);
210
+ const renewedAt: Array<string | undefined> = [];
211
+
212
+ onInvoke = async () => {
213
+ const before = repositories.get('agentLoopPathLocks')?.rows[0];
214
+ await worker.heartbeat(1, 'worker-a:lease');
215
+ const after = repositories.get('agentLoopPathLocks')?.rows[0];
216
+ renewedAt.push(String(after?.expiresAt));
217
+ expect(String(after?.expiresAt)).not.toBe(String(before?.expiresAt));
218
+ onInvoke = null;
219
+ };
220
+
221
+ await worker.execute(claimedRun(run));
222
+
223
+ // The lock TTL is longer than the lease, but a run can outlive it. Without renewal the lock
224
+ // lapses mid-run and another run becomes free to take the same paths.
225
+ expect(renewedAt).toHaveLength(1);
226
+ expect(repositories.get('agentLoopPathLocks')?.rows[0]).toMatchObject({ status: 'released' });
227
+ });
228
+
229
+ it('releases only the lock this worker still owns', async () => {
230
+ const run = baseRun({ repositoryKey: 'repo', actingOn: ['src/a/**'] });
231
+ const { repositories, worker } = createWorker(run);
232
+
233
+ onInvoke = async () => {
234
+ // Another worker reclaimed the run and re-took the lock while this one was mid-invocation.
235
+ const lock = repositories.get('agentLoopPathLocks')?.rows[0];
236
+ if (lock) lock.owner = 'worker-b:lease';
237
+ onInvoke = null;
238
+ };
239
+
240
+ await worker.execute(claimedRun(run));
241
+
242
+ expect(repositories.get('agentLoopPathLocks')?.rows[0]).toMatchObject({ status: 'held', owner: 'worker-b:lease' });
243
+ });
244
+ });
245
+
246
+ describe('LoopWorkerService tool loop guard', () => {
247
+ function seedIdenticalCalls(repositories: Map<string, MemoryRepository>, count: number) {
248
+ const messages = repositories.get('aiMessages');
249
+ if (!messages) throw new Error('aiMessages repository missing');
250
+ onInvoke = async (call) => {
251
+ if (call.username !== 'lead') return;
252
+ for (let index = 0; index < count; index += 1) {
253
+ await messages.create({
254
+ values: {
255
+ sessionId: 'session-1',
256
+ role: 'assistant',
257
+ toolCalls: [{ id: `call-${index}`, name: 'searchDocs', args: { query: 'loop' } }],
258
+ },
259
+ });
260
+ }
261
+ onInvoke = null;
262
+ };
263
+ }
264
+
265
+ it('warns later prompts and records one guard step at the warn threshold', async () => {
266
+ const run = baseRun();
267
+ const { repositories, worker } = createWorker(run);
268
+ seedIdenticalCalls(repositories, 3);
269
+
270
+ await worker.execute(claimedRun(run));
271
+
272
+ const makerPrompt = invokeCalls[1]?.prompt || '';
273
+ expect(makerPrompt).toContain('<tool_loop_warning>');
274
+ expect(makerPrompt).toContain('searchDocs');
275
+
276
+ const guardSteps = (repositories.get('agentLoopSteps')?.rows || []).filter((step) => step.kind === 'guard');
277
+ // Recorded once on first observation; later passes see the same signature and skip it.
278
+ expect(guardSteps).toHaveLength(1);
279
+ expect(guardSteps[0]).toMatchObject({ type: 'tool_loop', toolName: 'searchDocs', role: 'leader' });
280
+
281
+ const loopEvents = (repositories.get('agentLoopEvents')?.rows || []).filter(
282
+ (event) => event.type === 'tool_loop_detected',
283
+ );
284
+ expect(loopEvents).toHaveLength(1);
285
+
286
+ // A warning alone must not stop the run.
287
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
288
+ expect(verifyCalls).toHaveLength(1);
289
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
290
+ });
291
+
292
+ it('blocks the run at the block threshold before any further pass', async () => {
293
+ const run = baseRun();
294
+ const { repositories, worker } = createWorker(run);
295
+ seedIdenticalCalls(repositories, 5);
296
+
297
+ await worker.execute(claimedRun(run));
298
+
299
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead']);
300
+ expect(verifyCalls).toHaveLength(0);
301
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'blocked' });
302
+ expect(String(repositories.get('agentLoopRuns')?.rows[0].blockedReason)).toContain('searchDocs');
303
+ });
304
+
305
+ it('escalates the run to a human at the escalate threshold', async () => {
306
+ const run = baseRun();
307
+ const { repositories, worker } = createWorker(run);
308
+ seedIdenticalCalls(repositories, 8);
309
+
310
+ await worker.execute(claimedRun(run));
311
+
312
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead']);
313
+ expect(verifyCalls).toHaveLength(0);
314
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'waiting_human' });
315
+ expect(String(repositories.get('agentLoopRuns')?.rows[0].escalationReason)).toContain('searchDocs');
316
+ });
317
+ });
@@ -1,7 +1,20 @@
1
- import { describe, expect, it, vi } from 'vitest';
1
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
2
+ import { writeFileSync } from 'fs';
2
3
  import { AgentMemoryContextService } from '../services/AgentMemoryContextService';
4
+ import { compileHarness } from '../services/HarnessCompiler';
3
5
  import { NativeSubAgentObserver } from '../services/NativeSubAgentObserver';
4
6
  import { getAgentExecutionContext } from '../services/AgentExecutionContext';
7
+ import { REDACTED_PLACEHOLDER } from '../services/harness-runtime-policy';
8
+
9
+ // The observer spills oversized sub-agent results to storage; keep tests side-effect free.
10
+ vi.mock('fs', async (importOriginal) => {
11
+ const actual = await importOriginal<typeof import('fs')>();
12
+ return {
13
+ ...actual,
14
+ mkdirSync: vi.fn(),
15
+ writeFileSync: vi.fn(),
16
+ };
17
+ });
5
18
 
6
19
  function createObserverHarness(
7
20
  profileSettings: Record<string, unknown> | null = {},
@@ -10,6 +23,14 @@ function createObserverHarness(
10
23
  orchestratorConfig?: unknown;
11
24
  knowledgeBasePlugin?: unknown;
12
25
  toolCallResult?: unknown;
26
+ toolCallArgs?: Record<string, unknown>;
27
+ runResult?: string;
28
+ parentConversation?: Record<string, unknown>;
29
+ loopRuns?: Record<number, Record<string, unknown>>;
30
+ spanFindOne?: (query: {
31
+ filterByTk?: string | number;
32
+ filter?: Record<string, unknown>;
33
+ }) => Promise<Record<string, unknown> | null>;
13
34
  } = {},
14
35
  ) {
15
36
  let nextSpanId = 1;
@@ -18,6 +39,7 @@ function createObserverHarness(
18
39
  const spanRepo = {
19
40
  create: vi.fn(async ({ values }) => ({ id: nextSpanId++, ...values })),
20
41
  update: vi.fn(async () => ({})),
42
+ findOne: options.spanFindOne ? vi.fn(options.spanFindOne) : undefined,
21
43
  };
22
44
  const skillExecutionRepo = {
23
45
  update: vi.fn(async () => ({})),
@@ -31,7 +53,7 @@ function createObserverHarness(
31
53
  toolCall: {
32
54
  id: 'tool-1',
33
55
  name: 'skill_hub_execute',
34
- args: { input: 'x' },
56
+ args: options.toolCallArgs ?? { input: 'x' },
35
57
  messageId: 'msg-1',
36
58
  },
37
59
  },
@@ -60,7 +82,7 @@ function createObserverHarness(
60
82
  from: 'sub-agent',
61
83
  },
62
84
  });
63
- return `answer:${task.question}`;
85
+ return options.runResult ?? `answer:${task.question}`;
64
86
  });
65
87
  const dispatcher = { run: originalRun };
66
88
  const repos: Record<string, unknown> = {
@@ -83,10 +105,13 @@ function createObserverHarness(
83
105
  aiConversations: {
84
106
  findOne: vi.fn(async ({ filter }) =>
85
107
  filter?.sessionId === 'parent-session'
86
- ? { sessionId: 'parent-session', aiEmployeeUsername: 'leader', userId: 7 }
108
+ ? options.parentConversation ?? { sessionId: 'parent-session', aiEmployeeUsername: 'leader', userId: 7 }
87
109
  : null,
88
110
  ),
89
111
  },
112
+ agentLoopRuns: {
113
+ findOne: vi.fn(async ({ filterByTk }) => options.loopRuns?.[Number(filterByTk)] ?? null),
114
+ },
90
115
  orchestratorConfig: {
91
116
  findOne: vi.fn(async () => options.orchestratorConfig ?? null),
92
117
  },
@@ -344,6 +369,59 @@ describe('AgentMemoryContextService', () => {
344
369
  service.resolvePolicySettings({ ctx: createTask().ctx, employee: { username: 'sub-agent' } }),
345
370
  ).resolves.toEqual(expect.objectContaining({ harnessTag: 'safe', maxMemoryContextChars: 1200 }));
346
371
  });
372
+
373
+ it('prefers the published version over raw row settings and flattens the contract', async () => {
374
+ const versionSettings = {
375
+ memory: { enabled: true, scopes: ['public'], maxChars: 1500 },
376
+ observability: { enabled: true, tracingRetentionDays: 7 },
377
+ };
378
+ const plugin = {
379
+ app: { logger: { warn: vi.fn() }, pm: { get: vi.fn() } },
380
+ db: {
381
+ getRepository: vi.fn((name: string) => {
382
+ if (name === 'agentHarnessProfiles') {
383
+ return {
384
+ findOne: vi.fn(async ({ filter }: { filter: { tag: string } }) =>
385
+ filter.tag === 'strict' ? { id: 1, tag: 'strict', enabled: true, currentVersionId: 5 } : null,
386
+ ),
387
+ };
388
+ }
389
+ if (name === 'agentHarnessProfileVersions') {
390
+ return {
391
+ findOne: vi.fn(async ({ filter }: { filter: { id: number; status: string } }) =>
392
+ filter.id === 5 && filter.status === 'published'
393
+ ? {
394
+ id: 5,
395
+ profileId: 1,
396
+ version: 2,
397
+ schemaVersion: 1,
398
+ status: 'published',
399
+ settings: versionSettings,
400
+ }
401
+ : null,
402
+ ),
403
+ };
404
+ }
405
+ return null;
406
+ }),
407
+ },
408
+ };
409
+ const service = new AgentMemoryContextService(plugin);
410
+
411
+ const settings = await service.resolvePolicySettings({
412
+ ctx: { action: { params: { values: { harnessTag: 'strict' } } } },
413
+ employee: { username: 'sub-agent' },
414
+ });
415
+
416
+ expect(settings).toMatchObject({
417
+ harnessTag: 'strict',
418
+ memoryInjectionEnabled: true,
419
+ memoryScopes: ['public'],
420
+ maxMemoryContextChars: 1500,
421
+ nativeObserverEnabled: true,
422
+ tracingRetentionDays: 7,
423
+ });
424
+ });
347
425
  });
348
426
 
349
427
  describe('NativeSubAgentObserver memory injection', () => {
@@ -376,3 +454,209 @@ describe('NativeSubAgentObserver memory injection', () => {
376
454
  expect(runWithAgentContext).toHaveBeenCalledWith('sub-agent', expect.any(Function));
377
455
  });
378
456
  });
457
+
458
+ describe('NativeSubAgentObserver harness policy', () => {
459
+ beforeEach(() => {
460
+ vi.mocked(writeFileSync).mockClear();
461
+ });
462
+
463
+ it('persists no spans at all when sharing is disabled', async () => {
464
+ const { plugin, dispatcher, originalRun, spanRepo } = createObserverHarness({
465
+ observability: { sharing: 'disabled' },
466
+ });
467
+ const observer = new NativeSubAgentObserver(plugin);
468
+ observer.install();
469
+
470
+ const result = await dispatcher.run(createTask());
471
+
472
+ expect(result).toBe('answer:do the work');
473
+ expect(originalRun).toHaveBeenCalledTimes(1);
474
+ expect(spanRepo.create).not.toHaveBeenCalled();
475
+ expect(spanRepo.update).not.toHaveBeenCalled();
476
+ });
477
+
478
+ it('captures outputs but omits inputs under feedback-only sharing', async () => {
479
+ const { plugin, dispatcher, spanRepo } = createObserverHarness({
480
+ observability: { sharing: 'feedback-only' },
481
+ });
482
+ const observer = new NativeSubAgentObserver(plugin);
483
+ observer.install();
484
+
485
+ await dispatcher.run(createTask());
486
+
487
+ const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
488
+ const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
489
+ expect(rootSpanValues.input).toBeUndefined();
490
+ expect(toolSpanValues.input).toBeUndefined();
491
+ const toolSpanUpdate = spanRepo.update.mock.calls[0][0].values;
492
+ expect(toolSpanUpdate.output).toBeDefined();
493
+ });
494
+
495
+ it('redacts secret-looking keys in captured tool args by default', async () => {
496
+ const { plugin, dispatcher, spanRepo } = createObserverHarness(
497
+ {},
498
+ { toolCallArgs: { apiKey: 'secret-value', path: '/tmp/x' } },
499
+ );
500
+ const observer = new NativeSubAgentObserver(plugin);
501
+ observer.install();
502
+
503
+ await dispatcher.run(createTask());
504
+
505
+ const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
506
+ expect(toolSpanValues.input).toEqual({ apiKey: REDACTED_PLACEHOLDER, path: '/tmp/x' });
507
+ });
508
+
509
+ it('keeps raw tool args when the profile disables redaction', async () => {
510
+ const { plugin, dispatcher, spanRepo } = createObserverHarness(
511
+ { observability: { redactSecrets: false } },
512
+ { toolCallArgs: { apiKey: 'secret-value' } },
513
+ );
514
+ const observer = new NativeSubAgentObserver(plugin);
515
+ observer.install();
516
+
517
+ await dispatcher.run(createTask());
518
+
519
+ const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
520
+ expect(toolSpanValues.input).toEqual({ apiKey: 'secret-value' });
521
+ });
522
+
523
+ it('spills oversized sub-agent results to disk and returns a bounded preview', async () => {
524
+ const longAnswer = `ANSWER-HEAD ${'y'.repeat(6000)} ANSWER-TAIL`;
525
+ const { plugin, dispatcher, spanRepo } = createObserverHarness(
526
+ { context: { spill: { maxInlineBytes: 400 } } },
527
+ { runResult: longAnswer },
528
+ );
529
+ const observer = new NativeSubAgentObserver(plugin);
530
+ observer.install();
531
+
532
+ const result = await dispatcher.run(createTask());
533
+
534
+ expect(result).toContain('ANSWER-HEAD');
535
+ expect(result).toContain('ANSWER-TAIL');
536
+ expect(result).toContain('bytes omitted');
537
+ expect(Buffer.byteLength(result, 'utf8')).toBeLessThanOrEqual(400);
538
+ expect(writeFileSync).toHaveBeenCalledTimes(1);
539
+ const spillPath = vi.mocked(writeFileSync).mock.calls[0][0] as string;
540
+ expect(spillPath).toContain('spills');
541
+ // The root span (created first, id 1) stores the spilled preview, not the full text.
542
+ const rootSpanUpdate = spanRepo.update.mock.calls.map((call) => call[0]).find((values) => values.filterByTk === 1);
543
+ expect(rootSpanUpdate.values.output).toBe(result);
544
+ });
545
+
546
+ it('keeps small results inline when no spill budget is configured', async () => {
547
+ const { plugin, dispatcher } = createObserverHarness({}, { runResult: 'short answer' });
548
+ const observer = new NativeSubAgentObserver(plugin);
549
+ observer.install();
550
+
551
+ const result = await dispatcher.run(createTask());
552
+
553
+ expect(result).toBe('short answer');
554
+ expect(writeFileSync).not.toHaveBeenCalled();
555
+ });
556
+ });
557
+
558
+ describe('NativeSubAgentObserver delegation inheritance', () => {
559
+ function loopParentConversation() {
560
+ return {
561
+ sessionId: 'parent-session',
562
+ aiEmployeeUsername: 'leader',
563
+ userId: 7,
564
+ options: { controlPlaneRunId: 5 },
565
+ };
566
+ }
567
+
568
+ function loopRunHarness(settings: Record<string, unknown>) {
569
+ return {
570
+ id: 5,
571
+ roleBindingsSnapshot: { leader: 'leader' },
572
+ leaderHarnessSnapshot: {
573
+ effective: compileHarness([{ source: 'run-snapshot', settings }]),
574
+ },
575
+ };
576
+ }
577
+
578
+ it('inherits the loop role harness as an extra compile layer', async () => {
579
+ const { plugin, dispatcher, spanRepo } = createObserverHarness(
580
+ {},
581
+ {
582
+ parentConversation: loopParentConversation(),
583
+ loopRuns: {
584
+ 5: loopRunHarness({
585
+ observability: { sharing: 'feedback-only' },
586
+ delegation: { maxDepth: 4 },
587
+ }),
588
+ },
589
+ },
590
+ );
591
+ const observer = new NativeSubAgentObserver(plugin);
592
+ observer.install();
593
+
594
+ await dispatcher.run(createTask(plugin.db.getRepository));
595
+
596
+ const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
597
+ // The parent layer tightens sharing to feedback-only even though the child profile defaults
598
+ // to full; the run linkage is persisted on the span and in its metadata.
599
+ expect(rootSpanValues.input).toBeUndefined();
600
+ expect(rootSpanValues.depth).toBe(1);
601
+ expect(rootSpanValues.agentLoopRunId).toBe(5);
602
+ expect(rootSpanValues.metadata.agentLoopRunId).toBe(5);
603
+ });
604
+
605
+ it('does not inherit a run harness when the parent conversation is not a loop session', async () => {
606
+ const { plugin, dispatcher, spanRepo, repos } = createObserverHarness(
607
+ {},
608
+ {
609
+ loopRuns: { 5: loopRunHarness({ observability: { sharing: 'feedback-only' } }) },
610
+ },
611
+ );
612
+ const observer = new NativeSubAgentObserver(plugin);
613
+ observer.install();
614
+
615
+ await dispatcher.run(createTask(plugin.db.getRepository));
616
+
617
+ const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
618
+ // Full sharing from the child profile: without controlPlaneRunId no parent layer is applied.
619
+ expect(rootSpanValues.input).toBeDefined();
620
+ expect(rootSpanValues.agentLoopRunId).toBeUndefined();
621
+ const runRepo = repos.agentLoopRuns as { findOne: ReturnType<typeof vi.fn> };
622
+ expect(runRepo.findOne).not.toHaveBeenCalled();
623
+ });
624
+
625
+ it('derives the child depth from the parent span persisted in the database', async () => {
626
+ const { plugin, dispatcher, spanRepo } = createObserverHarness(
627
+ {},
628
+ {
629
+ spanFindOne: async (query) => (query.filter?.subSessionId === 'parent-session' ? { id: 99, depth: 2 } : null),
630
+ },
631
+ );
632
+ const observer = new NativeSubAgentObserver(plugin);
633
+ observer.install();
634
+
635
+ await dispatcher.run(createTask());
636
+
637
+ const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
638
+ expect(rootSpanValues.depth).toBe(3);
639
+ expect(rootSpanValues.parentSpanId).toBe('99');
640
+ });
641
+
642
+ it('fails the dispatch when the child depth exceeds the inherited maxDepth', async () => {
643
+ const { plugin, dispatcher, originalRun, spanRepo } = createObserverHarness(
644
+ {},
645
+ {
646
+ parentConversation: loopParentConversation(),
647
+ loopRuns: { 5: loopRunHarness({ delegation: { maxDepth: 2 } }) },
648
+ spanFindOne: async (query) => (query.filter?.subSessionId === 'parent-session' ? { id: 99, depth: 2 } : null),
649
+ },
650
+ );
651
+ const observer = new NativeSubAgentObserver(plugin);
652
+ observer.install();
653
+
654
+ await expect(dispatcher.run(createTask(plugin.db.getRepository))).rejects.toThrow(
655
+ 'delegation depth 3 exceeds the harness limit of 2',
656
+ );
657
+ expect(originalRun).not.toHaveBeenCalled();
658
+ const rootSpanUpdate = spanRepo.update.mock.calls.map((call) => call[0]).find((values) => values.filterByTk === 1);
659
+ expect(rootSpanUpdate.values.status).toBe('error');
660
+ expect(rootSpanUpdate.values.error).toContain('exceeds the harness limit');
661
+ });
662
+ });