pi-web-ui 0.94.0 → 0.95.0

package/dist/server/goal-service.js

@@ -122,6 +122,12 @@ export class GoalService {
      * Set (or clear) the active goal. `goal === ""` clears it. The goal is
      * applied to the CURRENT active conversation of this project; reviews check
      * whatever run finishes next (agent_end).
+     *
+     * `opts.targetConvId` retargets the write to a specific conversation — used by
+     * the goal wizard, which runs in the background while the user may have
+     * switched away: the refined goal must land in the conversation that LAUNCHED
+     * the survey (issue #292), not in whatever conversation happens to be active
+     * and not be thrown away.
      */
     async setGoal(goalText, opts) {
         const text = (goalText ?? "").trim();
@@ -138,11 +144,23 @@ export class GoalService {
             });
             return;
         }
-        // A goal is scoped to the conversation that is active when it is set.
-        // This prevents an agent_end from a newly-created/switched conversation
+        // A goal is scoped to the conversation it is set on (default: the active
+        // one). This prevents an agent_end from a newly-created/switched conversation
         // from consuming the previous conversation's goal.
-        const conv = this.host.activeConv();
-        const goalConversationId = this.host.activeConvId();
+        const targetConv = opts?.targetConvId ? this.host.getConv(opts.targetConvId) : undefined;
+        if (opts?.targetConvId && !targetConv) {
+            // The targeted conversation is gone (closed / disposed) — refuse loudly
+            // instead of silently landing the goal somewhere else.
+            this.host.emit({
+                type: "notice",
+                level: "warning",
+                text: `目标未设置：发起目标调研的对话已关闭。`,
+                textEn: `Goal not set: the conversation that started the survey is gone.`,
+            });
+            return;
+        }
+        const conv = targetConv ?? this.host.activeConv();
+        const goalConversationId = conv.id;
         conv.goalGeneration += 1;
         const goal = conv.goal;
         goal.reviewing = false;
@@ -171,6 +189,10 @@ export class GoalService {
             locked: goal.locked,
         });
         // Reset the loop for a freshly-set goal (single-shot goals start at 0).
+        conv.stagnantRounds = 0;
+        conv.lastDiff = undefined;
+        conv.lastErrorSnippet = undefined;
+        conv.sameErrorRounds = 0;
         goal.round = 0;
         goal.reviewing = false;
         goal.verdict = "pending";
@@ -232,6 +254,9 @@ export class GoalService {
         // new active conversation while the wizard is still finishing.
         const wizardConversationId = this.host.activeConvId();
         const wizardConversation = this.host.activeConv();
+        // Human-readable name for notices that must say WHICH conversation the survey
+        // belongs to (issue #292: the user is expected to switch away mid-survey).
+        const wizardConversationTitle = wizardConversation.title;
         if (wizardConversation.wizardRunning || this.wizardOwnerId !== null) {
             this.host.emit({
                 type: "notice",
@@ -329,6 +354,14 @@ export class GoalService {
         });
         // The main conversation to show wizard progress cards in.
         const mainSession = wizardConversation.session;
+        // The raw draft gets its own read-only card BEFORE the first question, so the
+        // flow starts from a visible anchor. If the survey is interrupted (idle/total
+        // timeout, ✗, or the user switching away and never coming back), the original
+        // requirement is still readable and copyable in THIS conversation instead of
+        // having to be retyped (issue #292).
+        await this.pushWizardCard(mainSession, pick(this.lang(), `🎯 原始目标草案：${draft}`, `🎯 Initial goal draft: ${draft}`, "goal.wizard.draft.card", {
+            draft,
+        }), { draft });
         let refinedGoal = "";
         try {
             const wmSpec = opts?.wizardModel ? this.resolveReviewModel(opts.wizardModel) : null; // reuse the honest "provider/id" parser
@@ -519,13 +552,17 @@ export class GoalService {
             this.wizardSession = null;
             this.emitGoalStatus();
         }
-        // Aborted externally (✗ / clear_goal / idle-timeout): do NOT set a goal.
+        // Aborted externally (✗ / clear_goal / idle-timeout): do NOT set a goal. The raw
+        // draft card stays in the launching conversation's flow, so the user can read
+        // it back (and retry) instead of having to retype it (issue #292).
         if (ac.signal.aborted || this.wizardCancelled) {
             this.host.emit({
                 type: "notice",
                 level: "info",
-                text: `目标调研已取消${ac.signal.reason ? `：${String(ac.signal.reason?.message ?? ac.signal.reason)}` : ""}`,
-                textEn: `Goal survey cancelled${ac.signal.reason ? `: ${String(ac.signal.reason?.message ?? ac.signal.reason)}` : ""}`,
+                text: `目标调研已取消${ac.signal.reason ? `：${String(ac.signal.reason?.message ?? ac.signal.reason)}` : ""}` +
+                    `。原始目标草案已保留在会话「${wizardConversationTitle}」的消息流中，可复制后重新发起。`,
+                textEn: `Goal survey cancelled${ac.signal.reason ? `: ${String(ac.signal.reason?.message ?? ac.signal.reason)}` : ""}` +
+                    `. The initial goal draft is preserved in the conversation "${wizardConversationTitle}" — copy it and start over.`,
             });
             this.wizardAbort = null;
             return;
@@ -534,20 +571,26 @@ export class GoalService {
             this.host.emit({
                 type: "notice",
                 level: "warning",
-                text: "调研未产出有效目标，请重试",
-                textEn: "The survey produced no usable goal — retry",
+                text: `调研未产出有效目标，请重试（原始目标草案在会话「${wizardConversationTitle}」的消息流中）`,
+                textEn: `The survey produced no usable goal — retry (the initial draft is in the conversation "${wizardConversationTitle}")`,
             });
             return;
         }
-        if (this.host.activeConvId() !== wizardConversationId) {
+        // The survey belongs to the conversation that launched it. The user is EXPECTED
+        // to switch away while the questions are being answered (check code, read docs),
+        // so "active ≠ launcher" is the normal case, not an error: land the refined goal
+        // on the launcher instead of discarding the work (issue #292).
+        const targetConv = this.host.getConv(wizardConversationId);
+        if (!targetConv) {
             this.host.emit({
                 type: "notice",
-                level: "info",
-                text: "已切换对话，目标调研结果已丢弃",
-                textEn: "Switched conversations; the survey result was discarded",
+                level: "warning",
+                text: `目标调研完成，但发起会话「${wizardConversationTitle}」已关闭，结果未应用（可在新会话里重新发起）。`,
+                textEn: `The survey finished, but the conversation that started it ("${wizardConversationTitle}") is gone — the result was not applied. Start a new survey.`,
             });
             return;
         }
+        const switchedAway = this.host.activeConvId() !== wizardConversationId;
         // Auto-set the refined goal. The wizard workflow implies "set a goal and
         // work until it passes", so default LOCKED=true unless the user explicitly
         // turned the lock off (a lock lets the review loop keep revising to pass;
@@ -557,6 +600,9 @@ export class GoalService {
             reviewModel: wgoal.reviewModel ?? undefined,
             maxRounds: opts?.maxRounds,
             locked: wantLocked,
+            // Land the goal on the conversation that launched the survey, even if the
+            // user is looking at another one right now (issue #292).
+            targetConvId: wizardConversationId,
             // The wizard kicks off generation itself below — avoid a double kick.
             autoStart: false,
         });
@@ -565,8 +611,12 @@ export class GoalService {
         this.host.emit({
             type: "notice",
             level: "info",
-            text: `🎯 调研完成，目标已设为：${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""}`,
-            textEn: `🎯 Survey done, goal set: ${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""}`,
+            text: switchedAway
+                ? `🎯 会话「${wizardConversationTitle}」目标调研完成，目标已设为：${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""}（已切回该会话开始生成）`
+                : `🎯 调研完成，目标已设为：${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""}`,
+            textEn: switchedAway
+                ? `🎯 Survey done in "${wizardConversationTitle}", goal set: ${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""} (switch back to that conversation to watch it generate)`
+                : `🎯 Survey done, goal set: ${refinedGoal.slice(0, 80)}${refinedGoal.length > 80 ? "…" : ""}`,
         });
         // Kick the main agent into generating right away (no manual "开始吧").
         // The kick-off is a user message so it appears in the flow and triggers a
@@ -613,6 +663,10 @@ export class GoalService {
     async clearGoal() {
         const conv = this.host.activeConv();
         conv.goalGeneration += 1;
+        conv.stagnantRounds = 0;
+        conv.lastDiff = undefined;
+        conv.lastErrorSnippet = undefined;
+        conv.sameErrorRounds = 0;
         const goal = conv.goal;
         goal.reviewing = false;
         goal.conversationId = null;
@@ -652,6 +706,10 @@ export class GoalService {
         if (aborted) {
             if (g.goal && g.conversationId === conv.id) {
                 conv.goalGeneration += 1;
+                conv.stagnantRounds = 0;
+                conv.lastDiff = undefined;
+                conv.lastErrorSnippet = undefined;
+                conv.sameErrorRounds = 0;
                 g.conversationId = null;
                 g.goal = null;
                 g.reviewing = false;
@@ -684,6 +742,38 @@ export class GoalService {
     resolveReviewModel(spec) {
         return parseModelSpec(spec);
     }
+    /** 提取会话最近产生的错误特征，用于停滞与相同报错检测。 */
+    extractErrorSnippet(session, text) {
+        try {
+            const messages = session.agent?.state?.messages;
+            if (Array.isArray(messages)) {
+                for (let i = messages.length - 1; i >= 0 && i >= messages.length - 6; i--) {
+                    const m = messages[i];
+                    if (m.role === "toolResult" && m.isError) {
+                        const errText = m.content
+                            ?.map((c) => (c.type === "text" ? c.text : ""))
+                            .join(" ")
+                            .trim();
+                        if (errText)
+                            return errText.slice(0, 300);
+                    }
+                    if (m.role === "bashExecution" && m.exitCode && m.exitCode !== 0) {
+                        const snippet = m.output?.trim().slice(-300);
+                        if (snippet)
+                            return `bash exit ${m.exitCode}: ${snippet}`;
+                    }
+                }
+            }
+        }
+        catch {
+            // Ignore
+        }
+        const errMatch = text.match(/(?:(?:Error|Exception|Fail|Fatal):[^\n]+)/i);
+        if (errMatch) {
+            return errMatch[0].trim().slice(0, 300);
+        }
+        return undefined;
+    }
     /**
      * The whitelisted reviewer plan — tell the reviewer what to decide and how
      * to report, regardless of which model it runs on.
@@ -798,65 +888,123 @@ export class GoalService {
         }
         let reviewerVerdict = "fail";
         let reviewerFeedback = pick(this.lang(), "（审查无法完成）", "(The review could not be completed)", "goal.review.incomplete");
-        try {
-            const rmSpec = this.resolveReviewModel(g.reviewModel);
-            const services = await createAgentSessionServices({
-                cwd: mainConv.cwd,
-                agentDir: this.host.agentDir,
-                // The reviewer has its own skill allow/deny list. It deliberately does
-                // not reuse the main session's disabledSkills setting.
-                resourceLoaderOptions: {
-                    skillsOverride: (res) => ({
-                        ...res,
-                        skills: res.skills.filter((s) => !reviewDisabledSkills.has(s.name)),
-                    }),
-                },
-                // A FRESH ModelRuntime for the reviewer — isolated from the shared
-                // one used by the main conversations, so its model choice is its own.
-                modelRuntime: await ModelRuntime.create({
-                    authPath: join(this.host.agentDir, "auth.json"),
-                    modelsPath: join(this.host.agentDir, "models.json"),
-                }),
-            });
-            // Model resolution: explicit reviewer model, else the main session's
-            // current model (so a goal works even when no reviewer model is given).
-            let model;
-            if (rmSpec) {
-                model = services.modelRuntime.getModel(rmSpec.provider, rmSpec.id);
-            }
-            if (!model) {
-                const mainModel = mainSession.model;
-                if (mainModel?.provider && mainModel.id) {
-                    model = services.modelRuntime.getModel(mainModel.provider, mainModel.id);
-                }
+        // 停滞与错误检测分析（DSH 风格防死循环与停滞检测）：
+        const currentError = this.extractErrorSnippet(mainSession, finalText);
+        const prevError = conv.lastErrorSnippet;
+        if (currentError &&
+            prevError &&
+            (currentError === prevError || currentError.includes(prevError) || prevError.includes(currentError))) {
+            conv.sameErrorRounds = (conv.sameErrorRounds ?? 0) + 1;
+        }
+        else {
+            conv.sameErrorRounds = currentError ? 1 : 0;
+        }
+        conv.lastErrorSnippet = currentError;
+        const trimmedDiff = diff.trim();
+        const prevDiff = conv.lastDiff;
+        const isNoDiffChange = trimmedDiff === "" || (prevDiff !== undefined && trimmedDiff === prevDiff);
+        if (isNoDiffChange) {
+            conv.stagnantRounds = (conv.stagnantRounds ?? 0) + 1;
+        }
+        else {
+            conv.stagnantRounds = 0;
+        }
+        conv.lastDiff = trimmedDiff;
+        const isAutonomous = !g.reviewModel;
+        if (isAutonomous) {
+            // DSH 风格自主轮次驱动（免拉起独立审查会话，省 token + 零启动延迟）：
+            // 检查模型自身是否在输出中表明目标已达成
+            const completionRegex = /【目标(?:已)?(?:达成|完成)】|GOAL(?:[:：_]|\s+)*(?:IS\s+)?(?:COMPLETED|PASSED)|目标已达成|目标已完成/i;
+            const isCompleted = completionRegex.test(finalText);
+            if (isCompleted) {
+                reviewerVerdict = "pass";
+                reviewerFeedback = pick(this.lang(), "模型自主验证：目标已达成", "Model autonomous evaluation: Goal completed", "goal.autonomous.pass");
             }
-            const srv = await createAgentSessionFromServices({
-                services,
-                sessionManager: SessionManager.inMemory(mainConv.cwd),
-                ...(model ? { model } : {}),
-            });
-            const reviewCap = g.locked && g.maxRounds > 0 ? g.maxRounds : 0; // 0 = no cap
-            const reviewer = srv.session;
-            await reviewer.prompt(this.reviewerPrompt(goalText, g.round, reviewCap, finalText, diff, reviewPrompt));
-            // Parse the reviewer's final output (expected to be a JSON object).
-            const raw = reviewer.getLastAssistantText() ?? "";
-            const m = raw.match(/\{\s*"verdict"\s*:\s*"(pass|fail)"[^}]*\}/);
-            if (m) {
-                reviewerVerdict = m[1];
-                const fm = raw.match(/"feedback"\s*:\s*"([^"]*)"/);
-                reviewerFeedback = fm?.[1] ?? "";
+            else if ((conv.sameErrorRounds ?? 0) >= 2 || (conv.stagnantRounds ?? 0) >= 2) {
+                // 触发防死循环与停滞熔断（Blocked）
+                reviewerVerdict = "blocked";
+                const blockedReason = (conv.sameErrorRounds ?? 0) >= 2
+                    ? `连续 ${conv.sameErrorRounds} 轮出现相同错误：${currentError}`
+                    : `连续 ${conv.stagnantRounds} 轮未检测到有效文件修改或实质进展`;
+                const blockedReasonEn = (conv.sameErrorRounds ?? 0) >= 2
+                    ? `Identical error across ${conv.sameErrorRounds} consecutive rounds: ${currentError}`
+                    : `No effective file modifications or progress across ${conv.stagnantRounds} consecutive rounds`;
+                reviewerFeedback = pick(this.lang(), `【目标防死循环保护：执行受阻（Blocked）】\n\n` +
+                    `• 停滞原因：${blockedReason}\n` +
+                    `• 当前轮次：第 ${g.round} 轮\n` +
+                    `• 诊断分析：智能体在自主推进中连续轮次未产生有效进展或反复遭遇相同错误，已自动熔断以防止无谓消耗 token。\n` +
+                    `• 建议措施：请检查相关代码、工具权限或手动调整提示词，排查阻碍后再继续。`, `[Goal Infinite-Loop Protection: Blocked]\n\n` +
+                    `• Cause: ${blockedReasonEn}\n` +
+                    `• Current round: Round ${g.round}\n` +
+                    `• Diagnosis: Agent made no progress or encountered identical errors across consecutive rounds. Circuit breaker tripped to prevent token waste.\n` +
+                    `• Recommendation: Please check code, tool permissions, or refine prompt before proceeding.`, "goal.review.blocked", { blockedReason, blockedReasonEn, round: g.round });
             }
             else {
-                // No JSON — assume fail with the raw output as feedback.
                 reviewerVerdict = "fail";
-                reviewerFeedback = raw.slice(0, 2000);
+                reviewerFeedback = pick(this.lang(), "目标尚未完成，自主推进下一轮迭代验证。", "Goal not yet completed; continuing to next iteration.", "goal.autonomous.continue");
             }
-            await srv.session.dispose();
         }
-        catch (err) {
-            const reviewErrMsg = err.message;
-            reviewerVerdict = "fail";
-            reviewerFeedback = pick(this.lang(), `审查过程中出错：${reviewErrMsg}`, `Error during review: ${reviewErrMsg}`, "goal.review.error", { reviewErrMsg: reviewErrMsg });
+        else {
+            try {
+                const rmSpec = this.resolveReviewModel(g.reviewModel);
+                const services = await createAgentSessionServices({
+                    cwd: mainConv.cwd,
+                    agentDir: this.host.agentDir,
+                    // The reviewer has its own skill allow/deny list. It deliberately does
+                    // not reuse the main session's disabledSkills setting.
+                    resourceLoaderOptions: {
+                        skillsOverride: (res) => ({
+                            ...res,
+                            skills: res.skills.filter((s) => !reviewDisabledSkills.has(s.name)),
+                        }),
+                    },
+                    // A FRESH ModelRuntime for the reviewer — isolated from the shared
+                    // one used by the main conversations, so its model choice is its own.
+                    modelRuntime: await ModelRuntime.create({
+                        authPath: join(this.host.agentDir, "auth.json"),
+                        modelsPath: join(this.host.agentDir, "models.json"),
+                    }),
+                });
+                // Model resolution: explicit reviewer model, else the main session's
+                // current model (so a goal works even when no reviewer model is given).
+                let model;
+                if (rmSpec) {
+                    model = services.modelRuntime.getModel(rmSpec.provider, rmSpec.id);
+                }
+                if (!model) {
+                    const mainModel = mainSession.model;
+                    if (mainModel?.provider && mainModel.id) {
+                        model = services.modelRuntime.getModel(mainModel.provider, mainModel.id);
+                    }
+                }
+                const srv = await createAgentSessionFromServices({
+                    services,
+                    sessionManager: SessionManager.inMemory(mainConv.cwd),
+                    ...(model ? { model } : {}),
+                });
+                const reviewCap = g.locked && g.maxRounds > 0 ? g.maxRounds : 0; // 0 = no cap
+                const reviewer = srv.session;
+                await reviewer.prompt(this.reviewerPrompt(goalText, g.round, reviewCap, finalText, diff, reviewPrompt));
+                // Parse the reviewer's final output (expected to be a JSON object).
+                const raw = reviewer.getLastAssistantText() ?? "";
+                const m = raw.match(/\{\s*"verdict"\s*:\s*"(pass|fail)"[^}]*\}/);
+                if (m) {
+                    reviewerVerdict = m[1];
+                    const fm = raw.match(/"feedback"\s*:\s*"([^"]*)"/);
+                    reviewerFeedback = fm?.[1] ?? "";
+                }
+                else {
+                    // No JSON — assume fail with the raw output as feedback.
+                    reviewerVerdict = "fail";
+                    reviewerFeedback = raw.slice(0, 2000);
+                }
+                await srv.session.dispose();
+            }
+            catch (err) {
+                const reviewErrMsg = err.message;
+                reviewerVerdict = "fail";
+                reviewerFeedback = pick(this.lang(), `审查过程中出错：${reviewErrMsg}`, `Error during review: ${reviewErrMsg}`, "goal.review.error", { reviewErrMsg: reviewErrMsg });
+            }
         }
         // The user may have switched chats or replaced/cleared the goal while the
         // isolated reviewer was running. Never apply a stale verdict or inject it
@@ -897,6 +1045,30 @@ export class GoalService {
             this.host.flushSnapshot();
             return;
         }
+        if (verdict === "blocked") {
+            g.status = "⚠️ 目标受阻（停滞熔断）";
+            g.statusEn = "⚠️ Goal blocked (stagnation circuit break)";
+            this.host.emit({
+                type: "notice",
+                level: "warning",
+                text: "⚠️ 目标执行受阻：检测到停滞或相同报错，已自动暂停",
+                textEn: "⚠️ Goal execution blocked: stagnation or repeated error detected, auto-loop paused",
+            });
+            try {
+                const blockedText = pick(this.lang(), `⚠️ 目标执行受阻（第 ${round} 轮已触发停滞熔断）。\n\n目标：${goalText}\n\n${feedback}\n\n（目标模式已暂停，请在排查问题后重新设定目标或手动继续。）`, `⚠️ Goal execution blocked (stagnation circuit breaker at round ${round}).\n\nGoal: ${goalText}\n\n${feedback}\n\n(Goal mode paused — please investigate and reset goal or continue manually.)`, "goal.review.blocked_msg", { round, goalText, feedback });
+                await mainSession.sendUserMessage(blockedText, {
+                    deliverAs: mainSession.isStreaming ? "steer" : "followUp",
+                });
+            }
+            catch {
+                // Best-effort.
+            }
+            g.conversationId = null;
+            g.goal = null; // loop blocked — clear the active goal
+            this.emitGoalStatus();
+            this.host.flushSnapshot();
+            return;
+        }
         // Failure: if rounds remain, steer a revision; else report the loop done.
         // For unlimited (budget=0) isLastRound is always false → keeps revising.
         const isLastRound = !g.locked ? true : g.maxRounds > 0 && g.round >= g.maxRounds;