pi-plans 0.5.7 → 0.7.0

package/tests/code-graph-index.test.ts

@@ -63,7 +63,7 @@ test("runIndex indexes files, writes rows, and screening excludes full_code", as
 	};
 	const sqlite = await import("node:sqlite");
 	const commonDir = git(worktreeRoot, ["rev-parse", "--git-common-dir"]);
-	const dbDir = path.join(path.resolve(worktreeRoot, commonDir), "pi_plans");
+	const dbDir = path.join(path.resolve(worktreeRoot, commonDir), "pi-plans");
 	fs.mkdirSync(dbDir, { recursive: true });
 	const dbPath = path.join(dbDir, "code_graph.db");
 	try { fs.unlinkSync(dbPath); } catch { /* ignore */ }
@@ -151,7 +151,7 @@ test("runIndex with opts.paths indexes only hit paths and purges missing ones",
 		tsx: makeBackend("tsx", ParserCtor, runtime.runtime.parser.tsx),
 		python: new PythonBackend(ParserCtor, runtime.runtime.parser.python),
 	};
-	const stateRoot = path.join(worktreeRoot, ".git", "pi_plans");
+	const stateRoot = path.join(worktreeRoot, ".git", "pi-plans");
 	fs.mkdirSync(stateRoot, { recursive: true });
 	const store = new Store({ dbPath: path.join(stateRoot, "code_graph.db"), worktreeRoot, gitCommonDir: path.join(worktreeRoot, ".git") }, runtime.runtime.sqlite);
 	t.after(() => store.close());

package/tests/code-graph-loop.e2e.test.ts

@@ -57,7 +57,7 @@ test("closed loop: init → mutation → apply → drift → final-commit → cl
 	const { root, cleanup } = initRepo();
 	t.after(cleanup);
 
-	const stateRoot = path.join(root, ".git", "pi_plans");
+	const stateRoot = path.join(root, ".git", "pi-plans");
 	fs.mkdirSync(stateRoot, { recursive: true });
 	const dbPath = path.join(stateRoot, "code_graph.db");
 	const store = new Store({ dbPath, worktreeRoot: root, gitCommonDir: path.join(root, ".git") }, runtime.runtime.sqlite);

package/tests/code-graph-mutations.test.ts

@@ -51,7 +51,7 @@ test("updateFunction propagates offsets, rebuilds source exactly, and applies by
 	if (!runtime.status.parserAvailable || !runtime.status.sqliteAvailable) return;
 	const { root, cleanup } = initRepo();
 	t.after(cleanup);
-	const stateRoot = path.join(root, ".git", "pi_plans");
+	const stateRoot = path.join(root, ".git", "pi-plans");
 	fs.mkdirSync(stateRoot, { recursive: true });
 	const store = new Store({ dbPath: path.join(stateRoot, "g.db"), worktreeRoot: root, gitCommonDir: path.join(root, ".git") }, runtime.runtime.sqlite);
 	t.after(() => store.close());

package/tests/code-graph-rollback.test.ts

@@ -59,7 +59,7 @@ test("indexer rolls back the whole file batch when an emit step throws", async (
 	};
 	const sqlite = await import("node:sqlite");
 	const commonDir = git(worktreeRoot, ["rev-parse", "--git-common-dir"]);
-	const dbDir = path.join(path.resolve(worktreeRoot, commonDir), "pi_plans");
+	const dbDir = path.join(path.resolve(worktreeRoot, commonDir), "pi-plans");
 	fs.mkdirSync(dbDir, { recursive: true });
 	const dbPath = path.join(dbDir, "code_graph.db");
 	try { fs.unlinkSync(dbPath); } catch { /* ignore */ }

package/tests/code-graph-v05.test.ts

@@ -362,8 +362,8 @@ describe("watch lifecycle (VC-006)", () => {
 		execSync('git config user.email t@t && git config user.name t', { cwd: root, shell: "/bin/bash" });
 		const { parsers, sqlite } = await makeParsers();
 		fs.writeFileSync(path.join(root, "a.ts"), "export function alpha() { return 1; }\n");
-		// The watcher always opens the CANONICAL db under .git/pi_plans/.
-		const dbPath = path.join(root, ".git", "pi_plans", "code_graph.db");
+		// The watcher always opens the CANONICAL db under .git/pi-plans/.
+		const dbPath = path.join(root, ".git", "pi-plans", "code_graph.db");
 		fs.mkdirSync(path.dirname(dbPath), { recursive: true });
 		const store = new Store({ dbPath, worktreeRoot: root, gitCommonDir: path.join(root, ".git") }, sqlite);
 		await runIndex({ store, worktreeRoot: root, parsers });

package/tests/compaction.test.ts

@@ -245,7 +245,7 @@ describe("pi-vcc compaction", () => {
 		assert.match(result.compaction.summary, /Modified: src\/compaction\.ts/);
 		assert.match(result.compaction.summary, /Read: src\/exec\.ts/);
 		assert.match(result.compaction.summary, /\[Outstanding Context\]/);
-		assert.match(result.compaction.summary, /Current implementation item: I-002/);
+		assert.match(result.compaction.summary, /Current task: I-002/);
 		assert.match(result.compaction.summary, /Previous compact summary: Legacy Summary Earlier compact facts\./);
 		assert.match(result.compaction.summary, /\[User Preferences\]/);
 		assert.match(result.compaction.summary, /Always keep ASCII output/);

package/tests/config-command.test.ts

@@ -3,7 +3,7 @@ import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
 import * as url from "node:url";
-import { after, before, describe, it } from "node:test";
+import { after, before, beforeEach, describe, it } from "node:test";
 
 import { configPiPlansCommand } from "../src/config-command.ts";
 import { startRun } from "../src/state.ts";
@@ -25,13 +25,25 @@ interface HarnessOptions {
 }
 
 let root: string;
+let globalDir: string;
+let previousGlobalDir: string | undefined;
 
 before(() => {
 	root = fs.mkdtempSync(path.join(os.tmpdir(), "pi-plans-config-command-"));
+	previousGlobalDir = process.env.PI_PLANS_GLOBAL_DIR;
+	globalDir = fs.mkdtempSync(path.join(os.tmpdir(), "pi-plans-global-config-command-"));
+	process.env.PI_PLANS_GLOBAL_DIR = globalDir;
+});
+
+beforeEach(() => {
+	fs.rmSync(path.join(globalDir, "config.json"), { force: true });
 });
 
 after(() => {
+	if (previousGlobalDir === undefined) delete process.env.PI_PLANS_GLOBAL_DIR;
+	else process.env.PI_PLANS_GLOBAL_DIR = previousGlobalDir;
 	fs.rmSync(root, { recursive: true, force: true });
+	fs.rmSync(globalDir, { recursive: true, force: true });
 });
 
 function workdir(name: string): string {
@@ -41,11 +53,15 @@ function workdir(name: string): string {
 }
 
 function configPath(workdirPath: string): string {
-	return path.join(workdirPath, ".git", "pi_plans", "config.json");
+	return path.join(workdirPath, ".git", "pi-plans", "config.json");
 }
 
 function runPath(workdirPath: string, runId: string): string {
-	return path.join(workdirPath, ".git", "pi_plans", "runs", runId, "run.json");
+	return path.join(workdirPath, ".git", "pi-plans", "runs", runId, "run.json");
+}
+
+function readGlobal(): any {
+	return JSON.parse(fs.readFileSync(path.join(globalDir, "config.json"), "utf8"));
 }
 
 function readJson(filePath: string): any {
@@ -61,6 +77,7 @@ function makeContext(workdirPath: string, options: HarnessOptions) {
 	const ctx = {
 		cwd: workdirPath,
 		hasUI: true,
+		mode: "rpc",
 		model: options.model ?? null,
 		scopedModels: options.scopedModels ?? [],
 		modelRegistry: {
@@ -83,6 +100,15 @@ function makeContext(workdirPath: string, options: HarnessOptions) {
 	return { ctx, recorded };
 }
 
+/** Default answers for the four workspace menus (language/artifact/refs/graph). */
+function workspaceDefaults(question: string, labels: string[]): string | undefined {
+	if (question === "Language?") return labels[0];
+	if (question === "Artifact root?") return labels[0];
+	if (question === "Refs root (plan-with-refs downloads)?") return labels[0];
+	if (question === "Code graph?") return labels[0];
+	return undefined;
+}
+
 describe("config-pi-plans command", () => {
 	it("registers the slash command in index.ts and delegates to the helper", () => {
 		const source = fs.readFileSync(path.join(ROOT, "index.ts"), "utf8");
@@ -91,25 +117,14 @@ describe("config-pi-plans command", () => {
 		assert.match(source, /await configPiPlansCommand\(args, ctx\);/);
 	});
 
-	it("writes the full wizard into config.json", async () => {
+	it("writes the workspace settings and switches the reviewer mode globally; current-session skips the model step (Q-3)", async () => {
 		const dir = workdir("full-wizard");
-		const { ctx } = makeContext(dir, {
+		const { ctx, recorded } = makeContext(dir, {
 			model: { provider: "live", id: "pro" },
 			availableModels: [{ provider: "registry", id: "critic" }],
 			select: (question, labels) => {
-				if (question === "Language?") return labels.find((label) => label.includes("en"));
-				if (question === "Artifact root?") return labels.find((label) => label.includes("./.git/pi_plans/plans"));
-				if (question === "Refs root (plan-with-refs downloads)?") return labels.find((label) => label.includes(".git/pi-plans/refs"));
-				if (question === "Code graph?") return labels.find((label) => label.includes("Disable code graph"));
 				if (question === "Reviewer mode?") return labels.find((label) => label.includes("Switch to current-session"));
-				if (question === "Reviewer model?") return labels.find((label) => label.includes("Use current session model (live/pro)"));
-				if (question === "Criticizer mode?") return labels.find((label) => label.includes("Keep delegated-subagent"));
-				if (question === "Criticizer model?") return labels.find((label) => label.includes("Other..."));
-				return undefined;
-			},
-			input: (prompt) => {
-				if (prompt === "Criticizer model selector:") return "custom/critic-model";
-				return undefined;
+				return workspaceDefaults(question, labels);
 			},
 		});
 
@@ -117,24 +132,44 @@ describe("config-pi-plans command", () => {
 
 		assert.ok(fs.existsSync(configPath(dir)));
 		const config = readJson(configPath(dir));
-		assert.equal(config.language.tag, "en");
-		assert.equal(config.language.source, "user");
-		assert.equal(config.artifact_root, "./.git/pi_plans/plans");
-		assert.equal(config.artifact_root_source, "user");
+		assert.equal(config.language.tag, "zh-Hans", "labels[0] on the language menu");
+		assert.equal(config.artifact_root, "./.git/pi-plans/plans");
 		assert.equal(config.refs_root, ".git/pi-plans/refs");
-		assert.equal(config.refs_root_source, "user");
-		assert.ok(config.refs_root_updated_at);
-		assert.equal(config.graph_enabled, false);
-		assert.equal(config.reviewer.mode, "current-session");
-		assert.equal(config.reviewer.model_selector, "live/pro");
-		assert.equal(config.criticizer.mode, "delegated-subagent");
-		assert.equal(config.criticizer.model_selector, "custom/critic-model");
-		assert.ok(config.reviewer.confirmed_at);
-		assert.ok(config.criticizer.confirmed_at);
+		assert.equal(config.graph_enabled, true, "labels[0] on the graph menu enables");
+		assert.equal("reviewer" in config, false, "the reviewer role never lands in the workspace config");
+		assert.equal("criticizer" in config, false);
+		// The mode switch went to the GLOBAL config.
+		const globalRole = readGlobal().reviewer;
+		assert.equal(globalRole.mode, "current-session");
+		// Q-3: no reviewer-model prompt in current-session mode.
+		assert.equal(recorded.selects.some((entry) => entry.question === "Reviewer model?"), false);
+	});
+
+	it("shows a keep/change entry menu when the reviewer is unconfirmed", async () => {
+		const dir = workdir("entry-menu");
+		const { ctx, recorded } = makeContext(dir, {
+			select: (question, labels) => {
+				if (question === "Reviewer mode?") return labels[0];
+				if (question === "Reviewer model?") return labels[0];
+				return workspaceDefaults(question, labels);
+			},
+		});
+
+		await configPiPlansCommand("", ctx);
+
+		const entry = recorded.selects.find((entry) => entry.question === "Reviewer model?");
+		assert.ok(entry);
+		assert.deepEqual(entry?.labels, [
+			"1. Keep current (unconfirmed; first refine will ask)",
+			"2. Choose model & thinking level…",
+		]);
+		// Keeping the unconfirmed role writes nothing to the global config.
+		assert.equal(fs.existsSync(path.join(globalDir, "config.json")), false);
+		assert.equal(fs.existsSync(configPath(dir)), true);
 	});
 
-	it("dedupes model choices and falls back to the live model when no default is stored", async () => {
-		const dir = workdir("model-menu");
+	it("change flow via menus persists model + level to the global config", async () => {
+		const dir = workdir("change-menus");
 		const { ctx, recorded } = makeContext(dir, {
 			model: { provider: "live", id: "pro" },
 			scopedModels: [{ model: { provider: "scoped", id: "model-a" } }],
@@ -143,51 +178,56 @@ describe("config-pi-plans command", () => {
 				{ provider: "registry", id: "model-b" },
 			],
 			select: (question, labels) => {
-				if (question === "Language?") return labels[0];
-				if (question === "Artifact root?") return labels[0];
-				if (question === "Refs root (plan-with-refs downloads)?") return labels[0];
-				if (question === "Code graph?") return labels[0];
 				if (question === "Reviewer mode?") return labels[0];
-				if (question === "Reviewer model?") return labels[0];
-				if (question === "Criticizer mode?") return undefined;
-				return undefined;
+				if (question === "Reviewer model?") {
+					const modelMenus = recorded.selects.filter((e) => e.question === "Reviewer model?");
+					if (modelMenus.length === 1) return labels.find((label) => label.includes("Choose model & thinking level"));
+					return labels.find((label) => label.includes("Use registry/model-b"));
+				}
+				if (question.startsWith("Reviewer thinking level?")) return labels[0];
+				return workspaceDefaults(question, labels);
 			},
 		});
 
 		await configPiPlansCommand("", ctx);
 
-		const reviewerModelPrompt = recorded.selects.find((entry) => entry.question === "Reviewer model?");
-		assert.ok(reviewerModelPrompt);
-		assert.deepEqual(reviewerModelPrompt?.labels, [
-			"1. Keep current default (inherit live model: live/pro)",
-			"2. Use current session model (live/pro)",
-			"3. Use available model (scoped/model-a)",
-			"4. Use available model (registry/model-b)",
-			"5. Other...",
-		]);
-		assert.equal(fs.existsSync(configPath(dir)), false);
-		assert.equal(recorded.notifies.at(-1)?.severity, "warning");
+		const globalRole = readGlobal().reviewer;
+		assert.equal(globalRole.mode, "delegated-subagent");
+		assert.equal(globalRole.model_selector, "registry/model-b");
+		assert.equal(globalRole.thinking_level, null, "first row = default → null");
+		assert.ok(globalRole.confirmed_at);
+		// The workspace config stays reviewer-free.
+		assert.equal("reviewer" in readJson(configPath(dir)), false);
 	});
 
-	it("rejects an invalid model selector entered through Other and leaves config untouched", async () => {
+	it("an invalid manual selector keeps the current role and still writes workspace settings (F-011)", async () => {
 		const dir = workdir("invalid-model");
 		const { ctx, recorded } = makeContext(dir, {
 			select: (question, labels) => {
-				if (question === "Language?") return labels[0];
-				if (question === "Artifact root?") return labels[0];
-				if (question === "Refs root (plan-with-refs downloads)?") return labels[0];
-				if (question === "Code graph?") return labels[0];
 				if (question === "Reviewer mode?") return labels[0];
-				if (question === "Reviewer model?") return labels.find((label) => label.includes("Other..."));
-				return undefined;
+				if (question === "Reviewer model?") {
+					const modelMenus = recorded.selects.filter((e) => e.question === "Reviewer model?");
+					if (modelMenus.length === 1) return labels.find((label) => label.includes("Choose model & thinking level"));
+					return labels.find((label) => label.includes("Other..."));
+				}
+				return workspaceDefaults(question, labels);
 			},
 			input: () => "bad selector",
 		});
 
 		await configPiPlansCommand("", ctx);
 
-		assert.equal(fs.existsSync(configPath(dir)), false);
-		assert.equal(recorded.notifies.some((entry) => entry.message.includes("Model selector must be an exact provider/model string.")), true);
+		assert.equal(fs.existsSync(path.join(globalDir, "config.json")), false, "nothing persisted for the reviewer");
+		assert.equal(fs.existsSync(configPath(dir)), true, "workspace settings still written");
+		assert.equal(
+			recorded.notifies.some((entry) => entry.message.includes("Model selector must be an exact provider/model string.")),
+			true,
+		);
+		assert.equal(
+			recorded.notifies.some((entry) => entry.message.includes("Reviewer change failed")),
+			true,
+			"the summary reports the failed reviewer change",
+		);
 	});
 
 	it("does not write when the wizard is cancelled", async () => {
@@ -204,49 +244,15 @@ describe("config-pi-plans command", () => {
 		assert.equal(fs.existsSync(configPath(dir)), false);
 	});
 
-	it("renders a two-option inherit menu when no model sources exist", async () => {
-		const dir = workdir("empty-model-menu");
-		const { ctx, recorded } = makeContext(dir, {
-			model: null,
-			scopedModels: [],
-			availableModels: [],
-			select: (question, labels) => {
-				if (question === "Language?") return labels[0];
-				if (question === "Artifact root?") return labels[0];
-				if (question === "Refs root (plan-with-refs downloads)?") return labels[0];
-				if (question === "Code graph?") return labels[0];
-				if (question === "Reviewer mode?") return labels[0];
-				if (question === "Reviewer model?") return labels[0];
-				return undefined;
-			},
-		});
-
-		await configPiPlansCommand("", ctx);
-
-		const reviewerModelPrompt = recorded.selects.find((entry) => entry.question === "Reviewer model?");
-		assert.ok(reviewerModelPrompt);
-		assert.deepEqual(reviewerModelPrompt?.labels, [
-			"1. Keep current default (inherit)",
-			"2. Other...",
-		]);
-		assert.equal(fs.existsSync(configPath(dir)), false);
-	});
-
 	it("keeps the active run snapshot unchanged", async () => {
 		const dir = workdir("active-run");
 		const { run } = startRun(dir, { topic: "config", skill: "plan-small", requestText: "x" });
 		const before = readJson(runPath(dir, run.run_id));
 		const { ctx } = makeContext(dir, {
 			select: (question, labels) => {
-				if (question === "Language?") return labels.find((label) => label.includes("en"));
-				if (question === "Artifact root?") return labels.find((label) => label.includes("./.git/pi_plans/plans"));
-				if (question === "Refs root (plan-with-refs downloads)?") return labels.find((label) => label.includes(".git/pi-plans/refs"));
-				if (question === "Code graph?") return labels.find((label) => label.includes("Enable code graph"));
 				if (question === "Reviewer mode?") return labels.find((label) => label.includes("Keep delegated-subagent"));
 				if (question === "Reviewer model?") return labels[0];
-				if (question === "Criticizer mode?") return labels.find((label) => label.includes("Keep delegated-subagent"));
-				if (question === "Criticizer model?") return labels[0];
-				return undefined;
+				return workspaceDefaults(question, labels);
 			},
 		});
 
@@ -255,10 +261,7 @@ describe("config-pi-plans command", () => {
 		const after = readJson(runPath(dir, run.run_id));
 		assert.deepEqual(after, before);
 		const config = readJson(configPath(dir));
-		assert.equal(config.language.tag, "en");
-		assert.equal(config.artifact_root, "./.git/pi_plans/plans");
-		assert.equal(config.reviewer.model_selector, null);
-		assert.ok(config.reviewer.confirmed_at);
+		assert.equal("reviewer" in config, false);
 	});
 
 	it("with an active run, a successful save never notifies an error (impl review F-001)", async () => {
@@ -266,14 +269,14 @@ describe("config-pi-plans command", () => {
 		startRun(dir, { topic: "config-guard", skill: "plan-small", requestText: "x" });
 		const { ctx, recorded } = makeContext(dir, {
 			select: (question, labels) => {
-				if (question === "Language?") return labels.find((label) => label.includes("en"));
+				if (question === "Language?") return labels.find((label) => label.includes("zh-Hans")) ?? labels[0];
 				return labels[0];
 			},
 		});
 
 		await configPiPlansCommand("", ctx);
 
-		assert.equal(readJson(configPath(dir)).language.tag, "en", "the wizard must keep saving");
+		assert.equal(fs.existsSync(configPath(dir)), true, "the wizard must keep saving");
 		assert.equal(
 			recorded.notifies.find((entry) => entry.severity === "error"),
 			undefined,