pi-lens 4.3.0 → 4.4.0

package/dist/clients/lazy-import.js

@@ -1,21 +0,0 @@
-export function createLazyImport(load) {
-    let cached;
-    return {
-        get() {
-            // `Promise.resolve().then(load)` (not a bare `load()`) so a loader
-            // that throws SYNCHRONOUSLY — rather than returning a rejected
-            // promise — still yields a rejected promise instead of throwing out
-            // of `get()` itself. `import(...)` never throws synchronously, but a
-            // caller-supplied `load` is not guaranteed to keep that contract.
-            return (cached ??= Promise.resolve()
-                .then(() => load())
-                .catch((err) => {
-                cached = undefined;
-                throw err;
-            }));
-        },
-        resetForTests() {
-            cached = undefined;
-        },
-    };
-}

package/dist/clients/ledger-bounds.js

@@ -1,54 +0,0 @@
-/**
- * The degradation ledger's field-truncation policy, as a leaf module (#1816).
- *
- * It lives here rather than in `degradation-ledger.ts` because reason BUILDERS
- * (`formatToolFailure`, `firstOutputLine`) need the bound without importing the
- * ledger itself. Test files routinely `vi.mock` the ledger to observe recorded
- * degradations; a builder that reached through that mock for a constant would
- * break every one of them.
- */
-/** The single truncation bound for every ledger field, and for the reasons callers build. */
-export const LEDGER_FIELD_MAX = 200;
-/**
- * How many retained entries the ledger keeps per kind — and therefore the bound
- * any producer of ledger-bound records sizes itself to.
- *
- * Moved here from `degradation-ledger.ts` (#2426) for the reason this module's
- * doc comment already gives: `config-core/records.ts` bounds its collector to
- * this number, and reading it off the LEDGER made the config core import a sink
- * it is documented not to touch ("Pure: no state, no I/O, no ledger writes").
- * That import also broke three suites that `vi.mock` the ledger wholesale — the
- * exact failure mode this leaf exists to prevent — and closed seven import
- * cycles once the config loaders started resolving through the core.
- */
-export const DEGRADATION_ENTRIES_PER_KIND = 20;
-export function normalizeForLedger(value) {
-    if (value === null || value === undefined)
-        return "unknown";
-    // A plain object or array has no `toString` of its own, so `String()`
-    // writes "[object Object]" — a ledger row that names nothing. Serialise
-    // those; everything else (Error, Date, URL, primitives, class instances)
-    // keeps its `String()` form. An object carrying its OWN `toString` goes
-    // through `String()` too, so a throwing one still raises into the
-    // ledger's corrupted-input failsafe (#2703 r1 F1) instead of being
-    // admitted as "{}". Circular input degrades to a fixed marker.
-    if (typeof value === "object" && !Object.hasOwn(value, "toString")) {
-        const proto = Object.getPrototypeOf(value);
-        if (proto === Object.prototype || proto === null || Array.isArray(value)) {
-            try {
-                return JSON.stringify(value) ?? "unknown";
-            }
-            catch {
-                return "[unserializable object]";
-            }
-        }
-    }
-    return String(value);
-}
-/** Bound a value to `LEDGER_FIELD_MAX`, marking the elision. */
-export function truncateForLedger(value) {
-    const text = normalizeForLedger(value);
-    return text.length > LEDGER_FIELD_MAX
-        ? `${text.slice(0, LEDGER_FIELD_MAX)}…`
-        : text;
-}

package/dist/clients/lens-config.js

@@ -1,404 +0,0 @@
-import { resetIgnoredConfigWarnCache, warnIgnoredConfigOnce, } from "./config-warn.js";
-import { recordDegradationOnce } from "./degradation-ledger.js";
-import { errorClassName } from "./error-class.js";
-import * as path from "node:path";
-import { assignFlagConfigSection, flagConfigSectionKeys, flagValueFromConfig, getLensFlagSpec, GLOBAL_NON_FLAG_CONFIG_SECTIONS, LENS_FLAGS, readFlagConfigValue, } from "./lens-flag-registry.js";
-import { CANONICAL_GLOBAL_CONFIG_FILE, canonicalPathIdentity, getPiLensGlobalConfigPath, getProductionGlobalConfigResolution, GLOBAL_CONFIG_LOCATIONS, LEGACY_ROOT_LSP_KEYS, } from "./config-locations.js";
-// Re-exported so this module's own, pre-existing import sites (`./lens-config.js`
-// / `../lens-config.js`) keep working. The function itself now lives in
-// `config-locations.ts` (#2426 review round 3, S1) — see the doc comment there.
-export { getPiLensGlobalConfigPath, getProductionGlobalConfigResolution, isResolvedGlobalConfigPath, resolveGlobalConfigLocation, resetGlobalConfigLocationCache, } from "./config-locations.js";
-import { ignoredRecordCollector, readConfigDocument, reportConfigReadFailure, reportPiLensConfigRecords, resolveOnePiLensConfigDocument, } from "./config-resolve.js";
-import { findNestedProjectMutationValue, } from "./project-lens-config.js";
-import { readToolConfig } from "./tool-config.js";
-/**
- * The canonical global location, looked up rather than constructed, so a change
- * to the shared table cannot leave this loader describing a file that is no
- * longer canonical.
- */
-function globalCanonicalLocation() {
-    const location = GLOBAL_CONFIG_LOCATIONS.find((candidate) => candidate.relativePath === CANONICAL_GLOBAL_CONFIG_FILE);
-    if (!location) {
-        throw new Error(`no canonical global config location named ${CANONICAL_GLOBAL_CONFIG_FILE}`);
-    }
-    return location;
-}
-/**
- * Same warn-once-per-(path, reason) contract as project-lens-config.ts's
- * `warnInvalidConfigOnce` — a malformed global config value is logged once
- * and then treated as absent, rather than silently dropped (#792). Since #2418
- * the latch, the log line, the durable ledger row, and the stable-coded
- * notification all live in the one shared seam.
- */
-function warnInvalidGlobalConfigOnce(configPath, reason, code) {
-    warnIgnoredConfigOnce({
-        subsystem: "lens-config",
-        file: configPath,
-        reason,
-        ...(code === undefined ? {} : { code }),
-    });
-}
-/** For tests that need to force the warn-once cache to reset between cases. */
-export function resetGlobalConfigWarnCache() {
-    resetIgnoredConfigWarnCache("lens-config");
-}
-function asConfigObject(value) {
-    return value && typeof value === "object" && !Array.isArray(value)
-        ? value
-        : undefined;
-}
-/**
- * Report a probe-error RETENTION decision once (global-config-location PR,
- * refs #2457; review H2 remedy B).
- *
- * Fired by `loadPiLensGlobalConfig` when it derived the path itself and the
- * resolution retained a location whose existence probe THREW. The record
- * names the retained path (subject) and the failed probe's error class;
- * once per session via `recordDegradationOnce`. A successful
- * non-canonical selection fires nothing (opt-in by file creation, visible
- * via `pilens_effective_config`).
- */
-function reportGlobalConfigProbeRetention() {
-    const resolution = getProductionGlobalConfigResolution();
-    if (resolution.source !== "legacy-default-unprobed" &&
-        resolution.source !== "pi-coding-agent-dir-unprobed") {
-        return;
-    }
-    recordDegradationOnce({
-        kind: "config-location-probe-failed",
-        subject: resolution.path,
-        reason: `existence probe for ${resolution.existsProbeFailed?.path} failed (${resolution.existsProbeFailed?.errorClassName}); the location is retained as the config source and its read failures report through PILENS_CFG_0001`,
-        metadata: { subsystem: "lens-config", configPath: resolution.path },
-    });
-}
-/** Report a lower-precedence global config that exists beside the winner. */
-function reportGlobalConfigShadowing() {
-    const resolution = getProductionGlobalConfigResolution();
-    if (resolution.shadowedPath === undefined)
-        return;
-    const winningPath = canonicalPathIdentity(resolution.path);
-    const shadowedPath = canonicalPathIdentity(resolution.shadowedPath);
-    recordDegradationOnce({
-        kind: "config-location-shadowed",
-        subject: winningPath,
-        reason: `shadowed global config ${shadowedPath}; winning path is the record subject`,
-        metadata: {
-            subsystem: "lens-config",
-            configPath: winningPath,
-            shadowedPath,
-        },
-        code: "PILENS_CFG_0010",
-    });
-}
-export function loadPiLensGlobalConfig(configPath) {
-    // An unresolvable existence probe on the derived path is the one decision
-    // that must carry its own bounded record (#3251 review H2 remedy B): the
-    // resolution RETAINED the location it could not evaluate, the read below
-    // reports its own `config-ignored` row when it fails, and this record
-    // names the retention decision itself - the failed probe's path and error
-    // class - so "different settings silently applying" is impossible.
-    // Explicit-path callers stay silent (#2427 quiet contract); the default
-    // parameter is evaluated FIRST so the body can tell derived from explicit.
-    const derivedPath = configPath === undefined;
-    if (derivedPath) {
-        reportGlobalConfigProbeRetention();
-        reportGlobalConfigShadowing();
-    }
-    const resolvedPath = configPath ?? getPiLensGlobalConfigPath();
-    const location = globalCanonicalLocation();
-    // #2445: this used to be `JSON.parse(fs.readFileSync(...))` inside a bare
-    // `catch { return undefined; }`, so a malformed `~/.pi-lens/config.json`
-    // produced ZERO signal of its own — no log line, no ledger row, no
-    // notification. The only thing a user saw was the LSP loader's report of the
-    // SAME file, mislabelled "ignoring invalid LSP config", because that loader
-    // resolves the canonical global too. Both halves are fixed together: the
-    // read/parse failure is reported here, under `lens-config`, and
-    // `reportConfigReadFailure` derives the subsystem from the DOCUMENT so the
-    // LSP loader's report of this file lands under `lens-config` as well and the
-    // warn-once latch collapses the two into one honest notice.
-    const outcome = readConfigDocument(resolvedPath);
-    if (outcome.status === "missing")
-        return undefined;
-    if (outcome.status === "error") {
-        reportConfigReadFailure({
-            file: resolvedPath,
-            location,
-            tier: "global",
-            error: outcome.error,
-            sourceText: outcome.sourceText,
-        });
-        return undefined;
-    }
-    // Every notice this projection composes is BUFFERED and bounded once, at the
-    // end, through the SAME `ignoredRecordCollector` the project loader uses
-    // (#2426 review round 6, F3; round 7, F2). It used to report each one the
-    // moment it was composed, with no collector anywhere in this function, so
-    // the unknown-top-level-key scan below — whose count is the number of keys
-    // the user typed — put 100 notifications on screen for a 100-key
-    // `~/.pi-lens/config.json` while the project loader's identical scan of an
-    // identical file produced 19 and a count. Two changelog fragments already
-    // claimed one bound for every producer; this is the producer that did not
-    // have one.
-    //
-    // Round 6 gave it that bound by COPYING the project loader's, which left two
-    // spellings of one record literal differing only in a tier. Round 7 moved
-    // the seam into `config-resolve.ts`, which both loaders already import, and
-    // made the tier an argument. This loader never passes a `{ parseError }`:
-    // its read/parse failure is reported above by `reportConfigReadFailure`,
-    // before the projection starts.
-    //
-    // The flush is in a `finally` so a throw in the projection still delivers
-    // what was composed before it, on top of the whole-config record the catch
-    // adds.
-    const { note, records: notedRecords } = ignoredRecordCollector(resolvedPath, "global");
-    try {
-        const parsed = outcome.value;
-        if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) {
-            // The other half of the same silence: a file that PARSES but is a list
-            // or a scalar is not a config either, and was dropped without a word.
-            note("top-level value must be an object");
-            return undefined;
-        }
-        // Through the #2425 core (#2426). The canonical global file is resolved as
-        // a single `global`-tier source against the canonical schema, so the depth
-        // bound, the prototype-key policy and the declared `lsp.*` types apply to
-        // `~/.pi-lens/config.json` exactly as they do to `.pi-lens.json`. The
-        // field-by-field projection below is unchanged and keeps owning the
-        // per-key prose its tests assert on — the core validates the SHAPE, this
-        // function still decides what a bad value is called.
-        const document = {
-            tier: "global",
-            file: resolvedPath,
-            location,
-            value: parsed,
-        };
-        const resolved = resolveOnePiLensConfigDocument(document);
-        // EVERY record this document produced (#2426 review round 3, F1) — not
-        // filtered to what this loader "owns". `reportPiLensConfigRecords` derives
-        // the reporting subsystem per record; the warn-once latch collapses a
-        // duplicate report of the SAME record from the LSP loader's resolution of
-        // this same file (it resolves the canonical global too) into one notice.
-        reportPiLensConfigRecords(resolved.records);
-        const raw = resolved.value;
-        const warnInvalid = note;
-        const config = {};
-        const toolConfig = readToolConfig(raw, warnInvalid);
-        if (toolConfig)
-            config.tools = toolConfig;
-        for (const spec of LENS_FLAGS) {
-            if (spec.readGlobal)
-                continue;
-            assignFlagConfigSection(raw, config, spec.configKey, warnInvalid);
-        }
-        const ignore = Array.isArray(raw.ignore)
-            ? raw.ignore.filter((p) => typeof p === "string")
-            : undefined;
-        if (ignore && ignore.length > 0)
-            config.ignore = ignore;
-        const startup = asConfigObject(raw.startup);
-        if (startup) {
-            const startupConfig = {};
-            const mode = startup.mode;
-            const scans = asConfigObject(startup.scans);
-            if (mode === "quick" || mode === "full" || mode === "minimal")
-                startupConfig.mode = mode;
-            else if ("mode" in startup)
-                warnInvalid('startup.mode must be "quick", "full", or "minimal"');
-            if (scans) {
-                if (typeof scans.enabled === "boolean") {
-                    startupConfig.scans = { enabled: scans.enabled };
-                }
-                else if ("enabled" in scans)
-                    warnInvalid("startup.scans.enabled must be a boolean");
-            }
-            if (startupConfig.mode !== undefined || startupConfig.scans !== undefined)
-                config.startup = startupConfig;
-        }
-        const dispatch = asConfigObject(raw.dispatch);
-        if (dispatch) {
-            const floor = dispatch.runnerTimeoutFloorMs;
-            if (typeof floor === "number" && Number.isFinite(floor) && floor > 0) {
-                config.dispatch = { runnerTimeoutFloorMs: floor };
-            }
-            else {
-                // #533: warn only when the key is PRESENT but malformed — an absent
-                // key stays silent so a config that never mentions it is not falsely
-                // flagged. Same warn-once path as the maxFixes case below.
-                if ("runnerTimeoutFloorMs" in dispatch) {
-                    warnInvalid("dispatch.runnerTimeoutFloorMs must be a positive finite number");
-                }
-                config.dispatch = { runnerTimeoutFloorMs: undefined };
-            }
-        }
-        const autoFix = asConfigObject(asConfigObject(raw.actionableWarnings)?.autoFix);
-        if (autoFix && "maxFixes" in autoFix) {
-            if (typeof autoFix.maxFixes === "number" &&
-                Number.isFinite(autoFix.maxFixes) &&
-                autoFix.maxFixes >= 0) {
-                config.actionableWarnings ??= {};
-                const warnings = config.actionableWarnings;
-                warnings.autoFix ??= {};
-                warnings.autoFix.maxFixes = Math.floor(autoFix.maxFixes);
-            }
-            else {
-                warnInvalid("actionableWarnings.autoFix.maxFixes must be a non-negative finite number");
-            }
-        }
-        const widget = asConfigObject(raw.widget);
-        if (widget) {
-            if (typeof widget.visible === "boolean") {
-                config.widget = { visible: widget.visible };
-            }
-            else {
-                // #533: present-but-wrong-type warns; absent stays silent.
-                if ("visible" in widget) {
-                    warnInvalid("widget.visible must be a boolean");
-                }
-                config.widget = { visible: undefined };
-            }
-        }
-        const format = asConfigObject(raw.format);
-        if (format) {
-            config.format ??= {};
-            const formatSection = config.format;
-            if (format.mode === "immediate" || format.mode === "deferred") {
-                formatSection.mode = format.mode;
-            }
-            else {
-                // #533: a present-but-invalid mode (e.g. "immedaite") warns and // spellchecker:disable-line
-                // falls back; an absent mode stays silent.
-                if ("mode" in format) {
-                    warnInvalid('format.mode must be "immediate" or "deferred"');
-                }
-                formatSection.mode = undefined;
-            }
-        }
-        // #533 hygiene: a completely unknown top-level key (e.g. a typo like
-        // `lps` for `lsp`) is otherwise dropped silently, so a setting the user
-        // thought they made does nothing with no signal. Warn once per key. The
-        // recognized set is single-sourced (#883): the flag sections derived
-        // from the registry plus the declared non-flag global sections
-        // (`GLOBAL_NON_FLAG_CONFIG_SECTIONS`, which co-locates `$schema` and the
-        // hand-parsed namespaces beside the registry). Adding a flag needs no
-        // edit here; adding a namespace is a one-line edit in that one constant.
-        //
-        // `LEGACY_ROOT_LSP_KEYS` joins them for #2426 review round 4, F1. The four
-        // legacy root LSP keys are read out of THIS file by the LSP loader and
-        // their values are applied, exactly as they are in a project
-        // `.pi-lens.json` — where `PROJECT_FOREIGN_CONFIG_NAMESPACES` has
-        // tolerated them since #2426. The global scan never got the same
-        // treatment, so `~/.pi-lens/config.json` with a root `warmFiles` both
-        // honored the setting and called it a typo in the same session. Spread
-        // from the registry-derived list rather than restated: `lens-config.ts`
-        // already imports `config-locations.ts`, which derives it from
-        // `DEPRECATED_CONFIG_SURFACES`, so the accepted set and the removal
-        // schedule cannot drift apart and there is no second copy of the names.
-        const knownGlobalConfigKeys = new Set([
-            ...flagConfigSectionKeys(LENS_FLAGS),
-            ...GLOBAL_NON_FLAG_CONFIG_SECTIONS,
-            ...LEGACY_ROOT_LSP_KEYS,
-        ]);
-        for (const key of Object.keys(raw)) {
-            if (!knownGlobalConfigKeys.has(key)) {
-                warnInvalid(`unknown key "${key}" is not a recognized pi-lens setting (check for a typo); ignored`);
-            }
-        }
-        return config;
-    }
-    catch (error) {
-        // #2426 review round 5, S-C. The other half of #2445's silence. The
-        // read/parse failure above now reports, but everything AFTER the parse —
-        // the resolution through the core and the field-by-field projection —
-        // still sat under a bare `catch { return undefined }`, so a throw in any
-        // of it dropped the WHOLE global config with no log line, no ledger row
-        // and no notification: pi-lens ran on defaults and said nothing, which is
-        // the exact defect #2445 was filed for.
-        //
-        // `PILENS_CFG_0008` ("config resolution failed; whole configuration
-        // ignored") rather than `0001`, and the ERROR CLASS only, never its
-        // message, which could quote the file — the same rule `resolveConfig`'s
-        // own guard follows for the same reason. Round 5 used `0005` here, which
-        // is registered as a per-FIELD rejection: a user matching on it would
-        // have expected one setting to be missing rather than the whole file
-        // (#2426 review round 6, S1). `errorClassName` (#2451) is the ONE
-        // implementation of "class name, never the message" — this loader
-        // already imports `config-warn.js` for the rest of the seam, so it could
-        // call `normalizeParseErrorReason({ classOnly: true })` directly, but
-        // calling the same leaf `config-warn.ts` itself delegates to keeps every
-        // caller of this guarantee, `config-core/` included, on ONE
-        // implementation rather than two that happen to agree today.
-        warnInvalidGlobalConfigOnce(resolvedPath, `global config could not be interpreted (${errorClassName(error)}); configuration ignored`, "PILENS_CFG_0008");
-        return undefined;
-    }
-    finally {
-        reportPiLensConfigRecords(notedRecords());
-    }
-}
-export function getGlobalIgnorePatterns(configPath) {
-    return loadPiLensGlobalConfig(configPath)?.ignore ?? [];
-}
-export function getGlobalWidgetDefaultVisible(configPath) {
-    return loadPiLensGlobalConfig(configPath)?.widget?.visible !== false;
-}
-/** Per-turn quickfix cap; undefined means "use the built-in default of 5". */
-export function getGlobalActionableWarningMaxFixes(configPath) {
-    return loadPiLensGlobalConfig(configPath)?.actionableWarnings?.autoFix
-        ?.maxFixes;
-}
-/**
- * Resolve a flag AND report which config tier decided it — same precedence
- * as {@link resolvePiLensFlag} (which now delegates here), just also
- * returning the `source` so callers can log e.g.
- * "(--no-autofix, source=project)" instead of a bare boolean (#792).
- *
- * Every tier is driven by `clients/lens-flag-registry.ts` (#166): the spec's
- * `configKey` is read out of each config object rather than matched by a
- * per-flag branch, so a new toggle needs no change here at all.
- *
- * Precedence: env → cli → nested-project → project → global → default.
- * Project tiers apply to `scope: "project"` flags only (maintainer decision —
- * project wins over global, including re-enabling; only an explicit CLI
- * disabling flag outranks project config). A name with no registry entry
- * passes its CLI value straight through, which is how untyped string flags
- * like `--lens-opengrep-config` keep working.
- */
-export function resolvePiLensFlagWithSource(name, value, config, projectConfig, editedFilePath, projectRoot) {
-    const spec = getLensFlagSpec(name);
-    if (spec?.env && process.env[spec.env] === "1") {
-        return { value: true, source: "env" };
-    }
-    if (value)
-        return { value, source: "cli" };
-    if (!spec)
-        return { value, source: "default" };
-    if (spec.scope === "project") {
-        const nested = editedFilePath && projectRoot
-            ? findNestedProjectMutationValue(spec, editedFilePath, projectRoot)
-            : undefined;
-        if (nested) {
-            return {
-                value: flagValueFromConfig(spec, nested.value),
-                source: path.resolve(nested.dir) === path.resolve(projectRoot)
-                    ? "project"
-                    : `nested-project:${nested.dir}`,
-            };
-        }
-        const projectValue = readFlagConfigValue(projectConfig, spec.configKey);
-        if (projectValue !== undefined) {
-            return {
-                value: flagValueFromConfig(spec, projectValue),
-                source: "project",
-            };
-        }
-    }
-    const globalValue = spec.readGlobal
-        ? spec.readGlobal((config ?? {}))
-        : readFlagConfigValue(config, spec.configKey);
-    if (globalValue !== undefined) {
-        return { value: flagValueFromConfig(spec, globalValue), source: "global" };
-    }
-    return { value: spec.default, source: "default" };
-}
-export function resolvePiLensFlag(name, value, config, projectConfig, editedFilePath, projectRoot) {
-    return resolvePiLensFlagWithSource(name, value, config, projectConfig, editedFilePath, projectRoot).value;
-}