pi-lens 4.3.0 → 4.4.0

package/dist/clients/demoted-finding-render.js

@@ -1,169 +0,0 @@
-/**
- * Body degradation for a DEMOTED finding (#1944).
- *
- * The demotion gates (#1631 dependency-drift, #1641 past-EOF) move a record
- * out of the authoritative blocker channel and into the advisory channel.
- * Until this module existed they changed the CHANNEL and nothing else: the
- * advisory embedded the blocker body verbatim, so the agent still read
- * "🔴 STOP — 11 issue(s) must be fixed" with dead line numbers under two
- * hedge lines it ignored. Live evidence (session 01a0234c, 2026-08-21): the
- * agent spent four re-run detours and about 7.4k tokens on a record whose
- * coordinates no longer existed, then explained an unrelated REAL blocker
- * away as "mid-edit state" in the same session.
- *
- * The rule this module owns, once, for every gated surface: a demoted body
- * loses its authority vocabulary and its dead coordinates, and it says so in
- * its own words. `clients/finding-delivery-gate.ts` documents the surrounding
- * contract; this is the one implementation of its "Demotion rendering" arm
- * for surfaces that carry a RENDERED BODY rather than a per-diagnostic row.
- * Per-row surfaces (`widget-state.ts`, `tools/lens-diagnostics.ts`) already
- * swap the coordinate for `PAST_EOF_STALE_MARKER` at render time and have no
- * body to degrade.
- *
- * Pure and leaf: no store, no coordinator, no I/O. The caller supplies the
- * dead lines it already computed while deciding to demote, so this module
- * never re-derives a verdict from rendered prose (the
- * re-derivation-vs-correlation screen).
- */
-/** Suffix that replaces a cited coordinate the file no longer has. */
-export const DEAD_LINE_ANNOTATION = "(line no longer exists)";
-/**
- * Authority vocabulary a demoted body must not carry, with its degraded
- * replacement. Ordered: the full banner rewrite runs first so the narrower
- * fallbacks only ever see text the banner rule did not already cover.
- *
- * This table is the single source of truth for the rule. A surface must not
- * hand-roll its own "strip the STOP" pass — that is how #1631, #1641, and
- * #1664 each ended up with a different answer to the same question.
- *
- * POSITION-ANCHORED (#1944 review F1). These patterns run over the BANNER
- * region only, never the whole body. Diagnostic messages are arbitrary text
- * from arbitrary runners, and they legitimately contain both tokens: the
- * reviewer's probe turned ts(2304) `Cannot find name 'STOP'` into `Cannot
- * find name 'Previously flagged'`, and mangled an English "must be fixed"
- * inside a rule message. Rewriting a finding's own words is a worse defect
- * than the banner it was cleaning up. See `splitBannerRegion`.
- */
-const AUTHORITY_REWRITES = [
-    [
-        /[^\S\n]*(?:🔴|⛔|❌)?[^\S\n]*STOP[^\S\n]*[—–-][^\S\n]*(\d+)[^\S\n]+issue\(s\)[^\S\n]+must be fixed:?/g,
-        "$1 issue(s) were flagged before this file changed; the coordinates below may no longer exist:",
-    ],
-    [/(?:🔴|⛔|❌)[^\S\n]*STOP\b[^\S\n]*[—–-]?/g, "Previously flagged —"],
-    [/\bSTOP\b/g, "Previously flagged"],
-    [/\bmust be fixed\b/g, "were flagged"],
-];
-/** `  L310: message` / `L310 message` at the head of a rendered row. */
-const CITED_LINE_RE = /^([^\S\n]*)L(\d+)\b/;
-/**
- * Split a rendered body into its BANNER region and its CONTENT region
- * (#1944 review F1).
- *
- * The body this module degrades is `InlineBlockerRecord.summary`, and its one
- * producer is `formatDiagnostics(inlineBlockers, "blocking")`
- * (`clients/dispatch/utils/format-utils.ts`), reaching the store as
- * `dispatchResult.blockerOutput` -> `PipelineResult.inlineBlockerSummary` ->
- * `recordInlineBlockers`. (`buildEnrichedBlockerOutput` in
- * `clients/pipeline.ts` renders the same shape with code snippets, but it
- * feeds the TOOL-RESULT output shown inline during the write, not this
- * stored summary. #1944 review round: naming it here as a producer was
- * wrong.) The shape is a header, then one `  L<n>: <message>` row per
- * diagnostic, then indented continuations (`💡 Fix: …`) and an optional
- * `… and N more` tail. So the first cited-line row is the boundary:
- * everything above it is ours to rewrite, everything from it down is the
- * findings' own words.
- *
- * A body with no cited row at all — `formatDiagnostics` omits `L<n>` for a
- * lineless diagnostic — falls back to the first NON-BLANK line. Leading
- * blanks must be skipped rather than counted (#1944 verify round, Edge-D):
- * `formatDiagnostics` opens its output with a newline, so a naive "first
- * line is the banner" rule degrades an empty string and leaves the real
- * header at full authority. Production is currently saved from that only by
- * an undocumented `.trim()` at `clients/pipeline.ts` (`inlineBlockerSummary`),
- * and this module claims to own the rule, so it must hold on its own input.
- */
-function splitBannerRegion(lines) {
-    const firstCitedRow = lines.findIndex((line) => CITED_LINE_RE.test(line));
-    if (firstCitedRow !== -1)
-        return { bannerEnd: firstCitedRow };
-    const firstNonBlank = lines.findIndex((line) => line.trim() !== "");
-    return { bannerEnd: firstNonBlank === -1 ? 0 : firstNonBlank + 1 };
-}
-/**
- * Degrade one demoted finding's rendered body.
- *
- * Two independent transforms, deliberately separable so each can be proven by
- * its own test (and so deleting either one reds a different assertion):
- *
- *   1. Authority vocabulary: the STOP banner and the "must be fixed"
- *      imperative are rewritten to past-tense, non-directive wording.
- *   2. Dead coordinates: every cited `L<n>` whose line the file no longer has
- *      renders as `L<n> (line no longer exists)`. The message text stays —
- *      demote, never drop (#1419).
- */
-export function degradeDemotedFindingBody(summary, options = {}) {
-    const deadLines = new Set(options.deadLines ?? []);
-    let authorityMarkersRemoved = 0;
-    const sourceLines = summary.split("\n");
-    const { bannerEnd } = splitBannerRegion(sourceLines);
-    const degradedLines = sourceLines.map((line, index) => {
-        // Content rows keep every character. Only the banner region is ours.
-        if (index >= bannerEnd)
-            return line;
-        let rewritten = line;
-        for (const [pattern, replacement] of AUTHORITY_REWRITES) {
-            rewritten = rewritten.replace(pattern, (...args) => {
-                authorityMarkersRemoved += 1;
-                // Expand `$n` against this match's capture groups by hand. A nested
-                // `String.replace` with the SAME global regex would clobber the
-                // outer call's `lastIndex` mid-iteration.
-                return replacement.replace(/\$(\d)/g, (_, digit) => String(args[Number(digit)] ?? ""));
-            });
-        }
-        return rewritten;
-    });
-    let body = degradedLines.join("\n");
-    const deadLinesAnnotated = [];
-    if (deadLines.size > 0) {
-        body = degradedLines
-            .map((line) => {
-            const hit = CITED_LINE_RE.exec(line);
-            if (!hit)
-                return line;
-            const cited = Number.parseInt(hit[2] ?? "", 10);
-            if (!Number.isFinite(cited) || !deadLines.has(cited))
-                return line;
-            deadLinesAnnotated.push(cited);
-            return `${hit[1] ?? ""}L${cited} ${DEAD_LINE_ANNOTATION}${line.slice(hit[0].length)}`;
-        })
-            .join("\n");
-    }
-    return { body, authorityMarkersRemoved, deadLinesAnnotated };
-}
-/**
- * The one-line note a surface appends when it RETIRES a demoted finding after
- * its single degraded delivery. Rendered inside the advisory itself, so an
- * empty advisory section can only ever mean "nothing to say" — if something
- * was dropped, this line is in the payload (#1944 AC3).
- */
-export function formatRetirementNote(deadLines) {
-    const cited = deadLines.length > 0
-        ? ` (cited ${deadLines.length === 1 ? "line" : "lines"} ${deadLines.join(", ")})`
-        : "";
-    return (`Retired after this delivery${cited}: the file no longer has these lines, ` +
-        "so this finding cannot be re-confirmed and will not be served again.");
-}
-/**
- * The one-line note a surface appends when it RETIRES a dependency-drift
- * demotion at its delivery cap (#1950). Deliberately worded differently from
- * {@link formatRetirementNote}: that one means the finding is provably
- * unrecoverable (the cited lines are gone), while THIS retirement is a
- * bounded-noise cap on a record that is still recoverable — a fresh dispatch
- * of the file could still confirm or clear it. Saying "cannot be re-confirmed"
- * here would be false.
- */
-export function formatDeliveryCapNote(deliveryCount) {
-    return (`Not shown again after ${deliveryCount} deliveries with no re-run: ` +
-        "this finding may still be accurate, but re-serving it further adds no " +
-        "new information. A fresh dispatch of this file will re-confirm or clear it.");
-}