pi-lens 4.1.5 → 4.2.0

package/dist/clients/dispatch/runners/spellcheck.js

@@ -20,7 +20,7 @@
  */
 import { safeSpawnAsync } from "../../safe-spawn.js";
 import { PRIORITY } from "../priorities.js";
-import { createAvailabilityChecker } from "./utils/runner-helpers.js";
+import { createAvailabilityChecker, resolveRunnerCwd, } from "./utils/runner-helpers.js";
 import { parseToolRun } from "./utils/tool-failure.js";
 const typos = createAvailabilityChecker("typos", ".exe");
 // typos-cli exit codes: 0 = no typos, 2 = typos found, 1 = an error that
@@ -82,7 +82,7 @@ const spellcheckRunner = {
     priority: PRIORITY.DOC_QUALITY,
     skipTestFiles: false, // Check docs in test files too
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "spellcheck/typos");
         // Skip if typos-cli is not installed
         if (!(await typos.isAvailableAsync(cwd))) {
             return { status: "skipped", diagnostics: [], semantic: "none" };

package/dist/clients/dispatch/runners/spotbugs.js

@@ -3,6 +3,7 @@ import * as os from "node:os";
 import * as path from "node:path";
 import { BoundedLruCache } from "../../bounded-cache.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { findCompiledClassesDir } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveAvailableOrInstall, } from "./utils/runner-helpers.js";
@@ -191,7 +192,7 @@ const spotbugsRunner = {
     appliesTo: ["java", "kotlin"],
     priority: PRIORITY.DEEP_LANGUAGE_ANALYSIS,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "spotbugs");
         const classesDir = findCompiledClassesDir(cwd);
         if (!classesDir) {
             ctx.log?.("spotbugs: Java project detected but no compiled .class files found — run `mvn compile` / `gradle build` first");

package/dist/clients/dispatch/runners/sqlfluff.js

@@ -1,4 +1,5 @@
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { logRunnerAdvisoryOnce, resolveRunnerCwd } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd, hasSqlfluffConfig } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
@@ -117,14 +118,14 @@ const sqlfluffRunner = {
     priority: PRIORITY.SQL_LINT,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "sqlfluff");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("sqlfluff")) {
             return { status: "skipped", diagnostics: [], semantic: "none" };
         }
         const hasConfig = hasSqlfluffConfig(cwd);
         if (!hasConfig) {
-            ctx.log("sqlfluff: no config detected, using ANSI dialect defaults");
+            logRunnerAdvisoryOnce(ctx, "sqlfluff", cwd, "sqlfluff: no config detected, using ANSI dialect defaults");
         }
         let cmd = null;
         if (await sqlfluff.isAvailableAsync(cwd)) {

package/dist/clients/dispatch/runners/stylelint.js

@@ -1,5 +1,6 @@
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { logRunnerAdvisoryOnce, resolveRunnerCwd } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd, hasStylelintConfig, } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
@@ -116,7 +117,7 @@ const stylelintRunner = {
     priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "stylelint");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("stylelint")) {
             return { status: "skipped", diagnostics: [], semantic: "none" };
@@ -124,7 +125,7 @@ const stylelintRunner = {
         const fileDir = path.dirname(path.resolve(cwd, ctx.filePath));
         const hasConfig = hasStylelintConfig(fileDir) || hasStylelintConfig(cwd);
         if (!hasConfig) {
-            ctx.log("stylelint: no config detected, running with default rules");
+            logRunnerAdvisoryOnce(ctx, "stylelint", cwd, "stylelint: no config detected, running with default rules");
         }
         let cmd = null;
         if (await stylelint.isAvailableAsync(cwd)) {

package/dist/clients/dispatch/runners/swiftlint.js

@@ -1,5 +1,6 @@
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
 import { parseToolRun } from "./utils/tool-failure.js";
@@ -115,7 +116,7 @@ const swiftlintRunner = {
     priority: PRIORITY.GENERAL_ANALYSIS,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "swiftlint");
         let cmd = null;
         if (await swiftlint.isAvailableAsync(cwd)) {
             cmd = swiftlint.getCommand(cwd);

package/dist/clients/dispatch/runners/taplo.js

@@ -1,6 +1,7 @@
 import * as path from "node:path";
 import { findLocalBinUpwards } from "../../package-manager.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, lspPrimaryCoversFile, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
@@ -106,7 +107,7 @@ const taploRunner = {
     priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "taplo");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("taplo")) {
             return { status: "skipped", diagnostics: [], semantic: "none" };

package/dist/clients/dispatch/runners/terragrunt.js

@@ -1,5 +1,6 @@
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { pathsEqual } from "../../path-utils.js";
 import { getLinterPolicyForCwd } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
@@ -128,7 +129,7 @@ const terragruntRunner = {
     priority: PRIORITY.GENERAL_ANALYSIS,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "terragrunt");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("terragrunt"))
             return SKIPPED;

package/dist/clients/dispatch/runners/tflint.js

@@ -1,5 +1,6 @@
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd } from "../../tool-policy.js";
 import { findNearestDirWithAnyBasename } from "../../workspace-topology.js";
 import { PRIORITY } from "../priorities.js";
@@ -52,7 +53,7 @@ const tflintRunner = {
     priority: PRIORITY.GENERAL_ANALYSIS,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "tflint");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("tflint")) {
             return { status: "skipped", diagnostics: [], semantic: "none" };

package/dist/clients/dispatch/runners/tree-sitter.js

@@ -6,7 +6,7 @@
  */
 import * as path from "node:path";
 import { RuleCache } from "../../cache/rule-cache.js";
-import { minimatch } from "../../deps/minimatch.js";
+import { isRuleIgnoredForPath } from "../rule-ignores.js";
 import { isTestFile } from "../../file-utils.js";
 import { buildOrUpdateGraph, computeImpactCascade, recordEntitySnapshotDiff, } from "../../review-graph/service.js";
 import { getSharedTreeSitterClient, isTreeSitterWasmAborted, markTreeSitterWasmAborted, resolveTreeSitterLanguage, } from "../../tree-sitter-shared.js";
@@ -292,25 +292,6 @@ function getTotalLinesChanged(ranges) {
 }
 /** Threshold: skip entity extraction for changes under 5 lines */
 const ENTITY_EXTRACTION_LINE_THRESHOLD = 5;
-/**
- * `filePath` relative to `root`, forward-slashed, for matching a rule's
- * `ignore_paths` globs. Falls back to the absolute (slash-normalized) path
- * when `filePath` isn't under `root` (e.g. an out-of-tree temp file), so a
- * glob like `scripts/**` simply never matches rather than throwing.
- */
-function relativeForIgnoreGlob(filePath, root) {
-    const rel = path.relative(root, filePath);
-    const normalized = (rel.startsWith("..") ? filePath : rel)
-        .split(path.sep)
-        .join("/");
-    return normalized;
-}
-function matchesIgnorePaths(filePath, root, patterns) {
-    if (!patterns || patterns.length === 0)
-        return false;
-    const rel = relativeForIgnoreGlob(filePath, root);
-    return patterns.some((pattern) => minimatch(rel, pattern, { dot: true }));
-}
 const treeSitterRunner = {
     id: "tree-sitter",
     appliesTo: [
@@ -447,7 +428,7 @@ const treeSitterRunner = {
         const effectiveQueries = (ctx.blockingOnly
             ? languageQueries.filter((q) => q.inline_tier !== "review")
             : languageQueries).filter((q) => !(fileIsTest && q.skip_test_files) &&
-            !matchesIgnorePaths(filePath, ignoreRoot, q.ignore_paths));
+            !isRuleIgnoredForPath(filePath, ignoreRoot, q.ignore_paths));
         logTreeSitter({
             phase: "queries_loaded",
             filePath,

package/dist/clients/dispatch/runners/trivy-config.js

@@ -40,6 +40,7 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { incrementDegradationCount } from "../../degradation-ledger.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { isTrivyEnabled, resolveSeverityFloor, } from "../../trivy-client.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveAvailableOrInstall, } from "./utils/runner-helpers.js";
@@ -148,7 +149,7 @@ const trivyConfigRunner = {
     priority: PRIORITY.GENERAL_ANALYSIS,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "trivy-config");
         // Single opt-in switch — trivy is opt-in across all modes.
         if (!isTrivyEnabled(cwd)) {
             return { status: "skipped", diagnostics: [], semantic: "none" };

package/dist/clients/dispatch/runners/utils/availability-policy.js

@@ -75,6 +75,11 @@ export function describeInstallAttempt(attempt, options = {}) {
             return { install: "succeeded", ...(reason && { installReason: reason }) };
         case "failed":
             return { install: "failed", ...(reason && { installReason: reason }) };
+        case "unavailable":
+            return {
+                install: "unavailable",
+                ...(reason && { installReason: reason }),
+            };
         default:
             return {
                 install: "not-attempted",

package/dist/clients/dispatch/runners/utils/candidate-probe.js

@@ -11,7 +11,7 @@
  * Complexity limit. This is that sweep, written once.
  */
 import * as fs from "node:fs";
-import { safeSpawnAsync } from "../../../safe-spawn.js";
+import { probeToolAsync } from "../../../tool-probe.js";
 import { classifyProbeFailure, startHostStallSampler, } from "./availability-policy.js";
 /**
  * Walk `candidates` in order. A candidate containing a path separator is
@@ -45,7 +45,7 @@ export async function probeAvailabilityCandidates(candidates, probeArgs, timeout
             let result;
             let stallMs;
             try {
-                result = await safeSpawnAsync(candidate, [...probeArgs], {
+                result = await probeToolAsync(candidate, probeArgs, {
                     timeout: timeoutMs,
                 });
             }

package/dist/clients/dispatch/runners/utils/runner-helpers.js

@@ -20,9 +20,11 @@ import { getServersForFileWithConfig, isServerDisabled, } from "../../../lsp/con
 import { findGlobalBinary, findLocalBinAt, findLocalBinsUpwards, findLocalBinUpwards, VENDOR_BIN_DIRS, VENV_BIN_DIRS, } from "../../../package-manager.js";
 import { logLatency } from "../../../latency-logger.js";
 import { safeSpawnAsync } from "../../../safe-spawn.js";
+import { probeToolAsync } from "../../../tool-probe.js";
 import { compareOrdinal } from "../../../string-utils.js";
 import { getToolCommandSpec, shouldAutoInstallTool, } from "../../../tool-policy.js";
 import { isInSpawnTimeoutCooldown } from "../../../spawn-timeout-cooldown.js";
+import { resolveToolCwd } from "../../../tool-cwd.js";
 import { createAvailabilityProbeFlight } from "../../../availability-probe-flight.js";
 import { classifyProbeFailure, createAvailabilityLatch, describeInstallAttempt, describeProbeEvidence, isLatchingOutcome, logAvailabilityDecision, startHostStallSampler, transientRetryDelayMs, } from "./availability-policy.js";
 export { createAvailabilityLatch, classifyProbeFailure, describeProbeEvidence, describeUnavailability, isTransientDecision, logAvailabilityDecision, startHostStallSampler, } from "./availability-policy.js";
@@ -1390,7 +1392,7 @@ async function probeAstGrepCommandAsync(cmd, argsPrefix = []) {
     let check;
     let hostStallMs;
     try {
-        check = await safeSpawnAsync(cmd, [...argsPrefix, "--version"], {
+        check = await probeToolAsync(cmd, [...argsPrefix, "--version"], {
             timeout: 5000,
         });
     }
@@ -1674,7 +1676,7 @@ export async function resolveLocalFirstAsync(toolName, cwd, windowsExt = ".cmd")
     if (globalBin)
         return { cmd: globalBin, args: [] };
     // 3. Global PATH (already installed system-wide, on PATH)
-    const globalCheck = await safeSpawnAsync(toolName, ["--version"], {
+    const globalCheck = await probeToolAsync(toolName, ["--version"], {
         timeout: 3000,
     });
     if (!globalCheck.error && globalCheck.status === 0) {
@@ -1693,3 +1695,7 @@ export const sg = {
     isAvailableAsync: isSgAvailableAsync,
     getCommand: getSgCommand,
 };
+/** Shared cwd seam for runner probes and analysis children (#2777). */
+export function resolveRunnerCwd(ctx, tool) {
+    return resolveToolCwd("runner", tool, ctx.filePath, ctx).cwd;
+}

package/dist/clients/dispatch/runners/vale.js

@@ -1,6 +1,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
 import { parseToolRun } from "./utils/tool-failure.js";
@@ -72,7 +73,7 @@ const valeRunner = {
     priority: PRIORITY.DOC_QUALITY,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "vale");
         // Config-gated: skip unless a .vale.ini is found
         if (!findValeConfig(cwd)) {
             return { status: "skipped", diagnostics: [], semantic: "none" };

package/dist/clients/dispatch/runners/yamllint.js

@@ -1,7 +1,8 @@
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { logRunnerAdvisoryOnce } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd, hasYamllintConfig } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
-import { createAvailabilityChecker, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
+import { createAvailabilityChecker, resolveRunnerCwd, resolveToolCommandWithInstallFallback, } from "./utils/runner-helpers.js";
 import { parseToolRun } from "./utils/tool-failure.js";
 import { finishParsedRun } from "./utils/tool-failure.js";
 const yamllint = createAvailabilityChecker("yamllint", ".exe");
@@ -35,14 +36,14 @@ const yamllintRunner = {
     priority: PRIORITY.YAML_LINT,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "yamllint");
         const policy = getLinterPolicyForCwd(ctx.filePath, cwd);
         if (policy && !policy.preferredRunners.includes("yamllint")) {
             return { status: "skipped", diagnostics: [], semantic: "none" };
         }
         const hasConfig = hasYamllintConfig(cwd);
         if (!hasConfig) {
-            ctx.log("yamllint: no config detected, running with default rules");
+            logRunnerAdvisoryOnce(ctx, "yamllint", cwd, "yamllint: no config detected, running with default rules");
         }
         let cmd = null;
         if (await yamllint.isAvailableAsync(cwd)) {

package/dist/clients/dispatch/runners/zig-check.js

@@ -1,5 +1,6 @@
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
+import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { createAvailabilityChecker } from "./utils/runner-helpers.js";
 import { PRIORITY } from "../priorities.js";
 // zig rejects `--version`; the version subcommand is `zig version`. Using the
@@ -46,7 +47,7 @@ const zigCheckRunner = {
     priority: PRIORITY.GENERAL_ANALYSIS,
     skipTestFiles: false,
     async run(ctx) {
-        const cwd = ctx.cwd || process.cwd();
+        const cwd = resolveRunnerCwd(ctx, "zig-check");
         if (!(await zig.isAvailableAsync(cwd))) {
             return { status: "skipped", diagnostics: [], semantic: "none" };
         }

package/dist/clients/dispatch/types.js

@@ -11,7 +11,10 @@
  * The dispatcher must handle these semantics consistently.
  */
 /** Closed telemetry taxonomy for expected runner skips. */
-export const RUNNER_SKIP_REASONS = ["no-files-matched"];
+export const RUNNER_SKIP_REASONS = [
+    "no-files-matched",
+    "configured-non-biome-linter",
+];
 /** Runtime guard for untyped/plugin-provided runner results. */
 export function isRunnerSkipReason(value) {
     return RUNNER_SKIP_REASONS.some((reason) => reason === value);

package/dist/clients/disposition-publish.js

@@ -97,6 +97,7 @@ export function publishDisposition(args) {
             line: args.line,
             anchor: args.anchor,
             reason: args.reason,
+            message: args.message,
         };
         busEmit(BUS_DISPOSITION_EVENT, payload);
         hasLoggedFailure = false;

package/dist/clients/effective-config.js

@@ -47,7 +47,9 @@ import { explainServersForFile, lspConfigOf, registerLSPConfig, } from "./lsp/co
 // apart on a Windows-shaped path (AGENTS.md defect shape 2).
 import { isSameOrWithin } from "./lsp/server.js";
 import { homeRelativePath } from "./path-utils.js";
+import { resolveToolCwd } from "./tool-cwd.js";
 import { compareOrdinal } from "./string-utils.js";
+import { LENS_TOOL_NAMES, resolveLensToolEnabled } from "./tool-config.js";
 /** True when a `file` half is the rejection shape, not a resolved view. */
 export function isEffectiveFileViewError(file) {
     return "error" in file;
@@ -289,6 +291,10 @@ export async function effectiveConfig(options = {}) {
         provenance: provenanceView(resolved, homeDir).entries,
         provenanceCounts: summary.countsByTier,
         recordCounts: countBy(resolution.records, (record) => record.code),
+        tools: LENS_TOOL_NAMES.map((name) => ({
+            name,
+            enabled: resolveLensToolEnabled(name, resolved.value, undefined, options.noTools),
+        })),
         ...(fileOutsideCwd
             ? {
                 file: {
@@ -299,7 +305,7 @@ export async function effectiveConfig(options = {}) {
             : absolute === undefined
                 ? {}
                 : {
-                    file: await fileView(absolute, resolved, homeDir, 
+                    file: await fileView(absolute, resolved, homeDir, cwd, 
                     // The gates read the LSP slice of that SAME resolution, through
                     // the same `registerLSPConfig` conversion `initLSPConfig` uses —
                     // no session-root registration, no per-root config-store write
@@ -325,7 +331,7 @@ function toolReason(selected, kind) {
         return "selected";
     return kind === undefined ? "no-dispatch-plan" : "not-registered-for-kind";
 }
-async function fileView(absolute, resolved, homeDir, lspConfig) {
+async function fileView(absolute, resolved, homeDir, workspaceCwd, lspConfig) {
     const language = resolveLanguage(absolute);
     const kind = detectFileKind(absolute);
     const section = lspSectionOf(resolved.value);
@@ -392,6 +398,10 @@ async function fileView(absolute, resolved, homeDir, lspConfig) {
         id,
         selected: available.has(id),
         reason: toolReason(available.has(id), kind),
+        resolvedCwd: homeRelativePath(resolveToolCwd("runner", id, absolute, {
+            cwd: workspaceCwd,
+            suppressTelemetry: true,
+        }).cwd, homeDir),
     }));
     return {
         path: homeRelativePath(absolute, homeDir),

package/dist/clients/extension-log.js

@@ -26,6 +26,7 @@ import { isTestMode } from "./env-utils.js";
 import { getGlobalPiLensLogDir } from "./probe-home-state.js";
 import { getMaxLogSizeMB } from "./log-cleanup.js";
 import { createNdjsonLogger } from "./ndjson-logger.js";
+import { getTurnId } from "./turn-context.js";
 export const EXTENSION_LOG_FILE = path.join(getGlobalPiLensLogDir(), "extension.log");
 const writer = createNdjsonLogger({
     filePath: EXTENSION_LOG_FILE,
@@ -37,6 +38,7 @@ export function logExtension(entry) {
     writer.log({
         ts: new Date().toISOString(),
         pid: process.pid,
+        turnId: getTurnId(),
         level: entry.level ?? "error",
         subsystem: entry.subsystem,
         message: entry.message,

package/dist/clients/file-kinds.js

@@ -4,7 +4,10 @@
  * Centralized file type detection to avoid duplication across clients.
  * Maps file extensions and paths to semantic file kinds.
  */
-import { basename, extname } from "node:path";
+import { basename, extname, win32 } from "node:path";
+import * as path from "node:path";
+import { isWindowsPath } from "./path-utils.js";
+import { findNearestDirWithMarker } from "./workspace-topology.js";
 // --- Extension Maps ---
 export const KIND_EXTENSIONS = {
     clojure: [".clj", ".cljc", ".cljs", ".edn"],
@@ -40,6 +43,9 @@ export const KIND_EXTENSIONS = {
         ".cu",
         // HIP
         ".hip",
+        // CUDA/HIP header convention; clang's driver table omits `.cuh`, but
+        // projects use it for C++ headers that must remain in the cxx kind (#2986).
+        ".cuh",
         // Objective-C
         ".m",
         ".mm",
@@ -179,6 +185,22 @@ export const SPECIAL_FILENAMES = [
     })),
 ];
 // --- Detection Functions ---
+/**
+ * Helm renders YAML-looking files as Go templates before they become YAML.
+ * Require the shared chart-root marker before promoting a YAML template, so
+ * ordinary repositories can use a `templates/` directory without entering
+ * Helm dispatch. `.tpl` remains extension-classified below.
+ */
+export function isHelmYamlTemplatePath(filePath) {
+    const templatesSegment = isWindowsPath(filePath)
+        ? /[\\/]templates[\\/]/i
+        : /\/templates\//i;
+    if (!templatesSegment.test(filePath) || !/\.ya?ml$/i.test(filePath)) {
+        return false;
+    }
+    const pathApi = isWindowsPath(filePath) ? win32 : path;
+    return Boolean(findNearestDirWithMarker(pathApi.dirname(filePath), "chartYamlPath"));
+}
 /**
  * Detect the file kind from a file path.
  * Returns the semantic file kind or undefined if unknown.
@@ -187,6 +209,9 @@ export function detectFileKind(filePath) {
     if (!filePath || typeof filePath !== "string") {
         return undefined;
     }
+    if (isHelmYamlTemplatePath(filePath)) {
+        return "helm-template";
+    }
     // Check special filenames first
     const base = basename(filePath);
     for (const { pattern, kind } of SPECIAL_FILENAMES) {

package/dist/clients/file-role.js

@@ -34,6 +34,24 @@ function isTypeStub(content) {
         /^export\s+type\s+\{/.test(l));
     return typeOnlyLines.length / lines.length >= 0.75;
 }
+// Shared filename predicate (#2928). The parity test iterates the runner's
+// discovery table; additional conventions are pinned in file-role.test.ts.
+// Keep the case-preserved basename for CamelCase suffixes (contest.java is source).
+function testFileNameMatches(rawBase, base) {
+    return (base.includes(".test.") ||
+        base.includes(".spec.") ||
+        base.includes("_test.") ||
+        base.includes("_spec.") ||
+        base.startsWith("test_") ||
+        base.startsWith("spec_") ||
+        /(Test|Tests|TestCase)\.(java|kt|kts|cs|fs|php)$/.test(rawBase));
+}
+/** Filename-only classification for consumers with their own directory policy. */
+export function isTestFileName(filePath) {
+    const windowsShaped = isWindowsPath(filePath);
+    const rawBase = windowsShaped ? win32.basename(filePath) : basename(filePath);
+    return testFileNameMatches(rawBase, rawBase.toLowerCase());
+}
 /**
  * Classify the structural role of a file. Pass `content` for higher
  * accuracy (enables generated-code detection, barrel detection, etc.).
@@ -51,16 +69,15 @@ function isTypeStub(content) {
  */
 export function detectFileRole(filePath, content) {
     const windowsShaped = isWindowsPath(filePath);
-    const base = (windowsShaped ? win32.basename(filePath) : basename(filePath)).toLowerCase();
+    const rawBase = windowsShaped ? win32.basename(filePath) : basename(filePath);
+    const base = rawBase.toLowerCase();
     const dir = (windowsShaped ? win32.dirname(filePath) : dirname(filePath))
         .replace(/\\/g, "/")
         .toLowerCase();
     // --- Test ---
-    if (base.includes(".test.") ||
-        base.includes(".spec.") ||
-        base.startsWith("test_") ||
-        base.startsWith("spec_") ||
-        dir.includes("/__tests__/") ||
+    // #2928: dirname has no trailing slash; match direct __tests__ children too.
+    if (testFileNameMatches(rawBase, base) ||
+        /(^|[\\/])__tests__([\\/]|$)/.test(dir) ||
         dir.includes("/test/") ||
         dir.includes("/tests/") ||
         dir.includes("/spec/") ||