pi-lens 4.1.5 → 4.2.0

package/dist/clients/actionable-warnings.js

@@ -13,6 +13,8 @@ import { toRunnerDisplayPath } from "./dispatch/runner-context.js";
 import { logActionableWarningsEvent } from "./actionable-warnings-logger.js";
 import { displayProjectDataPath, getProjectDataDir } from "./file-utils.js";
 import { commitDurableStore } from "./durable-store.js";
+import { establishToolAgreement } from "./tool-agreement.js";
+import { resolveLensToolName } from "./tool-config.js";
 let beforeWarningStateLockForTests = null;
 /** Test seam for a sibling process commit immediately before lock acquisition. */
 export function _setBeforeWarningStateLockForTests(hook) {
@@ -252,11 +254,15 @@ function lineInModifiedRanges(line, ranges) {
 function recordFromLspDiagnostic(diag, filePath, cwd) {
     const line = diag.range.start.line + 1;
     const column = diag.range.start.character + 1;
+    // Keep agreement keyed to the producer that supplied the diagnostic. The
+    // generic `lsp` label is only a last-resort identity: treating it as a
+    // registered writer would establish every LSP quickfix without evidence.
+    const producer = diag.source && diag.source !== "lsp" ? diag.source : diag.serverId;
     const source = diag.source ?? "lsp";
     const code = diag.code === undefined ? undefined : String(diag.code);
     const identityArgs = {
         filePath,
-        tool: "lsp",
+        tool: producer ?? "lsp",
         source,
         code,
         message: diag.message,
@@ -271,7 +277,7 @@ function recordFromLspDiagnostic(diag, filePath, cwd) {
         line,
         column,
         severity: "warning",
-        tool: "lsp",
+        tool: producer ?? "lsp",
         source,
         code,
         rule: code ? `${source}:${code}` : source,
@@ -1428,6 +1434,19 @@ export async function applyConservativeActionableWarningFixes(args) {
                 continue;
             }
             summary.considered++;
+            const agreement = establishToolAgreement(warning.tool, args.cwd);
+            if (agreement.decision === "decline") {
+                recordDegradationOnce({
+                    kind: "autofix-agreement-unavailable",
+                    subject: agreement.subject,
+                    reason: agreement.reason,
+                });
+                summary.skipped.push({
+                    id: warning.id,
+                    reason: "tool_agreement_unavailable",
+                });
+                continue;
+            }
             if (!warning.line || !warning.column) {
                 summary.skipped.push({ id: warning.id, reason: "missing_position" });
                 continue;
@@ -1516,7 +1535,7 @@ export async function applyConservativeActionableWarningFixes(args) {
  * unread under `~/.pi-lens/projects/<slug>/cache/`. An OPTIONAL `cwd` would
  * have kept that bug alive behind a default, so callers must pass it.
  */
-export function formatActionableWarningsAdvisory(report, cwd) {
+export function formatActionableWarningsAdvisory(report, cwd, host = "pi") {
     if (report.summary.unsuppressed === 0)
         return undefined;
     const files = report.files.filter((file) => file.warnings.some((warning) => !warning.suppressed));
@@ -1543,10 +1562,17 @@ export function formatActionableWarningsAdvisory(report, cwd) {
     // reading the transcript, rendered through the one helper that cannot
     // disagree with the writer.
     const reportPath = displayProjectDataPath(cwd, "cache", "actionable-warnings.json");
+    // #2535 F3: a known tool with no mapping on this host resolves to
+    // undefined — omit the instruction rather than naming a dead tool.
+    // `lens_diagnostics` is pinned available on both hosts, so this is
+    // defensive only.
+    const diagnosticsTool = resolveLensToolName("lens_diagnostics", host);
     return [
         `🟡 Fixable warnings introduced this turn: ${report.summary.unsuppressed}.${safe}`,
         tierLine,
-        "Use lens_diagnostics with mode=delta to inspect these warnings.",
+        diagnosticsTool
+            ? `Use ${diagnosticsTool} with mode=delta to inspect these warnings.`
+            : undefined,
         fileList ? `Files:\n${fileList}${more}` : undefined,
         "If continuing in these files, resolve warnings that are safe and relevant. Do not apply broad refactors unless requested.",
         `Raw report (only if you need the JSON): ${reportPath}`,

package/dist/clients/agent-behavior-client.js

@@ -143,3 +143,5 @@ export class AgentBehaviorClient {
         this.fileEditCount.clear();
     }
 }
+/** Process-wide behaviour history, independent of analyzer bootstrap residency. */
+export const agentBehaviorClient = new AgentBehaviorClient();

package/dist/clients/analysed-root.js

@@ -0,0 +1 @@
+export {};

package/dist/clients/ast-grep-tool-logger.js

@@ -99,7 +99,7 @@ export function astGrepRemediationHint(kind) {
         case "json_parse_failed":
             return "Hint: ast-grep produced output that could not be parsed — retry with a simpler pattern; the installed CLI version may be incompatible.";
         default:
-            return "Hint: verify the pattern is a single valid AST node for this `lang` (use ast_grep_dump to discover node kinds), or fall back to grep for plain-text search.";
+            return "Hint: verify the pattern is a single valid AST node for this `lang` (use ast_grep_search with dump=true to discover node kinds), or fall back to grep for plain-text search.";
     }
 }
 export function logAstGrepToolEvent(event) {

package/dist/clients/bash-file-access.js

@@ -17,6 +17,7 @@
 import * as nodeFs from "node:fs";
 import * as path from "node:path";
 import { isReadableSourceFile } from "./file-kinds.js";
+import { classifyMutatingTool } from "./mutating-tool.js";
 import { countFileLines } from "./read-guard-tool-lines.js";
 import { stripAnsi } from "./sanitize.js";
 function stripQuotes(token) {
@@ -1028,3 +1029,28 @@ export function extractDeletedPathsFromCommand(command, cwd) {
     }
     return Array.from(out);
 }
+/**
+ * One edit-class predicate for the `tool_result` path (#2939 F3).
+ *
+ * `index.ts` used to answer "is this an edit-class result" twice — once in
+ * the handler body (gated on `toolName === "bash"`) and once in the
+ * `budgetKey` callback (no tool gate) — and the copies disagreed on the
+ * first third-party case tried (`mcp__acme__shell` with `input.command`:
+ * wrapper said edit, handler said read-only). Both call sites now share
+ * this function, so the answer is written once — but the call sites
+ * themselves are not yet pinned (W4/M8, #2939), so a future tool-name gate
+ * re-introduced at one of them would still pass the suite.
+ *
+ * A result is edit-class when the mutation seam classifies it, or when its
+ * `input.command` names written files. The command half carries no tool-name
+ * gate on purpose: a shell that wrote files runs the same pipeline whatever
+ * its tool is named, and the edit budget must cover that work.
+ */
+export function isEditClassToolResult(event, cwd) {
+    if (classifyMutatingTool(event, { recognizeOnly: true }) !== undefined) {
+        return true;
+    }
+    const command = event?.input?.command;
+    return (typeof command === "string" &&
+        extractWrittenPathsFromCommand(command, cwd).length > 0);
+}

package/dist/clients/biome-client.js

@@ -14,8 +14,10 @@ import { isFileKind } from "./file-kinds.js";
 import { getGlobalPiLensDir } from "./file-utils.js";
 import { findGlobalBinary } from "./package-manager.js";
 import { safeSpawnAsync } from "./safe-spawn.js";
+import { probeToolAsync } from "./tool-probe.js";
 import { createSingleFlight } from "./single-flight.js";
 import { biomeConfigArgs } from "./tool-policy.js";
+import { resolveToolCwd } from "./tool-cwd.js";
 import { resolveManagedToolClient, } from "./dispatch/runners/utils/runner-helpers.js";
 import { classifyProbeFailure, describeInstallAttempt, createAvailabilityLatch, logAvailabilityDecision, startHostStallSampler, } from "./dispatch/runners/utils/availability-policy.js";
 // --- Client ---
@@ -169,7 +171,14 @@ export class BiomeClient {
         let result;
         let hostStallMs;
         try {
-            result = await this.spawnBiomeAsync(["--version"], PROBE_TIMEOUT_MS);
+            // The presence probe asks whether biome answers at all, so it goes
+            // through the probe seam (no cwd) rather than through
+            // `spawnBiomeAsync`, whose optional `cwd` exists for the analysis
+            // spawns that DO resolve a project config (#2894).
+            const { cmd, args: prefix } = await this.getBiomeBinary();
+            result = await probeToolAsync(cmd, [...prefix, "--version"], {
+                timeout: PROBE_TIMEOUT_MS,
+            });
         }
         finally {
             hostStallMs = sampler.stop();
@@ -314,7 +323,9 @@ export class BiomeClient {
         }
         try {
             const before = await fs.promises.readFile(absolutePath, "utf-8");
-            const configCwd = cwd ?? path.dirname(absolutePath);
+            const configCwd = resolveToolCwd("runner", "biome", absolutePath, {
+                ...(cwd !== undefined && { cwd }),
+            }).cwd;
             // Shared config-args seam (#1247): the lint runner consumes the same
             // builder, so `lint --write` can never drift to biome's default
             // config when a user config or the package fallback exists.