pi-lens 3.6.2 → 3.6.4

package/clients/agent-behavior-client.js

@@ -1,110 +0,0 @@
-/**
- * AgentBehaviorClient for pi-lens
- *
- * Tracks tool call sequences and flags anti-patterns in real-time:
- * - Blind writes: editing or writing without reading first
- * - Thrashing: repeated identical tool calls with no progress
- *
- * No external dependencies — purely tracks tool call history.
- */
-// --- Constants ---
-const WRITE_OPS = new Set(["edit", "write", "multiedit"]);
-const READ_OPS = new Set(["read", "bash", "grep", "glob", "find", "rg"]);
-const BLIND_WRITE_WINDOW = 5; // Check last N tool calls for a read
-const THRASH_THRESHOLD = 3; // Flag after N consecutive identical tools
-const THRASH_TIMEOUT_MS = 30000; // Reset thrash counter if gap > 30s
-// --- Client ---
-export class AgentBehaviorClient {
-    constructor() {
-        this.toolHistory = [];
-        this.consecutiveCount = 0;
-        this.lastToolName = null;
-        this.lastToolTimestamp = 0;
-        // Per-file tracking
-        this.fileEditCount = new Map();
-    }
-    /**
-     * Record a tool call and return any warnings triggered.
-     * Called from tool_result handler.
-     */
-    recordToolCall(toolName, filePath) {
-        const warnings = [];
-        const now = Date.now();
-        // Track consecutive identical tools (thrashing)
-        if (toolName === this.lastToolName &&
-            now - this.lastToolTimestamp < THRASH_TIMEOUT_MS) {
-            this.consecutiveCount++;
-        }
-        else {
-            this.consecutiveCount = 1;
-        }
-        this.lastToolName = toolName;
-        this.lastToolTimestamp = now;
-        // Check for thrashing
-        if (this.consecutiveCount === THRASH_THRESHOLD) {
-            warnings.push({
-                type: "thrashing",
-                message: `🔴 THRASHING — ${THRASH_THRESHOLD} consecutive \`${toolName}\` calls with no other action. Consider fixing the root cause instead of re-running.`,
-                severity: "error",
-                details: {
-                    toolName,
-                    callCount: this.consecutiveCount,
-                },
-            });
-        }
-        // Check for blind writes
-        if (WRITE_OPS.has(toolName)) {
-            const recentWindow = this.toolHistory.slice(-BLIND_WRITE_WINDOW);
-            const hasRecentRead = recentWindow.some((r) => READ_OPS.has(r.toolName));
-            if (!hasRecentRead && recentWindow.length > 0) {
-                // Count how many writes in the window without reads
-                const writesWithoutRead = recentWindow.filter((r) => WRITE_OPS.has(r.toolName)).length;
-                if (writesWithoutRead >= 2) {
-                    warnings.push({
-                        type: "blind-write",
-                        message: `⚠ BLIND WRITE — editing \`${filePath ?? "file"}\` without reading in the last ${BLIND_WRITE_WINDOW} tool calls. Read the file first to avoid assumptions.`,
-                        severity: "warning",
-                        details: {
-                            filePath,
-                            windowSize: recentWindow.length,
-                        },
-                    });
-                }
-            }
-            // Track edits per file
-            if (filePath) {
-                this.fileEditCount.set(filePath, (this.fileEditCount.get(filePath) ?? 0) + 1);
-            }
-        }
-        // Add to history (keep last 50 entries)
-        this.toolHistory.push({ toolName, filePath, timestamp: now });
-        if (this.toolHistory.length > 50) {
-            this.toolHistory = this.toolHistory.slice(-50);
-        }
-        return warnings;
-    }
-    /**
-     * Format warnings for LLM consumption.
-     */
-    formatWarnings(warnings) {
-        if (warnings.length === 0)
-            return "";
-        return warnings.map((w) => w.message).join("\n");
-    }
-    /**
-     * Get edit count for a file in this session.
-     */
-    getEditCount(filePath) {
-        return this.fileEditCount.get(filePath) ?? 0;
-    }
-    /**
-     * Reset state (e.g., on session start).
-     */
-    reset() {
-        this.toolHistory = [];
-        this.consecutiveCount = 0;
-        this.lastToolName = null;
-        this.lastToolTimestamp = 0;
-        this.fileEditCount.clear();
-    }
-}

package/clients/agent-behavior-client.test.js

@@ -1,94 +0,0 @@
-import { beforeEach, describe, expect, it } from "vitest";
-import { AgentBehaviorClient } from "./agent-behavior-client.js";
-describe("AgentBehaviorClient", () => {
-    let client;
-    beforeEach(() => {
-        client = new AgentBehaviorClient();
-        client.reset();
-    });
-    describe("blind write detection", () => {
-        it("should NOT warn when read precedes write", () => {
-            client.recordToolCall("read", "src/file.ts");
-            client.recordToolCall("edit", "src/file.ts");
-            const warnings = client.recordToolCall("write", "src/file.ts");
-            expect(warnings).toHaveLength(0);
-        });
-        it("should warn when multiple writes happen without reads", () => {
-            // First write is OK (no history)
-            client.recordToolCall("write", "src/file1.ts");
-            // Second write - still in window, accumulates
-            client.recordToolCall("edit", "src/file2.ts");
-            // Third write without any read - now we have a pattern
-            const warnings = client.recordToolCall("edit", "src/file3.ts");
-            expect(warnings).toHaveLength(1);
-            expect(warnings[0].type).toBe("blind-write");
-        });
-        it("should not warn for single write with no history", () => {
-            const warnings = client.recordToolCall("write", "src/file.ts");
-            expect(warnings).toHaveLength(0);
-        });
-    });
-    describe("thrashing detection", () => {
-        it("should warn after 3 consecutive identical tool calls", () => {
-            client.recordToolCall("bash", undefined);
-            // Second call - no warning yet
-            let warnings = client.recordToolCall("bash", undefined);
-            expect(warnings).toHaveLength(0);
-            // Third consecutive - should warn
-            warnings = client.recordToolCall("bash", undefined);
-            expect(warnings).toHaveLength(1);
-            expect(warnings[0].type).toBe("thrashing");
-            expect(warnings[0].details.callCount).toBe(3);
-        });
-        it("should NOT warn for different tool calls", () => {
-            client.recordToolCall("read", "src/file.ts");
-            client.recordToolCall("bash", "npm test");
-            const warnings = client.recordToolCall("edit", "src/file.ts");
-            expect(warnings).toHaveLength(0);
-        });
-        it("should reset count when tool changes", () => {
-            client.recordToolCall("bash", undefined);
-            client.recordToolCall("bash", undefined);
-            // Different tool resets the count
-            client.recordToolCall("read", "src/file.ts");
-            // Now start new consecutive sequence
-            client.recordToolCall("bash", undefined);
-            const warnings = client.recordToolCall("bash", undefined);
-            expect(warnings).toHaveLength(0); // Only 2 consecutive, not 3
-        });
-    });
-    describe("edit counting", () => {
-        it("should track edit count per file", () => {
-            client.recordToolCall("edit", "src/a.ts");
-            client.recordToolCall("edit", "src/a.ts");
-            client.recordToolCall("edit", "src/b.ts");
-            expect(client.getEditCount("src/a.ts")).toBe(2);
-            expect(client.getEditCount("src/b.ts")).toBe(1);
-            expect(client.getEditCount("src/c.ts")).toBe(0);
-        });
-    });
-    describe("formatWarnings", () => {
-        it("should format multiple warnings", () => {
-            const warnings = [
-                {
-                    type: "blind-write",
-                    message: "⚠ BLIND WRITE — editing file",
-                    severity: "warning",
-                    details: {},
-                },
-                {
-                    type: "thrashing",
-                    message: "🔴 THRASHING — 3 consecutive calls",
-                    severity: "error",
-                    details: {},
-                },
-            ];
-            const formatted = client.formatWarnings(warnings);
-            expect(formatted).toContain("BLIND WRITE");
-            expect(formatted).toContain("THRASHING");
-        });
-        it("should return empty string for no warnings", () => {
-            expect(client.formatWarnings([])).toBe("");
-        });
-    });
-});

package/clients/agent-behavior-client.test.ts

@@ -1,116 +0,0 @@
-import { beforeEach, describe, expect, it } from "vitest";
-import { AgentBehaviorClient } from "./agent-behavior-client.js";
-
-describe("AgentBehaviorClient", () => {
-	let client: AgentBehaviorClient;
-
-	beforeEach(() => {
-		client = new AgentBehaviorClient();
-		client.reset();
-	});
-
-	describe("blind write detection", () => {
-		it("should NOT warn when read precedes write", () => {
-			client.recordToolCall("read", "src/file.ts");
-			client.recordToolCall("edit", "src/file.ts");
-
-			const warnings = client.recordToolCall("write", "src/file.ts");
-			expect(warnings).toHaveLength(0);
-		});
-
-		it("should warn when multiple writes happen without reads", () => {
-			// First write is OK (no history)
-			client.recordToolCall("write", "src/file1.ts");
-
-			// Second write - still in window, accumulates
-			client.recordToolCall("edit", "src/file2.ts");
-
-			// Third write without any read - now we have a pattern
-			const warnings = client.recordToolCall("edit", "src/file3.ts");
-			expect(warnings).toHaveLength(1);
-			expect(warnings[0].type).toBe("blind-write");
-		});
-
-		it("should not warn for single write with no history", () => {
-			const warnings = client.recordToolCall("write", "src/file.ts");
-			expect(warnings).toHaveLength(0);
-		});
-	});
-
-	describe("thrashing detection", () => {
-		it("should warn after 3 consecutive identical tool calls", () => {
-			client.recordToolCall("bash", undefined);
-
-			// Second call - no warning yet
-			let warnings = client.recordToolCall("bash", undefined);
-			expect(warnings).toHaveLength(0);
-
-			// Third consecutive - should warn
-			warnings = client.recordToolCall("bash", undefined);
-			expect(warnings).toHaveLength(1);
-			expect(warnings[0].type).toBe("thrashing");
-			expect(warnings[0].details.callCount).toBe(3);
-		});
-
-		it("should NOT warn for different tool calls", () => {
-			client.recordToolCall("read", "src/file.ts");
-			client.recordToolCall("bash", "npm test");
-
-			const warnings = client.recordToolCall("edit", "src/file.ts");
-			expect(warnings).toHaveLength(0);
-		});
-
-		it("should reset count when tool changes", () => {
-			client.recordToolCall("bash", undefined);
-			client.recordToolCall("bash", undefined);
-
-			// Different tool resets the count
-			client.recordToolCall("read", "src/file.ts");
-
-			// Now start new consecutive sequence
-			client.recordToolCall("bash", undefined);
-
-			const warnings = client.recordToolCall("bash", undefined);
-			expect(warnings).toHaveLength(0); // Only 2 consecutive, not 3
-		});
-	});
-
-	describe("edit counting", () => {
-		it("should track edit count per file", () => {
-			client.recordToolCall("edit", "src/a.ts");
-			client.recordToolCall("edit", "src/a.ts");
-			client.recordToolCall("edit", "src/b.ts");
-
-			expect(client.getEditCount("src/a.ts")).toBe(2);
-			expect(client.getEditCount("src/b.ts")).toBe(1);
-			expect(client.getEditCount("src/c.ts")).toBe(0);
-		});
-	});
-
-	describe("formatWarnings", () => {
-		it("should format multiple warnings", () => {
-			const warnings = [
-				{
-					type: "blind-write" as const,
-					message: "⚠ BLIND WRITE — editing file",
-					severity: "warning" as const,
-					details: {},
-				},
-				{
-					type: "thrashing" as const,
-					message: "🔴 THRASHING — 3 consecutive calls",
-					severity: "error" as const,
-					details: {},
-				},
-			];
-
-			const formatted = client.formatWarnings(warnings);
-			expect(formatted).toContain("BLIND WRITE");
-			expect(formatted).toContain("THRASHING");
-		});
-
-		it("should return empty string for no warnings", () => {
-			expect(client.formatWarnings([])).toBe("");
-		});
-	});
-});

package/clients/amain-types.js

@@ -1,164 +0,0 @@
-/**
- * Amain State Types: 57 syntax types + 15 token types
- *
- * Adapted from Amain paper's Java AST structure for TypeScript.
- * 57 syntax types (non-leaf AST nodes) + 15 token types (leaf categories) = 72 states
- *
- * Reference: https://github.com/CGCL-codes/Amain (ASE 2022)
- */
-import * as ts from "typescript";
-// ============================================================================
-// 57 Syntax Types (non-leaf AST nodes, indices 0-56)
-// ============================================================================
-export const SYNTAX_TYPES = [
-    // Declarations (0-9)
-    "FunctionDeclaration", // 0
-    "ArrowFunction", // 1
-    "FunctionExpression", // 2
-    "ClassDeclaration", // 3
-    "InterfaceDeclaration", // 4
-    "TypeAliasDeclaration", // 5
-    "EnumDeclaration", // 6
-    "MethodDeclaration", // 7
-    "Constructor", // 8
-    "GetAccessor", // 9
-    // More declarations (10-19)
-    "SetAccessor", // 10
-    "PropertyDeclaration", // 11
-    "Parameter", // 12
-    "VariableDeclaration", // 13
-    "ModuleDeclaration", // 14
-    "ImportDeclaration", // 15
-    "ExportDeclaration", // 16
-    "NamespaceExportDeclaration", // 17
-    "ImportClause", // 18
-    "NamespaceImport", // 19
-    // Statements (20-39)
-    "IfStatement", // 20
-    "ForStatement", // 21
-    "ForOfStatement", // 22
-    "ForInStatement", // 23
-    "WhileStatement", // 24
-    "DoWhileStatement", // 25
-    "SwitchStatement", // 26
-    "CaseClause", // 27
-    "DefaultClause", // 28
-    "TryStatement", // 29
-    "CatchClause", // 30
-    "ThrowStatement", // 31
-    "ReturnStatement", // 32
-    "BreakStatement", // 33
-    "ContinueStatement", // 34
-    "Block", // 35
-    "EmptyStatement", // 36
-    // More statements (37-39)
-    "DebuggerStatement", // 37
-    "LabeledStatement", // 38
-    "WithStatement", // 39
-    // Expressions (40-56)
-    "BinaryExpression", // 40
-    "UnaryExpression", // 41
-    "PrefixUnaryExpression", // 42
-    "PostfixUnaryExpression", // 43
-    "ConditionalExpression", // 44
-    "CallExpression", // 45
-    "PropertyAccessExpression", // 46
-    "ElementAccessExpression", // 47
-    "NewExpression", // 48
-    "ParenthesizedExpression", // 49
-    "TypeAssertionExpression", // 50
-    "AsExpression", // 51
-    "NonNullExpression", // 52
-    "TemplateExpression", // 53
-    "ArrayLiteralExpression", // 54
-    "ObjectLiteralExpression", // 55
-    "ExpressionStatement", // 56
-];
-// ============================================================================
-// 15 Token Types (leaf node categories, indices 57-71)
-// ============================================================================
-export const TOKEN_TYPES = [
-    "Identifier", // 57
-    "StringLiteral", // 58
-    "NumericLiteral", // 59
-    "TrueKeyword", // 60
-    "FalseKeyword", // 61
-    "NullKeyword", // 62
-    "UndefinedKeyword", // 63
-    "ThisKeyword", // 64
-    "SuperKeyword", // 65
-    "RegularExpressionLiteral", // 66
-    "NoSubstitutionTemplateLiteral", // 67
-    "TemplateHead", // 68
-    "TemplateMiddle", // 69
-    "TemplateTail", // 70
-    "ComputedPropertyName", // 71
-];
-// ============================================================================
-// Constants
-// ============================================================================
-export const NUM_SYNTAX = SYNTAX_TYPES.length; // 57
-export const NUM_TOKEN = TOKEN_TYPES.length; // 15
-export const NUM_STATES = NUM_SYNTAX + NUM_TOKEN; // 72
-// ============================================================================
-// State Index Mapping
-// ============================================================================
-/**
- * Map a TypeScript AST node to its Amain state index (0-71)
- */
-export function getStateIndex(node) {
-    // Try syntax types first (0-56)
-    const kindName = ts.SyntaxKind[node.kind];
-    const syntaxIdx = SYNTAX_TYPES.indexOf(kindName);
-    if (syntaxIdx !== -1)
-        return syntaxIdx;
-    // Map to token types (57-71) based on node kind
-    if (ts.isIdentifier(node))
-        return 57;
-    if (ts.isStringLiteral(node))
-        return 58;
-    if (ts.isNumericLiteral(node))
-        return 59;
-    if (node.kind === ts.SyntaxKind.TrueKeyword)
-        return 60;
-    if (node.kind === ts.SyntaxKind.FalseKeyword)
-        return 61;
-    if (node.kind === ts.SyntaxKind.NullKeyword)
-        return 62;
-    if (node.kind === ts.SyntaxKind.UndefinedKeyword)
-        return 63;
-    if (node.kind === ts.SyntaxKind.ThisKeyword)
-        return 64;
-    if (node.kind === ts.SyntaxKind.SuperKeyword)
-        return 65;
-    if (node.kind === ts.SyntaxKind.RegularExpressionLiteral)
-        return 66;
-    if (node.kind === ts.SyntaxKind.NoSubstitutionTemplateLiteral)
-        return 67;
-    if (node.kind === ts.SyntaxKind.TemplateHead)
-        return 68;
-    if (node.kind === ts.SyntaxKind.TemplateMiddle)
-        return 69;
-    if (node.kind === ts.SyntaxKind.TemplateTail)
-        return 70;
-    if (node.kind === ts.SyntaxKind.ComputedPropertyName)
-        return 71;
-    // Default: treat as identifier for any other leaf node
-    return 57;
-}
-/**
- * Check if a node is a syntax type (non-leaf) vs token type (leaf)
- */
-export function isSyntaxNode(node) {
-    return getStateIndex(node) < NUM_SYNTAX;
-}
-/**
- * Get state name for debugging
- */
-export function getStateName(index) {
-    if (index < NUM_SYNTAX)
-        return SYNTAX_TYPES[index];
-    if (index < NUM_STATES)
-        return TOKEN_TYPES[index - NUM_SYNTAX];
-    return "Unknown";
-}