pi-lens 3.6.2 → 3.6.4

package/clients/dispatch/dispatcher.edge.test.ts

@@ -1,100 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { formatDiagnostic } from "./utils/format-utils.js";
-
-describe("formatDiagnostic edge cases", () => {
-	it("should handle messages with colons correctly", () => {
-		// This tests the actual format of inline code fix messages
-		const diagnostic = {
-			id: "architect-1",
-			// This is the format of architect warnings - starts with "No "
-			message:
-				"No absolute Windows paths — breaks CI and cross-platform builds.",
-			filePath: "/test.ts",
-			line: 10,
-			severity: "warning" as const,
-			semantic: "warning" as const,
-			tool: "architect",
-			rule: "no-absolute-paths",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		// Should show the complete message, not cut off at "No "
-		expect(formatted).toContain("No absolute Windows paths");
-		expect(formatted).toContain("breaks CI and cross-platform builds");
-		expect(formatted).not.toBe("  L10: No "); // Should NOT be truncated
-	});
-
-	it("should handle code fix messages with newlines", () => {
-		const diagnostic = {
-			id: "ts-12-2345",
-			// This is the actual format from ts-lsp runner
-			message:
-				"Property 'debug' is missing in type 'Config'\n💡 Quick fix: Add missing property 'debug'",
-			filePath: "/test.ts",
-			line: 12,
-			severity: "error" as const,
-			semantic: "blocking" as const,
-			tool: "ts-lsp",
-			rule: "TS2345",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		// Should have both lines properly indented
-		expect(formatted).toBe(
-			"  L12: Property 'debug' is missing in type 'Config'\n  💡 Quick fix: Add missing property 'debug'",
-		);
-	});
-
-	it("should handle messages with em-dashes (—)", () => {
-		const diagnostic = {
-			id: "architect-2",
-			message:
-				"No hardcoded secrets — use environment variables or a secrets manager.",
-			filePath: "/test.ts",
-			line: 5,
-			severity: "warning" as const,
-			semantic: "warning" as const,
-			tool: "architect",
-			rule: "no-secrets",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		// Should preserve the full message with em-dash
-		expect(formatted).toContain("No hardcoded secrets");
-		expect(formatted).toContain("use environment variables");
-	});
-
-	it("should not truncate architect 'No ' messages", () => {
-		// Testing all the "No " patterns from default-architect.yaml
-		const testMessages = [
-			"No absolute Windows paths — breaks CI and cross-platform builds.",
-			"No hardcoded localhost URLs — use environment variables or a config service.",
-			"No empty catch/except blocks. Swallowing errors makes debugging impossible — at least log the error.",
-			"No hardcoded secrets — use environment variables or a secrets manager.",
-			"No 'any' types — use 'unknown' or define a proper interface to maintain type safety.",
-		];
-
-		for (const message of testMessages) {
-			const diagnostic = {
-				id: "test-1",
-				message,
-				filePath: "/test.ts",
-				line: 1,
-				severity: "warning" as const,
-				semantic: "warning" as const,
-				tool: "architect",
-				rule: "test",
-			};
-
-			const formatted = formatDiagnostic(diagnostic);
-
-			// Each formatted message should be more than just "  L1: No "
-			expect(formatted.length).toBeGreaterThan(10);
-			expect(formatted).toContain("No ");
-			expect(formatted).toContain("—"); // Should have the em-dash
-		}
-	});
-});

package/clients/dispatch/dispatcher.format.test.js

@@ -1,46 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { formatDiagnostic } from "./utils/format-utils.js";
-describe("formatDiagnostic with code fixes", () => {
-    it("should format multi-line messages with proper indentation", () => {
-        const diagnostic = {
-            id: "ts-12-2345",
-            message: "Property 'debug' is missing in type 'Config'\n💡 Quick fix: Add missing property 'debug'",
-            filePath: "/test.ts",
-            line: 12,
-            severity: "error",
-            semantic: "blocking",
-            tool: "ts-lsp",
-            rule: "TS2345",
-        };
-        const formatted = formatDiagnostic(diagnostic);
-        // Should have proper indentation on both lines
-        expect(formatted).toBe("  L12: Property 'debug' is missing in type 'Config'\n  💡 Quick fix: Add missing property 'debug'");
-    });
-    it("should format single-line messages", () => {
-        const diagnostic = {
-            id: "ts-5-1234",
-            message: "Cannot find name 'foo'",
-            filePath: "/test.ts",
-            line: 5,
-            severity: "error",
-            semantic: "blocking",
-            tool: "ts-lsp",
-            rule: "TS1234",
-        };
-        const formatted = formatDiagnostic(diagnostic);
-        expect(formatted).toBe("  L5: Cannot find name 'foo'");
-    });
-    it("should handle diagnostics without line numbers", () => {
-        const diagnostic = {
-            id: "test-1",
-            message: "General error\n💡 Fix: Do something",
-            filePath: "/test.ts",
-            severity: "warning",
-            semantic: "warning",
-            tool: "test",
-            rule: "test",
-        };
-        const formatted = formatDiagnostic(diagnostic);
-        expect(formatted).toBe("  General error\n  💡 Fix: Do something");
-    });
-});

package/clients/dispatch/dispatcher.format.test.ts

@@ -1,58 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { formatDiagnostic } from "./utils/format-utils.js";
-
-describe("formatDiagnostic with code fixes", () => {
-	it("should format multi-line messages with proper indentation", () => {
-		const diagnostic = {
-			id: "ts-12-2345",
-			message:
-				"Property 'debug' is missing in type 'Config'\n💡 Quick fix: Add missing property 'debug'",
-			filePath: "/test.ts",
-			line: 12,
-			severity: "error" as const,
-			semantic: "blocking" as const,
-			tool: "ts-lsp",
-			rule: "TS2345",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		// Should have proper indentation on both lines
-		expect(formatted).toBe(
-			"  L12: Property 'debug' is missing in type 'Config'\n  💡 Quick fix: Add missing property 'debug'",
-		);
-	});
-
-	it("should format single-line messages", () => {
-		const diagnostic = {
-			id: "ts-5-1234",
-			message: "Cannot find name 'foo'",
-			filePath: "/test.ts",
-			line: 5,
-			severity: "error" as const,
-			semantic: "blocking" as const,
-			tool: "ts-lsp",
-			rule: "TS1234",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		expect(formatted).toBe("  L5: Cannot find name 'foo'");
-	});
-
-	it("should handle diagnostics without line numbers", () => {
-		const diagnostic = {
-			id: "test-1",
-			message: "General error\n💡 Fix: Do something",
-			filePath: "/test.ts",
-			severity: "warning" as const,
-			semantic: "warning" as const,
-			tool: "test",
-			rule: "test",
-		};
-
-		const formatted = formatDiagnostic(diagnostic);
-
-		expect(formatted).toBe("  General error\n  💡 Fix: Do something");
-	});
-});

package/clients/dispatch/dispatcher.inline.test.js

@@ -1,74 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { formatDiagnostic } from "./utils/format-utils.js";
-describe("formatDiagnostic inline output verification", () => {
-    it("should display complete architect messages (NOT truncated to 'No ')", () => {
-        // Simulate actual architect diagnostic
-        const diagnostic = {
-            id: "architect-1",
-            message: "No absolute Windows paths — breaks CI and cross-platform builds.",
-            filePath: "/test.ts",
-            line: 5,
-            severity: "warning",
-            semantic: "warning",
-            tool: "architect",
-            rule: "no-absolute-windows-paths",
-        };
-        const output = formatDiagnostic(diagnostic);
-        console.log("\n=== Architect Message Output ===");
-        console.log(output);
-        console.log("=================================\n");
-        // Verify complete message is shown
-        expect(output).toBe("  L5: No absolute Windows paths — breaks CI and cross-platform builds.");
-    });
-    it("should display code fix messages inline correctly", () => {
-        // This is what I actually see from ts-lsp runner
-        const diagnostic = {
-            id: "ts-12-2345",
-            message: "Property 'debug' is missing in type 'Config'\n💡 Quick fix: Add missing property 'debug'",
-            filePath: "/src/config.ts",
-            line: 12,
-            severity: "error",
-            semantic: "blocking",
-            tool: "ts-lsp",
-            rule: "TS2345",
-            fixable: true,
-            fixSuggestion: "Add missing property 'debug'",
-        };
-        const output = formatDiagnostic(diagnostic);
-        console.log("\n=== Code Fix Message Output ===");
-        console.log(output);
-        console.log("================================\n");
-        // Both lines should be properly indented
-        expect(output).toBe("  L12: Property 'debug' is missing in type 'Config'\n  💡 Quick fix: Add missing property 'debug'");
-    });
-    it("should prove architect 'No ' messages are complete (not noise)", () => {
-        // All the "No " messages from default-architect.yaml
-        const testMessages = [
-            "No absolute Windows paths — breaks CI and cross-platform builds.",
-            "No hardcoded localhost URLs — use environment variables or a config service.",
-            "No empty catch/except blocks. Swallowing errors makes debugging impossible — at least log the error.",
-            "No hardcoded secrets — use environment variables or a secrets manager.",
-            "No 'any' types — use 'unknown' or define a proper interface to maintain type safety.",
-        ];
-        for (let i = 0; i < testMessages.length; i++) {
-            const diagnostic = {
-                id: `architect-${i}`,
-                message: testMessages[i],
-                filePath: "/test.ts",
-                line: i + 1,
-                severity: "warning",
-                semantic: "warning",
-                tool: "architect",
-                rule: "test",
-            };
-            const output = formatDiagnostic(diagnostic);
-            // Each message should be complete, NOT truncated to just "No "
-            expect(output.length).toBeGreaterThan(15); // More than "  L1: No "
-            expect(output).toContain("No ");
-            expect(output).toContain("—"); // Contains the em-dash explanation
-            // Verify it's not truncated
-            const messageAfterNo = output.split("No ")[1];
-            expect(messageAfterNo.length).toBeGreaterThan(5);
-        }
-    });
-});

package/clients/dispatch/dispatcher.inline.test.ts

@@ -1,93 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { formatDiagnostic } from "./utils/format-utils.js";
-
-describe("formatDiagnostic inline output verification", () => {
-	it("should display complete architect messages (NOT truncated to 'No ')", () => {
-		// Simulate actual architect diagnostic
-		const diagnostic = {
-			id: "architect-1",
-			message:
-				"No absolute Windows paths — breaks CI and cross-platform builds.",
-			filePath: "/test.ts",
-			line: 5,
-			severity: "warning" as const,
-			semantic: "warning" as const,
-			tool: "architect",
-			rule: "no-absolute-windows-paths",
-		};
-
-		const output = formatDiagnostic(diagnostic);
-
-		console.log("\n=== Architect Message Output ===");
-		console.log(output);
-		console.log("=================================\n");
-
-		// Verify complete message is shown
-		expect(output).toBe(
-			"  L5: No absolute Windows paths — breaks CI and cross-platform builds.",
-		);
-	});
-
-	it("should display code fix messages inline correctly", () => {
-		// This is what I actually see from ts-lsp runner
-		const diagnostic = {
-			id: "ts-12-2345",
-			message:
-				"Property 'debug' is missing in type 'Config'\n💡 Quick fix: Add missing property 'debug'",
-			filePath: "/src/config.ts",
-			line: 12,
-			severity: "error" as const,
-			semantic: "blocking" as const,
-			tool: "ts-lsp",
-			rule: "TS2345",
-			fixable: true,
-			fixSuggestion: "Add missing property 'debug'",
-		};
-
-		const output = formatDiagnostic(diagnostic);
-
-		console.log("\n=== Code Fix Message Output ===");
-		console.log(output);
-		console.log("================================\n");
-
-		// Both lines should be properly indented
-		expect(output).toBe(
-			"  L12: Property 'debug' is missing in type 'Config'\n  💡 Quick fix: Add missing property 'debug'",
-		);
-	});
-
-	it("should prove architect 'No ' messages are complete (not noise)", () => {
-		// All the "No " messages from default-architect.yaml
-		const testMessages = [
-			"No absolute Windows paths — breaks CI and cross-platform builds.",
-			"No hardcoded localhost URLs — use environment variables or a config service.",
-			"No empty catch/except blocks. Swallowing errors makes debugging impossible — at least log the error.",
-			"No hardcoded secrets — use environment variables or a secrets manager.",
-			"No 'any' types — use 'unknown' or define a proper interface to maintain type safety.",
-		];
-
-		for (let i = 0; i < testMessages.length; i++) {
-			const diagnostic = {
-				id: `architect-${i}`,
-				message: testMessages[i],
-				filePath: "/test.ts",
-				line: i + 1,
-				severity: "warning" as const,
-				semantic: "warning" as const,
-				tool: "architect",
-				rule: "test",
-			};
-
-			const output = formatDiagnostic(diagnostic);
-
-			// Each message should be complete, NOT truncated to just "No "
-			expect(output.length).toBeGreaterThan(15); // More than "  L1: No "
-			expect(output).toContain("No ");
-			expect(output).toContain("—"); // Contains the em-dash explanation
-
-			// Verify it's not truncated
-			const messageAfterNo = output.split("No ")[1];
-			expect(messageAfterNo.length).toBeGreaterThan(5);
-		}
-	});
-});