pi-lens 2.0.7 → 2.0.8

package/clients/complexity-client.test.ts

@@ -1,72 +1,69 @@
-import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { ComplexityClient } from "./complexity-client.js";
 import { createTempFile, setupTestEnvironment } from "./test-utils.js";
 
 describe("ComplexityClient", () => {
-  let client: ComplexityClient;
-  let tmpDir: string;
-  let cleanup: () => void;
-
-  beforeEach(() => {
-    client = new ComplexityClient();
-    ({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-complexity-test-"));
-  });
-
-  afterEach(() => {
-    cleanup();
-  });
-
-  describe("isSupportedFile", () => {
-    it("should support TypeScript files", () => {
-      expect(client.isSupportedFile("test.ts")).toBe(true);
-      expect(client.isSupportedFile("test.tsx")).toBe(true);
-    });
-
-    it("should support JavaScript files", () => {
-      expect(client.isSupportedFile("test.js")).toBe(true);
-      expect(client.isSupportedFile("test.jsx")).toBe(true);
-      expect(client.isSupportedFile("test.mjs")).toBe(true);
-      expect(client.isSupportedFile("test.cjs")).toBe(true);
-    });
-
-    it("should not support non-TS/JS files", () => {
-      expect(client.isSupportedFile("test.py")).toBe(false);
-      expect(client.isSupportedFile("test.json")).toBe(false);
-      expect(client.isSupportedFile("test.md")).toBe(false);
-    });
-  });
-
-  describe("analyzeFile", () => {
-    it("should return null for non-existent files", () => {
-      const result = client.analyzeFile("/nonexistent/file.ts");
-      expect(result).toBeNull();
-    });
-
-    it("should analyze a simple function", () => {
-      
-      try {
-        const content = `
+	let client: ComplexityClient;
+	let tmpDir: string;
+	let cleanup: () => void;
+
+	beforeEach(() => {
+		client = new ComplexityClient();
+		({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-complexity-test-"));
+	});
+
+	afterEach(() => {
+		cleanup();
+	});
+
+	describe("isSupportedFile", () => {
+		it("should support TypeScript files", () => {
+			expect(client.isSupportedFile("test.ts")).toBe(true);
+			expect(client.isSupportedFile("test.tsx")).toBe(true);
+		});
+
+		it("should support JavaScript files", () => {
+			expect(client.isSupportedFile("test.js")).toBe(true);
+			expect(client.isSupportedFile("test.jsx")).toBe(true);
+			expect(client.isSupportedFile("test.mjs")).toBe(true);
+			expect(client.isSupportedFile("test.cjs")).toBe(true);
+		});
+
+		it("should not support non-TS/JS files", () => {
+			expect(client.isSupportedFile("test.py")).toBe(false);
+			expect(client.isSupportedFile("test.json")).toBe(false);
+			expect(client.isSupportedFile("test.md")).toBe(false);
+		});
+	});
+
+	describe("analyzeFile", () => {
+		it("should return null for non-existent files", () => {
+			const result = client.analyzeFile("/nonexistent/file.ts");
+			expect(result).toBeNull();
+		});
+
+		it("should analyze a simple function", () => {
+			try {
+				const content = `
 function greet(name: string): string {
   return "Hello, " + name;
 }
 `;
-        const filePath = createTempFile(tmpDir, "simple.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        expect(result!.functionCount).toBe(1);
-        expect(result!.cyclomaticComplexity).toBe(1);
-        expect(result!.cognitiveComplexity).toBe(0);
-        expect(result!.maxNestingDepth).toBeGreaterThanOrEqual(1);
-      } finally {
-  
-      }
-    });
-
-    it("should detect if statements in cyclomatic complexity", () => {
-      
-      try {
-        const content = `
+				const filePath = createTempFile(tmpDir, "simple.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				expect(result?.functionCount).toBe(1);
+				expect(result?.cyclomaticComplexity).toBe(1);
+				expect(result?.cognitiveComplexity).toBe(0);
+				expect(result?.maxNestingDepth).toBeGreaterThanOrEqual(1);
+			} finally {
+			}
+		});
+
+		it("should detect if statements in cyclomatic complexity", () => {
+			try {
+				const content = `
 function check(x: number): string {
   if (x > 0) {
     return "positive";
@@ -77,40 +74,36 @@ function check(x: number): string {
   }
 }
 `;
-        const filePath = createTempFile(tmpDir, "if-test.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        // 1 base + 1 if + 1 else-if = 3
-        expect(result!.cyclomaticComplexity).toBeGreaterThanOrEqual(3);
-      } finally {
-  
-      }
-    });
-
-    it("should calculate maintainability index", () => {
-      
-      try {
-        const content = `
+				const filePath = createTempFile(tmpDir, "if-test.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				// 1 base + 1 if + 1 else-if = 3
+				expect(result?.cyclomaticComplexity).toBeGreaterThanOrEqual(3);
+			} finally {
+			}
+		});
+
+		it("should calculate maintainability index", () => {
+			try {
+				const content = `
 function simple(): number {
   return 42;
 }
 `;
-        const filePath = createTempFile(tmpDir, "mi-test.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        expect(result!.maintainabilityIndex).toBeGreaterThan(0);
-        expect(result!.maintainabilityIndex).toBeLessThanOrEqual(100);
-      } finally {
-  
-      }
-    });
-
-    it("should detect deep nesting", () => {
-      
-      try {
-        const content = `
+				const filePath = createTempFile(tmpDir, "mi-test.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				expect(result?.maintainabilityIndex).toBeGreaterThan(0);
+				expect(result?.maintainabilityIndex).toBeLessThanOrEqual(100);
+			} finally {
+			}
+		});
+
+		it("should detect deep nesting", () => {
+			try {
+				const content = `
 function deepNest(arr: number[][][][]): number {
   for (let i = 0; i < arr.length; i++) {
     for (let j = 0; j < arr[i].length; j++) {
@@ -126,20 +119,18 @@ function deepNest(arr: number[][][][]): number {
   return 0;
 }
 `;
-        const filePath = createTempFile(tmpDir, "nesting-test.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        expect(result!.maxNestingDepth).toBeGreaterThanOrEqual(5);
-      } finally {
-  
-      }
-    });
-
-    it("should count cognitive complexity with nesting penalty", () => {
-      
-      try {
-        const content = `
+				const filePath = createTempFile(tmpDir, "nesting-test.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				expect(result?.maxNestingDepth).toBeGreaterThanOrEqual(5);
+			} finally {
+			}
+		});
+
+		it("should count cognitive complexity with nesting penalty", () => {
+			try {
+				const content = `
 function nested(x: number, y: number): number {
   if (x > 0) {
     if (y > 0) {
@@ -151,40 +142,36 @@ function nested(x: number, y: number): number {
   return 0;
 }
 `;
-        const filePath = createTempFile(tmpDir, "cognitive-test.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        // Cognitive: 1 (if) + 2 (nested if) + 3 (deeply nested if) = 6
-        expect(result!.cognitiveComplexity).toBeGreaterThanOrEqual(6);
-      } finally {
-  
-      }
-    });
-
-    it("should calculate halstead volume", () => {
-      
-      try {
-        const content = `
+				const filePath = createTempFile(tmpDir, "cognitive-test.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				// Cognitive: 1 (if) + 2 (nested if) + 3 (deeply nested if) = 6
+				expect(result?.cognitiveComplexity).toBeGreaterThanOrEqual(6);
+			} finally {
+			}
+		});
+
+		it("should calculate halstead volume", () => {
+			try {
+				const content = `
 function add(a: number, b: number): number {
   return a + b;
 }
 `;
-        const filePath = createTempFile(tmpDir, "halstead-test.ts", content);
-        const result = client.analyzeFile(filePath);
-
-        expect(result).not.toBeNull();
-        expect(result!.halsteadVolume).toBeGreaterThan(0);
-      } finally {
-  
-      }
-    });
-
-    it("should measure function length", () => {
-      
-      try {
-        const shortContent = `function short() { return 1; }`;
-        const longContent = `
+				const filePath = createTempFile(tmpDir, "halstead-test.ts", content);
+				const result = client.analyzeFile(filePath);
+
+				expect(result).not.toBeNull();
+				expect(result?.halsteadVolume).toBeGreaterThan(0);
+			} finally {
+			}
+		});
+
+		it("should measure function length", () => {
+			try {
+				const shortContent = `function short() { return 1; }`;
+				const longContent = `
 function long(): number {
   const a = 1;
   const b = 2;
@@ -199,69 +186,70 @@ function long(): number {
   return a + b + c + d + e + f + g + h + i + j;
 }
 `;
-        const shortPath = createTempFile(tmpDir, "short.ts", shortContent);
-        const longPath = createTempFile(tmpDir, "long.ts", longContent);
-
-        const shortResult = client.analyzeFile(shortPath);
-        const longResult = client.analyzeFile(longPath);
-
-        expect(shortResult!.maxFunctionLength).toBeLessThan(longResult!.maxFunctionLength);
-      } finally {
-  
-      }
-    });
-  });
-
-  describe("formatMetrics", () => {
-    it("should format metrics for display", () => {
-      const metrics = {
-        filePath: "test.ts",
-        maxNestingDepth: 4,
-        avgFunctionLength: 15,
-        maxFunctionLength: 30,
-        functionCount: 3,
-        cyclomaticComplexity: 4,
-        maxCyclomaticComplexity: 8,
-        cognitiveComplexity: 12,
-        halsteadVolume: 200,
-        maintainabilityIndex: 75,
-        linesOfCode: 100,
-        commentLines: 10,
-        codeEntropy: 0.5,
-        maxParamsInFunction: 3,
-        aiCommentPatterns: 1,
-        singleUseFunctions: 0,
-        tryCatchCount: 1,
-      };
-
-      const formatted = client.formatMetrics(metrics);
-      expect(formatted).toContain("test.ts");
-      expect(formatted).toContain("75/100");
-    });
-
-    it("should warn about low maintainability", () => {
-      const metrics = {
-        filePath: "bad.ts",
-        maxNestingDepth: 8,
-        avgFunctionLength: 60,
-        maxFunctionLength: 100,
-        functionCount: 5,
-        cyclomaticComplexity: 15,
-        maxCyclomaticComplexity: 25,
-        cognitiveComplexity: 50,
-        halsteadVolume: 800,
-        maintainabilityIndex: 25,
-        linesOfCode: 500,
-        commentLines: 10,
-        codeEntropy: 0.5,
-        maxParamsInFunction: 4,
-        aiCommentPatterns: 2,
-        singleUseFunctions: 1,
-        tryCatchCount: 2,
-      };
-
-      const formatted = client.formatMetrics(metrics);
-      expect(formatted).toContain("✗");  // Low MI indicator
-    });
-  });
+				const shortPath = createTempFile(tmpDir, "short.ts", shortContent);
+				const longPath = createTempFile(tmpDir, "long.ts", longContent);
+
+				const shortResult = client.analyzeFile(shortPath);
+				const longResult = client.analyzeFile(longPath);
+
+				expect(shortResult?.maxFunctionLength ?? 0).toBeLessThan(
+					longResult?.maxFunctionLength ?? 0,
+				);
+			} finally {
+			}
+		});
+	});
+
+	describe("formatMetrics", () => {
+		it("should format metrics for display", () => {
+			const metrics = {
+				filePath: "test.ts",
+				maxNestingDepth: 4,
+				avgFunctionLength: 15,
+				maxFunctionLength: 30,
+				functionCount: 3,
+				cyclomaticComplexity: 4,
+				maxCyclomaticComplexity: 8,
+				cognitiveComplexity: 12,
+				halsteadVolume: 200,
+				maintainabilityIndex: 75,
+				linesOfCode: 100,
+				commentLines: 10,
+				codeEntropy: 0.5,
+				maxParamsInFunction: 3,
+				aiCommentPatterns: 1,
+				singleUseFunctions: 0,
+				tryCatchCount: 1,
+			};
+
+			const formatted = client.formatMetrics(metrics);
+			expect(formatted).toContain("test.ts");
+			expect(formatted).toContain("75/100");
+		});
+
+		it("should warn about low maintainability", () => {
+			const metrics = {
+				filePath: "bad.ts",
+				maxNestingDepth: 8,
+				avgFunctionLength: 60,
+				maxFunctionLength: 100,
+				functionCount: 5,
+				cyclomaticComplexity: 15,
+				maxCyclomaticComplexity: 25,
+				cognitiveComplexity: 50,
+				halsteadVolume: 800,
+				maintainabilityIndex: 25,
+				linesOfCode: 500,
+				commentLines: 10,
+				codeEntropy: 0.5,
+				maxParamsInFunction: 4,
+				aiCommentPatterns: 2,
+				singleUseFunctions: 1,
+				tryCatchCount: 2,
+			};
+
+			const formatted = client.formatMetrics(metrics);
+			expect(formatted).toContain("✗"); // Low MI indicator
+		});
+	});
 });