pi-lens 2.0.7 → 2.0.8

package/clients/jscpd-client.test.ts

@@ -1,48 +1,48 @@
-import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { JscpdClient } from "./jscpd-client.js";
 import { createTempFile, setupTestEnvironment } from "./test-utils.js";
 
 describe("JscpdClient", () => {
-  let client: JscpdClient;
-  let tmpDir: string;
-  let cleanup: () => void;
-
-  beforeEach(() => {
-    client = new JscpdClient();
-    ({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-jscpd-test-"));
-  });
-
-  afterEach(() => {
-    cleanup();
-  });
-
-  afterEach(() => {
-    cleanup();
-  });
-
-  describe("isAvailable", () => {
-    it("should check jscpd availability", () => {
-      const available = client.isAvailable();
-      expect(typeof available).toBe("boolean");
-    });
-  });
-
-  describe("scan", () => {
-    it("should return success=false when not available", () => {
-      // Create a mock that returns false
-      const mockClient = new JscpdClient();
-      if (mockClient.isAvailable()) return; // Skip if available
-
-      const result = mockClient.scan(tmpDir);
-      expect(result.success).toBe(false);
-      expect(result.clones).toEqual([]);
-    });
-
-    it("should detect duplicate code blocks", () => {
-      if (!client.isAvailable()) return;
-
-      // Create identical code blocks in different files
-      const duplicateCode = `
+	let client: JscpdClient;
+	let tmpDir: string;
+	let cleanup: () => void;
+
+	beforeEach(() => {
+		client = new JscpdClient();
+		({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-jscpd-test-"));
+	});
+
+	afterEach(() => {
+		cleanup();
+	});
+
+	afterEach(() => {
+		cleanup();
+	});
+
+	describe("isAvailable", () => {
+		it("should check jscpd availability", () => {
+			const available = client.isAvailable();
+			expect(typeof available).toBe("boolean");
+		});
+	});
+
+	describe("scan", () => {
+		it("should return success=false when not available", () => {
+			// Create a mock that returns false
+			const mockClient = new JscpdClient();
+			if (mockClient.isAvailable()) return; // Skip if available
+
+			const result = mockClient.scan(tmpDir);
+			expect(result.success).toBe(false);
+			expect(result.clones).toEqual([]);
+		});
+
+		it("should detect duplicate code blocks", () => {
+			if (!client.isAvailable()) return;
+
+			// Create identical code blocks in different files
+			const duplicateCode = `
 function processData(data: number[]): number {
   let sum = 0;
   for (let i = 0; i < data.length; i++) {
@@ -51,95 +51,95 @@ function processData(data: number[]): number {
   return sum;
 }
 `;
-      createTempFile(tmpDir, "file1.ts", duplicateCode);
-      createTempFile(tmpDir, "file2.ts", duplicateCode);
-
-      const result = client.scan(tmpDir, 3, 20); // Lower thresholds for test
-
-      expect(result.success).toBe(true);
-      // May or may not detect clones depending on jscpd behavior
-    });
-  });
-
-  describe("formatResult", () => {
-    it("should return empty string for no success", () => {
-      const result = {
-        success: false,
-        clones: [],
-        duplicatedLines: 0,
-        totalLines: 100,
-        percentage: 0,
-      };
-
-      expect(client.formatResult(result)).toBe("");
-    });
-
-    it("should return empty string for no clones", () => {
-      const result = {
-        success: true,
-        clones: [],
-        duplicatedLines: 0,
-        totalLines: 100,
-        percentage: 0,
-      };
-
-      expect(client.formatResult(result)).toBe("");
-    });
-
-    it("should format clones for display", () => {
-      const result = {
-        success: true,
-        clones: [
-          {
-            fileA: "src/file1.ts",
-            startA: 10,
-            fileB: "src/file2.ts",
-            startB: 20,
-            lines: 15,
-            tokens: 50,
-          },
-          {
-            fileA: "src/file3.ts",
-            startA: 5,
-            fileB: "src/file4.ts",
-            startB: 12,
-            lines: 8,
-            tokens: 30,
-          },
-        ],
-        duplicatedLines: 23,
-        totalLines: 500,
-        percentage: 4.6,
-      };
-
-      const formatted = client.formatResult(result);
-      expect(formatted).toContain("jscpd");
-      expect(formatted).toContain("2 duplicate block(s)");
-      expect(formatted).toContain("4.6%");
-      expect(formatted).toContain("15 lines");
-    });
-
-    it("should truncate long clone lists", () => {
-      const clones = Array.from({ length: 10 }, (_, i) => ({
-        fileA: `file${i}a.ts`,
-        startA: 1,
-        fileB: `file${i}b.ts`,
-        startB: 1,
-        lines: 5,
-        tokens: 20,
-      }));
-
-      const result = {
-        success: true,
-        clones,
-        duplicatedLines: 50,
-        totalLines: 1000,
-        percentage: 5,
-      };
-
-      const formatted = client.formatResult(result, 8);
-      expect(formatted).toContain("...");
-      expect(formatted).toContain("2 more");
-    });
-  });
+			createTempFile(tmpDir, "file1.ts", duplicateCode);
+			createTempFile(tmpDir, "file2.ts", duplicateCode);
+
+			const result = client.scan(tmpDir, 3, 20); // Lower thresholds for test
+
+			expect(result.success).toBe(true);
+			// May or may not detect clones depending on jscpd behavior
+		});
+	});
+
+	describe("formatResult", () => {
+		it("should return empty string for no success", () => {
+			const result = {
+				success: false,
+				clones: [],
+				duplicatedLines: 0,
+				totalLines: 100,
+				percentage: 0,
+			};
+
+			expect(client.formatResult(result)).toBe("");
+		});
+
+		it("should return empty string for no clones", () => {
+			const result = {
+				success: true,
+				clones: [],
+				duplicatedLines: 0,
+				totalLines: 100,
+				percentage: 0,
+			};
+
+			expect(client.formatResult(result)).toBe("");
+		});
+
+		it("should format clones for display", () => {
+			const result = {
+				success: true,
+				clones: [
+					{
+						fileA: "src/file1.ts",
+						startA: 10,
+						fileB: "src/file2.ts",
+						startB: 20,
+						lines: 15,
+						tokens: 50,
+					},
+					{
+						fileA: "src/file3.ts",
+						startA: 5,
+						fileB: "src/file4.ts",
+						startB: 12,
+						lines: 8,
+						tokens: 30,
+					},
+				],
+				duplicatedLines: 23,
+				totalLines: 500,
+				percentage: 4.6,
+			};
+
+			const formatted = client.formatResult(result);
+			expect(formatted).toContain("jscpd");
+			expect(formatted).toContain("2 duplicate block(s)");
+			expect(formatted).toContain("4.6%");
+			expect(formatted).toContain("15 lines");
+		});
+
+		it("should truncate long clone lists", () => {
+			const clones = Array.from({ length: 10 }, (_, i) => ({
+				fileA: `file${i}a.ts`,
+				startA: 1,
+				fileB: `file${i}b.ts`,
+				startB: 1,
+				lines: 5,
+				tokens: 20,
+			}));
+
+			const result = {
+				success: true,
+				clones,
+				duplicatedLines: 50,
+				totalLines: 1000,
+				percentage: 5,
+			};
+
+			const formatted = client.formatResult(result, 8);
+			expect(formatted).toContain("...");
+			expect(formatted).toContain("2 more");
+		});
+	});
 });

package/clients/jscpd-client.ts

@@ -9,136 +9,173 @@
  */
 
 import { spawnSync } from "node:child_process";
-import * as path from "node:path";
 import * as fs from "node:fs";
 import * as os from "node:os";
+import * as path from "node:path";
 
 // --- Types ---
 
 export interface DuplicateClone {
-  fileA: string;
-  startA: number;
-  fileB: string;
-  startB: number;
-  lines: number;
-  tokens: number;
+	fileA: string;
+	startA: number;
+	fileB: string;
+	startB: number;
+	lines: number;
+	tokens: number;
 }
 
 export interface JscpdResult {
-  success: boolean;
-  clones: DuplicateClone[];
-  duplicatedLines: number;
-  totalLines: number;
-  percentage: number;
+	success: boolean;
+	clones: DuplicateClone[];
+	duplicatedLines: number;
+	totalLines: number;
+	percentage: number;
 }
 
 // --- Client ---
 
 export class JscpdClient {
-  private available: boolean | null = null;
-  private log: (msg: string) => void;
-
-  constructor(verbose = false) {
-    this.log = verbose ? (msg) => console.log(`[jscpd] ${msg}`) : () => {};
-  }
-
-  isAvailable(): boolean {
-    if (this.available !== null) return this.available;
-    const result = spawnSync("npx", ["jscpd", "--version"], {
-      encoding: "utf-8",
-      timeout: 10000,
-      shell: true,
-    });
-    this.available = !result.error && result.status === 0;
-    return this.available;
-  }
-
-  /**
-   * Scan a directory for duplicate code blocks.
-   * Uses a temp output dir to capture JSON report.
-   */
-  scan(cwd: string, minLines = 5, minTokens = 50): JscpdResult {
-    if (!this.isAvailable()) {
-      return { success: false, clones: [], duplicatedLines: 0, totalLines: 0, percentage: 0 };
-    }
-
-    const outDir = path.join(os.tmpdir(), `pi-lens-jscpd-${Date.now()}`);
-    fs.mkdirSync(outDir, { recursive: true });
-
-    try {
-      spawnSync("npx", [
-        "jscpd",
-        ".",
-        "--min-lines", String(minLines),
-        "--min-tokens", String(minTokens),
-        "--reporters", "json",
-        "--output", outDir,
-        "--ignore", "**/node_modules/**,**/dist/**,**/build/**,**/.git/**,**/.pi-lens/**,**/*.md,**/*.txt,**/*.json,**/*.yaml,**/*.yml,**/*.toml,**/*.lock",
-      ], {
-        encoding: "utf-8",
-        timeout: 30000,
-        cwd,
-        shell: true,
-      });
-
-      const reportPath = path.join(outDir, "jscpd-report.json");
-      if (!fs.existsSync(reportPath)) {
-        return { success: true, clones: [], duplicatedLines: 0, totalLines: 0, percentage: 0 };
-      }
-
-      return this.parseReport(reportPath);
-    } catch (err: any) {
-      this.log(`Scan error: ${err.message}`);
-      return { success: false, clones: [], duplicatedLines: 0, totalLines: 0, percentage: 0 };
-    } finally {
-      try { fs.rmSync(outDir, { recursive: true, force: true }); } catch {}
-    }
-  }
-
-  formatResult(result: JscpdResult, maxClones = 8): string {
-    if (!result.success || result.clones.length === 0) return "";
-
-    const pct = result.percentage.toFixed(1);
-    let output = `[jscpd] ${result.clones.length} duplicate block(s) — ${pct}% of codebase (${result.duplicatedLines}/${result.totalLines} lines):\n`;
-
-    for (const clone of result.clones.slice(0, maxClones)) {
-      const a = `${path.basename(clone.fileA)}:${clone.startA}`;
-      const b = `${path.basename(clone.fileB)}:${clone.startB}`;
-      output += `  ${clone.lines} lines — ${a} ↔ ${b}\n`;
-    }
-
-    if (result.clones.length > maxClones) {
-      output += `  ... and ${result.clones.length - maxClones} more\n`;
-    }
-
-    return output;
-  }
-
-  // --- Internal ---
-
-  private parseReport(reportPath: string): JscpdResult {
-    try {
-      const data = JSON.parse(fs.readFileSync(reportPath, "utf-8"));
-      // Stats live in statistics.total, not statistics.clones
-      const total = data.statistics?.total ?? {};
-
-      const duplicatedLines: number = total.duplicatedLines ?? 0;
-      const totalLines: number = total.lines ?? 0;
-      const percentage: number = total.percentage ?? (totalLines > 0 ? (duplicatedLines / totalLines) * 100 : 0);
-
-      const rawClones: any[] = data.duplicates ?? [];
-      const clones: DuplicateClone[] = rawClones.map((c: any) => ({
-        fileA: c.firstFile?.name ?? "",
-        startA: c.firstFile?.start ?? 0,
-        fileB: c.secondFile?.name ?? "",
-        startB: c.secondFile?.start ?? 0,
-        lines: c.lines ?? 0,
-        tokens: c.tokens ?? 0,
-      }));
-
-      return { success: true, clones, duplicatedLines, totalLines, percentage };
-    } catch {
-      return { success: false, clones: [], duplicatedLines: 0, totalLines: 0, percentage: 0 };
-    }
-  }
+	private available: boolean | null = null;
+	private log: (msg: string) => void;
+
+	constructor(verbose = false) {
+		this.log = verbose ? (msg) => console.log(`[jscpd] ${msg}`) : () => {};
+	}
+
+	isAvailable(): boolean {
+		if (this.available !== null) return this.available;
+		const result = spawnSync("npx", ["jscpd", "--version"], {
+			encoding: "utf-8",
+			timeout: 10000,
+			shell: true,
+		});
+		this.available = !result.error && result.status === 0;
+		return this.available;
+	}
+
+	/**
+	 * Scan a directory for duplicate code blocks.
+	 * Uses a temp output dir to capture JSON report.
+	 */
+	scan(cwd: string, minLines = 5, minTokens = 50): JscpdResult {
+		if (!this.isAvailable()) {
+			return {
+				success: false,
+				clones: [],
+				duplicatedLines: 0,
+				totalLines: 0,
+				percentage: 0,
+			};
+		}
+
+		const outDir = path.join(os.tmpdir(), `pi-lens-jscpd-${Date.now()}`);
+		fs.mkdirSync(outDir, { recursive: true });
+
+		try {
+			spawnSync(
+				"npx",
+				[
+					"jscpd",
+					".",
+					"--min-lines",
+					String(minLines),
+					"--min-tokens",
+					String(minTokens),
+					"--reporters",
+					"json",
+					"--output",
+					outDir,
+					"--ignore",
+					"**/node_modules/**,**/dist/**,**/build/**,**/.git/**,**/.pi-lens/**,**/*.md,**/*.txt,**/*.json,**/*.yaml,**/*.yml,**/*.toml,**/*.lock",
+				],
+				{
+					encoding: "utf-8",
+					timeout: 30000,
+					cwd,
+					shell: true,
+				},
+			);
+
+			const reportPath = path.join(outDir, "jscpd-report.json");
+			if (!fs.existsSync(reportPath)) {
+				return {
+					success: true,
+					clones: [],
+					duplicatedLines: 0,
+					totalLines: 0,
+					percentage: 0,
+				};
+			}
+
+			return this.parseReport(reportPath);
+		} catch (err: any) {
+			this.log(`Scan error: ${err.message}`);
+			return {
+				success: false,
+				clones: [],
+				duplicatedLines: 0,
+				totalLines: 0,
+				percentage: 0,
+			};
+		} finally {
+			try {
+				fs.rmSync(outDir, { recursive: true, force: true });
+			} catch (err) { void err; }
+		}
+	}
+
+	formatResult(result: JscpdResult, maxClones = 8): string {
+		if (!result.success || result.clones.length === 0) return "";
+
+		const pct = result.percentage.toFixed(1);
+		let output = `[jscpd] ${result.clones.length} duplicate block(s) — ${pct}% of codebase (${result.duplicatedLines}/${result.totalLines} lines):\n`;
+
+		for (const clone of result.clones.slice(0, maxClones)) {
+			const a = `${path.basename(clone.fileA)}:${clone.startA}`;
+			const b = `${path.basename(clone.fileB)}:${clone.startB}`;
+			output += `  ${clone.lines} lines — ${a} ↔ ${b}\n`;
+		}
+
+		if (result.clones.length > maxClones) {
+			output += `  ... and ${result.clones.length - maxClones} more\n`;
+		}
+
+		return output;
+	}
+
+	// --- Internal ---
+
+	private parseReport(reportPath: string): JscpdResult {
+		try {
+			const data = JSON.parse(fs.readFileSync(reportPath, "utf-8"));
+			// Stats live in statistics.total, not statistics.clones
+			const total = data.statistics?.total ?? {};
+
+			const duplicatedLines: number = total.duplicatedLines ?? 0;
+			const totalLines: number = total.lines ?? 0;
+			const percentage: number =
+				total.percentage ??
+				(totalLines > 0 ? (duplicatedLines / totalLines) * 100 : 0);
+
+			const rawClones: any[] = data.duplicates ?? [];
+			const clones: DuplicateClone[] = rawClones.map((c: any) => ({
+				fileA: c.firstFile?.name ?? "",
+				startA: c.firstFile?.start ?? 0,
+				fileB: c.secondFile?.name ?? "",
+				startB: c.secondFile?.start ?? 0,
+				lines: c.lines ?? 0,
+				tokens: c.tokens ?? 0,
+			}));
+
+			return { success: true, clones, duplicatedLines, totalLines, percentage };
+		} catch {
+			return {
+				success: false,
+				clones: [],
+				duplicatedLines: 0,
+				totalLines: 0,
+				percentage: 0,
+			};
+		}
+	}
 }