pi-lean-dimension 0.5.0 → 0.6.0

package/node_modules/pi-lean-portal/__tests__/router-session.test.ts

@@ -120,6 +120,29 @@ describe("Router session / profile dispatch", () => {
 			const result = await router.navigate("https://example.com");
 			expect(result.profileMode).toBe("none");
 		});
+
+		it('profile="none" destroys existing session with profile', async () => {
+			// First create a session with a named profile
+			await router.navigate("https://example.com", {
+				profile: "work",
+			});
+			expect(sessionManager.getSession("default")?.profileName).toBe("work");
+			expect(sessionManager.getSession("default")?.persistState).toBe(true);
+			mock.calls.delete("navigate");
+
+			// Switch to none — should destroy old context
+			const result = await router.navigate("https://example.com/other", {
+				profile: "none",
+			});
+
+			expect(result.success).toBe(true);
+			expect(result.profileMode).toBe("none");
+			expect(result.profileName).toBeUndefined();
+
+			const session = sessionManager.getSession("default");
+			expect(session?.persistState).toBeFalsy();
+			expect(session?.profileName).toBeUndefined();
+		});
 	});
 
 	// ─── profile="session" ───────────────────────────────────────
@@ -175,6 +198,22 @@ describe("Router session / profile dispatch", () => {
 			const session = sessionManager.getSession("default");
 			expect(session?.persistState).toBeFalsy();
 		});
+
+		it('clears persistState and profileName for profile="none"', async () => {
+			await router.navigate("https://example.com", {
+				profile: "session",
+				piSessionId: TEST_PI_SESSION_ID,
+			});
+			expect(sessionManager.getSession("default")?.persistState).toBe(true);
+
+			await router.navigate("https://example.com/other", {
+				profile: "none",
+			});
+
+			const session = sessionManager.getSession("default");
+			expect(session?.persistState).toBe(false);
+			expect(session?.profileName).toBeUndefined();
+		});
 	});
 
 	// ─── Named profile ──────────────────────────────────────────
@@ -268,157 +307,6 @@ describe("Router session / profile dispatch", () => {
 			expect(result.error).toContain("Invalid profile name");
 		});
 	});
-
-	// ─── profile parameter ─────────────────────────────────────
-
-	describe("profile parameter", () => {
-		it('profile="none" creates ephemeral session', async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "none",
-			});
-
-			expect(result.success).toBe(true);
-			expect(result.profileMode).toBe("none");
-			expect(result.profileName).toBeUndefined();
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBeFalsy();
-		});
-
-		it('profile="session" with piSessionId resolves to _session-<id>', async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "session",
-				piSessionId: TEST_PI_SESSION_ID,
-			});
-
-			expect(result.success).toBe(true);
-			expect(result.profileMode).toBe("session");
-			expect(result.profileName).toContain("_session-");
-			expect(result.profileName).toContain(TEST_PI_SESSION_ID);
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBe(true);
-			expect(session?.profileName).toContain("_session-");
-		});
-
-		it('profile="session" without piSessionId falls back to "none"', async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "session",
-			});
-
-			expect(result.success).toBe(true);
-			expect(result.profileMode).toBe("none");
-			expect(result.profileName).toBeUndefined();
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBeFalsy();
-		});
-
-		it('profile="work" creates named profile session', async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "work",
-			});
-
-			expect(result.success).toBe(true);
-			expect(result.profileMode).toBe("named");
-			expect(result.profileName).toBe("work");
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBe(true);
-			expect(session?.profileName).toBe("work");
-		});
-
-		it('profile="none" destroys existing session with profile', async () => {
-			// First create a session with a named profile
-			await router.navigate("https://example.com", {
-				profile: "work",
-			});
-			expect(sessionManager.getSession("default")?.profileName).toBe("work");
-			expect(sessionManager.getSession("default")?.persistState).toBe(true);
-			mock.calls.delete("navigate");
-
-			// Switch to none — should destroy old context
-			const result = await router.navigate("https://example.com/other", {
-				profile: "none",
-			});
-
-			expect(result.success).toBe(true);
-			expect(result.profileMode).toBe("none");
-			expect(result.profileName).toBeUndefined();
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBeFalsy();
-			expect(session?.profileName).toBeUndefined();
-		});
-	});
-
-	// ─── profileMode / profileName in result ────────────────────
-
-	describe("result fields", () => {
-		it("shows profileMode none and no profileName for default", async () => {
-			const result = await router.navigate("https://example.com");
-			expect(result.profileMode).toBe("none");
-			expect(result.profileName).toBeUndefined();
-		});
-
-		it("includes profileMode and profileName for named profile", async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "test-profile",
-			});
-			expect(result.profileMode).toBe("named");
-			expect(result.profileName).toBe("test-profile");
-		});
-
-		it('includes profileMode and profileName for profile="session" with piSessionId', async () => {
-			const result = await router.navigate("https://example.com", {
-				profile: "session",
-				piSessionId: TEST_PI_SESSION_ID,
-			});
-			expect(result.profileMode).toBe("session");
-			expect(result.profileName).toContain("_session-");
-		});
-	});
-
-	// ─── BrowserSession fields ──────────────────────────────────
-
-	describe("BrowserSession fields", () => {
-		it("sets persistState=true and profileName for named profile", async () => {
-			await router.navigate("https://example.com", {
-				profile: "my-projects",
-			});
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBe(true);
-			expect(session?.profileName).toBe("my-projects");
-		});
-
-		it('sets persistState=true and profileName for profile="session" with piSessionId', async () => {
-			await router.navigate("https://example.com", {
-				profile: "session",
-				piSessionId: TEST_PI_SESSION_ID,
-			});
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBe(true);
-			expect(session?.profileName).toContain("_session-");
-		});
-
-		it('clears persistState and profileName for profile="none"', async () => {
-			await router.navigate("https://example.com", {
-				profile: "session",
-				piSessionId: TEST_PI_SESSION_ID,
-			});
-			expect(sessionManager.getSession("default")?.persistState).toBe(true);
-
-			await router.navigate("https://example.com/other", {
-				profile: "none",
-			});
-
-			const session = sessionManager.getSession("default");
-			expect(session?.persistState).toBe(false);
-			expect(session?.profileName).toBeUndefined();
-		});
-	});
 });
 
 // ─── Router defaultProfile config routing ────────────────────────

package/node_modules/pi-lean-portal/__tests__/web-guides.test.ts

@@ -1,14 +1,13 @@
 /**
  * Tests for Web Navigation Guides (core/guides.ts)
  *
- * Covers types, resolveApplicableGuides, formatGuideFooter, formatGuideList,
+ * Covers resolveApplicableGuides, formatGuideFooter, formatGuideList,
  * parseGuideFile, buildDomainMap, and guide structure.
  * All tests run without Chromium.
  */
 
 import { describe, it, expect, beforeEach, afterEach } from "vitest";
 import {
-	type Guide,
 	type ApplicableGuide,
 	resolveApplicableGuides,
 	parseGuideContent,
@@ -37,48 +36,6 @@ vi.mock("node:fs", async (importActual) => {
 	};
 });
 
-// ─── Types ──────────────────────────────────────────────────────
-
-describe("types", () => {
-	it("Guide interface is structural — icon and shortName now required", () => {
-		const g: Guide = {
-			content: "test",
-			updated: "2026-01-01",
-			category: "site",
-			source: "builtin",
-			icon: "📖",
-			shortName: "test",
-		};
-		expect(g.icon).toBe("📖");
-		expect(g.shortName).toBe("test");
-	});
-
-	it("triggerSignal field on Guide works correctly", () => {
-		const g: Guide = {
-			content: "test",
-			updated: "2026-01-01",
-			category: "pattern",
-			source: "builtin",
-			icon: "⚠",
-			shortName: "test",
-			triggerSignal: "botDetected",
-		};
-		expect(g.triggerSignal).toBe("botDetected");
-	});
-
-	it("ApplicableGuide interface — name, icon, shortName, reason, category required", () => {
-		const r: ApplicableGuide = {
-			name: "test",
-			icon: "⚠",
-			shortName: "test",
-			reason: "test reason",
-			category: "pattern",
-		};
-		expect(r.name).toBe("test");
-		expect(r.category).toBe("pattern");
-	});
-});
-
 // ─── resolveApplicableGuides ────────────────────────────────────
 
 function injectTestFixture(): void {

package/node_modules/pi-lean-portal/backends/chromium/index.ts

@@ -35,7 +35,7 @@ export class ChromiumPlugin extends PlaywrightPluginBase {
 	}
 
 	protected get installHint(): string {
-		return "Browser not installed. Run: npx playwright install chromium firefox";
+		return "Browser not installed. Run /web install to install it.";
 	}
 }
 

package/node_modules/pi-lean-portal/backends/firefox/index.ts

@@ -54,7 +54,7 @@ export class FirefoxPlugin extends PlaywrightPluginBase {
 	}
 
 	protected get installHint(): string {
-		return "Browser not installed. Run: npx playwright install chromium firefox";
+		return "Browser not installed. Run /web install to install it.";
 	}
 }
 

package/node_modules/pi-lean-portal/backends/playwright-base/playwright-plugin.ts

@@ -83,7 +83,7 @@ export abstract class PlaywrightPluginBase implements BrowserPlugin {
 
 	/**
 	 * Engine-specific install hint, shown when the browser executable
-	 * is not installed. Example: "Run: npx playwright install firefox".
+	 * is not installed, e.g. "Browser not installed. Run /web install to install it".
 	 */
 	protected abstract get installHint(): string;
 

package/node_modules/pi-lean-portal/backends/python-base/pi_browser_bridge/playwright_base.py

@@ -38,6 +38,7 @@ contexts across tasks.
 """
 
 import base64
+import contextlib
 import json
 import os
 import re
@@ -299,13 +300,14 @@ class PlaywrightBridge:
     _csp_safe_readonly_via_init_script: bool = False
 
     #: When non-zero, ``_wait_for_navigation_settle`` uses this as the
-    #: settle poll budget (ms) instead of the default 400.  Stealth backends
+    #: settle poll budget (ms) instead of the default.  Stealth backends
     #: whose patched browser fires navigation events with higher latency
     #: (e.g. Camoufox's Juggler) set a larger value to avoid settling before
-    #: the navigation commit is observable.  Default 400 matches the
-    #: historical hard-coded value so shipped chromium-py / firefox-py are
-    #: unchanged.
-    _settle_budget_ms: int = 400
+    #: the navigation commit is observable.  Default reads
+    #: ``navSettle.settleTimeoutMs`` from the shared TS↔Python parity JSON
+    #: (``browser-data.json``) so both runtimes stay in lockstep; shipped
+    #: chromium-py / firefox-py are unchanged.
+    _settle_budget_ms: int = NAV_SETTLE["settleTimeoutMs"]
 
     #: When True, ``_wait_for_navigation_settle`` switches the no-nav
     #: polling branch from a fixed budget to "URL stable for 150 ms **or**
@@ -448,10 +450,8 @@ class PlaywrightBridge:
             self._log("captureUA", success=False, ua="(fallback)")
         finally:
             if page is not None:
-                try:
+                with contextlib.suppress(Exception):
                     page.close()
-                except Exception:
-                    pass
 
     # ── Debug logging ───────────────────────────────────────────
 
@@ -518,15 +518,11 @@ class PlaywrightBridge:
     def _maybe_stop_playwright(self) -> None:
         """Stop the shared Playwright if no sessions remain."""
         if not self.sessions and self._pw is not None:
-            try:
-                if self._browser:
+            if self._browser:
+                with contextlib.suppress(Exception):
                     self._browser.close()
-            except Exception:
-                pass
-            try:
+            with contextlib.suppress(Exception):
                 self._pw.stop()
-            except Exception:
-                pass
             self._pw = None
             self._browser = None
 
@@ -577,7 +573,7 @@ class PlaywrightBridge:
         # Start Playwright trace capture if BROWSER_TRACE_DIR is set.
         _trace_dir = os.environ.get("BROWSER_TRACE_DIR")
         if _trace_dir:
-            try:
+            with contextlib.suppress(Exception):
                 context.tracing.start(
                     screenshots=True,
                     snapshots=True,
@@ -588,9 +584,7 @@ class PlaywrightBridge:
                     taskId=config.get("_task_id", "shared"),
                     action="start",
                     dir=_trace_dir,
-                )
-            except Exception:
-                pass  # Best-effort
+                )  # Best-effort
 
         # CSP-safe read-only eval path (see _csp_safe_readonly_via_init_script).
         # Registers an init script that stashes the EXTRACTOR_SCRIPT result in
@@ -749,12 +743,10 @@ class PlaywrightBridge:
         if session is not None:
             context: Any = session.get("context")
 
-            try:
-                page: Any = session.get("page")
-                if page and not page.is_closed():
+            page: Any = session.get("page")
+            if page and not page.is_closed():
+                with contextlib.suppress(Exception):
                     page.close()
-            except Exception:
-                pass
 
             # Stop and save Playwright trace if BROWSER_TRACE_DIR is set.
             _trace_dir = os.environ.get("BROWSER_TRACE_DIR")
@@ -767,14 +759,15 @@ class PlaywrightBridge:
                     )
                     context.tracing.stop(path=_trace_path)
                     self._log("tracing", taskId=task_id, action="stop", dir=_trace_dir)
-                except Exception:
-                    pass
+                except Exception as exc:
+                    # Best-effort: a failed trace save must not fail cleanup.
+                    self._log(
+                        "tracing", taskId=task_id, action="stop-failed", error=str(exc)
+                    )
 
-            try:
-                if context:
+            if context:
+                with contextlib.suppress(Exception):
                     context.close()
-            except Exception:
-                pass
 
         # Remove session + element cache
         self.sessions.pop(task_id, None)
@@ -926,15 +919,11 @@ class PlaywrightBridge:
                 stealth patched-Firefox binaries don't fire it reliably and
                 loitering for it can deadlock the Juggler driver.
         """
-        try:
+        with contextlib.suppress(Exception):
             page.wait_for_load_state("load", timeout=timeout_ms)
-        except Exception:
-            pass
         if not skip_networkidle:
-            try:
+            with contextlib.suppress(Exception):
                 page.wait_for_load_state("networkidle", timeout=timeout_ms)
-            except Exception:
-                pass
 
     def _wait_for_navigation_settle(
         self,
@@ -974,8 +963,10 @@ class PlaywrightBridge:
         page.on("framenavigated", _on_nav)
 
         try:
-            # Wait for a potential navigation to start (150 ms window)
-            page.wait_for_timeout(150)
+            # Wait for a potential navigation to start (shared race window,
+            # ``navSettle.settleRaceMs`` in browser-data.json — same value
+            # the TS nav-settle races against ``framenavigated``).
+            page.wait_for_timeout(NAV_SETTLE["settleRaceMs"])
 
             waited_for_load = False
             if navigated:
@@ -1099,13 +1090,12 @@ class PlaywrightBridge:
                     break
 
         # ── DOM stabilization wait ──────────────────────────────
-        try:
+        # Stabilization timeout is best-effort — proceed.
+        with contextlib.suppress(Exception):
             page.wait_for_function(
                 _DOM_STABILIZE_JS,
                 timeout=NAV_SETTLE["navTimeoutMs"],
             )
-        except Exception:
-            pass  # Stabilization timed out — proceed
 
         # ── Bot detection ───────────────────────────────────────
         bot_detected = check_bot_detection(page)
@@ -1331,11 +1321,9 @@ class PlaywrightBridge:
 
             new_url: str | None = None
             new_title: str | None = None
-            try:
+            with contextlib.suppress(Exception):
                 new_url = page.url
                 new_title = page.title()
-            except Exception:
-                pass
 
             extra: dict[str, Any] = {}
             if new_url is not None:
@@ -1554,20 +1542,18 @@ class PlaywrightBridge:
             # ponytail: single retry, no backoff — challenge pages settle in
             # one load cycle; add exponential backoff if a real challenge
             # needs >1 retry.
-            # Nested ifs (rather than
-            # `self._wrap_mw_eval_in_eval and "Execution context was destroyed" in err_msg`)
-            # keep the no-boolean-in-except lint calm; behavior is identical.
+            retry_destroyed = False
             if self._wrap_mw_eval_in_eval:
-                if "Execution context was destroyed" in err_msg:
-                    try:
-                        page.wait_for_load_state("load")
-                    except Exception:
-                        pass  # Best-effort: proceed to retry even if wait fails
-                    try:
-                        result = page.evaluate(effective_expression)
-                        return {"success": True, "result": result}
-                    except Exception as retry_exc:
-                        return {"success": False, "error": str(retry_exc)}
+                retry_destroyed = "Execution context was destroyed" in err_msg
+            if retry_destroyed:
+                # Best-effort: proceed to retry even if wait fails
+                with contextlib.suppress(Exception):
+                    page.wait_for_load_state("load")
+                try:
+                    result = page.evaluate(effective_expression)
+                    return {"success": True, "result": result}
+                except Exception as retry_exc:
+                    return {"success": False, "error": str(retry_exc)}
             return {
                 "success": False,
                 "error": err_msg,

package/node_modules/pi-lean-portal/backends/python-base/pi_browser_bridge/transport.py

@@ -21,9 +21,7 @@ Error response::
 
 import json
 import sys
-import traceback
-from typing import Any, Optional
-
+from typing import Any
 
 # ─── Standard JSON-RPC error codes ────────────────────────────────────
 
@@ -31,7 +29,6 @@ PARSE_ERROR = -32700
 INVALID_REQUEST = -32600
 METHOD_NOT_FOUND = -32601
 INVALID_PARAMS = -32602
-INTERNAL_ERROR = -32603
 
 # Custom error codes (application-level)
 APPLICATION_ERROR = -32000
@@ -50,7 +47,8 @@ class InvalidRequestError(ValueError):
 
 # ─── Reading requests ─────────────────────────────────────────────────
 
-def read_request() -> Optional[dict[str, Any]]:
+
+def read_request() -> dict[str, Any] | None:
     """Read one JSON-RPC request from stdin (line-delimited).
 
     Returns the parsed request dict, or None on EOF.
@@ -86,6 +84,7 @@ def read_request() -> Optional[dict[str, Any]]:
 
 # ─── Writing responses ────────────────────────────────────────────────
 
+
 def write_response(response: dict[str, Any]) -> None:
     """Write a JSON-RPC response to stdout as a single JSON line, then flush.
 
@@ -110,7 +109,7 @@ def make_error_response(
     request_id: Any,
     code: int,
     message: str,
-    data: Optional[dict[str, Any]] = None,
+    data: dict[str, Any] | None = None,
 ) -> dict[str, Any]:
     """Build a JSON-RPC error response."""
     error: dict[str, Any] = {
@@ -136,24 +135,10 @@ def make_invalid_request(request_id: Any = None) -> dict[str, Any]:
     return make_error_response(request_id, INVALID_REQUEST, "Invalid Request")
 
 
-def make_internal_error(
-    request_id: Any,
-    exc: Exception,
-) -> dict[str, Any]:
-    """Build an internal error response including Python traceback."""
-    tb = traceback.format_exception(type(exc), exc, exc.__traceback__)
-    return make_error_response(
-        request_id,
-        INTERNAL_ERROR,
-        f"Internal error: {exc}",
-        data={"traceback": "".join(tb)},
-    )
-
-
 def make_application_error(
     request_id: Any,
     message: str,
-    traceback_str: Optional[str] = None,
+    traceback_str: str | None = None,
 ) -> dict[str, Any]:
     """Build an application-level error response."""
     data: dict[str, Any] = {}