pi-lean-dimension 0.5.0 → 0.6.0

package/node_modules/pi-lean-portal/__tests__/browser-navigate.test.ts

@@ -6,6 +6,9 @@
  */
 
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
 import { browserNavigateTool } from "../tools/browser-navigate.js";
 
 // ─── Mock router ─────────────────────────────────────────────────
@@ -16,7 +19,7 @@ const mockNavigateResult = {
 	title: "",
 	snapshot: "",
 	elementCount: 0,
-	error: "Browser not installed. Run: npx playwright install chromium firefox",
+	error: "Browser not installed. Run /web install to install it.",
 	backendUsed: "chromium",
 };
 
@@ -112,7 +115,7 @@ describe("browser-navigate notify path", () => {
 		// notify should have been called with the install command
 		expect(notifySpy).toHaveBeenCalledTimes(1);
 		expect(notifySpy).toHaveBeenCalledWith(
-			"Browser not installed. Run: npx playwright install chromium firefox",
+			"Browser not installed. Run /web install to install it.",
 			"warning",
 		);
 	});
@@ -142,3 +145,31 @@ describe("browser-navigate notify path", () => {
 		expect(notifySpy).not.toHaveBeenCalled();
 	});
 });
+
+// ─── Structural: hint-string coupling ───────────────────────────
+
+// The navigate notify is gated on result.error containing "not installed"
+// (see the isInstallError check in browser-navigate.ts), and that error is
+// the backend `installHint` string. A hint that loses the substring silently
+// disables the notify — and the mocked-error tests above cannot catch it,
+// because they control result.error themselves. These source-level checks
+// pin the coupling.
+
+describe("installHint string coupling", () => {
+	const portalRoot = join(dirname(fileURLToPath(import.meta.url)), "..");
+	const hintSources = [
+		join(portalRoot, "backends", "chromium", "index.ts"),
+		join(portalRoot, "backends", "firefox", "index.ts"),
+		join(portalRoot, "tools", "browser-navigate.ts"),
+	];
+
+	for (const src of hintSources) {
+		it(`${src.split(/[\\/]/).slice(-2).join("/")} hint contains "not installed" and no npx advice`, () => {
+			const text = readFileSync(src, "utf8");
+			expect(text).toContain(
+				'"Browser not installed. Run /web install to install it."',
+			);
+			expect(text).not.toContain("npx playwright install");
+		});
+	}
+});

package/node_modules/pi-lean-portal/__tests__/browser-status.test.ts

@@ -15,6 +15,7 @@ import type { BrowserSession } from "../core/shared/session-manager.js";
 import { handleStatusSubcommand } from "../browser-status.js";
 import { sessionManager } from "../core/shared/session-manager.js";
 import { listProfiles } from "../browser-profile.js";
+import { mockCtx } from "./helpers/mock-pi.js";
 
 // ─── Mock dependencies ──────────────────────────────────────────
 
@@ -44,6 +45,12 @@ vi.mock("../core/shared/storage-state.js", () => ({
 	isSessionProfile: vi.fn((name: string) => name.startsWith("_session-")),
 }));
 
+vi.mock("../browser-install.js", () => ({
+	ENGINES: ["chromium", "firefox"],
+	resolveBundledPlaywright: vi.fn(() => ({ pw: {} })),
+	detectInstalledBrowsers: vi.fn(() => ({ chromium: true, firefox: false })),
+}));
+
 // ─── Type shortcuts ─────────────────────────────────────────────
 
 type MockSession = {
@@ -62,19 +69,6 @@ type MockSession = {
 
 type Profile = ReturnType<typeof listProfiles>[number];
 
-// ─── Helpers ────────────────────────────────────────────────────
-
-function mockCtx(): ExtensionContext {
-	return {
-		ui: {
-			notify: vi.fn(),
-			setStatus: vi.fn(),
-		},
-		// Minimal shape required by ExtensionContext
-		sessionManager: {},
-	} as unknown as ExtensionContext;
-}
-
 // ─── Tests ──────────────────────────────────────────────────────
 
 describe("handleStatusSubcommand", () => {
@@ -82,7 +76,9 @@ describe("handleStatusSubcommand", () => {
 	let notifySpy: ReturnType<typeof vi.fn>;
 
 	beforeEach(() => {
-		vi.clearAllMocks();
+		// restoreAllMocks (not clearAllMocks): per-test mockReturnValue/mockImplementation
+		// overrides (e.g. the throwing resolveBundledPlaywright) must not leak into later tests.
+		vi.restoreAllMocks();
 		ctx = mockCtx();
 		notifySpy = ctx.ui.notify as ReturnType<typeof vi.fn>;
 		// Default: empty session-manager state, idle status
@@ -109,6 +105,44 @@ describe("handleStatusSubcommand", () => {
 		expect(msg).toContain("📖 Learn mode: ❌ off");
 	});
 
+	// ── Browser-binary detection line ───────────────────────
+
+	it("shows per-engine browser detection with install hint when missing", async () => {
+		const { detectInstalledBrowsers } = await import("../browser-install.js");
+		vi.mocked(detectInstalledBrowsers).mockReturnValue({
+			chromium: true,
+			firefox: false,
+		});
+		handleStatusSubcommand(ctx, true, false);
+
+		const msg = notifySpy.mock.lastCall?.[0] as string;
+		expect(msg).toContain("Browsers: chromium ✓ firefox ✗ (run /web install)");
+	});
+
+	it("omits the install hint when all Node-backend browsers are present", async () => {
+		const { detectInstalledBrowsers } = await import("../browser-install.js");
+		vi.mocked(detectInstalledBrowsers).mockReturnValue({
+			chromium: true,
+			firefox: true,
+		});
+		handleStatusSubcommand(ctx, true, false);
+
+		const msg = notifySpy.mock.lastCall?.[0] as string;
+		expect(msg).toContain("Browsers: chromium ✓ firefox ✓");
+		expect(msg).not.toContain("run /web install");
+	});
+
+	it("omits the Browsers line when playwright is unresolvable", async () => {
+		const { resolveBundledPlaywright } = await import("../browser-install.js");
+		vi.mocked(resolveBundledPlaywright).mockImplementation(() => {
+			throw new Error("Cannot find module 'playwright'");
+		});
+		expect(() => handleStatusSubcommand(ctx, true, false)).not.toThrow();
+
+		const msg = notifySpy.mock.lastCall?.[0] as string;
+		expect(msg).not.toContain("Browsers:");
+	});
+
 	// ── Plugin listing ─────────────────────────────────────────
 
 	it("lists plugins with enabled/disabled state", () => {
@@ -457,15 +491,4 @@ describe("handleStatusSubcommand", () => {
 		// Session profiles collapsed
 		expect(msg).toContain("Session profiles: 1 (manage with /web profile)");
 	});
-
-	// ── Edge: no profiles but named/session filter weirdness ───
-
-	it('shows "Profiles: none" when listProfiles returns an empty array', () => {
-		vi.mocked(listProfiles).mockReturnValue([]);
-
-		handleStatusSubcommand(ctx, false, false);
-
-		const msg = notifySpy.mock.lastCall?.[0] as string;
-		expect(msg).toContain("Profiles: none");
-	});
 });

package/node_modules/pi-lean-portal/__tests__/browser-toggle-profile.test.ts

@@ -27,6 +27,7 @@ vi.mock("node:fs", () => ({
 
 import browserToggle from "../browser-toggle.js";
 import { listProfiles, formatProfileList } from "../browser-profile.js";
+import { captureWebHandler } from "./helpers/mock-pi.js";
 
 // ─── Helpers ─────────────────────────────────────────────────────
 
@@ -55,20 +56,13 @@ function mockPi(tools?: string[]): ExtensionAPI {
 }
 
 /**
- * Capture the command handler from registerCommand.
+ * Register the /web command and capture its handler.
  */
 function captureHandler(
 	pi: ExtensionAPI,
 ): (args: string, ctx: any) => Promise<void> {
-	let capturedHandler: ((args: string, ctx: any) => Promise<void>) | undefined;
-	(pi.registerCommand as Mock).mockImplementation(
-		(_name: string, opts: any) => {
-			capturedHandler = opts.handler;
-		},
-	);
 	browserToggle(pi);
-	if (!capturedHandler) throw new Error("Handler was not registered");
-	return capturedHandler;
+	return captureWebHandler(pi);
 }
 
 beforeEach(() => {

package/node_modules/pi-lean-portal/__tests__/browser-toggle.test.ts

@@ -11,11 +11,9 @@
 
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import { EventEmitter } from "node:events";
-import type {
-	ExtensionAPI,
-	ExtensionContext,
-} from "@earendil-works/pi-coding-agent";
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { TOOLSET_EVENTS } from "pi-tool-masking";
+import { mockCtx, captureWebHandler } from "./helpers/mock-pi.js";
 import browserToggle, {
 	getToggleState,
 	getLearnState,
@@ -111,30 +109,6 @@ function mockPi(initialTools?: string[]): MockPi {
 	return { pi, events: eventEmitter, handlers, entryCalls };
 }
 
-function mockCtx(overrides: Partial<ExtensionContext> = {}): any {
-	return {
-		sessionManager: { getBranch: () => [] },
-		ui: {
-			setStatus: vi.fn(),
-			theme: { fg: (_c: string, t: string) => t },
-			notify: vi.fn(),
-		},
-		mode: "tui",
-		cwd: "/mock",
-		hasUI: true,
-		isIdle: () => true,
-		modelRegistry: {} as any,
-		...overrides,
-	};
-}
-
-/** Capture the /web command handler from registerCommand. */
-function captureWebHandler(
-	pi: ExtensionAPI,
-): (args: string, ctx: any) => Promise<void> {
-	return (pi.registerCommand as any).mock.calls[0][1].handler;
-}
-
 // ==================================================================
 //  Default export
 // ==================================================================
@@ -371,7 +345,7 @@ describe("/web focus-mode guard", () => {
 		browserToggle(pi);
 		focusAllowlistForTest();
 
-		for (const sub of ["status", "profile", "cookies", ""]) {
+		for (const sub of ["status", "profile", "cookies", "install", ""]) {
 			const ctx = mockCtx();
 			await captureWebHandler(pi)(sub, ctx);
 

package/node_modules/pi-lean-portal/__tests__/fetch-backend.test.ts

@@ -33,6 +33,11 @@ interface MockFetchOpts {
 	 * Only meaningful when delayMs is not set.
 	 */
 	abortOnly?: boolean;
+	/**
+	 * If true, respond with headers immediately but keep the body open until
+	 * aborted (for body-phase timeout tests). Takes precedence over delayMs.
+	 */
+	bodyStall?: boolean;
 }
 
 /**
@@ -70,6 +75,31 @@ function mockFetch(opts: MockFetchOpts): void {
 					return;
 				}
 
+				if (opts.bodyStall) {
+					// Headers arrive at once; the body read only settles on abort.
+					resolve(
+						new Response(
+							new ReadableStream({
+								start(streamController) {
+									signal?.addEventListener(
+										"abort",
+										() =>
+											streamController.error(
+												new DOMException(
+													"The operation was aborted",
+													"AbortError",
+												),
+											),
+										{ once: true },
+									);
+								},
+							}),
+							{ status: 200, headers: { "Content-Type": "text/html" } },
+						),
+					);
+					return;
+				}
+
 				const respond = (): void => {
 					resolve(
 						new Response(html, {
@@ -371,4 +401,25 @@ describe("webFetch — timeout", () => {
 		expect(result.success).toBe(false);
 		expect(result.error).toBe("timeout");
 	});
+
+	it("times out when the body stalls after the headers arrive", async () => {
+		vi.useFakeTimers();
+		try {
+			mockFetch({ body: "", bodyStall: true });
+
+			const pending = webFetch({
+				url: "http://example.com/stalled-body",
+				timeout: 1,
+			});
+
+			// Fire the abort timer deterministically instead of waiting on it.
+			await vi.advanceTimersByTimeAsync(1000);
+			const result = await pending;
+
+			expect(result.success).toBe(false);
+			expect(result.error).toBe("timeout");
+		} finally {
+			vi.useRealTimers();
+		}
+	});
 });

package/node_modules/pi-lean-portal/__tests__/helpers/mock-pi.ts

@@ -0,0 +1,34 @@
+import { vi } from "vitest";
+
+/**
+ * Shared ExtensionContext stub for command-handler tests. Superset of the
+ * shapes the browser-toggle / browser-install / browser-status tests need;
+ * callers add or replace fields via `overrides`.
+ */
+export function mockCtx(overrides: Record<string, unknown> = {}): any {
+	return {
+		sessionManager: { getBranch: () => [] },
+		ui: {
+			notify: vi.fn(),
+			setStatus: vi.fn(),
+			setWidget: vi.fn(),
+			theme: { fg: (_c: string, t: string) => t },
+			custom: vi.fn(async () => undefined),
+		},
+		mode: "tui",
+		cwd: "/mock",
+		hasUI: true,
+		isIdle: () => true,
+		modelRegistry: {},
+		...overrides,
+	};
+}
+
+/** Capture the /web command handler registered via registerCommand. */
+export function captureWebHandler(
+	pi: unknown,
+): (args: string, ctx: any) => Promise<void> {
+	const handler = (pi as any).registerCommand.mock.calls[0]?.[1]?.handler;
+	if (!handler) throw new Error("Handler was not registered");
+	return handler;
+}

package/node_modules/pi-lean-portal/__tests__/helpers/mock-python-bridge.py

@@ -2,11 +2,14 @@
 """Mock bridge for testing PythonPluginAdapter.
 
 Reads JSON-RPC 2.0 requests from stdin and writes hardcoded responses
-to stdout.  Supports: ping, shutdown, browser.navigate, browser.snapshot,
-browser.click, browser.cleanup.  Unknown methods return a METHOD_NOT_FOUND
-error.  The string "INVALID_JSON" as a request line triggers a malformed
-JSON response (to test protocol violation handling).
+to stdout: the ping / browser.init / shutdown handshake, the
+browser.* navigation, interaction, console, evaluate, screenshot,
+cookie and storage-state calls, and browser.cleanup.  browser.error
+and browser.missingSession deliberately return JSON-RPC errors (to
+test error handling).  Unknown methods return a METHOD_NOT_FOUND
+error, and a malformed request line returns a parse error.
 """
+
 import json
 import sys
 
@@ -17,12 +20,6 @@ def main() -> None:
         if not line:
             continue
 
-        # Special case: protocol violation test
-        if line == "INVALID_JSON":
-            sys.stdout.write("not valid json\n")
-            sys.stdout.flush()
-            continue
-
         try:
             request = json.loads(line)
         except json.JSONDecodeError:
@@ -61,7 +58,7 @@ def main() -> None:
                             "name": "Example Domain",
                             "props": [],
                             "depth": 0,
-                            "raw": "- link \"Example Domain\"",
+                            "raw": '- link "Example Domain"',
                             "occurrenceIndex": 0,
                         },
                         "e2": {
@@ -69,7 +66,7 @@ def main() -> None:
                             "name": "Submit",
                             "props": [],
                             "depth": 0,
-                            "raw": "- button \"Submit\"",
+                            "raw": '- button "Submit"',
                             "occurrenceIndex": 0,
                         },
                     },
@@ -89,7 +86,7 @@ def main() -> None:
                             "name": "Example",
                             "props": [],
                             "depth": 0,
-                            "raw": "- link \"Example\"",
+                            "raw": '- link "Example"',
                             "occurrenceIndex": 0,
                         },
                     },
@@ -200,17 +197,13 @@ def main() -> None:
                     "origins": [
                         {
                             "origin": "https://example.com",
-                            "localStorage": [
-                                {"name": "pref", "value": "dark_mode"}
-                            ],
+                            "localStorage": [{"name": "pref", "value": "dark_mode"}],
                         }
                     ],
                 },
             )
 
         elif method == "browser.getCookies":
-            params = request.get("params", {})
-            urls = params.get("urls", [])
             write_response(
                 req_id,
                 result={
@@ -240,7 +233,9 @@ def main() -> None:
                 error={
                     "code": -32000,
                     "message": "Something went wrong",
-                    "data": {"traceback": "Traceback (most recent call last):\n  File \"mock.py\", line 1, in <module>\nRuntimeError: test error"},
+                    "data": {
+                        "traceback": 'Traceback (most recent call last):\n  File "mock.py", line 1, in <module>\nRuntimeError: test error'
+                    },
                 },
             )
 
@@ -254,11 +249,6 @@ def main() -> None:
                 },
             )
 
-        elif method == "browser.timeout":
-            # Simulate a timeout by not responding
-            # (the caller's transport timeout will fire)
-            pass
-
         else:
             write_response(
                 req_id,

package/node_modules/pi-lean-portal/__tests__/plugin-registry.test.ts

@@ -358,93 +358,3 @@ describe("PluginRegistry.clear", () => {
 		expect(registry.available()).toEqual([]);
 	});
 });
-
-// ─── MockPlugin call tracking ────────────────────────────────────
-
-describe("MockPlugin call tracking", () => {
-	it("records navigate calls with correct args", async () => {
-		const plugin = new MockPlugin();
-		await plugin.navigate("https://example.com", "task-1", 30000);
-		await plugin.navigate("https://other.com", "task-2", 5000);
-		const calls = plugin.calls.get("navigate")!;
-		expect(calls).toHaveLength(2);
-		expect(calls[0]).toEqual(["https://example.com", "task-1", 30000, undefined]);
-		expect(calls[1]).toEqual(["https://other.com", "task-2", 5000, undefined]);
-	});
-
-	it("records click calls", async () => {
-		const plugin = new MockPlugin();
-		await plugin.click("task-1", "@e5");
-		expect(plugin.calls.get("click")).toEqual([["task-1", "@e5"]]);
-	});
-
-	it("records type calls", async () => {
-		const plugin = new MockPlugin();
-		await plugin.type("task-1", "@e3", "hello");
-		expect(plugin.calls.get("type")).toEqual([["task-1", "@e3", "hello"]]);
-	});
-
-	it("records cleanup calls", async () => {
-		const plugin = new MockPlugin();
-		await plugin.cleanup("task-1");
-		expect(plugin.calls.get("cleanup")).toEqual([["task-1"]]);
-	});
-
-	it("throws when shouldThrow is set", async () => {
-		const plugin = new MockPlugin();
-		plugin.shouldThrow.add("navigate");
-		await expect(
-			plugin.navigate("https://example.com", "task-1", 30000),
-		).rejects.toThrow("navigate failed");
-	});
-});
-
-// ─── MockPlugin configurable returns ─────────────────────────────
-
-describe("MockPlugin configurable returns", () => {
-	it("returns custom navigate result", async () => {
-		const plugin = new MockPlugin();
-		plugin.navResult = {
-			success: false,
-			error: "page not found",
-			url: "https://example.com/404",
-			title: "",
-			snapshot: "",
-			elementCount: 0,
-		};
-		const result = await plugin.navigate(
-			"https://example.com/404",
-			"task-1",
-			30000,
-		);
-		expect(result.success).toBe(false);
-		expect(result.error).toBe("page not found");
-	});
-
-	it("returns bot detection signal", async () => {
-		const plugin = new MockPlugin();
-		plugin.navResult = { botDetected: true };
-		const result = await plugin.navigate(
-			"https://protected.com",
-			"task-1",
-			30000,
-		);
-		expect(result.botDetected).toBe(true);
-	});
-
-	it("returns custom evaluate result", async () => {
-		const plugin = new MockPlugin();
-		plugin.evalResult = { result: { key: "value" } };
-		const result = await plugin.evaluate("task-1", "document.title");
-		expect(result.result).toEqual({ key: "value" });
-	});
-
-	it("returns custom screenshot data URI", async () => {
-		const plugin = new MockPlugin();
-		plugin.screenshotResult = {
-			dataUri: "data:image/png;base64,customdata",
-		};
-		const result = await plugin.screenshot("task-1");
-		expect(result.dataUri).toBe("data:image/png;base64,customdata");
-	});
-});