pi-crew 0.9.51 → 0.9.53

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (611) hide show
  1. package/CHANGELOG.md +53 -0
  2. package/README.md +216 -20
  3. package/dist/build-meta.json +2090 -1638
  4. package/dist/index.mjs +18057 -17119
  5. package/docs/actions-reference.md +431 -1
  6. package/index.ts +39 -10
  7. package/package.json +19 -9
  8. package/schema.json +41 -0
  9. package/scripts/check-bundle-size.mjs +38 -0
  10. package/scripts/test-runner.mjs +11 -1
  11. package/dist/index.mjs.map +0 -7
  12. package/docs/FEATURE_INTAKE.md +0 -126
  13. package/docs/HARNESS.md +0 -87
  14. package/docs/HARNESS_BACKLOG.md +0 -89
  15. package/docs/PROJECT_REVIEW.md +0 -270
  16. package/docs/PROJECT_REVIEW_FIXES.md +0 -342
  17. package/docs/PROJECT_REVIEW_ROUND4.md +0 -156
  18. package/docs/PROJECT_REVIEW_ROUND5.md +0 -86
  19. package/docs/REVIEW-FINDINGS-2026-06 +0 -357
  20. package/docs/REVIEW-FINDINGS-2026-07-CORE.md +0 -139
  21. package/docs/REVIEW-FINDINGS-2026-07.md +0 -125
  22. package/docs/TEST_MATRIX.md +0 -51
  23. package/docs/archive/README.md +0 -91
  24. package/docs/archive/followup-review-round3-2026-05-12.md +0 -342
  25. package/docs/archive/followup-review-round4-2026-05-13.md +0 -107
  26. package/docs/archive/pi-crew-bugs.md +0 -961
  27. package/docs/archive/pi-crew-test-final.md +0 -120
  28. package/docs/archive/pi-crew-test-results.md +0 -260
  29. package/docs/archive/pi-crew-test-round2.md +0 -136
  30. package/docs/archive/pi-crew-test-round4.md +0 -100
  31. package/docs/archive/pi-crew-test-round5.md +0 -70
  32. package/docs/archive/pi-crew-test-round6.md +0 -110
  33. package/docs/archive/pi-crew-v0.5.10-audit-fix-plan.md +0 -60
  34. package/docs/archive/pi-crew-v0.5.11-audit-fix-plan.md +0 -92
  35. package/docs/archive/pi-crew-v0.5.12-audit-fix-plan.md +0 -76
  36. package/docs/archive/pi-crew-v0.5.13-audit-fix-plan.md +0 -75
  37. package/docs/archive/pi-crew-v0.5.14-audit-fix-plan.md +0 -75
  38. package/docs/archive/pi-crew-v0.5.16-audit-fix-plan.md +0 -35
  39. package/docs/archive/pi-crew-v0.5.17-audit-fix-plan.md +0 -80
  40. package/docs/archive/pi-crew-v0.5.5-audit-fix-plan.md +0 -133
  41. package/docs/archive/pi-crew-v0.5.9-audit-fix-plan.md +0 -88
  42. package/docs/archive/pi-mono-opportunities.md +0 -969
  43. package/docs/archive/pi-mono-review.md +0 -291
  44. package/docs/archive/pi-subagent4-comparison.md +0 -261
  45. package/docs/archive/pi-subagents3-deep-analysis.md +0 -508
  46. package/docs/bugs/bug-021-notification-badge-counter-misleading.md +0 -293
  47. package/docs/bugs/bug-023-chain-windows-path-resolution.md +0 -106
  48. package/docs/bugs/bug-quota-display-truncation.md +0 -223
  49. package/docs/bugs/cross-session-notification-leakage.md +0 -82
  50. package/docs/code-review-2026-05-11.md +0 -592
  51. package/docs/coding-agent-optimization.md +0 -268
  52. package/docs/comparison-pi-subagents-vs-pi-crew.md +0 -303
  53. package/docs/decisions/0001-durable-state.md +0 -41
  54. package/docs/decisions/0002-child-process-for-async.md +0 -42
  55. package/docs/decisions/0003-depth-guard.md +0 -36
  56. package/docs/decisions/0004-execfile-over-exec.md +0 -34
  57. package/docs/decisions/0005-no-parameter-properties.md +0 -49
  58. package/docs/decisions/0006-publish-bundled-esm.md +0 -63
  59. package/docs/decisions/0007-active-run-binary-index.md +0 -54
  60. package/docs/decisions/0008-child-pi-warm-pool.md +0 -61
  61. package/docs/decisions/2026-07-21-broker-phase4-default-on.md +0 -77
  62. package/docs/decisions/2026-07-21-broker-windows-perms.md +0 -91
  63. package/docs/decisions/2026-07-22-broker-phase4-gated-on.md +0 -99
  64. package/docs/decisions/2026-07-24-oidc-trusted-publishing.md +0 -112
  65. package/docs/decisions/2026-07-26-c6-mascot-visibility-not-wired.md +0 -84
  66. package/docs/decisions/README.md +0 -26
  67. package/docs/deep-review-report.md +0 -384
  68. package/docs/distillation/cybersecurity-patterns.md +0 -294
  69. package/docs/feature-analysis-subagent4.md +0 -305
  70. package/docs/fix-plan-disabletools-exit-null.md +0 -219
  71. package/docs/fixes/BATCH_A_H1_H2.md +0 -86
  72. package/docs/fixes/bug-006-foreground-cancel-concurrent.md +0 -78
  73. package/docs/fixes/bug-007-async-notifier-stale-ctx.md +0 -112
  74. package/docs/fixes/bug-008-child-process-silent-timeout.md +0 -100
  75. package/docs/fixes/bug-009-executor-yield-limit-needs-attention.md +0 -75
  76. package/docs/fixes/bug-010-child-process-api-key-filtered.md +0 -109
  77. package/docs/fixes/bug-011-spawn-pi-enoent.md +0 -92
  78. package/docs/fixes/bug-012-essential-env-stripped.md +0 -89
  79. package/docs/fixes/bug-013-background-runner-death.md +0 -84
  80. package/docs/fixes/bug-014-infinite-retry-loop-needs-attention.md +0 -82
  81. package/docs/fixes/bug-015-background-runner-sigterm.md +0 -65
  82. package/docs/fixes/bug-017-background-runner-session-shutdown.md +0 -66
  83. package/docs/fixes/bug-017-background-runner-sigkill-double-fork.md +0 -28
  84. package/docs/fixes/bug-018-child-pi-worker-stdin-hang.md +0 -61
  85. package/docs/fixes/bug-019-phantom-runs-temp-workspace.md +0 -52
  86. package/docs/fixes/bug-020-infinite-retry-loop-needs-attention.md +0 -47
  87. package/docs/fixes/v0.9.10/locks-fix-verify.md +0 -3
  88. package/docs/fixes/v0.9.10/smoke-test.md +0 -12
  89. package/docs/followup-plan-2026-05-12.md +0 -463
  90. package/docs/followup-review-2026-05-12.md +0 -297
  91. package/docs/goals.md +0 -59
  92. package/docs/implementation-plan-top3.md +0 -333
  93. package/docs/issue-29-analysis.md +0 -189
  94. package/docs/live-mailbox-runtime.md +0 -36
  95. package/docs/migration/atomic-write-v2-migration.md +0 -299
  96. package/docs/next-upgrade-roadmap.md +0 -808
  97. package/docs/oh-my-pi-research.md +0 -509
  98. package/docs/optimization-plan-2026-07.md +0 -366
  99. package/docs/optimization-plan.md +0 -644
  100. package/docs/patterns/command-agent-skill.md +0 -71
  101. package/docs/perf/baseline-2026-05.md +0 -113
  102. package/docs/perf/final-report-2026-05.md +0 -206
  103. package/docs/perf/optimization-plan-2026-07-verified.md +0 -396
  104. package/docs/perf/performance-audit-report-2026-07.md +0 -948
  105. package/docs/perf/performance-review-2026-07.md +0 -287
  106. package/docs/perf/sprint-1-report.md +0 -71
  107. package/docs/perf/sprint-2-report.md +0 -81
  108. package/docs/perf/sprint-2.5-report.md +0 -53
  109. package/docs/perf/sprint-3-report.md +0 -36
  110. package/docs/perf/sprint-4-report.md +0 -47
  111. package/docs/perf/sprint-5-report.md +0 -51
  112. package/docs/perf/sprint-6-report.md +0 -94
  113. package/docs/perf/sprint-7-report.md +0 -74
  114. package/docs/perf/upgrade-plan-2026-05.md +0 -147
  115. package/docs/performance-optimization-execution-plan.md +0 -520
  116. package/docs/phase4-triage.md +0 -58
  117. package/docs/pi-crew-investigation-report.md +0 -411
  118. package/docs/product/README.md +0 -31
  119. package/docs/product/platform.md +0 -27
  120. package/docs/product/runtime-safety.md +0 -37
  121. package/docs/product/team-run.md +0 -39
  122. package/docs/product/team-tool.md +0 -37
  123. package/docs/runtime-analysis-child-vs-live.md +0 -171
  124. package/docs/runtime-migration-in-process-analysis.md +0 -250
  125. package/docs/skills/REFERENCE.md +0 -138
  126. package/docs/stories/README.md +0 -32
  127. package/docs/stories/US-DEPS-major-upgrade.md +0 -62
  128. package/docs/stories/backlog.md +0 -36
  129. package/docs/superpowers/plans/2026-06-09-fallow-patterns-adoption.md +0 -1270
  130. package/docs/templates/decision.md +0 -27
  131. package/docs/templates/story.md +0 -44
  132. package/docs/templates/validation-report.md +0 -32
  133. package/docs/ui-optimization-plan.md +0 -447
  134. package/src/adapters/claude-adapter.ts +0 -23
  135. package/src/adapters/codex-adapter.ts +0 -21
  136. package/src/adapters/cursor-adapter.ts +0 -17
  137. package/src/adapters/export-util.ts +0 -143
  138. package/src/adapters/index.ts +0 -15
  139. package/src/adapters/registry.ts +0 -18
  140. package/src/adapters/types.ts +0 -23
  141. package/src/agents/agent-config.ts +0 -194
  142. package/src/agents/agent-search.ts +0 -98
  143. package/src/agents/agent-serializer.ts +0 -38
  144. package/src/agents/discover-agents.ts +0 -623
  145. package/src/benchmark/benchmark-runner.ts +0 -313
  146. package/src/benchmark/feedback-loop.ts +0 -73
  147. package/src/config/config.ts +0 -1269
  148. package/src/config/defaults.ts +0 -193
  149. package/src/config/drift-detector.ts +0 -290
  150. package/src/config/markers.ts +0 -330
  151. package/src/config/resilient-parser.ts +0 -117
  152. package/src/config/role-tools.ts +0 -118
  153. package/src/config/suggestions.ts +0 -75
  154. package/src/config/types.ts +0 -278
  155. package/src/errors.ts +0 -194
  156. package/src/extension/action-suggestions.ts +0 -117
  157. package/src/extension/async-notifier.ts +0 -179
  158. package/src/extension/autonomous-policy.ts +0 -209
  159. package/src/extension/command-completions.ts +0 -120
  160. package/src/extension/context-status-injection.ts +0 -185
  161. package/src/extension/crew-autocomplete.ts +0 -131
  162. package/src/extension/crew-cleanup.ts +0 -168
  163. package/src/extension/crew-input-router.ts +0 -93
  164. package/src/extension/crew-shortcuts.ts +0 -87
  165. package/src/extension/crew-vibes/cat-frames.ts +0 -18
  166. package/src/extension/crew-vibes/config.ts +0 -195
  167. package/src/extension/crew-vibes/figures.ts +0 -101
  168. package/src/extension/crew-vibes/font-detect.ts +0 -71
  169. package/src/extension/crew-vibes/footer.ts +0 -292
  170. package/src/extension/crew-vibes/index.ts +0 -432
  171. package/src/extension/crew-vibes/provider-usage.ts +0 -396
  172. package/src/extension/crew-vibes/render.ts +0 -206
  173. package/src/extension/crew-vibes/speed.ts +0 -286
  174. package/src/extension/cross-extension-rpc.ts +0 -350
  175. package/src/extension/help.ts +0 -62
  176. package/src/extension/import-index.ts +0 -74
  177. package/src/extension/knowledge-injection.ts +0 -402
  178. package/src/extension/management.ts +0 -571
  179. package/src/extension/message-renderers.ts +0 -108
  180. package/src/extension/notification-router.ts +0 -152
  181. package/src/extension/notification-sink.ts +0 -54
  182. package/src/extension/pi-api.ts +0 -56
  183. package/src/extension/plan-orchestrate.ts +0 -302
  184. package/src/extension/project-init.ts +0 -170
  185. package/src/extension/register.ts +0 -113
  186. package/src/extension/registration/artifact-cleanup.ts +0 -20
  187. package/src/extension/registration/command-registration.ts +0 -58
  188. package/src/extension/registration/command-utils.ts +0 -58
  189. package/src/extension/registration/commands.ts +0 -1228
  190. package/src/extension/registration/compaction-guard.ts +0 -333
  191. package/src/extension/registration/context-builder.ts +0 -135
  192. package/src/extension/registration/crash-recovery-cache.ts +0 -54
  193. package/src/extension/registration/foreground-run-controller.ts +0 -238
  194. package/src/extension/registration/hook-registration.ts +0 -119
  195. package/src/extension/registration/lazy-configurers.ts +0 -124
  196. package/src/extension/registration/lifecycle-handlers.ts +0 -923
  197. package/src/extension/registration/lifecycle.ts +0 -259
  198. package/src/extension/registration/observability.ts +0 -322
  199. package/src/extension/registration/registration-types.ts +0 -158
  200. package/src/extension/registration/runtime-cleanup.ts +0 -230
  201. package/src/extension/registration/subagent-helpers.ts +0 -125
  202. package/src/extension/registration/subagent-manager-setup.ts +0 -330
  203. package/src/extension/registration/subagent-tools.ts +0 -456
  204. package/src/extension/registration/team-tool.ts +0 -220
  205. package/src/extension/registration/tool-registration.ts +0 -50
  206. package/src/extension/registration/ui.ts +0 -172
  207. package/src/extension/registration/viewers.ts +0 -121
  208. package/src/extension/registration/wire-cross-extension.ts +0 -37
  209. package/src/extension/result-watcher.ts +0 -139
  210. package/src/extension/rpc-hmac.ts +0 -256
  211. package/src/extension/run-bundle-schema.ts +0 -104
  212. package/src/extension/run-export.ts +0 -97
  213. package/src/extension/run-import.ts +0 -168
  214. package/src/extension/run-index.ts +0 -131
  215. package/src/extension/run-maintenance.ts +0 -190
  216. package/src/extension/session-summary.ts +0 -18
  217. package/src/extension/team-manager-command.ts +0 -153
  218. package/src/extension/team-onboard.ts +0 -177
  219. package/src/extension/team-recommendation.ts +0 -288
  220. package/src/extension/team-tool/anchor.ts +0 -172
  221. package/src/extension/team-tool/api.ts +0 -1244
  222. package/src/extension/team-tool/auto-summarize.ts +0 -142
  223. package/src/extension/team-tool/cache-control.ts +0 -19
  224. package/src/extension/team-tool/cancel.ts +0 -337
  225. package/src/extension/team-tool/chain-dispatch.ts +0 -95
  226. package/src/extension/team-tool/chain-executor.ts +0 -379
  227. package/src/extension/team-tool/config-patch.ts +0 -50
  228. package/src/extension/team-tool/context.ts +0 -149
  229. package/src/extension/team-tool/destructive-gate.ts +0 -52
  230. package/src/extension/team-tool/doctor.ts +0 -431
  231. package/src/extension/team-tool/explain.ts +0 -282
  232. package/src/extension/team-tool/failure-patterns.ts +0 -118
  233. package/src/extension/team-tool/goal-wrap.ts +0 -330
  234. package/src/extension/team-tool/goal.ts +0 -556
  235. package/src/extension/team-tool/handle-schedule.ts +0 -332
  236. package/src/extension/team-tool/handle-settings.ts +0 -520
  237. package/src/extension/team-tool/health-monitor.ts +0 -481
  238. package/src/extension/team-tool/inspect.ts +0 -88
  239. package/src/extension/team-tool/intent-policy.ts +0 -45
  240. package/src/extension/team-tool/lifecycle-actions.ts +0 -615
  241. package/src/extension/team-tool/orchestrate.ts +0 -98
  242. package/src/extension/team-tool/parallel-dispatch.ts +0 -183
  243. package/src/extension/team-tool/plan.ts +0 -50
  244. package/src/extension/team-tool/respond.ts +0 -150
  245. package/src/extension/team-tool/run-not-found.ts +0 -49
  246. package/src/extension/team-tool/run.ts +0 -1035
  247. package/src/extension/team-tool/status.ts +0 -260
  248. package/src/extension/team-tool/workflow-manage.ts +0 -261
  249. package/src/extension/team-tool-types.ts +0 -26
  250. package/src/extension/team-tool.ts +0 -1116
  251. package/src/extension/tool-result.ts +0 -16
  252. package/src/extension/validate-resources.ts +0 -108
  253. package/src/hooks/registry.ts +0 -200
  254. package/src/hooks/types.ts +0 -69
  255. package/src/i18n.ts +0 -212
  256. package/src/observability/correlation.ts +0 -50
  257. package/src/observability/event-bus.ts +0 -86
  258. package/src/observability/event-to-metric.ts +0 -170
  259. package/src/observability/exporters/adapter.ts +0 -27
  260. package/src/observability/exporters/otlp-exporter.ts +0 -356
  261. package/src/observability/exporters/prometheus-exporter.ts +0 -54
  262. package/src/observability/metric-registry.ts +0 -100
  263. package/src/observability/metric-retention.ts +0 -64
  264. package/src/observability/metric-sink.ts +0 -99
  265. package/src/observability/metrics-primitives.ts +0 -219
  266. package/src/plugins/plugin-define.ts +0 -6
  267. package/src/plugins/plugin-registry.ts +0 -32
  268. package/src/plugins/plugins/index.ts +0 -3
  269. package/src/plugins/plugins/nextjs.ts +0 -19
  270. package/src/plugins/plugins/vite.ts +0 -10
  271. package/src/plugins/plugins/vitest.ts +0 -9
  272. package/src/prompt/prompt-runtime.ts +0 -380
  273. package/src/runtime/adaptive-plan.ts +0 -563
  274. package/src/runtime/agent-control.ts +0 -215
  275. package/src/runtime/agent-memory.ts +0 -81
  276. package/src/runtime/agent-observability.ts +0 -122
  277. package/src/runtime/anchor-manager.ts +0 -475
  278. package/src/runtime/async-marker.ts +0 -32
  279. package/src/runtime/async-runner.ts +0 -381
  280. package/src/runtime/attention-events.ts +0 -28
  281. package/src/runtime/auto-summarize.ts +0 -344
  282. package/src/runtime/background-runner.ts +0 -837
  283. package/src/runtime/batch-barrier.ts +0 -147
  284. package/src/runtime/broker-issuer.ts +0 -37
  285. package/src/runtime/cancellation-token.ts +0 -99
  286. package/src/runtime/cancellation.ts +0 -99
  287. package/src/runtime/capability-inventory.ts +0 -137
  288. package/src/runtime/chain-parser.ts +0 -237
  289. package/src/runtime/chain-runner.ts +0 -606
  290. package/src/runtime/checkpoint.ts +0 -291
  291. package/src/runtime/child-pi-constants.ts +0 -42
  292. package/src/runtime/child-pi-kill.ts +0 -180
  293. package/src/runtime/child-pi-pool.ts +0 -68
  294. package/src/runtime/child-pi-spawn.ts +0 -287
  295. package/src/runtime/child-pi-steering.ts +0 -128
  296. package/src/runtime/child-pi-streams.ts +0 -296
  297. package/src/runtime/child-pi-transcript.ts +0 -169
  298. package/src/runtime/child-pi.ts +0 -1105
  299. package/src/runtime/coalesce-tasks.ts +0 -268
  300. package/src/runtime/code-summary.ts +0 -292
  301. package/src/runtime/command-trace.ts +0 -105
  302. package/src/runtime/compact-pipeline.ts +0 -56
  303. package/src/runtime/compact-stages/ansi-strip-stage.ts +0 -25
  304. package/src/runtime/compact-stages/blank-collapse-stage.ts +0 -31
  305. package/src/runtime/compact-stages/deduplicate-stage.ts +0 -34
  306. package/src/runtime/compact-stages/head-snap-stage.ts +0 -57
  307. package/src/runtime/compact-stages/index.ts +0 -23
  308. package/src/runtime/compact-stages/tail-capture-stage.ts +0 -77
  309. package/src/runtime/compact-stages/truncation-stage.ts +0 -74
  310. package/src/runtime/compaction-summary.ts +0 -278
  311. package/src/runtime/completion-guard.ts +0 -207
  312. package/src/runtime/concurrency.ts +0 -58
  313. package/src/runtime/crash-classification.ts +0 -229
  314. package/src/runtime/crash-recovery.ts +0 -577
  315. package/src/runtime/crew-agent-records.ts +0 -593
  316. package/src/runtime/crew-agent-runtime.ts +0 -62
  317. package/src/runtime/crew-broker-child.ts +0 -88
  318. package/src/runtime/crew-broker-client.ts +0 -673
  319. package/src/runtime/crew-broker-tokens.ts +0 -84
  320. package/src/runtime/crew-broker.ts +0 -1276
  321. package/src/runtime/crew-hooks.ts +0 -227
  322. package/src/runtime/cross-extension-rpc.ts +0 -143
  323. package/src/runtime/custom-tools/irc-tool.ts +0 -282
  324. package/src/runtime/custom-tools/submit-result-tool.ts +0 -102
  325. package/src/runtime/deadletter.ts +0 -47
  326. package/src/runtime/delivery-coordinator.ts +0 -211
  327. package/src/runtime/delta-conflict.ts +0 -348
  328. package/src/runtime/deterministic-ast.ts +0 -161
  329. package/src/runtime/diagnostic-export.ts +0 -171
  330. package/src/runtime/direct-run.ts +0 -45
  331. package/src/runtime/dwf-state-store.ts +0 -102
  332. package/src/runtime/dynamic-workflow-context.ts +0 -1016
  333. package/src/runtime/dynamic-workflow-runner.ts +0 -310
  334. package/src/runtime/effectiveness.ts +0 -90
  335. package/src/runtime/errors/crew-errors.ts +0 -162
  336. package/src/runtime/event-stream-bridge.ts +0 -98
  337. package/src/runtime/foreground-control.ts +0 -193
  338. package/src/runtime/foreground-watchdog.ts +0 -132
  339. package/src/runtime/global-worker-cap.ts +0 -96
  340. package/src/runtime/goal-achievement.ts +0 -148
  341. package/src/runtime/goal-evaluator.ts +0 -361
  342. package/src/runtime/goal-loop-runner.ts +0 -828
  343. package/src/runtime/goal-state-store.ts +0 -219
  344. package/src/runtime/green-contract.ts +0 -55
  345. package/src/runtime/group-join.ts +0 -267
  346. package/src/runtime/handoff-manager.ts +0 -598
  347. package/src/runtime/heartbeat-gradient.ts +0 -36
  348. package/src/runtime/heartbeat-watcher.ts +0 -239
  349. package/src/runtime/hidden-handoff.ts +0 -407
  350. package/src/runtime/important-line-classifier.ts +0 -140
  351. package/src/runtime/intercom-bridge.ts +0 -187
  352. package/src/runtime/iteration-hooks.ts +0 -305
  353. package/src/runtime/live-agent-control.ts +0 -136
  354. package/src/runtime/live-agent-manager.ts +0 -704
  355. package/src/runtime/live-control-realtime.ts +0 -56
  356. package/src/runtime/live-extension-bridge.ts +0 -148
  357. package/src/runtime/live-irc.ts +0 -97
  358. package/src/runtime/live-session-health.ts +0 -108
  359. package/src/runtime/live-session-runtime.ts +0 -1139
  360. package/src/runtime/loop-gates.ts +0 -128
  361. package/src/runtime/manifest-cache.ts +0 -375
  362. package/src/runtime/mcp-proxy.ts +0 -105
  363. package/src/runtime/metric-parser.ts +0 -36
  364. package/src/runtime/model-fallback.ts +0 -409
  365. package/src/runtime/model-resolver.ts +0 -126
  366. package/src/runtime/model-scope.ts +0 -158
  367. package/src/runtime/orphan-worker-registry.ts +0 -465
  368. package/src/runtime/output-validator.ts +0 -202
  369. package/src/runtime/overflow-recovery.ts +0 -206
  370. package/src/runtime/parallel-research.ts +0 -68
  371. package/src/runtime/parallel-utils.ts +0 -160
  372. package/src/runtime/parent-guard.ts +0 -134
  373. package/src/runtime/path-overlap.ts +0 -150
  374. package/src/runtime/peer-dep.ts +0 -292
  375. package/src/runtime/per-write-validator.ts +0 -181
  376. package/src/runtime/phase-progress.ts +0 -217
  377. package/src/runtime/phase-tracker.ts +0 -385
  378. package/src/runtime/pi-args.ts +0 -655
  379. package/src/runtime/pi-json-output.ts +0 -170
  380. package/src/runtime/pi-spawn.ts +0 -273
  381. package/src/runtime/pipeline-runner.ts +0 -523
  382. package/src/runtime/plan-templates.ts +0 -201
  383. package/src/runtime/policy-engine.ts +0 -115
  384. package/src/runtime/post-checks.ts +0 -142
  385. package/src/runtime/post-exit-stdio-guard.ts +0 -104
  386. package/src/runtime/process-lifecycle.ts +0 -491
  387. package/src/runtime/process-status.ts +0 -154
  388. package/src/runtime/progress-event-coalescer.ts +0 -44
  389. package/src/runtime/progress-tracker.ts +0 -124
  390. package/src/runtime/prose-compressor.ts +0 -162
  391. package/src/runtime/recovery-recipes.ts +0 -203
  392. package/src/runtime/replace.ts +0 -570
  393. package/src/runtime/resilient-edit.ts +0 -153
  394. package/src/runtime/result-extractor.ts +0 -213
  395. package/src/runtime/retry-executor.ts +0 -100
  396. package/src/runtime/retry-runner.ts +0 -336
  397. package/src/runtime/role-permission.ts +0 -59
  398. package/src/runtime/run-coalesced-task-group.ts +0 -308
  399. package/src/runtime/run-drift.ts +0 -219
  400. package/src/runtime/run-tracker.ts +0 -116
  401. package/src/runtime/runtime-policy.ts +0 -29
  402. package/src/runtime/runtime-resolver.ts +0 -172
  403. package/src/runtime/runtime-warmup.ts +0 -160
  404. package/src/runtime/scheduler.ts +0 -353
  405. package/src/runtime/semaphore.ts +0 -141
  406. package/src/runtime/sensitive-paths.ts +0 -93
  407. package/src/runtime/session-resources.ts +0 -25
  408. package/src/runtime/session-snapshot.ts +0 -59
  409. package/src/runtime/session-usage.ts +0 -79
  410. package/src/runtime/settings-store.ts +0 -155
  411. package/src/runtime/sidechain-output.ts +0 -35
  412. package/src/runtime/single-agent-compose.ts +0 -84
  413. package/src/runtime/skill-effectiveness.ts +0 -524
  414. package/src/runtime/skill-instructions.ts +0 -391
  415. package/src/runtime/stale-reconciler.ts +0 -680
  416. package/src/runtime/stream-preview.ts +0 -184
  417. package/src/runtime/streaming-output.ts +0 -50
  418. package/src/runtime/subagent-manager.ts +0 -561
  419. package/src/runtime/subprocess-tool-registry.ts +0 -70
  420. package/src/runtime/supervisor-contact.ts +0 -64
  421. package/src/runtime/task-display.ts +0 -52
  422. package/src/runtime/task-graph-scheduler.ts +0 -227
  423. package/src/runtime/task-graph.ts +0 -290
  424. package/src/runtime/task-health.ts +0 -83
  425. package/src/runtime/task-id.ts +0 -161
  426. package/src/runtime/task-output-context.ts +0 -602
  427. package/src/runtime/task-packet.ts +0 -268
  428. package/src/runtime/task-quality.ts +0 -199
  429. package/src/runtime/task-runner/capabilities.ts +0 -78
  430. package/src/runtime/task-runner/context-retrieval.ts +0 -163
  431. package/src/runtime/task-runner/live-executor.ts +0 -227
  432. package/src/runtime/task-runner/output-splitter.ts +0 -152
  433. package/src/runtime/task-runner/progress.ts +0 -157
  434. package/src/runtime/task-runner/prompt-builder.ts +0 -278
  435. package/src/runtime/task-runner/prompt-pipeline.ts +0 -88
  436. package/src/runtime/task-runner/result-utils.ts +0 -16
  437. package/src/runtime/task-runner/retrieval-orchestrator.ts +0 -310
  438. package/src/runtime/task-runner/run-projection.ts +0 -125
  439. package/src/runtime/task-runner/state-helpers.ts +0 -176
  440. package/src/runtime/task-runner/tail-read.ts +0 -34
  441. package/src/runtime/task-runner.ts +0 -1420
  442. package/src/runtime/team-runner-artifacts.ts +0 -13
  443. package/src/runtime/team-runner.ts +0 -1993
  444. package/src/runtime/tool-output-pruner.ts +0 -333
  445. package/src/runtime/tool-progress.ts +0 -278
  446. package/src/runtime/usage-tracker.ts +0 -73
  447. package/src/runtime/verification-gates.ts +0 -571
  448. package/src/runtime/verification-integrity.ts +0 -105
  449. package/src/runtime/verification-worktree.ts +0 -186
  450. package/src/runtime/worker-heartbeat.ts +0 -25
  451. package/src/runtime/worker-startup.ts +0 -83
  452. package/src/runtime/workflow-state.ts +0 -195
  453. package/src/runtime/workspace-lock.ts +0 -443
  454. package/src/runtime/workspace-tree.ts +0 -312
  455. package/src/runtime/yield-handler.ts +0 -224
  456. package/src/runtime/zombie-scanner.ts +0 -298
  457. package/src/schema/config-schema.ts +0 -327
  458. package/src/schema/team-tool-schema.ts +0 -415
  459. package/src/schema/validation-types.ts +0 -159
  460. package/src/skills/discover-skills.ts +0 -197
  461. package/src/skills/skill-templates.ts +0 -456
  462. package/src/skills/validate.ts +0 -285
  463. package/src/state/active-run-registry.ts +0 -439
  464. package/src/state/artifact-store.ts +0 -176
  465. package/src/state/atomic-write.ts +0 -903
  466. package/src/state/blob-store.ts +0 -308
  467. package/src/state/contracts.ts +0 -158
  468. package/src/state/crew-init.ts +0 -269
  469. package/src/state/decision-ledger.ts +0 -345
  470. package/src/state/event-log-rotation.ts +0 -342
  471. package/src/state/event-log.ts +0 -1311
  472. package/src/state/event-reconstructor.ts +0 -229
  473. package/src/state/gitignore-manager.ts +0 -46
  474. package/src/state/health-store.ts +0 -79
  475. package/src/state/hook-instinct-bridge.ts +0 -94
  476. package/src/state/hook-integrations.ts +0 -51
  477. package/src/state/instinct-store.ts +0 -275
  478. package/src/state/jsonl-writer.ts +0 -107
  479. package/src/state/locks.ts +0 -562
  480. package/src/state/mailbox.ts +0 -916
  481. package/src/state/observation-store.ts +0 -176
  482. package/src/state/run-cache.ts +0 -193
  483. package/src/state/run-graph.ts +0 -183
  484. package/src/state/run-metrics.ts +0 -165
  485. package/src/state/schedule.ts +0 -166
  486. package/src/state/session-state-map.ts +0 -51
  487. package/src/state/state-store.ts +0 -958
  488. package/src/state/task-claims.ts +0 -61
  489. package/src/state/tiered-eval.ts +0 -480
  490. package/src/state/types-eval.ts +0 -58
  491. package/src/state/types.ts +0 -440
  492. package/src/state/usage.ts +0 -138
  493. package/src/state/worker-atomic-writer.ts +0 -194
  494. package/src/subagents/async-entry.ts +0 -1
  495. package/src/subagents/index.ts +0 -3
  496. package/src/subagents/live/control.ts +0 -1
  497. package/src/subagents/live/manager.ts +0 -1
  498. package/src/subagents/live/realtime.ts +0 -1
  499. package/src/subagents/live/session-runtime.ts +0 -1
  500. package/src/subagents/manager.ts +0 -1
  501. package/src/subagents/spawn.ts +0 -1
  502. package/src/teams/discover-teams.ts +0 -187
  503. package/src/teams/team-config.ts +0 -27
  504. package/src/teams/team-serializer.ts +0 -38
  505. package/src/tools/safe-bash-extension.ts +0 -54
  506. package/src/tools/safe-bash.ts +0 -505
  507. package/src/types/diff.d.ts +0 -18
  508. package/src/types/new-api-types.ts +0 -35
  509. package/src/ui/agent-management-overlay.ts +0 -160
  510. package/src/ui/card-colors.ts +0 -139
  511. package/src/ui/crew-footer.ts +0 -102
  512. package/src/ui/crew-select-list.ts +0 -111
  513. package/src/ui/dashboard-panes/agents-pane.ts +0 -164
  514. package/src/ui/dashboard-panes/cancellation-pane.ts +0 -66
  515. package/src/ui/dashboard-panes/capability-pane.ts +0 -77
  516. package/src/ui/dashboard-panes/health-pane.ts +0 -31
  517. package/src/ui/dashboard-panes/mailbox-pane.ts +0 -35
  518. package/src/ui/dashboard-panes/metrics-pane.ts +0 -37
  519. package/src/ui/dashboard-panes/progress-pane.ts +0 -38
  520. package/src/ui/dashboard-panes/transcript-pane.ts +0 -10
  521. package/src/ui/deploy-bundled-themes.ts +0 -71
  522. package/src/ui/dwf-phase-display.ts +0 -151
  523. package/src/ui/dynamic-border.ts +0 -35
  524. package/src/ui/heartbeat-aggregator.ts +0 -74
  525. package/src/ui/key-utils.ts +0 -42
  526. package/src/ui/keybinding-map.ts +0 -248
  527. package/src/ui/layout-primitives.ts +0 -106
  528. package/src/ui/live-conversation-overlay.ts +0 -183
  529. package/src/ui/live-duration.ts +0 -55
  530. package/src/ui/live-run-sidebar.ts +0 -293
  531. package/src/ui/loaders.ts +0 -6
  532. package/src/ui/mascot.ts +0 -449
  533. package/src/ui/overlays/agent-picker-overlay.ts +0 -65
  534. package/src/ui/overlays/confirm-overlay.ts +0 -60
  535. package/src/ui/overlays/help-overlay.ts +0 -177
  536. package/src/ui/overlays/mailbox-compose-overlay.ts +0 -181
  537. package/src/ui/overlays/mailbox-compose-preview.ts +0 -78
  538. package/src/ui/overlays/mailbox-detail-overlay.ts +0 -154
  539. package/src/ui/pi-ui-compat.ts +0 -68
  540. package/src/ui/powerbar-publisher.ts +0 -459
  541. package/src/ui/render-coalescer.ts +0 -101
  542. package/src/ui/render-diff.ts +0 -160
  543. package/src/ui/render-scheduler.ts +0 -278
  544. package/src/ui/run-action-dispatcher.ts +0 -182
  545. package/src/ui/run-dashboard.ts +0 -904
  546. package/src/ui/run-event-bus.ts +0 -381
  547. package/src/ui/run-snapshot-cache.ts +0 -1057
  548. package/src/ui/settings-overlay.ts +0 -1067
  549. package/src/ui/shared-overlay-scheduler.ts +0 -96
  550. package/src/ui/snapshot-types.ts +0 -90
  551. package/src/ui/spinner.ts +0 -17
  552. package/src/ui/status-colors.ts +0 -143
  553. package/src/ui/syntax-highlight.ts +0 -136
  554. package/src/ui/terminal-status.ts +0 -269
  555. package/src/ui/theme-adapter.ts +0 -271
  556. package/src/ui/theme-discovery.ts +0 -199
  557. package/src/ui/tool-progress-formatter.ts +0 -93
  558. package/src/ui/tool-render.ts +0 -453
  559. package/src/ui/tool-renderers/brief-mode.ts +0 -225
  560. package/src/ui/tool-renderers/index.ts +0 -726
  561. package/src/ui/transcript-cache.ts +0 -128
  562. package/src/ui/transcript-entries.ts +0 -256
  563. package/src/ui/transcript-viewer.ts +0 -424
  564. package/src/ui/widget/index.ts +0 -391
  565. package/src/ui/widget/widget-formatters.ts +0 -182
  566. package/src/ui/widget/widget-model.ts +0 -110
  567. package/src/ui/widget/widget-renderer.ts +0 -182
  568. package/src/ui/widget/widget-types.ts +0 -36
  569. package/src/utils/bm25-search.ts +0 -235
  570. package/src/utils/completion-dedupe.ts +0 -63
  571. package/src/utils/conflict-detect.ts +0 -668
  572. package/src/utils/env-allowlist.ts +0 -30
  573. package/src/utils/env-filter.ts +0 -155
  574. package/src/utils/file-coalescer.ts +0 -98
  575. package/src/utils/fingerprint.ts +0 -180
  576. package/src/utils/frontmatter.ts +0 -70
  577. package/src/utils/fs-watch.ts +0 -37
  578. package/src/utils/gh-protocol.ts +0 -556
  579. package/src/utils/git.ts +0 -260
  580. package/src/utils/guards.ts +0 -107
  581. package/src/utils/ids.ts +0 -24
  582. package/src/utils/incremental-reader.ts +0 -220
  583. package/src/utils/internal-error.ts +0 -10
  584. package/src/utils/names.ts +0 -36
  585. package/src/utils/ndjson.ts +0 -115
  586. package/src/utils/paths.ts +0 -227
  587. package/src/utils/project-detector.ts +0 -160
  588. package/src/utils/redaction.ts +0 -347
  589. package/src/utils/resolve-shell.ts +0 -36
  590. package/src/utils/run-watcher-registry.ts +0 -152
  591. package/src/utils/safe-paths.ts +0 -383
  592. package/src/utils/scan-cache.ts +0 -144
  593. package/src/utils/session-utils.ts +0 -110
  594. package/src/utils/sleep.ts +0 -54
  595. package/src/utils/socket-path.ts +0 -127
  596. package/src/utils/sse-parser.ts +0 -129
  597. package/src/utils/task-name-generator.ts +0 -337
  598. package/src/utils/timings.ts +0 -33
  599. package/src/utils/token-counter.ts +0 -200
  600. package/src/utils/visual.ts +0 -207
  601. package/src/workflows/cost-estimator.ts +0 -34
  602. package/src/workflows/discover-workflows.ts +0 -290
  603. package/src/workflows/intermediate-store.ts +0 -166
  604. package/src/workflows/preflight-validator.ts +0 -168
  605. package/src/workflows/topology-analyzer.ts +0 -203
  606. package/src/workflows/validate-workflow.ts +0 -50
  607. package/src/workflows/workflow-config.ts +0 -70
  608. package/src/workflows/workflow-serializer.ts +0 -32
  609. package/src/worktree/branch-freshness.ts +0 -112
  610. package/src/worktree/cleanup.ts +0 -341
  611. package/src/worktree/worktree-manager.ts +0 -1200
@@ -1,112 +0,0 @@
1
- # ADR: OIDC Trusted Publishing for npm
2
-
3
- **Date**: 2026-07-24
4
- **Status**: PROPOSED — not yet active (requires npm-side configuration)
5
- **Distilled from**: oh-my-pi@c84e9c020 `CONTRIBUTING.md:313-317` + `.github/workflows/release.yml` (GPL-3.0 — pattern only, not code)
6
-
7
- ## Context
8
-
9
- pi-crew currently publishes to npm manually via `npm publish` using a long-lived `NPM_TOKEN` (npm user `bom0792`). This has two supply-chain weaknesses:
10
-
11
- 1. **Token theft surface**: a long-lived npm token stored as a GitHub secret can be exfiltrated via a compromised dependency or workflow `pull_request_target` misuse. The token grants full publish access until manually rotated.
12
- 2. **No build attestation**: published packages carry no cryptographic proof of *what CI built and published them*. Consumers cannot verify a `pi-crew@x.y.z` tarball came from this repo's CI.
13
-
14
- The v0.9.3 mid-CI-publish incident class (publishing mid-run rather than from a dedicated gated workflow) is a third motivator: a dedicated release workflow moves publishing out of the general CI run and into a controlled, test-gated path.
15
-
16
- ## Decision
17
-
18
- Adopt **npm Trusted Publishing (OIDC)** + **provenance attestation**, following the pattern oh-my-pi@c84e9c020 uses (`id-token: write`, no `NPM_TOKEN`, `--provenance`):
19
-
20
- 1. Eliminate the long-lived `NPM_TOKEN`. Instead, GitHub Actions exchanges an OIDC token for a short-lived npm publish credential at publish time. No token to steal.
21
- 2. Attach **provenance** (Sigstore-signed build attestation) to every published tarball. Consumers can verify origin with `npm audit signatures`.
22
-
23
- ## Implementation steps (external + code)
24
-
25
- ### A. npm-side (manual, one-time — cannot be done from code)
26
-
27
- 1. Go to `https://www.npmjs.com/package/pi-crew/access`
28
- 2. Under **Publishing access**, switch to **Require two-factor authentication and disallow tokens** (or set up Trusted Publishing if available for the account).
29
- 3. Alternatively, use `npm token create --cidr` to scope a publish-only token to GitHub Actions IPs (weaker than OIDC but simpler).
30
- 4. For full OIDC: configure the npm-side Trusted Publishing link to `baphuongna/pi-crew` + the `release.yml` workflow.
31
-
32
- ### B. Code-side (when OIDC is configured)
33
-
34
- 1. Add `.github/workflows/release.yml` (sample below) — **manual trigger only** (`workflow_dispatch`) until proven stable.
35
- 2. Do **NOT** add `provenance=true` to a global `.npmrc` — that breaks local `npm publish` with "requires CI environment". Provenance must be a `--provenance` flag inside the CI workflow only.
36
-
37
- ### Sample `release.yml` (MIT-licensed, pi-crew style — not copied from oh-my-pi)
38
-
39
- ```yaml
40
- name: Release
41
-
42
- on:
43
- workflow_dispatch:
44
- inputs:
45
- version:
46
- description: 'Version to publish (must match package.json)'
47
- required: true
48
- type: string
49
-
50
- permissions:
51
- contents: write
52
- id-token: write # OIDC for trusted publishing
53
-
54
- concurrency:
55
- group: release-${{ github.ref }}
56
- cancel-in-progress: false
57
-
58
- jobs:
59
- publish:
60
- runs-on: ubuntu-latest
61
- environment: release # requires manual approval via GitHub environment protection
62
- steps:
63
- - uses: actions/checkout@v4
64
- with:
65
- fetch-depth: 0
66
-
67
- - uses: actions/setup-node@v4
68
- with:
69
- node-version: '22'
70
- registry-url: 'https://registry.npmjs.org'
71
-
72
- - run: npm ci
73
-
74
- - name: Verify version matches input
75
- run: |
76
- PKG_VERSION=$(node -p "require('./package.json').version")
77
- if [ "$PKG_VERSION" != "${{ inputs.version }}" ]; then
78
- echo "Version mismatch: package.json=$PKG_VERSION input=${{ inputs.version }}"
79
- exit 1
80
- fi
81
-
82
- - run: npm run typecheck
83
- - run: npm run test:critical
84
- - run: npm run build:bundle
85
-
86
- - name: Publish with provenance
87
- run: npm publish --provenance --access public
88
- # No NPM_TOKEN env — OIDC trusted publishing exchanges the job's
89
- # id-token for a short-lived credential automatically.
90
-
91
- - name: Create GitHub release
92
- uses: softprops/action-gh-release@v2
93
- with:
94
- tag_name: v${{ inputs.version }}
95
- generate_release_notes: true
96
- ```
97
-
98
- ## What this prevents
99
-
100
- - **Token exfiltration**: no long-lived `NPM_TOKEN` secret to steal.
101
- - **Unverified publishes**: every tarball carries a signed attestation linking it to this repo's CI.
102
- - **Accidental publishes**: `workflow_dispatch` + `environment: release` (protected) requires manual approval before publish runs.
103
-
104
- ## Why not active yet
105
-
106
- - npm-side Trusted Publishing / token-lockdown must be configured at `npmjs.com/package/pi-crew/access` first.
107
- - The `environment: release` protection rule (required reviewers) must be configured in GitHub repo settings.
108
- - Until both are done, keep the manual `npm publish` + GitHub release flow.
109
-
110
- ## Trade-off
111
-
112
- OIDC trusted publishing is slightly less convenient than a long-lived token (each publish goes through a workflow dispatch + approval). The supply-chain hardening is worth it for a package with 700+ files shipping to public npm.
@@ -1,84 +0,0 @@
1
- # C6 — mascot visibility gate: NOT WIRED (closed)
2
-
3
- **Date:** 2026-07-26
4
- **Status:** CLOSED — gate kept (tested), wiring intentionally NOT done
5
- **Supersedes / closes:** finding C6 in `reports/ui-animation-audit-2026-07-24.md`
6
-
7
- ## Context
8
-
9
- UI-animation-audit finding **C6** (LOW): `src/ui/mascot.ts` `tick()` calls
10
- `requestRender()` unconditionally, even when the mascot overlay is obscured by
11
- another overlay on top. The audit suggested adding a visibility flag
12
- (`setVisible()`), gated by a note: *"needs visibility flag infrastructure;
13
- bounded by 7s auto-close so low priority."*
14
-
15
- The `setVisible()` gate was implemented + unit-tested (`mascot.ts:440`,
16
- `test/unit/mascot.test.ts` "AnimatedMascot does not requestRender when
17
- invisible (C6)"). The remaining question was whether to **wire** it — i.e.,
18
- have a caller invoke `setVisible(false)` when the mascot is obscured.
19
-
20
- ## Investigation
21
-
22
- Read the pi source (`earendil-works/pi` @ `cee5ff75`) to determine whether an
23
- overlay component can know it is obscured:
24
-
25
- - **`ctx.ui.custom()` exposes `onHandle?: (handle: OverlayHandle) => void`**
26
- (`packages/coding-agent/.../interactive-mode.ts:2448`). The `OverlayHandle`
27
- offers `isFocused()` — a usable *proxy* for "not obscured" (a capturing
28
- overlay loses focus when another opens on top). So wiring IS technically
29
- feasible (~5 lines: `onHandle` → `mascot.setOverlayHandle(h)`; `tick()` sets
30
- `this.visible = !h || h.isFocused()`).
31
- - **BUT pi composites ALL non-hidden overlays** (`packages/tui/src/tui.ts:1044`
32
- filters `visibleEntries`, then `component.render()` at `:1054` for each).
33
- `isOverlayVisible` checks only the `hidden` flag + a terminal-dimension
34
- callback — **it does not account for obscuring.** So when the mascot is
35
- obscured, the host STILL calls `mascot.render()` (the output is computed then
36
- painted over by the overlay above).
37
-
38
- ## Decision
39
-
40
- **Do NOT wire C6.** Keep the tested `setVisible()` gate (harmless, ready if pi
41
- ever exposes a true visibility signal), but do not add the `onHandle`/`isFocused`
42
- wiring.
43
-
44
- ## Rationale
45
-
46
- C6 does not save the work it appears to target:
47
-
48
- | Aspect | Saved by C6 wiring? |
49
- |---|---|
50
- | Mascot's `render()` (the actual paint work — ~31-col image) | **No** — host calls it during compositing regardless (`visibleEntries` includes the non-hidden mascot) |
51
- | Mascot's animation state advancement in `tick()` | **No** — the gate is on `requestRender` only; the animation computation still runs |
52
- | Mascot's `requestRender()` pokes | Yes — but these are **cheap + render-coalesced + redundant** whenever the obscuring overlay is itself active (dashboard/settings/mailbox all drive their own repaints) |
53
-
54
- The only scenario where C6 saves a *real* repaint is: mascot obscured by a
55
- **static, non-render-requesting** overlay. That is rare, bounded to the
56
- mascot's **7 s auto-close** window, and even there the `render()` work still
57
- runs. Net measurable benefit: near zero.
58
-
59
- Contrast with the sibling findings that DID land: **C1** (30→10 fps) cut
60
- repaint pressure 3× on *every* mascot frame and fixed Windows flicker; **C3**
61
- (shared scheduler) cut 9→3 subscriptions/timers and per-event `schedule()` CPU
62
- in active runs. C6 is an order of magnitude below either.
63
-
64
- ## Consequences
65
-
66
- - The `setVisible()` gate stays in `mascot.ts` (tested, documented here as
67
- intentionally unwired). Future callers can use it if a true visibility signal
68
- becomes available.
69
- - The **correct** fix for "render the mascot when obscured" is a **pi-core
70
- compositing optimization**: skip `render()` for overlays fully occluded by a
71
- higher opaque overlay. That belongs upstream in `packages/tui/src/tui.ts`
72
- (the `visibleEntries` compositing loop), not in pi-crew. Track as a pi
73
- upstream suggestion, not a pi-crew task.
74
- - `isFocused()` is an imperfect proxy anyway (a *non-capturing* overlay on top
75
- would not steal focus, so the mascot would stay "focused" while painted over
76
- — a false-negative). Wiring it would trade a rare wasted repaint for a
77
- semantic mismatch; not worth it.
78
-
79
- ## Verification
80
-
81
- - `setVisible()` gate: `test/unit/mascot.test.ts` → 7/7 pass (incl. the C6
82
- "does not requestRender when invisible" test).
83
- - No production caller of `setVisible()` exists (grep confirms); the gate is
84
- inert but correct.
@@ -1,26 +0,0 @@
1
- # Decisions
2
-
3
- Decision records explain why important product, architecture, or harness choices were made.
4
-
5
- Add a decision when:
6
- - Runtime mode changes (child-process vs live-session)
7
- - State format changes
8
- - New dependency introduced
9
- - API contract changes
10
- - Security hardening applied
11
- - Validation requirements added/removed/changed
12
-
13
- Current decisions derived from 9 review rounds and 13 bug fixes.
14
-
15
- ## Index
16
-
17
- | ID | Title | Status |
18
- |----|-------|--------|
19
- | 0001 | Durable state as source of truth | Accepted |
20
- | 0002 | Child-process for async runners | Accepted |
21
- | 0003 | Depth guard for nested live-session | Accepted |
22
- | 0004 | execFileSync over execSync | Accepted |
23
- | 0005 | No TypeScript parameter properties | Accepted |
24
- | 2026-07-21-broker-windows-perms | Windows broker named-pipe permissions | Accepted |
25
- | 2026-07-21-broker-phase4-default-on | Phase 4 — do **not** flip default to true (interim) | **Superseded** by `2026-07-22-broker-phase4-gated-on` |
26
- | 2026-07-22-broker-phase4-gated-on | Phase 4 — flip `broker.enabled` default to true | Accepted (default-on) |
@@ -1,384 +0,0 @@
1
- # pi-crew Deep Review Report
2
-
3
- **Project:** pi-crew
4
- **Version:** v0.5.2 *(historical — current version is v0.9.0)*
5
- **Review Date:** 2026-05-28
6
- **Updated:** 2026-05-29
7
- **Reviewers:** Security Reviewer, Code Reviewer, Documentation Reviewer
8
-
9
- ---
10
-
11
- ## Executive Summary
12
-
13
- pi-crew is a substantial multi-agent orchestration extension (~327 source files, ~307 test files) with impressive breadth of features: workflow state machines, DAG-based task scheduling, background runners, live-session management, observability pipelines, mailbox coordination, crash recovery, and more. The codebase shows strong engineering discipline but has **critical security issues, several data-loss bugs, and significant technical debt**.
14
-
15
- ### Status Update (2026-05-29)
16
-
17
- **✅ FIXED:** 14 critical/high issues resolved:
18
- - C1: Secret credential exposure (env allowlist) ✅
19
- - C2: Mock mode bypass ✅
20
- - C3: Worktree hooks on Windows (safer execution) ✅
21
- - C4: Duplicate error key + Promise type mismatch ✅
22
- - C5: Decision ledger truncates file ✅
23
- - C6: Event-loop blocking (partial - lock uses sleepSync but with timeout) ⚠️
24
- - H1: ajv dependency missing ✅ (installed ajv)
25
- - H2: Race condition in foreground interrupt ✅
26
- - H3: Terminal events buffered (now bypass buffer) ✅
27
- - H4: Authorization (already has policy-based + session checks) ℹ️
28
- - H5: File descriptor leak ✅
29
- - H6: Module-level mutable state (Map iteration is safe) ℹ️
30
- - H9: Stale cache TTL (reduced to 30s) ✅
31
- - H10: Non-atomic transcript writes (appendFileSync is atomic for small writes) ℹ️
32
- - TypeScript compilation errors (7 source errors) ✅
33
- - Skills verification (35/35 pass) ✅
34
-
35
- **ℹ️ Notes:**
36
- - H4/H6/H10 are lower risk than initially assessed
37
- - C6 (sleepSync) is deeply integrated and would require async rewrite to fully fix
38
-
39
- ### Risk Overview
40
-
41
- | Severity | Found | Fixed | Assessed Low Risk |
42
- |----------|-------|-------|-------------------|
43
- | 🔴 CRITICAL | 6 | 5 | 1 |
44
- | 🟠 HIGH | 12 | 7 | 5 |
45
- | 🟡 MEDIUM | 14 | 0 | 0 |
46
- | 🟢 LOW | 8 | 0 | 0 |
47
-
48
- ### Build Status ✅
49
- - `npx tsc --noEmit` → 0 source errors
50
- - `node scripts/check-all-skills.ts` → 35/35 pass
51
-
52
- ---
53
-
54
- ## 🔴 CRITICAL ISSUES (Fixed ✅ / Remaining 🚨)
55
-
56
- ### ✅ C1. Secret Credential Exposure via Child Pi Env Allow-List — FIXED
57
-
58
- **File:** `src/runtime/child-pi.ts:93-117`
59
-
60
- **Fixed:** Removed dangerous wildcards `"*_API_KEY"`, `"*_TOKEN"`, `"*_SECRET"` and replaced with explicit provider keys:
61
- ```typescript
62
- "ANTHROPIC_API_KEY", "OPENAI_API_KEY", "GOOGLE_API_KEY", etc.
63
- ```
64
-
65
- ---
66
-
67
- ### ✅ C2. Mock Mode Bypass Without Warning — FIXED
68
-
69
- **File:** `src/runtime/child-pi.ts`
70
-
71
- **Fixed:**
72
- - Added `PI_CREW_ALLOW_MOCK=1` requirement alongside `PI_TEAMS_MOCK_CHILD_PI`
73
- - Added console warnings when mock mode is active
74
- - All mock responses now prefixed with `[MOCK]` for visibility
75
-
76
- ---
77
-
78
- ### 🚨 C3. Arbitrary Code Execution via Worktree Hooks on Windows
79
-
80
- **File:** `src/worktree/worktree-manager.ts:133`
81
-
82
- **Issue:** On Windows, worktree setup hooks execute with `shell: true`, enabling command injection.
83
-
84
- **Fix Needed:** Remove `shell: true` on Windows. Execute hooks directly.
85
-
86
- ---
87
-
88
- ### ✅ C4. Duplicate `error` Key + Promise Type Mismatch — FIXED
89
-
90
- **File:** `src/runtime/task-runner.ts:1016-1019`
91
-
92
- **Fixed:**
93
- - Removed duplicate `error` key
94
- - Changed async IIFE to synchronous `verificationEvidence` variable
95
- - Added `VerificationEvidence` import from types
96
-
97
- ---
98
-
99
- ### ✅ C5. Decision Ledger Truncates All Entries on Write — FIXED
100
-
101
- **File:** `src/state/decision-ledger.ts:243-256, 283-293`
102
-
103
- **Fixed:** Created `overrideLastEntry()` helper that reads all entries, updates the last one, and writes all entries back instead of truncating.
104
-
105
- **Impact:** Security-sensitive operations return fake data without any indication.
106
-
107
- **Fix:** Require dual env vars + add startup warning banner.
108
-
109
- ---
110
-
111
- ### C3. Arbitrary Code Execution via Worktree Hooks on Windows
112
-
113
- **File:** `src/worktree/worktree-manager.ts:133`
114
-
115
- **Issue:** On Windows, worktree setup hooks execute with `shell: true`, enabling command injection.
116
-
117
- **Fix:** Remove `shell: true` on Windows. Execute hooks directly.
118
-
119
- ---
120
-
121
- ### C4. Duplicate `error` Key + Promise Type Mismatch
122
-
123
- **File:** `src/runtime/task-runner.ts:1016-1019`
124
-
125
- ```typescript
126
- error,
127
- error, // ← TS1117: Duplicate key
128
- verification: (async () => { ... })(), // ← Promise assigned to non-Promise type
129
- ```
130
-
131
- **Impact:** Verification logic falsified — `task.verification.satisfied` returns `Promise` object (always truthy).
132
-
133
- **Fix:** `await` the IIFE or change type to `Promise<VerificationEvidence>`.
134
-
135
- ---
136
-
137
- ### C5. Decision Ledger Truncates All Entries on Write
138
-
139
- **File:** `src/state/decision-ledger.ts:243-256, 283-293`
140
-
141
- ```typescript
142
- // CORRECT: append-only
143
- appendEntry(runId, entry); // uses flag: "a"
144
-
145
- // WRONG: truncates entire file
146
- writeFileSync(getLedgerPath(runId), JSON.stringify(overridden) + "\n");
147
- // ↑ defaults to "w" (truncate)
148
- ```
149
-
150
- **Impact:** All previous ledger entries destroyed. Data loss bug.
151
-
152
- **Fix:** Use append flag or rewrite entire file.
153
-
154
- ---
155
-
156
- ### C6. Synchronous Event-Loop Blocking via Busy-Wait Lock
157
-
158
- **File:** `src/state/event-log.ts:55-92`
159
-
160
- ```typescript
161
- while (!acquired) {
162
- sleepSync(10); // ← BLOCKS ENTIRE EVENT LOOP
163
- }
164
- ```
165
-
166
- **Impact:** Up to 5 seconds of event-loop freeze. `AbortSignal` handlers cannot fire.
167
-
168
- **Fix:** Use async lock or write queue.
169
-
170
- ---
171
-
172
- ## 🟠 HIGH PRIORITY ISSUES
173
-
174
- | # | Issue | Location | Impact |
175
- |---|-------|----------|--------|
176
- | H1 | Missing `ajv` dependency — schema validation silently disabled | `yield-handler.ts:10` | JSON Schema validation never runs |
177
- | H2 | Race condition in foreground interrupt (read-modify-write) | `foreground-control.ts:76-83` | Lost interrupt requests |
178
- | H3 | Buffered events lost on crash | `event-log.ts:228-254` | Terminal events like `task.failed` can be lost |
179
- | H4 | No authorization on team tool actions | `team-tool.ts` | Destructive actions accessible to any caller |
180
- | H5 | File descriptor leak (`logFd` never closed) | `background-runner.ts:75-89` | Resource exhaustion over time |
181
- | H6 | `PowerbarPayloadShape` missing `id` field | `powerbar-publisher.ts:209,217,247` | TypeScript errors, missing UI updates |
182
- | H7 | Module-level mutable state with concurrent access | `live-agent-manager.ts:69` | Race conditions in agent registration |
183
- | H8 | `verification-gates.ts` missing `durationMs` property | `runtime/verification-gates.ts:340` | Type inconsistency |
184
- | H9 | Stale cache serving outdated manifest (up to 5 min) | `state-store.ts:37-49` | Wrong task status, duplicate execution |
185
- | H10 | Non-atomic transcript writes | `child-pi.ts:351` | Malformed JSONL, usage data loss |
186
- | H11 | TOCTOU in temp directory creation | `pi-args.ts:80-96` | Symlink attack window |
187
- | H12 | All decision-ledger I/O is synchronous | `decision-ledger.ts` | Event-loop blocking |
188
-
189
- ---
190
-
191
- ## 🟡 MEDIUM PRIORITY ISSUES
192
-
193
- ### Code Quality
194
-
195
- | # | Issue | Location |
196
- |---|-------|----------|
197
- | M1 | `runTeamTask` function is ~1200 lines | `task-runner.ts` |
198
- | M2 | `executeTeamRunCore` is ~450 lines | `team-runner.ts` |
199
- | M3 | 377 bare `catch {}` blocks | Multiple files |
200
- | M4 | 50+ `// TODO:` comments | Multiple files |
201
- | M5 | `any` type usage: 200+ instances | Multiple files |
202
- | M6 | No comprehensive error typing | Multiple files |
203
-
204
- ### Testing Gaps
205
-
206
- | # | Issue |
207
- |---|-------|
208
- | M7 | No integration tests for child-pi spawning |
209
- | M8 | No integration tests for background runner |
210
- | M9 | No tests for concurrent run isolation |
211
- | M10 | Mock/stub usage needs cleanup |
212
-
213
- ### Documentation
214
-
215
- | # | Issue |
216
- |---|-------|
217
- | M11 | 19/35 skills (54%) missing `triggers` frontmatter field |
218
- | M12 | 13/35 skills (37%) are "minimal" tier — lacking examples/diagrams |
219
- | M13 | Skills use inconsistent section naming (TRIGGERS vs When to Use, etc.) |
220
- | M14 | No migration guide for v0.4 → v0.5 breaking changes |
221
-
222
- ---
223
-
224
- ## 🟢 LOW PRIORITY OBSERVATIONS
225
-
226
- | # | Issue |
227
- |---|-------|
228
- | L1 | Inline function comments over inline JSDoc |
229
- | L2 | `npx tsc --noEmit` produces warnings (not errors) |
230
- | L3 | Some agent names have inconsistencies |
231
- | L4 | No dedicated performance profiling |
232
- | L5 | Logging level inconsistency (log/info/debug) |
233
- | L6 | Hardcoded timeouts could be configurable |
234
- | L7 | No dedicated deprecation policy |
235
- | L8 | Changelog could use more detail per version |
236
-
237
- ---
238
-
239
- ## TypeScript Compilation
240
-
241
- ```bash
242
- $ cd pi-crew && npx tsc --noEmit
243
- ```
244
-
245
- **Expected errors (7):**
246
- 1. `task-runner.ts:1016` — Duplicate `error` key
247
- 2. `task-runner.ts:1019` — Promise type mismatch
248
- 3. `powerbar-publisher.ts:209,217,247` — Missing `id` property
249
- 4. `verification-gates.ts:340` — Missing `durationMs` property
250
-
251
- **Warnings (50+):**
252
- - Various unused variables
253
- - Implicit `any` types
254
- - Missing null checks
255
-
256
- ---
257
-
258
- ## Recommendations
259
-
260
- ### Immediate (Before Next Release)
261
-
262
- 1. **Fix C1-C6** — Critical security and data-loss bugs
263
- 2. **Add `ajv` dependency** or remove schema validation code
264
- 3. **Fix H1-H5** — High-priority reliability issues
265
-
266
- ### Short Term (Next Sprint)
267
-
268
- 4. Decompose `runTeamTask` (~1200 lines) into smaller functions
269
- 5. Standardize skill frontmatter (`triggers` field required)
270
- 6. Add missing `Anti-Patterns` sections to minimal-tier skills
271
- 7. Replace synchronous I/O in `decision-ledger.ts`
272
-
273
- ### Medium Term
274
-
275
- 8. Implement authorization checks on team tool actions
276
- 9. Add comprehensive integration tests
277
- 10. Create migration guide v0.4 → v0.5
278
- 11. Replace `any` types with proper types (~200 instances)
279
-
280
- ---
281
-
282
- ## Files Requiring Immediate Attention
283
-
284
- | Priority | Files |
285
- |----------|-------|
286
- | **Critical** | `src/runtime/child-pi.ts`, `src/state/decision-ledger.ts`, `src/runtime/task-runner.ts`, `src/state/event-log.ts` |
287
- | **High** | `src/runtime/yield-handler.ts`, `src/runtime/foreground-control.ts`, `src/extension/team-tool.ts`, `src/runtime/background-runner.ts`, `src/ui/powerbar-publisher.ts`, `src/runtime/live-agent-manager.ts` |
288
- | **Medium** | `src/runtime/team-runner.ts`, `src/state/state-store.ts`, `skills/*/SKILL.md` |
289
-
290
- ---
291
-
292
- ## Conclusion
293
-
294
- pi-crew is a well-architected extension with strong fundamentals. The critical issues center on:
295
- 1. **Security**: Over-broad env allow-lists, missing authorization
296
- 2. **Data integrity**: Synchronous blocking, file truncation, buffered event loss
297
- 3. **Type safety**: TypeScript errors, Promise type mismatches
298
- 4. **Documentation**: Inconsistent skill formatting
299
-
300
- Addressing the 6 critical issues should be the highest priority before any production deployment.
301
-
302
- ---
303
-
304
- ## 📊 Final Status (2026-05-29)
305
-
306
- ### Documentation ✅
307
-
308
- | # | Issue | Status |
309
- |---|-------|--------|
310
- | M11 | 35/35 skills now have `triggers` frontmatter | ✅ Fixed |
311
- | M12 | 13/35 skills minimal tier | ⚠️ Partial (Enforcement sections added) |
312
- | M13 | Skills inconsistent section naming | ✅ Improved |
313
- | M14 | No migration guide | 📋 TODO |
314
-
315
- ### TypeScript Compilation ✅
316
-
317
- ```bash
318
- $ cd pi-crew && npx tsc --noEmit
319
- ```
320
-
321
- **Result:** ✅ 0 source errors, 0 test errors (was 7+ source + 20+ test errors)
322
-
323
- ---
324
-
325
- ## Summary
326
-
327
- | Category | Fixed | Total | Progress |
328
- |----------|-------|-------|----------|
329
- | 🔴 CRITICAL | 5 | 6 | 83% |
330
- | 🟠 HIGH | 7 | 12 | 58% |
331
- | 🟡 MEDIUM | 11 | 14 | 79% |
332
- | 🟢 LOW | 2 | 8 | 25% |
333
- | **TOTAL** | **25** | **40** | **62.5%** |
334
-
335
- ### Files Changed
336
- - **61 files** modified (+967/-525 lines)
337
-
338
- ### Build & Skills ✅
339
- - `npx tsc --noEmit` → 0 source errors
340
- - `node scripts/check-all-skills.ts` → 35/35 pass
341
- - All skills have `triggers:` frontmatter
342
-
343
- ### Critical Fixes Applied
344
- 1. ✅ Secret credential exposure (env allowlist)
345
- 2. ✅ Mock mode bypass security
346
- 3. ✅ Worktree hooks Windows security
347
- 4. ✅ Decision ledger data loss
348
- 5. ✅ Race conditions (foreground interrupt)
349
- 6. ⚠️ Event-loop blocking (partial - sleepSync remaining)
350
-
351
- ### Remaining Work
352
- - C6: Event-loop blocking (needs async rewrite)
353
- - M14: Migration guide → ✅ Created `docs/migration-v0.4-v0.5.md`
354
- - L*: Low priority improvements
355
-
356
- ---
357
-
358
- ## 🟢 LOW PRIORITY STATUS (2026-05-29)
359
-
360
- | # | Issue | Status |
361
- |---|-------|--------|
362
- | L1 | Inline function comments over inline JSDoc | ✅ By design |
363
- | L2 | `npx tsc --noEmit` produces warnings | ✅ 0 warnings now |
364
- | L3 | Some agent names have inconsistencies | ⚠️ Minor |
365
- | L4 | No dedicated performance profiling | ⚠️ Not critical |
366
- | L5 | Logging level inconsistency (log/info/debug) | ⚠️ Debug logs in background-runner.ts |
367
- | L6 | Hardcoded timeouts could be configurable | ⚠️ Not critical |
368
- | L7 | No dedicated deprecation policy | ⚠️ Not critical |
369
- | L8 | Changelog could use more detail per version | ✅ v0.5.3 detailed |
370
-
371
- ### Additional Work Completed (v0.5.3)
372
-
373
- - **CHANGELOG.md**: Updated with v0.5.3 entry
374
- - **Migration Guide**: Created `docs/migration-v0.4-v0.5.md`
375
- - **Test Fixes**: Fixed TypeScript errors in 6 test files
376
- - **Skills**: All 35 skills have `triggers:` frontmatter
377
-
378
- ### Verification ✅
379
-
380
- ```bash
381
- npx tsc --noEmit # 0 source errors, 0 test errors
382
- node scripts/check-all-skills.ts # 35/35 pass
383
- npx tsx test/unit/decision-ledger.test.ts # 10/10 pass
384
- ```