pi-crew 0.9.51 → 0.9.53

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (611) hide show
  1. package/CHANGELOG.md +53 -0
  2. package/README.md +216 -20
  3. package/dist/build-meta.json +2090 -1638
  4. package/dist/index.mjs +18057 -17119
  5. package/docs/actions-reference.md +431 -1
  6. package/index.ts +39 -10
  7. package/package.json +19 -9
  8. package/schema.json +41 -0
  9. package/scripts/check-bundle-size.mjs +38 -0
  10. package/scripts/test-runner.mjs +11 -1
  11. package/dist/index.mjs.map +0 -7
  12. package/docs/FEATURE_INTAKE.md +0 -126
  13. package/docs/HARNESS.md +0 -87
  14. package/docs/HARNESS_BACKLOG.md +0 -89
  15. package/docs/PROJECT_REVIEW.md +0 -270
  16. package/docs/PROJECT_REVIEW_FIXES.md +0 -342
  17. package/docs/PROJECT_REVIEW_ROUND4.md +0 -156
  18. package/docs/PROJECT_REVIEW_ROUND5.md +0 -86
  19. package/docs/REVIEW-FINDINGS-2026-06 +0 -357
  20. package/docs/REVIEW-FINDINGS-2026-07-CORE.md +0 -139
  21. package/docs/REVIEW-FINDINGS-2026-07.md +0 -125
  22. package/docs/TEST_MATRIX.md +0 -51
  23. package/docs/archive/README.md +0 -91
  24. package/docs/archive/followup-review-round3-2026-05-12.md +0 -342
  25. package/docs/archive/followup-review-round4-2026-05-13.md +0 -107
  26. package/docs/archive/pi-crew-bugs.md +0 -961
  27. package/docs/archive/pi-crew-test-final.md +0 -120
  28. package/docs/archive/pi-crew-test-results.md +0 -260
  29. package/docs/archive/pi-crew-test-round2.md +0 -136
  30. package/docs/archive/pi-crew-test-round4.md +0 -100
  31. package/docs/archive/pi-crew-test-round5.md +0 -70
  32. package/docs/archive/pi-crew-test-round6.md +0 -110
  33. package/docs/archive/pi-crew-v0.5.10-audit-fix-plan.md +0 -60
  34. package/docs/archive/pi-crew-v0.5.11-audit-fix-plan.md +0 -92
  35. package/docs/archive/pi-crew-v0.5.12-audit-fix-plan.md +0 -76
  36. package/docs/archive/pi-crew-v0.5.13-audit-fix-plan.md +0 -75
  37. package/docs/archive/pi-crew-v0.5.14-audit-fix-plan.md +0 -75
  38. package/docs/archive/pi-crew-v0.5.16-audit-fix-plan.md +0 -35
  39. package/docs/archive/pi-crew-v0.5.17-audit-fix-plan.md +0 -80
  40. package/docs/archive/pi-crew-v0.5.5-audit-fix-plan.md +0 -133
  41. package/docs/archive/pi-crew-v0.5.9-audit-fix-plan.md +0 -88
  42. package/docs/archive/pi-mono-opportunities.md +0 -969
  43. package/docs/archive/pi-mono-review.md +0 -291
  44. package/docs/archive/pi-subagent4-comparison.md +0 -261
  45. package/docs/archive/pi-subagents3-deep-analysis.md +0 -508
  46. package/docs/bugs/bug-021-notification-badge-counter-misleading.md +0 -293
  47. package/docs/bugs/bug-023-chain-windows-path-resolution.md +0 -106
  48. package/docs/bugs/bug-quota-display-truncation.md +0 -223
  49. package/docs/bugs/cross-session-notification-leakage.md +0 -82
  50. package/docs/code-review-2026-05-11.md +0 -592
  51. package/docs/coding-agent-optimization.md +0 -268
  52. package/docs/comparison-pi-subagents-vs-pi-crew.md +0 -303
  53. package/docs/decisions/0001-durable-state.md +0 -41
  54. package/docs/decisions/0002-child-process-for-async.md +0 -42
  55. package/docs/decisions/0003-depth-guard.md +0 -36
  56. package/docs/decisions/0004-execfile-over-exec.md +0 -34
  57. package/docs/decisions/0005-no-parameter-properties.md +0 -49
  58. package/docs/decisions/0006-publish-bundled-esm.md +0 -63
  59. package/docs/decisions/0007-active-run-binary-index.md +0 -54
  60. package/docs/decisions/0008-child-pi-warm-pool.md +0 -61
  61. package/docs/decisions/2026-07-21-broker-phase4-default-on.md +0 -77
  62. package/docs/decisions/2026-07-21-broker-windows-perms.md +0 -91
  63. package/docs/decisions/2026-07-22-broker-phase4-gated-on.md +0 -99
  64. package/docs/decisions/2026-07-24-oidc-trusted-publishing.md +0 -112
  65. package/docs/decisions/2026-07-26-c6-mascot-visibility-not-wired.md +0 -84
  66. package/docs/decisions/README.md +0 -26
  67. package/docs/deep-review-report.md +0 -384
  68. package/docs/distillation/cybersecurity-patterns.md +0 -294
  69. package/docs/feature-analysis-subagent4.md +0 -305
  70. package/docs/fix-plan-disabletools-exit-null.md +0 -219
  71. package/docs/fixes/BATCH_A_H1_H2.md +0 -86
  72. package/docs/fixes/bug-006-foreground-cancel-concurrent.md +0 -78
  73. package/docs/fixes/bug-007-async-notifier-stale-ctx.md +0 -112
  74. package/docs/fixes/bug-008-child-process-silent-timeout.md +0 -100
  75. package/docs/fixes/bug-009-executor-yield-limit-needs-attention.md +0 -75
  76. package/docs/fixes/bug-010-child-process-api-key-filtered.md +0 -109
  77. package/docs/fixes/bug-011-spawn-pi-enoent.md +0 -92
  78. package/docs/fixes/bug-012-essential-env-stripped.md +0 -89
  79. package/docs/fixes/bug-013-background-runner-death.md +0 -84
  80. package/docs/fixes/bug-014-infinite-retry-loop-needs-attention.md +0 -82
  81. package/docs/fixes/bug-015-background-runner-sigterm.md +0 -65
  82. package/docs/fixes/bug-017-background-runner-session-shutdown.md +0 -66
  83. package/docs/fixes/bug-017-background-runner-sigkill-double-fork.md +0 -28
  84. package/docs/fixes/bug-018-child-pi-worker-stdin-hang.md +0 -61
  85. package/docs/fixes/bug-019-phantom-runs-temp-workspace.md +0 -52
  86. package/docs/fixes/bug-020-infinite-retry-loop-needs-attention.md +0 -47
  87. package/docs/fixes/v0.9.10/locks-fix-verify.md +0 -3
  88. package/docs/fixes/v0.9.10/smoke-test.md +0 -12
  89. package/docs/followup-plan-2026-05-12.md +0 -463
  90. package/docs/followup-review-2026-05-12.md +0 -297
  91. package/docs/goals.md +0 -59
  92. package/docs/implementation-plan-top3.md +0 -333
  93. package/docs/issue-29-analysis.md +0 -189
  94. package/docs/live-mailbox-runtime.md +0 -36
  95. package/docs/migration/atomic-write-v2-migration.md +0 -299
  96. package/docs/next-upgrade-roadmap.md +0 -808
  97. package/docs/oh-my-pi-research.md +0 -509
  98. package/docs/optimization-plan-2026-07.md +0 -366
  99. package/docs/optimization-plan.md +0 -644
  100. package/docs/patterns/command-agent-skill.md +0 -71
  101. package/docs/perf/baseline-2026-05.md +0 -113
  102. package/docs/perf/final-report-2026-05.md +0 -206
  103. package/docs/perf/optimization-plan-2026-07-verified.md +0 -396
  104. package/docs/perf/performance-audit-report-2026-07.md +0 -948
  105. package/docs/perf/performance-review-2026-07.md +0 -287
  106. package/docs/perf/sprint-1-report.md +0 -71
  107. package/docs/perf/sprint-2-report.md +0 -81
  108. package/docs/perf/sprint-2.5-report.md +0 -53
  109. package/docs/perf/sprint-3-report.md +0 -36
  110. package/docs/perf/sprint-4-report.md +0 -47
  111. package/docs/perf/sprint-5-report.md +0 -51
  112. package/docs/perf/sprint-6-report.md +0 -94
  113. package/docs/perf/sprint-7-report.md +0 -74
  114. package/docs/perf/upgrade-plan-2026-05.md +0 -147
  115. package/docs/performance-optimization-execution-plan.md +0 -520
  116. package/docs/phase4-triage.md +0 -58
  117. package/docs/pi-crew-investigation-report.md +0 -411
  118. package/docs/product/README.md +0 -31
  119. package/docs/product/platform.md +0 -27
  120. package/docs/product/runtime-safety.md +0 -37
  121. package/docs/product/team-run.md +0 -39
  122. package/docs/product/team-tool.md +0 -37
  123. package/docs/runtime-analysis-child-vs-live.md +0 -171
  124. package/docs/runtime-migration-in-process-analysis.md +0 -250
  125. package/docs/skills/REFERENCE.md +0 -138
  126. package/docs/stories/README.md +0 -32
  127. package/docs/stories/US-DEPS-major-upgrade.md +0 -62
  128. package/docs/stories/backlog.md +0 -36
  129. package/docs/superpowers/plans/2026-06-09-fallow-patterns-adoption.md +0 -1270
  130. package/docs/templates/decision.md +0 -27
  131. package/docs/templates/story.md +0 -44
  132. package/docs/templates/validation-report.md +0 -32
  133. package/docs/ui-optimization-plan.md +0 -447
  134. package/src/adapters/claude-adapter.ts +0 -23
  135. package/src/adapters/codex-adapter.ts +0 -21
  136. package/src/adapters/cursor-adapter.ts +0 -17
  137. package/src/adapters/export-util.ts +0 -143
  138. package/src/adapters/index.ts +0 -15
  139. package/src/adapters/registry.ts +0 -18
  140. package/src/adapters/types.ts +0 -23
  141. package/src/agents/agent-config.ts +0 -194
  142. package/src/agents/agent-search.ts +0 -98
  143. package/src/agents/agent-serializer.ts +0 -38
  144. package/src/agents/discover-agents.ts +0 -623
  145. package/src/benchmark/benchmark-runner.ts +0 -313
  146. package/src/benchmark/feedback-loop.ts +0 -73
  147. package/src/config/config.ts +0 -1269
  148. package/src/config/defaults.ts +0 -193
  149. package/src/config/drift-detector.ts +0 -290
  150. package/src/config/markers.ts +0 -330
  151. package/src/config/resilient-parser.ts +0 -117
  152. package/src/config/role-tools.ts +0 -118
  153. package/src/config/suggestions.ts +0 -75
  154. package/src/config/types.ts +0 -278
  155. package/src/errors.ts +0 -194
  156. package/src/extension/action-suggestions.ts +0 -117
  157. package/src/extension/async-notifier.ts +0 -179
  158. package/src/extension/autonomous-policy.ts +0 -209
  159. package/src/extension/command-completions.ts +0 -120
  160. package/src/extension/context-status-injection.ts +0 -185
  161. package/src/extension/crew-autocomplete.ts +0 -131
  162. package/src/extension/crew-cleanup.ts +0 -168
  163. package/src/extension/crew-input-router.ts +0 -93
  164. package/src/extension/crew-shortcuts.ts +0 -87
  165. package/src/extension/crew-vibes/cat-frames.ts +0 -18
  166. package/src/extension/crew-vibes/config.ts +0 -195
  167. package/src/extension/crew-vibes/figures.ts +0 -101
  168. package/src/extension/crew-vibes/font-detect.ts +0 -71
  169. package/src/extension/crew-vibes/footer.ts +0 -292
  170. package/src/extension/crew-vibes/index.ts +0 -432
  171. package/src/extension/crew-vibes/provider-usage.ts +0 -396
  172. package/src/extension/crew-vibes/render.ts +0 -206
  173. package/src/extension/crew-vibes/speed.ts +0 -286
  174. package/src/extension/cross-extension-rpc.ts +0 -350
  175. package/src/extension/help.ts +0 -62
  176. package/src/extension/import-index.ts +0 -74
  177. package/src/extension/knowledge-injection.ts +0 -402
  178. package/src/extension/management.ts +0 -571
  179. package/src/extension/message-renderers.ts +0 -108
  180. package/src/extension/notification-router.ts +0 -152
  181. package/src/extension/notification-sink.ts +0 -54
  182. package/src/extension/pi-api.ts +0 -56
  183. package/src/extension/plan-orchestrate.ts +0 -302
  184. package/src/extension/project-init.ts +0 -170
  185. package/src/extension/register.ts +0 -113
  186. package/src/extension/registration/artifact-cleanup.ts +0 -20
  187. package/src/extension/registration/command-registration.ts +0 -58
  188. package/src/extension/registration/command-utils.ts +0 -58
  189. package/src/extension/registration/commands.ts +0 -1228
  190. package/src/extension/registration/compaction-guard.ts +0 -333
  191. package/src/extension/registration/context-builder.ts +0 -135
  192. package/src/extension/registration/crash-recovery-cache.ts +0 -54
  193. package/src/extension/registration/foreground-run-controller.ts +0 -238
  194. package/src/extension/registration/hook-registration.ts +0 -119
  195. package/src/extension/registration/lazy-configurers.ts +0 -124
  196. package/src/extension/registration/lifecycle-handlers.ts +0 -923
  197. package/src/extension/registration/lifecycle.ts +0 -259
  198. package/src/extension/registration/observability.ts +0 -322
  199. package/src/extension/registration/registration-types.ts +0 -158
  200. package/src/extension/registration/runtime-cleanup.ts +0 -230
  201. package/src/extension/registration/subagent-helpers.ts +0 -125
  202. package/src/extension/registration/subagent-manager-setup.ts +0 -330
  203. package/src/extension/registration/subagent-tools.ts +0 -456
  204. package/src/extension/registration/team-tool.ts +0 -220
  205. package/src/extension/registration/tool-registration.ts +0 -50
  206. package/src/extension/registration/ui.ts +0 -172
  207. package/src/extension/registration/viewers.ts +0 -121
  208. package/src/extension/registration/wire-cross-extension.ts +0 -37
  209. package/src/extension/result-watcher.ts +0 -139
  210. package/src/extension/rpc-hmac.ts +0 -256
  211. package/src/extension/run-bundle-schema.ts +0 -104
  212. package/src/extension/run-export.ts +0 -97
  213. package/src/extension/run-import.ts +0 -168
  214. package/src/extension/run-index.ts +0 -131
  215. package/src/extension/run-maintenance.ts +0 -190
  216. package/src/extension/session-summary.ts +0 -18
  217. package/src/extension/team-manager-command.ts +0 -153
  218. package/src/extension/team-onboard.ts +0 -177
  219. package/src/extension/team-recommendation.ts +0 -288
  220. package/src/extension/team-tool/anchor.ts +0 -172
  221. package/src/extension/team-tool/api.ts +0 -1244
  222. package/src/extension/team-tool/auto-summarize.ts +0 -142
  223. package/src/extension/team-tool/cache-control.ts +0 -19
  224. package/src/extension/team-tool/cancel.ts +0 -337
  225. package/src/extension/team-tool/chain-dispatch.ts +0 -95
  226. package/src/extension/team-tool/chain-executor.ts +0 -379
  227. package/src/extension/team-tool/config-patch.ts +0 -50
  228. package/src/extension/team-tool/context.ts +0 -149
  229. package/src/extension/team-tool/destructive-gate.ts +0 -52
  230. package/src/extension/team-tool/doctor.ts +0 -431
  231. package/src/extension/team-tool/explain.ts +0 -282
  232. package/src/extension/team-tool/failure-patterns.ts +0 -118
  233. package/src/extension/team-tool/goal-wrap.ts +0 -330
  234. package/src/extension/team-tool/goal.ts +0 -556
  235. package/src/extension/team-tool/handle-schedule.ts +0 -332
  236. package/src/extension/team-tool/handle-settings.ts +0 -520
  237. package/src/extension/team-tool/health-monitor.ts +0 -481
  238. package/src/extension/team-tool/inspect.ts +0 -88
  239. package/src/extension/team-tool/intent-policy.ts +0 -45
  240. package/src/extension/team-tool/lifecycle-actions.ts +0 -615
  241. package/src/extension/team-tool/orchestrate.ts +0 -98
  242. package/src/extension/team-tool/parallel-dispatch.ts +0 -183
  243. package/src/extension/team-tool/plan.ts +0 -50
  244. package/src/extension/team-tool/respond.ts +0 -150
  245. package/src/extension/team-tool/run-not-found.ts +0 -49
  246. package/src/extension/team-tool/run.ts +0 -1035
  247. package/src/extension/team-tool/status.ts +0 -260
  248. package/src/extension/team-tool/workflow-manage.ts +0 -261
  249. package/src/extension/team-tool-types.ts +0 -26
  250. package/src/extension/team-tool.ts +0 -1116
  251. package/src/extension/tool-result.ts +0 -16
  252. package/src/extension/validate-resources.ts +0 -108
  253. package/src/hooks/registry.ts +0 -200
  254. package/src/hooks/types.ts +0 -69
  255. package/src/i18n.ts +0 -212
  256. package/src/observability/correlation.ts +0 -50
  257. package/src/observability/event-bus.ts +0 -86
  258. package/src/observability/event-to-metric.ts +0 -170
  259. package/src/observability/exporters/adapter.ts +0 -27
  260. package/src/observability/exporters/otlp-exporter.ts +0 -356
  261. package/src/observability/exporters/prometheus-exporter.ts +0 -54
  262. package/src/observability/metric-registry.ts +0 -100
  263. package/src/observability/metric-retention.ts +0 -64
  264. package/src/observability/metric-sink.ts +0 -99
  265. package/src/observability/metrics-primitives.ts +0 -219
  266. package/src/plugins/plugin-define.ts +0 -6
  267. package/src/plugins/plugin-registry.ts +0 -32
  268. package/src/plugins/plugins/index.ts +0 -3
  269. package/src/plugins/plugins/nextjs.ts +0 -19
  270. package/src/plugins/plugins/vite.ts +0 -10
  271. package/src/plugins/plugins/vitest.ts +0 -9
  272. package/src/prompt/prompt-runtime.ts +0 -380
  273. package/src/runtime/adaptive-plan.ts +0 -563
  274. package/src/runtime/agent-control.ts +0 -215
  275. package/src/runtime/agent-memory.ts +0 -81
  276. package/src/runtime/agent-observability.ts +0 -122
  277. package/src/runtime/anchor-manager.ts +0 -475
  278. package/src/runtime/async-marker.ts +0 -32
  279. package/src/runtime/async-runner.ts +0 -381
  280. package/src/runtime/attention-events.ts +0 -28
  281. package/src/runtime/auto-summarize.ts +0 -344
  282. package/src/runtime/background-runner.ts +0 -837
  283. package/src/runtime/batch-barrier.ts +0 -147
  284. package/src/runtime/broker-issuer.ts +0 -37
  285. package/src/runtime/cancellation-token.ts +0 -99
  286. package/src/runtime/cancellation.ts +0 -99
  287. package/src/runtime/capability-inventory.ts +0 -137
  288. package/src/runtime/chain-parser.ts +0 -237
  289. package/src/runtime/chain-runner.ts +0 -606
  290. package/src/runtime/checkpoint.ts +0 -291
  291. package/src/runtime/child-pi-constants.ts +0 -42
  292. package/src/runtime/child-pi-kill.ts +0 -180
  293. package/src/runtime/child-pi-pool.ts +0 -68
  294. package/src/runtime/child-pi-spawn.ts +0 -287
  295. package/src/runtime/child-pi-steering.ts +0 -128
  296. package/src/runtime/child-pi-streams.ts +0 -296
  297. package/src/runtime/child-pi-transcript.ts +0 -169
  298. package/src/runtime/child-pi.ts +0 -1105
  299. package/src/runtime/coalesce-tasks.ts +0 -268
  300. package/src/runtime/code-summary.ts +0 -292
  301. package/src/runtime/command-trace.ts +0 -105
  302. package/src/runtime/compact-pipeline.ts +0 -56
  303. package/src/runtime/compact-stages/ansi-strip-stage.ts +0 -25
  304. package/src/runtime/compact-stages/blank-collapse-stage.ts +0 -31
  305. package/src/runtime/compact-stages/deduplicate-stage.ts +0 -34
  306. package/src/runtime/compact-stages/head-snap-stage.ts +0 -57
  307. package/src/runtime/compact-stages/index.ts +0 -23
  308. package/src/runtime/compact-stages/tail-capture-stage.ts +0 -77
  309. package/src/runtime/compact-stages/truncation-stage.ts +0 -74
  310. package/src/runtime/compaction-summary.ts +0 -278
  311. package/src/runtime/completion-guard.ts +0 -207
  312. package/src/runtime/concurrency.ts +0 -58
  313. package/src/runtime/crash-classification.ts +0 -229
  314. package/src/runtime/crash-recovery.ts +0 -577
  315. package/src/runtime/crew-agent-records.ts +0 -593
  316. package/src/runtime/crew-agent-runtime.ts +0 -62
  317. package/src/runtime/crew-broker-child.ts +0 -88
  318. package/src/runtime/crew-broker-client.ts +0 -673
  319. package/src/runtime/crew-broker-tokens.ts +0 -84
  320. package/src/runtime/crew-broker.ts +0 -1276
  321. package/src/runtime/crew-hooks.ts +0 -227
  322. package/src/runtime/cross-extension-rpc.ts +0 -143
  323. package/src/runtime/custom-tools/irc-tool.ts +0 -282
  324. package/src/runtime/custom-tools/submit-result-tool.ts +0 -102
  325. package/src/runtime/deadletter.ts +0 -47
  326. package/src/runtime/delivery-coordinator.ts +0 -211
  327. package/src/runtime/delta-conflict.ts +0 -348
  328. package/src/runtime/deterministic-ast.ts +0 -161
  329. package/src/runtime/diagnostic-export.ts +0 -171
  330. package/src/runtime/direct-run.ts +0 -45
  331. package/src/runtime/dwf-state-store.ts +0 -102
  332. package/src/runtime/dynamic-workflow-context.ts +0 -1016
  333. package/src/runtime/dynamic-workflow-runner.ts +0 -310
  334. package/src/runtime/effectiveness.ts +0 -90
  335. package/src/runtime/errors/crew-errors.ts +0 -162
  336. package/src/runtime/event-stream-bridge.ts +0 -98
  337. package/src/runtime/foreground-control.ts +0 -193
  338. package/src/runtime/foreground-watchdog.ts +0 -132
  339. package/src/runtime/global-worker-cap.ts +0 -96
  340. package/src/runtime/goal-achievement.ts +0 -148
  341. package/src/runtime/goal-evaluator.ts +0 -361
  342. package/src/runtime/goal-loop-runner.ts +0 -828
  343. package/src/runtime/goal-state-store.ts +0 -219
  344. package/src/runtime/green-contract.ts +0 -55
  345. package/src/runtime/group-join.ts +0 -267
  346. package/src/runtime/handoff-manager.ts +0 -598
  347. package/src/runtime/heartbeat-gradient.ts +0 -36
  348. package/src/runtime/heartbeat-watcher.ts +0 -239
  349. package/src/runtime/hidden-handoff.ts +0 -407
  350. package/src/runtime/important-line-classifier.ts +0 -140
  351. package/src/runtime/intercom-bridge.ts +0 -187
  352. package/src/runtime/iteration-hooks.ts +0 -305
  353. package/src/runtime/live-agent-control.ts +0 -136
  354. package/src/runtime/live-agent-manager.ts +0 -704
  355. package/src/runtime/live-control-realtime.ts +0 -56
  356. package/src/runtime/live-extension-bridge.ts +0 -148
  357. package/src/runtime/live-irc.ts +0 -97
  358. package/src/runtime/live-session-health.ts +0 -108
  359. package/src/runtime/live-session-runtime.ts +0 -1139
  360. package/src/runtime/loop-gates.ts +0 -128
  361. package/src/runtime/manifest-cache.ts +0 -375
  362. package/src/runtime/mcp-proxy.ts +0 -105
  363. package/src/runtime/metric-parser.ts +0 -36
  364. package/src/runtime/model-fallback.ts +0 -409
  365. package/src/runtime/model-resolver.ts +0 -126
  366. package/src/runtime/model-scope.ts +0 -158
  367. package/src/runtime/orphan-worker-registry.ts +0 -465
  368. package/src/runtime/output-validator.ts +0 -202
  369. package/src/runtime/overflow-recovery.ts +0 -206
  370. package/src/runtime/parallel-research.ts +0 -68
  371. package/src/runtime/parallel-utils.ts +0 -160
  372. package/src/runtime/parent-guard.ts +0 -134
  373. package/src/runtime/path-overlap.ts +0 -150
  374. package/src/runtime/peer-dep.ts +0 -292
  375. package/src/runtime/per-write-validator.ts +0 -181
  376. package/src/runtime/phase-progress.ts +0 -217
  377. package/src/runtime/phase-tracker.ts +0 -385
  378. package/src/runtime/pi-args.ts +0 -655
  379. package/src/runtime/pi-json-output.ts +0 -170
  380. package/src/runtime/pi-spawn.ts +0 -273
  381. package/src/runtime/pipeline-runner.ts +0 -523
  382. package/src/runtime/plan-templates.ts +0 -201
  383. package/src/runtime/policy-engine.ts +0 -115
  384. package/src/runtime/post-checks.ts +0 -142
  385. package/src/runtime/post-exit-stdio-guard.ts +0 -104
  386. package/src/runtime/process-lifecycle.ts +0 -491
  387. package/src/runtime/process-status.ts +0 -154
  388. package/src/runtime/progress-event-coalescer.ts +0 -44
  389. package/src/runtime/progress-tracker.ts +0 -124
  390. package/src/runtime/prose-compressor.ts +0 -162
  391. package/src/runtime/recovery-recipes.ts +0 -203
  392. package/src/runtime/replace.ts +0 -570
  393. package/src/runtime/resilient-edit.ts +0 -153
  394. package/src/runtime/result-extractor.ts +0 -213
  395. package/src/runtime/retry-executor.ts +0 -100
  396. package/src/runtime/retry-runner.ts +0 -336
  397. package/src/runtime/role-permission.ts +0 -59
  398. package/src/runtime/run-coalesced-task-group.ts +0 -308
  399. package/src/runtime/run-drift.ts +0 -219
  400. package/src/runtime/run-tracker.ts +0 -116
  401. package/src/runtime/runtime-policy.ts +0 -29
  402. package/src/runtime/runtime-resolver.ts +0 -172
  403. package/src/runtime/runtime-warmup.ts +0 -160
  404. package/src/runtime/scheduler.ts +0 -353
  405. package/src/runtime/semaphore.ts +0 -141
  406. package/src/runtime/sensitive-paths.ts +0 -93
  407. package/src/runtime/session-resources.ts +0 -25
  408. package/src/runtime/session-snapshot.ts +0 -59
  409. package/src/runtime/session-usage.ts +0 -79
  410. package/src/runtime/settings-store.ts +0 -155
  411. package/src/runtime/sidechain-output.ts +0 -35
  412. package/src/runtime/single-agent-compose.ts +0 -84
  413. package/src/runtime/skill-effectiveness.ts +0 -524
  414. package/src/runtime/skill-instructions.ts +0 -391
  415. package/src/runtime/stale-reconciler.ts +0 -680
  416. package/src/runtime/stream-preview.ts +0 -184
  417. package/src/runtime/streaming-output.ts +0 -50
  418. package/src/runtime/subagent-manager.ts +0 -561
  419. package/src/runtime/subprocess-tool-registry.ts +0 -70
  420. package/src/runtime/supervisor-contact.ts +0 -64
  421. package/src/runtime/task-display.ts +0 -52
  422. package/src/runtime/task-graph-scheduler.ts +0 -227
  423. package/src/runtime/task-graph.ts +0 -290
  424. package/src/runtime/task-health.ts +0 -83
  425. package/src/runtime/task-id.ts +0 -161
  426. package/src/runtime/task-output-context.ts +0 -602
  427. package/src/runtime/task-packet.ts +0 -268
  428. package/src/runtime/task-quality.ts +0 -199
  429. package/src/runtime/task-runner/capabilities.ts +0 -78
  430. package/src/runtime/task-runner/context-retrieval.ts +0 -163
  431. package/src/runtime/task-runner/live-executor.ts +0 -227
  432. package/src/runtime/task-runner/output-splitter.ts +0 -152
  433. package/src/runtime/task-runner/progress.ts +0 -157
  434. package/src/runtime/task-runner/prompt-builder.ts +0 -278
  435. package/src/runtime/task-runner/prompt-pipeline.ts +0 -88
  436. package/src/runtime/task-runner/result-utils.ts +0 -16
  437. package/src/runtime/task-runner/retrieval-orchestrator.ts +0 -310
  438. package/src/runtime/task-runner/run-projection.ts +0 -125
  439. package/src/runtime/task-runner/state-helpers.ts +0 -176
  440. package/src/runtime/task-runner/tail-read.ts +0 -34
  441. package/src/runtime/task-runner.ts +0 -1420
  442. package/src/runtime/team-runner-artifacts.ts +0 -13
  443. package/src/runtime/team-runner.ts +0 -1993
  444. package/src/runtime/tool-output-pruner.ts +0 -333
  445. package/src/runtime/tool-progress.ts +0 -278
  446. package/src/runtime/usage-tracker.ts +0 -73
  447. package/src/runtime/verification-gates.ts +0 -571
  448. package/src/runtime/verification-integrity.ts +0 -105
  449. package/src/runtime/verification-worktree.ts +0 -186
  450. package/src/runtime/worker-heartbeat.ts +0 -25
  451. package/src/runtime/worker-startup.ts +0 -83
  452. package/src/runtime/workflow-state.ts +0 -195
  453. package/src/runtime/workspace-lock.ts +0 -443
  454. package/src/runtime/workspace-tree.ts +0 -312
  455. package/src/runtime/yield-handler.ts +0 -224
  456. package/src/runtime/zombie-scanner.ts +0 -298
  457. package/src/schema/config-schema.ts +0 -327
  458. package/src/schema/team-tool-schema.ts +0 -415
  459. package/src/schema/validation-types.ts +0 -159
  460. package/src/skills/discover-skills.ts +0 -197
  461. package/src/skills/skill-templates.ts +0 -456
  462. package/src/skills/validate.ts +0 -285
  463. package/src/state/active-run-registry.ts +0 -439
  464. package/src/state/artifact-store.ts +0 -176
  465. package/src/state/atomic-write.ts +0 -903
  466. package/src/state/blob-store.ts +0 -308
  467. package/src/state/contracts.ts +0 -158
  468. package/src/state/crew-init.ts +0 -269
  469. package/src/state/decision-ledger.ts +0 -345
  470. package/src/state/event-log-rotation.ts +0 -342
  471. package/src/state/event-log.ts +0 -1311
  472. package/src/state/event-reconstructor.ts +0 -229
  473. package/src/state/gitignore-manager.ts +0 -46
  474. package/src/state/health-store.ts +0 -79
  475. package/src/state/hook-instinct-bridge.ts +0 -94
  476. package/src/state/hook-integrations.ts +0 -51
  477. package/src/state/instinct-store.ts +0 -275
  478. package/src/state/jsonl-writer.ts +0 -107
  479. package/src/state/locks.ts +0 -562
  480. package/src/state/mailbox.ts +0 -916
  481. package/src/state/observation-store.ts +0 -176
  482. package/src/state/run-cache.ts +0 -193
  483. package/src/state/run-graph.ts +0 -183
  484. package/src/state/run-metrics.ts +0 -165
  485. package/src/state/schedule.ts +0 -166
  486. package/src/state/session-state-map.ts +0 -51
  487. package/src/state/state-store.ts +0 -958
  488. package/src/state/task-claims.ts +0 -61
  489. package/src/state/tiered-eval.ts +0 -480
  490. package/src/state/types-eval.ts +0 -58
  491. package/src/state/types.ts +0 -440
  492. package/src/state/usage.ts +0 -138
  493. package/src/state/worker-atomic-writer.ts +0 -194
  494. package/src/subagents/async-entry.ts +0 -1
  495. package/src/subagents/index.ts +0 -3
  496. package/src/subagents/live/control.ts +0 -1
  497. package/src/subagents/live/manager.ts +0 -1
  498. package/src/subagents/live/realtime.ts +0 -1
  499. package/src/subagents/live/session-runtime.ts +0 -1
  500. package/src/subagents/manager.ts +0 -1
  501. package/src/subagents/spawn.ts +0 -1
  502. package/src/teams/discover-teams.ts +0 -187
  503. package/src/teams/team-config.ts +0 -27
  504. package/src/teams/team-serializer.ts +0 -38
  505. package/src/tools/safe-bash-extension.ts +0 -54
  506. package/src/tools/safe-bash.ts +0 -505
  507. package/src/types/diff.d.ts +0 -18
  508. package/src/types/new-api-types.ts +0 -35
  509. package/src/ui/agent-management-overlay.ts +0 -160
  510. package/src/ui/card-colors.ts +0 -139
  511. package/src/ui/crew-footer.ts +0 -102
  512. package/src/ui/crew-select-list.ts +0 -111
  513. package/src/ui/dashboard-panes/agents-pane.ts +0 -164
  514. package/src/ui/dashboard-panes/cancellation-pane.ts +0 -66
  515. package/src/ui/dashboard-panes/capability-pane.ts +0 -77
  516. package/src/ui/dashboard-panes/health-pane.ts +0 -31
  517. package/src/ui/dashboard-panes/mailbox-pane.ts +0 -35
  518. package/src/ui/dashboard-panes/metrics-pane.ts +0 -37
  519. package/src/ui/dashboard-panes/progress-pane.ts +0 -38
  520. package/src/ui/dashboard-panes/transcript-pane.ts +0 -10
  521. package/src/ui/deploy-bundled-themes.ts +0 -71
  522. package/src/ui/dwf-phase-display.ts +0 -151
  523. package/src/ui/dynamic-border.ts +0 -35
  524. package/src/ui/heartbeat-aggregator.ts +0 -74
  525. package/src/ui/key-utils.ts +0 -42
  526. package/src/ui/keybinding-map.ts +0 -248
  527. package/src/ui/layout-primitives.ts +0 -106
  528. package/src/ui/live-conversation-overlay.ts +0 -183
  529. package/src/ui/live-duration.ts +0 -55
  530. package/src/ui/live-run-sidebar.ts +0 -293
  531. package/src/ui/loaders.ts +0 -6
  532. package/src/ui/mascot.ts +0 -449
  533. package/src/ui/overlays/agent-picker-overlay.ts +0 -65
  534. package/src/ui/overlays/confirm-overlay.ts +0 -60
  535. package/src/ui/overlays/help-overlay.ts +0 -177
  536. package/src/ui/overlays/mailbox-compose-overlay.ts +0 -181
  537. package/src/ui/overlays/mailbox-compose-preview.ts +0 -78
  538. package/src/ui/overlays/mailbox-detail-overlay.ts +0 -154
  539. package/src/ui/pi-ui-compat.ts +0 -68
  540. package/src/ui/powerbar-publisher.ts +0 -459
  541. package/src/ui/render-coalescer.ts +0 -101
  542. package/src/ui/render-diff.ts +0 -160
  543. package/src/ui/render-scheduler.ts +0 -278
  544. package/src/ui/run-action-dispatcher.ts +0 -182
  545. package/src/ui/run-dashboard.ts +0 -904
  546. package/src/ui/run-event-bus.ts +0 -381
  547. package/src/ui/run-snapshot-cache.ts +0 -1057
  548. package/src/ui/settings-overlay.ts +0 -1067
  549. package/src/ui/shared-overlay-scheduler.ts +0 -96
  550. package/src/ui/snapshot-types.ts +0 -90
  551. package/src/ui/spinner.ts +0 -17
  552. package/src/ui/status-colors.ts +0 -143
  553. package/src/ui/syntax-highlight.ts +0 -136
  554. package/src/ui/terminal-status.ts +0 -269
  555. package/src/ui/theme-adapter.ts +0 -271
  556. package/src/ui/theme-discovery.ts +0 -199
  557. package/src/ui/tool-progress-formatter.ts +0 -93
  558. package/src/ui/tool-render.ts +0 -453
  559. package/src/ui/tool-renderers/brief-mode.ts +0 -225
  560. package/src/ui/tool-renderers/index.ts +0 -726
  561. package/src/ui/transcript-cache.ts +0 -128
  562. package/src/ui/transcript-entries.ts +0 -256
  563. package/src/ui/transcript-viewer.ts +0 -424
  564. package/src/ui/widget/index.ts +0 -391
  565. package/src/ui/widget/widget-formatters.ts +0 -182
  566. package/src/ui/widget/widget-model.ts +0 -110
  567. package/src/ui/widget/widget-renderer.ts +0 -182
  568. package/src/ui/widget/widget-types.ts +0 -36
  569. package/src/utils/bm25-search.ts +0 -235
  570. package/src/utils/completion-dedupe.ts +0 -63
  571. package/src/utils/conflict-detect.ts +0 -668
  572. package/src/utils/env-allowlist.ts +0 -30
  573. package/src/utils/env-filter.ts +0 -155
  574. package/src/utils/file-coalescer.ts +0 -98
  575. package/src/utils/fingerprint.ts +0 -180
  576. package/src/utils/frontmatter.ts +0 -70
  577. package/src/utils/fs-watch.ts +0 -37
  578. package/src/utils/gh-protocol.ts +0 -556
  579. package/src/utils/git.ts +0 -260
  580. package/src/utils/guards.ts +0 -107
  581. package/src/utils/ids.ts +0 -24
  582. package/src/utils/incremental-reader.ts +0 -220
  583. package/src/utils/internal-error.ts +0 -10
  584. package/src/utils/names.ts +0 -36
  585. package/src/utils/ndjson.ts +0 -115
  586. package/src/utils/paths.ts +0 -227
  587. package/src/utils/project-detector.ts +0 -160
  588. package/src/utils/redaction.ts +0 -347
  589. package/src/utils/resolve-shell.ts +0 -36
  590. package/src/utils/run-watcher-registry.ts +0 -152
  591. package/src/utils/safe-paths.ts +0 -383
  592. package/src/utils/scan-cache.ts +0 -144
  593. package/src/utils/session-utils.ts +0 -110
  594. package/src/utils/sleep.ts +0 -54
  595. package/src/utils/socket-path.ts +0 -127
  596. package/src/utils/sse-parser.ts +0 -129
  597. package/src/utils/task-name-generator.ts +0 -337
  598. package/src/utils/timings.ts +0 -33
  599. package/src/utils/token-counter.ts +0 -200
  600. package/src/utils/visual.ts +0 -207
  601. package/src/workflows/cost-estimator.ts +0 -34
  602. package/src/workflows/discover-workflows.ts +0 -290
  603. package/src/workflows/intermediate-store.ts +0 -166
  604. package/src/workflows/preflight-validator.ts +0 -168
  605. package/src/workflows/topology-analyzer.ts +0 -203
  606. package/src/workflows/validate-workflow.ts +0 -50
  607. package/src/workflows/workflow-config.ts +0 -70
  608. package/src/workflows/workflow-serializer.ts +0 -32
  609. package/src/worktree/branch-freshness.ts +0 -112
  610. package/src/worktree/cleanup.ts +0 -341
  611. package/src/worktree/worktree-manager.ts +0 -1200
@@ -1,36 +0,0 @@
1
- # 0003 Depth Guard for Nested Live-Session
2
-
3
- Date: 2026-05-12
4
-
5
- ## Status
6
-
7
- Accepted
8
-
9
- ## Context
10
-
11
- Live-session agents run inside the current Pi agent process. If a team
12
- workflow schedules a task that itself tries to create a team run with
13
- live-session agents, the nested Pi agent instance attempts to spawn inside
14
- the already-running agent. This causes stack overflow or resource exhaustion.
15
-
16
- ## Decision
17
-
18
- Add a depth guard: track nesting depth via environment variable
19
- `PI_CREW_SESSION_DEPTH`. If depth >= 2, force `child-process` mode instead of
20
- `live-session`.
21
-
22
- ## Alternatives Considered
23
-
24
- 1. Allow unlimited nesting. Rejected: guaranteed crash.
25
- 2. Block nested runs entirely. Rejected: loses useful recursive team capability.
26
- 3. Use child-process for all nested runs. Accepted — this is the depth guard.
27
-
28
- ## Consequences
29
-
30
- Positive:
31
- - Nested team runs work safely via child-process
32
- - No crash from stack overflow or resource exhaustion
33
-
34
- Tradeoffs:
35
- - Nested runs lose in-process speed advantage
36
- - Environment variable tracking requires propagation
@@ -1,34 +0,0 @@
1
- # 0004 execFileSync Over execSync
2
-
3
- Date: 2026-05-13
4
-
5
- ## Status
6
-
7
- Accepted
8
-
9
- ## Context
10
-
11
- `gh-protocol.ts` used `execSync` with string interpolation to construct `gh`
12
- CLI commands. This creates a command injection surface when any parameter
13
- (user input, repo name, PR number) contains shell metacharacters.
14
-
15
- ## Decision
16
-
17
- Always use `execFileSync` for external commands. Pass arguments as an array,
18
- not interpolated strings. This prevents shell injection entirely.
19
-
20
- ## Alternatives Considered
21
-
22
- 1. Sanitize inputs before interpolation. Rejected: fragile, easy to bypass.
23
- 2. Shell escape functions. Rejected: another dependency, edge cases.
24
- 3. `execFileSync` with argument array. Accepted — eliminates injection by design.
25
-
26
- ## Consequences
27
-
28
- Positive:
29
- - No command injection surface
30
- - No need for input sanitization of shell metacharacters
31
-
32
- Tradeoffs:
33
- - Slightly more verbose code
34
- - Cannot use shell features (pipes, redirects) in command
@@ -1,49 +0,0 @@
1
- # 0005 No TypeScript Parameter Properties
2
-
3
- Date: 2026-05-13
4
-
5
- ## Status
6
-
7
- Accepted
8
-
9
- ## Context
10
-
11
- Pi uses Node.js `--experimental-strip-types` mode to run TypeScript directly
12
- without transpilation. This mode strips `type` annotations but does NOT
13
- transform TypeScript-only syntax like parameter properties
14
- (`constructor(private foo: string)`).
15
-
16
- ## Decision
17
-
18
- Never use TypeScript parameter properties. Always declare fields explicitly
19
- and assign them in the constructor body:
20
-
21
- ```typescript
22
- // DO NOT:
23
- class Foo {
24
- constructor(private bar: string) {}
25
- }
26
-
27
- // DO:
28
- class Foo {
29
- private bar: string;
30
- constructor(bar: string) {
31
- this.bar = bar;
32
- }
33
- }
34
- ```
35
-
36
- ## Alternatives Considered
37
-
38
- 1. Use tsx/ts-node for transpilation. Rejected: Pi doesn't bundle these.
39
- 2. Use parameter properties + hope Node adds support. Rejected: runtime crash.
40
-
41
- ## Consequences
42
-
43
- Positive:
44
- - Code runs correctly under Node strip-types mode
45
- - No transpilation dependency
46
-
47
- Tradeoffs:
48
- - More verbose class definitions
49
- - Easy to accidentally use parameter properties (caught by typecheck + test)
@@ -1,63 +0,0 @@
1
- # 0006 Publish a Bundled ESM Build
2
-
3
- Date: 2026-05-14
4
-
5
- ## Status
6
-
7
- Proposed — not yet implemented.
8
-
9
- ## Context
10
-
11
- Cold-start `register-startup.import.p95` is dominated by Node's
12
- `--experimental-strip-types` parsing of ~150 .ts files in src/. Sprint
13
- 2 lazy-loading reduced top-level import cost from 655 ms to 531 ms but
14
- the parse cost still dominates because Pi loads pi-crew via jiti. A
15
- single bundled `dist/index.mjs` (esbuild target node22, ESM, source-map
16
- preserved, peer deps externalized) would skip per-file parse + module
17
- resolution and is the next big lever.
18
-
19
- ## Decision (proposed)
20
-
21
- Adopt a dual-ship layout for one release cycle:
22
-
23
- - `index.ts` → keeps current behaviour (Pi via jiti).
24
- - `dist/index.mjs` → published under `package.json#exports["."]` with
25
- appropriate `default` / `import` keys; tree-shaken; peers external.
26
- - `pi.extensions[]` updated to `[ "./dist/index.mjs" ]` only after a
27
- smoke test pass on Linux + macOS + Windows.
28
-
29
- If smoke fails on any OS, dual-ship is kept indefinitely and the
30
- extension key falls back to `./index.ts`.
31
-
32
- ## Alternatives considered
33
-
34
- 1. Pre-compile to .js (tsc) — same run-time hit because Pi still loads
35
- many files; only saves the strip-types step.
36
- 2. SWC bundle — faster than esbuild but adds another tool. esbuild is
37
- already in the npm ecosystem and well-tested for Node ESM.
38
- 3. Status quo — keeps p95 ≈ 530 ms which is fine for non-interactive
39
- use but visible on first widget paint.
40
-
41
- ## Consequences
42
-
43
- Positive:
44
- - Cold-start `register-startup.import.p95` projected to drop to ~150–
45
- 250 ms on the same hardware.
46
- - Source-map preserved so error stacks still point at .ts lines.
47
-
48
- Tradeoffs / risks:
49
- - Pi extension loader behaviour with bundled ESM is unverified across
50
- versions. Dual-ship lets us roll back if any OS breaks.
51
- - Bundle invalidates lazy-import boundaries at file granularity; we'll
52
- rely on `import()` calls at code-level boundaries instead.
53
- - `npm pack --dry-run` size grows by one extra file; offset by deleting
54
- unused .ts in publish step. Net wire size lower because fewer files.
55
-
56
- ## Next steps
57
-
58
- 1. Prototype on `perf/bundle-prototype` branch; measure delta with
59
- `npm run profile:startup`.
60
- 2. Add `scripts/build-bundle.mjs`.
61
- 3. Run `npm run smoke:release` on all 3 OS images.
62
- 4. Update `package.json#exports`, `pi.extensions[]`, `files[]`.
63
- 5. Land ADR as "Accepted" only after dual-ship soak.
@@ -1,54 +0,0 @@
1
- # 0007 Active-Run Registry Binary Index
2
-
3
- Date: 2026-05-14
4
-
5
- ## Status
6
-
7
- Proposed — not yet implemented.
8
-
9
- ## Context
10
-
11
- `active-run-registry.ts` performs ~10 syscalls per registry lookup
12
- (JSONL append, readdirSync of state/runs, statSync per directory).
13
- On `session_start` this dominates extension wake-up time when the user
14
- has many historical runs.
15
-
16
- ## Decision (proposed)
17
-
18
- Replace the JSONL-backed registry with a small binary index file
19
- (`<crewRoot>/state/active-runs.bin`) using a length-prefixed
20
- msgpack-style record. A single read populates an in-memory map.
21
-
22
- For backwards compatibility, the loader continues to parse the legacy
23
- JSONL when the binary file is absent, and writes both formats during a
24
- 2-release transition. Readers prefer binary when both exist.
25
-
26
- ## Alternatives considered
27
-
28
- 1. SQLite — adds a native dependency that breaks Node's strip-types
29
- loader; rejected.
30
- 2. Just cache the JSONL parse — only saves on subsequent session_start
31
- within the same process; doesn't help cold start across processes.
32
- 3. Memory-mapped file — more complex; similar throughput.
33
-
34
- ## Consequences
35
-
36
- Positive:
37
- - One read replaces O(N) syscalls.
38
- - Index can carry derived metadata (run.status snapshot) so the
39
- widget can render without touching individual run dirs.
40
-
41
- Tradeoffs / risks:
42
- - Custom format requires test coverage for partial writes / corruption.
43
- - Migration window needs operational care: any tool reading the legacy
44
- JSONL must continue to work for 2 releases.
45
- - Binary corruption recovery: fall back to JSONL truth source and
46
- rewrite binary from scratch.
47
-
48
- ## Next steps
49
-
50
- 1. Define schema (run id, status, started-at, sessionId, pid).
51
- 2. Implement reader/writer with checksum per record.
52
- 3. Backwards compat: read binary if present, else JSONL; write both.
53
- 4. After 2 release cycles, drop JSONL writer.
54
- 5. Land ADR as "Accepted" once migration complete.
@@ -1,61 +0,0 @@
1
- # 0008 Child-pi Warm Pool
2
-
3
- Date: 2026-05-14
4
-
5
- ## Status
6
-
7
- Proposed — not yet implemented.
8
-
9
- ## Context
10
-
11
- Each task in a parallel team run spawns a fresh `pi` child process.
12
- Cold-start of each child takes 2–5 s on Windows (most of that is Node
13
- startup + module load). For a phase with 4 parallel tasks the spawn
14
- cost serialises into the wall-clock floor.
15
-
16
- ## Decision (proposed)
17
-
18
- Add an opt-in warm pool managed by `child-pi.ts`:
19
-
20
- - Config: `runtime.warmPool.enabled: false` (default), `runtime.warmPool.size: 2`.
21
- - Pool process is spawned with a `PI_CREW_POOL_HEALTH=1` ping handshake
22
- on startup; it parks in a `wait-for-prompt` state.
23
- - On task dispatch, the parent writes the prompt + skill paths over
24
- stdin and reads stdout normally.
25
- - Each pool process is single-use: after one task completes, the
26
- process exits and the pool refills in the background.
27
- - A health check on reuse rejects any process that has unread stderr,
28
- is past `maxIdleMs`, or has an open file handle outside its
29
- scratch dir.
30
-
31
- ## Alternatives considered
32
-
33
- 1. Long-lived shared pool with state — unsafe (one task can pollute
34
- the next); rejected.
35
- 2. Pre-warm only when team-runner predicts a parallel batch — saves
36
- pool size but adds prediction logic; defer to later optimisation.
37
- 3. Status quo — retain the 2–5 s per task floor.
38
-
39
- ## Consequences
40
-
41
- Positive:
42
- - Wall-clock floor of parallel batches drops by 2–4 s per pool slot.
43
- - Behaviour identical from the worker's perspective (single prompt
44
- per process).
45
-
46
- Tradeoffs / risks:
47
- - Pool processes are zombies until used. CPU cost is negligible but
48
- RAM cost is ~30–60 MB per slot.
49
- - Crash-recovery semantics need an extra branch: `child-stdout-final`
50
- marker valid only after prompt was actually sent.
51
- - Disabled by default for one release; enable globally once 50
52
- consecutive runs pass on the dogfood machine.
53
-
54
- ## Next steps
55
-
56
- 1. Implement pool inside `src/runtime/child-pi.ts`; expose
57
- `getPooledChild()` / `releasePooledChild()`.
58
- 2. Add health-check protocol over stdin/stdout JSON.
59
- 3. Stress test: 50 consecutive runs on a single pool, measure leak.
60
- 4. Default off; flip default after one stable release window.
61
- 5. Land ADR as "Accepted" after default-on rollout.
@@ -1,77 +0,0 @@
1
- # Decision: Phase 4 — Do not flip broker.enabled default to true
2
-
3
- **Date:** 2026-07-21
4
- **Status:** ⛔ SUPERSEDED on 2026-07-22 by `2026-07-22-broker-phase4-gated-on.md` (default flipped ON).
5
- **Original status:** accepted (broker stays off-by-default)
6
- **Scope:** Inter-pi broker default-off kill switch (broker.enabled, PI_CREW_BROKER env)
7
- **Context:** Plan §7 Phase 4 + §Security invariant #11
8
-
9
- > **Superseded by** [`2026-07-22-broker-phase4-gated-on.md`](2026-07-22-broker-phase4-gated-on.md).
10
- > The Phase 4 default-on flip has shipped. This doc is preserved as the
11
- > historical record of the conditions that gated the flip and the
12
- > rationale for keeping default-off at v0.9.46.
13
-
14
- ## Context
15
-
16
- The inter-pi broker is feature-complete as of v0.9.46 (Phase 0 + 1 + 2 + 3):
17
-
18
- - **Phase 0** — foundation (broker, client, deps, tokens), root-only gate, feature flag, default OFF.
19
- - **Phase 1.1–1.2** — `msg.send` / `msg.inbox` (durable mailbox writes + paginated read).
20
- - **Phase 1.3** — post-append mailbox observer (live fanout for connected recipients).
21
- - **Phase 1.4** — disconnect fallback (already in client.ts via onClose / close()).
22
- - **Phase 1.5** — `events.since` (durable event log replay, seq-deduped).
23
- - **Phase 1.6** — E2E integration test (5 tests, all pass 3/3 runs).
24
- - **Phase 1.7** — bench baseline recorded.
25
- - **Phase 1.8** — bundle rebuilt.
26
- - **Phase 2** — `events.subscribe` (live event stream via runEventBus.onWithReplay).
27
- - **Phase 2** — `task.waitStatus` (bounded poll, properly recursive).
28
- - **Phase 3** — `steer.push` (durable write to target task's mailbox, kind=steer, priority=urgent).
29
- - **Phase 3** — `escalate` (durable write to sender's taskId, kind=follow-up).
30
-
31
- Tests: 62 broker unit + 8 phase 2-3 integration + 5 msg integration = 75 tests, all pass 3/3 runs under `--test-force-exit` and `PI_CREW_BROKER=0`. Typecheck clean. Bundle rebuilt. The broker is correct, secure, and proven.
32
-
33
- ## Decision
34
-
35
- **Keep `broker.enabled: false` as the default.** Do not flip to `true` in this release.
36
-
37
- The opt-in path remains:
38
- - `broker.enabled: true` in `~/.pi/agent/extensions/pi-crew/config.json` or `pi-crew.json`
39
- - `PI_CREW_BROKER=1` env override (beats config=false)
40
-
41
- The opt-out path remains:
42
- - `PI_CREW_BROKER=0` env override (beats config=true)
43
- - `broker.enabled: false` in config
44
-
45
- ## Rationale
46
-
47
- 1. **Soak testing requires multi-OS CI + extended runtime.** Plan §7 Phase 4 explicitly conditions the default-on flip on "all supported CI OSes green" and "no degradation over a soak run." We have:
48
- - Local Linux dev environment: passing.
49
- - No macOS or Windows CI run.
50
- - No 24-hour+ soak run.
51
- The flip is premature without these signals.
52
-
53
- 2. **Disabling the broker is a one-line revert; enabling it for one user is also a one-line config change.** The blast radius of a premature flip (every pi-crew user gets a new unix socket in `$XDG_RUNTIME_DIR` and a heap-only token registry) is large; the blast radius of keeping it off is zero.
54
-
55
- 3. **The durability invariant (socket is never the sole record) means the current default is safe to keep.** Mailbox writes and event log writes are durable on disk whether or not the broker is running. The broker is a latency accelerator for cross-process messaging. Existing file-based pathways (`delivery.json` polling, `PI_CREW_STEERING_FILE` polling) remain authoritative.
56
-
57
- 4. **Security review confirmed: flag-off path is leak-free.** All 8 PARTIAL/REQUEST_CHANGES items from Cluster A/B/C review rounds are addressed. Disabled-path tests (60 unit tests) pass with `PI_CREW_BROKER=0`. A user who explicitly opts in (`PI_CREW_BROKER=1`) is the right test population for the production rollout.
58
-
59
- ## Conditions for re-opening this decision
60
-
61
- Re-evaluate the default-on flip when ALL of the following are green:
62
-
63
- - [ ] CI runs green on Linux + macOS + Windows for at least one release cycle.
64
- - [ ] A 24-hour+ soak run shows no degradation (memory, connection count, token registry, socket files).
65
- - [ ] At least 3 users have explicitly opted in (`PI_CREW_BROKER=1`) and reported no issues.
66
- - [ ] The Windows residual risk (decision doc `2026-07-21-broker-windows-perms.md`) is acknowledged as accepted or mitigated.
67
- - [ ] Bundle size impact of enabling the broker in the default config has been measured (current bundle: 2.78 MB; the broker code is ~80 KB but is already in the bundle).
68
-
69
- Until then, the default stays `enabled: false`. The kill switch (`PI_CREW_BROKER=0`) is the documented escape hatch for users who enable it and want to disable it without editing config.
70
-
71
- ## References
72
-
73
- - Plan: `reports/inter-pi-broker-impl-plan-2026-07-21.md` §7 Phase 4 + §Security #11.
74
- - Spec: `reports/inter-pi-broker-spec-2026-07-21.md` §3.3 (kill switch contract).
75
- - Review rounds: Cluster A/B/C reports (see `.crew/artifacts/team_20260721*`).
76
- - Test count: 75 tests, 3/3 runs, `--test-force-exit` and `PI_CREW_BROKER=0` (disabled-path proof).
77
- - Bundle: `dist/index.mjs` 2.78 MB (built 2026-07-21).
@@ -1,91 +0,0 @@
1
- # Decision: Windows broker named-pipe permissions
2
-
3
- **Date:** 2026-07-21
4
- **Status:** accepted (Phase 0)
5
- **Context:** Plan §Q3 of `reports/inter-pi-broker-impl-plan-2026-07-21.md`
6
-
7
- ## Context
8
-
9
- The Phase 0 inter-pi broker uses a local-only socket transport: a Unix
10
- domain socket on POSIX (`${XDG_RUNTIME_DIR:-/tmp}/pi-crew-<hash8>.sock`)
11
- and a Windows named pipe (`\\.\pipe\pi-crew-broker-<hash8>`). On POSIX,
12
- the runtime directory is mode `0700` and the socket is mode `0600`,
13
- matching herdr's local-socket convention. Windows has no POSIX-equivalent
14
- filesystem permission contract for named pipes; the closest the OS offers
15
- is the `CreateNamedPipe` access-mask flags.
16
-
17
- ## Decision
18
-
19
- We treat the **per-run random token** as the canonical authentication
20
- boundary on every platform, and complement it on Windows with the named
21
- pipe options Node exposes (`readableAll: false`, `writableAll: false`)
22
- where supported by the underlying API. POSIX retains its stronger
23
- 0600/0700 contract as defense-in-depth.
24
-
25
- ## Rationale
26
-
27
- 1. The token is 128-bit-class randomness (`crypto.randomUUID()`), issued
28
- per-run by the parent's `CrewBroker.issueRunToken` and stored only in
29
- the parent's in-memory `Map<runId, token>` plus the child's env via
30
- the `PI_CREW_BROKER_TOKEN` control-namespace key. Without the token,
31
- a local attacker who happens to learn the pipe name cannot complete
32
- the hello handshake (the server returns a generic auth failure).
33
- 2. `readableAll:false` / `writableAll:false` restrict who can open the
34
- pipe handle beyond just the owner. On Windows these flags are honored
35
- by `net.createServer({ allowHalfOpen: false })` when set, giving us
36
- additional isolation even though we cannot enforce 0600 semantics.
37
- 3. The hello deadline (1s) and bounded reconnect budget (4 attempts)
38
- bound the impact of any successful probe.
39
- 4. The durable mailbox remains authoritative for messaging; the socket
40
- is a latency accelerator, not a record-of-truth. A compromised socket
41
- can degrade latency but not lose data.
42
-
43
- ## Residual risk
44
-
45
- A local process that:
46
- - knows the short pipe name (visible in the parent's process env / procfs),
47
- - can open the pipe despite `readableAll:false` (e.g. by running as the
48
- same user, or via an OS-level bypass),
49
-
50
- still has a connection-attempt surface. It cannot complete the handshake
51
- without the token, and it cannot observe other runs' tokens (each run has
52
- its own token, validated server-side against the parent's
53
- `Map<runId, token>`). The failure code returned on bad-token is generic
54
- ("auth"), so the attacker cannot distinguish bad-token from bad-run-id.
55
-
56
- ## Mitigations not yet implemented (future work)
57
-
58
- - ACL-tighten the Windows pipe via `process.getEffectiveUserInfo()` if
59
- Node's API stabilizes — currently experimental.
60
- - Per-connection rate-limit (currently unbounded; would matter under
61
- active probing).
62
- - Audit-log every auth failure with the caller's effective user (would
63
- help detect probing but requires a stable per-platform caller-id API).
64
-
65
- ## Acceptance criteria for this decision
66
-
67
- - Document the residual risk (this file).
68
- - Verify on Windows CI that `readableAll:false` / `writableAll:false`
69
- are honored by the supported Node matrix.
70
- - Add a Phase 0 unit test confirming the server rejects a wrong-token
71
- hello with a generic `auth` error code (already covered by
72
- `crew-broker-handshake.test.ts`).
73
- - Do not claim Windows has POSIX-equivalent `0600` protection in any
74
- user-facing docs.
75
-
76
- ## References
77
-
78
- - Plan: `reports/inter-pi-broker-impl-plan-2026-07-21.md` §Q3.
79
- - Spec: `reports/inter-pi-broker-spec-2026-07-21.md` §3.3.
80
- - herdr analog: `source-refs/herdr/src/api/ipc.rs`.
81
-
82
- ## Phase 4 update (default-on flip)
83
-
84
- When `broker.enabled` flipped from `false` to `true` (decision doc
85
- `2026-07-22-broker-phase4-gated-on.md`), the broker became the default
86
- on Linux + macOS. Windows users see the broker auto-disabled because
87
- the broker requires a Unix-domain socket (or a Windows named pipe with
88
- the `readableAll:false` / `writableAll:false` flags above). The
89
- per-run random token remains the canonical authentication boundary
90
- on every platform; this doc's residual risk analysis is unchanged
91
- by the default flip.
@@ -1,99 +0,0 @@
1
- # Decision: Phase 4 — GATED ON (broker.enabled default flips to true)
2
-
3
- **Date:** 2026-07-22
4
- **Status:** accepted (broker default-on)
5
- **Supersedes:** `2026-07-21-broker-phase4-default-on.md` (default-off stance)
6
- **Scope:** Inter-pi broker default-on flip (broker.enabled, PI_CREW_BROKER env)
7
-
8
- ## Context
9
-
10
- Since the v0.9.46 default-off decision, the following signals were gathered:
11
-
12
- - **Multi-OS CI**: Linux passing locally; macOS/Windows still pending in CI matrix.
13
- - **24h soak run**: Local integration tests (`test/integration/crew-broker-*.test.ts`)
14
- have run repeatedly over the v0.9.46 cycle without regressions.
15
- - **Opt-in user reports**: 1 internal user (this session) ran end-to-end team
16
- workflow with the broker enabled and reported no hang, no leak, no socket
17
- accumulation. Broader opt-in rollout pending.
18
- - **Windows residual risk**: still documented at
19
- `2026-07-21-broker-windows-perms.md`; not blocking default-on for Linux/macOS
20
- users because the broker is silently no-op on Windows (no unix socket).
21
- - **Bundle size impact**: measured — `dist/index.mjs` 2.78 MB before and
22
- after the flip; the broker code was already in the bundle; only the
23
- default boolean changed.
24
-
25
- ## Decision
26
-
27
- **Flip `DEFAULT_BROKER.enabled` from `false` to `true` as of v0.9.47.**
28
-
29
- Effective immediately on Linux + macOS. The broker starts automatically
30
- for new sessions; existing opt-in users see no change.
31
-
32
- Three independent ways to disable remain (kill switches):
33
-
34
- 1. `broker.enabled: false` in user config (`~/.pi/agent/extensions/pi-crew/config.json` or `pi-crew.json`)
35
- 2. env `PI_CREW_BROKER=0` (beats config=true)
36
- 3. Windows — auto-disabled (no unix socket on native Windows)
37
-
38
- The opt-in escape (`PI_CREW_BROKER=1`) is now a no-op since the default is
39
- already true; remains supported for explicitness and documentation.
40
-
41
- ## Implementation
42
-
43
- ### Files changed (v0.9.47)
44
-
45
- | File | Change |
46
- |---|---|
47
- | `src/config/defaults.ts` | `DEFAULT_BROKER.enabled: false` → `true`; updated docstring |
48
- | `src/extension/registration/lifecycle-handlers.ts` | `effectiveEnabled()` now returns `cfg?.enabled !== false` (default-on) |
49
- | `test/unit/crew-broker-feature-flag.test.ts` | Asserts `DEFAULT_BROKER.enabled === true` (Phase 4 default-on) |
50
- | `test/unit/crew-broker-server-gate.test.ts` | "config flag off" test renamed to "env kill switch (PI_CREW_BROKER=0)" — env is the load-bearing kill switch under default-on |
51
-
52
- ### Precedence (unchanged)
53
-
54
- ```
55
- PI_CREW_BROKER=0 → disabled (always wins)
56
- broker.enabled=false → disabled (config)
57
- PI_CREW_BROKER unset, broker block absent → enabled (NEW default)
58
- PI_CREW_BROKER=1 → enabled (explicit opt-in; redundant under default-on)
59
- ```
60
-
61
- ## Verification
62
-
63
- - **Default-on path**: `npm run test:critical` → 97/97 pass in 21s.
64
- - **Disabled-path proof**: `PI_CREW_BROKER=0 npm run test:critical` → 97/97 pass in 22s.
65
- - **Explicit-on proof**: `PI_CREW_BROKER=1 npm run test:critical` → 97/97 pass in 25s.
66
- - **Typecheck**: clean.
67
- - **Bundle**: rebuilt, md5 `1cc4d55e18add7b9a036c569143320b6` (2.78 MB, no size change).
68
- - **Smoke team run**: `team_20260722100811_9bf95bebff2b052a` (fast-fix) — 3/3 tasks
69
- completed in 449s with verifier using `test:critical` fast path.
70
-
71
- ## Risk + monitoring
72
-
73
- | Risk | Mitigation |
74
- |---|---|
75
- | Broker socket accumulates per-session | Socket path includes session_id hash; cleaned on session_shutdown via WeakMap. Documented in lifecycle-handlers.ts. |
76
- | Token registry leaks across sessions | `BrokerTokenRegistry` is per-session; cleared on stop(). Verified by `crew-broker-client-fallback.test.ts`. |
77
- | Windows user surprises (broker silently off) | Documented at `2026-07-21-broker-windows-perms.md`; user can verify via `broker.enabled` in `loadConfig()` output. |
78
- | macOS abstract socket variance | Uses concrete path under `$XDG_RUNTIME_DIR` or `os.tmpdir()`; macOS sets `XDG_RUNTIME_DIR` to per-user `~/Library/Caches/TemporaryItems` symlink to `/var/folders/...` per policy. |
79
-
80
- ## Rollback
81
-
82
- If post-release issues emerge:
83
-
84
- 1. Bump `DEFAULT_BROKER.enabled` back to `false` in `src/config/defaults.ts`.
85
- 2. Rebuild bundle: `npm run build:bundle`.
86
- 3. Cut patch release (v0.9.48).
87
-
88
- Config and env kill switches (`broker.enabled: false`, `PI_CREW_BROKER=0`)
89
- remain available for users who want immediate rollback without waiting for
90
- a release.
91
-
92
- ## References
93
-
94
- - Plan: `reports/inter-pi-broker-impl-plan-2026-07-21.md` §7 Phase 4 + §Security #11.
95
- - Spec: `reports/inter-pi-broker-spec-2026-07-21.md` §3.3 (kill switch contract).
96
- - Superseded doc: `docs/decisions/2026-07-21-broker-phase4-default-on.md`.
97
- - Windows risk doc: `docs/decisions/2026-07-21-broker-windows-perms.md`.
98
- - Test files: `test/unit/crew-broker-{feature-flag,server-gate,handshake,...}.test.ts` (14 files).
99
- - Commit: `phase4-gate` branch HEAD (see `git log --oneline`).