pi-crew 0.2.3 → 0.2.5

package/src/runtime/capability-inventory.ts

@@ -1,116 +1,116 @@
-import type { AgentConfig, ResourceSource } from "../agents/agent-config.ts";
-import { discoverAgents } from "../agents/discover-agents.ts";
-import { discoverTeams } from "../teams/discover-teams.ts";
-import { discoverWorkflows } from "../workflows/discover-workflows.ts";
-import { discoverSkills } from "../skills/discover-skills.ts";
-import type { PiTeamsConfig } from "../config/config.ts";
-
-export type CapabilityKind = "team" | "workflow" | "agent" | "skill" | "tool" | "runtime";
-export type CapabilitySource = "builtin" | "project" | "user" | "package" | "git";
-export type CapabilityState = "active" | "disabled" | "shadowed" | "missing";
-
-export interface CapabilityItem {
-	id: string;
-	kind: CapabilityKind;
-	name: string;
-	description: string;
-	source: CapabilitySource;
-	path?: string;
-	state: CapabilityState;
-	disabledReason?: string;
-	shadowedBy?: string;
-}
-
-function normalizeAgents(agents: AgentConfig[], source: CapabilitySource, disabledIds: Set<string>): CapabilityItem[] {
-	return agents.map((agent) => {
-		const id = `agent:${agent.name}`;
-		const configDisabled = disabledIds.has(id);
-		const agentDisabled = agent.disabled || configDisabled;
-		return {
-			id,
-			kind: "agent" as const,
-			name: agent.name,
-			description: agent.description,
-			source,
-			path: agent.filePath,
-			state: agentDisabled ? "disabled" : "active",
-			disabledReason: configDisabled ? "disabled by policy" : agent.disabled ? "disabled in config" : undefined,
-		};
-	});
-}
-
-function normalizeSkills(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
-	const skills = discoverSkills(cwd);
-	return skills.map((skill) => {
-		const id = `skill:${skill.name}`;
-		const configDisabled = disabledIds.has(id);
-		return {
-			id,
-			kind: "skill" as const,
-			name: skill.name,
-			description: skill.description,
-			source: skill.source as CapabilitySource,
-			path: skill.path,
-			state: configDisabled ? "disabled" : "active",
-			disabledReason: configDisabled ? "disabled by policy" : undefined,
-		};
-	});
-}
-
-function normalizeTeams(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
-	const result = discoverTeams(cwd);
-	return [...result.builtin, ...result.user, ...result.project].map((team) => {
-		const id = `team:${team.name}`;
-		const configDisabled = disabledIds.has(id);
-		return {
-			id,
-			kind: "team" as const,
-			name: team.name,
-			description: team.description,
-			source: team.source as CapabilitySource,
-			path: team.filePath,
-			state: configDisabled ? "disabled" : "active",
-			disabledReason: configDisabled ? "disabled by policy" : undefined,
-		};
-	});
-}
-
-function normalizeWorkflows(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
-	const result = discoverWorkflows(cwd);
-	return [...result.builtin, ...result.user, ...result.project].map((workflow) => {
-		const id = `workflow:${workflow.name}`;
-		const configDisabled = disabledIds.has(id);
-		return {
-			id,
-			kind: "workflow" as const,
-			name: workflow.name,
-			description: workflow.description,
-			source: workflow.source as CapabilitySource,
-			path: workflow.filePath,
-			state: configDisabled ? "disabled" : "active",
-			disabledReason: configDisabled ? "disabled by policy" : undefined,
-		};
-	});
-}
-
-export function buildCapabilityInventory(cwd: string, config?: PiTeamsConfig): CapabilityItem[] {
-	const disabledIds = new Set<string>(config?.policy?.disabledCapabilities ?? []);
-	const agents = discoverAgents(cwd);
-	const items = [
-		...normalizeTeams(cwd, disabledIds),
-		...normalizeWorkflows(cwd, disabledIds),
-		...normalizeAgents([...agents.builtin, ...agents.user, ...agents.project], "builtin", disabledIds),
-		...normalizeSkills(cwd, disabledIds),
-	];
-
-	// Mark shadowed resources: project/user items with same kind:name as a builtin
-	const builtinNames = new Set(items.filter((item) => item.source === "builtin" || item.source === "package").map((item) => `${item.kind}:${item.name}`));
-	for (const item of items) {
-		if (item.source !== "builtin" && item.source !== "package" && builtinNames.has(`${item.kind}:${item.name}`)) {
-			item.state = "shadowed";
-			item.shadowedBy = `builtin:${item.kind}:${item.name}`;
-		}
-	}
-
-	return items.sort((a, b) => a.id.localeCompare(b.id));
-}
+import type { AgentConfig, ResourceSource } from "../agents/agent-config.ts";
+import { discoverAgents } from "../agents/discover-agents.ts";
+import { discoverTeams } from "../teams/discover-teams.ts";
+import { discoverWorkflows } from "../workflows/discover-workflows.ts";
+import { discoverSkills } from "../skills/discover-skills.ts";
+import type { PiTeamsConfig } from "../config/config.ts";
+
+export type CapabilityKind = "team" | "workflow" | "agent" | "skill" | "tool" | "runtime";
+export type CapabilitySource = "builtin" | "project" | "user" | "package" | "git";
+export type CapabilityState = "active" | "disabled" | "shadowed" | "missing";
+
+export interface CapabilityItem {
+	id: string;
+	kind: CapabilityKind;
+	name: string;
+	description: string;
+	source: CapabilitySource;
+	path?: string;
+	state: CapabilityState;
+	disabledReason?: string;
+	shadowedBy?: string;
+}
+
+function normalizeAgents(agents: AgentConfig[], source: CapabilitySource, disabledIds: Set<string>): CapabilityItem[] {
+	return agents.map((agent) => {
+		const id = `agent:${agent.name}`;
+		const configDisabled = disabledIds.has(id);
+		const agentDisabled = agent.disabled || configDisabled;
+		return {
+			id,
+			kind: "agent" as const,
+			name: agent.name,
+			description: agent.description,
+			source,
+			path: agent.filePath,
+			state: agentDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : agent.disabled ? "disabled in config" : undefined,
+		};
+	});
+}
+
+function normalizeSkills(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const skills = discoverSkills(cwd);
+	return skills.map((skill) => {
+		const id = `skill:${skill.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "skill" as const,
+			name: skill.name,
+			description: skill.description,
+			source: skill.source as CapabilitySource,
+			path: skill.path,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+function normalizeTeams(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const result = discoverTeams(cwd);
+	return [...result.builtin, ...result.user, ...result.project].map((team) => {
+		const id = `team:${team.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "team" as const,
+			name: team.name,
+			description: team.description,
+			source: team.source as CapabilitySource,
+			path: team.filePath,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+function normalizeWorkflows(cwd: string, disabledIds: Set<string>): CapabilityItem[] {
+	const result = discoverWorkflows(cwd);
+	return [...result.builtin, ...result.user, ...result.project].map((workflow) => {
+		const id = `workflow:${workflow.name}`;
+		const configDisabled = disabledIds.has(id);
+		return {
+			id,
+			kind: "workflow" as const,
+			name: workflow.name,
+			description: workflow.description,
+			source: workflow.source as CapabilitySource,
+			path: workflow.filePath,
+			state: configDisabled ? "disabled" : "active",
+			disabledReason: configDisabled ? "disabled by policy" : undefined,
+		};
+	});
+}
+
+export function buildCapabilityInventory(cwd: string, config?: PiTeamsConfig): CapabilityItem[] {
+	const disabledIds = new Set<string>(config?.policy?.disabledCapabilities ?? []);
+	const agents = discoverAgents(cwd);
+	const items = [
+		...normalizeTeams(cwd, disabledIds),
+		...normalizeWorkflows(cwd, disabledIds),
+		...normalizeAgents([...agents.builtin, ...agents.user, ...agents.project], "builtin", disabledIds),
+		...normalizeSkills(cwd, disabledIds),
+	];
+
+	// Mark shadowed resources: project/user items with same kind:name as a builtin
+	const builtinNames = new Set(items.filter((item) => item.source === "builtin" || item.source === "package").map((item) => `${item.kind}:${item.name}`));
+	for (const item of items) {
+		if (item.source !== "builtin" && item.source !== "package" && builtinNames.has(`${item.kind}:${item.name}`)) {
+			item.state = "shadowed";
+			item.shadowedBy = `builtin:${item.kind}:${item.name}`;
+		}
+	}
+
+	return items.sort((a, b) => a.id.localeCompare(b.id));
+}

package/src/runtime/child-pi-pool.ts

@@ -0,0 +1,68 @@
+// 2.6 — Child-pi warm pool skeleton (ADR 0008 Proposed).
+//
+// This module exposes the pool interface that child-pi.ts will consume
+// once Pi gains the wait-for-prompt handshake protocol. Until the Pi-side
+// support lands, the pool is permanently disabled (size=0): callers always
+// receive null from `acquirePooledChild` and fall through to the regular
+// spawn path. This keeps the integration point ready without altering
+// production behaviour.
+//
+// Enabling a real pool requires three pieces in order:
+//
+//   1. Pi runtime: respond to a `PI_CREW_POOL_HEALTH=1` ping on stdin and
+//      block in a "wait-for-prompt" state until the parent writes a real
+//      prompt. Pi does not currently implement this.
+//   2. This module: replace the `acquirePooledChild` returning null with
+//      an actual pool that spawn-and-park N processes.
+//   3. child-pi.ts: prefer pooled children on `runChildPi` entry; fall
+//      back to fresh spawn on miss.
+//
+// Disabled by default; opt-in via `runtime.warmPool.size > 0` config or
+// the `PI_CREW_WARM_POOL_SIZE` env var.
+import type { ChildProcess } from "node:child_process";
+
+export interface WarmPoolOptions {
+	/** Number of warm processes to maintain. 0 disables the pool. */
+	size: number;
+	/** Drop pooled processes that have been idle longer than this. */
+	maxIdleMs: number;
+}
+
+export const DEFAULT_WARM_POOL_OPTIONS: WarmPoolOptions = {
+	size: 0,
+	maxIdleMs: 5 * 60_000,
+};
+
+/** Resolve the effective pool size from env / config / defaults. */
+export function resolveWarmPoolSize(env: NodeJS.ProcessEnv = process.env, configured?: number): number {
+	const fromEnv = Number.parseInt(env.PI_CREW_WARM_POOL_SIZE ?? "", 10);
+	if (Number.isFinite(fromEnv) && fromEnv >= 0) return fromEnv;
+	if (typeof configured === "number" && Number.isFinite(configured) && configured >= 0) return configured;
+	return DEFAULT_WARM_POOL_OPTIONS.size;
+}
+
+/**
+ * Try to acquire a parked child from the pool. Returns null when the pool
+ * is disabled or empty; caller should spawn a fresh child instead.
+ *
+ * Skeleton — currently always returns null. See module docstring.
+ */
+export function acquirePooledChild(_options: Partial<WarmPoolOptions> = {}): ChildProcess | null {
+	return null;
+}
+
+/**
+ * Mark a pooled child as done. Pool processes are single-use: this terminates
+ * the child rather than returning it to the pool, because state contamination
+ * across runs would be unsafe (file handles, env mutations, mounted FDs).
+ *
+ * Skeleton — currently a no-op since acquirePooledChild never returns a child.
+ */
+export function releasePooledChild(_child: ChildProcess | null | undefined): void {
+	// no-op while the pool is disabled
+}
+
+/** Drain and terminate every parked child. Call on cleanupRuntime. */
+export function disposeWarmPool(): void {
+	// no-op while the pool is disabled
+}