pi-crew 0.2.3 → 0.2.5

package/src/extension/registration/compaction-guard.ts

@@ -1,125 +1,125 @@
-import type { ExtensionAPI, ExtensionContext } from "@mariozechner/pi-coding-agent";
-import { listRecentRuns } from "../run-index.ts";
-import type { ArtifactDescriptor, TeamRunManifest } from "../../state/types.ts";
-
-export interface RegisterCompactionGuardOptions {
-	foregroundControllers: Map<string | symbol, AbortController>;
-}
-
-const TRIGGER_RATIO = 0.75;
-const HARD_RATIO = 0.95;
-const DEFAULT_CONTEXT_WINDOW = 200_000;
-const MAX_ARTIFACT_INDEX_RUNS = 10;
-const MAX_ARTIFACT_INDEX_ITEMS = 80;
-
-function contextWindow(ctx: { model?: { contextWindow?: number } }): number {
-	const value = ctx.model?.contextWindow;
-	return typeof value === "number" && Number.isFinite(value) && value > 0 ? value : DEFAULT_CONTEXT_WINDOW;
-}
-
-function usageRatio(ctx: { getContextUsage(): { tokens: number | null } | undefined; model?: { contextWindow?: number } }): number | undefined {
-	const tokens = ctx.getContextUsage()?.tokens;
-	if (tokens === null || tokens === undefined || !Number.isFinite(tokens)) return undefined;
-	return tokens / contextWindow(ctx);
-}
-
-interface CrewArtifactIndexEntry {
-	runId: string;
-	status: TeamRunManifest["status"];
-	team: string;
-	workflow?: string;
-	goal: string;
-	artifact: Pick<ArtifactDescriptor, "kind" | "path" | "producer" | "sizeBytes" | "createdAt">;
-}
-
-function collectCrewArtifactIndex(cwd: string): CrewArtifactIndexEntry[] {
-	const entries: CrewArtifactIndexEntry[] = [];
-	for (const run of listRecentRuns(cwd, MAX_ARTIFACT_INDEX_RUNS)) {
-		for (const artifact of run.artifacts) {
-			entries.push({
-				runId: run.runId,
-				status: run.status,
-				team: run.team,
-				workflow: run.workflow,
-				goal: run.goal,
-				artifact: {
-					kind: artifact.kind,
-					path: artifact.path,
-					producer: artifact.producer,
-					sizeBytes: artifact.sizeBytes,
-					createdAt: artifact.createdAt,
-				},
-			});
-			if (entries.length >= MAX_ARTIFACT_INDEX_ITEMS) return entries;
-		}
-	}
-	return entries;
-}
-
-function formatCrewArtifactIndex(entries: CrewArtifactIndexEntry[]): string {
-	if (!entries.length) return "";
-	const lines = ["", "# pi-crew artifact index", "Preserve these run artifact references in the compaction summary:"];
-	for (const entry of entries) {
-		lines.push(`- ${entry.artifact.kind}: ${entry.artifact.path} (run=${entry.runId}, status=${entry.status}, team=${entry.team}, workflow=${entry.workflow ?? "none"}, producer=${entry.artifact.producer})`);
-	}
-	return lines.join("\n");
-}
-
-export function registerCompactionGuard(pi: ExtensionAPI, options: RegisterCompactionGuardOptions): void {
-	let pendingCompactReason: string | null = null;
-	let compactionInProgress = false;
-
-	const startCompact = (ctx: ExtensionContext, reason: string): void => {
-		if (compactionInProgress) return;
-		compactionInProgress = true;
-		const artifactIndex = collectCrewArtifactIndex(ctx.cwd);
-		if (artifactIndex.length > 0) {
-			pi.appendEntry("crew:artifact-index", {
-				reason,
-				createdAt: new Date().toISOString(),
-				artifacts: artifactIndex,
-			});
-		}
-		ctx.compact({
-			customInstructions: `Prioritize keeping pi-crew run state, task results, artifact references, run IDs, and next actions. Keep completed-task detail concise.${formatCrewArtifactIndex(artifactIndex)}`,
-			onComplete: () => {
-				compactionInProgress = false;
-				ctx.ui.notify(reason === "deferred" ? "Deferred compaction completed" : "Auto-compacted context during team run", "info");
-			},
-			onError: (error) => {
-				compactionInProgress = false;
-				ctx.ui.notify(`${reason === "deferred" ? "Deferred" : "Auto"} compaction failed: ${error.message}`, "error");
-			},
-		});
-	};
-
-	// Phase 1.2: Defer compaction during foreground runs unless context is critically full.
-	pi.on("session_before_compact", async (_event, ctx) => {
-		if (options.foregroundControllers.size === 0) return;
-		const ratio = usageRatio(ctx);
-		if (ratio !== undefined && ratio >= HARD_RATIO) {
-			ctx.ui.notify("Compaction allowed despite foreground run: context is critically full", "warning");
-			return;
-		}
-		pendingCompactReason = "deferred-during-foreground-run";
-		ctx.ui.notify("Compaction deferred: foreground team run in progress", "info");
-		return { cancel: true };
-	});
-
-	// Phase 2.1: Proactive compaction with dynamic threshold based on model context window.
-	pi.on("turn_end", (_event, ctx) => {
-		if (compactionInProgress) return;
-		if (options.foregroundControllers.size === 0 && pendingCompactReason) {
-			pendingCompactReason = null;
-			startCompact(ctx, "deferred");
-			return;
-		}
-		const ratio = usageRatio(ctx);
-		if (ratio === undefined || ratio < TRIGGER_RATIO) return;
-		if (options.foregroundControllers.size > 0) {
-			pendingCompactReason = "threshold-during-foreground-run";
-			return;
-		}
-		startCompact(ctx, "threshold");
-	});
-}
+import type { ExtensionAPI, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { listRecentRuns } from "../run-index.ts";
+import type { ArtifactDescriptor, TeamRunManifest } from "../../state/types.ts";
+
+export interface RegisterCompactionGuardOptions {
+	foregroundControllers: Map<string | symbol, AbortController>;
+}
+
+const TRIGGER_RATIO = 0.75;
+const HARD_RATIO = 0.95;
+const DEFAULT_CONTEXT_WINDOW = 200_000;
+const MAX_ARTIFACT_INDEX_RUNS = 10;
+const MAX_ARTIFACT_INDEX_ITEMS = 80;
+
+function contextWindow(ctx: { model?: { contextWindow?: number } }): number {
+	const value = ctx.model?.contextWindow;
+	return typeof value === "number" && Number.isFinite(value) && value > 0 ? value : DEFAULT_CONTEXT_WINDOW;
+}
+
+function usageRatio(ctx: { getContextUsage(): { tokens: number | null } | undefined; model?: { contextWindow?: number } }): number | undefined {
+	const tokens = ctx.getContextUsage()?.tokens;
+	if (tokens === null || tokens === undefined || !Number.isFinite(tokens)) return undefined;
+	return tokens / contextWindow(ctx);
+}
+
+interface CrewArtifactIndexEntry {
+	runId: string;
+	status: TeamRunManifest["status"];
+	team: string;
+	workflow?: string;
+	goal: string;
+	artifact: Pick<ArtifactDescriptor, "kind" | "path" | "producer" | "sizeBytes" | "createdAt">;
+}
+
+function collectCrewArtifactIndex(cwd: string): CrewArtifactIndexEntry[] {
+	const entries: CrewArtifactIndexEntry[] = [];
+	for (const run of listRecentRuns(cwd, MAX_ARTIFACT_INDEX_RUNS)) {
+		for (const artifact of run.artifacts) {
+			entries.push({
+				runId: run.runId,
+				status: run.status,
+				team: run.team,
+				workflow: run.workflow,
+				goal: run.goal,
+				artifact: {
+					kind: artifact.kind,
+					path: artifact.path,
+					producer: artifact.producer,
+					sizeBytes: artifact.sizeBytes,
+					createdAt: artifact.createdAt,
+				},
+			});
+			if (entries.length >= MAX_ARTIFACT_INDEX_ITEMS) return entries;
+		}
+	}
+	return entries;
+}
+
+function formatCrewArtifactIndex(entries: CrewArtifactIndexEntry[]): string {
+	if (!entries.length) return "";
+	const lines = ["", "# pi-crew artifact index", "Preserve these run artifact references in the compaction summary:"];
+	for (const entry of entries) {
+		lines.push(`- ${entry.artifact.kind}: ${entry.artifact.path} (run=${entry.runId}, status=${entry.status}, team=${entry.team}, workflow=${entry.workflow ?? "none"}, producer=${entry.artifact.producer})`);
+	}
+	return lines.join("\n");
+}
+
+export function registerCompactionGuard(pi: ExtensionAPI, options: RegisterCompactionGuardOptions): void {
+	let pendingCompactReason: string | null = null;
+	let compactionInProgress = false;
+
+	const startCompact = (ctx: ExtensionContext, reason: string): void => {
+		if (compactionInProgress) return;
+		compactionInProgress = true;
+		const artifactIndex = collectCrewArtifactIndex(ctx.cwd);
+		if (artifactIndex.length > 0) {
+			pi.appendEntry("crew:artifact-index", {
+				reason,
+				createdAt: new Date().toISOString(),
+				artifacts: artifactIndex,
+			});
+		}
+		ctx.compact({
+			customInstructions: `Prioritize keeping pi-crew run state, task results, artifact references, run IDs, and next actions. Keep completed-task detail concise.${formatCrewArtifactIndex(artifactIndex)}`,
+			onComplete: () => {
+				compactionInProgress = false;
+				ctx.ui.notify(reason === "deferred" ? "Deferred compaction completed" : "Auto-compacted context during team run", "info");
+			},
+			onError: (error) => {
+				compactionInProgress = false;
+				ctx.ui.notify(`${reason === "deferred" ? "Deferred" : "Auto"} compaction failed: ${error.message}`, "error");
+			},
+		});
+	};
+
+	// Phase 1.2: Defer compaction during foreground runs unless context is critically full.
+	pi.on("session_before_compact", async (_event, ctx) => {
+		if (options.foregroundControllers.size === 0) return;
+		const ratio = usageRatio(ctx);
+		if (ratio !== undefined && ratio >= HARD_RATIO) {
+			ctx.ui.notify("Compaction allowed despite foreground run: context is critically full", "warning");
+			return;
+		}
+		pendingCompactReason = "deferred-during-foreground-run";
+		ctx.ui.notify("Compaction deferred: foreground team run in progress", "info");
+		return { cancel: true };
+	});
+
+	// Phase 2.1: Proactive compaction with dynamic threshold based on model context window.
+	pi.on("turn_end", (_event, ctx) => {
+		if (compactionInProgress) return;
+		if (options.foregroundControllers.size === 0 && pendingCompactReason) {
+			pendingCompactReason = null;
+			startCompact(ctx, "deferred");
+			return;
+		}
+		const ratio = usageRatio(ctx);
+		if (ratio === undefined || ratio < TRIGGER_RATIO) return;
+		if (options.foregroundControllers.size > 0) {
+			pendingCompactReason = "threshold-during-foreground-run";
+			return;
+		}
+		startCompact(ctx, "threshold");
+	});
+}

package/src/extension/registration/subagent-helpers.ts

@@ -1,102 +1,102 @@
-import * as fs from "node:fs";
-import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext } from "@mariozechner/pi-coding-agent";
-import { loadRunManifestById } from "../../state/state-store.ts";
-import { savePersistedSubagentRecord, type SubagentRecord, type SubagentSpawnOptions } from "../../subagents/manager.ts";
-import { resolveRealContainedPath } from "../../utils/safe-paths.ts";
-
-interface FollowUpCapablePi {
-	sendMessage?: (message: unknown, options?: unknown) => void;
-	sendUserMessage?: (content: string, options?: unknown) => void;
-}
-
-export function sendFollowUp(pi: ExtensionAPI, content: string): void {
-	const api = pi as unknown as FollowUpCapablePi;
-	if (typeof api.sendMessage !== "function") return;
-	api.sendMessage.call(pi, { customType: "pi-crew-subagent-notification", content, display: true }, { deliverAs: "followUp", triggerTurn: true });
-}
-
-export function sendAgentWakeUp(pi: ExtensionAPI, content: string): boolean {
-	const api = pi as unknown as FollowUpCapablePi;
-	try {
-		if (typeof api.sendUserMessage === "function") {
-			api.sendUserMessage.call(pi, content, { deliverAs: "followUp", triggerTurn: true });
-			return true;
-		}
-		if (typeof api.sendMessage === "function") {
-			api.sendMessage.call(pi, { customType: "pi-crew-subagent-wakeup", content, display: true }, { deliverAs: "followUp", triggerTurn: true });
-			return true;
-		}
-	} catch {
-		return false;
-	}
-	return false;
-}
-
-export function refreshPersistedSubagentRecord(ctx: ExtensionContext | ExtensionCommandContext, record: SubagentRecord): SubagentRecord {
-	if (!record.runId) return record;
-	const loaded = loadRunManifestById(ctx.cwd, record.runId);
-	if (!loaded) return record;
-	if (loaded.manifest.status === "completed" || loaded.manifest.status === "failed" || loaded.manifest.status === "cancelled" || loaded.manifest.status === "blocked") {
-		const refreshed = {
-			...record,
-			status: loaded.manifest.status,
-			error: loaded.manifest.status === "completed" || loaded.manifest.status === "blocked" ? undefined : loaded.manifest.summary,
-			completedAt: loaded.manifest.status === "blocked" ? undefined : record.completedAt ?? Date.now(),
-		};
-		savePersistedSubagentRecord(ctx.cwd, refreshed);
-		return refreshed;
-	}
-	return record;
-}
-
-export function formatSubagentRecord(record: SubagentRecord): string {
-	const duration = record.completedAt ? `${Math.round((record.completedAt - record.startedAt) / 1000)}s` : "running";
-	return [
-		`Agent: ${record.id}`,
-		`Type: ${record.type}`,
-		`Status: ${record.status}`,
-		record.runId ? `Run: ${record.runId}` : undefined,
-		`Description: ${record.description}`,
-		record.model ? `Model: ${record.model}` : undefined,
-		`Duration: ${duration}`,
-		record.error ? `Error: ${record.error}` : undefined,
-	].filter((line): line is string => Boolean(line)).join("\n");
-}
-
-export function readSubagentRunResult(ctx: ExtensionContext | ExtensionCommandContext, record: SubagentRecord): string | undefined {
-	if (!record.runId) return record.result;
-	const loaded = loadRunManifestById(ctx.cwd, record.runId);
-	const task = loaded?.tasks.find((item) => item.resultArtifact) ?? loaded?.tasks[0];
-	const artifactPath = task?.resultArtifact?.path;
-	if (!artifactPath || !loaded) return undefined;
-	try {
-		const safePath = resolveRealContainedPath(loaded.manifest.artifactsRoot, artifactPath);
-		return fs.readFileSync(safePath, "utf-8").trim();
-	} catch {
-		return undefined;
-	}
-}
-
-export function subagentToolResult(text: string, details: Record<string, unknown> = {}, isError = false) {
-	return { content: [{ type: "text" as const, text }], details, isError };
-}
-
-function parseSkillParam(value: unknown): string | string[] | false | undefined {
-	if (value === false) return false;
-	if (typeof value === "string") return value;
-	if (Array.isArray(value) && value.every((entry) => typeof entry === "string")) return value;
-	return undefined;
-}
-
-export function __test__subagentSpawnParams(params: Record<string, unknown>, ctx: Pick<ExtensionContext, "cwd">): SubagentSpawnOptions {
-	return {
-		cwd: ctx.cwd,
-		type: typeof params.subagent_type === "string" && params.subagent_type.trim() ? params.subagent_type.trim() : "executor",
-		description: typeof params.description === "string" && params.description.trim() ? params.description.trim() : "pi-crew subagent",
-		prompt: typeof params.prompt === "string" ? params.prompt : "",
-		background: params.run_in_background === true,
-		model: typeof params.model === "string" && params.model.trim() ? params.model.trim() : undefined,
-		skill: parseSkillParam(params.skill),
-		maxTurns: typeof params.max_turns === "number" && Number.isFinite(params.max_turns) ? params.max_turns : undefined,
-	};
-}
+import * as fs from "node:fs";
+import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { loadRunManifestById } from "../../state/state-store.ts";
+import { savePersistedSubagentRecord, type SubagentRecord, type SubagentSpawnOptions } from "../../subagents/manager.ts";
+import { resolveRealContainedPath } from "../../utils/safe-paths.ts";
+
+interface FollowUpCapablePi {
+	sendMessage?: (message: unknown, options?: unknown) => void;
+	sendUserMessage?: (content: string, options?: unknown) => void;
+}
+
+export function sendFollowUp(pi: ExtensionAPI, content: string): void {
+	const api = pi as unknown as FollowUpCapablePi;
+	if (typeof api.sendMessage !== "function") return;
+	api.sendMessage.call(pi, { customType: "pi-crew-subagent-notification", content, display: true }, { deliverAs: "followUp", triggerTurn: true });
+}
+
+export function sendAgentWakeUp(pi: ExtensionAPI, content: string): boolean {
+	const api = pi as unknown as FollowUpCapablePi;
+	try {
+		if (typeof api.sendUserMessage === "function") {
+			api.sendUserMessage.call(pi, content, { deliverAs: "followUp", triggerTurn: true });
+			return true;
+		}
+		if (typeof api.sendMessage === "function") {
+			api.sendMessage.call(pi, { customType: "pi-crew-subagent-wakeup", content, display: true }, { deliverAs: "followUp", triggerTurn: true });
+			return true;
+		}
+	} catch {
+		return false;
+	}
+	return false;
+}
+
+export function refreshPersistedSubagentRecord(ctx: ExtensionContext | ExtensionCommandContext, record: SubagentRecord): SubagentRecord {
+	if (!record.runId) return record;
+	const loaded = loadRunManifestById(ctx.cwd, record.runId);
+	if (!loaded) return record;
+	if (loaded.manifest.status === "completed" || loaded.manifest.status === "failed" || loaded.manifest.status === "cancelled" || loaded.manifest.status === "blocked") {
+		const refreshed = {
+			...record,
+			status: loaded.manifest.status,
+			error: loaded.manifest.status === "completed" || loaded.manifest.status === "blocked" ? undefined : loaded.manifest.summary,
+			completedAt: loaded.manifest.status === "blocked" ? undefined : record.completedAt ?? Date.now(),
+		};
+		savePersistedSubagentRecord(ctx.cwd, refreshed);
+		return refreshed;
+	}
+	return record;
+}
+
+export function formatSubagentRecord(record: SubagentRecord): string {
+	const duration = record.completedAt ? `${Math.round((record.completedAt - record.startedAt) / 1000)}s` : "running";
+	return [
+		`Agent: ${record.id}`,
+		`Type: ${record.type}`,
+		`Status: ${record.status}`,
+		record.runId ? `Run: ${record.runId}` : undefined,
+		`Description: ${record.description}`,
+		record.model ? `Model: ${record.model}` : undefined,
+		`Duration: ${duration}`,
+		record.error ? `Error: ${record.error}` : undefined,
+	].filter((line): line is string => Boolean(line)).join("\n");
+}
+
+export function readSubagentRunResult(ctx: ExtensionContext | ExtensionCommandContext, record: SubagentRecord): string | undefined {
+	if (!record.runId) return record.result;
+	const loaded = loadRunManifestById(ctx.cwd, record.runId);
+	const task = loaded?.tasks.find((item) => item.resultArtifact) ?? loaded?.tasks[0];
+	const artifactPath = task?.resultArtifact?.path;
+	if (!artifactPath || !loaded) return undefined;
+	try {
+		const safePath = resolveRealContainedPath(loaded.manifest.artifactsRoot, artifactPath);
+		return fs.readFileSync(safePath, "utf-8").trim();
+	} catch {
+		return undefined;
+	}
+}
+
+export function subagentToolResult(text: string, details: Record<string, unknown> = {}, isError = false) {
+	return { content: [{ type: "text" as const, text }], details, isError };
+}
+
+function parseSkillParam(value: unknown): string | string[] | false | undefined {
+	if (value === false) return false;
+	if (typeof value === "string") return value;
+	if (Array.isArray(value) && value.every((entry) => typeof entry === "string")) return value;
+	return undefined;
+}
+
+export function __test__subagentSpawnParams(params: Record<string, unknown>, ctx: Pick<ExtensionContext, "cwd">): SubagentSpawnOptions {
+	return {
+		cwd: ctx.cwd,
+		type: typeof params.subagent_type === "string" && params.subagent_type.trim() ? params.subagent_type.trim() : "executor",
+		description: typeof params.description === "string" && params.description.trim() ? params.description.trim() : "pi-crew subagent",
+		prompt: typeof params.prompt === "string" ? params.prompt : "",
+		background: params.run_in_background === true,
+		model: typeof params.model === "string" && params.model.trim() ? params.model.trim() : undefined,
+		skill: parseSkillParam(params.skill),
+		maxTurns: typeof params.max_turns === "number" && Number.isFinite(params.max_turns) ? params.max_turns : undefined,
+	};
+}