pi-crew 0.2.2 → 0.2.4

package/src/extension/team-manager-command.ts

@@ -1,95 +1,96 @@
-import type { ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
-import { listRuns } from "./run-index.ts";
-// Lazy-loaded: team-tool.ts pulls in entire runtime chain.
-import type { handleTeamTool as HandleTeamToolFn } from "./team-tool.ts";
-let _cachedHandleTeamTool: typeof HandleTeamToolFn | undefined;
-async function handleTeamTool(params: Parameters<typeof HandleTeamToolFn>[0], ctx: Parameters<typeof HandleTeamToolFn>[1]): Promise<Awaited<ReturnType<typeof HandleTeamToolFn>>> {
-	if (!_cachedHandleTeamTool) {
-		const mod = await import("./team-tool.ts");
-		_cachedHandleTeamTool = mod.handleTeamTool;
-	}
-	return _cachedHandleTeamTool(params, ctx);
-}
-import { isToolError, textFromToolResult } from "./tool-result.ts";
-
-async function notifyResult(ctx: ExtensionCommandContext, result: Awaited<ReturnType<typeof handleTeamTool>>): Promise<void> {
-	const text = textFromToolResult(result);
-	ctx.ui.notify(text.length > 1000 ? `${text.slice(0, 997)}...` : text, isToolError(result) ? "error" : "info");
-}
-
-export async function handleTeamManagerCommand(_args: string, ctx: ExtensionCommandContext): Promise<void> {
-	const action = await ctx.ui.select("pi-crew", [
-		"List teams/workflows/agents/runs",
-		"Run team",
-		"Show run status",
-		"Cleanup run worktrees",
-		"Create routed resource",
-		"Update routed resource",
-		"Doctor",
-	]);
-	if (!action) return;
-
-	if (action.startsWith("List")) {
-		await notifyResult(ctx, await handleTeamTool({ action: "list" }, ctx));
-		return;
-	}
-
-	if (action === "Doctor") {
-		await notifyResult(ctx, await handleTeamTool({ action: "doctor" }, ctx));
-		return;
-	}
-
-	if (action === "Create routed resource" || action === "Update routed resource") {
-		const isUpdate = action === "Update routed resource";
-		const resource = await ctx.ui.select("Resource type", ["agent", "team"]);
-		if (resource !== "agent" && resource !== "team") return;
-		const name = await ctx.ui.input("Name", resource === "agent" ? "custom-agent" : "custom-team");
-		if (!name) return;
-		const description = await ctx.ui.input("Description", "When to use this resource");
-		if (!description) return;
-		const triggers = await ctx.ui.input("Triggers (comma-separated)", "");
-		const useWhen = await ctx.ui.input("Use when (comma-separated)", "");
-		const avoidWhen = await ctx.ui.input("Avoid when (comma-separated)", "");
-		const cost = await ctx.ui.select("Cost", ["cheap", "free", "expensive"]);
-		const category = await ctx.ui.input("Category", "custom");
-		const baseConfig = { name, description, scope: "project", triggers, useWhen, avoidWhen, cost, category };
-		if (resource === "agent") {
-			const systemPrompt = isUpdate ? undefined : `You are ${name}.`;
-			await notifyResult(ctx, await handleTeamTool({ action: isUpdate ? "update" : "create", resource, agent: name, config: { ...baseConfig, systemPrompt } }, ctx));
-			return;
-		}
-		const agent = await ctx.ui.input("Role agent", "executor");
-		await notifyResult(ctx, await handleTeamTool({ action: isUpdate ? "update" : "create", resource, team: name, config: { ...baseConfig, roles: [{ name: "executor", agent: agent || "executor" }] } }, ctx));
-		return;
-	}
-
-	if (action === "Run team") {
-		const team = await ctx.ui.input("Team name", "default");
-		if (team === undefined) return;
-		const goal = await ctx.ui.input("Goal", "Describe the team objective");
-		if (!goal) return;
-		const asyncRun = await ctx.ui.confirm("Async run?", "Run in detached background mode?");
-		const worktree = await ctx.ui.confirm("Worktree mode?", "Use git worktrees for task workspaces? Requires a clean repo by default.");
-		await notifyResult(ctx, await handleTeamTool({ action: "run", team: team || "default", goal, async: asyncRun, workspaceMode: worktree ? "worktree" : "single" }, ctx));
-		return;
-	}
-
-	const runs = listRuns(ctx.cwd).slice(0, 20);
-	if (runs.length === 0) {
-		ctx.ui.notify("No pi-crew runs found.", "info");
-		return;
-	}
-	const selected = await ctx.ui.select("Select run", runs.map((run) => `${run.runId} [${run.status}] ${run.team}/${run.workflow ?? "none"}`));
-	if (!selected) return;
-	const runId = selected.split(" ")[0];
-	if (!runId) return;
-
-	if (action === "Show run status") {
-		await notifyResult(ctx, await handleTeamTool({ action: "status", runId }, ctx));
-		return;
-	}
-	if (action === "Cleanup run worktrees") {
-		const force = await ctx.ui.confirm("Force cleanup?", "Force may remove dirty worktrees. Choose false to preserve dirty worktrees and capture cleanup diffs.");
-		await notifyResult(ctx, await handleTeamTool({ action: "cleanup", runId, force }, ctx));
-	}
-}
+import type { ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
+import { listRuns } from "./run-index.ts";
+// Lazy-loaded: team-tool.ts pulls in entire runtime chain.
+import type { handleTeamTool as HandleTeamToolFn } from "./team-tool.ts";
+let _cachedHandleTeamTool: typeof HandleTeamToolFn | undefined;
+async function handleTeamTool(params: Parameters<typeof HandleTeamToolFn>[0], ctx: Parameters<typeof HandleTeamToolFn>[1]): Promise<Awaited<ReturnType<typeof HandleTeamToolFn>>> {
+	if (!_cachedHandleTeamTool) {
+		// LAZY: team-tool.ts pulls in the entire runtime chain.
+		const mod = await import("./team-tool.ts");
+		_cachedHandleTeamTool = mod.handleTeamTool;
+	}
+	return _cachedHandleTeamTool(params, ctx);
+}
+import { isToolError, textFromToolResult } from "./tool-result.ts";
+
+async function notifyResult(ctx: ExtensionCommandContext, result: Awaited<ReturnType<typeof handleTeamTool>>): Promise<void> {
+	const text = textFromToolResult(result);
+	ctx.ui.notify(text.length > 1000 ? `${text.slice(0, 997)}...` : text, isToolError(result) ? "error" : "info");
+}
+
+export async function handleTeamManagerCommand(_args: string, ctx: ExtensionCommandContext): Promise<void> {
+	const action = await ctx.ui.select("pi-crew", [
+		"List teams/workflows/agents/runs",
+		"Run team",
+		"Show run status",
+		"Cleanup run worktrees",
+		"Create routed resource",
+		"Update routed resource",
+		"Doctor",
+	]);
+	if (!action) return;
+
+	if (action.startsWith("List")) {
+		await notifyResult(ctx, await handleTeamTool({ action: "list" }, ctx));
+		return;
+	}
+
+	if (action === "Doctor") {
+		await notifyResult(ctx, await handleTeamTool({ action: "doctor" }, ctx));
+		return;
+	}
+
+	if (action === "Create routed resource" || action === "Update routed resource") {
+		const isUpdate = action === "Update routed resource";
+		const resource = await ctx.ui.select("Resource type", ["agent", "team"]);
+		if (resource !== "agent" && resource !== "team") return;
+		const name = await ctx.ui.input("Name", resource === "agent" ? "custom-agent" : "custom-team");
+		if (!name) return;
+		const description = await ctx.ui.input("Description", "When to use this resource");
+		if (!description) return;
+		const triggers = await ctx.ui.input("Triggers (comma-separated)", "");
+		const useWhen = await ctx.ui.input("Use when (comma-separated)", "");
+		const avoidWhen = await ctx.ui.input("Avoid when (comma-separated)", "");
+		const cost = await ctx.ui.select("Cost", ["cheap", "free", "expensive"]);
+		const category = await ctx.ui.input("Category", "custom");
+		const baseConfig = { name, description, scope: "project", triggers, useWhen, avoidWhen, cost, category };
+		if (resource === "agent") {
+			const systemPrompt = isUpdate ? undefined : `You are ${name}.`;
+			await notifyResult(ctx, await handleTeamTool({ action: isUpdate ? "update" : "create", resource, agent: name, config: { ...baseConfig, systemPrompt } }, ctx));
+			return;
+		}
+		const agent = await ctx.ui.input("Role agent", "executor");
+		await notifyResult(ctx, await handleTeamTool({ action: isUpdate ? "update" : "create", resource, team: name, config: { ...baseConfig, roles: [{ name: "executor", agent: agent || "executor" }] } }, ctx));
+		return;
+	}
+
+	if (action === "Run team") {
+		const team = await ctx.ui.input("Team name", "default");
+		if (team === undefined) return;
+		const goal = await ctx.ui.input("Goal", "Describe the team objective");
+		if (!goal) return;
+		const asyncRun = await ctx.ui.confirm("Async run?", "Run in detached background mode?");
+		const worktree = await ctx.ui.confirm("Worktree mode?", "Use git worktrees for task workspaces? Requires a clean repo by default.");
+		await notifyResult(ctx, await handleTeamTool({ action: "run", team: team || "default", goal, async: asyncRun, workspaceMode: worktree ? "worktree" : "single" }, ctx));
+		return;
+	}
+
+	const runs = listRuns(ctx.cwd).slice(0, 20);
+	if (runs.length === 0) {
+		ctx.ui.notify("No pi-crew runs found.", "info");
+		return;
+	}
+	const selected = await ctx.ui.select("Select run", runs.map((run) => `${run.runId} [${run.status}] ${run.team}/${run.workflow ?? "none"}`));
+	if (!selected) return;
+	const runId = selected.split(" ")[0];
+	if (!runId) return;
+
+	if (action === "Show run status") {
+		await notifyResult(ctx, await handleTeamTool({ action: "status", runId }, ctx));
+		return;
+	}
+	if (action === "Cleanup run worktrees") {
+		const force = await ctx.ui.confirm("Force cleanup?", "Force may remove dirty worktrees. Choose false to preserve dirty worktrees and capture cleanup diffs.");
+		await notifyResult(ctx, await handleTeamTool({ action: "cleanup", runId, force }, ctx));
+	}
+}

package/src/extension/team-recommendation.ts

@@ -1,188 +1,188 @@
-import { detectTeamIntent } from "./autonomous-policy.ts";
-import type { AgentConfig } from "../agents/agent-config.ts";
-import type { TeamConfig } from "../teams/team-config.ts";
-import type { PiTeamsAutonomousConfig } from "../config/config.ts";
-
-export type DecompositionStrategy = "numbered" | "bulleted" | "conjunction" | "atomic";
-
-export interface RecommendedSubtask {
-	subject: string;
-	description: string;
-	role: string;
-}
-
-export interface TeamRecommendation {
-	team: string;
-	workflow: string;
-	action: "plan" | "run";
-	async: boolean;
-	workspaceMode: "single" | "worktree";
-	confidence: "low" | "medium" | "high";
-	decomposition: { strategy: DecompositionStrategy; subtasks: RecommendedSubtask[]; fanout: number };
-	reasons: string[];
-}
-
-const REVIEW_TERMS = ["review", "audit", "security", "vulnerability", "diff", "pr", "pull request"];
-const RESEARCH_TERMS = ["research", "investigate", "compare", "analyze", "document", "docs", "explain", "architecture", "đọc sâu", "source", "projects"];
-const PARALLEL_RESEARCH_RE = /(?:đọc sâu|deep read|deep research|source audit|multiple projects|các project|pi-\*|source\/|@source)/i;
-const FAST_FIX_TERMS = ["quick fix", "fast-fix", "small bug", "typo", "one-line", "minor", "lint"];
-const IMPLEMENTATION_TERMS = ["implement", "refactor", "migrate", "feature", "tests", "test", "integration", "upgrade", "build", "create", "add", "fix", "update", "sửa", "thêm", "cập nhật", "kiểm thử"];
-const RISKY_TERMS = ["migration", "refactor", "large", "multiple", "parallel", "concurrent", "risky", "critical", "nhiều file", "nhiều task"];
-const NUMBERED_LINE_RE = /^\s*\d+[.)]\s+(.+)$/;
-const BULLETED_LINE_RE = /^\s*[-*•]\s+(.+)$/;
-const CONJUNCTION_SPLIT_RE = /\s+(?:and|,\s*and|,)\s+/i;
-const FILE_REF_RE = /\b\S+\.\w{1,8}\b/g;
-const CODE_SYMBOL_RE = /`[^`]+`/g;
-
-function includesAny(text: string, terms: string[]): string[] {
-	return terms.filter((term) => text.includes(term));
-}
-
-function wordCount(text: string): number {
-	return text.trim().split(/\s+/).filter(Boolean).length;
-}
-
-function recommendRole(text: string): string {
-	const lower = text.toLowerCase();
-	if (includesAny(lower, ["test", "spec", "coverage", "verify"]).length > 0) return "test-engineer";
-	if (includesAny(lower, ["security", "vulnerability", "auth", "owasp"]).length > 0) return "security-reviewer";
-	if (includesAny(lower, ["review", "audit", "diff"]).length > 0) return "reviewer";
-	if (includesAny(lower, ["doc", "readme", "guide", "write"]).length > 0) return "writer";
-	if (includesAny(lower, ["research", "investigate", "explore", "find", "trace"]).length > 0) return "explorer";
-	if (includesAny(lower, ["plan", "design", "architecture"]).length > 0) return "planner";
-	return "executor";
-}
-
-function makeSubtask(text: string): RecommendedSubtask {
-	const subject = text.trim().slice(0, 80) || "Task";
-	return { subject, description: text.trim(), role: recommendRole(text) };
-}
-
-export function decomposeGoal(goal: string): { strategy: DecompositionStrategy; subtasks: RecommendedSubtask[]; fanout: number } {
-	const lines = goal.split("\n").map((line) => line.trim()).filter(Boolean);
-	const fileRefs = goal.match(FILE_REF_RE)?.length ?? 0;
-	const codeSymbols = goal.match(CODE_SYMBOL_RE)?.length ?? 0;
-	const hasParallelKeyword = /\b(?:parallel|concurrently|simultaneously|independently)\b/i.test(goal);
-	if (fileRefs >= 3 || codeSymbols >= 3 || hasParallelKeyword) {
-		const subtask = makeSubtask(goal);
-		return { strategy: "atomic", subtasks: [subtask], fanout: 1 };
-	}
-	const numberedLines = lines.map((line) => line.match(NUMBERED_LINE_RE)?.[1]).filter((line): line is string => line !== undefined);
-	if (numberedLines.length >= 2 && numberedLines.length >= lines.length - 1) {
-		const subtasks = numberedLines.map((line) => makeSubtask(line));
-		return { strategy: "numbered", subtasks, fanout: subtasks.length };
-	}
-	const bulletedLines = lines.map((line) => line.match(BULLETED_LINE_RE)?.[1]).filter((line): line is string => line !== undefined);
-	if (bulletedLines.length >= 2 && bulletedLines.length >= lines.length - 1) {
-		const subtasks = bulletedLines.map((line) => makeSubtask(line));
-		return { strategy: "bulleted", subtasks, fanout: subtasks.length };
-	}
-	if (lines.length === 1) {
-		const parts = lines[0].split(CONJUNCTION_SPLIT_RE).map((part) => part.trim()).filter(Boolean);
-		if (parts.length >= 2) {
-			const subtasks = parts.map((part) => makeSubtask(part));
-			return { strategy: "conjunction", subtasks, fanout: subtasks.length };
-		}
-	}
-	const subtask = makeSubtask(goal);
-	return { strategy: "atomic", subtasks: [subtask], fanout: 1 };
-}
-
-function metadataMatches(goal: string, values: string[] | undefined): string[] {
-	const lower = goal.toLowerCase();
-	return (values ?? []).filter((value) => lower.includes(value.toLowerCase()));
-}
-
-export function recommendTeam(goal: string, config: PiTeamsAutonomousConfig = {}, resources?: { teams?: TeamConfig[]; agents?: AgentConfig[] }): TeamRecommendation {
-	const normalized = goal.toLowerCase();
-	const intents = detectTeamIntent(goal, config);
-	const decomposition = decomposeGoal(goal);
-	const reasons: string[] = [];
-	let team: TeamRecommendation["team"] = "default";
-	let workflow: TeamRecommendation["workflow"] = "default";
-	let action: TeamRecommendation["action"] = "run";
-	let confidence: TeamRecommendation["confidence"] = "medium";
-
-	if (intents.length > 0) reasons.push(`Matched explicit intent keyword(s): ${intents.join(", ")}.`);
-
-	const metadataTeamMatches = (resources?.teams ?? [])
-		.map((candidate) => ({ team: candidate, matches: [...metadataMatches(goal, candidate.routing?.triggers), ...metadataMatches(goal, candidate.routing?.useWhen)] }))
-		.filter((candidate) => candidate.matches.length > 0)
-		.sort((a, b) => b.matches.length - a.matches.length);
-
-	const reviewMatches = includesAny(normalized, REVIEW_TERMS);
-	const researchMatches = includesAny(normalized, RESEARCH_TERMS);
-	const fastFixMatches = includesAny(normalized, FAST_FIX_TERMS);
-	const implementationMatches = includesAny(normalized, IMPLEMENTATION_TERMS);
-	const riskyMatches = includesAny(normalized, RISKY_TERMS);
-
-	if (metadataTeamMatches[0]) {
-		team = metadataTeamMatches[0].team.name as TeamRecommendation["team"];
-		workflow = (metadataTeamMatches[0].team.defaultWorkflow ?? metadataTeamMatches[0].team.name) as TeamRecommendation["workflow"];
-		confidence = "high";
-		reasons.push(`Matched team routing metadata for '${metadataTeamMatches[0].team.name}': ${metadataTeamMatches[0].matches.join(", ")}.`);
-	} else if (intents.includes("review") || reviewMatches.length >= 2 || normalized.includes("security review")) {
-		team = "review";
-		workflow = "review";
-		confidence = "high";
-		reasons.push(`Review/audit terms detected: ${reviewMatches.join(", ") || "explicit review intent"}.`);
-	} else if (PARALLEL_RESEARCH_RE.test(goal) || (researchMatches.length >= 2 && (normalized.includes("multiple") || normalized.includes("source") || normalized.includes("project") || normalized.includes("pi-")))) {
-		team = "parallel-research";
-		workflow = "parallel-research";
-		confidence = "high";
-		reasons.push("Deep/multi-source research detected; use parallel shard exploration.");
-	} else if (intents.includes("research") || (researchMatches.length > 0 && implementationMatches.length === 0)) {
-		team = "research";
-		workflow = "research";
-		confidence = researchMatches.length >= 2 ? "high" : "medium";
-		reasons.push(`Research/analysis terms detected: ${researchMatches.join(", ")}.`);
-	} else if (intents.includes("fastFix") || fastFixMatches.length > 0) {
-		team = "fast-fix";
-		workflow = "fast-fix";
-		confidence = "high";
-		reasons.push(`Small fix terms detected: ${fastFixMatches.join(", ") || "fast-fix intent"}.`);
-	} else if (intents.includes("taskList")) {
-		team = "implementation";
-		workflow = "implementation";
-		confidence = "high";
-		reasons.push(`Actionable multi-item task list detected (${decomposition.fanout} bullet${decomposition.fanout === 1 ? "" : "s"}); use coordinated implementation planning.`);
-	} else if (intents.includes("implementation") || implementationMatches.length > 0) {
-		team = "implementation";
-		workflow = "implementation";
-		confidence = implementationMatches.length >= 2 || riskyMatches.length > 0 || decomposition.fanout >= 2 ? "high" : "medium";
-		reasons.push(`Implementation terms detected: ${implementationMatches.join(", ") || "implementation intent"}.`);
-	} else {
-		action = "plan";
-		confidence = wordCount(goal) < 8 ? "low" : "medium";
-		reasons.push("No strong team-specific intent detected; start with planning/default discovery.");
-	}
-
-
-	if (decomposition.strategy !== "atomic") reasons.push(`Goal decomposes into ${decomposition.subtasks.length} subtasks using ${decomposition.strategy} parsing.`);
-	const async = config.preferAsyncForLongTasks === true && (wordCount(goal) > 24 || riskyMatches.length > 0 || implementationMatches.length >= 2 || decomposition.fanout >= 3);
-	const workspaceMode = config.allowWorktreeSuggestion === false ? "single" : (riskyMatches.length > 0 && team === "implementation" ? "worktree" : "single");
-	if (async) reasons.push("Task appears long/risky and config prefers async for long tasks.");
-	if (workspaceMode === "worktree") reasons.push(`Risk/isolation terms detected: ${riskyMatches.join(", ")}.`);
-
-	return { team, workflow, action, async, workspaceMode, confidence, decomposition, reasons };
-}
-
-export function formatRecommendation(goal: string, recommendation: TeamRecommendation): string {
-	return [
-		"pi-crew recommendation:",
-		`Goal: ${goal}`,
-		`Action: ${recommendation.action}`,
-		`Team: ${recommendation.team}`,
-		`Workflow: ${recommendation.workflow}`,
-		`Async: ${recommendation.async}`,
-		`Workspace mode: ${recommendation.workspaceMode}`,
-		`Confidence: ${recommendation.confidence}`,
-		`Decomposition: ${recommendation.decomposition.strategy} (${recommendation.decomposition.fanout} lane${recommendation.decomposition.fanout === 1 ? "" : "s"})`,
-		"Subtasks:",
-		...recommendation.decomposition.subtasks.map((task, index) => `- ${index + 1}. [${task.role}] ${task.subject}`),
-		"Reasons:",
-		...recommendation.reasons.map((reason) => `- ${reason}`),
-		"Suggested tool call:",
-		JSON.stringify({ action: recommendation.action, team: recommendation.team, workflow: recommendation.workflow, goal, async: recommendation.async, workspaceMode: recommendation.workspaceMode }, null, 2),
-	].join("\n");
-}
+import { detectTeamIntent } from "./autonomous-policy.ts";
+import type { AgentConfig } from "../agents/agent-config.ts";
+import type { TeamConfig } from "../teams/team-config.ts";
+import type { PiTeamsAutonomousConfig } from "../config/config.ts";
+
+export type DecompositionStrategy = "numbered" | "bulleted" | "conjunction" | "atomic";
+
+export interface RecommendedSubtask {
+	subject: string;
+	description: string;
+	role: string;
+}
+
+export interface TeamRecommendation {
+	team: string;
+	workflow: string;
+	action: "plan" | "run";
+	async: boolean;
+	workspaceMode: "single" | "worktree";
+	confidence: "low" | "medium" | "high";
+	decomposition: { strategy: DecompositionStrategy; subtasks: RecommendedSubtask[]; fanout: number };
+	reasons: string[];
+}
+
+const REVIEW_TERMS = ["review", "audit", "security", "vulnerability", "diff", "pr", "pull request"];
+const RESEARCH_TERMS = ["research", "investigate", "compare", "analyze", "document", "docs", "explain", "architecture", "đọc sâu", "source", "projects"];
+const PARALLEL_RESEARCH_RE = /(?:đọc sâu|deep read|deep research|source audit|multiple projects|các project|pi-\*|source\/|@source)/i;
+const FAST_FIX_TERMS = ["quick fix", "fast-fix", "small bug", "typo", "one-line", "minor", "lint"];
+const IMPLEMENTATION_TERMS = ["implement", "refactor", "migrate", "feature", "tests", "test", "integration", "upgrade", "build", "create", "add", "fix", "update", "sửa", "thêm", "cập nhật", "kiểm thử"];
+const RISKY_TERMS = ["migration", "refactor", "large", "multiple", "parallel", "concurrent", "risky", "critical", "nhiều file", "nhiều task"];
+const NUMBERED_LINE_RE = /^\s*\d+[.)]\s+(.+)$/;
+const BULLETED_LINE_RE = /^\s*[-*•]\s+(.+)$/;
+const CONJUNCTION_SPLIT_RE = /\s+(?:and|,\s*and|,)\s+/i;
+const FILE_REF_RE = /\b\S+\.\w{1,8}\b/g;
+const CODE_SYMBOL_RE = /`[^`]+`/g;
+
+function includesAny(text: string, terms: string[]): string[] {
+	return terms.filter((term) => text.includes(term));
+}
+
+function wordCount(text: string): number {
+	return text.trim().split(/\s+/).filter(Boolean).length;
+}
+
+function recommendRole(text: string): string {
+	const lower = text.toLowerCase();
+	if (includesAny(lower, ["test", "spec", "coverage", "verify"]).length > 0) return "test-engineer";
+	if (includesAny(lower, ["security", "vulnerability", "auth", "owasp"]).length > 0) return "security-reviewer";
+	if (includesAny(lower, ["review", "audit", "diff"]).length > 0) return "reviewer";
+	if (includesAny(lower, ["doc", "readme", "guide", "write"]).length > 0) return "writer";
+	if (includesAny(lower, ["research", "investigate", "explore", "find", "trace"]).length > 0) return "explorer";
+	if (includesAny(lower, ["plan", "design", "architecture"]).length > 0) return "planner";
+	return "executor";
+}
+
+function makeSubtask(text: string): RecommendedSubtask {
+	const subject = text.trim().slice(0, 80) || "Task";
+	return { subject, description: text.trim(), role: recommendRole(text) };
+}
+
+export function decomposeGoal(goal: string): { strategy: DecompositionStrategy; subtasks: RecommendedSubtask[]; fanout: number } {
+	const lines = goal.split("\n").map((line) => line.trim()).filter(Boolean);
+	const fileRefs = goal.match(FILE_REF_RE)?.length ?? 0;
+	const codeSymbols = goal.match(CODE_SYMBOL_RE)?.length ?? 0;
+	const hasParallelKeyword = /\b(?:parallel|concurrently|simultaneously|independently)\b/i.test(goal);
+	if (fileRefs >= 3 || codeSymbols >= 3 || hasParallelKeyword) {
+		const subtask = makeSubtask(goal);
+		return { strategy: "atomic", subtasks: [subtask], fanout: 1 };
+	}
+	const numberedLines = lines.map((line) => line.match(NUMBERED_LINE_RE)?.[1]).filter((line): line is string => line !== undefined);
+	if (numberedLines.length >= 2 && numberedLines.length >= lines.length - 1) {
+		const subtasks = numberedLines.map((line) => makeSubtask(line));
+		return { strategy: "numbered", subtasks, fanout: subtasks.length };
+	}
+	const bulletedLines = lines.map((line) => line.match(BULLETED_LINE_RE)?.[1]).filter((line): line is string => line !== undefined);
+	if (bulletedLines.length >= 2 && bulletedLines.length >= lines.length - 1) {
+		const subtasks = bulletedLines.map((line) => makeSubtask(line));
+		return { strategy: "bulleted", subtasks, fanout: subtasks.length };
+	}
+	if (lines.length === 1) {
+		const parts = lines[0].split(CONJUNCTION_SPLIT_RE).map((part) => part.trim()).filter(Boolean);
+		if (parts.length >= 2) {
+			const subtasks = parts.map((part) => makeSubtask(part));
+			return { strategy: "conjunction", subtasks, fanout: subtasks.length };
+		}
+	}
+	const subtask = makeSubtask(goal);
+	return { strategy: "atomic", subtasks: [subtask], fanout: 1 };
+}
+
+function metadataMatches(goal: string, values: string[] | undefined): string[] {
+	const lower = goal.toLowerCase();
+	return (values ?? []).filter((value) => lower.includes(value.toLowerCase()));
+}
+
+export function recommendTeam(goal: string, config: PiTeamsAutonomousConfig = {}, resources?: { teams?: TeamConfig[]; agents?: AgentConfig[] }): TeamRecommendation {
+	const normalized = goal.toLowerCase();
+	const intents = detectTeamIntent(goal, config);
+	const decomposition = decomposeGoal(goal);
+	const reasons: string[] = [];
+	let team: TeamRecommendation["team"] = "default";
+	let workflow: TeamRecommendation["workflow"] = "default";
+	let action: TeamRecommendation["action"] = "run";
+	let confidence: TeamRecommendation["confidence"] = "medium";
+
+	if (intents.length > 0) reasons.push(`Matched explicit intent keyword(s): ${intents.join(", ")}.`);
+
+	const metadataTeamMatches = (resources?.teams ?? [])
+		.map((candidate) => ({ team: candidate, matches: [...metadataMatches(goal, candidate.routing?.triggers), ...metadataMatches(goal, candidate.routing?.useWhen)] }))
+		.filter((candidate) => candidate.matches.length > 0)
+		.sort((a, b) => b.matches.length - a.matches.length);
+
+	const reviewMatches = includesAny(normalized, REVIEW_TERMS);
+	const researchMatches = includesAny(normalized, RESEARCH_TERMS);
+	const fastFixMatches = includesAny(normalized, FAST_FIX_TERMS);
+	const implementationMatches = includesAny(normalized, IMPLEMENTATION_TERMS);
+	const riskyMatches = includesAny(normalized, RISKY_TERMS);
+
+	if (metadataTeamMatches[0]) {
+		team = metadataTeamMatches[0].team.name as TeamRecommendation["team"];
+		workflow = (metadataTeamMatches[0].team.defaultWorkflow ?? metadataTeamMatches[0].team.name) as TeamRecommendation["workflow"];
+		confidence = "high";
+		reasons.push(`Matched team routing metadata for '${metadataTeamMatches[0].team.name}': ${metadataTeamMatches[0].matches.join(", ")}.`);
+	} else if (intents.includes("review") || reviewMatches.length >= 2 || normalized.includes("security review")) {
+		team = "review";
+		workflow = "review";
+		confidence = "high";
+		reasons.push(`Review/audit terms detected: ${reviewMatches.join(", ") || "explicit review intent"}.`);
+	} else if (PARALLEL_RESEARCH_RE.test(goal) || (researchMatches.length >= 2 && (normalized.includes("multiple") || normalized.includes("source") || normalized.includes("project") || normalized.includes("pi-")))) {
+		team = "parallel-research";
+		workflow = "parallel-research";
+		confidence = "high";
+		reasons.push("Deep/multi-source research detected; use parallel shard exploration.");
+	} else if (intents.includes("research") || (researchMatches.length > 0 && implementationMatches.length === 0)) {
+		team = "research";
+		workflow = "research";
+		confidence = researchMatches.length >= 2 ? "high" : "medium";
+		reasons.push(`Research/analysis terms detected: ${researchMatches.join(", ")}.`);
+	} else if (intents.includes("fastFix") || fastFixMatches.length > 0) {
+		team = "fast-fix";
+		workflow = "fast-fix";
+		confidence = "high";
+		reasons.push(`Small fix terms detected: ${fastFixMatches.join(", ") || "fast-fix intent"}.`);
+	} else if (intents.includes("taskList")) {
+		team = "implementation";
+		workflow = "implementation";
+		confidence = "high";
+		reasons.push(`Actionable multi-item task list detected (${decomposition.fanout} bullet${decomposition.fanout === 1 ? "" : "s"}); use coordinated implementation planning.`);
+	} else if (intents.includes("implementation") || implementationMatches.length > 0) {
+		team = "implementation";
+		workflow = "implementation";
+		confidence = implementationMatches.length >= 2 || riskyMatches.length > 0 || decomposition.fanout >= 2 ? "high" : "medium";
+		reasons.push(`Implementation terms detected: ${implementationMatches.join(", ") || "implementation intent"}.`);
+	} else {
+		action = "plan";
+		confidence = wordCount(goal) < 8 ? "low" : "medium";
+		reasons.push("No strong team-specific intent detected; start with planning/default discovery.");
+	}
+
+
+	if (decomposition.strategy !== "atomic") reasons.push(`Goal decomposes into ${decomposition.subtasks.length} subtasks using ${decomposition.strategy} parsing.`);
+	const async = config.preferAsyncForLongTasks === true && (wordCount(goal) > 24 || riskyMatches.length > 0 || implementationMatches.length >= 2 || decomposition.fanout >= 3);
+	const workspaceMode = config.allowWorktreeSuggestion === false ? "single" : (riskyMatches.length > 0 && team === "implementation" ? "worktree" : "single");
+	if (async) reasons.push("Task appears long/risky and config prefers async for long tasks.");
+	if (workspaceMode === "worktree") reasons.push(`Risk/isolation terms detected: ${riskyMatches.join(", ")}.`);
+
+	return { team, workflow, action, async, workspaceMode, confidence, decomposition, reasons };
+}
+
+export function formatRecommendation(goal: string, recommendation: TeamRecommendation): string {
+	return [
+		"pi-crew recommendation:",
+		`Goal: ${goal}`,
+		`Action: ${recommendation.action}`,
+		`Team: ${recommendation.team}`,
+		`Workflow: ${recommendation.workflow}`,
+		`Async: ${recommendation.async}`,
+		`Workspace mode: ${recommendation.workspaceMode}`,
+		`Confidence: ${recommendation.confidence}`,
+		`Decomposition: ${recommendation.decomposition.strategy} (${recommendation.decomposition.fanout} lane${recommendation.decomposition.fanout === 1 ? "" : "s"})`,
+		"Subtasks:",
+		...recommendation.decomposition.subtasks.map((task, index) => `- ${index + 1}. [${task.role}] ${task.subject}`),
+		"Reasons:",
+		...recommendation.reasons.map((reason) => `- ${reason}`),
+		"Suggested tool call:",
+		JSON.stringify({ action: recommendation.action, team: recommendation.team, workflow: recommendation.workflow, goal, async: recommendation.async, workspaceMode: recommendation.workspaceMode }, null, 2),
+	].join("\n");
+}

package/src/extension/team-tool/api.ts

@@ -12,9 +12,10 @@ import { probeLiveSessionRuntime } from "../../subagents/live/session-runtime.ts
 import { currentCrewRole, permissionForRole } from "../../runtime/role-permission.ts";
 import { touchWorkerHeartbeat } from "../../runtime/worker-heartbeat.ts";
 import { agentOutputPath, readCrewAgentEventsCursor, readCrewAgentStatus, readCrewAgents } from "../../runtime/crew-agent-records.ts";
+import { terminateLiveAgentsForRun } from "../../runtime/live-agent-manager.ts";
 import { buildAgentDashboard, readAgentOutput } from "../../runtime/agent-observability.ts";
 import { readForegroundControlStatus, writeForegroundInterruptRequest } from "../../runtime/foreground-control.ts";
-import { followUpLiveAgent, getLiveAgent, listLiveAgents, resumeLiveAgent, steerLiveAgent, stopLiveAgent } from "../../subagents/live/manager.ts";
+import { followUpLiveAgent, getLiveAgent, listActiveLiveAgents, resumeLiveAgent, steerLiveAgent, stopLiveAgent } from "../../subagents/live/manager.ts";
 import { appendLiveAgentControlRequest } from "../../subagents/live/control.ts";
 import { liveControlRealtimeMessage, publishLiveControlRealtime } from "../../subagents/live/realtime.ts";
 import { buildCapabilityInventory } from "../../runtime/capability-inventory.ts";
@@ -121,6 +122,7 @@ export async function handleApi(params: TeamToolParamsValue, ctx: TeamContext):
 				saveRunTasks(manifest, tasks);
 				appendEvent(manifest.eventsPath, { type: "plan.cancelled", runId: manifest.runId, taskId: approval.planTaskId, message: "Adaptive implementation plan was cancelled.", metadata: { provenance: "api" } });
 				manifest = updateRunStatus(manifest, "cancelled", "Plan approval was cancelled.");
+				void terminateLiveAgentsForRun(manifest.runId, "cancelled", appendEvent, manifest.eventsPath).catch(() => {});
 				return result(JSON.stringify({ planApproval: manifest.planApproval, cancelledTasks: tasks.filter((task) => task.status === "cancelled").map((task) => task.id) }, null, 2), { action: "api", status: "ok", runId: manifest.runId, artifactsRoot: manifest.artifactsRoot });
 			});
 		} catch (error) {
@@ -223,7 +225,7 @@ export async function handleApi(params: TeamToolParamsValue, ctx: TeamContext):
 		return result(JSON.stringify({ agentId: agent.id, mailboxMessage: message }, null, 2), { action: "api", status: "ok", runId: loaded.manifest.runId, artifactsRoot: loaded.manifest.artifactsRoot });
 	}
 	if (operation === "list-live-agents") {
-		return result(JSON.stringify(listLiveAgents().filter((agent) => agent.runId === loaded.manifest.runId), null, 2), { action: "api", status: "ok", runId: loaded.manifest.runId, artifactsRoot: loaded.manifest.artifactsRoot });
+		return result(JSON.stringify(listActiveLiveAgents().filter((agent) => agent.runId === loaded.manifest.runId), null, 2), { action: "api", status: "ok", runId: loaded.manifest.runId, artifactsRoot: loaded.manifest.artifactsRoot });
 	}
 	if (operation === "steer-agent" || operation === "follow-up-agent" || operation === "stop-agent" || operation === "resume-agent" || operation === "interrupt-agent") {
 		const agentId = typeof cfg.agentId === "string" ? cfg.agentId : undefined;
@@ -233,6 +235,7 @@ export async function handleApi(params: TeamToolParamsValue, ctx: TeamContext):
 		try {
 			const live = getLiveAgent(agentId);
 			if (live && live.runId !== loaded.manifest.runId) return result(`Live agent '${agentId}' does not belong to run ${loaded.manifest.runId}.`, { action: "api", status: "error", runId: loaded.manifest.runId }, true);
+			if (live && live.workspaceId !== loaded.manifest.cwd) return result(`Live agent '${agentId}' does not belong to workspace ${loaded.manifest.cwd}.`, { action: "api", status: "error", runId: loaded.manifest.runId }, true);
 			if (!live && (operation === "steer-agent" || operation === "follow-up-agent")) throw new Error(`Live agent '${agentId}' not found.`);
 			const liveTaskId = live?.taskId;
 			if ((operation === "steer-agent" || operation === "follow-up-agent") && !liveTaskId) throw new Error(`Live agent '${agentId}' not found.`);