pi-crew 0.2.2 → 0.2.4

package/src/config/defaults.ts

@@ -1,96 +1,96 @@
-export const DEFAULT_CHILD_PI = {
-	postExitStdioGuardMs: 3000,
-	finalDrainMs: 5000,
-	hardKillMs: 3000,
-	// Child workers can spend more than a few seconds in provider calls or long-running tools without emitting stdout.
-	// Keep this as a coarse stuck-worker guard rather than a short per-message latency budget.
-	responseTimeoutMs: 5 * 60_000,
-	maxCaptureBytes: 256 * 1024,
-	maxAssistantTextChars: 8192,
-	maxToolResultChars: 1024,
-	maxToolInputChars: 2048,
-	maxCompactContentChars: 4096,
-};
-
-export const DEFAULT_LIVE_SESSION = {
-	/** Maximum wall-clock time for a single live-session task before abort (ms). */
-	responseTimeoutMs: 5 * 60_000,
-	/** Maximum yield reminder attempts before accepting no-yield. */
-	maxYieldRetries: 3,
-	/** Polling interval for session idle check during yield enforcement (ms). */
-	yieldPollIntervalMs: 500,
-	/** Maximum time to wait for session idle after prompt (ms). */
-	idleWaitTimeoutMs: 60_000,
-};
-
-export const DEFAULT_LOCKS = {
-	staleMs: 30_000,
-};
-
-export const DEFAULT_CONCURRENCY = {
-	hardCap: 8,
-	workflow: {
-		parallelResearch: 4,
-		research: 3,
-		implementation: 4,
-		review: 3,
-		default: 3,
-	},
-	fallback: 2,
-};
-
-export const DEFAULT_EVENT_LOG = {
-	terminalEventTypes: ["run.blocked", "run.completed", "run.failed", "run.cancelled", "task.completed", "task.failed", "task.skipped", "task.cancelled"],
-};
-
-export const DEFAULT_ARTIFACT_CLEANUP = {
-	maxAgeDays: 7,
-};
-
-export const DEFAULT_PATHS = {
-	state: {
-		runsSubdir: "state/runs",
-		artifactsSubdir: "artifacts",
-		subagentsSubdir: "state/subagents",
-		importsSubdir: "imports",
-		worktreesSubdir: "worktrees",
-		manifestFile: "manifest.json",
-		tasksFile: "tasks.json",
-		eventsFile: "events.jsonl",
-	},
-};
-
-export const DEFAULT_UI = {
-	refreshMs: 1000,
-	notifierIntervalMs: 5000,
-	widgetDefaultFrameMs: 1000,
-	widgetPlacement: "aboveEditor" as const,
-	widgetMaxLines: 8,
-	powerbar: true,
-	dashboardPlacement: "center" as const,
-	dashboardWidth: 72,
-	dashboardLiveRefreshMs: 1000,
-	autoOpenDashboard: false,
-	autoOpenDashboardForForegroundRuns: false,
-	showModel: true,
-	showTokens: true,
-	showTools: true,
-	transcriptTailBytes: 1024 * 1024,
-	mascotStyle: "cat" as const,
-	mascotEffect: "random" as const,
-};
-
-export const DEFAULT_NOTIFICATIONS = {
-	severityFilter: ["warning", "error", "critical"] as const,
-	dedupWindowMs: 30_000,
-	batchWindowMs: 0,
-	sinkRetentionDays: 7,
-};
-
-export const DEFAULT_CACHE = {
-	manifestMaxEntries: 64,
-};
-
-export const DEFAULT_SUBAGENT = {
-	stuckBlockedNotifyMs: 5 * 60_000,
-};
+export const DEFAULT_CHILD_PI = {
+	postExitStdioGuardMs: 3000,
+	finalDrainMs: 5000,
+	hardKillMs: 3000,
+	// Child workers can spend more than a few seconds in provider calls or long-running tools without emitting stdout.
+	// Keep this as a coarse stuck-worker guard rather than a short per-message latency budget.
+	responseTimeoutMs: 5 * 60_000,
+	maxCaptureBytes: 256 * 1024,
+	maxAssistantTextChars: 8192,
+	maxToolResultChars: 1024,
+	maxToolInputChars: 2048,
+	maxCompactContentChars: 4096,
+};
+
+export const DEFAULT_LIVE_SESSION = {
+	/** Maximum wall-clock time for a single live-session task before abort (ms). */
+	responseTimeoutMs: 5 * 60_000,
+	/** Maximum yield reminder attempts before accepting no-yield. */
+	maxYieldRetries: 3,
+	/** Polling interval for session idle check during yield enforcement (ms). */
+	yieldPollIntervalMs: 500,
+	/** Maximum time to wait for session idle after prompt (ms). */
+	idleWaitTimeoutMs: 60_000,
+};
+
+export const DEFAULT_LOCKS = {
+	staleMs: 30_000,
+};
+
+export const DEFAULT_CONCURRENCY = {
+	hardCap: 8,
+	workflow: {
+		parallelResearch: 4,
+		research: 3,
+		implementation: 4,
+		review: 3,
+		default: 3,
+	},
+	fallback: 2,
+};
+
+export const DEFAULT_EVENT_LOG = {
+	terminalEventTypes: ["run.blocked", "run.completed", "run.failed", "run.cancelled", "task.completed", "task.failed", "task.skipped", "task.cancelled"],
+};
+
+export const DEFAULT_ARTIFACT_CLEANUP = {
+	maxAgeDays: 7,
+};
+
+export const DEFAULT_PATHS = {
+	state: {
+		runsSubdir: "state/runs",
+		artifactsSubdir: "artifacts",
+		subagentsSubdir: "state/subagents",
+		importsSubdir: "imports",
+		worktreesSubdir: "worktrees",
+		manifestFile: "manifest.json",
+		tasksFile: "tasks.json",
+		eventsFile: "events.jsonl",
+	},
+};
+
+export const DEFAULT_UI = {
+	refreshMs: 1000,
+	notifierIntervalMs: 5000,
+	widgetDefaultFrameMs: 1000,
+	widgetPlacement: "aboveEditor" as const,
+	widgetMaxLines: 8,
+	powerbar: true,
+	dashboardPlacement: "center" as const,
+	dashboardWidth: 72,
+	dashboardLiveRefreshMs: 1000,
+	autoOpenDashboard: false,
+	autoOpenDashboardForForegroundRuns: false,
+	showModel: true,
+	showTokens: true,
+	showTools: true,
+	transcriptTailBytes: 1024 * 1024,
+	mascotStyle: "cat" as const,
+	mascotEffect: "random" as const,
+};
+
+export const DEFAULT_NOTIFICATIONS = {
+	severityFilter: ["warning", "error", "critical"] as const,
+	dedupWindowMs: 30_000,
+	batchWindowMs: 0,
+	sinkRetentionDays: 7,
+};
+
+export const DEFAULT_CACHE = {
+	manifestMaxEntries: 64,
+};
+
+export const DEFAULT_SUBAGENT = {
+	stuckBlockedNotifyMs: 5 * 60_000,
+};

package/src/config/drift-detector.ts

@@ -1,211 +1,211 @@
-import type { PiTeamsConfig } from "./config.ts";
-import { PiTeamsConfigSchema } from "../schema/config-schema.ts";
-
-/**
- * A single drift finding between discovered resources and config expectations.
- */
-export interface DriftItem {
-	kind: "agent" | "team" | "workflow" | "config-key";
-	name: string;
-	status: "missing" | "extra" | "mismatched";
-	expected?: string;
-	actual?: string;
-	severity: "error" | "warning";
-}
-
-/**
- * Summary counts by drift status.
- */
-export interface DriftSummary {
-	missing: number;
-	extra: number;
-	mismatched: number;
-}
-
-/**
- * Full drift report produced by `detectDrift`.
- */
-export interface DriftReport {
-	hasDrift: boolean;
-	items: DriftItem[];
-	summary: DriftSummary;
-}
-
-/**
- * Discovered resources passed into the drift detector.
- */
-export interface DiscoveredResources {
-	agents: string[];
-	teams: string[];
-	workflows: string[];
-}
-
-/**
- * Config references extracted from team roles and workflow steps.
- * Used to compare against discovered resources.
- */
-export interface ConfigReferences {
-	agents: Set<string>;
-	teams: Set<string>;
-	workflows: Set<string>;
-}
-
-/**
- * Known top-level config keys allowed by the schema.
- */
-const SCHEMA_KEYS: ReadonlySet<string> = new Set<string>(
-	Object.keys(PiTeamsConfigSchema.properties ?? {}),
-);
-
-/**
- * Extract all agent, team, and workflow names referenced in a raw config object.
- *
- * Looks at:
- * - `agents.overrides` keys → referenced agent names
- * - Top-level keys that aren't in the schema are ignored (handled separately as config-key drift)
- */
-function extractConfigReferences(config: Record<string, unknown>): ConfigReferences {
-	const agents = new Set<string>();
-	const teams = new Set<string>();
-	const workflows = new Set<string>();
-
-	// agents.overrides keys are explicit agent references
-	const agentsObj = typeof config.agents === "object" && config.agents !== null && !Array.isArray(config.agents)
-		? config.agents as Record<string, unknown>
-		: undefined;
-	if (agentsObj) {
-		const overrides = typeof agentsObj.overrides === "object" && agentsObj.overrides !== null && !Array.isArray(agentsObj.overrides)
-			? agentsObj.overrides as Record<string, unknown>
-			: undefined;
-		if (overrides) {
-			for (const name of Object.keys(overrides)) {
-				agents.add(name);
-			}
-		}
-	}
-
-	return { agents, teams, workflows };
-}
-
-/**
- * Detect config drift between discovered resources and the configuration.
- *
- * Checks:
- * 1. **Missing**: resource referenced in config (e.g. agents.overrides) but not discovered → error
- * 2. **Extra**: discovered resource not referenced anywhere in config → warning
- * 3. **Mismatched**: resource exists in both but with structural differences → warning
- * 4. **Config keys**: config keys not present in the schema → warning
- *
- * For agents: compares against `agents.overrides` in config. Discovered agents not in overrides
- * are NOT considered extra (they may be built-in). Only agents referenced in overrides but not
- * discovered are considered missing.
- *
- * For teams/workflows: the config currently doesn't have explicit team/workflow references,
- * so missing/extra checks rely solely on what resources reference each other.
- */
-export function detectDrift(
-	discovered: DiscoveredResources,
-	config: PiTeamsConfig,
-): DriftReport {
-	const items: DriftItem[] = [];
-
-	const configRaw = config as Record<string, unknown>;
-	const refs = extractConfigReferences(configRaw);
-
-	// --- Agent drift ---
-	const discoveredAgentSet = new Set<string>(discovered.agents);
-
-	// Missing: referenced in agents.overrides but not discovered
-	for (const agentName of refs.agents) {
-		if (!discoveredAgentSet.has(agentName)) {
-			items.push({
-				kind: "agent",
-				name: agentName,
-				status: "missing",
-				expected: "agent file discovered",
-				actual: "not found",
-				severity: "error",
-			});
-		}
-	}
-
-	// Extra: discovered agent referenced in overrides doesn't apply here;
-	// discovered agents not in overrides are not "extra" since they can be built-in.
-	// We only check if the override references a disabled agent that doesn't exist.
-
-	// --- Team drift ---
-	// Teams reference agents via roles; check if any role.agent is not in discovered agents
-	// This is already handled by validate-resources, so we keep it lightweight here.
-	// We do NOT mark teams as "extra" because teams can exist without explicit config references.
-
-	// --- Workflow drift ---
-	// Similar to teams — workflows are discovered but not directly referenced in config.
-	// No extra/missing checks for workflows from config alone.
-
-	// --- Config-key drift ---
-	const configKeys = Object.keys(configRaw);
-	for (const key of configKeys) {
-		if (!SCHEMA_KEYS.has(key)) {
-			items.push({
-				kind: "config-key",
-				name: key,
-				status: "extra",
-				expected: `key not in schema`,
-				actual: `present in config`,
-				severity: "warning",
-			});
-		}
-	}
-
-	// --- Mismatched config-key check ---
-	// Check if agents.overrides references exist but have unexpected structure
-	if (config.agents?.overrides) {
-		for (const [agentName, override] of Object.entries(config.agents.overrides)) {
-			if (override && typeof override === "object") {
-				const overrideKeys = Object.keys(override as Record<string, unknown>);
-				const knownOverrideKeys = new Set(["disabled", "model", "fallbackModels", "thinking", "tools", "skills"]);
-				const unknownKeys = overrideKeys.filter((key) => !knownOverrideKeys.has(key));
-				if (unknownKeys.length > 0) {
-					items.push({
-						kind: "agent",
-						name: agentName,
-						status: "mismatched",
-						expected: `override keys from schema: ${[...knownOverrideKeys].join(", ")}`,
-						actual: `unknown keys: ${unknownKeys.join(", ")}`,
-						severity: "warning",
-					});
-				}
-			}
-		}
-	}
-
-	// --- Build summary ---
-	const missing = items.filter((item) => item.status === "missing").length;
-	const extra = items.filter((item) => item.status === "extra").length;
-	const mismatched = items.filter((item) => item.status === "mismatched").length;
-
-	return {
-		hasDrift: items.length > 0,
-		items,
-		summary: { missing, extra, mismatched },
-	};
-}
-
-/**
- * Format a drift report into a human-readable multi-line string.
- */
-export function formatDriftReport(report: DriftReport): string {
-	if (!report.hasDrift) {
-		return "No drift detected.";
-	}
-	const lines: string[] = [
-		`Drift summary: ${report.summary.missing} missing, ${report.summary.extra} extra, ${report.summary.mismatched} mismatched`,
-		"",
-	];
-	for (const item of report.items) {
-		const severityTag = item.severity === "error" ? "ERROR" : "WARN";
-		const detail = item.expected && item.actual ? ` (expected: ${item.expected}, actual: ${item.actual})` : "";
-		lines.push(`- ${severityTag} [${item.kind}] ${item.name}: ${item.status}${detail}`);
-	}
-	return lines.join("\n");
-}
+import type { PiTeamsConfig } from "./config.ts";
+import { PiTeamsConfigSchema } from "../schema/config-schema.ts";
+
+/**
+ * A single drift finding between discovered resources and config expectations.
+ */
+export interface DriftItem {
+	kind: "agent" | "team" | "workflow" | "config-key";
+	name: string;
+	status: "missing" | "extra" | "mismatched";
+	expected?: string;
+	actual?: string;
+	severity: "error" | "warning";
+}
+
+/**
+ * Summary counts by drift status.
+ */
+export interface DriftSummary {
+	missing: number;
+	extra: number;
+	mismatched: number;
+}
+
+/**
+ * Full drift report produced by `detectDrift`.
+ */
+export interface DriftReport {
+	hasDrift: boolean;
+	items: DriftItem[];
+	summary: DriftSummary;
+}
+
+/**
+ * Discovered resources passed into the drift detector.
+ */
+export interface DiscoveredResources {
+	agents: string[];
+	teams: string[];
+	workflows: string[];
+}
+
+/**
+ * Config references extracted from team roles and workflow steps.
+ * Used to compare against discovered resources.
+ */
+export interface ConfigReferences {
+	agents: Set<string>;
+	teams: Set<string>;
+	workflows: Set<string>;
+}
+
+/**
+ * Known top-level config keys allowed by the schema.
+ */
+const SCHEMA_KEYS: ReadonlySet<string> = new Set<string>(
+	Object.keys(PiTeamsConfigSchema.properties ?? {}),
+);
+
+/**
+ * Extract all agent, team, and workflow names referenced in a raw config object.
+ *
+ * Looks at:
+ * - `agents.overrides` keys → referenced agent names
+ * - Top-level keys that aren't in the schema are ignored (handled separately as config-key drift)
+ */
+function extractConfigReferences(config: Record<string, unknown>): ConfigReferences {
+	const agents = new Set<string>();
+	const teams = new Set<string>();
+	const workflows = new Set<string>();
+
+	// agents.overrides keys are explicit agent references
+	const agentsObj = typeof config.agents === "object" && config.agents !== null && !Array.isArray(config.agents)
+		? config.agents as Record<string, unknown>
+		: undefined;
+	if (agentsObj) {
+		const overrides = typeof agentsObj.overrides === "object" && agentsObj.overrides !== null && !Array.isArray(agentsObj.overrides)
+			? agentsObj.overrides as Record<string, unknown>
+			: undefined;
+		if (overrides) {
+			for (const name of Object.keys(overrides)) {
+				agents.add(name);
+			}
+		}
+	}
+
+	return { agents, teams, workflows };
+}
+
+/**
+ * Detect config drift between discovered resources and the configuration.
+ *
+ * Checks:
+ * 1. **Missing**: resource referenced in config (e.g. agents.overrides) but not discovered → error
+ * 2. **Extra**: discovered resource not referenced anywhere in config → warning
+ * 3. **Mismatched**: resource exists in both but with structural differences → warning
+ * 4. **Config keys**: config keys not present in the schema → warning
+ *
+ * For agents: compares against `agents.overrides` in config. Discovered agents not in overrides
+ * are NOT considered extra (they may be built-in). Only agents referenced in overrides but not
+ * discovered are considered missing.
+ *
+ * For teams/workflows: the config currently doesn't have explicit team/workflow references,
+ * so missing/extra checks rely solely on what resources reference each other.
+ */
+export function detectDrift(
+	discovered: DiscoveredResources,
+	config: PiTeamsConfig,
+): DriftReport {
+	const items: DriftItem[] = [];
+
+	const configRaw = config as Record<string, unknown>;
+	const refs = extractConfigReferences(configRaw);
+
+	// --- Agent drift ---
+	const discoveredAgentSet = new Set<string>(discovered.agents);
+
+	// Missing: referenced in agents.overrides but not discovered
+	for (const agentName of refs.agents) {
+		if (!discoveredAgentSet.has(agentName)) {
+			items.push({
+				kind: "agent",
+				name: agentName,
+				status: "missing",
+				expected: "agent file discovered",
+				actual: "not found",
+				severity: "error",
+			});
+		}
+	}
+
+	// Extra: discovered agent referenced in overrides doesn't apply here;
+	// discovered agents not in overrides are not "extra" since they can be built-in.
+	// We only check if the override references a disabled agent that doesn't exist.
+
+	// --- Team drift ---
+	// Teams reference agents via roles; check if any role.agent is not in discovered agents
+	// This is already handled by validate-resources, so we keep it lightweight here.
+	// We do NOT mark teams as "extra" because teams can exist without explicit config references.
+
+	// --- Workflow drift ---
+	// Similar to teams — workflows are discovered but not directly referenced in config.
+	// No extra/missing checks for workflows from config alone.
+
+	// --- Config-key drift ---
+	const configKeys = Object.keys(configRaw);
+	for (const key of configKeys) {
+		if (!SCHEMA_KEYS.has(key)) {
+			items.push({
+				kind: "config-key",
+				name: key,
+				status: "extra",
+				expected: `key not in schema`,
+				actual: `present in config`,
+				severity: "warning",
+			});
+		}
+	}
+
+	// --- Mismatched config-key check ---
+	// Check if agents.overrides references exist but have unexpected structure
+	if (config.agents?.overrides) {
+		for (const [agentName, override] of Object.entries(config.agents.overrides)) {
+			if (override && typeof override === "object") {
+				const overrideKeys = Object.keys(override as Record<string, unknown>);
+				const knownOverrideKeys = new Set(["disabled", "model", "fallbackModels", "thinking", "tools", "skills"]);
+				const unknownKeys = overrideKeys.filter((key) => !knownOverrideKeys.has(key));
+				if (unknownKeys.length > 0) {
+					items.push({
+						kind: "agent",
+						name: agentName,
+						status: "mismatched",
+						expected: `override keys from schema: ${[...knownOverrideKeys].join(", ")}`,
+						actual: `unknown keys: ${unknownKeys.join(", ")}`,
+						severity: "warning",
+					});
+				}
+			}
+		}
+	}
+
+	// --- Build summary ---
+	const missing = items.filter((item) => item.status === "missing").length;
+	const extra = items.filter((item) => item.status === "extra").length;
+	const mismatched = items.filter((item) => item.status === "mismatched").length;
+
+	return {
+		hasDrift: items.length > 0,
+		items,
+		summary: { missing, extra, mismatched },
+	};
+}
+
+/**
+ * Format a drift report into a human-readable multi-line string.
+ */
+export function formatDriftReport(report: DriftReport): string {
+	if (!report.hasDrift) {
+		return "No drift detected.";
+	}
+	const lines: string[] = [
+		`Drift summary: ${report.summary.missing} missing, ${report.summary.extra} extra, ${report.summary.mismatched} mismatched`,
+		"",
+	];
+	for (const item of report.items) {
+		const severityTag = item.severity === "error" ? "ERROR" : "WARN";
+		const detail = item.expected && item.actual ? ` (expected: ${item.expected}, actual: ${item.actual})` : "";
+		lines.push(`- ${severityTag} [${item.kind}] ${item.name}: ${item.status}${detail}`);
+	}
+	return lines.join("\n");
+}