pi-crew 0.1.49 → 0.2.0

package/src/workflows/validate-workflow.ts

@@ -1,40 +1,40 @@
-import type { TeamConfig } from "../teams/team-config.ts";
-import type { WorkflowConfig } from "./workflow-config.ts";
-
-export function validateWorkflowForTeam(workflow: WorkflowConfig, team: TeamConfig): string[] {
-	const errors: string[] = [];
-	const roles = new Set(team.roles.map((role) => role.name));
-	const stepIds = new Set<string>();
-
-	for (const step of workflow.steps) {
-		if (stepIds.has(step.id)) errors.push(`Duplicate workflow step id '${step.id}'.`);
-		stepIds.add(step.id);
-		if (!roles.has(step.role)) errors.push(`Step '${step.id}' references unknown team role '${step.role}'.`);
-	}
-
-	for (const step of workflow.steps) {
-		for (const dep of step.dependsOn ?? []) {
-			if (!stepIds.has(dep)) errors.push(`Step '${step.id}' depends on unknown step '${dep}'.`);
-		}
-	}
-
-	const visiting = new Set<string>();
-	const visited = new Set<string>();
-	const byId = new Map(workflow.steps.map((step) => [step.id, step]));
-
-	function visit(id: string, trail: string[]): void {
-		if (visited.has(id)) return;
-		if (visiting.has(id)) {
-			errors.push(`Workflow dependency cycle detected: ${[...trail, id].join(" -> ")}.`);
-			return;
-		}
-		visiting.add(id);
-		const step = byId.get(id);
-		for (const dep of step?.dependsOn ?? []) visit(dep, [...trail, id]);
-		visiting.delete(id);
-		visited.add(id);
-	}
-
-	for (const step of workflow.steps) visit(step.id, []);
-	return [...new Set(errors)];
-}
+import type { TeamConfig } from "../teams/team-config.ts";
+import type { WorkflowConfig } from "./workflow-config.ts";
+
+export function validateWorkflowForTeam(workflow: WorkflowConfig, team: TeamConfig): string[] {
+	const errors: string[] = [];
+	const roles = new Set(team.roles.map((role) => role.name));
+	const stepIds = new Set<string>();
+
+	for (const step of workflow.steps) {
+		if (stepIds.has(step.id)) errors.push(`Duplicate workflow step id '${step.id}'.`);
+		stepIds.add(step.id);
+		if (!roles.has(step.role)) errors.push(`Step '${step.id}' references unknown team role '${step.role}'.`);
+	}
+
+	for (const step of workflow.steps) {
+		for (const dep of step.dependsOn ?? []) {
+			if (!stepIds.has(dep)) errors.push(`Step '${step.id}' depends on unknown step '${dep}'.`);
+		}
+	}
+
+	const visiting = new Set<string>();
+	const visited = new Set<string>();
+	const byId = new Map(workflow.steps.map((step) => [step.id, step]));
+
+	function visit(id: string, trail: string[]): void {
+		if (visited.has(id)) return;
+		if (visiting.has(id)) {
+			errors.push(`Workflow dependency cycle detected: ${[...trail, id].join(" -> ")}.`);
+			return;
+		}
+		visiting.add(id);
+		const step = byId.get(id);
+		for (const dep of step?.dependsOn ?? []) visit(dep, [...trail, id]);
+		visiting.delete(id);
+		visited.add(id);
+	}
+
+	for (const step of workflow.steps) visit(step.id, []);
+	return [...new Set(errors)];
+}

package/src/worktree/branch-freshness.ts

@@ -1,45 +1,45 @@
-import { execFileSync } from "node:child_process";
-
-export type BranchFreshnessStatus = "fresh" | "stale" | "diverged" | "unknown";
-export type StaleBranchPolicy = "warn" | "block" | "auto_rebase" | "auto_merge_forward";
-
-export interface BranchFreshness {
-	status: BranchFreshnessStatus;
-	branch?: string;
-	mainRef: string;
-	ahead: number;
-	behind: number;
-	missingFixes: string[];
-	message: string;
-	error?: string;
-}
-
-function git(cwd: string, args: string[]): string {
-	return execFileSync("git", args, { cwd, encoding: "utf-8", stdio: ["ignore", "pipe", "pipe"] }).trim();
-}
-
-function count(cwd: string, range: string): number {
-	const raw = git(cwd, ["rev-list", "--count", range]);
-	const parsed = Number.parseInt(raw, 10);
-	return Number.isFinite(parsed) ? parsed : 0;
-}
-
-export function checkBranchFreshness(cwd: string, mainRef = "main"): BranchFreshness {
-	try {
-		git(cwd, ["rev-parse", "--is-inside-work-tree"]);
-		const branch = git(cwd, ["rev-parse", "--abbrev-ref", "HEAD"]);
-		const behind = count(cwd, `${branch}..${mainRef}`);
-		const ahead = count(cwd, `${mainRef}..${branch}`);
-		const missingFixes = behind > 0 ? git(cwd, ["log", "--format=%s", `${branch}..${mainRef}`]).split("\n").map((line) => line.trim()).filter(Boolean) : [];
-		if (behind === 0) return { status: "fresh", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' is fresh against ${mainRef}.` };
-		if (ahead > 0) return { status: "diverged", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' diverged from ${mainRef}: ahead=${ahead}, behind=${behind}.` };
-		return { status: "stale", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' is ${behind} commit(s) behind ${mainRef}.` };
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		return { status: "unknown", mainRef, ahead: 0, behind: 0, missingFixes: [], message: "Branch freshness could not be determined.", error: message };
-	}
-}
-
-export function shouldBlockForBranchFreshness(freshness: BranchFreshness, policy: StaleBranchPolicy = "warn"): boolean {
-	return policy === "block" && (freshness.status === "stale" || freshness.status === "diverged");
-}
+import { execFileSync } from "node:child_process";
+
+export type BranchFreshnessStatus = "fresh" | "stale" | "diverged" | "unknown";
+export type StaleBranchPolicy = "warn" | "block" | "auto_rebase" | "auto_merge_forward";
+
+export interface BranchFreshness {
+	status: BranchFreshnessStatus;
+	branch?: string;
+	mainRef: string;
+	ahead: number;
+	behind: number;
+	missingFixes: string[];
+	message: string;
+	error?: string;
+}
+
+function git(cwd: string, args: string[]): string {
+	return execFileSync("git", args, { cwd, encoding: "utf-8", stdio: ["ignore", "pipe", "pipe"] }).trim();
+}
+
+function count(cwd: string, range: string): number {
+	const raw = git(cwd, ["rev-list", "--count", range]);
+	const parsed = Number.parseInt(raw, 10);
+	return Number.isFinite(parsed) ? parsed : 0;
+}
+
+export function checkBranchFreshness(cwd: string, mainRef = "main"): BranchFreshness {
+	try {
+		git(cwd, ["rev-parse", "--is-inside-work-tree"]);
+		const branch = git(cwd, ["rev-parse", "--abbrev-ref", "HEAD"]);
+		const behind = count(cwd, `${branch}..${mainRef}`);
+		const ahead = count(cwd, `${mainRef}..${branch}`);
+		const missingFixes = behind > 0 ? git(cwd, ["log", "--format=%s", `${branch}..${mainRef}`]).split("\n").map((line) => line.trim()).filter(Boolean) : [];
+		if (behind === 0) return { status: "fresh", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' is fresh against ${mainRef}.` };
+		if (ahead > 0) return { status: "diverged", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' diverged from ${mainRef}: ahead=${ahead}, behind=${behind}.` };
+		return { status: "stale", branch, mainRef, ahead, behind, missingFixes, message: `Branch '${branch}' is ${behind} commit(s) behind ${mainRef}.` };
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		return { status: "unknown", mainRef, ahead: 0, behind: 0, missingFixes: [], message: "Branch freshness could not be determined.", error: message };
+	}
+}
+
+export function shouldBlockForBranchFreshness(freshness: BranchFreshness, policy: StaleBranchPolicy = "warn"): boolean {
+	return policy === "block" && (freshness.status === "stale" || freshness.status === "diverged");
+}

package/src/worktree/worktree-manager.ts

@@ -77,9 +77,17 @@ function runSetupHook(manifest: TeamRunManifest, task: TeamTaskState, repoRoot:
 	if (result.status !== 0) throw new Error(`worktree setup hook failed with exit code ${result.status}: ${result.stderr || result.stdout || "no output"}`);
 	const trimmed = result.stdout.trim();
 	if (!trimmed) return [];
-	const parsed = JSON.parse(trimmed) as { syntheticPaths?: unknown };
-	if (!Array.isArray(parsed.syntheticPaths)) return [];
-	return [...new Set(parsed.syntheticPaths.filter((entry): entry is string => typeof entry === "string").map((entry) => normalizeSyntheticPath(worktreePath, entry)))];
+	try {
+		// Extract JSON from last line — hooks may output debug logging before JSON
+		const lines = trimmed.split(/\r?\n/);
+		const lastLine = lines[lines.length - 1] ?? trimmed;
+		const parsed = JSON.parse(lastLine) as { syntheticPaths?: unknown };
+		if (!Array.isArray(parsed.syntheticPaths)) return [];
+		return [...new Set(parsed.syntheticPaths.filter((entry): entry is string => typeof entry === "string").map((entry) => normalizeSyntheticPath(worktreePath, entry)))];
+	} catch {
+		// Hook output was not valid JSON — treat as no synthetic paths
+		return [];
+	}
 }
 
 export function prepareTaskWorkspace(manifest: TeamRunManifest, task: TeamTaskState): PreparedTaskWorkspace {

package/teams/default.team.md

@@ -1,12 +1,12 @@
----
-name: default
-description: Balanced team for ordinary implementation tasks
-defaultWorkflow: default
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer fast discovery
-- planner: agent=planner plan the work
-- executor: agent=executor implement changes
-- verifier: agent=verifier verify completion
+---
+name: default
+description: Balanced team for ordinary implementation tasks
+defaultWorkflow: default
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer fast discovery
+- planner: agent=planner plan the work
+- executor: agent=executor implement changes
+- verifier: agent=verifier verify completion

package/teams/fast-fix.team.md

@@ -1,11 +1,11 @@
----
-name: fast-fix
-description: Small team for quick bug fixes
-defaultWorkflow: fast-fix
-workspaceMode: single
-maxConcurrency: 1
----
-
-- explorer: agent=explorer find the relevant files
-- executor: agent=executor make the fix
-- verifier: agent=verifier verify the fix
+---
+name: fast-fix
+description: Small team for quick bug fixes
+defaultWorkflow: fast-fix
+workspaceMode: single
+maxConcurrency: 1
+---
+
+- explorer: agent=explorer find the relevant files
+- executor: agent=executor make the fix
+- verifier: agent=verifier verify the fix

package/teams/implementation.team.md

@@ -1,18 +1,18 @@
----
-name: implementation
-description: Full implementation team with parallel specialists, critique, execution, review, and verification
-defaultWorkflow: implementation
-workspaceMode: single
-maxConcurrency: 3
----
-
-- explorer: agent=explorer map the codebase
-- analyst: agent=analyst clarify requirements and constraints
-- planner: agent=planner create execution plan
-- critic: agent=critic challenge and synthesize specialist findings
-- executor: agent=executor implement the plan
-- reviewer: agent=reviewer review the implementation
-- security-reviewer: agent=security-reviewer review security and trust boundaries
-- test-engineer: agent=test-engineer design and run verification
-- verifier: agent=verifier verify done
-- writer: agent=writer summarize documentation or release notes when needed
+---
+name: implementation
+description: Full implementation team with parallel specialists, critique, execution, review, and verification
+defaultWorkflow: implementation
+workspaceMode: single
+maxConcurrency: 3
+---
+
+- explorer: agent=explorer map the codebase
+- analyst: agent=analyst clarify requirements and constraints
+- planner: agent=planner create execution plan
+- critic: agent=critic challenge and synthesize specialist findings
+- executor: agent=executor implement the plan
+- reviewer: agent=reviewer review the implementation
+- security-reviewer: agent=security-reviewer review security and trust boundaries
+- test-engineer: agent=test-engineer design and run verification
+- verifier: agent=verifier verify done
+- writer: agent=writer summarize documentation or release notes when needed

package/teams/parallel-research.team.md

@@ -1,14 +1,14 @@
----
-name: parallel-research
-description: Parallel research team for multi-project/source audits
-workspaceMode: single
-defaultWorkflow: parallel-research
-maxConcurrency: 4
-triggers: đọc sâu, deep read, deep research, source audit, multiple projects, parallel research, pi-*
-category: research
-cost: cheap
----
-
-- explorer: agent=explorer gather source facts in parallel shards
-- analyst: agent=analyst synthesize shard findings
-- writer: agent=writer produce final notes
+---
+name: parallel-research
+description: Parallel research team for multi-project/source audits
+workspaceMode: single
+defaultWorkflow: parallel-research
+maxConcurrency: 4
+triggers: đọc sâu, deep read, deep research, source audit, multiple projects, parallel research, pi-*
+category: research
+cost: cheap
+---
+
+- explorer: agent=explorer gather source facts in parallel shards
+- analyst: agent=analyst synthesize shard findings
+- writer: agent=writer produce final notes

package/teams/research.team.md

@@ -1,11 +1,11 @@
----
-name: research
-description: Team for investigation and documentation
-defaultWorkflow: research
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer gather codebase facts
-- analyst: agent=analyst analyze findings
-- writer: agent=writer produce final notes
+---
+name: research
+description: Team for investigation and documentation
+defaultWorkflow: research
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer gather codebase facts
+- analyst: agent=analyst analyze findings
+- writer: agent=writer produce final notes

package/teams/review.team.md

@@ -1,12 +1,12 @@
----
-name: review
-description: Team for code review and security review
-defaultWorkflow: review
-workspaceMode: single
-maxConcurrency: 2
----
-
-- explorer: agent=explorer understand changed areas
-- reviewer: agent=reviewer review correctness and maintainability
-- security-reviewer: agent=security-reviewer review security risks
-- verifier: agent=verifier summarize pass/fail
+---
+name: review
+description: Team for code review and security review
+defaultWorkflow: review
+workspaceMode: single
+maxConcurrency: 2
+---
+
+- explorer: agent=explorer understand changed areas
+- reviewer: agent=reviewer review correctness and maintainability
+- security-reviewer: agent=security-reviewer review security risks
+- verifier: agent=verifier summarize pass/fail

package/workflows/default.workflow.md

@@ -1,29 +1,30 @@
----
-name: default
-description: Explore, plan, execute, and verify
----
-
-## explore
-role: explorer
-
-Explore the codebase for the goal: {goal}
-
-## plan
-role: planner
-dependsOn: explore
-output: plan.md
-
-Create a concise implementation plan for: {goal}
-
-## execute
-role: executor
-dependsOn: plan
-
-Implement the plan for: {goal}
-
-## verify
-role: verifier
-dependsOn: execute
-verify: true
-
-Verify completion for: {goal}
+---
+name: default
+description: Explore, plan, execute, and verify
+---
+
+## explore
+role: explorer
+
+Explore the codebase for the goal: {goal}
+
+## plan
+role: planner
+dependsOn: explore
+output: plan.md
+
+Create a concise implementation plan for: {goal}
+
+## execute
+role: executor
+dependsOn: plan
+
+Implement the plan for: {goal}
+
+## verify
+role: verifier
+dependsOn: execute
+verify: true
+
+Verify completion for: {goal}
+Run tests ONCE (cache to .crew/cache/), read changed files from executor context. Cross-reference test output with the changes. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.

package/workflows/fast-fix.workflow.md

@@ -1,22 +1,23 @@
----
-name: fast-fix
-description: Minimal workflow for small fixes
----
-
-## explore
-role: explorer
-
-Find the likely source of the issue: {goal}
-
-## execute
-role: executor
-dependsOn: explore
-
-Make the smallest safe fix.
-
-## verify
-role: verifier
-dependsOn: execute
-verify: true
-
-Verify the fix with available evidence.
+---
+name: fast-fix
+description: Minimal workflow for small fixes
+---
+
+## explore
+role: explorer
+
+Find the likely source of the issue: {goal}
+
+## execute
+role: executor
+dependsOn: explore
+
+Make the smallest safe fix.
+
+## verify
+role: verifier
+dependsOn: execute
+verify: true
+
+Verify the fix with available evidence.
+Run tests ONCE (cache to .crew/cache/), read changed files from executor context. Cross-reference test output with the fix. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.

package/workflows/implementation.workflow.md

@@ -1,38 +1,43 @@
----
-name: implementation
-description: Adaptive implementation workflow where a planner agent decides the subagent fanout
----
-
-## assess
-role: planner
-output: adaptive-plan.json
-
-Assess this task and decide how many subagents are actually needed for: {goal}
-
-You are the orchestration planner. Inspect the repository enough to choose an efficient crew; do not use a fixed template. Small/simple tasks may need one executor plus one verifier. Risky or broad tasks may need parallel explorers, specialists, implementers, reviewers, security reviewers, or test engineers.
-
-Return a concise rationale, then include exactly one JSON block between these markers:
-
-ADAPTIVE_PLAN_JSON_START
-{
-  "phases": [
-    {
-      "name": "short-phase-name",
-      "tasks": [
-        {
-          "role": "explorer|analyst|planner|critic|executor|reviewer|security-reviewer|test-engineer|verifier|writer",
-          "title": "short task title",
-          "task": "specific autonomous task prompt for this subagent"
-        }
-      ]
-    }
-  ]
-}
-ADAPTIVE_PLAN_JSON_END
-
-Rules:
-- Choose the smallest effective number of subagents.
-- Use parallel tasks in the same phase only when their work is independent.
-- Later phases depend on all tasks in the previous phase.
-- Include verification/review tasks when implementation is requested.
-- Do not include more than 12 total subagents; split or summarize oversized plans instead.
+---
+name: implementation
+description: Adaptive implementation workflow where a planner agent decides the subagent fanout
+---
+
+## assess
+role: planner
+output: adaptive-plan.json
+
+Assess this task and decide how many subagents are actually needed for: {goal}
+
+You are the orchestration planner. Inspect the repository enough to choose an efficient crew; do not use a fixed template. Small/simple tasks may need one executor plus one verifier. Risky or broad tasks may need parallel explorers, specialists, implementers, reviewers, security reviewers, or test engineers.
+
+Return a concise rationale, then include exactly one JSON block between these markers:
+
+ADAPTIVE_PLAN_JSON_START
+{
+  "phases": [
+    {
+      "name": "short-phase-name",
+      "tasks": [
+        {
+          "role": "explorer|analyst|planner|critic|executor|reviewer|security-reviewer|test-engineer|verifier|writer",
+          "title": "short task title",
+          "task": "specific autonomous task prompt for this subagent"
+        }
+      ]
+    }
+  ]
+}
+ADAPTIVE_PLAN_JSON_END
+
+Rules:
+- **MAXIMIZE PARALLELISM**: Put independent tasks in the SAME phase so they run concurrently.
+  For example, if a task needs exploration + implementation + review, use 3 phases:
+  Phase 1: explorers (2-3 in parallel), Phase 2: executors (2-3 in parallel), Phase 3: reviewers (2 in parallel).
+  NEVER create sequential phases when tasks are independent.
+- Choose the smallest effective number of subagents per phase.
+- Tasks within the same phase run in parallel; phases run sequentially.
+- Include verification/review tasks when implementation is requested.
+- Do not include more than 12 total subagents; split or summarize oversized plans instead.
+- A good plan for a complex task has 2-4 phases with 2-4 parallel tasks each.
+- A simple task may have just 1-2 phases with 1-2 tasks.

package/workflows/parallel-research.workflow.md

@@ -1,46 +1,46 @@
----
-name: parallel-research
-description: Parallel research with shard exploration and synthesis
----
-
-## discover
-role: explorer
-
-Discover the relevant files/projects for: {goal}. Return a shard plan with paths grouped by topic. Do not deeply read every file yet; focus on routing the work.
-
-## explore-core
-role: explorer
-parallelGroup: explore
-
-Explore the core/runtime shard from the discover output. Focus on architecture, package config, docs, and reusable patterns for: {goal}
-
-## explore-ui
-role: explorer
-parallelGroup: explore
-
-Explore the UI/TUI/extension-interface shard from the discover output. Focus on widgets, overlays, commands, status bars, package config, docs, and reusable patterns for: {goal}
-
-## explore-runtime
-role: explorer
-parallelGroup: explore
-
-Explore the worker/runtime/subagent/runtime-control shard from the discover output. Focus on process/session/runtime orchestration, event streams, logs, package config, docs, and reusable patterns for: {goal}
-
-## explore-extensions
-role: explorer
-parallelGroup: explore
-
-Explore the extension bundle/small-package shard from the discover output. Focus on package config, extension registration, commands/tools, docs, and reusable patterns for: {goal}
-
-## synthesize
-role: analyst
-dependsOn: explore-core, explore-ui, explore-runtime, explore-extensions
-
-Synthesize all shard findings. Use discover output if available, but do not require it. Identify common patterns, gaps, and concrete recommendations.
-
-## write
-role: writer
-dependsOn: synthesize
-output: research-summary.md
-
-Write a concise final summary with evidence, risks, and actionable next steps.
+---
+name: parallel-research
+description: Parallel research with shard exploration and synthesis
+---
+
+## discover
+role: explorer
+
+Discover the relevant files/projects for: {goal}. Return a shard plan with paths grouped by topic. Do not deeply read every file yet; focus on routing the work.
+
+## explore-core
+role: explorer
+parallelGroup: explore
+
+Explore the core/runtime shard from the discover output. Focus on architecture, package config, docs, and reusable patterns for: {goal}
+
+## explore-ui
+role: explorer
+parallelGroup: explore
+
+Explore the UI/TUI/extension-interface shard from the discover output. Focus on widgets, overlays, commands, status bars, package config, docs, and reusable patterns for: {goal}
+
+## explore-runtime
+role: explorer
+parallelGroup: explore
+
+Explore the worker/runtime/subagent/runtime-control shard from the discover output. Focus on process/session/runtime orchestration, event streams, logs, package config, docs, and reusable patterns for: {goal}
+
+## explore-extensions
+role: explorer
+parallelGroup: explore
+
+Explore the extension bundle/small-package shard from the discover output. Focus on package config, extension registration, commands/tools, docs, and reusable patterns for: {goal}
+
+## synthesize
+role: analyst
+dependsOn: explore-core, explore-ui, explore-runtime, explore-extensions
+
+Synthesize all shard findings. Use discover output if available, but do not require it. Identify common patterns, gaps, and concrete recommendations.
+
+## write
+role: writer
+dependsOn: synthesize
+output: research-summary.md
+
+Write a concise final summary with evidence, risks, and actionable next steps.