pi-crew 0.1.49 → 0.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +74 -1
- package/README.md +176 -781
- package/agents/analyst.md +11 -11
- package/agents/critic.md +11 -11
- package/agents/executor.md +11 -11
- package/agents/explorer.md +11 -11
- package/agents/planner.md +11 -11
- package/agents/reviewer.md +11 -11
- package/agents/security-reviewer.md +11 -11
- package/agents/test-engineer.md +11 -11
- package/agents/verifier.md +70 -11
- package/agents/writer.md +11 -11
- package/docs/actions-reference.md +595 -0
- package/docs/commands-reference.md +347 -0
- package/docs/runtime-flow.md +148 -148
- package/index.ts +6 -6
- package/package.json +99 -99
- package/skills/async-worker-recovery/SKILL.md +42 -42
- package/skills/context-artifact-hygiene/SKILL.md +52 -52
- package/skills/delegation-patterns/SKILL.md +54 -54
- package/skills/mailbox-interactive/SKILL.md +40 -40
- package/skills/model-routing-context/SKILL.md +39 -39
- package/skills/multi-perspective-review/SKILL.md +58 -58
- package/skills/observability-reliability/SKILL.md +41 -41
- package/skills/orchestration/SKILL.md +157 -157
- package/skills/ownership-session-security/SKILL.md +41 -41
- package/skills/pi-extension-lifecycle/SKILL.md +39 -39
- package/skills/requirements-to-task-packet/SKILL.md +63 -63
- package/skills/resource-discovery-config/SKILL.md +41 -41
- package/skills/runtime-state-reader/SKILL.md +44 -44
- package/skills/secure-agent-orchestration-review/SKILL.md +45 -45
- package/skills/state-mutation-locking/SKILL.md +42 -42
- package/skills/systematic-debugging/SKILL.md +67 -67
- package/skills/ui-render-performance/SKILL.md +39 -39
- package/skills/verification-before-done/SKILL.md +57 -57
- package/skills/worktree-isolation/SKILL.md +39 -39
- package/src/adapters/claude-adapter.ts +25 -0
- package/src/adapters/codex-adapter.ts +21 -0
- package/src/adapters/cursor-adapter.ts +17 -0
- package/src/adapters/export-util.ts +137 -0
- package/src/adapters/index.ts +15 -0
- package/src/adapters/registry.ts +18 -0
- package/src/adapters/types.ts +23 -0
- package/src/agents/agent-config.ts +2 -0
- package/src/agents/agent-search.ts +98 -98
- package/src/agents/discover-agents.ts +2 -1
- package/src/config/config.ts +14 -1
- package/src/config/defaults.ts +5 -5
- package/src/config/drift-detector.ts +211 -0
- package/src/config/markers.ts +327 -0
- package/src/config/resilient-parser.ts +108 -0
- package/src/config/suggestions.ts +74 -0
- package/src/extension/cross-extension-rpc.ts +103 -82
- package/src/extension/project-init.ts +36 -4
- package/src/extension/register.ts +67 -22
- package/src/extension/registration/commands.ts +77 -8
- package/src/extension/registration/subagent-tools.ts +10 -1
- package/src/extension/registration/team-tool.ts +10 -1
- package/src/extension/registration/viewers.ts +48 -34
- package/src/extension/run-bundle-schema.ts +89 -89
- package/src/extension/run-export.ts +26 -12
- package/src/extension/run-import.ts +25 -1
- package/src/extension/run-index.ts +5 -1
- package/src/extension/run-maintenance.ts +142 -68
- package/src/extension/team-manager-command.ts +10 -1
- package/src/extension/team-tool/context.ts +1 -1
- package/src/extension/team-tool/doctor.ts +28 -3
- package/src/extension/team-tool/handle-settings.ts +195 -188
- package/src/extension/team-tool/inspect.ts +41 -41
- package/src/extension/team-tool/intent-policy.ts +42 -42
- package/src/extension/team-tool/lifecycle-actions.ts +27 -8
- package/src/extension/team-tool/plan.ts +19 -19
- package/src/extension/team-tool/run.ts +12 -1
- package/src/extension/team-tool.ts +14 -3
- package/src/i18n.ts +184 -184
- package/src/observability/exporters/otlp-exporter.ts +92 -77
- package/src/prompt/prompt-runtime.ts +72 -72
- package/src/runtime/agent-memory.ts +72 -72
- package/src/runtime/agent-observability.ts +114 -114
- package/src/runtime/async-marker.ts +26 -26
- package/src/runtime/attention-events.ts +28 -28
- package/src/runtime/auto-resume.ts +100 -0
- package/src/runtime/background-runner.ts +11 -1
- package/src/runtime/cancellation-token.ts +89 -89
- package/src/runtime/cancellation.ts +61 -61
- package/src/runtime/capability-inventory.ts +116 -116
- package/src/runtime/child-pi.ts +7 -2
- package/src/runtime/compaction-summary.ts +271 -0
- package/src/runtime/completion-guard.ts +190 -190
- package/src/runtime/concurrency.ts +3 -1
- package/src/runtime/crash-recovery.ts +33 -0
- package/src/runtime/delta-conflict.ts +360 -0
- package/src/runtime/diagnostic-export.ts +3 -1
- package/src/runtime/direct-run.ts +35 -35
- package/src/runtime/event-stream-bridge.ts +3 -1
- package/src/runtime/foreground-control.ts +82 -82
- package/src/runtime/green-contract.ts +46 -46
- package/src/runtime/group-join.ts +106 -106
- package/src/runtime/heartbeat-gradient.ts +28 -28
- package/src/runtime/heartbeat-watcher.ts +124 -124
- package/src/runtime/iteration-hooks.ts +262 -0
- package/src/runtime/live-agent-control.ts +88 -88
- package/src/runtime/live-control-realtime.ts +36 -36
- package/src/runtime/live-extension-bridge.ts +150 -150
- package/src/runtime/live-irc.ts +92 -92
- package/src/runtime/live-session-health.ts +100 -100
- package/src/runtime/loop-gates.ts +129 -0
- package/src/runtime/metric-parser.ts +40 -0
- package/src/runtime/notebook-helpers.ts +90 -90
- package/src/runtime/orphan-sentinel.ts +7 -7
- package/src/runtime/parallel-research.ts +44 -44
- package/src/runtime/phase-progress.ts +217 -0
- package/src/runtime/pi-args.ts +38 -2
- package/src/runtime/pi-json-output.ts +111 -111
- package/src/runtime/pi-spawn.ts +74 -6
- package/src/runtime/policy-engine.ts +79 -79
- package/src/runtime/post-checks.ts +122 -0
- package/src/runtime/process-status.ts +14 -1
- package/src/runtime/progress-event-coalescer.ts +43 -43
- package/src/runtime/prose-compressor.ts +164 -164
- package/src/runtime/recovery-recipes.ts +74 -74
- package/src/runtime/result-extractor.ts +121 -121
- package/src/runtime/role-permission.ts +39 -39
- package/src/runtime/sensitive-paths.ts +3 -3
- package/src/runtime/session-resources.ts +25 -25
- package/src/runtime/session-snapshot.ts +59 -59
- package/src/runtime/session-usage.ts +79 -79
- package/src/runtime/sidechain-output.ts +29 -29
- package/src/runtime/stream-preview.ts +177 -177
- package/src/runtime/supervisor-contact.ts +59 -59
- package/src/runtime/task-display.ts +38 -38
- package/src/runtime/task-graph.ts +207 -0
- package/src/runtime/task-quality.ts +207 -0
- package/src/runtime/task-runner/capabilities.ts +78 -78
- package/src/runtime/task-runner/live-executor.ts +7 -1
- package/src/runtime/task-runner/progress.ts +119 -119
- package/src/runtime/task-runner/prompt-builder.ts +1 -1
- package/src/runtime/task-runner/prompt-pipeline.ts +64 -64
- package/src/runtime/task-runner/result-utils.ts +14 -14
- package/src/runtime/task-runner/run-projection.ts +103 -103
- package/src/runtime/task-runner/state-helpers.ts +22 -22
- package/src/runtime/team-runner.ts +126 -7
- package/src/runtime/worker-heartbeat.ts +21 -21
- package/src/runtime/worker-startup.ts +57 -57
- package/src/runtime/workflow-state.ts +187 -0
- package/src/runtime/workspace-tree.ts +298 -298
- package/src/schema/config-schema.ts +12 -0
- package/src/schema/validation-types.ts +148 -0
- package/src/skills/skill-templates.ts +374 -0
- package/src/state/active-run-registry.ts +35 -11
- package/src/state/atomic-write.ts +33 -26
- package/src/state/contracts.ts +1 -0
- package/src/state/event-reconstructor.ts +217 -0
- package/src/state/locks.ts +2 -11
- package/src/state/mailbox.ts +4 -3
- package/src/state/state-store.ts +32 -14
- package/src/state/task-claims.ts +44 -44
- package/src/state/types.ts +9 -0
- package/src/state/usage.ts +29 -29
- package/src/subagents/async-entry.ts +1 -1
- package/src/subagents/index.ts +3 -3
- package/src/subagents/live/control.ts +1 -1
- package/src/subagents/live/manager.ts +1 -1
- package/src/subagents/live/realtime.ts +1 -1
- package/src/subagents/live/session-runtime.ts +1 -1
- package/src/subagents/manager.ts +1 -1
- package/src/subagents/spawn.ts +1 -1
- package/src/teams/team-serializer.ts +38 -38
- package/src/types/diff.d.ts +18 -18
- package/src/ui/crew-footer.ts +101 -101
- package/src/ui/crew-select-list.ts +111 -111
- package/src/ui/crew-widget.ts +9 -4
- package/src/ui/dashboard-panes/cancellation-pane.ts +42 -42
- package/src/ui/dashboard-panes/capability-pane.ts +59 -59
- package/src/ui/dashboard-panes/mailbox-pane.ts +35 -35
- package/src/ui/dashboard-panes/metrics-pane.ts +34 -34
- package/src/ui/dashboard-panes/progress-pane.ts +11 -0
- package/src/ui/dynamic-border.ts +25 -25
- package/src/ui/layout-primitives.ts +106 -106
- package/src/ui/loaders.ts +158 -158
- package/src/ui/powerbar-publisher.ts +6 -0
- package/src/ui/render-coalescer.ts +51 -51
- package/src/ui/render-diff.ts +119 -119
- package/src/ui/render-scheduler.ts +143 -143
- package/src/ui/run-action-dispatcher.ts +10 -1
- package/src/ui/spinner.ts +17 -17
- package/src/ui/status-colors.ts +58 -58
- package/src/ui/syntax-highlight.ts +116 -116
- package/src/ui/transcript-entries.ts +258 -258
- package/src/utils/completion-dedupe.ts +63 -63
- package/src/utils/frontmatter.ts +68 -68
- package/src/utils/git.ts +262 -262
- package/src/utils/ids.ts +17 -17
- package/src/utils/incremental-reader.ts +104 -104
- package/src/utils/names.ts +27 -27
- package/src/utils/redaction.ts +44 -44
- package/src/utils/safe-paths.ts +47 -47
- package/src/utils/scan-cache.ts +136 -136
- package/src/utils/sleep.ts +40 -26
- package/src/utils/task-name-generator.ts +337 -337
- package/src/workflows/validate-workflow.ts +40 -40
- package/src/worktree/branch-freshness.ts +45 -45
- package/src/worktree/worktree-manager.ts +11 -3
- package/teams/default.team.md +12 -12
- package/teams/fast-fix.team.md +11 -11
- package/teams/implementation.team.md +18 -18
- package/teams/parallel-research.team.md +14 -14
- package/teams/research.team.md +11 -11
- package/teams/review.team.md +12 -12
- package/workflows/default.workflow.md +30 -29
- package/workflows/fast-fix.workflow.md +23 -22
- package/workflows/implementation.workflow.md +43 -38
- package/workflows/parallel-research.workflow.md +46 -46
- package/workflows/research.workflow.md +22 -22
- package/workflows/review.workflow.md +30 -30
- package/docs/refactor-tasks-phase3.md +0 -394
- package/docs/refactor-tasks-phase4.md +0 -564
- package/docs/refactor-tasks-phase5.md +0 -402
- package/docs/refactor-tasks-phase6.md +0 -662
- package/docs/refactor-tasks.md +0 -1484
- package/docs/research/AGENT-EXECUTION-ARCHITECTURE.md +0 -261
- package/docs/research/AGENT-LIFECYCLE-COMPARISON.md +0 -111
- package/docs/research/AUDIT_OH_MY_PI.md +0 -261
- package/docs/research/AUDIT_PI_CREW.md +0 -457
- package/docs/research/CAVEMAN-DEEP-RESEARCH.md +0 -281
- package/docs/research/COMPARISON_OH_MY_PI_VS_PI_CREW.md +0 -264
- package/docs/research/DEEP-RESEARCH-PI-POWERBAR.md +0 -343
- package/docs/research/DEEP_RESEARCH_SUBAGENT_ARCHITECTURE.md +0 -480
- package/docs/research/GAP_CLOSURE_IMPLEMENTATION_PLAN.md +0 -354
- package/docs/research/IMPLEMENTATION_PLAN.md +0 -385
- package/docs/research/LIVE-SESSION-PRODUCTION-READY-PLAN.md +0 -502
- package/docs/research/OH-MY-PI-DEEP-RESEARCH-v14.7.6.md +0 -266
- package/docs/research/REMAINING-GAPS-PLAN.md +0 -363
- package/docs/research/SESSION-SUMMARY-2026-05-08.md +0 -146
- package/docs/research/UI-RESPONSIVENESS-AUDIT.md +0 -173
- package/docs/research-awesome-agent-skills-distillation.md +0 -100
- package/docs/research-extension-examples.md +0 -297
- package/docs/research-extension-system.md +0 -324
- package/docs/research-oh-my-pi-distillation.md +0 -369
- package/docs/research-optimization-plan.md +0 -548
- package/docs/research-phase10-distillation.md +0 -199
- package/docs/research-phase11-distillation.md +0 -201
- package/docs/research-phase8-operator-experience-plan.md +0 -819
- package/docs/research-phase9-observability-reliability-plan.md +0 -1190
- package/docs/research-pi-coding-agent.md +0 -357
- package/docs/research-source-pi-crew-reference.md +0 -174
- package/docs/research-ui-optimization-plan.md +0 -480
- package/docs/source-runtime-refactor-map.md +0 -107
- package/src/utils/atomic-write.ts +0 -33
|
@@ -1,111 +1,111 @@
|
|
|
1
|
-
export interface ParsedPiUsage {
|
|
2
|
-
input?: number;
|
|
3
|
-
output?: number;
|
|
4
|
-
cacheRead?: number;
|
|
5
|
-
cacheWrite?: number;
|
|
6
|
-
cost?: number;
|
|
7
|
-
turns?: number;
|
|
8
|
-
}
|
|
9
|
-
|
|
10
|
-
export interface ParsedPiJsonOutput {
|
|
11
|
-
jsonEvents: number;
|
|
12
|
-
textEvents: string[];
|
|
13
|
-
finalText?: string;
|
|
14
|
-
usage?: ParsedPiUsage;
|
|
15
|
-
}
|
|
16
|
-
|
|
17
|
-
function asRecord(value: unknown): Record<string, unknown> | undefined {
|
|
18
|
-
return value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : undefined;
|
|
19
|
-
}
|
|
20
|
-
|
|
21
|
-
function numberField(obj: Record<string, unknown>, keys: string[]): number | undefined {
|
|
22
|
-
for (const key of keys) {
|
|
23
|
-
const value = obj[key];
|
|
24
|
-
if (typeof value === "number" && Number.isFinite(value)) return value;
|
|
25
|
-
}
|
|
26
|
-
return undefined;
|
|
27
|
-
}
|
|
28
|
-
|
|
29
|
-
function mergeUsage(target: ParsedPiUsage, source: ParsedPiUsage): ParsedPiUsage {
|
|
30
|
-
return {
|
|
31
|
-
input: source.input ?? target.input,
|
|
32
|
-
output: source.output ?? target.output,
|
|
33
|
-
cacheRead: source.cacheRead ?? target.cacheRead,
|
|
34
|
-
cacheWrite: source.cacheWrite ?? target.cacheWrite,
|
|
35
|
-
cost: source.cost ?? target.cost,
|
|
36
|
-
turns: source.turns ?? target.turns,
|
|
37
|
-
};
|
|
38
|
-
}
|
|
39
|
-
|
|
40
|
-
function extractUsage(value: unknown): ParsedPiUsage | undefined {
|
|
41
|
-
const obj = asRecord(value);
|
|
42
|
-
if (!obj) return undefined;
|
|
43
|
-
const direct: ParsedPiUsage = {
|
|
44
|
-
input: numberField(obj, ["input", "inputTokens", "input_tokens"]),
|
|
45
|
-
output: numberField(obj, ["output", "outputTokens", "output_tokens"]),
|
|
46
|
-
cacheRead: numberField(obj, ["cacheRead", "cache_read", "cacheReadTokens", "cache_read_tokens"]),
|
|
47
|
-
cacheWrite: numberField(obj, ["cacheWrite", "cache_write", "cacheWriteTokens", "cache_write_tokens"]),
|
|
48
|
-
cost: numberField(obj, ["cost", "costUsd", "cost_usd"]),
|
|
49
|
-
turns: numberField(obj, ["turns", "turnCount", "turn_count"]),
|
|
50
|
-
};
|
|
51
|
-
if (Object.values(direct).some((entry) => entry !== undefined)) return direct;
|
|
52
|
-
for (const key of ["usage", "tokenUsage", "tokens", "stats"]) {
|
|
53
|
-
const nested = extractUsage(obj[key]);
|
|
54
|
-
if (nested) return nested;
|
|
55
|
-
}
|
|
56
|
-
return undefined;
|
|
57
|
-
}
|
|
58
|
-
|
|
59
|
-
function textFromContent(content: unknown): string[] {
|
|
60
|
-
if (typeof content === "string") return [content];
|
|
61
|
-
if (!Array.isArray(content)) return [];
|
|
62
|
-
const text: string[] = [];
|
|
63
|
-
for (const part of content) {
|
|
64
|
-
const obj = asRecord(part);
|
|
65
|
-
if (!obj) continue;
|
|
66
|
-
if (obj.type === "text" && typeof obj.text === "string") text.push(obj.text);
|
|
67
|
-
else if (typeof obj.content === "string") text.push(obj.content);
|
|
68
|
-
}
|
|
69
|
-
return text;
|
|
70
|
-
}
|
|
71
|
-
|
|
72
|
-
function extractText(value: unknown): string[] {
|
|
73
|
-
const obj = asRecord(value);
|
|
74
|
-
if (!obj) return [];
|
|
75
|
-
const message = asRecord(obj.message);
|
|
76
|
-
if (message?.role !== undefined && message.role !== "assistant") return [];
|
|
77
|
-
const text: string[] = [];
|
|
78
|
-
if (typeof obj.text === "string") text.push(obj.text);
|
|
79
|
-
if (typeof obj.output === "string") text.push(obj.output);
|
|
80
|
-
if (typeof obj.finalOutput === "string") text.push(obj.finalOutput);
|
|
81
|
-
if (typeof obj.final_output === "string") text.push(obj.final_output);
|
|
82
|
-
if (!message) text.push(...textFromContent(obj.content));
|
|
83
|
-
if (message) text.push(...textFromContent(message.content));
|
|
84
|
-
return text.filter((entry) => entry.trim().length > 0);
|
|
85
|
-
}
|
|
86
|
-
|
|
87
|
-
export function parsePiJsonOutput(stdout: string): ParsedPiJsonOutput {
|
|
88
|
-
let jsonEvents = 0;
|
|
89
|
-
const textEvents: string[] = [];
|
|
90
|
-
let usage: ParsedPiUsage | undefined;
|
|
91
|
-
for (const line of stdout.split("\n")) {
|
|
92
|
-
const trimmed = line.trim();
|
|
93
|
-
if (!trimmed) continue;
|
|
94
|
-
let event: unknown;
|
|
95
|
-
try {
|
|
96
|
-
event = JSON.parse(trimmed) as unknown;
|
|
97
|
-
} catch {
|
|
98
|
-
continue;
|
|
99
|
-
}
|
|
100
|
-
jsonEvents++;
|
|
101
|
-
textEvents.push(...extractText(event));
|
|
102
|
-
const eventUsage = extractUsage(event);
|
|
103
|
-
if (eventUsage) usage = mergeUsage(usage ?? {}, eventUsage);
|
|
104
|
-
}
|
|
105
|
-
return {
|
|
106
|
-
jsonEvents,
|
|
107
|
-
textEvents,
|
|
108
|
-
finalText: textEvents.length > 0 ? textEvents[textEvents.length - 1] : undefined,
|
|
109
|
-
usage,
|
|
110
|
-
};
|
|
111
|
-
}
|
|
1
|
+
export interface ParsedPiUsage {
|
|
2
|
+
input?: number;
|
|
3
|
+
output?: number;
|
|
4
|
+
cacheRead?: number;
|
|
5
|
+
cacheWrite?: number;
|
|
6
|
+
cost?: number;
|
|
7
|
+
turns?: number;
|
|
8
|
+
}
|
|
9
|
+
|
|
10
|
+
export interface ParsedPiJsonOutput {
|
|
11
|
+
jsonEvents: number;
|
|
12
|
+
textEvents: string[];
|
|
13
|
+
finalText?: string;
|
|
14
|
+
usage?: ParsedPiUsage;
|
|
15
|
+
}
|
|
16
|
+
|
|
17
|
+
function asRecord(value: unknown): Record<string, unknown> | undefined {
|
|
18
|
+
return value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : undefined;
|
|
19
|
+
}
|
|
20
|
+
|
|
21
|
+
function numberField(obj: Record<string, unknown>, keys: string[]): number | undefined {
|
|
22
|
+
for (const key of keys) {
|
|
23
|
+
const value = obj[key];
|
|
24
|
+
if (typeof value === "number" && Number.isFinite(value)) return value;
|
|
25
|
+
}
|
|
26
|
+
return undefined;
|
|
27
|
+
}
|
|
28
|
+
|
|
29
|
+
function mergeUsage(target: ParsedPiUsage, source: ParsedPiUsage): ParsedPiUsage {
|
|
30
|
+
return {
|
|
31
|
+
input: source.input ?? target.input,
|
|
32
|
+
output: source.output ?? target.output,
|
|
33
|
+
cacheRead: source.cacheRead ?? target.cacheRead,
|
|
34
|
+
cacheWrite: source.cacheWrite ?? target.cacheWrite,
|
|
35
|
+
cost: source.cost ?? target.cost,
|
|
36
|
+
turns: source.turns ?? target.turns,
|
|
37
|
+
};
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
function extractUsage(value: unknown): ParsedPiUsage | undefined {
|
|
41
|
+
const obj = asRecord(value);
|
|
42
|
+
if (!obj) return undefined;
|
|
43
|
+
const direct: ParsedPiUsage = {
|
|
44
|
+
input: numberField(obj, ["input", "inputTokens", "input_tokens"]),
|
|
45
|
+
output: numberField(obj, ["output", "outputTokens", "output_tokens"]),
|
|
46
|
+
cacheRead: numberField(obj, ["cacheRead", "cache_read", "cacheReadTokens", "cache_read_tokens"]),
|
|
47
|
+
cacheWrite: numberField(obj, ["cacheWrite", "cache_write", "cacheWriteTokens", "cache_write_tokens"]),
|
|
48
|
+
cost: numberField(obj, ["cost", "costUsd", "cost_usd"]),
|
|
49
|
+
turns: numberField(obj, ["turns", "turnCount", "turn_count"]),
|
|
50
|
+
};
|
|
51
|
+
if (Object.values(direct).some((entry) => entry !== undefined)) return direct;
|
|
52
|
+
for (const key of ["usage", "tokenUsage", "tokens", "stats"]) {
|
|
53
|
+
const nested = extractUsage(obj[key]);
|
|
54
|
+
if (nested) return nested;
|
|
55
|
+
}
|
|
56
|
+
return undefined;
|
|
57
|
+
}
|
|
58
|
+
|
|
59
|
+
function textFromContent(content: unknown): string[] {
|
|
60
|
+
if (typeof content === "string") return [content];
|
|
61
|
+
if (!Array.isArray(content)) return [];
|
|
62
|
+
const text: string[] = [];
|
|
63
|
+
for (const part of content) {
|
|
64
|
+
const obj = asRecord(part);
|
|
65
|
+
if (!obj) continue;
|
|
66
|
+
if (obj.type === "text" && typeof obj.text === "string") text.push(obj.text);
|
|
67
|
+
else if (typeof obj.content === "string") text.push(obj.content);
|
|
68
|
+
}
|
|
69
|
+
return text;
|
|
70
|
+
}
|
|
71
|
+
|
|
72
|
+
function extractText(value: unknown): string[] {
|
|
73
|
+
const obj = asRecord(value);
|
|
74
|
+
if (!obj) return [];
|
|
75
|
+
const message = asRecord(obj.message);
|
|
76
|
+
if (message?.role !== undefined && message.role !== "assistant") return [];
|
|
77
|
+
const text: string[] = [];
|
|
78
|
+
if (typeof obj.text === "string") text.push(obj.text);
|
|
79
|
+
if (typeof obj.output === "string") text.push(obj.output);
|
|
80
|
+
if (typeof obj.finalOutput === "string") text.push(obj.finalOutput);
|
|
81
|
+
if (typeof obj.final_output === "string") text.push(obj.final_output);
|
|
82
|
+
if (!message) text.push(...textFromContent(obj.content));
|
|
83
|
+
if (message) text.push(...textFromContent(message.content));
|
|
84
|
+
return text.filter((entry) => entry.trim().length > 0);
|
|
85
|
+
}
|
|
86
|
+
|
|
87
|
+
export function parsePiJsonOutput(stdout: string): ParsedPiJsonOutput {
|
|
88
|
+
let jsonEvents = 0;
|
|
89
|
+
const textEvents: string[] = [];
|
|
90
|
+
let usage: ParsedPiUsage | undefined;
|
|
91
|
+
for (const line of stdout.split("\n")) {
|
|
92
|
+
const trimmed = line.trim();
|
|
93
|
+
if (!trimmed) continue;
|
|
94
|
+
let event: unknown;
|
|
95
|
+
try {
|
|
96
|
+
event = JSON.parse(trimmed) as unknown;
|
|
97
|
+
} catch {
|
|
98
|
+
continue;
|
|
99
|
+
}
|
|
100
|
+
jsonEvents++;
|
|
101
|
+
textEvents.push(...extractText(event));
|
|
102
|
+
const eventUsage = extractUsage(event);
|
|
103
|
+
if (eventUsage) usage = mergeUsage(usage ?? {}, eventUsage);
|
|
104
|
+
}
|
|
105
|
+
return {
|
|
106
|
+
jsonEvents,
|
|
107
|
+
textEvents,
|
|
108
|
+
finalText: textEvents.length > 0 ? textEvents[textEvents.length - 1] : undefined,
|
|
109
|
+
usage,
|
|
110
|
+
};
|
|
111
|
+
}
|
package/src/runtime/pi-spawn.ts
CHANGED
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import * as fs from "node:fs";
|
|
2
|
+
import * as os from "node:os";
|
|
2
3
|
import { fileURLToPath } from "node:url";
|
|
3
4
|
import * as path from "node:path";
|
|
4
5
|
|
|
@@ -11,6 +12,48 @@ function isRunnableNodeScript(filePath: string): boolean {
|
|
|
11
12
|
return fs.existsSync(filePath) && /\.(?:mjs|cjs|js)$/i.test(filePath);
|
|
12
13
|
}
|
|
13
14
|
|
|
15
|
+
/**
|
|
16
|
+
* Check that a resolved path is within known safe prefixes.
|
|
17
|
+
* Allowed prefixes: npm global bin (APPDATA/npm), project node_modules/.bin,
|
|
18
|
+
* or the current process's execPath directory.
|
|
19
|
+
*/
|
|
20
|
+
function isWithinAllowedPrefixes(resolvedPath: string): boolean {
|
|
21
|
+
const normalized = path.resolve(resolvedPath).toLowerCase();
|
|
22
|
+
|
|
23
|
+
const allowedPrefixes: string[] = [];
|
|
24
|
+
|
|
25
|
+
// Current process execPath directory (e.g. node installation)
|
|
26
|
+
try {
|
|
27
|
+
const execDir = path.dirname(fs.realpathSync.native(process.execPath));
|
|
28
|
+
allowedPrefixes.push(execDir.toLowerCase());
|
|
29
|
+
} catch { /* ignore */ }
|
|
30
|
+
|
|
31
|
+
// npm global bin via APPDATA
|
|
32
|
+
if (process.env.APPDATA) {
|
|
33
|
+
allowedPrefixes.push(path.join(process.env.APPDATA, "npm").toLowerCase());
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
// Project-local node_modules/.bin
|
|
37
|
+
try {
|
|
38
|
+
const projectBin = path.resolve("node_modules", ".bin");
|
|
39
|
+
allowedPrefixes.push(projectBin.toLowerCase());
|
|
40
|
+
} catch { /* ignore */ }
|
|
41
|
+
|
|
42
|
+
// User home npm-global
|
|
43
|
+
try {
|
|
44
|
+
const homeNpm = path.join(os.homedir(), ".npm-global", "bin");
|
|
45
|
+
allowedPrefixes.push(homeNpm.toLowerCase());
|
|
46
|
+
} catch { /* ignore */ }
|
|
47
|
+
|
|
48
|
+
// User home .local/bin
|
|
49
|
+
try {
|
|
50
|
+
const homeLocal = path.join(os.homedir(), ".local", "bin");
|
|
51
|
+
allowedPrefixes.push(homeLocal.toLowerCase());
|
|
52
|
+
} catch { /* ignore */ }
|
|
53
|
+
|
|
54
|
+
return allowedPrefixes.some((prefix) => normalized.startsWith(prefix));
|
|
55
|
+
}
|
|
56
|
+
|
|
14
57
|
function resolvePiPackageRoot(): string | undefined {
|
|
15
58
|
try {
|
|
16
59
|
const entry = process.argv[1];
|
|
@@ -61,9 +104,6 @@ function findPiPackageJsonFrom(startDir: string): string | undefined {
|
|
|
61
104
|
}
|
|
62
105
|
|
|
63
106
|
function resolvePiCliScript(): string | undefined {
|
|
64
|
-
const explicit = process.env.PI_TEAMS_PI_BIN?.trim();
|
|
65
|
-
if (explicit && isRunnableNodeScript(explicit)) return explicit;
|
|
66
|
-
|
|
67
107
|
const argv1 = process.argv[1];
|
|
68
108
|
if (argv1) {
|
|
69
109
|
const argvPath = path.isAbsolute(argv1) ? argv1 : path.resolve(argv1);
|
|
@@ -85,11 +125,39 @@ function resolvePiCliScript(): string | undefined {
|
|
|
85
125
|
return undefined;
|
|
86
126
|
}
|
|
87
127
|
|
|
128
|
+
function validateExplicitBin(explicit: string): string | undefined {
|
|
129
|
+
const resolved = path.resolve(explicit);
|
|
130
|
+
if (!fs.existsSync(resolved)) return undefined;
|
|
131
|
+
// Reject paths outside allowed safe prefixes
|
|
132
|
+
if (!isWithinAllowedPrefixes(resolved)) {
|
|
133
|
+
throw new Error(
|
|
134
|
+
`PI_TEAMS_PI_BIN path '${resolved}' is outside allowed prefixes. ` +
|
|
135
|
+
`Allowed: npm global bin, project node_modules/.bin, APPDATA/npm, or process execPath directory.`,
|
|
136
|
+
);
|
|
137
|
+
}
|
|
138
|
+
// Reject if symlink points outside expected directories
|
|
139
|
+
try {
|
|
140
|
+
const real = fs.realpathSync(resolved);
|
|
141
|
+
if (!isWithinAllowedPrefixes(real)) {
|
|
142
|
+
throw new Error(
|
|
143
|
+
`PI_TEAMS_PI_BIN symlink target '${real}' is outside allowed prefixes.`,
|
|
144
|
+
);
|
|
145
|
+
}
|
|
146
|
+
} catch (e) {
|
|
147
|
+
if (e instanceof Error && e.message.includes("allowed prefixes")) throw e;
|
|
148
|
+
return undefined;
|
|
149
|
+
}
|
|
150
|
+
return resolved;
|
|
151
|
+
}
|
|
152
|
+
|
|
88
153
|
export function getPiSpawnCommand(args: string[]): PiSpawnCommand {
|
|
89
154
|
const explicit = process.env.PI_TEAMS_PI_BIN?.trim();
|
|
90
|
-
if (explicit
|
|
91
|
-
|
|
92
|
-
|
|
155
|
+
if (explicit) {
|
|
156
|
+
const validated = validateExplicitBin(explicit);
|
|
157
|
+
if (validated) {
|
|
158
|
+
if (isRunnableNodeScript(validated)) return { command: process.execPath, args: [validated, ...args] };
|
|
159
|
+
return { command: validated, args };
|
|
160
|
+
}
|
|
93
161
|
}
|
|
94
162
|
if (process.platform === "win32") {
|
|
95
163
|
const script = resolvePiCliScript();
|
|
@@ -1,79 +1,79 @@
|
|
|
1
|
-
import type { CrewLimitsConfig } from "../config/config.ts";
|
|
2
|
-
import type { PolicyDecision, PolicyDecisionAction, PolicyDecisionReason, TeamRunManifest, TeamTaskState } from "../state/types.ts";
|
|
3
|
-
import { evaluateGreenContract } from "./green-contract.ts";
|
|
4
|
-
import { isWorkerHeartbeatStale } from "./worker-heartbeat.ts";
|
|
5
|
-
|
|
6
|
-
export interface PolicyEngineInput {
|
|
7
|
-
manifest: TeamRunManifest;
|
|
8
|
-
tasks: TeamTaskState[];
|
|
9
|
-
limits?: CrewLimitsConfig;
|
|
10
|
-
now?: Date;
|
|
11
|
-
}
|
|
12
|
-
|
|
13
|
-
function decision(action: PolicyDecisionAction, reason: PolicyDecisionReason, message: string, taskId?: string): PolicyDecision {
|
|
14
|
-
return {
|
|
15
|
-
action,
|
|
16
|
-
reason,
|
|
17
|
-
message,
|
|
18
|
-
taskId,
|
|
19
|
-
createdAt: new Date().toISOString(),
|
|
20
|
-
};
|
|
21
|
-
}
|
|
22
|
-
|
|
23
|
-
function taskDepth(task: TeamTaskState, tasksById: Map<string, TeamTaskState>): number {
|
|
24
|
-
let depth = 0;
|
|
25
|
-
let current = task.graph?.parentId;
|
|
26
|
-
const seen = new Set<string>();
|
|
27
|
-
while (current && !seen.has(current)) {
|
|
28
|
-
seen.add(current);
|
|
29
|
-
depth += 1;
|
|
30
|
-
current = tasksById.get(current)?.graph?.parentId;
|
|
31
|
-
}
|
|
32
|
-
return depth;
|
|
33
|
-
}
|
|
34
|
-
|
|
35
|
-
export function evaluateCrewPolicy(input: PolicyEngineInput): PolicyDecision[] {
|
|
36
|
-
const decisions: PolicyDecision[] = [];
|
|
37
|
-
const maxTasksPerRun = Number.isFinite(input.limits?.maxTasksPerRun) ? input.limits!.maxTasksPerRun : undefined;
|
|
38
|
-
if (maxTasksPerRun !== undefined && input.tasks.length > maxTasksPerRun) {
|
|
39
|
-
decisions.push(decision("block", "limit_exceeded", `Run has ${input.tasks.length} tasks, exceeding maxTasksPerRun=${maxTasksPerRun}.`));
|
|
40
|
-
}
|
|
41
|
-
const runningCount = input.tasks.filter((task) => task.status === "running").length;
|
|
42
|
-
const maxConcurrentWorkers = Number.isFinite(input.limits?.maxConcurrentWorkers) ? input.limits!.maxConcurrentWorkers : undefined;
|
|
43
|
-
if (maxConcurrentWorkers !== undefined && runningCount > maxConcurrentWorkers) {
|
|
44
|
-
decisions.push(decision("block", "limit_exceeded", `Run has ${runningCount} running workers, exceeding maxConcurrentWorkers=${maxConcurrentWorkers}.`));
|
|
45
|
-
}
|
|
46
|
-
const tasksById = new Map(input.tasks.map((task) => [task.id, task]));
|
|
47
|
-
|
|
48
|
-
for (const task of input.tasks) {
|
|
49
|
-
if (input.limits?.maxChildrenPerTask !== undefined && (task.graph?.children.length ?? 0) > input.limits.maxChildrenPerTask) {
|
|
50
|
-
decisions.push(decision("block", "limit_exceeded", `Task has ${task.graph?.children.length ?? 0} children, exceeding maxChildrenPerTask=${input.limits.maxChildrenPerTask}.`, task.id));
|
|
51
|
-
}
|
|
52
|
-
if (input.limits?.maxTaskDepth !== undefined && taskDepth(task, tasksById) > input.limits.maxTaskDepth) {
|
|
53
|
-
decisions.push(decision("block", "limit_exceeded", `Task graph depth exceeds maxTaskDepth=${input.limits.maxTaskDepth}.`, task.id));
|
|
54
|
-
}
|
|
55
|
-
if (task.status === "failed") {
|
|
56
|
-
const retryCount = task.policy?.retryCount ?? 0;
|
|
57
|
-
const maxRetries = input.limits?.maxRetriesPerTask ?? 0;
|
|
58
|
-
decisions.push(decision(retryCount < maxRetries ? "retry" : "escalate", "task_failed", task.error ? `Task failed: ${task.error}` : "Task failed.", task.id));
|
|
59
|
-
}
|
|
60
|
-
if ((task.status === "running" || task.status === "queued") && task.heartbeat && task.heartbeat.alive !== false && isWorkerHeartbeatStale(task.heartbeat, input.limits?.heartbeatStaleMs ?? 60_000, input.now)) {
|
|
61
|
-
decisions.push(decision("escalate", "worker_stale", "Worker heartbeat is stale.", task.id));
|
|
62
|
-
}
|
|
63
|
-
if (task.taskPacket?.verification) {
|
|
64
|
-
const outcome = evaluateGreenContract(task.taskPacket.verification, task.verification);
|
|
65
|
-
if (!outcome.satisfied && task.status === "completed") {
|
|
66
|
-
decisions.push(decision("block", "green_unsatisfied", `Green contract unsatisfied: required=${outcome.requiredGreenLevel}, observed=${outcome.observedGreenLevel}.`, task.id));
|
|
67
|
-
}
|
|
68
|
-
}
|
|
69
|
-
}
|
|
70
|
-
|
|
71
|
-
if (decisions.length === 0 && input.tasks.length > 0 && input.tasks.every((task) => task.status === "completed")) {
|
|
72
|
-
decisions.push(decision("closeout", "run_complete", "All tasks completed and no policy blockers were found."));
|
|
73
|
-
}
|
|
74
|
-
return decisions;
|
|
75
|
-
}
|
|
76
|
-
|
|
77
|
-
export function summarizePolicyDecisions(decisions: PolicyDecision[]): string[] {
|
|
78
|
-
return decisions.map((item) => `- ${item.action} (${item.reason})${item.taskId ? ` ${item.taskId}` : ""}: ${item.message}`);
|
|
79
|
-
}
|
|
1
|
+
import type { CrewLimitsConfig } from "../config/config.ts";
|
|
2
|
+
import type { PolicyDecision, PolicyDecisionAction, PolicyDecisionReason, TeamRunManifest, TeamTaskState } from "../state/types.ts";
|
|
3
|
+
import { evaluateGreenContract } from "./green-contract.ts";
|
|
4
|
+
import { isWorkerHeartbeatStale } from "./worker-heartbeat.ts";
|
|
5
|
+
|
|
6
|
+
export interface PolicyEngineInput {
|
|
7
|
+
manifest: TeamRunManifest;
|
|
8
|
+
tasks: TeamTaskState[];
|
|
9
|
+
limits?: CrewLimitsConfig;
|
|
10
|
+
now?: Date;
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
function decision(action: PolicyDecisionAction, reason: PolicyDecisionReason, message: string, taskId?: string): PolicyDecision {
|
|
14
|
+
return {
|
|
15
|
+
action,
|
|
16
|
+
reason,
|
|
17
|
+
message,
|
|
18
|
+
taskId,
|
|
19
|
+
createdAt: new Date().toISOString(),
|
|
20
|
+
};
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
function taskDepth(task: TeamTaskState, tasksById: Map<string, TeamTaskState>): number {
|
|
24
|
+
let depth = 0;
|
|
25
|
+
let current = task.graph?.parentId;
|
|
26
|
+
const seen = new Set<string>();
|
|
27
|
+
while (current && !seen.has(current)) {
|
|
28
|
+
seen.add(current);
|
|
29
|
+
depth += 1;
|
|
30
|
+
current = tasksById.get(current)?.graph?.parentId;
|
|
31
|
+
}
|
|
32
|
+
return depth;
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
export function evaluateCrewPolicy(input: PolicyEngineInput): PolicyDecision[] {
|
|
36
|
+
const decisions: PolicyDecision[] = [];
|
|
37
|
+
const maxTasksPerRun = Number.isFinite(input.limits?.maxTasksPerRun) ? input.limits!.maxTasksPerRun : undefined;
|
|
38
|
+
if (maxTasksPerRun !== undefined && input.tasks.length > maxTasksPerRun) {
|
|
39
|
+
decisions.push(decision("block", "limit_exceeded", `Run has ${input.tasks.length} tasks, exceeding maxTasksPerRun=${maxTasksPerRun}.`));
|
|
40
|
+
}
|
|
41
|
+
const runningCount = input.tasks.filter((task) => task.status === "running").length;
|
|
42
|
+
const maxConcurrentWorkers = Number.isFinite(input.limits?.maxConcurrentWorkers) ? input.limits!.maxConcurrentWorkers : undefined;
|
|
43
|
+
if (maxConcurrentWorkers !== undefined && runningCount > maxConcurrentWorkers) {
|
|
44
|
+
decisions.push(decision("block", "limit_exceeded", `Run has ${runningCount} running workers, exceeding maxConcurrentWorkers=${maxConcurrentWorkers}.`));
|
|
45
|
+
}
|
|
46
|
+
const tasksById = new Map(input.tasks.map((task) => [task.id, task]));
|
|
47
|
+
|
|
48
|
+
for (const task of input.tasks) {
|
|
49
|
+
if (input.limits?.maxChildrenPerTask !== undefined && (task.graph?.children.length ?? 0) > input.limits.maxChildrenPerTask) {
|
|
50
|
+
decisions.push(decision("block", "limit_exceeded", `Task has ${task.graph?.children.length ?? 0} children, exceeding maxChildrenPerTask=${input.limits.maxChildrenPerTask}.`, task.id));
|
|
51
|
+
}
|
|
52
|
+
if (input.limits?.maxTaskDepth !== undefined && taskDepth(task, tasksById) > input.limits.maxTaskDepth) {
|
|
53
|
+
decisions.push(decision("block", "limit_exceeded", `Task graph depth exceeds maxTaskDepth=${input.limits.maxTaskDepth}.`, task.id));
|
|
54
|
+
}
|
|
55
|
+
if (task.status === "failed") {
|
|
56
|
+
const retryCount = task.policy?.retryCount ?? 0;
|
|
57
|
+
const maxRetries = input.limits?.maxRetriesPerTask ?? 0;
|
|
58
|
+
decisions.push(decision(retryCount < maxRetries ? "retry" : "escalate", "task_failed", task.error ? `Task failed: ${task.error}` : "Task failed.", task.id));
|
|
59
|
+
}
|
|
60
|
+
if ((task.status === "running" || task.status === "queued") && task.heartbeat && task.heartbeat.alive !== false && isWorkerHeartbeatStale(task.heartbeat, input.limits?.heartbeatStaleMs ?? 60_000, input.now)) {
|
|
61
|
+
decisions.push(decision("escalate", "worker_stale", "Worker heartbeat is stale.", task.id));
|
|
62
|
+
}
|
|
63
|
+
if (task.taskPacket?.verification) {
|
|
64
|
+
const outcome = evaluateGreenContract(task.taskPacket.verification, task.verification);
|
|
65
|
+
if (!outcome.satisfied && task.status === "completed") {
|
|
66
|
+
decisions.push(decision("block", "green_unsatisfied", `Green contract unsatisfied: required=${outcome.requiredGreenLevel}, observed=${outcome.observedGreenLevel}.`, task.id));
|
|
67
|
+
}
|
|
68
|
+
}
|
|
69
|
+
}
|
|
70
|
+
|
|
71
|
+
if (decisions.length === 0 && input.tasks.length > 0 && input.tasks.every((task) => task.status === "completed")) {
|
|
72
|
+
decisions.push(decision("closeout", "run_complete", "All tasks completed and no policy blockers were found."));
|
|
73
|
+
}
|
|
74
|
+
return decisions;
|
|
75
|
+
}
|
|
76
|
+
|
|
77
|
+
export function summarizePolicyDecisions(decisions: PolicyDecision[]): string[] {
|
|
78
|
+
return decisions.map((item) => `- ${item.action} (${item.reason})${item.taskId ? ` ${item.taskId}` : ""}: ${item.message}`);
|
|
79
|
+
}
|
|
@@ -0,0 +1,122 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Post-task backpressure checks — runs a configurable shell script after
|
|
3
|
+
* task completion to verify workspace health before proceeding.
|
|
4
|
+
*
|
|
5
|
+
* Distilled from pi-autoresearch's post-check / backpressure pattern.
|
|
6
|
+
*/
|
|
7
|
+
import { execFileSync } from "node:child_process";
|
|
8
|
+
|
|
9
|
+
/** Default timeout for post-check scripts (5 minutes). */
|
|
10
|
+
const DEFAULT_TIMEOUT_MS = 300_000;
|
|
11
|
+
|
|
12
|
+
/** Environment variable name for the post-check script path. */
|
|
13
|
+
const POST_CHECK_SCRIPT_ENV = "PI_CREW_POST_CHECK_SCRIPT";
|
|
14
|
+
|
|
15
|
+
/**
|
|
16
|
+
* Configuration for a post-task check.
|
|
17
|
+
*/
|
|
18
|
+
export interface PostCheckConfig {
|
|
19
|
+
/** Path to the shell script to execute. */
|
|
20
|
+
scriptPath: string;
|
|
21
|
+
/** Timeout in milliseconds. Defaults to 300000 (5 minutes). */
|
|
22
|
+
timeoutMs: number;
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
/**
|
|
26
|
+
* Result of running a post-task check.
|
|
27
|
+
*/
|
|
28
|
+
export interface PostCheckResult {
|
|
29
|
+
/** Whether the check passed (exit code 0). */
|
|
30
|
+
passed: boolean;
|
|
31
|
+
/** Combined stdout + stderr from the script. */
|
|
32
|
+
output: string;
|
|
33
|
+
/** Wall-clock duration of the check in milliseconds. */
|
|
34
|
+
durationMs: number;
|
|
35
|
+
/** Whether the check timed out. */
|
|
36
|
+
timedOut: boolean;
|
|
37
|
+
}
|
|
38
|
+
|
|
39
|
+
/**
|
|
40
|
+
* Resolve the effective post-check script path.
|
|
41
|
+
* Prefers config.scriptPath; falls back to the PI_CREW_POST_CHECK_SCRIPT env var.
|
|
42
|
+
*/
|
|
43
|
+
function resolveScriptPath(config: PostCheckConfig): string | undefined {
|
|
44
|
+
if (config.scriptPath && config.scriptPath.length > 0) {
|
|
45
|
+
return config.scriptPath;
|
|
46
|
+
}
|
|
47
|
+
return process.env[POST_CHECK_SCRIPT_ENV];
|
|
48
|
+
}
|
|
49
|
+
|
|
50
|
+
/**
|
|
51
|
+
* Run a post-task backpressure check script.
|
|
52
|
+
*
|
|
53
|
+
* Executes the configured bash script and returns a structured result.
|
|
54
|
+
* If no script path is available (neither config nor env var), the check
|
|
55
|
+
* passes by default with a note.
|
|
56
|
+
*
|
|
57
|
+
* **Security note:** The script path is user-configurable (config or env var)
|
|
58
|
+
* and executed with minimal environment (PATH, HOME, USER, LANG). Only use with trusted script
|
|
59
|
+
* paths. No path containment validation is performed.
|
|
60
|
+
*
|
|
61
|
+
* @param config - Post-check configuration (script path and timeout)
|
|
62
|
+
* @param cwd - Working directory for script execution
|
|
63
|
+
* @returns PostCheckResult with pass/fail status, output, and timing
|
|
64
|
+
*/
|
|
65
|
+
export async function runPostCheck(config: PostCheckConfig, cwd: string): Promise<PostCheckResult> {
|
|
66
|
+
const scriptPath = resolveScriptPath(config);
|
|
67
|
+
const timeoutMs = config.timeoutMs > 0 ? config.timeoutMs : DEFAULT_TIMEOUT_MS;
|
|
68
|
+
|
|
69
|
+
if (!scriptPath) {
|
|
70
|
+
return {
|
|
71
|
+
passed: true,
|
|
72
|
+
output: "No post-check script configured; skipping.",
|
|
73
|
+
durationMs: 0,
|
|
74
|
+
timedOut: false,
|
|
75
|
+
};
|
|
76
|
+
}
|
|
77
|
+
|
|
78
|
+
const startTime = Date.now();
|
|
79
|
+
|
|
80
|
+
return new Promise<PostCheckResult>((resolve) => {
|
|
81
|
+
try {
|
|
82
|
+
const output = execFileSync("bash", [scriptPath], {
|
|
83
|
+
cwd,
|
|
84
|
+
timeout: timeoutMs,
|
|
85
|
+
encoding: "utf-8",
|
|
86
|
+
maxBuffer: 10 * 1024 * 1024, // 10 MB
|
|
87
|
+
env: { PATH: process.env.PATH ?? "/usr/bin:/bin", HOME: process.env.HOME ?? "/tmp", USER: process.env.USER, LANG: process.env.LANG, PI_CREW_POST_CHECK: "1" },
|
|
88
|
+
});
|
|
89
|
+
|
|
90
|
+
const durationMs = Date.now() - startTime;
|
|
91
|
+
resolve({
|
|
92
|
+
passed: true,
|
|
93
|
+
output: output.trim(),
|
|
94
|
+
durationMs,
|
|
95
|
+
timedOut: false,
|
|
96
|
+
});
|
|
97
|
+
} catch (error: unknown) {
|
|
98
|
+
const durationMs = Date.now() - startTime;
|
|
99
|
+
|
|
100
|
+
// Determine if this was a timeout
|
|
101
|
+
// execFileSync throws with code 'ETIMEDOUT' or sets killed:true on timeout
|
|
102
|
+
const isTimedOut =
|
|
103
|
+
Boolean((error as NodeJS.ErrnoException & { killed?: boolean }).killed) ||
|
|
104
|
+
(error as NodeJS.ErrnoException).code === "ETIMEDOUT";
|
|
105
|
+
|
|
106
|
+
let output = "";
|
|
107
|
+
if (error instanceof Error) {
|
|
108
|
+
const execError = error as NodeJS.ErrnoException & { stdout?: string; stderr?: string };
|
|
109
|
+
output = [execError.stdout ?? "", execError.stderr ?? "", execError.message ?? ""].join("\n").trim();
|
|
110
|
+
} else {
|
|
111
|
+
output = String(error);
|
|
112
|
+
}
|
|
113
|
+
|
|
114
|
+
resolve({
|
|
115
|
+
passed: false,
|
|
116
|
+
output,
|
|
117
|
+
durationMs,
|
|
118
|
+
timedOut: isTimedOut,
|
|
119
|
+
});
|
|
120
|
+
}
|
|
121
|
+
});
|
|
122
|
+
}
|
|
@@ -9,6 +9,8 @@ export interface ProcessLiveness {
|
|
|
9
9
|
}
|
|
10
10
|
|
|
11
11
|
const ORPHANED_ACTIVE_RUN_MS = 10 * 60 * 1000;
|
|
12
|
+
/** How long a completed run stays visible in the widget after completion. */
|
|
13
|
+
const COMPLETED_VISIBILITY_GRACE_MS = 8000;
|
|
12
14
|
|
|
13
15
|
export function checkProcessLiveness(pid: number | undefined): ProcessLiveness {
|
|
14
16
|
if (pid === undefined || !Number.isInteger(pid) || pid <= 0) {
|
|
@@ -50,7 +52,18 @@ export function hasStaleAsyncProcess(run: TeamRunManifest): boolean {
|
|
|
50
52
|
}
|
|
51
53
|
|
|
52
54
|
export function isDisplayActiveRun(run: TeamRunManifest, agents: CrewAgentRecord[] = [], now = Date.now()): boolean {
|
|
53
|
-
if (
|
|
55
|
+
if (hasStaleAsyncProcess(run) || isLikelyOrphanedActiveRun(run, agents, now)) return false;
|
|
56
|
+
// Grace period: show completed runs for a few seconds so users see the result.
|
|
57
|
+
if (run.status === "completed" || run.status === "failed" || run.status === "cancelled") {
|
|
58
|
+
const lastAgentActivity = agents.reduce<number>((max, agent) => {
|
|
59
|
+
const ts = agent.completedAt ?? agent.startedAt;
|
|
60
|
+
const parsed = ts ? new Date(ts).getTime() : 0;
|
|
61
|
+
return Number.isFinite(parsed) && parsed > max ? parsed : max;
|
|
62
|
+
}, new Date(run.updatedAt).getTime());
|
|
63
|
+
if (Number.isFinite(lastAgentActivity) && now - lastAgentActivity < COMPLETED_VISIBILITY_GRACE_MS) return true;
|
|
64
|
+
return false;
|
|
65
|
+
}
|
|
66
|
+
if (!isActiveRunStatus(run.status)) return false;
|
|
54
67
|
// Keep the always-visible widget quiet until a worker actually exists.
|
|
55
68
|
// Empty active manifests can be created briefly at startup, by old fixture/scaffold
|
|
56
69
|
// runs, or from cross-cwd registry history; showing them causes noisy 0/0 rows and
|