pi-crew 0.1.37 → 0.1.39

package/src/utils/paths.ts

@@ -29,14 +29,15 @@ export function findRepoRoot(cwd: string): string | undefined {
 	let current = path.resolve(cwd);
 	const root = path.parse(current).root;
 	const home = path.resolve(os.homedir());
+	const tempRoot = path.resolve(os.tmpdir());
 	while (current !== root) {
-		if (current === home) return undefined;
+		if (current === home || current === tempRoot) return undefined;
 		if (hasProjectMarker(current)) return current;
 		const parent = path.dirname(current);
 		if (parent === current) break;
 		current = parent;
 	}
-	if (current === home) return undefined;
+	if (current === home || current === tempRoot) return undefined;
 	if (hasProjectMarker(root)) return root;
 	return undefined;
 }

package/src/utils/safe-paths.ts

@@ -0,0 +1,34 @@
+import * as fs from "node:fs";
+import * as path from "node:path";
+
+export function isSafePathId(value: string): boolean {
+	return /^[A-Za-z0-9_-]+$/.test(value);
+}
+
+export function assertSafePathId(kind: string, value: string): string {
+	if (!isSafePathId(value)) throw new Error(`Invalid ${kind}: ${value}`);
+	return value;
+}
+
+export function resolveContainedPath(baseDir: string, targetPath: string): string {
+	const base = path.resolve(baseDir);
+	const resolved = path.isAbsolute(targetPath) ? path.resolve(targetPath) : path.resolve(base, targetPath);
+	const relative = path.relative(base, resolved);
+	if (relative.startsWith("..") || path.isAbsolute(relative)) throw new Error(`Path is outside ${baseDir}: ${targetPath}`);
+	return resolved;
+}
+
+export function resolveRealContainedPath(baseDir: string, targetPath: string): string {
+	const resolved = resolveContainedPath(baseDir, targetPath);
+	const realBase = fs.realpathSync.native(baseDir);
+	const realTarget = fs.realpathSync.native(resolved);
+	const relative = path.relative(realBase, realTarget);
+	if (relative.startsWith("..") || path.isAbsolute(relative)) throw new Error(`Path is outside ${baseDir}: ${targetPath}`);
+	return realTarget;
+}
+
+export function resolveContainedRelativePath(baseDir: string, relativePath: string, kind = "path"): string {
+	const normalized = relativePath.replaceAll("\\", "/").replace(/^\.\/+/, "");
+	if (!normalized || normalized.split("/").some((segment) => segment === "..") || path.isAbsolute(normalized)) throw new Error(`Invalid ${kind}: ${relativePath}`);
+	return resolveContainedPath(baseDir, path.resolve(baseDir, normalized));
+}

package/src/utils/sleep.ts

@@ -1,32 +1,32 @@
-/**
- * Sleep helper that respects abort signal.
- */
-export function sleep(ms: number, signal?: AbortSignal): Promise<void> {
-	return new Promise((resolve, reject) => {
-		if (signal?.aborted) {
-			reject(new Error("Aborted"));
-			return;
-		}
-
-		let settled = false;
-		const cleanup = (): void => {
-			if (signal) signal.removeEventListener("abort", onAbort);
-		};
-		const timeout = setTimeout(() => {
-			if (settled) return;
-			settled = true;
-			cleanup();
-			resolve();
-		}, ms);
-
-		const onAbort = (): void => {
-			if (settled) return;
-			settled = true;
-			clearTimeout(timeout);
-			cleanup();
-			reject(new Error("Aborted"));
-		};
-
-		signal?.addEventListener("abort", onAbort);
-	});
-}
+/**
+ * Sleep helper that respects abort signal.
+ */
+export function sleep(ms: number, signal?: AbortSignal): Promise<void> {
+	return new Promise((resolve, reject) => {
+		if (signal?.aborted) {
+			reject(new Error("Aborted"));
+			return;
+		}
+
+		let settled = false;
+		const cleanup = (): void => {
+			if (signal) signal.removeEventListener("abort", onAbort);
+		};
+		const timeout = setTimeout(() => {
+			if (settled) return;
+			settled = true;
+			cleanup();
+			resolve();
+		}, ms);
+
+		const onAbort = (): void => {
+			if (settled) return;
+			settled = true;
+			clearTimeout(timeout);
+			cleanup();
+			reject(new Error("Aborted"));
+		};
+
+		signal?.addEventListener("abort", onAbort);
+	});
+}

package/src/utils/timings.ts

@@ -1,31 +1,31 @@
-/**
- * Central timing instrumentation for startup profiling.
- * Enable with PI_TIMING=1 environment variable.
- */
-
-const ENABLED = process.env.PI_TIMING === "1";
-const timings: Array<{ label: string; ms: number }> = [];
-let lastTime = Date.now();
-
-export function resetTimings(): void {
-	if (!ENABLED) return;
-	timings.length = 0;
-	lastTime = Date.now();
-}
-
-export function time(label: string): void {
-	if (!ENABLED) return;
-	const now = Date.now();
-	timings.push({ label, ms: now - lastTime });
-	lastTime = now;
-}
-
-export function printTimings(): void {
-	if (!ENABLED || timings.length === 0) return;
-	console.error("\n--- Startup Timings ---");
-	for (const t of timings) {
-		console.error(`  ${t.label}: ${t.ms}ms`);
-	}
-	console.error(`  TOTAL: ${timings.reduce((a, b) => a + b.ms, 0)}ms`);
-	console.error("------------------------\n");
-}
+/**
+ * Central timing instrumentation for startup profiling.
+ * Enable with PI_TIMING=1 environment variable.
+ */
+
+const ENABLED = process.env.PI_TIMING === "1";
+const timings: Array<{ label: string; ms: number }> = [];
+let lastTime = Date.now();
+
+export function resetTimings(): void {
+	if (!ENABLED) return;
+	timings.length = 0;
+	lastTime = Date.now();
+}
+
+export function time(label: string): void {
+	if (!ENABLED) return;
+	const now = Date.now();
+	timings.push({ label, ms: now - lastTime });
+	lastTime = now;
+}
+
+export function printTimings(): void {
+	if (!ENABLED || timings.length === 0) return;
+	console.error("\n--- Startup Timings ---");
+	for (const t of timings) {
+		console.error(`  ${t.label}: ${t.ms}ms`);
+	}
+	console.error(`  TOTAL: ${timings.reduce((a, b) => a + b.ms, 0)}ms`);
+	console.error("------------------------\n");
+}

package/src/utils/visual.ts

@@ -1,159 +1,159 @@
-export const ANSI_PATTERN = /\u001b\[[0-?]*[ -/]*[@-~]/g;
-
-const WIDTH_CACHE_LIMIT = 256;
-const widthCache = new Map<string, number>();
-
-export function visibleWidth(value: string): number {
-	const cached = widthCache.get(value);
-	if (cached !== undefined) return cached;
-	let length = 0;
-	for (const char of value.replace(ANSI_PATTERN, "")) {
-		if (char !== "\n") length += 1;
-	}
-	if (widthCache.size >= WIDTH_CACHE_LIMIT) {
-		const firstKey = widthCache.keys().next().value;
-		if (firstKey !== undefined) widthCache.delete(firstKey);
-	}
-	widthCache.set(value, length);
-	return length;
-}
-
-export function __test__clearVisibleWidthCache(): void {
-	widthCache.clear();
-}
-
-export function __test__visibleWidthCacheSize(): number {
-	return widthCache.size;
-}
-
-function consumeAnsi(input: string, index: number): number {
-	const char = input[index];
-	if (!char || char !== "\u001b") return 0;
-	if (input[index + 1] !== "[") return 0;
-	let i = index + 2;
-	while (i < input.length) {
-		const code = input.charCodeAt(i);
-		if (code >= 0x40 && code <= 0x7e) return i - index + 1;
-		i++;
-	}
-	return 0;
-}
-
-function splitGraphemes(value: string): string[] {
-	return Array.from(value.replace(ANSI_PATTERN, ""));
-}
-
-export function truncateToWidth(value: string, width: number, ellipsis = "…"): string {
-	if (width <= 0) return "";
-	if (visibleWidth(value) <= width) return value;
-	if (width <= ellipsis.length) return ellipsis.slice(0, width);
-	let output = "";
-	let renderedWidth = 0;
-	for (let i = 0; i < value.length; i++) {
-		const ansiLen = consumeAnsi(value, i);
-		if (ansiLen) {
-			output += value.slice(i, i + ansiLen);
-			i += ansiLen - 1;
-			continue;
-		}
-		const char = value[i] as string;
-		const nextIndex = i + (char.codePointAt(0) ?? 0) > 0xFFFF ? i + 2 : i + 1;
-		const segment = value.slice(i, nextIndex);
-		const charWidth = visibleWidth(segment);
-		if (renderedWidth + charWidth > width - ellipsis.length) {
-			return `${output}${ellipsis}`;
-		}
-		output += segment;
-		renderedWidth += charWidth;
-		i = nextIndex - 1;
-	}
-	return output;
-}
-
-export const truncate = truncateToWidth;
-
-export function pad(value: string, width: number): string {
-	const current = visibleWidth(value);
-	if (current >= width) return value;
-	return `${value}${" ".repeat(width - current)}`;
-}
-
-export function boxLine(text: string, innerWidth: number): string {
-	return `│ ${truncate(text, innerWidth - 4)} │`;
-}
-
-function readAnsiCode(input: string, index: number): string | undefined {
-	const ansiLength = consumeAnsi(input, index);
-	if (ansiLength > 0) return input.slice(index, index + ansiLength);
-	return undefined;
-}
-
-function takeCodePoint(input: string, index: number): { chunk: string; nextIndex: number } {
-	const code = input.codePointAt(index);
-	if (code === undefined) return { chunk: "", nextIndex: index + 1 };
-	if (code >= 0xD800 && code <= 0xDBFF && index + 1 < input.length) {
-		return { chunk: input.slice(index, index + 2), nextIndex: index + 2 };
-	}
-	return { chunk: input[index] ?? "", nextIndex: index + 1 };
-}
-
-export function wrapHard(value: string, width: number): string[] {
-	if (width <= 0 || !value) return [];
-	const lines: string[] = [];
-	let current = "";
-	let currentWidth = 0;
-	let i = 0;
-	while (i < value.length) {
-		const ansi = readAnsiCode(value, i);
-		if (ansi) {
-			current += ansi;
-			i += ansi.length;
-			continue;
-		}
-		const { chunk, nextIndex } = takeCodePoint(value, i);
-		const chunkWidth = visibleWidth(chunk);
-		if (chunkWidth > width) {
-			lines.push(current ? current + chunk : chunk);
-			current = "";
-			currentWidth = 0;
-			i = nextIndex;
-			continue;
-		}
-		if (currentWidth + chunkWidth > width) {
-			if (current) lines.push(current);
-			current = chunk;
-			currentWidth = chunkWidth;
-			i = nextIndex;
-			continue;
-		}
-		current += chunk;
-		currentWidth += chunkWidth;
-		i = nextIndex;
-	}
-	if (current) lines.push(current);
-	return lines.length > 0 ? lines : [""];
-}
-
-export interface VisualTruncateResult {
-	visualLines: string[];
-	skippedCount: number;
-}
-
-export function truncateToVisualLines(
-	text: string,
-	maxVisualLines: number,
-	width: number,
-	paddingX = 0,
-): VisualTruncateResult {
-	if (!text) {
-		return { visualLines: [], skippedCount: 0 };
-	}
-	const effectiveWidth = Math.max(1, width - paddingX * 2);
-	const limit = Math.max(1, maxVisualLines);
-	const visualLines = text
-		.split("\n")
-		.flatMap((line) => wrapHard(pad(line, Math.max(0, effectiveWidth)).trimEnd(), effectiveWidth));
-	if (visualLines.length <= limit) return { visualLines, skippedCount: 0 };
-	const truncated = visualLines.slice(-limit);
-	return { visualLines: truncated, skippedCount: visualLines.length - limit };
-}
+export const ANSI_PATTERN = /\u001b\[[0-?]*[ -/]*[@-~]/g;
+
+const WIDTH_CACHE_LIMIT = 256;
+const widthCache = new Map<string, number>();
+
+export function visibleWidth(value: string): number {
+	const cached = widthCache.get(value);
+	if (cached !== undefined) return cached;
+	let length = 0;
+	for (const char of value.replace(ANSI_PATTERN, "")) {
+		if (char !== "\n") length += 1;
+	}
+	if (widthCache.size >= WIDTH_CACHE_LIMIT) {
+		const firstKey = widthCache.keys().next().value;
+		if (firstKey !== undefined) widthCache.delete(firstKey);
+	}
+	widthCache.set(value, length);
+	return length;
+}
+
+export function __test__clearVisibleWidthCache(): void {
+	widthCache.clear();
+}
+
+export function __test__visibleWidthCacheSize(): number {
+	return widthCache.size;
+}
+
+function consumeAnsi(input: string, index: number): number {
+	const char = input[index];
+	if (!char || char !== "\u001b") return 0;
+	if (input[index + 1] !== "[") return 0;
+	let i = index + 2;
+	while (i < input.length) {
+		const code = input.charCodeAt(i);
+		if (code >= 0x40 && code <= 0x7e) return i - index + 1;
+		i++;
+	}
+	return 0;
+}
+
+function splitGraphemes(value: string): string[] {
+	return Array.from(value.replace(ANSI_PATTERN, ""));
+}
+
+export function truncateToWidth(value: string, width: number, ellipsis = "…"): string {
+	if (width <= 0) return "";
+	if (visibleWidth(value) <= width) return value;
+	if (width <= ellipsis.length) return ellipsis.slice(0, width);
+	let output = "";
+	let renderedWidth = 0;
+	for (let i = 0; i < value.length; i++) {
+		const ansiLen = consumeAnsi(value, i);
+		if (ansiLen) {
+			output += value.slice(i, i + ansiLen);
+			i += ansiLen - 1;
+			continue;
+		}
+		const char = value[i] as string;
+		const nextIndex = i + (char.codePointAt(0) ?? 0) > 0xFFFF ? i + 2 : i + 1;
+		const segment = value.slice(i, nextIndex);
+		const charWidth = visibleWidth(segment);
+		if (renderedWidth + charWidth > width - ellipsis.length) {
+			return `${output}${ellipsis}`;
+		}
+		output += segment;
+		renderedWidth += charWidth;
+		i = nextIndex - 1;
+	}
+	return output;
+}
+
+export const truncate = truncateToWidth;
+
+export function pad(value: string, width: number): string {
+	const current = visibleWidth(value);
+	if (current >= width) return value;
+	return `${value}${" ".repeat(width - current)}`;
+}
+
+export function boxLine(text: string, innerWidth: number): string {
+	return `│ ${truncate(text, innerWidth - 4)} │`;
+}
+
+function readAnsiCode(input: string, index: number): string | undefined {
+	const ansiLength = consumeAnsi(input, index);
+	if (ansiLength > 0) return input.slice(index, index + ansiLength);
+	return undefined;
+}
+
+function takeCodePoint(input: string, index: number): { chunk: string; nextIndex: number } {
+	const code = input.codePointAt(index);
+	if (code === undefined) return { chunk: "", nextIndex: index + 1 };
+	if (code >= 0xD800 && code <= 0xDBFF && index + 1 < input.length) {
+		return { chunk: input.slice(index, index + 2), nextIndex: index + 2 };
+	}
+	return { chunk: input[index] ?? "", nextIndex: index + 1 };
+}
+
+export function wrapHard(value: string, width: number): string[] {
+	if (width <= 0 || !value) return [];
+	const lines: string[] = [];
+	let current = "";
+	let currentWidth = 0;
+	let i = 0;
+	while (i < value.length) {
+		const ansi = readAnsiCode(value, i);
+		if (ansi) {
+			current += ansi;
+			i += ansi.length;
+			continue;
+		}
+		const { chunk, nextIndex } = takeCodePoint(value, i);
+		const chunkWidth = visibleWidth(chunk);
+		if (chunkWidth > width) {
+			lines.push(current ? current + chunk : chunk);
+			current = "";
+			currentWidth = 0;
+			i = nextIndex;
+			continue;
+		}
+		if (currentWidth + chunkWidth > width) {
+			if (current) lines.push(current);
+			current = chunk;
+			currentWidth = chunkWidth;
+			i = nextIndex;
+			continue;
+		}
+		current += chunk;
+		currentWidth += chunkWidth;
+		i = nextIndex;
+	}
+	if (current) lines.push(current);
+	return lines.length > 0 ? lines : [""];
+}
+
+export interface VisualTruncateResult {
+	visualLines: string[];
+	skippedCount: number;
+}
+
+export function truncateToVisualLines(
+	text: string,
+	maxVisualLines: number,
+	width: number,
+	paddingX = 0,
+): VisualTruncateResult {
+	if (!text) {
+		return { visualLines: [], skippedCount: 0 };
+	}
+	const effectiveWidth = Math.max(1, width - paddingX * 2);
+	const limit = Math.max(1, maxVisualLines);
+	const visualLines = text
+		.split("\n")
+		.flatMap((line) => wrapHard(pad(line, Math.max(0, effectiveWidth)).trimEnd(), effectiveWidth));
+	if (visualLines.length <= limit) return { visualLines, skippedCount: 0 };
+	const truncated = visualLines.slice(-limit);
+	return { visualLines: truncated, skippedCount: visualLines.length - limit };
+}

package/src/workflows/discover-workflows.ts

@@ -11,20 +11,25 @@ export interface WorkflowDiscoveryResult {
 	project: WorkflowConfig[];
 }
 
+const STEP_CONFIG_KEYS = new Set(["role", "dependsOn", "parallelGroup", "output", "reads", "model", "skills", "progress", "worktree", "verify", "task"]);
+
 function parseStepSection(id: string, body: string): WorkflowStep | undefined {
 	const lines = body.trim().split("\n");
 	const config: Record<string, string> = {};
 	const taskLines: string[] = [];
 	let inTask = false;
+	let sawConfig = false;
 	for (const line of lines) {
 		if (!inTask) {
 			if (line.trim() === "") {
+				if (!sawConfig) continue;
 				inTask = true;
 				continue;
 			}
 			const match = line.match(/^([\w-]+):\s*(.*)$/);
 			if (match) {
 				config[match[1]!.trim()] = match[2]!.trim();
+				sawConfig = true;
 				continue;
 			}
 			inTask = true;
@@ -55,18 +60,40 @@ const parseOptionalInteger = (value: string | undefined): number | undefined =>
 	return Math.trunc(parsed);
 };
 
+function hasSectionBoundary(body: string, match: RegExpMatchArray): boolean {
+	const index = match.index ?? 0;
+	return index === 0 || body.slice(0, index).trim() === "" || body.slice(Math.max(0, index - 2), index) === "\n\n";
+}
+
+function isStepHeading(body: string, match: RegExpMatchArray): boolean {
+	const sectionStart = match.index! + match[0].length + (body[match.index! + match[0].length] === "\n" ? 1 : 0);
+	const nextHeading = body.slice(sectionStart).search(/^##\s+.+[^\S\n]*$/m);
+	const section = body.slice(sectionStart, nextHeading >= 0 ? sectionStart + nextHeading : body.length);
+	for (const line of section.split("\n")) {
+		const trimmed = line.trim();
+		if (!trimmed) continue;
+		const config = trimmed.match(/^([\w-]+):\s*(.*)$/);
+		if (config && STEP_CONFIG_KEYS.has(config[1]!)) return true;
+		return false;
+	}
+	return false;
+}
+
 function parseWorkflowFile(filePath: string, source: ResourceSource): WorkflowConfig | undefined {
 	try {
 		const content = fs.readFileSync(filePath, "utf-8");
 		const { frontmatter, body } = parseFrontmatter(content);
 		const name = frontmatter.name?.trim() || path.basename(filePath, ".workflow.md");
 		const matches = [...body.matchAll(/^##\s+(.+)[^\S\n]*$/gm)];
+		const explicitStepIndexes = new Set(matches.map((match, index) => isStepHeading(body, match) ? index : undefined).filter((index): index is number => index !== undefined));
+		const effectiveMatches = matches.filter((match, index) => explicitStepIndexes.has(index) || (hasSectionBoundary(body, match) && /^[a-z][a-z0-9-]*$/.test(match[1]?.trim() ?? "")));
+		const parseMatches = explicitStepIndexes.size ? effectiveMatches : matches;
 		const steps: WorkflowStep[] = [];
-		for (let i = 0; i < matches.length; i++) {
-			const match = matches[i]!;
+		for (let i = 0; i < parseMatches.length; i++) {
+			const match = parseMatches[i]!;
 			const id = match[1]!.trim();
 			const sectionStart = match.index! + match[0].length + (body[match.index! + match[0].length] === "\n" ? 1 : 0);
-			const sectionEnd = i + 1 < matches.length ? matches[i + 1]!.index! : body.length;
+			const sectionEnd = i + 1 < parseMatches.length ? parseMatches[i + 1]!.index! : body.length;
 			const step = parseStepSection(id, body.slice(sectionStart, sectionEnd));
 			if (step) steps.push(step);
 		}

package/src/workflows/validate-workflow.ts

@@ -1,40 +1,40 @@
-import type { TeamConfig } from "../teams/team-config.ts";
-import type { WorkflowConfig } from "./workflow-config.ts";
-
-export function validateWorkflowForTeam(workflow: WorkflowConfig, team: TeamConfig): string[] {
-	const errors: string[] = [];
-	const roles = new Set(team.roles.map((role) => role.name));
-	const stepIds = new Set<string>();
-
-	for (const step of workflow.steps) {
-		if (stepIds.has(step.id)) errors.push(`Duplicate workflow step id '${step.id}'.`);
-		stepIds.add(step.id);
-		if (!roles.has(step.role)) errors.push(`Step '${step.id}' references unknown team role '${step.role}'.`);
-	}
-
-	for (const step of workflow.steps) {
-		for (const dep of step.dependsOn ?? []) {
-			if (!stepIds.has(dep)) errors.push(`Step '${step.id}' depends on unknown step '${dep}'.`);
-		}
-	}
-
-	const visiting = new Set<string>();
-	const visited = new Set<string>();
-	const byId = new Map(workflow.steps.map((step) => [step.id, step]));
-
-	function visit(id: string, trail: string[]): void {
-		if (visited.has(id)) return;
-		if (visiting.has(id)) {
-			errors.push(`Workflow dependency cycle detected: ${[...trail, id].join(" -> ")}.`);
-			return;
-		}
-		visiting.add(id);
-		const step = byId.get(id);
-		for (const dep of step?.dependsOn ?? []) visit(dep, [...trail, id]);
-		visiting.delete(id);
-		visited.add(id);
-	}
-
-	for (const step of workflow.steps) visit(step.id, []);
-	return [...new Set(errors)];
-}
+import type { TeamConfig } from "../teams/team-config.ts";
+import type { WorkflowConfig } from "./workflow-config.ts";
+
+export function validateWorkflowForTeam(workflow: WorkflowConfig, team: TeamConfig): string[] {
+	const errors: string[] = [];
+	const roles = new Set(team.roles.map((role) => role.name));
+	const stepIds = new Set<string>();
+
+	for (const step of workflow.steps) {
+		if (stepIds.has(step.id)) errors.push(`Duplicate workflow step id '${step.id}'.`);
+		stepIds.add(step.id);
+		if (!roles.has(step.role)) errors.push(`Step '${step.id}' references unknown team role '${step.role}'.`);
+	}
+
+	for (const step of workflow.steps) {
+		for (const dep of step.dependsOn ?? []) {
+			if (!stepIds.has(dep)) errors.push(`Step '${step.id}' depends on unknown step '${dep}'.`);
+		}
+	}
+
+	const visiting = new Set<string>();
+	const visited = new Set<string>();
+	const byId = new Map(workflow.steps.map((step) => [step.id, step]));
+
+	function visit(id: string, trail: string[]): void {
+		if (visited.has(id)) return;
+		if (visiting.has(id)) {
+			errors.push(`Workflow dependency cycle detected: ${[...trail, id].join(" -> ")}.`);
+			return;
+		}
+		visiting.add(id);
+		const step = byId.get(id);
+		for (const dep of step?.dependsOn ?? []) visit(dep, [...trail, id]);
+		visiting.delete(id);
+		visited.add(id);
+	}
+
+	for (const step of workflow.steps) visit(step.id, []);
+	return [...new Set(errors)];
+}