pi-crew 0.1.37 → 0.1.39

package/src/ui/syntax-highlight.ts

@@ -1,116 +1,116 @@
-import { supportsLanguage, highlight } from "cli-highlight";
-import type { CrewTheme } from "./theme-adapter.ts";
-import { asCrewTheme } from "./theme-adapter.ts";
-
-function buildCliTheme(theme: CrewTheme): Record<string, (text: string) => string> {
-	return {
-		keyword: (text) => theme.fg("syntaxKeyword", text),
-		built_in: (text) => theme.fg("syntaxType", text),
-		literal: (text) => theme.fg("syntaxNumber", text),
-		number: (text) => theme.fg("syntaxNumber", text),
-		string: (text) => theme.fg("syntaxString", text),
-		comment: (text) => theme.fg("syntaxComment", text),
-		function: (text) => theme.fg("syntaxFunction", text),
-		title: (text) => theme.fg("syntaxFunction", text),
-		class: (text) => theme.fg("syntaxType", text),
-		type: (text) => theme.fg("syntaxType", text),
-		attr: (text) => theme.fg("syntaxVariable", text),
-		variable: (text) => theme.fg("syntaxVariable", text),
-		params: (text) => theme.fg("syntaxVariable", text),
-		operator: (text) => theme.fg("syntaxOperator", text),
-		punctuation: (text) => theme.fg("syntaxPunctuation", text),
-	};
-}
-
-export function detectLanguageFromPath(filePath: string): string | undefined {
-	const ext = filePath.split(".").pop()?.toLowerCase();
-	if (!ext) return undefined;
-	return languageMap[ext];
-}
-
-export const languageMap: Record<string, string> = {
-	ts: "typescript",
-	tsx: "typescript",
-	js: "javascript",
-	jsx: "javascript",
-	mjs: "javascript",
-	cjs: "javascript",
-	py: "python",
-	md: "markdown",
-	markdown: "markdown",
-	json: "json",
-	yml: "yaml",
-	yaml: "yaml",
-	toml: "yaml",
-	html: "html",
-	htm: "html",
-	css: "css",
-	scss: "scss",
-	sass: "sass",
-	bash: "bash",
-	sh: "bash",
-	zsh: "bash",
-	fish: "bash",
-	ps1: "powershell",
-	sql: "sql",
-	rust: "rust",
-	rb: "ruby",
-	go: "go",
-	java: "java",
-	kt: "kotlin",
-	cpp: "cpp",
-	cc: "cpp",
-	cxx: "cpp",
-	hpp: "cpp",
-	c: "c",
-	h: "c",
-	cs: "csharp",
-	php: "php",
-};
-
-export function highlightCode(code: string, language: string | undefined, themeLike: unknown = undefined): string {
-	const theme = asCrewTheme(themeLike);
-	const validLanguage = language && supportsLanguage(language) ? language : undefined;
-	if (!validLanguage) {
-		return code
-			.split("\n")
-			.map((line) => theme.fg("mdCodeBlock", line))
-			.join("\n");
-	}
-	try {
-		return highlight(code, {
-			language: validLanguage,
-			ignoreIllegals: true,
-			theme: buildCliTheme(theme),
-		}).trimEnd();
-	} catch {
-		return code
-			.split("\n")
-			.map((line) => theme.fg("mdCodeBlock", line))
-			.join("\n");
-	}
-}
-
-export function highlightJson(payload: string, themeLike: unknown = undefined): string {
-	const theme = asCrewTheme(themeLike);
-	try {
-		return highlight(payload, {
-			language: "json",
-			ignoreIllegals: true,
-			theme: buildCliTheme(theme),
-		}).trimEnd();
-	} catch {
-		try {
-			const parsed = JSON.parse(payload);
-			return JSON.stringify(parsed, null, 2)
-				.split("\n")
-				.map((line) => theme.fg("mdCodeBlock", line))
-				.join("\n");
-		} catch {
-			return payload
-				.split("\n")
-				.map((line) => theme.fg("mdCodeBlock", line))
-				.join("\n");
-		}
-	}
-}
+import { supportsLanguage, highlight } from "cli-highlight";
+import type { CrewTheme } from "./theme-adapter.ts";
+import { asCrewTheme } from "./theme-adapter.ts";
+
+function buildCliTheme(theme: CrewTheme): Record<string, (text: string) => string> {
+	return {
+		keyword: (text) => theme.fg("syntaxKeyword", text),
+		built_in: (text) => theme.fg("syntaxType", text),
+		literal: (text) => theme.fg("syntaxNumber", text),
+		number: (text) => theme.fg("syntaxNumber", text),
+		string: (text) => theme.fg("syntaxString", text),
+		comment: (text) => theme.fg("syntaxComment", text),
+		function: (text) => theme.fg("syntaxFunction", text),
+		title: (text) => theme.fg("syntaxFunction", text),
+		class: (text) => theme.fg("syntaxType", text),
+		type: (text) => theme.fg("syntaxType", text),
+		attr: (text) => theme.fg("syntaxVariable", text),
+		variable: (text) => theme.fg("syntaxVariable", text),
+		params: (text) => theme.fg("syntaxVariable", text),
+		operator: (text) => theme.fg("syntaxOperator", text),
+		punctuation: (text) => theme.fg("syntaxPunctuation", text),
+	};
+}
+
+export function detectLanguageFromPath(filePath: string): string | undefined {
+	const ext = filePath.split(".").pop()?.toLowerCase();
+	if (!ext) return undefined;
+	return languageMap[ext];
+}
+
+export const languageMap: Record<string, string> = {
+	ts: "typescript",
+	tsx: "typescript",
+	js: "javascript",
+	jsx: "javascript",
+	mjs: "javascript",
+	cjs: "javascript",
+	py: "python",
+	md: "markdown",
+	markdown: "markdown",
+	json: "json",
+	yml: "yaml",
+	yaml: "yaml",
+	toml: "yaml",
+	html: "html",
+	htm: "html",
+	css: "css",
+	scss: "scss",
+	sass: "sass",
+	bash: "bash",
+	sh: "bash",
+	zsh: "bash",
+	fish: "bash",
+	ps1: "powershell",
+	sql: "sql",
+	rust: "rust",
+	rb: "ruby",
+	go: "go",
+	java: "java",
+	kt: "kotlin",
+	cpp: "cpp",
+	cc: "cpp",
+	cxx: "cpp",
+	hpp: "cpp",
+	c: "c",
+	h: "c",
+	cs: "csharp",
+	php: "php",
+};
+
+export function highlightCode(code: string, language: string | undefined, themeLike: unknown = undefined): string {
+	const theme = asCrewTheme(themeLike);
+	const validLanguage = language && supportsLanguage(language) ? language : undefined;
+	if (!validLanguage) {
+		return code
+			.split("\n")
+			.map((line) => theme.fg("mdCodeBlock", line))
+			.join("\n");
+	}
+	try {
+		return highlight(code, {
+			language: validLanguage,
+			ignoreIllegals: true,
+			theme: buildCliTheme(theme),
+		}).trimEnd();
+	} catch {
+		return code
+			.split("\n")
+			.map((line) => theme.fg("mdCodeBlock", line))
+			.join("\n");
+	}
+}
+
+export function highlightJson(payload: string, themeLike: unknown = undefined): string {
+	const theme = asCrewTheme(themeLike);
+	try {
+		return highlight(payload, {
+			language: "json",
+			ignoreIllegals: true,
+			theme: buildCliTheme(theme),
+		}).trimEnd();
+	} catch {
+		try {
+			const parsed = JSON.parse(payload);
+			return JSON.stringify(parsed, null, 2)
+				.split("\n")
+				.map((line) => theme.fg("mdCodeBlock", line))
+				.join("\n");
+		} catch {
+			return payload
+				.split("\n")
+				.map((line) => theme.fg("mdCodeBlock", line))
+				.join("\n");
+		}
+	}
+}

package/src/ui/transcript-viewer.ts

@@ -8,6 +8,7 @@ import { highlightCode, highlightJson } from "./syntax-highlight.ts";
 import { pad, truncate, truncateToVisualLines } from "../utils/visual.ts";
 import { colorForStatus, iconForStatus, type RunStatus } from "./status-colors.ts";
 import { DEFAULT_TRANSCRIPT_TAIL_BYTES, getTranscriptCacheEntry, readTranscriptLinesCached } from "./transcript-cache.ts";
+import { resolveRealContainedPath } from "../utils/safe-paths.ts";
 
 type Component = { invalidate(): void; render(width: number): string[]; handleInput(data: string): void };
 
@@ -128,7 +129,20 @@ export function readRunTranscript(manifest: TeamRunManifest, taskId?: string, op
 	const agents = readCrewAgents(manifest);
 	const agent = taskId ? agents.find((item) => item.taskId === taskId || item.id === taskId) : agents.find((item) => item.transcriptPath) ?? agents[0];
 	const selectedTaskId = agent?.taskId ?? taskId ?? "unknown";
-	const transcriptPath = agent?.transcriptPath && fs.existsSync(agent.transcriptPath) ? agent.transcriptPath : agentOutputPath(manifest, selectedTaskId);
+	let transcriptPath: string;
+	try {
+		transcriptPath = agentOutputPath(manifest, selectedTaskId);
+	} catch {
+		transcriptPath = agentOutputPath(manifest, "unknown");
+	}
+	if (agent?.transcriptPath) {
+		try {
+			const safeTranscriptPath = resolveRealContainedPath(manifest.artifactsRoot, agent.transcriptPath);
+			if (fs.existsSync(safeTranscriptPath)) transcriptPath = safeTranscriptPath;
+		} catch {
+			// Ignore untrusted transcript paths from mutable agent state and fall back to durable agent output.
+		}
+	}
 	const readOptions = { full: options.full === true, maxTailBytes: options.maxTailBytes ?? DEFAULT_TRANSCRIPT_TAIL_BYTES };
 	const lines = readTranscriptLinesCached(transcriptPath, (text) => formatTranscriptText(text), Date.now(), readOptions);
 	const entry = getTranscriptCacheEntry(transcriptPath, readOptions);

package/src/utils/completion-dedupe.ts

@@ -1,63 +1,63 @@
-interface CompletionDataLike {
-	id?: unknown;
-	agent?: unknown;
-	timestamp?: unknown;
-	sessionId?: unknown;
-	taskIndex?: unknown;
-	totalTasks?: unknown;
-	success?: unknown;
-}
-
-function asNonEmptyString(value: unknown): string | undefined {
-	if (typeof value !== "string") return undefined;
-	const trimmed = value.trim();
-	return trimmed.length > 0 ? trimmed : undefined;
-}
-
-function asFiniteNumber(value: unknown): number | undefined {
-	if (typeof value !== "number") return undefined;
-	return Number.isFinite(value) ? value : undefined;
-}
-
-export function buildCompletionKey(data: CompletionDataLike, fallback: string): string {
-	const id = asNonEmptyString(data.id);
-	if (id) return `id:${id}`;
-	const sessionId = asNonEmptyString(data.sessionId) ?? "no-session";
-	const agent = asNonEmptyString(data.agent) ?? "unknown";
-	const timestamp = asFiniteNumber(data.timestamp);
-	const taskIndex = asFiniteNumber(data.taskIndex);
-	const totalTasks = asFiniteNumber(data.totalTasks);
-	const success = typeof data.success === "boolean" ? (data.success ? "1" : "0") : "?";
-	return [
-		"meta",
-		sessionId,
-		agent,
-		timestamp !== undefined ? String(timestamp) : "no-ts",
-		taskIndex !== undefined ? String(taskIndex) : "-",
-		totalTasks !== undefined ? String(totalTasks) : "-",
-		success,
-		fallback,
-	].join(":");
-}
-
-export function pruneSeenMap(seen: Map<string, number>, now: number, ttlMs: number): void {
-	for (const [key, ts] of seen.entries()) {
-		if (now - ts > ttlMs) seen.delete(key);
-	}
-}
-
-export function markSeenWithTtl(seen: Map<string, number>, key: string, now: number, ttlMs: number): boolean {
-	pruneSeenMap(seen, now, ttlMs);
-	if (seen.has(key)) return true;
-	seen.set(key, now);
-	return false;
-}
-
-export function getGlobalSeenMap(storeKey: string): Map<string, number> {
-	const globalStore = globalThis as Record<string, unknown>;
-	const existing = globalStore[storeKey];
-	if (existing instanceof Map) return existing as Map<string, number>;
-	const map = new Map<string, number>();
-	globalStore[storeKey] = map;
-	return map;
-}
+interface CompletionDataLike {
+	id?: unknown;
+	agent?: unknown;
+	timestamp?: unknown;
+	sessionId?: unknown;
+	taskIndex?: unknown;
+	totalTasks?: unknown;
+	success?: unknown;
+}
+
+function asNonEmptyString(value: unknown): string | undefined {
+	if (typeof value !== "string") return undefined;
+	const trimmed = value.trim();
+	return trimmed.length > 0 ? trimmed : undefined;
+}
+
+function asFiniteNumber(value: unknown): number | undefined {
+	if (typeof value !== "number") return undefined;
+	return Number.isFinite(value) ? value : undefined;
+}
+
+export function buildCompletionKey(data: CompletionDataLike, fallback: string): string {
+	const id = asNonEmptyString(data.id);
+	if (id) return `id:${id}`;
+	const sessionId = asNonEmptyString(data.sessionId) ?? "no-session";
+	const agent = asNonEmptyString(data.agent) ?? "unknown";
+	const timestamp = asFiniteNumber(data.timestamp);
+	const taskIndex = asFiniteNumber(data.taskIndex);
+	const totalTasks = asFiniteNumber(data.totalTasks);
+	const success = typeof data.success === "boolean" ? (data.success ? "1" : "0") : "?";
+	return [
+		"meta",
+		sessionId,
+		agent,
+		timestamp !== undefined ? String(timestamp) : "no-ts",
+		taskIndex !== undefined ? String(taskIndex) : "-",
+		totalTasks !== undefined ? String(totalTasks) : "-",
+		success,
+		fallback,
+	].join(":");
+}
+
+export function pruneSeenMap(seen: Map<string, number>, now: number, ttlMs: number): void {
+	for (const [key, ts] of seen.entries()) {
+		if (now - ts > ttlMs) seen.delete(key);
+	}
+}
+
+export function markSeenWithTtl(seen: Map<string, number>, key: string, now: number, ttlMs: number): boolean {
+	pruneSeenMap(seen, now, ttlMs);
+	if (seen.has(key)) return true;
+	seen.set(key, now);
+	return false;
+}
+
+export function getGlobalSeenMap(storeKey: string): Map<string, number> {
+	const globalStore = globalThis as Record<string, unknown>;
+	const existing = globalStore[storeKey];
+	if (existing instanceof Map) return existing as Map<string, number>;
+	const map = new Map<string, number>();
+	globalStore[storeKey] = map;
+	return map;
+}

package/src/utils/file-coalescer.ts

@@ -1,84 +1,84 @@
-import * as fs from "node:fs";
-
-interface TimerApi {
-	setTimeout(handler: () => void, delayMs: number): unknown;
-	clearTimeout(handle: unknown): void;
-}
-
-const defaultTimerApi: TimerApi = {
-	setTimeout: (handler, delayMs) => setTimeout(handler, delayMs),
-	clearTimeout: (handle) => clearTimeout(handle as ReturnType<typeof setTimeout>),
-};
-
-export interface FileCoalescer {
-	schedule(file: string, delayMs?: number): boolean;
-	clear(): void;
-}
-
-export function createFileCoalescer(handler: (file: string) => void, defaultDelayMs: number, timerApi: TimerApi = defaultTimerApi): FileCoalescer {
-	const pending = new Map<string, unknown>();
-	return {
-		schedule(file, delayMs = defaultDelayMs) {
-			if (pending.has(file)) return false;
-			const timer = timerApi.setTimeout(() => {
-				pending.delete(file);
-				handler(file);
-			}, delayMs);
-			pending.set(file, timer);
-			return true;
-		},
-		clear() {
-			for (const timer of pending.values()) timerApi.clearTimeout(timer);
-			pending.clear();
-		},
-	};
-}
-
-interface ReadCacheEntry<T> {
-	value: T;
-	mtimeMs: number;
-	size: number;
-	expiresAt: number;
-}
-
-const readCache = new Map<string, ReadCacheEntry<unknown>>();
-const readCacheSizeLimit = 128;
-
-function evictOldestCacheEntry(): void {
-	if (readCache.size < readCacheSizeLimit) return;
-	const oldestKey = readCache.keys().next().value;
-	if (oldestKey !== undefined) {
-		readCache.delete(oldestKey);
-	}
-}
-
-export function clearReadCache(): void {
-	readCache.clear();
-}
-
-export function readJsonFileCoalesced<T>(filePath: string, ttlMs: number, read: () => T): T {
-	const now = Date.now();
-	const stat = (() => {
-		try {
-			const fileStat = fs.statSync(filePath);
-			return { mtimeMs: fileStat.mtimeMs, size: fileStat.size };
-		} catch {
-			return undefined;
-		}
-	})();
-	const cached = readCache.get(filePath);
-	if (cached && stat && cached.expiresAt > now && cached.mtimeMs === stat.mtimeMs && cached.size === stat.size) {
-		return cached.value as T;
-	}
-	const value = read();
-	if (stat !== undefined) {
-		readCache.set(filePath, {
-			value,
-			mtimeMs: stat.mtimeMs,
-			size: stat.size,
-			expiresAt: now + ttlMs,
-		});
-		evictOldestCacheEntry();
-	}
-	return value;
-}
+import * as fs from "node:fs";
+
+interface TimerApi {
+	setTimeout(handler: () => void, delayMs: number): unknown;
+	clearTimeout(handle: unknown): void;
+}
+
+const defaultTimerApi: TimerApi = {
+	setTimeout: (handler, delayMs) => setTimeout(handler, delayMs),
+	clearTimeout: (handle) => clearTimeout(handle as ReturnType<typeof setTimeout>),
+};
+
+export interface FileCoalescer {
+	schedule(file: string, delayMs?: number): boolean;
+	clear(): void;
+}
+
+export function createFileCoalescer(handler: (file: string) => void, defaultDelayMs: number, timerApi: TimerApi = defaultTimerApi): FileCoalescer {
+	const pending = new Map<string, unknown>();
+	return {
+		schedule(file, delayMs = defaultDelayMs) {
+			if (pending.has(file)) return false;
+			const timer = timerApi.setTimeout(() => {
+				pending.delete(file);
+				handler(file);
+			}, delayMs);
+			pending.set(file, timer);
+			return true;
+		},
+		clear() {
+			for (const timer of pending.values()) timerApi.clearTimeout(timer);
+			pending.clear();
+		},
+	};
+}
+
+interface ReadCacheEntry<T> {
+	value: T;
+	mtimeMs: number;
+	size: number;
+	expiresAt: number;
+}
+
+const readCache = new Map<string, ReadCacheEntry<unknown>>();
+const readCacheSizeLimit = 128;
+
+function evictOldestCacheEntry(): void {
+	if (readCache.size < readCacheSizeLimit) return;
+	const oldestKey = readCache.keys().next().value;
+	if (oldestKey !== undefined) {
+		readCache.delete(oldestKey);
+	}
+}
+
+export function clearReadCache(): void {
+	readCache.clear();
+}
+
+export function readJsonFileCoalesced<T>(filePath: string, ttlMs: number, read: () => T): T {
+	const now = Date.now();
+	const stat = (() => {
+		try {
+			const fileStat = fs.statSync(filePath);
+			return { mtimeMs: fileStat.mtimeMs, size: fileStat.size };
+		} catch {
+			return undefined;
+		}
+	})();
+	const cached = readCache.get(filePath);
+	if (cached && stat && cached.expiresAt > now && cached.mtimeMs === stat.mtimeMs && cached.size === stat.size) {
+		return cached.value as T;
+	}
+	const value = read();
+	if (stat !== undefined) {
+		readCache.set(filePath, {
+			value,
+			mtimeMs: stat.mtimeMs,
+			size: stat.size,
+			expiresAt: now + ttlMs,
+		});
+		evictOldestCacheEntry();
+	}
+	return value;
+}

package/src/utils/frontmatter.ts

@@ -1,36 +1,36 @@
-export interface ParsedFrontmatter {
-	frontmatter: Record<string, string>;
-	body: string;
-}
-
-export function parseFrontmatter(content: string): ParsedFrontmatter {
-	if (!content.startsWith("---\n") && !content.startsWith("---\r\n")) {
-		return { frontmatter: {}, body: content };
-	}
-
-	const normalized = content.replaceAll("\r\n", "\n");
-	const end = normalized.indexOf("\n---\n", 4);
-	if (end === -1) return { frontmatter: {}, body: content };
-
-	const raw = normalized.slice(4, end);
-	const body = normalized.slice(end + "\n---\n".length);
-	const frontmatter: Record<string, string> = {};
-
-	for (const line of raw.split("\n")) {
-		const trimmed = line.trim();
-		if (!trimmed || trimmed.startsWith("#")) continue;
-		const separator = trimmed.indexOf(":");
-		if (separator === -1) continue;
-		const key = trimmed.slice(0, separator).trim();
-		const value = trimmed.slice(separator + 1).trim();
-		if (key) frontmatter[key] = value;
-	}
-
-	return { frontmatter, body };
-}
-
-export function parseCsv(value: string | undefined): string[] | undefined {
-	if (value === undefined) return undefined;
-	const values = value.split(",").map((item) => item.trim()).filter(Boolean);
-	return values.length > 0 ? [...new Set(values)] : undefined;
-}
+export interface ParsedFrontmatter {
+	frontmatter: Record<string, string>;
+	body: string;
+}
+
+export function parseFrontmatter(content: string): ParsedFrontmatter {
+	if (!content.startsWith("---\n") && !content.startsWith("---\r\n")) {
+		return { frontmatter: {}, body: content };
+	}
+
+	const normalized = content.replaceAll("\r\n", "\n");
+	const end = normalized.indexOf("\n---\n", 4);
+	if (end === -1) return { frontmatter: {}, body: content };
+
+	const raw = normalized.slice(4, end);
+	const body = normalized.slice(end + "\n---\n".length);
+	const frontmatter: Record<string, string> = {};
+
+	for (const line of raw.split("\n")) {
+		const trimmed = line.trim();
+		if (!trimmed || trimmed.startsWith("#")) continue;
+		const separator = trimmed.indexOf(":");
+		if (separator === -1) continue;
+		const key = trimmed.slice(0, separator).trim();
+		const value = trimmed.slice(separator + 1).trim();
+		if (key) frontmatter[key] = value;
+	}
+
+	return { frontmatter, body };
+}
+
+export function parseCsv(value: string | undefined): string[] | undefined {
+	if (value === undefined) return undefined;
+	const values = value.split(",").map((item) => item.trim()).filter(Boolean);
+	return values.length > 0 ? [...new Set(values)] : undefined;
+}