pi-ask-popup 0.1.0 → 0.1.1

package/src/view/components/preview/preview-pane.ts

@@ -119,17 +119,25 @@ export class PreviewPane implements StatefulView<PreviewPaneProps>, Component {
   }
 
   render(width: number): string[] {
-    if (this.question.multiSelect === true) return this.optionListView.render(width);
+    if (this.question.multiSelect === true) {
+      return this.optionListView.render(width);
+    }
     // Spec: hide the preview pane entirely when no option carries a `preview`.
-    if (!this.previewBlock.hasAnyPreview()) return this.optionListView.render(width);
+    if (!this.previewBlock.hasAnyPreview()) {
+      return this.optionListView.render(width);
+    }
     // `inputMode` (typing on the "other" custom-answer row): the preview is irrelevant —
     // the row sits at index `options.length`, out of bounds for any option's preview — so
     // render the option list at the full pane width instead of the cramped left column.
     // Side-by-side + preview block resume verbatim on nav-away (inputMode clears).
-    if (this.props.inputMode) return this.optionListView.render(width);
+    if (this.props.inputMode) {
+      return this.optionListView.render(width);
+    }
 
     const mode = decideLayout(this.getTerminalWidth(), width);
-    if (mode === "side-by-side") return this.renderSideBySide(width, mode);
+    if (mode === "side-by-side") {
+      return this.renderSideBySide(width, mode);
+    }
 
     // Stacked: options + blank gap + preview block.
     return [
@@ -146,24 +154,38 @@ export class PreviewPane implements StatefulView<PreviewPaneProps>, Component {
   }
 
   focusedItemRowRange(width: number): [number, number] {
-    if (this.question.multiSelect === true) return this.optionListView.focusedItemRowRange(width);
-    if (!this.previewBlock.hasAnyPreview()) return this.optionListView.focusedItemRowRange(width);
+    if (this.question.multiSelect === true) {
+      return this.optionListView.focusedItemRowRange(width);
+    }
+    if (!this.previewBlock.hasAnyPreview()) {
+      return this.optionListView.focusedItemRowRange(width);
+    }
     // `inputMode`: compute the focused row range against the FULL pane width (not the
     // side-by-side leftWidth), mirroring `render`'s full-width option list.
-    if (this.props.inputMode) return this.optionListView.focusedItemRowRange(width);
+    if (this.props.inputMode) {
+      return this.optionListView.focusedItemRowRange(width);
+    }
     const mode = decideLayout(this.getTerminalWidth(), width);
-    if (mode === "stacked") return this.optionListView.focusedItemRowRange(width);
+    if (mode === "stacked") {
+      return this.optionListView.focusedItemRowRange(width);
+    }
     const adaptiveLeft = this.getAdaptiveLeft(width);
     const { leftWidth } = columnWidths(width, adaptiveLeft);
     return this.optionListView.focusedItemRowRange(leftWidth);
   }
 
   naturalHeight(width: number): number {
-    if (this.question.multiSelect === true) return this.optionListView.render(width).length;
-    if (!this.previewBlock.hasAnyPreview()) return this.optionListView.render(width).length;
+    if (this.question.multiSelect === true) {
+      return this.optionListView.render(width).length;
+    }
+    if (!this.previewBlock.hasAnyPreview()) {
+      return this.optionListView.render(width).length;
+    }
     // `inputMode`: height is the full-width option list only (no preview block) — preserves
     // the `naturalHeight === render.length` parity invariant.
-    if (this.props.inputMode) return this.optionListView.render(width).length;
+    if (this.props.inputMode) {
+      return this.optionListView.render(width).length;
+    }
     const mode = decideLayout(this.getTerminalWidth(), width);
     const adaptiveLeft = this.getAdaptiveLeft(width);
     const { optionsWidth, previewWidth } = bodyWidths(width, mode, adaptiveLeft);
@@ -173,16 +195,24 @@ export class PreviewPane implements StatefulView<PreviewPaneProps>, Component {
       this.props.selectedIndex,
       mode,
     );
-    if (mode === "side-by-side") return Math.max(optionsHeight, previewBlockHeight);
+    if (mode === "side-by-side") {
+      return Math.max(optionsHeight, previewBlockHeight);
+    }
     return optionsHeight + STACKED_GAP_ROWS + previewBlockHeight;
   }
 
   maxNaturalHeight(width: number): number {
-    if (this.question.multiSelect === true) return this.optionListView.render(width).length;
-    if (!this.previewBlock.hasAnyPreview()) return this.optionListView.render(width).length;
+    if (this.question.multiSelect === true) {
+      return this.optionListView.render(width).length;
+    }
+    if (!this.previewBlock.hasAnyPreview()) {
+      return this.optionListView.render(width).length;
+    }
     // `inputMode`: like naturalHeight — full-width option list only, so the
     // `maxNaturalHeight >= naturalHeight` parity invariant holds (both equal the list height).
-    if (this.props.inputMode) return this.optionListView.render(width).length;
+    if (this.props.inputMode) {
+      return this.optionListView.render(width).length;
+    }
     const mode = decideLayout(this.getTerminalWidth(), width);
     const adaptiveLeft = this.getAdaptiveLeft(width);
     const { optionsWidth, previewWidth } = bodyWidths(width, mode, adaptiveLeft);
@@ -190,9 +220,13 @@ export class PreviewPane implements StatefulView<PreviewPaneProps>, Component {
     let maxPreviewBlock = 0;
     for (let i = 0; i < this.question.options.length; i++) {
       const h = this.previewBlock.blockHeight(previewWidth, i, mode);
-      if (h > maxPreviewBlock) maxPreviewBlock = h;
+      if (h > maxPreviewBlock) {
+        maxPreviewBlock = h;
+      }
+    }
+    if (mode === "side-by-side") {
+      return Math.max(optionsHeight, maxPreviewBlock);
     }
-    if (mode === "side-by-side") return Math.max(optionsHeight, maxPreviewBlock);
     return optionsHeight + STACKED_GAP_ROWS + maxPreviewBlock;
   }
 
@@ -227,7 +261,9 @@ export class PreviewPane implements StatefulView<PreviewPaneProps>, Component {
     const boxWidth = Math.max(1, visibleWidth(contentLines[0] ?? ""));
     const boxAlignedPad = Math.max(PREVIEW_PADDING_LEFT, colWidth - boxWidth);
     return contentLines.map((line) => {
-      if (line === "") return "";
+      if (line === "") {
+        return "";
+      }
       // A line wider than the box (a long-locale notes affordance) slides left to
       // stay fully visible; truncation engages only when the column itself runs out.
       const pad = Math.max(

package/src/view/components/wrapping-select.ts

@@ -130,7 +130,9 @@ export class WrappingSelect implements Component {
   invalidate(): void {}
 
   render(width: number): string[] {
-    if (this.items.length === 0) return [];
+    if (this.items.length === 0) {
+      return [];
+    }
 
     const { startIndex, endIndex } = this.computeVisibleWindow();
     const numberWidth = String(Math.max(1, this.totalItemsForNumbering)).length;
@@ -138,7 +140,9 @@ export class WrappingSelect implements Component {
 
     for (let i = startIndex; i < endIndex; i++) {
       const item = this.items[i];
-      if (!item) continue;
+      if (!item) {
+        continue;
+      }
       const isActive = i === this.selectedIndex && this.focused;
       lines.push(...this.renderItem(item, i, isActive, width, numberWidth));
     }
@@ -155,13 +159,17 @@ export class WrappingSelect implements Component {
    * summing per-item row counts — O(maxVisible) per call.
    */
   focusedItemRowRange(width: number): [number, number] {
-    if (this.items.length === 0) return [0, 0];
+    if (this.items.length === 0) {
+      return [0, 0];
+    }
     const { startIndex, endIndex } = this.computeVisibleWindow();
     const numberWidth = String(Math.max(1, this.totalItemsForNumbering)).length;
     let row = 0;
     for (let i = startIndex; i < endIndex; i++) {
       const item = this.items[i];
-      if (!item) continue;
+      if (!item) {
+        continue;
+      }
       const isActive = i === this.selectedIndex && this.focused;
       const itemRowCount = this.computeItemRowCount(item, i, isActive, width, numberWidth);
       if (i === this.selectedIndex) {
@@ -306,7 +314,9 @@ export class WrappingSelect implements Component {
     continuationPrefix: string,
     contentWidth: number,
   ): string[] {
-    if (!description) return [];
+    if (!description) {
+      return [];
+    }
     const wrapped = wrapTextWithAnsi(description, contentWidth);
     return wrapped.map((segment) => `${continuationPrefix}${this.theme.description(segment)}`);
   }

package/src/view/dialog-builder.ts

@@ -103,7 +103,9 @@ function computeScrollStart(
   availableMiddle: number,
   middleRows: number,
 ): number {
-  if (!bodyRange) return 0;
+  if (!bodyRange) {
+    return 0;
+  }
   const focusedRowInMiddle = headingCount + bodyRange[0];
   const focusedHeight = bodyRange[1] - bodyRange[0];
   const idealStart =
@@ -122,13 +124,19 @@ function decorateOverflow(
   hasDown: boolean,
   theme: Theme,
 ): void {
-  if (scrollableMiddle.length === 0) return;
+  if (scrollableMiddle.length === 0) {
+    return;
+  }
   if (hasUp && hasDown && scrollableMiddle.length === 1) {
     scrollableMiddle[0] = theme.fg("dim", OVERFLOW_BOTH);
     return;
   }
-  if (hasUp) scrollableMiddle[0] = theme.fg("dim", OVERFLOW_UP);
-  if (hasDown) scrollableMiddle[scrollableMiddle.length - 1] = theme.fg("dim", OVERFLOW_DOWN);
+  if (hasUp) {
+    scrollableMiddle[0] = theme.fg("dim", OVERFLOW_UP);
+  }
+  if (hasDown) {
+    scrollableMiddle[scrollableMiddle.length - 1] = theme.fg("dim", OVERFLOW_DOWN);
+  }
 }
 
 export type DialogState = QuestionnaireState;
@@ -307,16 +315,24 @@ export class DialogView implements StatefulView<DialogProps> {
     const border = () => new DynamicBorder((s) => theme.fg("accent", s));
 
     container.addChild(border());
-    if (isMulti && tabBar) container.addChild(tabBar);
+    if (isMulti && tabBar) {
+      container.addChild(tabBar);
+    }
     container.addChild(new Spacer(1));
 
-    for (const c of headingRowCache) container.addChild(c);
+    for (const c of headingRowCache) {
+      container.addChild(c);
+    }
     container.addChild(strategy.bodyComponent(state));
     container.addChild(new Spacer(1));
-    for (const c of strategy.midRows(state)) container.addChild(c);
+    for (const c of strategy.midRows(state)) {
+      container.addChild(c);
+    }
 
     container.addChild(border());
-    for (const c of strategy.footerRows(state)) container.addChild(c);
+    for (const c of strategy.footerRows(state)) {
+      container.addChild(c);
+    }
 
     // The residual spacer lives in render(), not here: whether it applies
     // depends on overflow, which the container cannot see.

package/src/view/props-adapter.ts

@@ -22,7 +22,9 @@ function getInputCursorOffset(input: Editor): number {
   const lines = input.getLines();
   const cursor = input.getCursor();
   let offset = cursor.col;
-  for (let i = 0; i < cursor.line; i++) offset += (lines[i]?.length ?? 0) + 1;
+  for (let i = 0; i < cursor.line; i++) {
+    offset += (lines[i]?.length ?? 0) + 1;
+  }
   return offset;
 }
 
@@ -82,7 +84,9 @@ export class QuestionnairePropsAdapter {
     // so there is always a tab. Skipping the tick beats asserting non-null and
     // throwing out of a render path if that ever stops being true.
     const activePreviewPane = this.tabsByIndex[paneIndex]?.preview ?? firstTab?.preview;
-    if (!activePreviewPane) return;
+    if (!activePreviewPane) {
+      return;
+    }
 
     const ctx: BindingContext = {
       questions: this.questions,
@@ -94,13 +98,19 @@ export class QuestionnairePropsAdapter {
       activePreviewPane,
     };
 
-    for (const binding of this.globalBindings) binding.apply(state, ctx);
+    for (const binding of this.globalBindings) {
+      binding.apply(state, ctx);
+    }
 
     for (let i = 0; i < this.tabsByIndex.length; i++) {
       const tab = this.tabsByIndex[i];
-      if (!tab) continue;
+      if (!tab) {
+        continue;
+      }
       const tabCtx: PerTabBindingContext = { ...ctx, tab, i };
-      for (const binding of this.perTabBindings) binding.apply(state, tabCtx);
+      for (const binding of this.perTabBindings) {
+        binding.apply(state, tabCtx);
+      }
     }
 
     this.tui.requestRender();
@@ -113,12 +123,16 @@ export class QuestionnairePropsAdapter {
    * refresh them. Walks the same registries `apply()` does, then the extras.
    */
   invalidate(): void {
-    for (const b of this.globalBindings) b.invalidate();
+    for (const b of this.globalBindings) {
+      b.invalidate();
+    }
     for (const tab of this.tabsByIndex) {
       tab.optionList.invalidate();
       tab.preview.invalidate();
       tab.multiSelect?.invalidate();
     }
-    for (const x of this.extraInvalidatables) x.invalidate();
+    for (const x of this.extraInvalidatables) {
+      x.invalidate();
+    }
   }
 }

package/src/view/tab-content-strategy.ts

@@ -152,7 +152,9 @@ export class QuestionTabStrategy implements TabContentStrategy {
   bodyComponent(state: DialogState): Component {
     const question = this.config.questions[state.currentTab];
     const multiSelect = this.config.tabsByIndex[state.currentTab]?.multiSelect;
-    if (question?.multiSelect === true && multiSelect) return multiSelect;
+    if (question?.multiSelect === true && multiSelect) {
+      return multiSelect;
+    }
     return this.config.getPreviewPane();
   }
 
@@ -161,7 +163,9 @@ export class QuestionTabStrategy implements TabContentStrategy {
   }
 
   midRows(state: DialogState): Component[] {
-    if (!state.notesVisible) return this.restingNoteRows(state);
+    if (!state.notesVisible) {
+      return this.restingNoteRows(state);
+    }
     return [
       new Text(this.config.theme.fg("muted", NOTES_HEADER), 1, 0),
       this.config.notesInput,
@@ -190,9 +194,13 @@ export class QuestionTabStrategy implements TabContentStrategy {
    * put noise on every un-noted tab of every questionnaire.
    */
   restingNoteRows(state: DialogState): Component[] {
-    if (this.restingNoteRowCount(state) === 0) return [];
+    if (this.restingNoteRowCount(state) === 0) {
+      return [];
+    }
     const note = noteForTab(state, state.currentTab);
-    if (note.length === 0) return [new Spacer(1)];
+    if (note.length === 0) {
+      return [new Spacer(1)];
+    }
     return [
       new OneLineClippedText(
         this.config.theme.fg("dim", `${NOTES_LABEL} ${collapseToOneLine(note)}`),
@@ -213,9 +221,13 @@ export class QuestionTabStrategy implements TabContentStrategy {
    * then, and its own height is the intentional expansion.
    */
   restingNoteRowCount(state: DialogState): number {
-    if (state.notesVisible) return 0;
+    if (state.notesVisible) {
+      return 0;
+    }
     for (let i = 0; i < this.config.questions.length; i++) {
-      if (noteForTab(state, i).length > 0) return 1;
+      if (noteForTab(state, i).length > 0) {
+        return 1;
+      }
     }
     return 0;
   }
@@ -273,13 +285,17 @@ export class SubmitTabStrategy implements TabContentStrategy {
     const c = new Container();
     for (let i = 0; i < this.config.questions.length; i++) {
       const q = this.config.questions[i];
-      if (!q) continue;
+      if (!q) {
+        continue;
+      }
       const a = state.answers.get(i);
       const note = noteForTab(state, i);
       // A note with no answer still gets an entry. Skipping it, which is what
       // this loop used to do, dropped the note from the review and from the
       // result: the user wrote something and was never told it went nowhere.
-      if (!a && note.length === 0) continue;
+      if (!a && note.length === 0) {
+        continue;
+      }
       c.addChild(new Text(this.config.theme.fg("muted", ` ● ${tabLabel(q.header, i)}`), 1, 0));
       // No arrow row when there is no answer. The absent row is the signal, and
       // the footer already names the question in its incomplete warning, so
@@ -326,7 +342,9 @@ export class SubmitTabStrategy implements TabContentStrategy {
   midRows(state: DialogState): Component[] {
     // The question tabs' notes editor, mirrored for the global note. The draft
     // itself is reducer-owned; this only renders it.
-    if (!state.notesVisible) return [];
+    if (!state.notesVisible) {
+      return [];
+    }
     return [
       new Text(this.config.theme.fg("muted", GLOBAL_NOTES_HEADER), 1, 0),
       this.config.notesInput,
@@ -338,7 +356,9 @@ export class SubmitTabStrategy implements TabContentStrategy {
     const missing: string[] = [];
     for (let i = 0; i < this.config.questions.length; i++) {
       const q = this.config.questions[i];
-      if (q && !state.answers.has(i)) missing.push(tabLabel(q.header, i));
+      if (q && !state.answers.has(i)) {
+        missing.push(tabLabel(q.header, i));
+      }
     }
     const promptText =
       missing.length === 0
@@ -380,9 +400,13 @@ export class SubmitTabStrategy implements TabContentStrategy {
 }
 
 function remainingLabel(state: DialogState): string | undefined {
-  if (state.timerCancelled) return undefined;
+  if (state.timerCancelled) {
+    return undefined;
+  }
   const ms = state.remainingMs;
-  if (ms === undefined) return undefined;
+  if (ms === undefined) {
+    return undefined;
+  }
   const secs = Math.max(0, Math.ceil(ms / 1000));
   return `${secs}s left`;
 }
@@ -408,7 +432,9 @@ export function buildHintText(
   collapseKey: string,
 ): string {
   const parts: string[] = [HINT_PART_ENTER, HINT_PART_NAV];
-  if (question?.multiSelect === true) parts.push(HINT_PART_TOGGLE);
+  if (question?.multiSelect === true) {
+    parts.push(HINT_PART_TOGGLE);
+  }
   if (question && !state.notesVisible && !state.inputMode) {
     // "add" is wrong once one exists, and the hint is the only affordance
     // telling a keyboard user the resting row can be reopened at all.
@@ -416,17 +442,25 @@ export function buildHintText(
       noteForTab(state, state.currentTab).length > 0 ? HINT_PART_NOTES_EDIT : HINT_PART_NOTES,
     );
   }
-  if (isMulti) parts.push(HINT_PART_TAB);
+  if (isMulti) {
+    parts.push(HINT_PART_TAB);
+  }
   parts.push(HINT_PART_CANCEL);
   if (collapseKey !== COLLAPSE_KEY_OFF) {
     parts.push(
       HINT_PART_COLLAPSE_TEMPLATE.replace(KEY_PLACEHOLDER, formatKeySpecForDisplay(collapseKey)),
     );
   }
-  if (state.notesVisible || state.inputMode) parts.push(HINT_PART_NEW_LINE);
-  if (state.inputMode) parts.push(HINT_PART_CLEAR);
+  if (state.notesVisible || state.inputMode) {
+    parts.push(HINT_PART_NEW_LINE);
+  }
+  if (state.inputMode) {
+    parts.push(HINT_PART_CLEAR);
+  }
   const rem = remainingLabel(state);
-  if (rem) parts.push(rem);
+  if (rem) {
+    parts.push(rem);
+  }
   return parts.join(" · ");
 }
 
@@ -438,10 +472,16 @@ export function buildHintText(
  */
 export function buildSubmitHintText(state: DialogState): string {
   const parts: string[] = [HINT_PART_ENTER, HINT_PART_NAV];
-  if (!state.notesVisible) parts.push(REVIEW_GLOBAL_HINT);
+  if (!state.notesVisible) {
+    parts.push(REVIEW_GLOBAL_HINT);
+  }
   parts.push(HINT_PART_CANCEL);
-  if (state.notesVisible) parts.push(HINT_PART_NEW_LINE);
+  if (state.notesVisible) {
+    parts.push(HINT_PART_NEW_LINE);
+  }
   const rem = remainingLabel(state);
-  if (rem) parts.push(rem);
+  if (rem) {
+    parts.push(rem);
+  }
   return parts.join(" · ");
 }