pi-ask-popup 0.1.0 → 0.1.1

package/src/state/key-router.ts

@@ -2,6 +2,13 @@ import { Key, matchesKey } from "@earendil-works/pi-tui";
 import type { QuestionAnswer } from "../tool/types.js";
 import { ROW_INTENT_META } from "./row-intent.js";
 import type { QuestionnaireRuntime, QuestionnaireState } from "./state.js";
+type JsonValue =
+  | string
+  | number
+  | boolean
+  | null
+  | JsonValue[]
+  | { readonly [key: string]: JsonValue };
 
 const KEYBIND_UP = "tui.select.up";
 const KEYBIND_DOWN = "tui.select.down";
@@ -59,14 +66,20 @@ function isConfirm(kb: QuestionnaireKeybindings, data: string): boolean {
 }
 
 export function wrapTab(index: number, total: number): number {
-  if (total <= 0) return 0;
+  if (total <= 0) {
+    return 0;
+  }
   return ((index % total) + total) % total;
 }
 
 export function allAnswered(state: QuestionnaireState, runtime: QuestionnaireRuntime): boolean {
-  if (runtime.questions.length === 0) return false;
+  if (runtime.questions.length === 0) {
+    return false;
+  }
   for (let i = 0; i < runtime.questions.length; i++) {
-    if (!state.answers.has(i)) return false;
+    if (!state.answers.has(i)) {
+      return false;
+    }
   }
   return true;
 }
@@ -79,8 +92,12 @@ function computeAutoAdvanceTab(
   state: QuestionnaireState,
   runtime: QuestionnaireRuntime,
 ): number | undefined {
-  if (!runtime.isMulti) return undefined;
-  if (state.currentTab < runtime.questions.length - 1) return state.currentTab + 1;
+  if (!runtime.isMulti) {
+    return undefined;
+  }
+  if (state.currentTab < runtime.questions.length - 1) {
+    return state.currentTab + 1;
+  }
   return runtime.questions.length;
 }
 
@@ -89,7 +106,9 @@ function buildSingleSelectAnswer(
   runtime: QuestionnaireRuntime,
 ): QuestionAnswer | null {
   const q = runtime.questions[state.currentTab];
-  if (!q) return null;
+  if (!q) {
+    return null;
+  }
 
   const item = runtime.currentItem;
 
@@ -102,7 +121,9 @@ function buildSingleSelectAnswer(
       answer: label.length > 0 ? label : null,
     };
   }
-  if (!item) return null;
+  if (!item) {
+    return null;
+  }
   if (item.kind === "other") {
     return null;
   }
@@ -117,14 +138,22 @@ function buildSingleSelectAnswer(
   };
 }
 
+function isString(value: JsonValue | undefined): value is string {
+  return typeof value === "string";
+}
+
 function buildMultiSelected(state: QuestionnaireState, runtime: QuestionnaireRuntime): string[] {
   const q = runtime.questions[state.currentTab];
-  if (!q) return [];
+  if (!q) {
+    return [];
+  }
   const out: string[] = [];
   for (let i = 0; i < q.options.length; i++) {
     if (state.multiSelectChecked.has(i)) {
       const label = q.options[i]?.label;
-      if (typeof label === "string") out.push(label);
+      if (isString(label)) {
+        out.push(label);
+      }
     }
   }
   return out;
@@ -135,7 +164,9 @@ function tabSwitchAction(
   state: QuestionnaireState,
   runtime: QuestionnaireRuntime,
 ): QuestionnaireAction | null {
-  if (!runtime.isMulti) return null;
+  if (!runtime.isMulti) {
+    return null;
+  }
   const total = totalTabs(runtime);
   if (matchesKey(data, Key.tab) || matchesKey(data, Key.right)) {
     return { kind: "tab_switch", nextTab: wrapTab(state.currentTab + 1, total) };
@@ -174,14 +205,22 @@ function prevNavOnUp(
 // the user can read the now-uncovered transcript without accidentally mutating
 // answers or notes. The collapse toggle itself is already handled above.
 function routeCollapsed(kb: QuestionnaireKeybindings, data: string): QuestionnaireAction {
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "cancel" };
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "cancel" };
+  }
   return { kind: "ignore" };
 }
 
 function routeNotesMode(kb: QuestionnaireKeybindings, data: string): QuestionnaireAction {
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "notes_exit" };
-  if (kb.matches(data, KEYBIND_NEW_LINE)) return { kind: "notes_forward", data };
-  if (isConfirm(kb, data)) return { kind: "notes_exit" };
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "notes_exit" };
+  }
+  if (kb.matches(data, KEYBIND_NEW_LINE)) {
+    return { kind: "notes_forward", data };
+  }
+  if (isConfirm(kb, data)) {
+    return { kind: "notes_exit" };
+  }
   return { kind: "notes_forward", data };
 }
 
@@ -193,22 +232,39 @@ function routeInputMode(
 ): QuestionnaireAction {
   // Newline takes precedence over confirmation if a user configuration binds
   // the same physical key to both semantic actions.
-  if (kb.matches(data, KEYBIND_NEW_LINE)) return { kind: "ignore" };
+  if (kb.matches(data, KEYBIND_NEW_LINE)) {
+    return { kind: "ignore" };
+  }
   if (isConfirm(kb, data)) {
     const answer = buildSingleSelectAnswer(state, runtime);
-    if (!answer) return { kind: "ignore" };
+    if (!answer) {
+      return { kind: "ignore" };
+    }
     return { kind: "confirm", answer, autoAdvanceTab: computeAutoAdvanceTab(state, runtime) };
   }
   // Treat Pi's Ctrl+U line-kill binding as an explicit whole-draft clear,
   // independent of the current cursor position.
-  if (kb.matches(data, KEYBIND_CLEAR)) return { kind: "input_clear" };
-  if (kb.matches(data, KEYBIND_EXTERNAL_EDITOR))
+  if (kb.matches(data, KEYBIND_CLEAR)) {
+    return { kind: "input_clear" };
+  }
+  if (kb.matches(data, KEYBIND_EXTERNAL_EDITOR)) {
     return { kind: "input_edit", value: runtime.inputBuffer };
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "cancel" };
-  if (kb.matches(data, KEYBIND_EDITOR_UP) && runtime.canMoveInputUp) return { kind: "ignore" };
-  if (kb.matches(data, KEYBIND_EDITOR_DOWN) && runtime.canMoveInputDown) return { kind: "ignore" };
-  if (kb.matches(data, KEYBIND_UP)) return prevNavOnUp(state, runtime);
-  if (kb.matches(data, KEYBIND_DOWN)) return nextNavOnDown(state, runtime);
+  }
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "cancel" };
+  }
+  if (kb.matches(data, KEYBIND_EDITOR_UP) && runtime.canMoveInputUp) {
+    return { kind: "ignore" };
+  }
+  if (kb.matches(data, KEYBIND_EDITOR_DOWN) && runtime.canMoveInputDown) {
+    return { kind: "ignore" };
+  }
+  if (kb.matches(data, KEYBIND_UP)) {
+    return prevNavOnUp(state, runtime);
+  }
+  if (kb.matches(data, KEYBIND_DOWN)) {
+    return nextNavOnDown(state, runtime);
+  }
   return { kind: "ignore" };
 }
 
@@ -218,12 +274,17 @@ function routeSubmitTab(
   state: QuestionnaireState,
   runtime: QuestionnaireRuntime,
 ): QuestionnaireAction {
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "cancel" };
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "cancel" };
+  }
   const tab = tabSwitchAction(data, state, runtime);
-  if (tab) return tab;
+  if (tab) {
+    return tab;
+  }
   if (kb.matches(data, KEYBIND_UP) || kb.matches(data, KEYBIND_DOWN)) {
     const delta = kb.matches(data, KEYBIND_DOWN) ? 1 : -1;
     const next = wrapTab(state.submitChoiceIndex + delta, 2);
+    // SAFETY: safe cast — value is validated at boundary or test fixture with known shape.
     return { kind: "submit_nav", nextIndex: (next === 1 ? 1 : 0) as 0 | 1 };
   }
   if (isConfirm(kb, data)) {
@@ -257,20 +318,28 @@ function routeMultiSelectTab(
   // `blocksMultiToggle` (the Next sentinel) or `activatesInputMode` (the "Type
   // something." row — it is an inline input, not a checkable option).
   if (data === SPACE_KEY) {
-    if (focusedMeta?.blocksMultiToggle) return { kind: "ignore" };
-    if (focusedMeta?.activatesInputMode) return { kind: "ignore" };
+    if (focusedMeta?.blocksMultiToggle) {
+      return { kind: "ignore" };
+    }
+    if (focusedMeta?.activatesInputMode) {
+      return { kind: "ignore" };
+    }
     return { kind: "toggle", index: state.optionIndex };
   }
   if (isConfirm(kb, data)) {
     // Enter on the "Type something." row is handled by the inputMode block above
     // (→ confirm kind:"custom"). Defensive: never enter the toggle/multi_confirm
     // path for an inputMode-activating row.
-    if (focusedMeta?.activatesInputMode) return { kind: "ignore" };
+    if (focusedMeta?.activatesInputMode) {
+      return { kind: "ignore" };
+    }
     // Enter on a regular row toggles (matching Space) — committing the question is now
     // gated behind explicit focus on a row whose META declares `autoSubmitsInMulti`
     // (the Next sentinel), so Enter on options is a no-cost way to flip checkboxes
     // without leaving the keyboard home row.
-    if (!focusedMeta?.autoSubmitsInMulti) return { kind: "toggle", index: state.optionIndex };
+    if (!focusedMeta?.autoSubmitsInMulti) {
+      return { kind: "toggle", index: state.optionIndex };
+    }
     // Enter on Next: carry autoAdvanceTab so the host can advance to the next tab in
     // multi-question mode, OR submit the dialog in single-question mode
     // (autoAdvanceTab === undefined when !isMulti). Without this, a single multi-select
@@ -281,7 +350,9 @@ function routeMultiSelectTab(
       autoAdvanceTab: computeAutoAdvanceTab(state, runtime),
     };
   }
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "cancel" };
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "cancel" };
+  }
   return { kind: "ignore" };
 }
 
@@ -293,10 +364,14 @@ function routeSingleSelectTab(
 ): QuestionnaireAction {
   if (isConfirm(kb, data)) {
     const answer = buildSingleSelectAnswer(state, runtime);
-    if (!answer) return { kind: "ignore" };
+    if (!answer) {
+      return { kind: "ignore" };
+    }
     return { kind: "confirm", answer, autoAdvanceTab: computeAutoAdvanceTab(state, runtime) };
   }
-  if (kb.matches(data, KEYBIND_CANCEL)) return { kind: "cancel" };
+  if (kb.matches(data, KEYBIND_CANCEL)) {
+    return { kind: "cancel" };
+  }
   return { kind: "ignore" };
 }
 
@@ -329,28 +404,39 @@ export function routeKey(
   // undefined into matchesKey reaches parseKeyId().toLowerCase() and crashes the
   // entire host process, so keep the runtime boundary defensive even though the
   // TypeScript contract requires a string. The "off" literal is deliberate:
-  // importing COLLAPSE_KEY_OFF would pull ../config.js (and its rpiv-config
-  // loader graph) into this pure module for a string that cannot change.
+  // importing COLLAPSE_KEY_OFF would pull ../config.js (and its config loader
+  // graph) into this pure module for a string that cannot change.
   if (
-    typeof runtime.collapseKey === "string" &&
+    isString(runtime.collapseKey) &&
     runtime.collapseKey !== "off" &&
+    // SAFETY: safe cast — value is validated at boundary or test fixture with known shape.
     matchesKey(data, runtime.collapseKey as Parameters<typeof matchesKey>[1])
   ) {
     return { kind: "toggle_collapsed" };
   }
 
-  if (state.collapsed) return routeCollapsed(kb, data);
-  if (state.notesVisible) return routeNotesMode(kb, data);
-  if (state.inputMode) return routeInputMode(kb, data, state, runtime);
+  if (state.collapsed) {
+    return routeCollapsed(kb, data);
+  }
+  if (state.notesVisible) {
+    return routeNotesMode(kb, data);
+  }
+  if (state.inputMode) {
+    return routeInputMode(kb, data, state, runtime);
+  }
   if (runtime.isMulti && state.currentTab === runtime.questions.length) {
     return routeSubmitTab(kb, data, state, runtime);
   }
 
   const tab = tabSwitchAction(data, state, runtime);
-  if (tab) return tab;
+  if (tab) {
+    return tab;
+  }
 
   const q = runtime.questions[state.currentTab];
-  if (!q) return { kind: "ignore" };
+  if (!q) {
+    return { kind: "ignore" };
+  }
 
   // Universal `n` activation (FR-1): the notes editor opens on every question tab
   // (single- or multi-select, preview or no-preview). The blocks above already
@@ -373,6 +459,8 @@ export function routeKey(
     return nextNavOnDown(state, runtime);
   }
 
-  if (q.multiSelect) return routeMultiSelectTab(kb, data, state, runtime);
+  if (q.multiSelect) {
+    return routeMultiSelectTab(kb, data, state, runtime);
+  }
   return routeSingleSelectTab(kb, data, state, runtime);
 }

package/src/state/questionnaire-session.ts

@@ -152,7 +152,9 @@ export class QuestionnaireSession {
 
     this.component = this.assembleComponent(built, config.theme);
     this.viewAdapter.apply(this.state);
-    if (this.state.deadline !== undefined) this.startTimer();
+    if (this.state.deadline !== undefined) {
+      this.startTimer();
+    }
   }
 
   private assembleComponent(
@@ -180,15 +182,17 @@ export class QuestionnaireSession {
    * falls back to cancel-only rather than telling the user to press "Off".
    */
   private startTimer(): void {
-    if (this.timer !== undefined) return;
+    if (this.timer !== undefined) {
+      return;
+    }
     this.timer = setInterval(() => {
       this.commit({ kind: "tick", now: Date.now() });
     }, 1000);
     // Don't keep the process alive after Pi exits.
     // SAFETY: Node's Timeout has unref, DOM/Bun number does not; guard ensures we only call when present.
-    if (typeof (this.timer as unknown as { unref?: () => void }).unref === "function") {
+    if (typeof (this.timer as { unref?: () => void }).unref === "function") {
       // SAFETY: same guard as above — only called when unref is a function.
-      (this.timer as unknown as { unref: () => void }).unref();
+      (this.timer as { unref: () => void }).unref();
     }
   }
 
@@ -200,9 +204,13 @@ export class QuestionnaireSession {
   }
 
   private formatRemaining(): string | undefined {
-    if (this.state.timerCancelled) return undefined;
+    if (this.state.timerCancelled) {
+      return undefined;
+    }
     const ms = this.state.remainingMs;
-    if (ms === undefined) return undefined;
+    if (ms === undefined) {
+      return undefined;
+    }
     const secs = Math.max(0, Math.ceil(ms / 1000));
     return `${secs}s`;
   }
@@ -221,7 +229,9 @@ export class QuestionnaireSession {
   }
 
   dispatch(data: string): void {
-    if (this.inputEditorOpen) return;
+    if (this.inputEditorOpen) {
+      return;
+    }
     const action = routeKey(data, this.state, this.runtime());
     if (action.kind === "ignore") {
       this.handleIgnoreInline(data);
@@ -233,7 +243,9 @@ export class QuestionnaireSession {
   private commit(action: QuestionnaireAction): void {
     const result = reduce(this.state, action, this.applyContext());
     this.state = result.state;
-    for (const effect of result.effects) this.runEffect(effect);
+    for (const effect of result.effects) {
+      this.runEffect(effect);
+    }
     this.state = this.mirrorNotesDraft(this.state);
     this.viewAdapter.apply(this.state);
   }
@@ -274,7 +286,9 @@ export class QuestionnaireSession {
         // A no-op until the handle arrives, and suppressed entirely without a
         // raw terminal listener: see `canReopenWhileHidden`. The state still
         // says collapsed either way, so the view renders the one-line row.
-        if (this.canReopenWhileHidden) this.overlayHandle?.setHidden(effect.hidden);
+        if (this.canReopenWhileHidden) {
+          this.overlayHandle?.setHidden(effect.hidden);
+        }
         return;
       case "clear_timer":
         this.clearTimer();
@@ -294,12 +308,16 @@ export class QuestionnaireSession {
    * nothing.
    */
   private openInputEditorAsync(value: string): void {
-    if (this.inputEditorOpen) return;
+    if (this.inputEditorOpen) {
+      return;
+    }
     this.inputEditorOpen = true;
     void this.editInput(value).then(
       (edited) => {
         this.inputEditorOpen = false;
-        if (edited !== undefined) this.commit({ kind: "input_replace", value: edited });
+        if (edited !== undefined) {
+          this.commit({ kind: "input_replace", value: edited });
+        }
       },
       () => {
         this.inputEditorOpen = false;
@@ -326,7 +344,9 @@ export class QuestionnaireSession {
       timerWasCancelled = true;
     }
     if (!this.state.inputMode) {
-      if (timerWasCancelled) this.viewAdapter.apply(this.state);
+      if (timerWasCancelled) {
+        this.viewAdapter.apply(this.state);
+      }
       return;
     }
     this.inlineInput.handleInput(data);
@@ -377,6 +397,8 @@ export class QuestionnaireSession {
    * else.
    */
   toggleCollapsedExternal(): void {
-    if (!this.inputEditorOpen) this.commit({ kind: "toggle_collapsed" });
+    if (!this.inputEditorOpen) {
+      this.commit({ kind: "toggle_collapsed" });
+    }
   }
 }

package/src/state/row-intent.ts

@@ -147,10 +147,14 @@ export function sentinelsToAppend(question: QuestionData): SentinelKind[] {
   const out: SentinelKind[] = [];
   for (const kind of SENTINEL_KINDS) {
     const meta = ROW_INTENT_META[kind];
-    if (!meta.livesInMainList) continue;
+    if (!meta.livesInMainList) {
+      continue;
+    }
     const appends =
       question.multiSelect === true ? meta.autoAppendOnMultiSelect : meta.autoAppendOnSingleSelect;
-    if (appends) out.push(kind);
+    if (appends) {
+      out.push(kind);
+    }
   }
   return out;
 }

package/src/state/selectors/derivations.ts

@@ -15,17 +15,27 @@ export function selectConfirmedIndicator(
   items: readonly WrappingSelectItem[],
 ): { index: number; labelOverride?: string } | undefined {
   const q = questions[currentTab];
-  if (!q || q.multiSelect === true) return undefined;
+  if (!q || q.multiSelect === true) {
+    return undefined;
+  }
   const prior = answers.get(currentTab);
-  if (!prior) return undefined;
+  if (!prior) {
+    return undefined;
+  }
   if (prior.kind === "custom") {
     const otherIndex = items.findIndex((it) => it.kind === "other");
-    if (otherIndex < 0) return undefined;
+    if (otherIndex < 0) {
+      return undefined;
+    }
     return { index: otherIndex, labelOverride: prior.answer ?? "" };
   }
-  if (prior.kind !== "option" || typeof prior.answer !== "string") return undefined;
+  if (prior.kind !== "option" || typeof prior.answer !== "string") {
+    return undefined;
+  }
   const index = items.findIndex((it) => it.kind === "option" && it.label === prior.answer);
-  if (index < 0) return undefined;
+  if (index < 0) {
+    return undefined;
+  }
   return { index };
 }
 
@@ -35,6 +45,8 @@ export function selectConfirmedIndicator(
  * machinery picks the right body component independently. Defensive against `totalQuestions === 0`.
  */
 export function selectActivePreviewPaneIndex(currentTab: number, totalQuestions: number): number {
-  if (totalQuestions <= 0) return 0;
+  if (totalQuestions <= 0) {
+    return 0;
+  }
   return Math.min(currentTab, totalQuestions - 1);
 }

package/src/state/selectors/focus.ts

@@ -11,7 +11,11 @@ export function selectActiveView(
   state: { notesVisible: boolean; currentTab: number },
   totalQuestions: number,
 ): ActiveView {
-  if (state.notesVisible) return "notes";
-  if (state.currentTab === totalQuestions) return "submit";
+  if (state.notesVisible) {
+    return "notes";
+  }
+  if (state.currentTab === totalQuestions) {
+    return "submit";
+  }
   return "options";
 }

package/src/state/selectors/projections.ts

@@ -44,7 +44,9 @@ function nextLabelFor(ctx: PerTabBindingContext): string {
 
 export const selectMultiSelectProps: PerTabSelector<MultiSelectViewProps> = (state, ctx) => {
   const question = ctx.questions[ctx.i];
-  if (!question) return emptyMultiSelectProps(ctx);
+  if (!question) {
+    return emptyMultiSelectProps(ctx);
+  }
   const focused = ctx.activeView === "options";
   const rows = question.options.map((_option, i) => ({
     checked: state.multiSelectChecked.has(i),