peaks-loop 4.1.4 → 4.1.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/marketplace.json +7 -2
- package/CHANGELOG.md +148 -0
- package/README-en.md +47 -183
- package/README.md +24 -188
- package/dist/cli/cli-helpers.d.ts +20 -0
- package/dist/cli/cli-helpers.js +34 -0
- package/dist/cli/commands/_register.js +2 -0
- package/dist/cli/commands/best-practice-scan-command.d.ts +11 -6
- package/dist/cli/commands/best-practice-scan-command.js +35 -20
- package/dist/cli/commands/best-practice-scan-helpers.d.ts +47 -0
- package/dist/cli/commands/best-practice-scan-helpers.js +88 -5
- package/dist/cli/commands/best-practice-scan-lookup-results.d.ts +13 -0
- package/dist/cli/commands/best-practice-scan-lookup-results.js +237 -0
- package/dist/cli/commands/code-commands.d.ts +6 -4
- package/dist/cli/commands/code-commands.js +6 -4
- package/dist/cli/commands/code-gate-command.d.ts +5 -5
- package/dist/cli/commands/code-gate-command.js +49 -9
- package/dist/cli/commands/code-mode-gate-plan-command.d.ts +1 -1
- package/dist/cli/commands/code-mode-gate-plan-command.js +2 -2
- package/dist/cli/commands/core/memory-extract-command.js +10 -5
- package/dist/cli/commands/dispatch-cli-invocation-check.d.ts +108 -0
- package/dist/cli/commands/dispatch-cli-invocation-check.js +87 -0
- package/dist/cli/commands/dispatch-cli-invocation-scan.d.ts +66 -0
- package/dist/cli/commands/dispatch-cli-invocation-scan.js +162 -0
- package/dist/cli/commands/dispatch-command-spec.js +1 -1
- package/dist/cli/commands/dispatch-commands.js +12 -5
- package/dist/cli/commands/dispatch-isolation-lease.d.ts +1 -1
- package/dist/cli/commands/dispatch-isolation-lease.js +6 -53
- package/dist/cli/commands/dispatch-preflight.js +46 -0
- package/dist/cli/commands/dispatch-prompt-blocks.d.ts +1 -1
- package/dist/cli/commands/dispatch-prompt-composition.d.ts +7 -1
- package/dist/cli/commands/dispatch-prompt-composition.js +29 -7
- package/dist/cli/commands/dispatch-record-write.d.ts +1 -1
- package/dist/cli/commands/dispatch-tool-call.d.ts +1 -1
- package/dist/cli/commands/doc-commands.js +1 -1
- package/dist/cli/commands/feedback-commands-helpers.js +1 -1
- package/dist/cli/commands/final-review-prepare-command.js +22 -1
- package/dist/cli/commands/gate-commands-enforce.js +3 -3
- package/dist/cli/commands/hook-handle.js +41 -20
- package/dist/cli/commands/lint-commands.js +3 -1
- package/dist/cli/commands/loop-eval-capture-index.js +2 -4
- package/dist/cli/commands/openspec-command-shared.js +2 -2
- package/dist/cli/commands/perf-audit-commands.js +15 -5
- package/dist/cli/commands/project-commands.js +9 -6
- package/dist/cli/commands/race-commands.d.ts +15 -0
- package/dist/cli/commands/race-commands.js +65 -0
- package/dist/cli/commands/race-pilot-gate-record-command.d.ts +3 -0
- package/dist/cli/commands/race-pilot-gate-record-command.js +81 -0
- package/dist/cli/commands/request-command-options.d.ts +8 -0
- package/dist/cli/commands/request-commands.js +2 -0
- package/dist/cli/commands/request-init-command.js +67 -12
- package/dist/cli/commands/{vm-status-command.d.ts → request-retag-command.d.ts} +1 -1
- package/dist/cli/commands/request-retag-command.js +50 -0
- package/dist/cli/commands/request-show-command.d.ts +8 -0
- package/dist/cli/commands/request-show-command.js +14 -1
- package/dist/cli/commands/request-transition-command.js +12 -4
- package/dist/cli/commands/request-transition-failures.d.ts +14 -0
- package/dist/cli/commands/request-transition-failures.js +76 -7
- package/dist/cli/commands/request-transition-preflight.js +1 -1
- package/dist/cli/commands/scan-scope-commands.js +2 -2
- package/dist/cli/commands/security-audit-commands.js +26 -6
- package/dist/cli/commands/slice-decompose-artifacts.js +2 -1
- package/dist/cli/commands/verdict-aggregate-command.js +2 -1
- package/dist/cli/commands/workflow-gate-commands.js +4 -4
- package/dist/cli/commands/worktree-lease-gc-command.js +1 -1
- package/dist/cli/program.js +0 -2
- package/dist/services/artifacts/artifact-contract-block.d.ts +53 -0
- package/dist/services/artifacts/artifact-contract-block.js +231 -0
- package/dist/services/artifacts/artifact-prerequisites.d.ts +27 -19
- package/dist/services/artifacts/artifact-prerequisites.js +65 -135
- package/dist/services/artifacts/artifact-templates.d.ts +1 -1
- package/dist/services/artifacts/artifact-templates.js +17 -10
- package/dist/services/artifacts/prerequisite-checks.d.ts +87 -0
- package/dist/services/artifacts/prerequisite-checks.js +198 -0
- package/dist/services/artifacts/prerequisite-transition-event.d.ts +20 -0
- package/dist/services/artifacts/prerequisite-transition-event.js +27 -0
- package/dist/services/artifacts/rd-transition-gates.d.ts +33 -0
- package/dist/services/artifacts/rd-transition-gates.js +71 -0
- package/dist/services/artifacts/request-artifact-metadata.d.ts +31 -0
- package/dist/services/artifacts/request-artifact-metadata.js +44 -0
- package/dist/services/artifacts/request-artifact-service.d.ts +5 -0
- package/dist/services/artifacts/request-artifact-service.js +43 -69
- package/dist/services/artifacts/request-artifact-state-helpers.d.ts +21 -1
- package/dist/services/artifacts/request-artifact-state-helpers.js +34 -8
- package/dist/services/artifacts/request-retag-service.d.ts +68 -0
- package/dist/services/artifacts/request-retag-service.js +125 -0
- package/dist/services/artifacts/request-state-order.d.ts +38 -0
- package/dist/services/artifacts/request-state-order.js +99 -0
- package/dist/services/artifacts/request-type-demand.d.ts +44 -0
- package/dist/services/artifacts/request-type-demand.js +71 -0
- package/dist/services/audit/audit-goal-service.d.ts +7 -0
- package/dist/services/audit/enforcers/active-skill-resolver.d.ts +18 -0
- package/dist/services/audit/enforcers/active-skill-resolver.js +48 -1
- package/dist/services/audit/enforcers/code-ban.d.ts +11 -2
- package/dist/services/audit/enforcers/code-ban.js +21 -1
- package/dist/services/audit/red-line-catalog-p2-a-bee-runtime.d.ts +17 -0
- package/dist/services/audit/red-line-catalog-p2-a-bee-runtime.js +24 -7
- package/dist/services/audit-independent/handoff-missing-refusal.d.ts +26 -0
- package/dist/services/audit-independent/handoff-missing-refusal.js +109 -0
- package/dist/services/audit-independent/handoff-readers.d.ts +37 -0
- package/dist/services/audit-independent/handoff-readers.js +81 -0
- package/dist/services/audit-independent/index.d.ts +6 -1
- package/dist/services/audit-independent/index.js +6 -1
- package/dist/services/audit-independent/judged-declaration-build.d.ts +48 -0
- package/dist/services/audit-independent/judged-declaration-build.js +73 -0
- package/dist/services/audit-independent/judged-declaration-check.d.ts +80 -0
- package/dist/services/audit-independent/judged-declaration-check.js +216 -0
- package/dist/services/audit-independent/judged-declaration.d.ts +94 -0
- package/dist/services/audit-independent/judged-declaration.js +218 -0
- package/dist/services/audit-independent/perf-audit-service.js +12 -14
- package/dist/services/audit-independent/security-audit-artifact.d.ts +28 -0
- package/dist/services/audit-independent/security-audit-artifact.js +90 -0
- package/dist/services/audit-independent/security-audit-service.d.ts +6 -53
- package/dist/services/audit-independent/security-audit-service.js +34 -178
- package/dist/services/capability-guard-runner/contracts/J05.js +60 -14
- package/dist/services/codegraph/codegraph-index-integrity.js +2 -0
- package/dist/services/context/build-dispatch-system-prompt.d.ts +8 -12
- package/dist/services/context/build-dispatch-system-prompt.js +18 -18
- package/dist/services/context/collector.js +5 -1
- package/dist/services/context/post-compact-reinjection.js +1 -1
- package/dist/services/dispatch/active-dispatch-index.d.ts +36 -0
- package/dist/services/dispatch/active-dispatch-index.js +118 -0
- package/dist/services/dispatch/batch-counter.js +1 -2
- package/dist/services/dispatch/dispatch-record-writer.d.ts +29 -16
- package/dist/services/dispatch/dispatch-record-writer.js +58 -100
- package/dist/services/dispatch/dispatch-sub-agent.js +1 -1
- package/dist/services/dispatch/karpathy-block.d.ts +55 -0
- package/dist/services/dispatch/karpathy-block.js +101 -0
- package/dist/services/dispatch/ledger-reaper.d.ts +80 -0
- package/dist/services/dispatch/ledger-reaper.js +131 -0
- package/dist/services/dispatch/test-tool-detection.d.ts +17 -1
- package/dist/services/dispatch/test-tool-detection.js +12 -1
- package/dist/services/evidence/evidence-generator.js +23 -12
- package/dist/services/feedback/feedback-promotion-service.d.ts +8 -11
- package/dist/services/feedback/feedback-promotion-service.js +30 -35
- package/dist/services/feedback/promotion-artifact-json-evidence.d.ts +18 -0
- package/dist/services/feedback/promotion-artifact-missing.d.ts +22 -0
- package/dist/services/feedback/promotion-artifact-missing.js +63 -0
- package/dist/services/final-review/final-review-contract.d.ts +95 -4
- package/dist/services/final-review/final-review-contract.js +64 -0
- package/dist/services/final-review/final-review-delivery.d.ts +13 -0
- package/dist/services/final-review/final-review-delivery.js +26 -12
- package/dist/services/final-review/final-review-evidence-collect.js +8 -53
- package/dist/services/final-review/final-review-evidence-records.d.ts +21 -0
- package/dist/services/final-review/final-review-evidence-records.js +67 -0
- package/dist/services/final-review/final-review-evidence-sources.d.ts +22 -0
- package/dist/services/final-review/final-review-evidence-sources.js +28 -4
- package/dist/services/final-review/final-review-prompt.js +19 -6
- package/dist/services/final-review/final-review-runner.js +5 -0
- package/dist/services/final-review/final-review-service.d.ts +2 -2
- package/dist/services/final-review/index.d.ts +1 -1
- package/dist/services/final-review/pre-post-diff.d.ts +2 -75
- package/dist/services/final-review/pre-post-diff.js +60 -59
- package/dist/services/hooks/pre-tool-code-gate.d.ts +7 -1
- package/dist/services/hooks/pre-tool-code-gate.js +21 -2
- package/dist/services/hooks/worktree-authorization-gate.js +6 -31
- package/dist/services/hooks/worktree-refusal-messages.d.ts +74 -0
- package/dist/services/hooks/worktree-refusal-messages.js +102 -0
- package/dist/services/lint/eslint-runner-support.d.ts +1 -1
- package/dist/services/lint/eslint-runner-support.js +2 -1
- package/dist/services/lint/eslint-runner-types.d.ts +8 -0
- package/dist/services/lint/eslint-runner.js +17 -4
- package/dist/services/llm/anthropic-runner.js +24 -7
- package/dist/services/loop/loop-observability.d.ts +39 -0
- package/dist/services/loop/loop-observability.js +55 -0
- package/dist/services/loop/monotonic-guard.js +6 -9
- package/dist/services/loop/monotonic-runner.js +8 -7
- package/dist/services/loop/run-driver.js +18 -22
- package/dist/services/memory/project-memory-service/index/kind-dispatch.js +14 -1
- package/dist/services/memory/project-memory-service/index/project-memory-plan-exec.js +13 -2
- package/dist/services/memory/project-memory-service/index.d.ts +2 -2
- package/dist/services/memory/project-memory-service/index.js +1 -1
- package/dist/services/memory/project-memory-service/parsers/frontmatter-parse.d.ts +36 -0
- package/dist/services/memory/project-memory-service/parsers/frontmatter-parse.js +48 -2
- package/dist/services/memory/project-memory-service/parsers/markdown-pure.d.ts +23 -1
- package/dist/services/memory/project-memory-service/parsers/markdown-pure.js +37 -0
- package/dist/services/memory/project-memory-service/types.d.ts +32 -0
- package/dist/services/observability/observability-service.d.ts +7 -0
- package/dist/services/observability/observability-service.js +2 -1
- package/dist/services/openspec/coverage-evidence-reader.d.ts +9 -9
- package/dist/services/openspec/coverage-evidence-reader.js +8 -8
- package/dist/services/openspec/openspec-archive-service.d.ts +1 -1
- package/dist/services/openspec/openspec-archive-service.js +6 -6
- package/dist/services/prd/gate-evidence-derivation.d.ts +4 -3
- package/dist/services/prd/gate-evidence-derivation.js +4 -3
- package/dist/services/qa/bdd-test-style-verifier.js +22 -8
- package/dist/services/race/gate2-evaluator.d.ts +58 -0
- package/dist/services/race/gate2-evaluator.js +111 -0
- package/dist/services/race/gate2-policy.d.ts +17 -0
- package/dist/services/race/gate2-policy.js +31 -0
- package/dist/services/race/lane-phase.d.ts +19 -0
- package/dist/services/race/lane-phase.js +113 -0
- package/dist/services/race/pilot-gate-store.d.ts +67 -0
- package/dist/services/race/pilot-gate-store.js +227 -0
- package/dist/services/scan/file-size-baseline.d.ts +33 -0
- package/dist/services/scan/file-size-baseline.js +173 -0
- package/dist/services/scan/file-size-scan.d.ts +35 -3
- package/dist/services/scan/file-size-scan.js +63 -42
- package/dist/services/scan/type-corroboration.d.ts +32 -0
- package/dist/services/scan/type-corroboration.js +51 -0
- package/dist/services/scan/type-sanity-service.d.ts +14 -0
- package/dist/services/scan/type-sanity-service.js +23 -22
- package/dist/services/security/safe-settings-path.d.ts +5 -0
- package/dist/services/security/safe-settings-path.js +64 -8
- package/dist/services/skill/resume-detector.js +11 -11
- package/dist/services/skills/hooks-codegate-superpowers.d.ts +5 -6
- package/dist/services/skills/hooks-codegate-superpowers.js +7 -8
- package/dist/services/skills/hooks-settings-service.d.ts +1 -1
- package/dist/services/skills/hooks-settings-service.js +1 -1
- package/dist/services/skills/presence-lease-order.d.ts +13 -0
- package/dist/services/skills/presence-lease-order.js +24 -0
- package/dist/services/skills/skill-conformance-service.js +1 -0
- package/dist/services/skills/skill-statusline-service.js +4 -7
- package/dist/services/slice/slice-check-service.js +8 -8
- package/dist/services/workflow/pipeline-verify-gate-support.d.ts +24 -8
- package/dist/services/workflow/pipeline-verify-gate-support.js +34 -39
- package/dist/services/workflow/pipeline-verify-qa-phase.d.ts +102 -0
- package/dist/services/workflow/pipeline-verify-qa-phase.js +176 -0
- package/dist/services/workflow/pipeline-verify-service.js +27 -28
- package/dist/services/workflow/request-type-resolution.d.ts +99 -0
- package/dist/services/workflow/request-type-resolution.js +130 -0
- package/dist/services/workflow/workflow-skip-service.d.ts +1 -20
- package/dist/services/workflow/workflow-skip-service.js +22 -25
- package/dist/services/workflow/workflow-state-store.d.ts +9 -0
- package/dist/services/workflow/workflow-state-store.js +26 -1
- package/dist/services/workspace/claude-settings-retirements.d.ts +54 -0
- package/dist/services/workspace/claude-settings-retirements.js +112 -0
- package/dist/services/workspace/claude-settings-template-merge.d.ts +35 -15
- package/dist/services/workspace/claude-settings-template-merge.js +33 -53
- package/dist/services/workspace/claude-settings-template.d.ts +62 -12
- package/dist/services/workspace/claude-settings-template.js +58 -58
- package/dist/services/workspace/migrate-1-4-1-service.js +3 -0
- package/dist/services/workspace/reconcile-service.js +0 -1
- package/dist/shared/incrementing-number.d.ts +33 -2
- package/dist/shared/incrementing-number.js +72 -3
- package/package.json +5 -7
- package/skills/bee/peaks-perf-audit/SKILL.md +1 -1
- package/skills/bee/peaks-prd/SKILL.md +4 -3
- package/skills/bee/peaks-qa/SKILL.md +1 -1
- package/skills/bee/peaks-qa/references/qa-sub-agent-dispatch.md +2 -2
- package/skills/bee/peaks-qa/references/qa-transition-gates.md +1 -1
- package/skills/bee/peaks-rd/SKILL.md +2 -2
- package/skills/bee/peaks-rd/references/rd-fanout-contracts.md +1 -1
- package/skills/bee/peaks-rd/references/rd-sub-agent-dispatch.md +8 -4
- package/skills/bee/peaks-rd/references/rd-transition-gates.md +3 -3
- package/skills/bee/peaks-rd/references/v2-12-fanout-collapse.md +2 -2
- package/skills/bee/peaks-rd/references/writing-handoff-frontmatter.md +1 -1
- package/skills/bee/peaks-reviewer/SKILL.md +1 -1
- package/skills/bee/peaks-sc/SKILL.md +1 -1
- package/skills/bee/peaks-security-audit/SKILL.md +10 -2
- package/skills/bee/peaks-txt/SKILL.md +4 -3
- package/skills/bee/peaks-ui/SKILL.md +3 -3
- package/skills/peaks-audit/SKILL.md +29 -1
- package/skills/peaks-code/SKILL.md +37 -17
- package/skills/peaks-code/references/fast-lane-norm.md +42 -0
- package/skills/peaks-code/references/fast-mode.md +3 -2
- package/skills/peaks-code/references/local-artifact-workspace.md +3 -3
- package/skills/peaks-code/references/micro-cycle.md +3 -3
- package/skills/peaks-code/references/resume-detection.md +1 -1
- package/skills/peaks-code/references/runbook.md +12 -6
- package/skills/peaks-code/references/step-11-memory-sediment.md +4 -0
- package/skills/peaks-code/references/sub-agent-dispatch.md +1 -1
- package/skills/peaks-code/references/swarm-dispatch-contract.md +40 -16
- package/skills/peaks-code/references/workflow-gates-and-types.md +6 -6
- package/skills/peaks-code/references/worktree-governance.md +4 -4
- package/skills/peaks-content/SKILL.md +1 -1
- package/skills/peaks-doctor/SKILL.md +1 -1
- package/skills/peaks-final-review/SKILL.md +31 -11
- package/skills/peaks-ide/SKILL.md +1 -1
- package/skills/peaks-issue-fix-orchestrator/SKILL.md +1 -1
- package/skills/peaks-race-code/SKILL.md +185 -0
- package/skills/peaks-resume/SKILL.md +1 -1
- package/skills/peaks-slice-decompose/SKILL.md +1 -1
- package/skills/peaks-solo/SKILL.md +1 -1
- package/skills/peaks-sop/SKILL.md +1 -1
- package/skills/peaks-status/SKILL.md +1 -1
- package/skills/peaks-test/SKILL.md +7 -4
- package/dist/cli/commands/vm-command-shared.d.ts +0 -23
- package/dist/cli/commands/vm-command-shared.js +0 -23
- package/dist/cli/commands/vm-commands.d.ts +0 -3
- package/dist/cli/commands/vm-commands.js +0 -45
- package/dist/cli/commands/vm-hypervisor-probe.d.ts +0 -27
- package/dist/cli/commands/vm-hypervisor-probe.js +0 -78
- package/dist/cli/commands/vm-hypervisor-runtime.d.ts +0 -15
- package/dist/cli/commands/vm-hypervisor-runtime.js +0 -64
- package/dist/cli/commands/vm-release-command.d.ts +0 -5
- package/dist/cli/commands/vm-release-command.js +0 -101
- package/dist/cli/commands/vm-spawn-command.d.ts +0 -5
- package/dist/cli/commands/vm-spawn-command.js +0 -177
- package/dist/cli/commands/vm-status-command.js +0 -50
- package/dist/services/audit/enforcers/lint-peaks-skill-runtime.d.ts +0 -23
- package/dist/services/audit/enforcers/lint-peaks-skill-runtime.js +0 -64
- package/dist/services/vm/vm-lease.d.ts +0 -40
- package/dist/services/vm/vm-lease.js +0 -160
|
@@ -2,10 +2,27 @@
|
|
|
2
2
|
* Utilities for generating incrementing numbered filenames.
|
|
3
3
|
* Used by session-based artifact storage to create files like 001-feature.md.
|
|
4
4
|
*/
|
|
5
|
+
/**
|
|
6
|
+
* The `<NNN>-` prefix family: EXACTLY three digits, anchored at the start. The one
|
|
7
|
+
* definition the counting side (`getNextNumber`), the writing side
|
|
8
|
+
* (`buildNumberedFilename`) and the stripping side (`requestIdFromFileName`) all
|
|
9
|
+
* read, so neither side can widen the family without the others.
|
|
10
|
+
*
|
|
11
|
+
* Three digits is what the writer pads to for every number it can hand out, and a
|
|
12
|
+
* WIDER pattern on the counting side is the whole defect this constant closes: with
|
|
13
|
+
* `^(\d+)-` the leading YEAR of a bare date-shaped name (`2026-10-15-<slug>`) reads
|
|
14
|
+
* as a file number. Four digits is out of family by construction — `\d{3}` is
|
|
15
|
+
* followed by `-`, and `2026-` has a digit there.
|
|
16
|
+
*/
|
|
17
|
+
export declare const NUMBERED_PREFIX_RE: RegExp;
|
|
5
18
|
/**
|
|
6
19
|
* Get the next available number in a directory.
|
|
7
|
-
* Scans existing .md files and finds the highest numeric prefix.
|
|
8
|
-
* Returns 1 if directory is empty or
|
|
20
|
+
* Scans existing .md files and finds the highest IN-FAMILY numeric prefix.
|
|
21
|
+
* Returns 1 if the directory is empty, missing, or holds no in-family name.
|
|
22
|
+
*
|
|
23
|
+
* A name whose leading digits are not a whole prefix in the family — a bare
|
|
24
|
+
* date-shaped name, whose leading digits are a year — is ignored rather than
|
|
25
|
+
* counted, so it can never move the answer.
|
|
9
26
|
*
|
|
10
27
|
* @param dirPath - Directory to scan for numbered files
|
|
11
28
|
* @returns Next available number (1, 2, 3, ...)
|
|
@@ -22,6 +39,20 @@ export declare function getNextNumber(dirPath: string): number;
|
|
|
22
39
|
*/
|
|
23
40
|
export declare function slugifyDescription(description: string): string;
|
|
24
41
|
export declare function buildNumberedFilename(number: number, description: string): string;
|
|
42
|
+
/**
|
|
43
|
+
* The id a markdown artifact's filename carries, or null when the name is not a
|
|
44
|
+
* markdown artifact at all. The READ side of `buildNumberedFilename`, in the same
|
|
45
|
+
* module, so writer and reader cannot drift apart from each other.
|
|
46
|
+
*
|
|
47
|
+
* The prefix it strips is `NUMBERED_PREFIX_RE` — the same family `getNextNumber`
|
|
48
|
+
* counts — so a name the writer produced always reads back as the id it was given.
|
|
49
|
+
* A bare date-shaped stem carries no in-family prefix and is returned verbatim.
|
|
50
|
+
*
|
|
51
|
+
* The returned stem is not yet checked against the id pattern the artifact service
|
|
52
|
+
* owns; a caller that needs a legal request id applies that there rather than the
|
|
53
|
+
* pattern being imported here.
|
|
54
|
+
*/
|
|
55
|
+
export declare function requestIdFromFileName(fileName: string): string | null;
|
|
25
56
|
/**
|
|
26
57
|
* Get the next numbered file path in a directory.
|
|
27
58
|
* Combines getNextNumber() and buildNumberedFilename().
|
|
@@ -4,10 +4,27 @@
|
|
|
4
4
|
*/
|
|
5
5
|
import { existsSync, readdirSync } from 'node:fs';
|
|
6
6
|
import { join } from 'node:path';
|
|
7
|
+
/**
|
|
8
|
+
* The `<NNN>-` prefix family: EXACTLY three digits, anchored at the start. The one
|
|
9
|
+
* definition the counting side (`getNextNumber`), the writing side
|
|
10
|
+
* (`buildNumberedFilename`) and the stripping side (`requestIdFromFileName`) all
|
|
11
|
+
* read, so neither side can widen the family without the others.
|
|
12
|
+
*
|
|
13
|
+
* Three digits is what the writer pads to for every number it can hand out, and a
|
|
14
|
+
* WIDER pattern on the counting side is the whole defect this constant closes: with
|
|
15
|
+
* `^(\d+)-` the leading YEAR of a bare date-shaped name (`2026-10-15-<slug>`) reads
|
|
16
|
+
* as a file number. Four digits is out of family by construction — `\d{3}` is
|
|
17
|
+
* followed by `-`, and `2026-` has a digit there.
|
|
18
|
+
*/
|
|
19
|
+
export const NUMBERED_PREFIX_RE = /^(\d{3})-/;
|
|
7
20
|
/**
|
|
8
21
|
* Get the next available number in a directory.
|
|
9
|
-
* Scans existing .md files and finds the highest numeric prefix.
|
|
10
|
-
* Returns 1 if directory is empty or
|
|
22
|
+
* Scans existing .md files and finds the highest IN-FAMILY numeric prefix.
|
|
23
|
+
* Returns 1 if the directory is empty, missing, or holds no in-family name.
|
|
24
|
+
*
|
|
25
|
+
* A name whose leading digits are not a whole prefix in the family — a bare
|
|
26
|
+
* date-shaped name, whose leading digits are a year — is ignored rather than
|
|
27
|
+
* counted, so it can never move the answer.
|
|
11
28
|
*
|
|
12
29
|
* @param dirPath - Directory to scan for numbered files
|
|
13
30
|
* @returns Next available number (1, 2, 3, ...)
|
|
@@ -20,7 +37,7 @@ export function getNextNumber(dirPath) {
|
|
|
20
37
|
return 1;
|
|
21
38
|
const numbers = files
|
|
22
39
|
.map((f) => {
|
|
23
|
-
const match =
|
|
40
|
+
const match = NUMBERED_PREFIX_RE.exec(f);
|
|
24
41
|
return match && match[1] ? parseInt(match[1], 10) : NaN;
|
|
25
42
|
})
|
|
26
43
|
.filter((n) => !isNaN(n));
|
|
@@ -34,6 +51,31 @@ export function getNextNumber(dirPath) {
|
|
|
34
51
|
* @param description - Human-readable description (converted to kebab-case slug)
|
|
35
52
|
* @returns Formatted filename like "001-feature-name.md"
|
|
36
53
|
*/
|
|
54
|
+
/**
|
|
55
|
+
* The `<NNN>` prefix in a numbered filename is COSMETIC — but that is a claim about
|
|
56
|
+
* the NUMBER, not about the prefix's WIDTH. The width is `NUMBERED_PREFIX_RE`:
|
|
57
|
+
* exactly three digits, the one family the counting, writing and stripping sides all
|
|
58
|
+
* read. `getNextNumber` scans the directory's highest in-family prefix and adds one,
|
|
59
|
+
* and nothing claims a number in between — so two writers running at once can both
|
|
60
|
+
* read the same maximum and both stamp the same number. That is harmless only
|
|
61
|
+
* because the number is not an identity: what names an artifact is the slug (the
|
|
62
|
+
* request id), and every reader strips a prefix in the family. Measured 2026-10-12:
|
|
63
|
+
* the sole consumers of the number are this module's writer path (`getNextNumber` ->
|
|
64
|
+
* `buildNumberedFilename`) and the read side (`requestIdFromFileName`, which
|
|
65
|
+
* discards it); the artifact service's duplicate check and lookup both key on the
|
|
66
|
+
* slug. Read that as a constraint: give the number a meaning and you must claim it
|
|
67
|
+
* atomically first, rather than assume this scan hands out unique values.
|
|
68
|
+
*
|
|
69
|
+
* WHY THE FAMILY IS STATED RATHER THAN ASSUMED — the defect this replaced. The
|
|
70
|
+
* counting side once matched `^(\d+)-` while the stripping side knew only `^0\d{2}-`.
|
|
71
|
+
* Two patterns on one naming rule disagree from the day they are written, and a
|
|
72
|
+
* directory of nothing but bare date-shaped names is where it showed: the count
|
|
73
|
+
* answered 2027 (the year 2026, plus one), the writer stamped `2027-` onto a fresh
|
|
74
|
+
* artifact, and the stripping side handed back an id carrying a prefix the state
|
|
75
|
+
* machine had never been given. A four-digit prefix is out of family, so
|
|
76
|
+
* `buildNumberedFilename` refuses to write one instead of letting the writer walk
|
|
77
|
+
* past the reader.
|
|
78
|
+
*/
|
|
37
79
|
// Windows supports up to 255 chars per filename component (and 260 for the
|
|
38
80
|
// full path). Pre-#015 the slug was silently truncated to 50 chars, which
|
|
39
81
|
// produced orphaned artefacts (the on-disk file no longer matched the
|
|
@@ -62,9 +104,36 @@ export function slugifyDescription(description) {
|
|
|
62
104
|
}
|
|
63
105
|
export function buildNumberedFilename(number, description) {
|
|
64
106
|
const padded = String(number).padStart(3, '0');
|
|
107
|
+
// The writer is held to the reader's own family. A number with no three-digit
|
|
108
|
+
// spelling (1000 and up) would produce a prefix `requestIdFromFileName` does not
|
|
109
|
+
// strip, and the artifact's id would then disagree with the id it was given —
|
|
110
|
+
// the counting/stripping disagreement on a second axis. Refuse rather than widen
|
|
111
|
+
// the reader: a four-digit prefix on a filename is a year to every reader.
|
|
112
|
+
if (!NUMBERED_PREFIX_RE.test(`${padded}-`)) {
|
|
113
|
+
throw new Error(`Cannot number a file ${number}: the prefix family is exactly three digits, and ${padded}- is ` +
|
|
114
|
+
'outside it. A directory that has filled the family needs a second directory, not a fourth digit.');
|
|
115
|
+
}
|
|
65
116
|
const slug = slugifyDescription(description);
|
|
66
117
|
return `${padded}-${slug}.md`;
|
|
67
118
|
}
|
|
119
|
+
/**
|
|
120
|
+
* The id a markdown artifact's filename carries, or null when the name is not a
|
|
121
|
+
* markdown artifact at all. The READ side of `buildNumberedFilename`, in the same
|
|
122
|
+
* module, so writer and reader cannot drift apart from each other.
|
|
123
|
+
*
|
|
124
|
+
* The prefix it strips is `NUMBERED_PREFIX_RE` — the same family `getNextNumber`
|
|
125
|
+
* counts — so a name the writer produced always reads back as the id it was given.
|
|
126
|
+
* A bare date-shaped stem carries no in-family prefix and is returned verbatim.
|
|
127
|
+
*
|
|
128
|
+
* The returned stem is not yet checked against the id pattern the artifact service
|
|
129
|
+
* owns; a caller that needs a legal request id applies that there rather than the
|
|
130
|
+
* pattern being imported here.
|
|
131
|
+
*/
|
|
132
|
+
export function requestIdFromFileName(fileName) {
|
|
133
|
+
if (!fileName.endsWith('.md'))
|
|
134
|
+
return null;
|
|
135
|
+
return fileName.replace(NUMBERED_PREFIX_RE, '').replace(/\.md$/, '');
|
|
136
|
+
}
|
|
68
137
|
/**
|
|
69
138
|
* Get the next numbered file path in a directory.
|
|
70
139
|
* Combines getNextNumber() and buildNumberedFilename().
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "peaks-loop",
|
|
3
|
-
"version": "4.1.
|
|
3
|
+
"version": "4.1.6",
|
|
4
4
|
"description": "Loop Engineering CLI — workflow primitive / loop guards / evaluators / slice orchestration",
|
|
5
5
|
"author": "SquabbyZ",
|
|
6
6
|
"keywords": [
|
|
@@ -129,10 +129,10 @@
|
|
|
129
129
|
"picomatch": "4.0.4",
|
|
130
130
|
"yaml": "^2.9.0",
|
|
131
131
|
"zod": "^4.4.3",
|
|
132
|
-
"peaks-loop-internal-runtime": "0.0.
|
|
133
|
-
"peaks-loop-
|
|
134
|
-
"peaks-loop-
|
|
135
|
-
"peaks-loop-shared-channel": "0.0.
|
|
132
|
+
"peaks-loop-internal-runtime": "0.0.46",
|
|
133
|
+
"peaks-loop-mut": "0.1.60",
|
|
134
|
+
"peaks-loop-shared": "0.0.95",
|
|
135
|
+
"peaks-loop-shared-channel": "0.0.63"
|
|
136
136
|
},
|
|
137
137
|
"devDependencies": {
|
|
138
138
|
"@changesets/cli": "2.31.1",
|
|
@@ -185,8 +185,6 @@
|
|
|
185
185
|
"test:race": "vitest run --no-file-parallelism packages/peaks-loop-shared-channel/tests/shared-channel.test.ts tests/unit/services/dispatch/dispatch-record-writer.test.ts",
|
|
186
186
|
"test:replay": "node scripts/fixture-capture-setup.mjs && vitest run tests/unit/services/dispatch/conflict-replay.test.ts tests/unit/services/dispatch/e2e-fixtures.test.ts",
|
|
187
187
|
"fixture:capture-setup": "node scripts/fixture-capture-setup.mjs",
|
|
188
|
-
"test:coverage": "node ./scripts/coverage-c8.mjs",
|
|
189
|
-
"test:coverage:c8": "node ./scripts/coverage-c8.mjs",
|
|
190
188
|
"test:coverage:vitest": "vitest run --coverage",
|
|
191
189
|
"test:coverage:workflow": "vitest run --coverage --coverage.include='src/services/workflow/plan-*.ts' tests/unit/services/workflow/",
|
|
192
190
|
"schema:generate": "node scripts/generate-context-schema.mjs",
|
|
@@ -12,7 +12,7 @@ metadata:
|
|
|
12
12
|
- schema: .peaks/project-scan/audit-output-schema.md
|
|
13
13
|
---
|
|
14
14
|
|
|
15
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
15
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
16
16
|
|
|
17
17
|
## Loop hygiene (every turn — MANDATORY)
|
|
18
18
|
|
|
@@ -8,7 +8,7 @@ description: |
|
|
|
8
8
|
visibility: internal
|
|
9
9
|
---
|
|
10
10
|
|
|
11
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
11
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
12
12
|
|
|
13
13
|
## Loop hygiene (every turn — MANDATORY)
|
|
14
14
|
|
|
@@ -383,8 +383,9 @@ scan BEFORE transitioning to Step 3 RD.
|
|
|
383
383
|
|
|
384
384
|
**Handoff contract:**
|
|
385
385
|
- Input: `businessGoal` (natural language) + `.peaks/project-scan/project-scan.md` (auto-generated by `peaks workspace init`)
|
|
386
|
-
-
|
|
387
|
-
-
|
|
386
|
+
- Lookup (LLM-side, and required for a real scan): query Context7 priority-1 → WebSearch priority-2 with your own tools, then write the results to `.peaks/_runtime/<sessionId>/best-practice/lookup-results.json` as `{ "intent": "<businessGoal>", "context7": { "ok", "results": [{ "title", "url", "snippet" }] }, "websearch": { … } }`. A lookup that returned nothing is `"ok": false, "results": []`, and **if every seam you supply returns nothing the scan refuses with `BEST_PRACTICE_SCAN_NO_FRAGMENTS` and writes no artifact** — zero fragments never renders. Each fragment carries `title`/`url`/`snippet` and no other key, and the `url` is one you construct: Context7 returns no URL, only a library ID.
|
|
387
|
+
- Output: best-practice scan artifact at `<repo>/best-practice/<date>-<slug>.md` (gitignored; `<slug>` is a 32-char slice of the goal). A refusal never overwrites it — it is recorded beside it at `<repo>/best-practice/skipped/<date>-<slug>.md`, so a real recommendation survives the auto-triggered scan that shares its intent.
|
|
388
|
+
- Trigger CLI: `peaks best-practice-scan --project <repo> --intent "<businessGoal>" --lookup-results .peaks/_runtime/<sessionId>/best-practice/lookup-results.json --json`
|
|
388
389
|
- Status: `awaiting-user-ack` (3 valid user responses per spec §7: 接受 / 接受方案 N / 拒绝 + 原因)
|
|
389
390
|
|
|
390
391
|
**State machine:** peak-prd's state machine refuses `--allow-incomplete` style bypass for
|
|
@@ -8,7 +8,7 @@ description: |
|
|
|
8
8
|
visibility: internal
|
|
9
9
|
---
|
|
10
10
|
|
|
11
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
11
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
12
12
|
|
|
13
13
|
## Loop hygiene (every turn — MANDATORY)
|
|
14
14
|
|
|
@@ -13,8 +13,8 @@ This chain ends with `git worktree add` (superpowers:using-git-worktrees SKILL.m
|
|
|
13
13
|
|
|
14
14
|
For worktree operations, use ONLY:
|
|
15
15
|
|
|
16
|
-
- `peaks worktree spawn --rid <rid> --
|
|
17
|
-
- until then: `peaks worktree auth grant --
|
|
16
|
+
- `peaks worktree spawn --rid <rid> --role <role> --purpose <text>` (after rid-L2-extended ships)
|
|
17
|
+
- until then: `peaks worktree auth grant --operation <op> --reason <text>` (`<op>`, e.g. `git-worktree` | `agent-isolation-worktree`)
|
|
18
18
|
|
|
19
19
|
The superpowers skills remain available as REFERENCE material for brainstorming / planning techniques, but MUST NOT be used as a workflow. peaks-qa's own QA artifacts (`.peaks/_runtime/<sessionId>/qa/<artifact>.md`) are authoritative.
|
|
20
20
|
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
|
|
3
3
|
> Body of `### Transition verification gates`. You cannot declare a phase complete from memory. Each gate below is a `ls` or `grep` command you **MUST run** and whose output you **MUST see** before proceeding. If any file shows "No such file" or any command returns empty, the phase is incomplete.
|
|
4
4
|
|
|
5
|
-
> **CLI enforcement (v2.11.0 D1/D4 trim)**: the gates below are enforced by `peaks request transition`. The CLI checks the same files before allowing the transition and fails with `code: PREREQUISITES_MISSING` if any are absent. Required files depend on the request type recorded at `peaks request init --type ...`. **As of v2.11.0:** peaks-qa does NOT own security-findings or performance-findings —
|
|
5
|
+
> **CLI enforcement (v2.11.0 D1/D4 trim)**: the gates below are enforced by `peaks request transition`. The CLI checks the same files before allowing the transition and fails with `code: PREREQUISITES_MISSING` if any are absent. Required files depend on the request type recorded at `peaks request init --type ...`. **As of v2.11.0:** peaks-qa does NOT own security-findings or performance-findings — peaks-rd's audit fan-out produces that evidence as `audit/security-<rid>.md` and `audit/perf-<rid>.md` (the standalone skills in the paragraph below; the paths named here were `rd/security-review.md` / `rd/perf-baseline.md` until v2.12.0 and remain readable back-compat tiers), and the QA test report references it rather than requiring separate files.
|
|
6
6
|
|
|
7
7
|
| Type | qa:running requires | qa:verdict-issued also requires |
|
|
8
8
|
|---|---|---|
|
|
@@ -9,7 +9,7 @@ description: |
|
|
|
9
9
|
visibility: internal
|
|
10
10
|
---
|
|
11
11
|
|
|
12
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
12
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
13
13
|
|
|
14
14
|
## Loop hygiene (every turn — MANDATORY)
|
|
15
15
|
|
|
@@ -85,7 +85,7 @@ For frontend / UI-affecting slices, RD's self-test uses the Playwright MCP heade
|
|
|
85
85
|
|
|
86
86
|
When this skill is launched as a sub-agent via `peaks sub-agent dispatch <role>` (then the LLM executes the returned toolCall) from `peaks-code`, the following sections of THIS skill are **suspended** for the sub-agent run: Session id (use parent's), Skill presence, Workspace initialization, Mode selection, Statusline install.
|
|
87
87
|
|
|
88
|
-
What the sub-agent MUST still do: read PRD via `peaks request show`, run standards preflight (dry-run only), write planning artefact (`rd/tech-doc.md` for feature/refactor; `rd/bug-analysis
|
|
88
|
+
What the sub-agent MUST still do: read PRD via `peaks request show`, run standards preflight (dry-run only), write planning artefact (`rd/tech-doc.md` for feature/refactor; `rd/bug-analysis-<rid>.md` for bugfix; skip for config/docs/chore), return compact JSON envelope.
|
|
89
89
|
|
|
90
90
|
→ see `references/rd-sub-agent-dispatch.md` for the full contract + hard prohibitions.
|
|
91
91
|
|
|
@@ -230,7 +230,7 @@ refusing — matching the prereq-side acceptance above.
|
|
|
230
230
|
|---|---|
|
|
231
231
|
| feature / refactor | `prd/handoff.md` (immutable) + `audit/security-<rid>.md` (peaks-security-audit) + `audit/perf-<rid>.md` (peaks-perf-audit) + `rd/code-review-<rid>.md` + `rd/karpathy-review-<rid>.md` + `qa/test-cases/<rid>.md` |
|
|
232
232
|
| bugfix | `prd/handoff.md` (immutable) + `audit/security-<rid>.md` (peaks-security-audit) + `audit/perf-<rid>.md` (peaks-perf-audit, perf-shaped only) + `rd/code-review-<rid>.md` + `rd/karpathy-review-<rid>.md` + `qa/test-cases/<rid>.md` |
|
|
233
|
-
| config | `rd/security-review
|
|
233
|
+
| config | `rd/security-review-<rid>.md` (`SECURITY_REVIEW.relativePath` carries the `<rid>` since slice 9.37; the bare name stays readable as the legacy tier) |
|
|
234
234
|
| docs / chore | (no extra evidence required) |
|
|
235
235
|
|
|
236
236
|
Always required (in addition to the type-specific row):
|
|
@@ -13,8 +13,8 @@ This chain ends with `git worktree add` (superpowers:using-git-worktrees SKILL.m
|
|
|
13
13
|
|
|
14
14
|
For worktree operations, use ONLY:
|
|
15
15
|
|
|
16
|
-
- `peaks worktree spawn --rid <rid> --
|
|
17
|
-
- until then: `peaks worktree auth grant --
|
|
16
|
+
- `peaks worktree spawn --rid <rid> --role <role> --purpose <text>` (after rid-L2-extended ships)
|
|
17
|
+
- until then: `peaks worktree auth grant --operation <op> --reason <text>` (`<op>`, e.g. `git-worktree` | `agent-isolation-worktree`)
|
|
18
18
|
|
|
19
19
|
The superpowers skills remain available as REFERENCE material for brainstorming / planning techniques, but MUST NOT be used as a workflow. peaks-rd's own PRD/RD artifacts (`.peaks/_runtime/<sessionId>/rd/requests/<rid>.md`) are authoritative.
|
|
20
20
|
|
|
@@ -70,7 +70,7 @@ What the sub-agent **MUST** still do, from this skill's contract:
|
|
|
70
70
|
2. `peaks request show <rid> --role prd --project <repo> --json` (and `--role ui` if UI is in the swarm plan).
|
|
71
71
|
3. Standards preflight (dry-run only; Code owns the apply step).
|
|
72
72
|
4. Project-scan read; create `rd/project-scan.md` only if Code flagged it missing in the dispatch prompt.
|
|
73
|
-
5. Write the planning artefact: `rd/requests/<rid>.md` (feature/refactor, per the `artifact-per-request.md` contract) or `rd/bug-analysis
|
|
73
|
+
5. Write the planning artefact: `rd/requests/<rid>.md` (feature/refactor, per the `artifact-per-request.md` contract) or `rd/bug-analysis-<rid>.md` (bugfix). If `--type` is `config|docs|chore`, **no planning artefact is required** — return immediately with `{"role":"rd-planning","status":"skipped","reason":"type=<type>"}`.
|
|
74
74
|
|
|
75
75
|
> **v2.11.0 change (Group A):** `rd/tech-doc.md` is removed. The per-slice planning record is the per-request artefact at `rd/requests/<rid>.md`; the slice's source-of-truth architecture is the immutable peaks-prd handoff at `prd/handoff.md` (verify handoff hash = `<dispatched value>` before reading).
|
|
76
76
|
6. Return only a compact JSON envelope — Code will run the convergence gate (`ls` checks):
|
|
@@ -139,6 +139,8 @@ See the block constant at `src/services/dispatch/test-tool-detection.ts` for the
|
|
|
139
139
|
|
|
140
140
|
When the dispatch primitive constructs the sub-agent prompt, the following context block MUST be appended to the sub-agent prompt verbatim. The block is the canonical injection source for any RD-spawned sub-agent (including 4-way fanout, including inline main-loop RD).
|
|
141
141
|
|
|
142
|
+
**The dispatch CLI now does this itself (2026-10-13).** `peaks sub-agent dispatch` runs `ensureKarpathyBlock` over the assembled prompt (`src/services/dispatch/karpathy-block.ts`, applied in `src/cli/commands/dispatch-prompt-composition.ts`), so the block reaches the child whether or not the caller remembers to append it. A caller that already appended it is not appended twice. The constant is the machine copy of the block below, and a unit test asserts the two are byte-equal, so neither can drift. What the obligation still covers is the path that does NOT go through this CLI: `--from-dag` (`src/services/code/dag-orchestrator.ts`) and `--mode detached` inject no Karpathy block, so a caller using either must append it itself.
|
|
143
|
+
|
|
142
144
|
```
|
|
143
145
|
Karpathy-guidelines context (REQUIRED — read before any code action)
|
|
144
146
|
|
|
@@ -161,7 +163,9 @@ Touch only what you must. Clean up only your own mess. When editing existing cod
|
|
|
161
163
|
Define success criteria. Loop until verified. "Add validation" → write tests for invalid inputs, then make them pass. "Fix the bug" → write a test that reproduces it, then make it pass. For multi-step tasks, state a brief plan with verify checkpoints. Strong success criteria let you loop independently. Weak criteria require constant clarification.
|
|
162
164
|
```
|
|
163
165
|
|
|
164
|
-
Sub-agents MUST NOT silently drop this block.
|
|
166
|
+
Sub-agents MUST NOT silently drop this block. The canonical skill id for the full guidelines text is `andrej-karpathy-skills:karpathy-guidelines`.
|
|
167
|
+
|
|
168
|
+
Corrected 2026-10-13, kept visible rather than edited away: this paragraph used to read *"Nothing asserts its presence automatically — the unit test that did was deleted in `f17aa377`, so a dropped block fails silently."* That was true when written and it was the defect. The composer now injects the block and `tests/unit/services/dispatch/karpathy-block.test.ts` + `tests/unit/skills/karpathy-injection.test.ts` assert both the delivery and the byte-equality of this file's block with the constant, so a dropped block no longer fails silently on the CLI path. Measured 2026-10-12, before the executor existed: four RD dispatch prompts in one session carried zero occurrences of `Karpathy`.
|
|
165
169
|
|
|
166
170
|
## BDD Test Style Contract (effective rid-2026-08-05-bdd-test-style, v4.0.11+)
|
|
167
171
|
|
|
@@ -11,10 +11,10 @@ You cannot declare a phase complete from memory. Each gate below is a `ls` or `g
|
|
|
11
11
|
> | Type | rd:implemented requires | rd:qa-handoff also requires |
|
|
12
12
|
> |---|---|---|
|
|
13
13
|
> | feature / refactor | `rd/tech-doc.md` | `rd/code-review-<rid>.md` + `audit/security-<rid>.md` + `audit/perf-<rid>.md` (filled Results table, or `N/A — no perf surface` in Notes) + **`qa/test-cases/<rid>.md`** (added in slice 004; pre-drafted by the 4th sub-agent in the parallel fan-out) |
|
|
14
|
-
> | bugfix | `rd/bug-analysis
|
|
15
|
-
> | config | (none) | `rd/security-review
|
|
14
|
+
> | bugfix | `rd/bug-analysis-<rid>.md` (lighter than tech-doc; root cause + fix + regression test plan) | `rd/code-review-<rid>.md` + `audit/security-<rid>.md` + **`qa/test-cases/<rid>.md`**; `audit/perf-<rid>.md` only when the bug is performance-shaped (matches the L449-452 "When this applies" criteria) |
|
|
15
|
+
> | config | (none) | `rd/security-review-<rid>.md` only — `SECURITY_REVIEW.relativePath` carries the `<rid>` since slice 9.37 |
|
|
16
16
|
>
|
|
17
|
-
> The `<rid>`-bearing names are the ones `peaks request transition` resolves first; the pre-rid names (`rd/code-review.md`, `rd/security-review.md`, `audit/security.md`, `audit/perf.md`) stay **readable** as back-compat tiers for sessions written before
|
|
17
|
+
> The `<rid>`-bearing names are the ones `peaks request transition` resolves first; the pre-rid names (`rd/bug-analysis.md`, `rd/code-review.md`, `rd/security-review.md`, `audit/security.md`, `audit/perf.md`) stay **readable** as back-compat tiers for sessions written before the rid was added to the filename — read, never written. Exception: `rd/perf-baseline.md` is the RD-side Gate B9 baseline (a different artifact from `audit/perf-<rid>.md`) and is still both written by `peaks perf baseline --apply` and read as `AUDIT_PERF`'s oldest legacy tier.
|
|
18
18
|
> | docs / chore | (none) | (none) |
|
|
19
19
|
>
|
|
20
20
|
> The escape hatch `--allow-incomplete --reason "<text>"` still exists for one-off exceptions; the bypass is recorded in the artifact transition note.
|
|
@@ -9,10 +9,10 @@ into two new standalone audit skills.
|
|
|
9
9
|
## Removed sub-agent slots
|
|
10
10
|
|
|
11
11
|
- `security-reviewer` — moved to standalone `peaks-security-audit` skill.
|
|
12
|
-
Output: `.peaks/_runtime/<sessionId>/audit/security
|
|
12
|
+
Output: `.peaks/_runtime/<sessionId>/audit/security-<rid>.md`.
|
|
13
13
|
Required RD-side prereq: `AUDIT_SECURITY`.
|
|
14
14
|
- `perf-baseline-reviewer` — moved to standalone `peaks-perf-audit` skill.
|
|
15
|
-
Output: `.peaks/_runtime/<sessionId>/audit/perf
|
|
15
|
+
Output: `.peaks/_runtime/<sessionId>/audit/perf-<rid>.md`.
|
|
16
16
|
Required RD-side prereq: `AUDIT_PERF`.
|
|
17
17
|
|
|
18
18
|
Both audit skills consume the immutable peaks-prd handoff
|
|
@@ -67,7 +67,7 @@ gateEvidence:
|
|
|
67
67
|
- `nextActions[]` — verb-first; what peaks-qa should do next, in order.
|
|
68
68
|
- `gateEvidence` — paths to the gate files peaks-qa will validate. **DERIVED, never hand-written**: the producer computes it from the request `type` (`src/services/prd/gate-evidence-derivation.ts`), and Gate C reads the same `rd:qa-handoff` row, so the block and the gate cannot disagree. It declares that row's evidence, plus `projectScan` (Gate A's artifact — declared only where Gate C runs, since a path nothing verifies should not be declared):
|
|
69
69
|
- `feature` / `refactor` / `bugfix` → **5 keys**: `projectScan`, `prdHandoff`, `codeReview`, `securityReview`, `perfBaseline`
|
|
70
|
-
- `config` → **2 keys**: `projectScan`, `securityReview`. `CONFIG_TABLE['rd:qa-handoff']` is the security review alone, so a config slice has **no** `prdHandoff`; and its security evidence is
|
|
70
|
+
- `config` → **2 keys**: `projectScan`, `securityReview`. `CONFIG_TABLE['rd:qa-handoff']` is the security review alone, so a config slice has **no** `prdHandoff`; and its security evidence is `rd/security-review-<rid>.md` (scoped by rid since slice 9.37), not `audit/security-<rid>.md`.
|
|
71
71
|
- `docs` / `chore` → **no `gateEvidence` block at all**. Those types have no `rd:qa-handoff` row: there is no evidence to declare and nothing for Gate C to check, so the block is omitted rather than filled with an unverified statement. Such a capsule is byte-identical to a pre-B2 one.
|
|
72
72
|
**The Gate C failure rule is scoped to the types above** — where that gate runs: a declared path that does not exist fails `peaks request transition --state qa-handoff` (`PREREQUISITES_MISSING`), naming the key. Two shapes are deliberately NOT failures: a capsule for a type with no `rd:qa-handoff` row (the check does not run), and an **empty** declaration (`gateEvidence: {}`) — a weak claim, not a false one, since the type's artifacts remain enforced by the table itself, so an empty map cannot open the gate. When the request type cannot be resolved at all, the block is omitted rather than half-declared.
|
|
73
73
|
- `schemaVersion: 2` — pinned, and written PLAIN (no quotes). The constant is `HANDOFF_SCHEMA_VERSION` in `src/services/prd/handoff-frontmatter-shape.ts` and its value is the string `'2'`; the serializer emits it unquoted, because `AUDIT_REQUIRES_HANDOFF` matches the substring `schemaVersion: 2` and a quoted `'2'` would not contain it. `readHandoff` accepts `'2'` or the bare number `2` and nothing else — **`'2.0'` is not a valid value here**, and this document said it was until it was measured against the serializer. Bump only when the field set changes.
|
|
@@ -4,7 +4,7 @@ visibility: internal
|
|
|
4
4
|
description: Third-party independent code-review skill for Peaks. Use as a parallel reviewer to karpathy-reviewer when a workflow needs an out-of-band (non-RD-model) review pass to mitigate single-LLM self-dogfood blind spots. Emits a schema-validated ReviewerEnvelope (no free-form LLM JSON). v2.14.0 G4.
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
7
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
8
8
|
|
|
9
9
|
## Loop hygiene (every turn — MANDATORY)
|
|
10
10
|
|
|
@@ -8,7 +8,7 @@ description: |
|
|
|
8
8
|
visibility: internal
|
|
9
9
|
---
|
|
10
10
|
|
|
11
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
11
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
12
12
|
|
|
13
13
|
## Loop hygiene (every turn — MANDATORY)
|
|
14
14
|
|
|
@@ -12,7 +12,7 @@ metadata:
|
|
|
12
12
|
- schema: .peaks/project-scan/audit-output-schema.md
|
|
13
13
|
---
|
|
14
14
|
|
|
15
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
15
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
16
16
|
|
|
17
17
|
## Loop hygiene (every turn — MANDATORY)
|
|
18
18
|
|
|
@@ -142,11 +142,19 @@ The service renders the envelope to markdown and writes to
|
|
|
142
142
|
|
|
143
143
|
```bash
|
|
144
144
|
peaks security-audit run --rid <id> --sid <sid> --project <repo> \
|
|
145
|
+
--judged <path> [<path>...] \
|
|
145
146
|
--envelope @<path-to-envelope.json>
|
|
146
147
|
# or pipe the envelope via stdin
|
|
147
|
-
peaks security-audit run --rid <id> --sid <sid> --project <repo>
|
|
148
|
+
peaks security-audit run --rid <id> --sid <sid> --project <repo> \
|
|
149
|
+
--judged <path> [<path>...] < envelope.json
|
|
148
150
|
```
|
|
149
151
|
|
|
152
|
+
`--judged` is **required**, and omitting it refuses the run with `declaration-missing` without
|
|
153
|
+
writing anything. Name the paths this audit actually judged: the CLI records each one's content
|
|
154
|
+
hash in the artifact, and `rd:qa-handoff` re-hashes them, so a declared path edited afterwards
|
|
155
|
+
refuses that transition. **Declare what you judged, not what you touched** — the check can tell
|
|
156
|
+
that a declared path moved, and it cannot tell that an undeclared one did.
|
|
157
|
+
|
|
150
158
|
The artifact body has the required sections per `.peaks/project-scan/audit-output-schema.md`:
|
|
151
159
|
|
|
152
160
|
- `## Summary` — 1-paragraph narrative
|
|
@@ -8,7 +8,7 @@ description: |
|
|
|
8
8
|
visibility: internal
|
|
9
9
|
---
|
|
10
10
|
|
|
11
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
11
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
12
12
|
|
|
13
13
|
## Loop hygiene (every turn — MANDATORY)
|
|
14
14
|
|
|
@@ -277,7 +277,8 @@ peaks capabilities --json
|
|
|
277
277
|
# You MUST scan the handoff capsule for embedded memory blocks FIRST. If none
|
|
278
278
|
# are present, the step is a no-op (the command succeeds with extractedCount=0
|
|
279
279
|
# and writes nothing). If blocks are present, --apply writes them and the
|
|
280
|
-
# index is regenerated
|
|
280
|
+
# index is regenerated — except a block whose target name is already in the
|
|
281
|
+
# store, which is skipped and named in warnings[] (check it; see below).
|
|
281
282
|
grep -c "peaks-memory:start" .peaks/_runtime/<sessionId>/txt/handoff.md || true # skill-side scan; do NOT add a new CLI
|
|
282
283
|
peaks memory extract --project <repo> --artifact .peaks/_runtime/<sessionId>/txt/handoff.md --apply --json
|
|
283
284
|
peaks skill presence:clear --project <repo> # handoff capsule complete, remove presence indicator
|
|
@@ -292,7 +293,7 @@ Every handoff capsule you emit **MUST** include the scan for stable facts. The m
|
|
|
292
293
|
- Run `grep -c 'peaks-memory:start' .peaks/_runtime/<sessionId>/txt/handoff.md` after writing the capsule body.
|
|
293
294
|
- If the count is 0 AND this session surfaced a stable project fact (an architectural decision, a stack constraint, a naming convention, a refactor approved by the user, an API pattern, a hard rule from RD/QA review), you MUST go back and embed at least one `<!-- peaks-memory:start -->` block before declaring TXT complete. Skipping the block is a workflow violation.
|
|
294
295
|
- If the count is 0 AND no stable fact was surfaced (pure analysis, no code touched, all transient), it is acceptable to skip embedding — but you MUST still run `peaks memory extract --apply` so the artefact state stays consistent (the command will be a no-op write, that's fine).
|
|
295
|
-
- If the count is ≥ 1, the `--apply` extract
|
|
296
|
+
- If the count is ≥ 1, the `--apply` extract writes one markdown per block **whose target name the store does not already hold**, then regenerates `index.json`. A block whose name (the title, lowercased, with every run of non-letter/non-digit characters collapsed to `-`) already names a stored file is **skipped, not overwritten** — and the envelope says so: one `warnings[]` line per skipped block, plus a closing line giving both counts. So read `warnings[]` and compare `writtenFiles` with `plannedWrites` before reporting the sediment complete; `writtenFiles` shorter than `plannedWrites` with `warnings: []` is the case that used to be indistinguishable from success. The user sees the durable persistence; that is the entire point of this step.
|
|
296
297
|
|
|
297
298
|
This rule is the skill-side half of the **Skill is primary, CLI is auxiliary** contract: the LLM is responsible for embedding blocks (skill prompt, no CLI can decide what is stable), and the CLI is responsible for atomic persistence (`peaks memory extract --apply`, single shot, structured JSON envelope).
|
|
298
299
|
|
|
@@ -8,7 +8,7 @@ description: |
|
|
|
8
8
|
visibility: internal
|
|
9
9
|
---
|
|
10
10
|
|
|
11
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
11
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
12
12
|
|
|
13
13
|
## Loop hygiene (every turn — MANDATORY)
|
|
14
14
|
|
|
@@ -381,8 +381,8 @@ UI sub-agents follow the same G7 metadata-only + G8.6 share protocol. UI artifac
|
|
|
381
381
|
|
|
382
382
|
For worktree operations, use ONLY:
|
|
383
383
|
|
|
384
|
-
- `peaks worktree spawn --rid <rid> --
|
|
385
|
-
- until then: `peaks worktree auth grant --
|
|
384
|
+
- `peaks worktree spawn --rid <rid> --role <role> --purpose <text>` (after rid-L2-extended ships)
|
|
385
|
+
- until then: `peaks worktree auth grant --operation <op> --reason <text>` (`<op>`, e.g. `git-worktree` | `agent-isolation-worktree`)
|
|
386
386
|
|
|
387
387
|
The superpowers skills remain available as REFERENCE material for brainstorming / planning techniques, but MUST NOT be used as a workflow. peaks-ui's own UI artifacts (`.peaks/_runtime/<sessionId>/ui/<artifact>.md`) are authoritative. Full design: `skills/peaks-code/references/worktree-governance.md`.
|
|
388
388
|
|
|
@@ -3,7 +3,7 @@ name: peaks-audit
|
|
|
3
3
|
description: Gate autonomous LLM work on a 6-dimension audit + user-accepted goal. Use IMMEDIATELY after a need is expressed, BEFORE any PRD/RD/QA work starts.
|
|
4
4
|
---
|
|
5
5
|
|
|
6
|
-
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all
|
|
6
|
+
<!-- peaks:loop-hygiene — HAND-MAINTAINED block, NOT generated; byte-identical in every SKILL.md, enforced by tests/unit/skills/loop-hygiene-block.test.ts. Edit one, edit all 23. -->
|
|
7
7
|
|
|
8
8
|
## Loop hygiene (every turn — MANDATORY)
|
|
9
9
|
|
|
@@ -51,6 +51,34 @@ The `.peaks/` workspace is partitioned by a **single scope axis** (session-id, a
|
|
|
51
51
|
|
|
52
52
|
**None.** `peaks-audit` is the entry point; no other peaks-* skill runs first. If the user hands you a raw need with no accepted goal, audit it before doing anything else.
|
|
53
53
|
|
|
54
|
+
## Lane routing — ask once per request, at this entry
|
|
55
|
+
|
|
56
|
+
If every peaks-* workflow enters here, then this is where the lane question belongs: a need reaches `peaks-audit` before it reaches any other peaks-* skill, whichever words the user used to express it. The question — the full workflow (`peaks-code`) or the fast lane (`peaks-race-code`) — is answered by the user, and is never presumed by the LLM on their behalf.
|
|
57
|
+
|
|
58
|
+
| Situation | Behaviour |
|
|
59
|
+
|---|---|
|
|
60
|
+
| The user named no skill — just a need, in their own words | Ask once with `AskUserQuestion`. **No option is preselected.** |
|
|
61
|
+
| The user named a skill (`/peaks-code`, `/peaks-race-code`) | Ask once, with **the named lane preselected**: one Enter passes, and choosing the other lane stays available. |
|
|
62
|
+
| The question has already been answered for this request | Do not ask again. |
|
|
63
|
+
| This session is already locked to a lane | Do not ask again. |
|
|
64
|
+
|
|
65
|
+
**The phase rewrites the first two rows of that table, and nothing else.** Which of the two branches is in force is read from the tracked file `.peaks/race/lane-phase.json` and stated nowhere else in this file — what follows gives the rule for either value rather than asserting a value, so no sentence here can drift from it:
|
|
66
|
+
|
|
67
|
+
| `.peaks/race/lane-phase.json` says | Behaviour |
|
|
68
|
+
|---|---|
|
|
69
|
+
| `name-only` | **Do not ask.** An unnamed need runs the full workflow (`peaks-code`), and a named skill is respected without being questioned. The question would be **malformed rather than merely unhelpful** here: with the fast lane absent from its options it carries a single answer, and `AskUserQuestion` requires two to four — so do not re-add it to "be safe", as its absence is the design, not an oversight. |
|
|
70
|
+
| `offered-by-default` | The table above applies in full: ask even when a skill was named, with that one preselected, and the fast lane is one of the offered options. |
|
|
71
|
+
|
|
72
|
+
That file is **authoritative**, and it may hold exactly one key, `phase`, with exactly one of those two values: `src/services/race/lane-phase.ts` reads it and refuses anything else, and `tests/unit/skills/race-lane-phase-gate.test.ts` judges the value against the tracked evidence before this lane may be offered. Moving the phase means moving that one value, with the evidence behind it — and leaving it at `offered-by-default` while its evidence does not pass turns that guard red.
|
|
73
|
+
|
|
74
|
+
Clearing the pilot is a separate, explicit project decision — a real-task trial with no severe regression — and not something to read off a green test run. It is recorded by moving that value to `offered-by-default`; whatever the file names is what binds.
|
|
75
|
+
|
|
76
|
+
**There is no silent lane.** `peaks-race-code` starts only on the user's word: they named it, or they picked it when the question was asked. Never answer that question for them, and where it applies and they have not answered it, hold there rather than choosing a lane on their behalf.
|
|
77
|
+
|
|
78
|
+
**Mid-task, suggest; never re-ask.** When a closer look shows the task is heavier than it looked, say so in one sentence and let the user keep going — "this is past what the fast lane is for; want the full workflow instead?" A suggestion, not a popup and not a gate, and the user may ignore it.
|
|
79
|
+
|
|
80
|
+
What may take the fast lane at all is not decided here. The changes that do not belong in one, and what "done" means once one does, are stated once in `../peaks-code/references/fast-lane-norm.md`; read them there rather than from this file, and do not restate them here.
|
|
81
|
+
|
|
54
82
|
## Hard contract — invoke IMMEDIATELY
|
|
55
83
|
|
|
56
84
|
When a workflow surfaces a human need (a sentence, a ticket summary, a voice note, a vague "I want X"), call `peaks-audit` BEFORE any other skill:
|