peaks-loop 4.1.4 → 4.1.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/marketplace.json +7 -2
- package/CHANGELOG.md +148 -0
- package/README-en.md +47 -183
- package/README.md +24 -188
- package/dist/cli/cli-helpers.d.ts +20 -0
- package/dist/cli/cli-helpers.js +34 -0
- package/dist/cli/commands/_register.js +2 -0
- package/dist/cli/commands/best-practice-scan-command.d.ts +11 -6
- package/dist/cli/commands/best-practice-scan-command.js +35 -20
- package/dist/cli/commands/best-practice-scan-helpers.d.ts +47 -0
- package/dist/cli/commands/best-practice-scan-helpers.js +88 -5
- package/dist/cli/commands/best-practice-scan-lookup-results.d.ts +13 -0
- package/dist/cli/commands/best-practice-scan-lookup-results.js +237 -0
- package/dist/cli/commands/code-commands.d.ts +6 -4
- package/dist/cli/commands/code-commands.js +6 -4
- package/dist/cli/commands/code-gate-command.d.ts +5 -5
- package/dist/cli/commands/code-gate-command.js +49 -9
- package/dist/cli/commands/code-mode-gate-plan-command.d.ts +1 -1
- package/dist/cli/commands/code-mode-gate-plan-command.js +2 -2
- package/dist/cli/commands/core/memory-extract-command.js +10 -5
- package/dist/cli/commands/dispatch-cli-invocation-check.d.ts +108 -0
- package/dist/cli/commands/dispatch-cli-invocation-check.js +87 -0
- package/dist/cli/commands/dispatch-cli-invocation-scan.d.ts +66 -0
- package/dist/cli/commands/dispatch-cli-invocation-scan.js +162 -0
- package/dist/cli/commands/dispatch-command-spec.js +1 -1
- package/dist/cli/commands/dispatch-commands.js +12 -5
- package/dist/cli/commands/dispatch-isolation-lease.d.ts +1 -1
- package/dist/cli/commands/dispatch-isolation-lease.js +6 -53
- package/dist/cli/commands/dispatch-preflight.js +46 -0
- package/dist/cli/commands/dispatch-prompt-blocks.d.ts +1 -1
- package/dist/cli/commands/dispatch-prompt-composition.d.ts +7 -1
- package/dist/cli/commands/dispatch-prompt-composition.js +29 -7
- package/dist/cli/commands/dispatch-record-write.d.ts +1 -1
- package/dist/cli/commands/dispatch-tool-call.d.ts +1 -1
- package/dist/cli/commands/doc-commands.js +1 -1
- package/dist/cli/commands/feedback-commands-helpers.js +1 -1
- package/dist/cli/commands/final-review-prepare-command.js +22 -1
- package/dist/cli/commands/gate-commands-enforce.js +3 -3
- package/dist/cli/commands/hook-handle.js +41 -20
- package/dist/cli/commands/lint-commands.js +3 -1
- package/dist/cli/commands/loop-eval-capture-index.js +2 -4
- package/dist/cli/commands/openspec-command-shared.js +2 -2
- package/dist/cli/commands/perf-audit-commands.js +15 -5
- package/dist/cli/commands/project-commands.js +9 -6
- package/dist/cli/commands/race-commands.d.ts +15 -0
- package/dist/cli/commands/race-commands.js +65 -0
- package/dist/cli/commands/race-pilot-gate-record-command.d.ts +3 -0
- package/dist/cli/commands/race-pilot-gate-record-command.js +81 -0
- package/dist/cli/commands/request-command-options.d.ts +8 -0
- package/dist/cli/commands/request-commands.js +2 -0
- package/dist/cli/commands/request-init-command.js +67 -12
- package/dist/cli/commands/{vm-status-command.d.ts → request-retag-command.d.ts} +1 -1
- package/dist/cli/commands/request-retag-command.js +50 -0
- package/dist/cli/commands/request-show-command.d.ts +8 -0
- package/dist/cli/commands/request-show-command.js +14 -1
- package/dist/cli/commands/request-transition-command.js +12 -4
- package/dist/cli/commands/request-transition-failures.d.ts +14 -0
- package/dist/cli/commands/request-transition-failures.js +76 -7
- package/dist/cli/commands/request-transition-preflight.js +1 -1
- package/dist/cli/commands/scan-scope-commands.js +2 -2
- package/dist/cli/commands/security-audit-commands.js +26 -6
- package/dist/cli/commands/slice-decompose-artifacts.js +2 -1
- package/dist/cli/commands/verdict-aggregate-command.js +2 -1
- package/dist/cli/commands/workflow-gate-commands.js +4 -4
- package/dist/cli/commands/worktree-lease-gc-command.js +1 -1
- package/dist/cli/program.js +0 -2
- package/dist/services/artifacts/artifact-contract-block.d.ts +53 -0
- package/dist/services/artifacts/artifact-contract-block.js +231 -0
- package/dist/services/artifacts/artifact-prerequisites.d.ts +27 -19
- package/dist/services/artifacts/artifact-prerequisites.js +65 -135
- package/dist/services/artifacts/artifact-templates.d.ts +1 -1
- package/dist/services/artifacts/artifact-templates.js +17 -10
- package/dist/services/artifacts/prerequisite-checks.d.ts +87 -0
- package/dist/services/artifacts/prerequisite-checks.js +198 -0
- package/dist/services/artifacts/prerequisite-transition-event.d.ts +20 -0
- package/dist/services/artifacts/prerequisite-transition-event.js +27 -0
- package/dist/services/artifacts/rd-transition-gates.d.ts +33 -0
- package/dist/services/artifacts/rd-transition-gates.js +71 -0
- package/dist/services/artifacts/request-artifact-metadata.d.ts +31 -0
- package/dist/services/artifacts/request-artifact-metadata.js +44 -0
- package/dist/services/artifacts/request-artifact-service.d.ts +5 -0
- package/dist/services/artifacts/request-artifact-service.js +43 -69
- package/dist/services/artifacts/request-artifact-state-helpers.d.ts +21 -1
- package/dist/services/artifacts/request-artifact-state-helpers.js +34 -8
- package/dist/services/artifacts/request-retag-service.d.ts +68 -0
- package/dist/services/artifacts/request-retag-service.js +125 -0
- package/dist/services/artifacts/request-state-order.d.ts +38 -0
- package/dist/services/artifacts/request-state-order.js +99 -0
- package/dist/services/artifacts/request-type-demand.d.ts +44 -0
- package/dist/services/artifacts/request-type-demand.js +71 -0
- package/dist/services/audit/audit-goal-service.d.ts +7 -0
- package/dist/services/audit/enforcers/active-skill-resolver.d.ts +18 -0
- package/dist/services/audit/enforcers/active-skill-resolver.js +48 -1
- package/dist/services/audit/enforcers/code-ban.d.ts +11 -2
- package/dist/services/audit/enforcers/code-ban.js +21 -1
- package/dist/services/audit/red-line-catalog-p2-a-bee-runtime.d.ts +17 -0
- package/dist/services/audit/red-line-catalog-p2-a-bee-runtime.js +24 -7
- package/dist/services/audit-independent/handoff-missing-refusal.d.ts +26 -0
- package/dist/services/audit-independent/handoff-missing-refusal.js +109 -0
- package/dist/services/audit-independent/handoff-readers.d.ts +37 -0
- package/dist/services/audit-independent/handoff-readers.js +81 -0
- package/dist/services/audit-independent/index.d.ts +6 -1
- package/dist/services/audit-independent/index.js +6 -1
- package/dist/services/audit-independent/judged-declaration-build.d.ts +48 -0
- package/dist/services/audit-independent/judged-declaration-build.js +73 -0
- package/dist/services/audit-independent/judged-declaration-check.d.ts +80 -0
- package/dist/services/audit-independent/judged-declaration-check.js +216 -0
- package/dist/services/audit-independent/judged-declaration.d.ts +94 -0
- package/dist/services/audit-independent/judged-declaration.js +218 -0
- package/dist/services/audit-independent/perf-audit-service.js +12 -14
- package/dist/services/audit-independent/security-audit-artifact.d.ts +28 -0
- package/dist/services/audit-independent/security-audit-artifact.js +90 -0
- package/dist/services/audit-independent/security-audit-service.d.ts +6 -53
- package/dist/services/audit-independent/security-audit-service.js +34 -178
- package/dist/services/capability-guard-runner/contracts/J05.js +60 -14
- package/dist/services/codegraph/codegraph-index-integrity.js +2 -0
- package/dist/services/context/build-dispatch-system-prompt.d.ts +8 -12
- package/dist/services/context/build-dispatch-system-prompt.js +18 -18
- package/dist/services/context/collector.js +5 -1
- package/dist/services/context/post-compact-reinjection.js +1 -1
- package/dist/services/dispatch/active-dispatch-index.d.ts +36 -0
- package/dist/services/dispatch/active-dispatch-index.js +118 -0
- package/dist/services/dispatch/batch-counter.js +1 -2
- package/dist/services/dispatch/dispatch-record-writer.d.ts +29 -16
- package/dist/services/dispatch/dispatch-record-writer.js +58 -100
- package/dist/services/dispatch/dispatch-sub-agent.js +1 -1
- package/dist/services/dispatch/karpathy-block.d.ts +55 -0
- package/dist/services/dispatch/karpathy-block.js +101 -0
- package/dist/services/dispatch/ledger-reaper.d.ts +80 -0
- package/dist/services/dispatch/ledger-reaper.js +131 -0
- package/dist/services/dispatch/test-tool-detection.d.ts +17 -1
- package/dist/services/dispatch/test-tool-detection.js +12 -1
- package/dist/services/evidence/evidence-generator.js +23 -12
- package/dist/services/feedback/feedback-promotion-service.d.ts +8 -11
- package/dist/services/feedback/feedback-promotion-service.js +30 -35
- package/dist/services/feedback/promotion-artifact-json-evidence.d.ts +18 -0
- package/dist/services/feedback/promotion-artifact-missing.d.ts +22 -0
- package/dist/services/feedback/promotion-artifact-missing.js +63 -0
- package/dist/services/final-review/final-review-contract.d.ts +95 -4
- package/dist/services/final-review/final-review-contract.js +64 -0
- package/dist/services/final-review/final-review-delivery.d.ts +13 -0
- package/dist/services/final-review/final-review-delivery.js +26 -12
- package/dist/services/final-review/final-review-evidence-collect.js +8 -53
- package/dist/services/final-review/final-review-evidence-records.d.ts +21 -0
- package/dist/services/final-review/final-review-evidence-records.js +67 -0
- package/dist/services/final-review/final-review-evidence-sources.d.ts +22 -0
- package/dist/services/final-review/final-review-evidence-sources.js +28 -4
- package/dist/services/final-review/final-review-prompt.js +19 -6
- package/dist/services/final-review/final-review-runner.js +5 -0
- package/dist/services/final-review/final-review-service.d.ts +2 -2
- package/dist/services/final-review/index.d.ts +1 -1
- package/dist/services/final-review/pre-post-diff.d.ts +2 -75
- package/dist/services/final-review/pre-post-diff.js +60 -59
- package/dist/services/hooks/pre-tool-code-gate.d.ts +7 -1
- package/dist/services/hooks/pre-tool-code-gate.js +21 -2
- package/dist/services/hooks/worktree-authorization-gate.js +6 -31
- package/dist/services/hooks/worktree-refusal-messages.d.ts +74 -0
- package/dist/services/hooks/worktree-refusal-messages.js +102 -0
- package/dist/services/lint/eslint-runner-support.d.ts +1 -1
- package/dist/services/lint/eslint-runner-support.js +2 -1
- package/dist/services/lint/eslint-runner-types.d.ts +8 -0
- package/dist/services/lint/eslint-runner.js +17 -4
- package/dist/services/llm/anthropic-runner.js +24 -7
- package/dist/services/loop/loop-observability.d.ts +39 -0
- package/dist/services/loop/loop-observability.js +55 -0
- package/dist/services/loop/monotonic-guard.js +6 -9
- package/dist/services/loop/monotonic-runner.js +8 -7
- package/dist/services/loop/run-driver.js +18 -22
- package/dist/services/memory/project-memory-service/index/kind-dispatch.js +14 -1
- package/dist/services/memory/project-memory-service/index/project-memory-plan-exec.js +13 -2
- package/dist/services/memory/project-memory-service/index.d.ts +2 -2
- package/dist/services/memory/project-memory-service/index.js +1 -1
- package/dist/services/memory/project-memory-service/parsers/frontmatter-parse.d.ts +36 -0
- package/dist/services/memory/project-memory-service/parsers/frontmatter-parse.js +48 -2
- package/dist/services/memory/project-memory-service/parsers/markdown-pure.d.ts +23 -1
- package/dist/services/memory/project-memory-service/parsers/markdown-pure.js +37 -0
- package/dist/services/memory/project-memory-service/types.d.ts +32 -0
- package/dist/services/observability/observability-service.d.ts +7 -0
- package/dist/services/observability/observability-service.js +2 -1
- package/dist/services/openspec/coverage-evidence-reader.d.ts +9 -9
- package/dist/services/openspec/coverage-evidence-reader.js +8 -8
- package/dist/services/openspec/openspec-archive-service.d.ts +1 -1
- package/dist/services/openspec/openspec-archive-service.js +6 -6
- package/dist/services/prd/gate-evidence-derivation.d.ts +4 -3
- package/dist/services/prd/gate-evidence-derivation.js +4 -3
- package/dist/services/qa/bdd-test-style-verifier.js +22 -8
- package/dist/services/race/gate2-evaluator.d.ts +58 -0
- package/dist/services/race/gate2-evaluator.js +111 -0
- package/dist/services/race/gate2-policy.d.ts +17 -0
- package/dist/services/race/gate2-policy.js +31 -0
- package/dist/services/race/lane-phase.d.ts +19 -0
- package/dist/services/race/lane-phase.js +113 -0
- package/dist/services/race/pilot-gate-store.d.ts +67 -0
- package/dist/services/race/pilot-gate-store.js +227 -0
- package/dist/services/scan/file-size-baseline.d.ts +33 -0
- package/dist/services/scan/file-size-baseline.js +173 -0
- package/dist/services/scan/file-size-scan.d.ts +35 -3
- package/dist/services/scan/file-size-scan.js +63 -42
- package/dist/services/scan/type-corroboration.d.ts +32 -0
- package/dist/services/scan/type-corroboration.js +51 -0
- package/dist/services/scan/type-sanity-service.d.ts +14 -0
- package/dist/services/scan/type-sanity-service.js +23 -22
- package/dist/services/security/safe-settings-path.d.ts +5 -0
- package/dist/services/security/safe-settings-path.js +64 -8
- package/dist/services/skill/resume-detector.js +11 -11
- package/dist/services/skills/hooks-codegate-superpowers.d.ts +5 -6
- package/dist/services/skills/hooks-codegate-superpowers.js +7 -8
- package/dist/services/skills/hooks-settings-service.d.ts +1 -1
- package/dist/services/skills/hooks-settings-service.js +1 -1
- package/dist/services/skills/presence-lease-order.d.ts +13 -0
- package/dist/services/skills/presence-lease-order.js +24 -0
- package/dist/services/skills/skill-conformance-service.js +1 -0
- package/dist/services/skills/skill-statusline-service.js +4 -7
- package/dist/services/slice/slice-check-service.js +8 -8
- package/dist/services/workflow/pipeline-verify-gate-support.d.ts +24 -8
- package/dist/services/workflow/pipeline-verify-gate-support.js +34 -39
- package/dist/services/workflow/pipeline-verify-qa-phase.d.ts +102 -0
- package/dist/services/workflow/pipeline-verify-qa-phase.js +176 -0
- package/dist/services/workflow/pipeline-verify-service.js +27 -28
- package/dist/services/workflow/request-type-resolution.d.ts +99 -0
- package/dist/services/workflow/request-type-resolution.js +130 -0
- package/dist/services/workflow/workflow-skip-service.d.ts +1 -20
- package/dist/services/workflow/workflow-skip-service.js +22 -25
- package/dist/services/workflow/workflow-state-store.d.ts +9 -0
- package/dist/services/workflow/workflow-state-store.js +26 -1
- package/dist/services/workspace/claude-settings-retirements.d.ts +54 -0
- package/dist/services/workspace/claude-settings-retirements.js +112 -0
- package/dist/services/workspace/claude-settings-template-merge.d.ts +35 -15
- package/dist/services/workspace/claude-settings-template-merge.js +33 -53
- package/dist/services/workspace/claude-settings-template.d.ts +62 -12
- package/dist/services/workspace/claude-settings-template.js +58 -58
- package/dist/services/workspace/migrate-1-4-1-service.js +3 -0
- package/dist/services/workspace/reconcile-service.js +0 -1
- package/dist/shared/incrementing-number.d.ts +33 -2
- package/dist/shared/incrementing-number.js +72 -3
- package/package.json +5 -7
- package/skills/bee/peaks-perf-audit/SKILL.md +1 -1
- package/skills/bee/peaks-prd/SKILL.md +4 -3
- package/skills/bee/peaks-qa/SKILL.md +1 -1
- package/skills/bee/peaks-qa/references/qa-sub-agent-dispatch.md +2 -2
- package/skills/bee/peaks-qa/references/qa-transition-gates.md +1 -1
- package/skills/bee/peaks-rd/SKILL.md +2 -2
- package/skills/bee/peaks-rd/references/rd-fanout-contracts.md +1 -1
- package/skills/bee/peaks-rd/references/rd-sub-agent-dispatch.md +8 -4
- package/skills/bee/peaks-rd/references/rd-transition-gates.md +3 -3
- package/skills/bee/peaks-rd/references/v2-12-fanout-collapse.md +2 -2
- package/skills/bee/peaks-rd/references/writing-handoff-frontmatter.md +1 -1
- package/skills/bee/peaks-reviewer/SKILL.md +1 -1
- package/skills/bee/peaks-sc/SKILL.md +1 -1
- package/skills/bee/peaks-security-audit/SKILL.md +10 -2
- package/skills/bee/peaks-txt/SKILL.md +4 -3
- package/skills/bee/peaks-ui/SKILL.md +3 -3
- package/skills/peaks-audit/SKILL.md +29 -1
- package/skills/peaks-code/SKILL.md +37 -17
- package/skills/peaks-code/references/fast-lane-norm.md +42 -0
- package/skills/peaks-code/references/fast-mode.md +3 -2
- package/skills/peaks-code/references/local-artifact-workspace.md +3 -3
- package/skills/peaks-code/references/micro-cycle.md +3 -3
- package/skills/peaks-code/references/resume-detection.md +1 -1
- package/skills/peaks-code/references/runbook.md +12 -6
- package/skills/peaks-code/references/step-11-memory-sediment.md +4 -0
- package/skills/peaks-code/references/sub-agent-dispatch.md +1 -1
- package/skills/peaks-code/references/swarm-dispatch-contract.md +40 -16
- package/skills/peaks-code/references/workflow-gates-and-types.md +6 -6
- package/skills/peaks-code/references/worktree-governance.md +4 -4
- package/skills/peaks-content/SKILL.md +1 -1
- package/skills/peaks-doctor/SKILL.md +1 -1
- package/skills/peaks-final-review/SKILL.md +31 -11
- package/skills/peaks-ide/SKILL.md +1 -1
- package/skills/peaks-issue-fix-orchestrator/SKILL.md +1 -1
- package/skills/peaks-race-code/SKILL.md +185 -0
- package/skills/peaks-resume/SKILL.md +1 -1
- package/skills/peaks-slice-decompose/SKILL.md +1 -1
- package/skills/peaks-solo/SKILL.md +1 -1
- package/skills/peaks-sop/SKILL.md +1 -1
- package/skills/peaks-status/SKILL.md +1 -1
- package/skills/peaks-test/SKILL.md +7 -4
- package/dist/cli/commands/vm-command-shared.d.ts +0 -23
- package/dist/cli/commands/vm-command-shared.js +0 -23
- package/dist/cli/commands/vm-commands.d.ts +0 -3
- package/dist/cli/commands/vm-commands.js +0 -45
- package/dist/cli/commands/vm-hypervisor-probe.d.ts +0 -27
- package/dist/cli/commands/vm-hypervisor-probe.js +0 -78
- package/dist/cli/commands/vm-hypervisor-runtime.d.ts +0 -15
- package/dist/cli/commands/vm-hypervisor-runtime.js +0 -64
- package/dist/cli/commands/vm-release-command.d.ts +0 -5
- package/dist/cli/commands/vm-release-command.js +0 -101
- package/dist/cli/commands/vm-spawn-command.d.ts +0 -5
- package/dist/cli/commands/vm-spawn-command.js +0 -177
- package/dist/cli/commands/vm-status-command.js +0 -50
- package/dist/services/audit/enforcers/lint-peaks-skill-runtime.d.ts +0 -23
- package/dist/services/audit/enforcers/lint-peaks-skill-runtime.js +0 -64
- package/dist/services/vm/vm-lease.d.ts +0 -40
- package/dist/services/vm/vm-lease.js +0 -160
|
@@ -46,58 +46,7 @@
|
|
|
46
46
|
import { execFileSync } from 'node:child_process';
|
|
47
47
|
import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
|
|
48
48
|
import { dirname, join } from 'node:path';
|
|
49
|
-
|
|
50
|
-
export const API_DIFF_ARTIFACT_SEGMENTS = ['final-review', 'api-diff.txt'];
|
|
51
|
-
/**
|
|
52
|
-
* The literal that opens the artifact's conclusion line.
|
|
53
|
-
*
|
|
54
|
-
* Exported because the consumer must be able to test for the CONCLUSION, not
|
|
55
|
-
* for a byte count (F-BLOCK-1BYTE): one byte of `api-diff.txt` satisfied
|
|
56
|
-
* "status: found" while conveying nothing, and the delivery gate it fed then let
|
|
57
|
-
* a `pass` stand on a comparison nobody saw. The producer writes the line this
|
|
58
|
-
* marker opens and `final-review-service.ts` requires it in the delivered
|
|
59
|
-
* bytes, so the two cannot drift apart into the same hole again.
|
|
60
|
-
*/
|
|
61
|
-
export const PRE_POST_DIFF_VERDICT_MARKER = 'VERDICT: ';
|
|
62
|
-
/**
|
|
63
|
-
* The three conclusions the artifact may open with, exported as the same
|
|
64
|
-
* literals the writer interpolates below.
|
|
65
|
-
*
|
|
66
|
-
* They are constants because reading the conclusion is now part of the
|
|
67
|
-
* consumer's job (F2): the pre/post-diff source is the one source whose
|
|
68
|
-
* conclusion had a machine-readable form all along, and the envelope threw it
|
|
69
|
-
* away — a delivered `STRUCTURAL DRIFT DETECTED` produced `allPass: true` with
|
|
70
|
-
* an empty `needsAttention`. A consumer that must classify the conclusion may
|
|
71
|
-
* only do so against the producer's own literals, never against a re-typed
|
|
72
|
-
* copy of them.
|
|
73
|
-
*/
|
|
74
|
-
export const PRE_POST_DIFF_NO_DRIFT = 'NO STRUCTURAL DRIFT';
|
|
75
|
-
export const PRE_POST_DIFF_ADDITIONS_ONLY = 'ADDITIONS ONLY';
|
|
76
|
-
export const PRE_POST_DIFF_DRIFT_DETECTED = 'STRUCTURAL DRIFT DETECTED';
|
|
77
|
-
/**
|
|
78
|
-
* Classify the delivered conclusion. Pure and total: a caller passes the bytes
|
|
79
|
-
* it received (possibly a head slice) and gets back what the artifact says.
|
|
80
|
-
*
|
|
81
|
-
* Only the FIRST `VERDICT:` line is read. The artifact's header promises the
|
|
82
|
-
* verdict "is repeated nowhere" and that it is the file's conclusion, so a
|
|
83
|
-
* later line cannot be the answer, and reading further would let a document's
|
|
84
|
-
* prose masquerade as its conclusion.
|
|
85
|
-
*/
|
|
86
|
-
export function classifyPrePostDiffVerdict(content) {
|
|
87
|
-
const line = content
|
|
88
|
-
.split(/\r?\n/)
|
|
89
|
-
.find((candidate) => candidate.startsWith(PRE_POST_DIFF_VERDICT_MARKER));
|
|
90
|
-
if (line === undefined)
|
|
91
|
-
return 'indeterminate';
|
|
92
|
-
const conclusion = line.slice(PRE_POST_DIFF_VERDICT_MARKER.length);
|
|
93
|
-
if (conclusion.startsWith(PRE_POST_DIFF_DRIFT_DETECTED))
|
|
94
|
-
return 'drift-detected';
|
|
95
|
-
if (conclusion.startsWith(PRE_POST_DIFF_ADDITIONS_ONLY))
|
|
96
|
-
return 'additions-only';
|
|
97
|
-
if (conclusion.startsWith(PRE_POST_DIFF_NO_DRIFT))
|
|
98
|
-
return 'no-drift';
|
|
99
|
-
return 'indeterminate';
|
|
100
|
-
}
|
|
49
|
+
import { API_DIFF_ARTIFACT_SEGMENTS, PRE_POST_DIFF_VERDICT_MARKER, PRE_POST_DIFF_NO_DRIFT, PRE_POST_DIFF_ADDITIONS_ONLY, PRE_POST_DIFF_DRIFT_DETECTED } from './final-review-contract.js';
|
|
101
50
|
/** Test-file globs — the single definition both the file count and the case
|
|
102
51
|
* count use, so the two can never disagree about what a "test file" is. */
|
|
103
52
|
export const TEST_FILE_GLOBS = ['*.test.ts', '*.test.tsx', '*.spec.ts', '*.spec.tsx'];
|
|
@@ -158,6 +107,19 @@ const EXPORT_DECL_RE = /^export\s+(?:declare\s+)?(?:async\s+)?(?:abstract\s+)?(?
|
|
|
158
107
|
const EXPORT_TYPE_LIST_RE = /^export\s+type\s*\{([^}]*)\}/;
|
|
159
108
|
const EXPORT_LIST_RE = /^export\s*\{([^}]*)\}/;
|
|
160
109
|
const EXPORT_DEFAULT_RE = /^export\s+default\b/;
|
|
110
|
+
/**
|
|
111
|
+
* An `export { … }` list OPENED on this line and closed on a LATER one.
|
|
112
|
+
*
|
|
113
|
+
* `EXPORT_LIST_RE` above requires the closing `}` on the same line, so a block
|
|
114
|
+
* written across several lines matched nothing at all. The miss is ASYMMETRIC,
|
|
115
|
+
* which is what makes it a false-positive source rather than a mere blind spot:
|
|
116
|
+
* reformatting a one-line `export { A, B, C };` into a five-line block left the
|
|
117
|
+
* before side binding three names and the after side binding NONE, so `A`, `B`
|
|
118
|
+
* and `C` were reported REMOVED while all three were still exported. A
|
|
119
|
+
* line-oriented reader cannot see such a block, so the statement is accumulated
|
|
120
|
+
* until the line carrying its closing brace (see the diff loop).
|
|
121
|
+
*/
|
|
122
|
+
const EXPORT_LIST_OPEN_RE = /^export\s*(?:type\s*)?\{[^}]*$/;
|
|
161
123
|
/**
|
|
162
124
|
* Run git read-only. Exit code 1 is `grep`-found-nothing and `merge-base`-no-
|
|
163
125
|
* common-ancestor, which are answers rather than failures — every caller
|
|
@@ -475,6 +437,26 @@ export function producePrePostDiff(opts) {
|
|
|
475
437
|
]).stdout;
|
|
476
438
|
const namesAddedByPath = new Map();
|
|
477
439
|
const namesRemovedByPath = new Map();
|
|
440
|
+
/** Record the names one diff line — its `-` / `+` sign already stripped — binds. */
|
|
441
|
+
const recordNames = (sign, text) => {
|
|
442
|
+
const names = extractExportedNames(text);
|
|
443
|
+
if (names.length === 0)
|
|
444
|
+
return;
|
|
445
|
+
const byPath = sign === '-' ? namesRemovedByPath : namesAddedByPath;
|
|
446
|
+
const bucket = byPath.get(currentPath) ?? new Set();
|
|
447
|
+
for (const name of names)
|
|
448
|
+
bucket.add(name);
|
|
449
|
+
byPath.set(currentPath, bucket);
|
|
450
|
+
};
|
|
451
|
+
// An `export { … }` list written across several lines is ONE statement; see
|
|
452
|
+
// `EXPORT_LIST_OPEN_RE`. It is accumulated here, per SIDE, because a unified
|
|
453
|
+
// diff emits every `-` line of a hunk before its `+` lines and the two sides
|
|
454
|
+
// must never be folded into one statement. A side still open when the other
|
|
455
|
+
// side begins — or when the diff ends — is parsed as it stands: with no
|
|
456
|
+
// closing brace it binds no name, which is the UNDER-reporting this module
|
|
457
|
+
// prefers over a manufactured removal.
|
|
458
|
+
let openSign = null;
|
|
459
|
+
let openStatement = '';
|
|
478
460
|
for (const line of diffText.split(/\r?\n/)) {
|
|
479
461
|
if (line.startsWith('+++ ')) {
|
|
480
462
|
currentPath = line.slice(4).replace(/^b\//, '');
|
|
@@ -484,15 +466,31 @@ export function producePrePostDiff(opts) {
|
|
|
484
466
|
continue;
|
|
485
467
|
if (!line.startsWith('-') && !line.startsWith('+'))
|
|
486
468
|
continue;
|
|
487
|
-
const
|
|
488
|
-
|
|
469
|
+
const sign = line.startsWith('-') ? '-' : '+';
|
|
470
|
+
const text = line.slice(1);
|
|
471
|
+
if (openSign !== null && sign === openSign) {
|
|
472
|
+
openStatement += ` ${text.trim()}`;
|
|
473
|
+
if (text.includes('}')) {
|
|
474
|
+
recordNames(sign, openStatement);
|
|
475
|
+
openSign = null;
|
|
476
|
+
openStatement = '';
|
|
477
|
+
}
|
|
489
478
|
continue;
|
|
490
|
-
|
|
491
|
-
|
|
492
|
-
|
|
493
|
-
|
|
494
|
-
|
|
479
|
+
}
|
|
480
|
+
if (openSign !== null) {
|
|
481
|
+
recordNames(openSign, openStatement);
|
|
482
|
+
openSign = null;
|
|
483
|
+
openStatement = '';
|
|
484
|
+
}
|
|
485
|
+
if (EXPORT_LIST_OPEN_RE.test(text)) {
|
|
486
|
+
openSign = sign;
|
|
487
|
+
openStatement = text.trim();
|
|
488
|
+
continue;
|
|
489
|
+
}
|
|
490
|
+
recordNames(sign, text);
|
|
495
491
|
}
|
|
492
|
+
if (openSign !== null)
|
|
493
|
+
recordNames(openSign, openStatement);
|
|
496
494
|
// F6 — a name that appears on BOTH sides of the same file was REWRITTEN or
|
|
497
495
|
// re-listed, not removed: `export { a }` -> `export { a, b }` diffs as
|
|
498
496
|
// `-export { a }` / `+export { a, b }`, and reading the minus side alone
|
|
@@ -666,3 +664,6 @@ export function producePrePostDiff(opts) {
|
|
|
666
664
|
: `Structural removals: ${removals.join('; ')}.`);
|
|
667
665
|
return { status: 'computed', summary, relativePath, absolutePath, content };
|
|
668
666
|
}
|
|
667
|
+
// The artifact's contract now lives in final-review-contract.ts; re-exported so
|
|
668
|
+
// every name that was importable from this module still is.
|
|
669
|
+
export { API_DIFF_ARTIFACT_SEGMENTS, PRE_POST_DIFF_VERDICT_MARKER, PRE_POST_DIFF_NO_DRIFT, PRE_POST_DIFF_ADDITIONS_ONLY, PRE_POST_DIFF_DRIFT_DETECTED, classifyPrePostDiffVerdict } from './final-review-contract.js';
|
|
@@ -41,5 +41,11 @@ export declare function extractFilePath(input: Readonly<Record<string, unknown>>
|
|
|
41
41
|
/**
|
|
42
42
|
* Pure decision function. Given the tool name + input object, return
|
|
43
43
|
* the gate verdict. Tolerates malformed payloads (allow).
|
|
44
|
+
*
|
|
45
|
+
* `driver` is the already-resolved identity of whoever is running the
|
|
46
|
+
* tool call, or `null`/absent when no caller identity resolved. Absent and
|
|
47
|
+
* `null` are the same verdict as before this parameter existed: the
|
|
48
|
+
* hard-blocked families deny. Resolution is the caller's job, so this
|
|
49
|
+
* module keeps no session, lease or filesystem state.
|
|
44
50
|
*/
|
|
45
|
-
export declare function decideGateAction(tool: GateToolName, input: Readonly<Record<string, unknown
|
|
51
|
+
export declare function decideGateAction(tool: GateToolName, input: Readonly<Record<string, unknown>>, driver?: string | null): GateVerdict;
|
|
@@ -37,6 +37,13 @@ export const ALLOW_LISTED_PATH_PATTERNS = [
|
|
|
37
37
|
'CHANGELOG.md',
|
|
38
38
|
'README.md'
|
|
39
39
|
];
|
|
40
|
+
/**
|
|
41
|
+
* The single driver identity that opens the hard-blocked families: the
|
|
42
|
+
* fast-lane skill's name, compared as a whole string. No prefix match and no
|
|
43
|
+
* case folding — a future `peaks-race-<something>` sibling must NOT inherit
|
|
44
|
+
* this write, because the write it opens is source editing.
|
|
45
|
+
*/
|
|
46
|
+
const FAST_LANE_DRIVER = 'peaks-race-code';
|
|
40
47
|
/** Pull the target file path from `input.file_path | input.path | input.notebook_path`. */
|
|
41
48
|
export function extractFilePath(input) {
|
|
42
49
|
for (const key of ['file_path', 'path', 'notebook_path']) {
|
|
@@ -59,8 +66,14 @@ function matchesAny(path, families) {
|
|
|
59
66
|
/**
|
|
60
67
|
* Pure decision function. Given the tool name + input object, return
|
|
61
68
|
* the gate verdict. Tolerates malformed payloads (allow).
|
|
69
|
+
*
|
|
70
|
+
* `driver` is the already-resolved identity of whoever is running the
|
|
71
|
+
* tool call, or `null`/absent when no caller identity resolved. Absent and
|
|
72
|
+
* `null` are the same verdict as before this parameter existed: the
|
|
73
|
+
* hard-blocked families deny. Resolution is the caller's job, so this
|
|
74
|
+
* module keeps no session, lease or filesystem state.
|
|
62
75
|
*/
|
|
63
|
-
export function decideGateAction(tool, input) {
|
|
76
|
+
export function decideGateAction(tool, input, driver) {
|
|
64
77
|
// Only gate Edit / Write / MultiEdit.
|
|
65
78
|
if (tool !== 'Edit' && tool !== 'Write' && tool !== 'MultiEdit') {
|
|
66
79
|
return { action: 'allow' };
|
|
@@ -72,7 +85,7 @@ export function decideGateAction(tool, input) {
|
|
|
72
85
|
// handles file paths only.
|
|
73
86
|
return { action: 'allow' };
|
|
74
87
|
}
|
|
75
|
-
// Allow-list check first — short-circuits any deny.
|
|
88
|
+
// Allow-list check first — short-circuits any deny, for every driver.
|
|
76
89
|
const allowMatch = matchesAny(filePath, ALLOW_LISTED_PATH_PATTERNS);
|
|
77
90
|
if (allowMatch !== null) {
|
|
78
91
|
return { action: 'allow' };
|
|
@@ -80,6 +93,12 @@ export function decideGateAction(tool, input) {
|
|
|
80
93
|
// Hard-blocked family check.
|
|
81
94
|
const denyMatch = matchesAny(filePath, HARD_BLOCKED_PATH_FAMILIES);
|
|
82
95
|
if (denyMatch !== null) {
|
|
96
|
+
// A driver that is not the fast lane falls through to the same deny a
|
|
97
|
+
// two-argument call produces, so an unresolvable identity can never
|
|
98
|
+
// become a silent pass.
|
|
99
|
+
if (driver === FAST_LANE_DRIVER) {
|
|
100
|
+
return { action: 'allow' };
|
|
101
|
+
}
|
|
83
102
|
const reason = `${denyMatch} (orchestrator's hard-blocked path family)`;
|
|
84
103
|
const message = `PEAKS_CODE_PROHIBITED_DIRECT_EDIT: ${filePath} matches hard-blocked path family ${reason}; ` +
|
|
85
104
|
`orchestrator MUST NOT Edit/Write these directly. Use: peaks sub-agent dispatch rd --prompt '<your task>' --request-id <rid> --project . --batch-id <uuid>`;
|
|
@@ -37,6 +37,7 @@ import { dirname, join } from 'node:path';
|
|
|
37
37
|
import { deserializeLease, isLeaseActive, leaseFilePath } from '../worktree/worktree-lease.js';
|
|
38
38
|
import { readDispatchProvenance } from '../worktree/dispatch-provenance.js';
|
|
39
39
|
import { containerLeaseFilePath, deserializeContainerLease, isContainerLeaseActive } from '../container/container-lease.js';
|
|
40
|
+
import { consumedGrantsDenial, expiredGrantsDenial, noAuthorizationDenial, noGrantForOperationDenial, requestMismatchDenial } from './worktree-refusal-messages.js';
|
|
40
41
|
export const WORKTREE_AUTH_FILE = 'worktree-auth.json';
|
|
41
42
|
/** Stable identifier of the current "user authorization" — derived from session + tool + key args. */
|
|
42
43
|
export function currentAuthFingerprint(input) {
|
|
@@ -165,13 +166,7 @@ export function classifyToolCall(input) {
|
|
|
165
166
|
*/
|
|
166
167
|
export function decideFromAuthorization(input, operation, file) {
|
|
167
168
|
if (file === null) {
|
|
168
|
-
return
|
|
169
|
-
allow: false,
|
|
170
|
-
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
171
|
-
reason: `No current-task user authorization for "${operation}" (session=${input.sessionId}).`,
|
|
172
|
-
remediation: `Ask the user to explicitly authorize this worktree-mutating operation, then run \`peaks worktree auth grant --operation ${operation} --reason "<why>"\` ` +
|
|
173
|
-
`before the tool call retries. Re-running with --consume=false and a longer --ttl is allowed but should be rare.`
|
|
174
|
-
};
|
|
169
|
+
return noAuthorizationDenial(operation, input.sessionId);
|
|
175
170
|
}
|
|
176
171
|
const now = Date.now();
|
|
177
172
|
// First try to find a requestId-matched, non-consumed, unexpired grant. If none is found,
|
|
@@ -193,41 +188,21 @@ export function decideFromAuthorization(input, operation, file) {
|
|
|
193
188
|
// No live grant matched the current rid (or the caller's rid is null). Diagnose why.
|
|
194
189
|
const sameOpAnyState = file.grants.filter((g) => g.operation === operation);
|
|
195
190
|
if (sameOpAnyState.length === 0) {
|
|
196
|
-
return
|
|
197
|
-
allow: false,
|
|
198
|
-
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
199
|
-
reason: `No grant for operation "${operation}" in this session.`,
|
|
200
|
-
remediation: `Run \`peaks worktree auth grant --operation ${operation} --reason "<why>"\` from the LLM after the user has explicitly asked for the operation.`
|
|
201
|
-
};
|
|
191
|
+
return noGrantForOperationDenial(operation);
|
|
202
192
|
}
|
|
203
193
|
const ridScoped = sameOpAnyState.find((g) => g.requestId !== null);
|
|
204
194
|
const ridMatchesScope = ridScoped !== undefined &&
|
|
205
195
|
(input.requestId === null || ridScoped.requestId === input.requestId);
|
|
206
196
|
if (ridScoped !== undefined && !ridMatchesScope) {
|
|
207
|
-
return
|
|
208
|
-
allow: false,
|
|
209
|
-
code: 'WORKTREE_USER_AUTH_REQUEST_MISMATCH',
|
|
210
|
-
reason: `Grant for "${operation}" is scoped to requestId=${ridScoped.requestId} but the current tool call carries requestId=${input.requestId ?? 'null'}.`,
|
|
211
|
-
remediation: `Either drop the requestId scope from the grant (\`peaks worktree auth grant --operation ${operation} --no-request-id\`) or operate under the scoped request.`
|
|
212
|
-
};
|
|
197
|
+
return requestMismatchDenial(operation, ridScoped.requestId, input.requestId);
|
|
213
198
|
}
|
|
214
199
|
// Otherwise: every grant for the operation is either consumed or expired.
|
|
215
200
|
const hasUnexpired = sameOpAnyState.some((g) => Date.parse(g.expiresAt) > now);
|
|
216
201
|
if (!hasUnexpired) {
|
|
217
|
-
return
|
|
218
|
-
allow: false,
|
|
219
|
-
code: 'WORKTREE_USER_AUTH_EXPIRED',
|
|
220
|
-
reason: `All grants for operation "${operation}" in this session have expired.`,
|
|
221
|
-
remediation: `Re-run \`peaks worktree auth grant --operation ${operation} --reason "<why>"\` (default TTL 5 min) before the tool call retries.`
|
|
222
|
-
};
|
|
202
|
+
return expiredGrantsDenial(operation);
|
|
223
203
|
}
|
|
224
204
|
// Grants exist and at least one is unexpired, but every non-expired one is consumed.
|
|
225
|
-
return
|
|
226
|
-
allow: false,
|
|
227
|
-
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
228
|
-
reason: `All unexpired grants for operation "${operation}" in this session are already consumed.`,
|
|
229
|
-
remediation: `Re-run \`peaks worktree auth grant --operation ${operation} --reason "<why>"\` to issue a fresh grant (or pass --multi to make it multi-use).`
|
|
230
|
-
};
|
|
205
|
+
return consumedGrantsDenial(operation);
|
|
231
206
|
}
|
|
232
207
|
/**
|
|
233
208
|
* Public entry point used by `peaks gate enforce`. Reads the auth file, decides, and (when consume=true
|
|
@@ -0,0 +1,74 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* The denial text the worktree-authorization gate prints when no live user
|
|
3
|
+
* grant covers the operation.
|
|
4
|
+
*
|
|
5
|
+
* WHY ITS OWN MODULE. `worktree-authorization-gate.ts` is 701 lines against a
|
|
6
|
+
* 300-line cap and already carries a baseline row, so it may only shrink. The
|
|
7
|
+
* five refusal texts it used to build inline move here and the gate calls
|
|
8
|
+
* these builders — the extract-don't-append move this repository makes instead
|
|
9
|
+
* of growing an over-cap file.
|
|
10
|
+
*
|
|
11
|
+
* WHY THE TEXT ASKS THE READER TO GO TO THE USER. The gate is a `PreToolUse`
|
|
12
|
+
* hook, so its reader is the agent, and the AGENT IS THE PARTY THE PROJECT'S
|
|
13
|
+
* RULE AIMS AT: the authorization this gate consumes is the user's to give. The
|
|
14
|
+
* gate cannot enforce that distinction — see the next paragraph, which is the
|
|
15
|
+
* part an earlier revision of this file got wrong — so the text asks rather
|
|
16
|
+
* than claims, and the denial that told its own reader to run a command it was
|
|
17
|
+
* told it must not run is the defect this function replaces.
|
|
18
|
+
*
|
|
19
|
+
* WHAT THE GATE ACTUALLY CHECKS — AND WHAT IT DOES NOT. A grant recorded for
|
|
20
|
+
* the operation in this session. Nothing else: the gate has no issuer concept,
|
|
21
|
+
* so it cannot and does not discriminate on who wrote the grant. Measured
|
|
22
|
+
* 2026-10-13, end to end, in a scratch project: `git stash drop stash@{0}` is
|
|
23
|
+
* refused (exit 2); the agent then runs
|
|
24
|
+
* `peaks worktree auth grant --operation git-stash-mutating --reason "the agent
|
|
25
|
+
* wrote this itself; no user was involved"` and gets `ok: true`; the SAME call
|
|
26
|
+
* then exits 0 and is allowed. The grant stays operation-scoped (`git worktree
|
|
27
|
+
* add` against the same project is still refused), so the gate does gate — it
|
|
28
|
+
* just cannot tell consent from self-authorization.
|
|
29
|
+
*
|
|
30
|
+
* WHY THIS MATTERS FOR THE TEXT. An earlier revision of this function said "an
|
|
31
|
+
* agent-issued grant is not the consent this gate checks for, so the reader
|
|
32
|
+
* cannot satisfy this refusal itself". That is exactly the defect the function
|
|
33
|
+
* exists to avoid: a message asserting a guarantee the code does not implement,
|
|
34
|
+
* which this module's own header above already falsifies. The text below says
|
|
35
|
+
* what the measurement shows — the gate needs a recorded grant, and nothing
|
|
36
|
+
* distinguishes who issued it — and keeps the ask, because the authorization is
|
|
37
|
+
* the user's to give even though the gate cannot enforce that.
|
|
38
|
+
*
|
|
39
|
+
* `operation` is a plain `string`, not the gate's `OperationType`: the text
|
|
40
|
+
* only interpolates the value, and importing that type back would make the two
|
|
41
|
+
* modules mutually importing. `as const` on `code` and `allow` keeps each
|
|
42
|
+
* returned literal narrow enough to be the gate's deny variant without the
|
|
43
|
+
* import.
|
|
44
|
+
*/
|
|
45
|
+
export declare function noAuthorizationDenial(operation: string, sessionId: string): {
|
|
46
|
+
allow: false;
|
|
47
|
+
code: "WORKTREE_USER_AUTH_REQUIRED";
|
|
48
|
+
reason: string;
|
|
49
|
+
remediation: string;
|
|
50
|
+
};
|
|
51
|
+
export declare function noGrantForOperationDenial(operation: string): {
|
|
52
|
+
allow: false;
|
|
53
|
+
code: "WORKTREE_USER_AUTH_REQUIRED";
|
|
54
|
+
reason: string;
|
|
55
|
+
remediation: string;
|
|
56
|
+
};
|
|
57
|
+
export declare function requestMismatchDenial(operation: string, grantRequestId: string | null, currentRequestId: string | null): {
|
|
58
|
+
allow: false;
|
|
59
|
+
code: "WORKTREE_USER_AUTH_REQUEST_MISMATCH";
|
|
60
|
+
reason: string;
|
|
61
|
+
remediation: string;
|
|
62
|
+
};
|
|
63
|
+
export declare function expiredGrantsDenial(operation: string): {
|
|
64
|
+
allow: false;
|
|
65
|
+
code: "WORKTREE_USER_AUTH_EXPIRED";
|
|
66
|
+
reason: string;
|
|
67
|
+
remediation: string;
|
|
68
|
+
};
|
|
69
|
+
export declare function consumedGrantsDenial(operation: string): {
|
|
70
|
+
allow: false;
|
|
71
|
+
code: "WORKTREE_USER_AUTH_REQUIRED";
|
|
72
|
+
reason: string;
|
|
73
|
+
remediation: string;
|
|
74
|
+
};
|
|
@@ -0,0 +1,102 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* The denial text the worktree-authorization gate prints when no live user
|
|
3
|
+
* grant covers the operation.
|
|
4
|
+
*
|
|
5
|
+
* WHY ITS OWN MODULE. `worktree-authorization-gate.ts` is 701 lines against a
|
|
6
|
+
* 300-line cap and already carries a baseline row, so it may only shrink. The
|
|
7
|
+
* five refusal texts it used to build inline move here and the gate calls
|
|
8
|
+
* these builders — the extract-don't-append move this repository makes instead
|
|
9
|
+
* of growing an over-cap file.
|
|
10
|
+
*
|
|
11
|
+
* WHY THE TEXT ASKS THE READER TO GO TO THE USER. The gate is a `PreToolUse`
|
|
12
|
+
* hook, so its reader is the agent, and the AGENT IS THE PARTY THE PROJECT'S
|
|
13
|
+
* RULE AIMS AT: the authorization this gate consumes is the user's to give. The
|
|
14
|
+
* gate cannot enforce that distinction — see the next paragraph, which is the
|
|
15
|
+
* part an earlier revision of this file got wrong — so the text asks rather
|
|
16
|
+
* than claims, and the denial that told its own reader to run a command it was
|
|
17
|
+
* told it must not run is the defect this function replaces.
|
|
18
|
+
*
|
|
19
|
+
* WHAT THE GATE ACTUALLY CHECKS — AND WHAT IT DOES NOT. A grant recorded for
|
|
20
|
+
* the operation in this session. Nothing else: the gate has no issuer concept,
|
|
21
|
+
* so it cannot and does not discriminate on who wrote the grant. Measured
|
|
22
|
+
* 2026-10-13, end to end, in a scratch project: `git stash drop stash@{0}` is
|
|
23
|
+
* refused (exit 2); the agent then runs
|
|
24
|
+
* `peaks worktree auth grant --operation git-stash-mutating --reason "the agent
|
|
25
|
+
* wrote this itself; no user was involved"` and gets `ok: true`; the SAME call
|
|
26
|
+
* then exits 0 and is allowed. The grant stays operation-scoped (`git worktree
|
|
27
|
+
* add` against the same project is still refused), so the gate does gate — it
|
|
28
|
+
* just cannot tell consent from self-authorization.
|
|
29
|
+
*
|
|
30
|
+
* WHY THIS MATTERS FOR THE TEXT. An earlier revision of this function said "an
|
|
31
|
+
* agent-issued grant is not the consent this gate checks for, so the reader
|
|
32
|
+
* cannot satisfy this refusal itself". That is exactly the defect the function
|
|
33
|
+
* exists to avoid: a message asserting a guarantee the code does not implement,
|
|
34
|
+
* which this module's own header above already falsifies. The text below says
|
|
35
|
+
* what the measurement shows — the gate needs a recorded grant, and nothing
|
|
36
|
+
* distinguishes who issued it — and keeps the ask, because the authorization is
|
|
37
|
+
* the user's to give even though the gate cannot enforce that.
|
|
38
|
+
*
|
|
39
|
+
* `operation` is a plain `string`, not the gate's `OperationType`: the text
|
|
40
|
+
* only interpolates the value, and importing that type back would make the two
|
|
41
|
+
* modules mutually importing. `as const` on `code` and `allow` keeps each
|
|
42
|
+
* returned literal narrow enough to be the gate's deny variant without the
|
|
43
|
+
* import.
|
|
44
|
+
*/
|
|
45
|
+
/**
|
|
46
|
+
* The remedy paragraph every denial ends with, with the operation baked in.
|
|
47
|
+
*
|
|
48
|
+
* Four facts, in the order a reader needs them: what the gate requires, what it
|
|
49
|
+
* does not check, whose authorization the rule is, and how to record it.
|
|
50
|
+
*/
|
|
51
|
+
function userSideGrant(operation) {
|
|
52
|
+
return [
|
|
53
|
+
`The gate requires one thing: a grant recorded for the "${operation}" operation in this session's \`.peaks/_runtime/<sessionId>/worktree-auth.json\`.`,
|
|
54
|
+
'Nothing in the gate records or checks WHO issued a grant, so a grant the reader writes itself is accepted — the requirement is a recorded grant, not a verified issuer.',
|
|
55
|
+
"The authorization is the USER's to give: ask them first, then record it with",
|
|
56
|
+
` peaks worktree auth grant --operation ${operation} --reason "<the words they used>"`,
|
|
57
|
+
'(`--ttl <ms>` and `--multi` are accepted.) A grant with no user behind it satisfies this gate; it does not satisfy the rule the gate exists for, which is why the ask comes first.'
|
|
58
|
+
].join('\n');
|
|
59
|
+
}
|
|
60
|
+
export function noAuthorizationDenial(operation, sessionId) {
|
|
61
|
+
return {
|
|
62
|
+
allow: false,
|
|
63
|
+
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
64
|
+
reason: `No current-task user authorization for "${operation}" (session=${sessionId}).`,
|
|
65
|
+
remediation: userSideGrant(operation)
|
|
66
|
+
};
|
|
67
|
+
}
|
|
68
|
+
export function noGrantForOperationDenial(operation) {
|
|
69
|
+
return {
|
|
70
|
+
allow: false,
|
|
71
|
+
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
72
|
+
reason: `No grant for operation "${operation}" in this session.`,
|
|
73
|
+
remediation: userSideGrant(operation)
|
|
74
|
+
};
|
|
75
|
+
}
|
|
76
|
+
export function requestMismatchDenial(operation, grantRequestId, currentRequestId) {
|
|
77
|
+
return {
|
|
78
|
+
allow: false,
|
|
79
|
+
code: 'WORKTREE_USER_AUTH_REQUEST_MISMATCH',
|
|
80
|
+
reason: `Grant for "${operation}" is scoped to requestId=${grantRequestId} but the current tool ` +
|
|
81
|
+
`call carries requestId=${currentRequestId}.`,
|
|
82
|
+
remediation: `Operate under the request the grant is scoped to (requestId=${grantRequestId}), or have ` +
|
|
83
|
+
`the user re-issue the grant unscoped. ${userSideGrant(operation)}`
|
|
84
|
+
};
|
|
85
|
+
}
|
|
86
|
+
export function expiredGrantsDenial(operation) {
|
|
87
|
+
return {
|
|
88
|
+
allow: false,
|
|
89
|
+
code: 'WORKTREE_USER_AUTH_EXPIRED',
|
|
90
|
+
reason: `All grants for operation "${operation}" in this session have expired.`,
|
|
91
|
+
remediation: `${userSideGrant(operation)} (The previous grant expired; the default TTL is 5 minutes.)`
|
|
92
|
+
};
|
|
93
|
+
}
|
|
94
|
+
export function consumedGrantsDenial(operation) {
|
|
95
|
+
return {
|
|
96
|
+
allow: false,
|
|
97
|
+
code: 'WORKTREE_USER_AUTH_REQUIRED',
|
|
98
|
+
reason: `All unexpired grants for operation "${operation}" in this session are already consumed.`,
|
|
99
|
+
remediation: `${userSideGrant(operation)} (The previous grant was single-use and already consumed; a ` +
|
|
100
|
+
`multi-use grant is possible but should be rare.)`
|
|
101
|
+
};
|
|
102
|
+
}
|
|
@@ -17,6 +17,6 @@ export declare function matchBaseline(finding: EslintFinding, baseline: readonly
|
|
|
17
17
|
export declare function aggregateRedLine(baseline: readonly BaselineViolation[]): readonly RedLineEntry[];
|
|
18
18
|
export declare const EMPTY_DIFF_RANGE: readonly DiffRange[];
|
|
19
19
|
export declare const EMPTY_REDLINE: readonly RedLineEntry[];
|
|
20
|
-
export declare function emptyResult(state: EslintState, start: number, rawOutput: string): EslintRunResult;
|
|
20
|
+
export declare function emptyResult(state: EslintState, start: number, rawOutput: string, reason?: string): EslintRunResult;
|
|
21
21
|
export declare function buildEslintArgs(options: EslintRunOptions): string[];
|
|
22
22
|
export type { DiffRange };
|
|
@@ -150,13 +150,14 @@ export function aggregateRedLine(baseline) {
|
|
|
150
150
|
}
|
|
151
151
|
export const EMPTY_DIFF_RANGE = [];
|
|
152
152
|
export const EMPTY_REDLINE = [];
|
|
153
|
-
export function emptyResult(state, start, rawOutput) {
|
|
153
|
+
export function emptyResult(state, start, rawOutput, reason) {
|
|
154
154
|
return {
|
|
155
155
|
state,
|
|
156
156
|
findings: [],
|
|
157
157
|
summary: { error: 0, warn: 0, info: 0 },
|
|
158
158
|
durationMs: Date.now() - start,
|
|
159
159
|
rawOutput,
|
|
160
|
+
...(reason === undefined ? {} : { reason }),
|
|
160
161
|
baselineWaived: [],
|
|
161
162
|
redLine: EMPTY_REDLINE
|
|
162
163
|
};
|
|
@@ -45,6 +45,14 @@ export type EslintRunResult = {
|
|
|
45
45
|
readonly summary: EslintSummary;
|
|
46
46
|
readonly durationMs: number;
|
|
47
47
|
readonly rawOutput: string;
|
|
48
|
+
/**
|
|
49
|
+
* Why a non-`ok` state was reached. Four different conditions — an
|
|
50
|
+
* unbuildable argument list, a spawn failure, a signal kill (which is how a
|
|
51
|
+
* spawn timeout lands) and unparseable linter output — all reported
|
|
52
|
+
* `execution-failed` and nothing else, so an operator could not tell a
|
|
53
|
+
* timed-out linter from one that emitted rubbish. Absent when `state` is ok.
|
|
54
|
+
*/
|
|
55
|
+
readonly reason?: string;
|
|
48
56
|
readonly baselineWaived: readonly EslintFinding[];
|
|
49
57
|
readonly redLine: readonly RedLineEntry[];
|
|
50
58
|
};
|
|
@@ -87,7 +87,7 @@ export function runEslint(options) {
|
|
|
87
87
|
args = buildEslintArgs(options);
|
|
88
88
|
}
|
|
89
89
|
catch (error) {
|
|
90
|
-
return emptyResult('execution-failed', start, error instanceof Error ? error.message : String(error));
|
|
90
|
+
return emptyResult('execution-failed', start, error instanceof Error ? error.message : String(error), 'the eslint argument list could not be built');
|
|
91
91
|
}
|
|
92
92
|
const projectRoot = resolveProjectRoot(options.cwd);
|
|
93
93
|
// Invoke eslint via `node <node_modules/eslint/bin/eslint.js>` to bypass
|
|
@@ -132,10 +132,23 @@ export function runEslint(options) {
|
|
|
132
132
|
if (result.error !== undefined && result.error !== null) {
|
|
133
133
|
const message = result.error.message;
|
|
134
134
|
const state = /ENOENT/.test(message) ? 'npx-failed' : 'execution-failed';
|
|
135
|
-
|
|
135
|
+
// A spawn timeout arrives HERE, as `error.code === 'ETIMEDOUT'` — measured on
|
|
136
|
+
// this host with `--timeout-ms 20000`: the spawn-error branch below wins over
|
|
137
|
+
// the signal branch, because this check comes first and spawnSync sets both.
|
|
138
|
+
// So a timeout must not be reported as "could not be spawned": it was spawned
|
|
139
|
+
// and did not finish, and that difference is the whole diagnosis.
|
|
140
|
+
const timedOut = result.error.code === 'ETIMEDOUT';
|
|
141
|
+
const budgetMs = options.timeoutMs ?? ESLINT_DEFAULT_TIMEOUT_MS;
|
|
142
|
+
return emptyResult(state, start, typeof result.stdout === 'string' ? result.stdout : '', timedOut
|
|
143
|
+
? `eslint did not finish within the ${budgetMs}ms spawn timeout`
|
|
144
|
+
: `eslint could not be spawned: ${message}`);
|
|
136
145
|
}
|
|
137
146
|
if (result.signal !== null && result.signal !== undefined) {
|
|
138
|
-
|
|
147
|
+
// A kill that arrived WITHOUT a spawn error — a signal from outside, not the
|
|
148
|
+
// spawn timeout (that one is caught above as ETIMEDOUT). Named so it is not
|
|
149
|
+
// read as linter output that would not parse.
|
|
150
|
+
const budgetMs = options.timeoutMs ?? ESLINT_DEFAULT_TIMEOUT_MS;
|
|
151
|
+
return emptyResult('execution-failed', start, typeof result.stdout === 'string' ? result.stdout : '', `eslint was killed by ${result.signal} after ${Date.now() - start}ms (spawn timeout ${budgetMs}ms)`);
|
|
139
152
|
}
|
|
140
153
|
const stdout = typeof result.stdout === 'string' ? result.stdout : '';
|
|
141
154
|
let findings = [];
|
|
@@ -166,7 +179,7 @@ export function runEslint(options) {
|
|
|
166
179
|
}
|
|
167
180
|
}
|
|
168
181
|
catch {
|
|
169
|
-
return emptyResult('execution-failed', start, stdout);
|
|
182
|
+
return emptyResult('execution-failed', start, stdout, `eslint stdout was not valid JSON (${stdout.length} bytes)`);
|
|
170
183
|
}
|
|
171
184
|
}
|
|
172
185
|
if (result.status !== 0 && findings.length === 0) {
|
|
@@ -13,6 +13,7 @@
|
|
|
13
13
|
* a fake transport instead of reaching the network.
|
|
14
14
|
*/
|
|
15
15
|
import { getErrorMessage } from 'peaks-loop-shared/result';
|
|
16
|
+
import { estimateTokens } from '../memory/llm-reranker-core.js';
|
|
16
17
|
/** Public Anthropic endpoint. `ANTHROPIC_BASE_URL` overrides it (gateways, local proxies). */
|
|
17
18
|
const DEFAULT_BASE_URL = 'https://api.anthropic.com';
|
|
18
19
|
/** One call is bounded: an unbounded gate is a hung gate. */
|
|
@@ -102,6 +103,28 @@ function isTextBlock(block) {
|
|
|
102
103
|
function isAbort(error) {
|
|
103
104
|
return error instanceof Error && (error.name === 'TimeoutError' || error.name === 'AbortError');
|
|
104
105
|
}
|
|
106
|
+
/**
|
|
107
|
+
* The two token counts this call reports, and where they came from.
|
|
108
|
+
*
|
|
109
|
+
* `?? 0` used to stand in for an omitted `usage`, which made "the provider
|
|
110
|
+
* reported zero" and "nobody measured" the same number on the wire. When the
|
|
111
|
+
* reply does not carry BOTH counts, the runner falls back to the estimator the
|
|
112
|
+
* repo already has (`llm-reranker-core.ts` `estimateTokens`, 1 token ≈ 4 bytes)
|
|
113
|
+
* over the request body and the returned text, and says so with
|
|
114
|
+
* `source: 'estimated'` rather than leaving the two states indistinguishable.
|
|
115
|
+
*/
|
|
116
|
+
function tokenCounts(usage, requestBody, text) {
|
|
117
|
+
const input = usage?.input_tokens;
|
|
118
|
+
const output = usage?.output_tokens;
|
|
119
|
+
if (typeof input !== 'number' || typeof output !== 'number') {
|
|
120
|
+
return {
|
|
121
|
+
input: estimateTokens(requestBody),
|
|
122
|
+
output: estimateTokens(text),
|
|
123
|
+
source: 'estimated'
|
|
124
|
+
};
|
|
125
|
+
}
|
|
126
|
+
return { input, output, source: 'provider' };
|
|
127
|
+
}
|
|
105
128
|
export function createAnthropicRunner(config, options = {}) {
|
|
106
129
|
const fetchImpl = options.fetchImpl ?? defaultFetch;
|
|
107
130
|
const timeoutMs = options.timeoutMs ?? DEFAULT_TIMEOUT_MS;
|
|
@@ -153,13 +176,7 @@ export function createAnthropicRunner(config, options = {}) {
|
|
|
153
176
|
if (!output) {
|
|
154
177
|
throw new LlmRequestError(`LLM reply from ${url} carried no text block`);
|
|
155
178
|
}
|
|
156
|
-
return {
|
|
157
|
-
output,
|
|
158
|
-
tokens: {
|
|
159
|
-
input: payload.usage?.input_tokens ?? 0,
|
|
160
|
-
output: payload.usage?.output_tokens ?? 0
|
|
161
|
-
}
|
|
162
|
-
};
|
|
179
|
+
return { output, tokens: tokenCounts(payload.usage, body, output) };
|
|
163
180
|
}
|
|
164
181
|
};
|
|
165
182
|
}
|
|
@@ -0,0 +1,39 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* The loop runtime's two observability emissions: the monotonic guard's verdict
|
|
3
|
+
* for a cycle, and that cycle's own outcome.
|
|
4
|
+
*
|
|
5
|
+
* WHY BOTH MAPPINGS LIVE HERE. The two producers cannot emit for themselves:
|
|
6
|
+
* `checkMonotonicImprovement` is pure (no project root, no session id —
|
|
7
|
+
* `monotonic-guard.ts:83`), and the cycle bookkeeping in `runLoopLocked` has no
|
|
8
|
+
* emitter. So the emit happens in the callers, and the callers are two files.
|
|
9
|
+
* The mapping from loop state to event vocabulary is decided ONCE, here, rather
|
|
10
|
+
* than re-derived at each call site.
|
|
11
|
+
*
|
|
12
|
+
* Fire-and-forget by contract: whatever `emitObservabilityEvent` returns
|
|
13
|
+
* (`written: false` on every error path) is dropped, and neither helper throws.
|
|
14
|
+
*/
|
|
15
|
+
import type { MonotonicReport } from './monotonic-guard.js';
|
|
16
|
+
/**
|
|
17
|
+
* `monotonic-trigger` — once per computed report, from each caller of
|
|
18
|
+
* `checkMonotonicImprovement`, which is pure and cannot emit for itself.
|
|
19
|
+
*
|
|
20
|
+
* `pass` → `report: 'pass'`; `block` → `report: 'block'`; `action` is the
|
|
21
|
+
* report's own `code`, a vocabulary the guard already produces
|
|
22
|
+
* (`MONOTONIC_OK` / `MONOTONIC_VIOLATION` / `MONOTONIC_NO_PREVIOUS` /
|
|
23
|
+
* `MONOTONIC_INCOMPARABLE_EVALUATORS`). **`skip` emits NOTHING**: nothing was
|
|
24
|
+
* guarded, so counting it would make the counter track "how often the guard ran"
|
|
25
|
+
* instead of "how often a monotonic condition fired". `'warn'` stays unused —
|
|
26
|
+
* the guard cannot return it, and it is not repurposed here.
|
|
27
|
+
*/
|
|
28
|
+
export declare function emitMonotonicReport(projectRoot: string, sid: string, report: MonotonicReport): void;
|
|
29
|
+
/**
|
|
30
|
+
* `cycle` — exactly ONE event per cycle, at the end of the iteration.
|
|
31
|
+
*
|
|
32
|
+
* One, not two: `aggregateDashboardMetrics` counts events, not distinct cycle
|
|
33
|
+
* ids (`aggregation.ts:212`), so emitting `'started'` alongside this one would
|
|
34
|
+
* double `cycleCount`. `'started'` therefore stays unused. `status` is
|
|
35
|
+
* `'failed'` for the cycle whose report carries the violation — the same
|
|
36
|
+
* condition `runLoopLocked` aborts on — and `'completed'` otherwise, so
|
|
37
|
+
* `cycleCount` equals the number of cycles the driver actually ran.
|
|
38
|
+
*/
|
|
39
|
+
export declare function emitCycleOutcome(projectRoot: string, sid: string, cycle: number, report: MonotonicReport): void;
|