peaks-loop 4.1.0 → 4.1.2

package/dist/services/upgrade/upgrade-service.js

@@ -1,428 +0,0 @@
-/**
- * peaks upgrade --to 2.0 — umbrella service for the 1.x → 2.0
- * migration.
- *
- * Per the "one-key completion" + "minimal-user-operation" tenets
- * (2026-06-11), the typical upgrade path is:
- *
- *   $ npm i -g peaks-loop@2.0   # postinstall does everything
- *
- * OR (postinstall skipped / manual fallback):
- *
- *   $ peaks upgrade --to 2.0
- *
- * The umbrella orchestrates 7 sub-commands:
- *   1. config migrate       (already ships as `peaks config migrate`)
- *   2. standards migrate    (`peaks standards migrate --from-claude-rules`)
- *   3. memory extract       (already ships as `peaks memory extract`)
- *   4. hooks install        (already ships as `peaks hooks install`)
- *   5. skill sync           (this session, `peaks skill sync --all`)
- *   6. audit verify         (already ships as `peaks audit red-lines`)
- *   7. write upgrade record (in-process, .peaks/memory/upgrade-2.0-*.md)
- *
- * Each sub-step is a thin shell-out to the existing CLI; the
- * umbrella's only in-process work is the audit and the upgrade
- * record write. Sub-step failures are SOFT (logged + nextActions
- * populated) so the umbrella never blocks a successful partial
- * upgrade.
- */
-import { spawnSync } from 'node:child_process';
-import { existsSync, mkdirSync, readdirSync, readFileSync, statSync, writeFileSync } from 'node:fs';
-import { join, dirname, relative, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { runRedLinesAudit } from '../audit/red-lines-service.js';
-import { savePreferences } from '../preferences/preferences-service.js';
-import { migrateGitignoreFile } from './gitignore-migrate-service.js';
-/**
- * Default substep executor — wraps `spawnSync` with the same
- * stdio / encoding / timeout config the umbrella has used since
- * v1. Exported for test coverage: the seam-preservation test
- * imports this directly to verify the normalized return shape
- * on a spawn failure (e.g. a non-existent command).
- */
-export const defaultSubstepExecutor = (command, args, timeoutMs) => {
-    const start = Date.now();
-    try {
-        const result = spawnSync(command, args, {
-            encoding: 'utf8',
-            stdio: ['ignore', 'pipe', 'pipe'],
-            timeout: timeoutMs,
-            windowsHide: true
-        });
-        return {
-            status: result.status,
-            stdout: result.stdout ?? '',
-            stderr: result.stderr ?? '',
-            durationMs: Date.now() - start
-        };
-    }
-    catch (err) {
-        const message = err instanceof Error ? err.message : String(err);
-        return {
-            status: null,
-            stdout: '',
-            stderr: message,
-            durationMs: Date.now() - start
-        };
-    }
-};
-const STEPS = [
-    {
-        name: 'config-migrate',
-        args: (p) => ['config', 'migrate', '--project', p, '--apply', '--json']
-    },
-    {
-        name: 'standards-migrate',
-        args: (p) => [
-            'standards',
-            'migrate',
-            '--from-claude-rules',
-            '--project',
-            p,
-            '--apply',
-            '--json'
-        ]
-    },
-    // memory extract is special: its --artifact takes literal file
-    // paths (memory-service rejects glob patterns via realpathSync).
-    // The umbrella expands the three documented patterns
-    // (skills/**/SKILL.md, CLAUDE.md, .claude/rules/**/*.md) on disk
-    // and passes the resulting literal list. See runUpgrade's special
-    // case below for the args resolution; the args function here is
-    // a placeholder so the STEPS table stays uniform.
-    { name: 'memory-extract', args: (p) => ['memory', 'extract', '--project', p, '--json'] },
-    { name: 'hooks-install', args: (p) => ['hooks', 'install', '--project', p, '--json'] },
-    { name: 'skill-sync', args: (p) => ['skill', 'sync', '--all', '--project', p, '--json'] },
-    { name: 'audit-verify', args: (p) => ['audit', 'red-lines', '--project', p, '--json'] }
-];
-/**
- * Walk `<root>` recursively and collect every file whose basename
- * matches `predicate`. Returns absolute paths.
- *
- * Mirrors `readMarkdownFilesRecursive` in
- * src/services/standards/migrate-claude-rules-service.ts so the
- * umbrella does not pull a new glob dependency (Node 20+ engine
- * constraint — `fs.globSync` requires Node 22+).
- */
-function collectFilesRecursive(root, predicate) {
-    if (!existsSync(root))
-        return [];
-    const stat = statSync(root);
-    if (stat.isFile()) {
-        return predicate(root.split(/[\\/]/).pop() ?? '') ? [root] : [];
-    }
-    if (!stat.isDirectory())
-        return [];
-    const out = [];
-    for (const entry of readdirSync(root)) {
-        const child = join(root, entry);
-        let childStat;
-        try {
-            childStat = statSync(child);
-        }
-        catch {
-            continue;
-        }
-        if (childStat.isFile()) {
-            if (predicate(entry))
-                out.push(child);
-        }
-        else if (childStat.isDirectory()) {
-            out.push(...collectFilesRecursive(child, predicate));
-        }
-    }
-    return out;
-}
-/**
- * Resolve the three documented memory-extract artifact patterns
- * against a real project tree. Returns project-relative paths
- * (memory-service joins them with --project root) so the
- * realpathSync inside memory-service's assertInsideProject
- * succeeds.
- *
- * Patterns:
- *   - skills/[asterisk][asterisk]/SKILL.md       (project-root convention)
- *   - .claude/skills/[asterisk][asterisk]/SKILL.md (Claude-Code consumer convention; ice-cola)
- *   - CLAUDE.md
- *   - .claude/rules/[asterisk][asterisk]/[asterisk].md
- *
- * Returns an empty list when none of the roots exist. The
- * caller marks the step skipped in that case.
- */
-function expandMemoryArtifacts(projectRoot) {
-    const out = [];
-    // skills/**/SKILL.md (peaks-loop repo convention)
-    const skillFiles = collectFilesRecursive(join(projectRoot, 'skills'), (name) => name === 'SKILL.md');
-    for (const abs of skillFiles) {
-        out.push(relative(projectRoot, abs));
-    }
-    // .claude/skills/**/SKILL.md (Claude-Code consumer convention;
-    // surfaced by ice-cola dogfood 2026-06-12 — the 1.x install
-    // landed skills under .claude/skills/, not <root>/skills/)
-    const claudeSkillFiles = collectFilesRecursive(join(projectRoot, '.claude', 'skills'), (name) => name === 'SKILL.md');
-    for (const abs of claudeSkillFiles) {
-        out.push(relative(projectRoot, abs));
-    }
-    // CLAUDE.md (literal)
-    const claudeMd = join(projectRoot, 'CLAUDE.md');
-    if (existsSync(claudeMd) && statSync(claudeMd).isFile()) {
-        out.push('CLAUDE.md');
-    }
-    // .claude/rules/**/*.md
-    const claudeRules = collectFilesRecursive(join(projectRoot, '.claude', 'rules'), (name) => name.endsWith('.md'));
-    for (const abs of claudeRules) {
-        out.push(relative(projectRoot, abs));
-    }
-    return out;
-}
-function read1xVersion(cwd) {
-    const home = process.env['HOME'] ?? process.env['USERPROFILE'] ?? '';
-    if (home.length === 0)
-        return null;
-    const global = join(home, '.peaks', 'config.json');
-    if (!existsSync(global))
-        return null;
-    try {
-        const raw = JSON.parse(readFileSync(global, 'utf8'));
-        if (typeof raw.version === 'string')
-            return raw.version;
-    }
-    catch {
-        // TODO(g2): legacy silent catch — grace: 1 minor release (v2.14.0)
-        // ignore
-    }
-    return null;
-}
-function runStep(peaksBin, name, args, timeoutMs = 60_000, executor = defaultSubstepExecutor) {
-    // The global `peaks` shim is a `/bin/sh` symlink script (the
-    // npm install postinstall creates `peaks` → `peaks.sh` on
-    // Windows). cmd.exe (the default Windows shell) cannot run
-    // `.sh` scripts directly, so the shim fails with "unknown
-    // command 'migrate'" etc. The fix: prefer the local node
-    // binary + the peaks.js script path. The umbrella resolves
-    // the script path at startup; only falls back to `peaks` if
-    // no script path is available (Unix-only).
-    let command;
-    let spawnArgs;
-    if (peaksBin.includes('\\') || peaksBin.includes('/')) {
-        // peaksBin is a real path (e.g. /c/.../bin/peaks.js);
-        // invoke directly via node.
-        command = process.execPath;
-        spawnArgs = [peaksBin, ...args];
-    }
-    else {
-        // peaksBin is just "peaks" — best-effort shell exec.
-        command = peaksBin;
-        spawnArgs = args;
-    }
-    // The executor normalizes spawn errors to { status: null, stderr: ... }
-    // so no try/catch wrapper is needed here — the call always returns
-    // a shaped record. See defaultSubstepExecutor for the reference impl.
-    const result = executor(command, spawnArgs, timeoutMs);
-    return {
-        name,
-        status: result.status === 0 ? 'pass' : 'fail',
-        exitCode: result.status,
-        stdout: result.stdout,
-        stderr: result.stderr,
-        durationMs: result.durationMs
-    };
-}
-function writeUpgradeRecord(projectRoot, result) {
-    try {
-        const memoryDir = join(projectRoot, '.peaks', 'memory');
-        mkdirSync(memoryDir, { recursive: true });
-        const date = new Date().toISOString().slice(0, 10);
-        const file = join(memoryDir, `upgrade-2.0-${date}.md`);
-        const lines = [];
-        lines.push(`# Upgrade to peaks-loop 2.0 — ${date}`);
-        lines.push('');
-        lines.push(`> Auto-generated by \`peaks upgrade --to 2.0${result.applied ? ' --auto' : ''}\`.`);
-        lines.push(`> Per the "one-key completion" + "minimal-user-operation" tenets.`);
-        lines.push('');
-        if (result.fromVersion !== null) {
-            lines.push(`**From version**: ${result.fromVersion}`);
-        }
-        lines.push(`**To version**: 2.0.0`);
-        lines.push(`**Project root**: \`${result.projectRoot}\``);
-        lines.push('');
-        lines.push('## Sub-step results');
-        lines.push('');
-        lines.push('| step | status | exitCode | durationMs |');
-        lines.push('|------|--------|----------|------------|');
-        for (const step of result.steps) {
-            lines.push(`| ${step.name} | ${step.status} | ${step.exitCode ?? 'n/a'} | ${step.durationMs} |`);
-        }
-        lines.push('');
-        if (result.auditBefore !== null || result.auditAfter !== null) {
-            lines.push('## Audit snapshot');
-            lines.push('');
-            if (result.auditBefore !== null) {
-                lines.push(`- Before: totalRedLines=${result.auditBefore.totalRedLines}, cliBacked=${result.auditBefore.cliBacked}`);
-            }
-            if (result.auditAfter !== null) {
-                lines.push(`- After:  totalRedLines=${result.auditAfter.totalRedLines}, cliBacked=${result.auditAfter.cliBacked}`);
-            }
-            lines.push('');
-        }
-        lines.push('## Next actions');
-        lines.push('');
-        for (const a of result.nextActions) {
-            lines.push(`- ${a}`);
-        }
-        writeFileSync(file, lines.join('\n') + '\n', 'utf8');
-        return file;
-    }
-    catch (err) {
-        process.stderr.write(`peaks upgrade: failed to write upgrade record: ${err instanceof Error ? err.message : String(err)}\n`);
-        return null;
-    }
-}
-export function runUpgrade(input) {
-    // Resolve the peaks binary. Default: the peaks.js script
-    // co-located with this compiled module (the user just installed
-    // peaks-loop globally, but the global `peaks` shim is a .sh
-    // script that cmd.exe can't run on Windows). Falling back
-    // to just "peaks" lets the umbrella work when invoked from
-    // a Unix-style environment that can run the shim directly.
-    const here = dirname(fileURLToPath(import.meta.url));
-    // Walk up from the compiled location to find bin/peaks.js.
-    // The compiled service lives at dist/services/upgrade/upgrade-service.js
-    // (rootDir=src in tsconfig.build.json trims the "src" segment); bin/peaks.js
-    // is at the peaks-loop root, 3 dirs up.
-    const peaksBin = input.peaksBin ?? resolve(here, '..', '..', '..', 'bin', 'peaks.js');
-    const fallbackPeaks = 'peaks';
-    const resolvedPeaksBin = existsSync(peaksBin) ? peaksBin : fallbackPeaks;
-    // Resolve the executor once at the top of runUpgrade so every
-    // sub-step call shares the same instance. Tests pass a fake
-    // executor via UpgradeInput.executor; production callers omit
-    // it and get the default spawnSync wrapper.
-    const executor = input.executor ?? defaultSubstepExecutor;
-    const fromVersion = read1xVersion(input.projectRoot);
-    const steps = [];
-    const warnings = [];
-    const nextActions = [];
-    // Ensure .peaks/preferences.json exists. This is the file the
-    // 1.x detector keys off — without it, `peaks upgrade --detect-1x`
-    // keeps returning isOneX=true after a successful upgrade and the
-    // user gets stuck in a re-prompt loop. savePreferences with an
-    // empty override merges with DEFAULT_PREFERENCES and writes; if
-    // the file already exists the user's values are preserved.
-    // Real bug surfaced by ice-cola dogfood 2026-06-12.
-    try {
-        savePreferences(input.projectRoot, {});
-    }
-    catch (err) {
-        warnings.push(`ensure-preferences failed: ${err instanceof Error ? err.message : String(err)}`);
-    }
-    // Migrate .gitignore so 2.0 tracked artifacts
-    // (.peaks/standards/, .peaks/memory/*.md durable memories,
-    // .peaks/PROJECT.md) aren't silently hidden by a 1.x wholesale
-    // `/.peaks/` ignore rule. Real bug surfaced by ice-cola dogfood
-    // 2026-06-12: every consumer artifact was being dropped from git
-    // status. Service is idempotent + creates a timestamped backup
-    // before any write.
-    try {
-        const giResult = migrateGitignoreFile({ projectRoot: input.projectRoot, apply: true });
-        if (giResult.changed && giResult.appliedWrite && giResult.backupPath !== null) {
-            nextActions.push(`Updated .gitignore — removed stale wholesale .peaks rule(s): ${giResult.removedRules.join(', ')}. Backup at ${giResult.backupPath}.`);
-        }
-        else if (giResult.missing) {
-            warnings.push('gitignore-migrate skipped: project has no .gitignore');
-        }
-    }
-    catch (err) {
-        warnings.push(`gitignore-migrate failed: ${err instanceof Error ? err.message : String(err)}`);
-    }
-    // Audit BEFORE the upgrade (baseline)
-    let auditBefore = null;
-    try {
-        const r = runRedLinesAudit({ projectRoot: input.projectRoot });
-        auditBefore = { totalRedLines: r.audit.totalRedLines, cliBacked: r.audit.cliBacked };
-    }
-    catch (err) {
-        warnings.push(`audit-before failed: ${err instanceof Error ? err.message : String(err)}`);
-    }
-    // Run the 6 sub-steps
-    for (const step of STEPS) {
-        if (step.name === 'memory-extract') {
-            // Special case: expand the three glob patterns to literal
-            // paths before spawning. memory-service rejects literal
-            // '**' in artifact paths (assertInsideProject's realpathSync
-            // throws ENOENT) and refuses to run without --artifact.
-            const artifacts = expandMemoryArtifacts(input.projectRoot);
-            if (artifacts.length === 0) {
-                steps.push({
-                    name: 'memory-extract',
-                    status: 'skipped',
-                    exitCode: null,
-                    stdout: '',
-                    stderr: 'no skills/, CLAUDE.md, or .claude/rules/ artifacts found in the project',
-                    durationMs: 0
-                });
-                continue;
-            }
-            const args = [
-                'memory',
-                'extract',
-                '--project',
-                input.projectRoot,
-                '--artifact',
-                ...artifacts,
-                '--apply',
-                '--json'
-            ];
-            const r = runStep(resolvedPeaksBin, 'memory-extract', args, 60_000, executor);
-            steps.push(r);
-            if (r.status === 'fail') {
-                warnings.push(`memory-extract failed: ${r.stderr.slice(0, 200)}`);
-            }
-            continue;
-        }
-        const args = step.args(input.projectRoot);
-        const r = runStep(resolvedPeaksBin, step.name, args, 60_000, executor);
-        steps.push(r);
-        if (r.status === 'fail') {
-            warnings.push(`${step.name} failed: ${r.stderr.slice(0, 200)}`);
-        }
-    }
-    // Audit AFTER the upgrade (verify)
-    let auditAfter = null;
-    try {
-        const r = runRedLinesAudit({ projectRoot: input.projectRoot });
-        auditAfter = { totalRedLines: r.audit.totalRedLines, cliBacked: r.audit.cliBacked };
-    }
-    catch (err) {
-        warnings.push(`audit-after failed: ${err instanceof Error ? err.message : String(err)}`);
-    }
-    const passedCount = steps.filter((s) => s.status === 'pass').length;
-    const failedCount = steps.filter((s) => s.status === 'fail').length;
-    const skippedCount = steps.filter((s) => s.status === 'skipped').length;
-    const applied = failedCount === 0;
-    if (failedCount > 0) {
-        nextActions.push(`${failedCount} sub-step(s) failed. Run \`peaks upgrade --to 2.0\` again to retry the failed steps.`);
-    }
-    if (input.auto !== true) {
-        nextActions.push('Run `peaks audit red-lines --project .` to verify the L2 catalog is healthy.');
-    }
-    nextActions.push('See `docs/UPGRADING-2.0.md` for the manual fallback if this auto-upgrade fails.');
-    // Write the upgrade record (always, even on partial failure —
-    // the user gets a forensic artifact either way)
-    const partial = {
-        applied,
-        fromVersion,
-        toVersion: '2.0.0',
-        projectRoot: input.projectRoot,
-        steps,
-        passedCount,
-        failedCount,
-        skippedCount,
-        auditBefore,
-        auditAfter,
-        upgradeRecordPath: null,
-        nextActions,
-        warnings
-    };
-    const upgradeRecordPath = writeUpgradeRecord(input.projectRoot, partial);
-    return { ...partial, upgradeRecordPath };
-}

package/skills/peaks-code/references/step-0-55-1x-detection.md

@@ -1,83 +0,0 @@
-# Step 0.55 — 1.x → 2.0 detection reference
-
-> Body of `### Peaks-Loop Step 0.55`. Slice: 2026-06-12-code-step-0-55-1x-detection.
-
-## Why this step exists
-
-The peaks-loop 1.x → 2.0 closeout ships:
-
-1. A postinstall that auto-detects 1.x state and dispatches the upgrade (slice 1, commit `b6e34e6`).
-2. A standards-migrate path that thins `.claude/rules/**/*.md` and scaffolds `.peaks/standards/` (slice 2, commit `33dd392`).
-3. **THIS STEP** — a peaks-code startup sequence probe that detects 1.x state when the user invokes `/peaks-code` directly in a 1.x consumer project, and prompts the user to upgrade.
-
-The 1.x user experience is: "I just typed /peaks-code. Why is it not working in 2.0 mode?" Step 0.55 catches this case and surfaces an `AskUserQuestion` with a one-click upgrade.
-
-## Detection algorithm
-
-```bash
-# 1. Read-only probe via the umbrella CLI
-peaks upgrade --detect-1x --project <root> --json
-```
-
-The CLI returns:
-```json
-{
-  "ok": true,
-  "command": "upgrade.detect-1x",
-  "data": {
-    "isOneX": true,
-    "signals": [
-      "<path> has schema_version 1.0.0, expected '2.0.0'",
-      "..."
-    ],
-    "projectRoot": "/path/to/project",
-    "configPath": null
-  },
-  "warnings": [],
-  "nextActions": [
-    "Detected 1.x state. peaks-code Step 0.55 should present an AskUserQuestion to invoke `peaks upgrade --to 2.0 --auto --project /path/to/project`."
-  ]
-}
-```
-
-The detection logic mirrors `scripts/install-skills.mjs:detect1xProjectState` (canonical implementation) — it walks up to find `.peaks/_runtime/`, then sniffs:
-
-1. `~/.peaks/config.json` for `version: 1.x`
-2. `<projectRoot>/.claude/rules/common/dev-preference.md` for "peaks progress"
-3. `<projectRoot>/.peaks/preferences.json` for missing or non-`2.0.0` `schema_version`
-
-The TS mirror in `src/services/upgrade/1x-detector-service.ts` is the canonical entrypoint for the skill; the postinstall `.mjs` version is the canonical entrypoint for the npm-install flow. The two implementations MUST stay in parity (a parity test is in the slice's test suite).
-
-## AskUserQuestion (only when `isOneX: true`)
-
-| Option | What it does |
-|---|---|
-| Run `peaks upgrade --to 2.0 --auto --project <root>` (Recommended) | Invokes the umbrella. The user sees the 6 sub-step results in the terminal. After the upgrade, re-run peaks-code with the standing 2.0 layout. Persist `autoUpgradePrompt: opt-in` to `.peaks/preferences.json`. |
-| Skip for this session | Continue with the standing 1.x layout. Persist `autoUpgradePrompt: skip-this-session` to `.peaks/preferences.json`. The next time the user invokes peaks-code in this project, the question re-asks. |
-| Never ask again for this project | Persist `autoUpgradePrompt: skip-forever` to `.peaks/preferences.json`. Step 0.55 becomes a no-op for this project from now on. The user can re-enable later by removing the `autoUpgradePrompt` key from preferences.json. |
-
-## Persistence contract
-
-The decision is persisted via `peaks preferences set --project <root> --key autoUpgradePrompt --value <opt-in|skip-this-session|skip-forever> --apply`. Subsequent Step 0.55 invocations read the value first:
-
-- If `opt-in` (and Step 0.55 is the first invocation in the session), the user has already opted in; auto-run the umbrella without re-asking.
-- If `skip-this-session`, the user already said no this session; skip without re-asking (but re-ask next session).
-- If `skip-forever`, the user said no permanently; skip without re-asking.
-- If the key is absent, present the AskUserQuestion.
-
-## What is NOT in this step
-
-- The auto-upgrade execution itself: the umbrella is invoked via the AskUserQuestion's recommended option. The umbrella's behavior (6 sub-commands + write-upgrade-record) is documented in the umbrella's own help text.
-- The postinstall auto-dispatch: that's `scripts/install-skills.mjs:autoUpgrade1xProjectIfPresent`, which fires fire-and-forget on `npm i -g peaks-loop@2.0`. Step 0.55 is the user-invoked path.
-- Re-authoring the 1.x detector heuristics: the implementation is a 1:1 mirror of the canonical `.mjs` version. Drift is prevented by the parity test.
-
-## How this integrates with the rest of the workflow
-
-- Step 0 (anchor) — runs always.
-- Step 0.7 (resume detection) — runs after Step 0.
-- **Step 0.55 (1.x detection) — runs after Step 0.7, only when the project is not on a 2.0 layout.**
-- Step 1 (mode selection) — runs after Step 0.55.
-
-The 1.x detection is intentionally placed AFTER Step 0.7 because the user might already have a 1.x-converted in-flight slice; the resume flow takes precedence over the upgrade prompt.
-
-> **Historical note (prior to 2026-07-08 RR slice):** an OpenSpec first-run opt-in step (Step 0.5) used to sit between Step 0 and Step 0.7. peaks-code is now decoupled from OpenSpec and does not surface that step; this reference still preserves the historical ordering for context.