p-dev-harness 0.3.1 → 0.4.0

package/workspace-snapshot/files/tests/gui/m6-configure-boundaries.test.ts

@@ -21,8 +21,6 @@ const M6_GUI_COMPONENTS = [
   "apps/gui/components/custom/configure-experience.tsx",
   "apps/gui/components/custom/first-run-stepper.tsx",
   "apps/gui/components/custom/readiness-banner.tsx",
-  "apps/gui/components/custom/setup-dashboard.tsx",
-  "apps/gui/components/custom/setup-readonly-sections.tsx",
   "apps/gui/components/custom/configure-workflow.tsx",
   "apps/gui/components/custom/environment-config-form.tsx",
   "apps/gui/components/custom/github-token-help-disclosure.tsx",
@@ -73,7 +71,9 @@ describe("M6 configure GUI boundaries", () => {
     expect(source).toContain("Setup complete");
     expect(source).toContain('title="Setup complete"');
     expect(source).not.toContain("Blocked for first run");
-    expect(source).toContain('useState<ConfigureMode>("guided")');
+    expect(source).not.toContain("ConfigureMode");
+    expect(source).not.toContain("Advanced checklist view");
+    expect(source).not.toContain("SetupDashboard");
     expect(source).toContain("GuidedLocalReadinessCard");
     expect(source).toContain("GuidedCloudSecretsCard");
     expect(source).toContain("GuidedTargetWorkflowCard");
@@ -92,16 +92,10 @@ describe("M6 configure GUI boundaries", () => {
     expect(source).toContain("handleRemoteUiStateChange");
     expect(source).toContain("onUiStateChange={handleLocalUiStateChange}");
     expect(source).toContain("onUiStateChange={handleRemoteUiStateChange}");
-    expect(source).toContain("onLocalUiStateChange={handleLocalUiStateChange}");
-    expect(source).toContain("onRemoteUiStateChange={handleRemoteUiStateChange}");
+    expect(source).not.toContain("onLocalUiStateChange=");
+    expect(source).not.toContain("onRemoteUiStateChange=");
     expect(source).toContain("cloudSecretsApplyEvidence");
     expect(source).toContain("remoteSecretPreviewStale");
-    expect(source).not.toMatch(
-      /onLocalUiStateChange=\{\(state\) =>\s*\n?\s*setUiState/,
-    );
-    expect(source).not.toMatch(
-      /onRemoteUiStateChange=\{\(state\) =>\s*\n?\s*setUiState/,
-    );
     expect(source).not.toMatch(
       /onUiStateChange=\{\(state\) =>\s*\n?\s*setUiState/,
     );
@@ -118,20 +112,31 @@ describe("M6 configure GUI boundaries", () => {
     expect(source).toContain("[readiness.currentStepId]");
   });
 
+  it("configure page uses Initial Harness Configuration title", () => {
+    const source = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-experience.tsx"),
+      "utf8",
+    );
+
+    expect(source).toContain("Initial Harness Configuration");
+    expect(source).not.toContain("Settings / Configure");
+  });
+
   it("guided configure experience hides readiness diagnostics by default", () => {
     const source = readFileSync(
       path.join(repoRoot, "apps/gui/components/custom/configure-experience.tsx"),
       "utf8",
     );
 
-    expect(source).toContain('mode === "advanced" ? <ReadinessBanner');
+    expect(source).not.toContain("ReadinessBanner");
+    expect(source).not.toContain("Advanced checklist view");
+    expect(source).not.toContain("SetupDashboard");
     expect(source).toContain('mode="guided"');
     expect(source).toContain("switch (displayedGuidedStep)");
     expect(source).toContain('case "local-readiness":');
-    expect(source).toContain('mode === "advanced" ? (');
-    expect(source).toContain("justify-between");
+    expect(source).toContain("GuidedSetupProgress");
     expect(source).not.toContain("PrimarySetupTaskCard");
-    expect(source).toMatch(/mode === "advanced" \? \([\s\S]*configBadgeLabel/);
+    expect(source).not.toContain("configBadgeLabel");
   });
 
   it("guided workflow renders one active step with animated transitions", () => {
@@ -139,6 +144,10 @@ describe("M6 configure GUI boundaries", () => {
       path.join(repoRoot, "apps/gui/components/custom/configure-workflow.tsx"),
       "utf8",
     );
+    const experienceSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-experience.tsx"),
+      "utf8",
+    );
     const transitionSource = readFileSync(
       path.join(
         repoRoot,
@@ -146,9 +155,18 @@ describe("M6 configure GUI boundaries", () => {
       ),
       "utf8",
     );
+    const progressSource = readFileSync(
+      path.join(
+        repoRoot,
+        "apps/gui/components/custom/guided-setup-progress.tsx",
+      ),
+      "utf8",
+    );
 
-    expect(workflowSource).toContain("GuidedStepTransition");
-    expect(workflowSource).toContain("stepKey={guidedStep}");
+    expect(workflowSource).not.toContain("GuidedStepTransition");
+    expect(experienceSource).toContain("GuidedStepTransition");
+    expect(experienceSource).toContain("getGuidedTransitionDirection");
+    expect(experienceSource).toContain('stepKey={displayedGuidedStep}');
     expect(workflowSource).not.toContain("Back to service keys");
     expect(workflowSource).not.toContain("Back to target repo");
     expect(workflowSource).not.toContain(
@@ -157,8 +175,12 @@ describe("M6 configure GUI boundaries", () => {
     expect(workflowSource).not.toContain(
       "Target repo is set. You can go back to change it before applying.",
     );
-    expect(transitionSource).toContain("AnimatePresence");
-    expect(transitionSource).toContain("useReducedMotion");
+    expect(transitionSource).toContain('mode="wait"');
+    expect(transitionSource).toContain('x: "100vw"');
+    expect(transitionSource).toContain('x: "-100vw"');
+    expect(transitionSource).toContain("overflow-x-hidden");
+    expect(transitionSource).toContain("panelRef?.current?.contains(document.activeElement)");
+    expect(progressSource).toContain("GuidedProgressCheck");
   });
 
   it("guided workflow hides advanced fields from default view", () => {
@@ -194,6 +216,7 @@ describe("M6 configure GUI boundaries", () => {
     expect(guidedEnvBlock).toBeDefined();
     expect(guidedEnvBlock).not.toContain("GITHUB_DISPATCH_REPOSITORY");
     expect(guidedEnvBlock).toContain("ServiceConnectionCard");
+    expect(guidedEnvBlock).not.toContain("envKey");
     expect(guidedEnvBlock).toContain("space-y-4");
     expect(targetSource).toContain('variant === "guided-minimal"');
     const guidedTargetBlock = targetSource.match(
@@ -344,13 +367,13 @@ describe("M6 configure GUI boundaries", () => {
     );
 
     expect(envSource).toContain(
-      "Go to Linear, create or copy your API key, then paste it here.",
+      "Copy an existing Linear API key or create a new one, then paste it here.",
     );
     expect(envSource).toContain(
-      "Go to Cursor, create or copy your API key, then paste it here.",
+      "Copy an existing Cursor API key or create a new one, then paste it here.",
     );
     expect(envSource).toContain(
-      "Go to Vercel, create or copy your token, then paste it here.",
+      "Copy an existing Vercel token or create a new one, then paste it here.",
     );
     expect(envSource).toContain(
       "Lets the harness read and update Linear issues.",
@@ -359,7 +382,7 @@ describe("M6 configure GUI boundaries", () => {
       "Used to spin up Cursor agents that do the planning and development work.",
     );
     expect(envSource).toContain(
-      "Used to create or access Vercel previews so implementation work can be verified before code is merged.",
+      "Used to configure the PDev automation bridge hosted on Vercel (not target-app preview deployment).",
     );
     expect(envSource).not.toContain("during later automation phases");
     expect(envSource).not.toContain("Lets later Cursor SDK runs authenticate.");
@@ -378,7 +401,7 @@ describe("M6 configure GUI boundaries", () => {
     expect(workflowSource).not.toContain("handleSaveConnectServices");
 
     const guidedPanelBlock = experienceSource.match(
-      /mode === "guided" \? \([\s\S]*?\) : \(/,
+      /<GuidedStepTransition[\s\S]*?\{renderGuidedActionPanel\(\)\}[\s\S]*?<\/GuidedStepTransition>/,
     )?.[0];
     expect(guidedPanelBlock).toBeDefined();
     expect(guidedPanelBlock).not.toContain("prohibitedActionsNote");
@@ -535,6 +558,8 @@ describe("M6 configure GUI boundaries", () => {
     expect(readinessCardSource).toContain("/api/setup/local-readiness");
     expect(readinessCardSource).toContain("LocalReadinessChecklist");
     expect(routeSource).toContain("runLocalReadinessChecks");
+    expect(routeSource).toContain("resolveHarnessWorkspaceDir");
+    expect(routeSource).not.toContain("resolveHarnessRepoRoot");
     expect(readinessCardSource).not.toContain("CLI-only");
     expect(readinessCardSource).not.toContain("Milestone 3");
     expect(readinessCardSource).not.toContain("npm run harness:doctor");
@@ -576,13 +601,17 @@ describe("M6 configure GUI boundaries", () => {
     );
   });
 
-  it("back to guided flow does not force local setup wizard state", () => {
+  it("guided flow has no advanced checklist mode toggle", () => {
     const experienceSource = readFileSync(
       path.join(repoRoot, "apps/gui/components/custom/configure-experience.tsx"),
       "utf8",
     );
 
-    expect(experienceSource).toContain('onClick={() => setMode("guided")}');
+    expect(experienceSource).not.toContain("Advanced checklist view");
+    expect(experienceSource).not.toContain("Back to guided flow");
+    expect(experienceSource).not.toContain("setMode");
+    expect(experienceSource).not.toContain("ConfigureMode");
+    expect(experienceSource).not.toContain("SetupDashboard");
     expect(experienceSource).not.toContain("setGuidedLocalSetupActive(true)");
     expect(experienceSource).not.toContain("guidedLocalSetupActive");
   });
@@ -603,7 +632,8 @@ describe("M6 configure GUI boundaries", () => {
     expect(readinessCardSource).toContain(
       "We're checking whether this machine is ready for remote setup.",
     );
-    expect(readinessCardSource).toContain("Local readiness passed.");
+    expect(readinessCardSource).toContain("GuidedStepSuccessPanel");
+    expect(readinessCardSource).toContain("onStepCompleted");
     expect(readinessCardSource).toContain("<LocalReadinessChecklist checks={checks} />");
     expect(experienceSource).toContain("switch (displayedGuidedStep)");
     expect(experienceSource).not.toContain("readiness.primaryTask?.stepId");
@@ -633,7 +663,9 @@ describe("M6 configure GUI boundaries", () => {
     expect(envSource).toContain("GitHubTokenHelpDisclosure");
     expect(envSource).not.toContain("Step 4");
     expect(envSource).not.toContain("Step 5");
-    expect(GITHUB_TOKEN_INPUT_LABEL).toBe("Paste your GitHub token");
+    expect(GITHUB_TOKEN_INPUT_LABEL).toBe(
+      "Copy an existing GitHub personal access token or create a new one, then paste it here.",
+    );
     expect(GITHUB_TOKEN_GUIDED_HELPER_TEXT).toContain("repo and workflow access");
     expect(GITHUB_TOKEN_GUIDED_HELPER_TEXT).not.toContain("Step 4");
     expect(GITHUB_TOKEN_GUIDED_HELPER_TEXT).not.toContain("Step 5");
@@ -710,7 +742,7 @@ describe("M6 configure GUI boundaries", () => {
     expect(experienceSource).toContain("GUIDED_DISPLAY_STEP_AFTER_LOCAL_APPLY");
     expect(experienceSource).toContain("localReadinessReviewed: false");
     expect(experienceSource).toContain("cloudSecretsReviewed: false");
-    expect(experienceSource).toContain("remoteSecretPreviewStale: true");
+    expect(experienceSource).toContain("remoteSecretPreviewStale: current.cloudSecretsPreviewOpened");
     expect(experienceSource).toContain("localSetupFilesExist={localSetupFilesExist(summary)}");
 
     const guidedSectionEnd = workflowSource.indexOf(
@@ -773,7 +805,8 @@ describe("M6 configure GUI boundaries", () => {
     expect(prCardSource).toContain('variant === "advanced" && successMessage');
 
     expect(pendingPanelSource).toContain("WorkflowInstallProgressPanel");
-    expect(pendingPanelSource).toContain("Merging automatically");
+    expect(pendingPanelSource).toContain("WORKFLOW_INSTALL_UI_PHASE_LABELS");
+    expect(pendingPanelSource).toContain("GuidedOperationPanel");
     expect(pendingPanelSource).toContain("Open GitHub details");
     expect(pendingPanelSource).not.toContain("Merge the PR in GitHub");
     expect(pendingPanelSource).not.toMatch(/auto-merge|dispatch|harness phase/i);
@@ -796,7 +829,8 @@ describe("M6 configure GUI boundaries", () => {
     expect(experienceSource).toContain("showGuidedBackButton");
     expect(experienceSource).toContain("shouldShowGuidedBackButton(displayedGuidedStep)");
     expect(experienceSource).toContain('variant="ghost"');
-    expect(experienceSource).toContain("Advanced checklist view");
+    expect(experienceSource).not.toContain("Advanced checklist view");
+    expect(experienceSource).not.toContain("setMode");
     expect(experienceSource).toContain("defaultGuidedDisplayStep");
     expect(experienceSource).toContain("previousReadinessStepRef");
     expect(experienceSource).toContain("shouldReadinessAdvanceGuidedDisplay");
@@ -804,7 +838,6 @@ describe("M6 configure GUI boundaries", () => {
     expect(experienceSource).not.toContain("localPreviewStale: true");
     expect(experienceSource).not.toMatch(/history\.back|router\.back/);
     expect(experienceSource).not.toMatch(/localStorage|sessionStorage/);
-    expect(experienceSource).toContain('onClick={() => setMode("guided")}');
   });
 
   it("Step 1 verify-and-save does not call onConnectServicesComplete", () => {
@@ -820,7 +853,40 @@ describe("M6 configure GUI boundaries", () => {
     expect(workflowSource).toContain("verifyAndSaveService");
     expect(verifyBlock).toBeDefined();
     expect(verifyBlock).not.toContain("onConnectServicesComplete");
-    expect(workflowSource).toContain("onConnectServicesComplete?.()");
+    // Continue advances only via GuidedStepSuccessPanel after successful provisioning.
+    expect(workflowSource).toContain(
+      "onContinue={onConnectServicesComplete ?? (() => undefined)}",
+    );
+    expect(workflowSource).toContain("onConnectServicesSucceeded?.()");
+    expect(workflowSource).not.toContain("onConnectServicesComplete?.()");
+  });
+
+  it("Step 1 verification returns to a retryable failed state without clearing the token", () => {
+    const workflowSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-workflow.tsx"),
+      "utf8",
+    );
+    const formSource = readFileSync(
+      path.join(
+        repoRoot,
+        "apps/gui/components/custom/environment-config-form.tsx",
+      ),
+      "utf8",
+    );
+
+    const verifyBlock = workflowSource.match(
+      /const runServiceVerification = useCallback\([\s\S]*?\n  \);/,
+    )?.[0];
+
+    expect(verifyBlock).toBeDefined();
+    expect(verifyBlock).toContain('state: "checking"');
+    expect(verifyBlock).toContain('state: "failed"');
+    expect(verifyBlock).toContain("setVerifyingServiceKey(null)");
+    expect(verifyBlock).not.toContain("setEnvValues");
+    expect(workflowSource).toContain("verifyAndSaveService");
+    expect(formSource).toContain("verifyButtonDisabled =");
+    expect(formSource).toContain("verifying ||");
+    expect(formSource).toContain("verifiedForCurrentValue");
   });
 
   it("explicit Continue handler remains the Step 1 to Step 2 transition", () => {
@@ -855,13 +921,66 @@ describe("M6 configure GUI boundaries", () => {
     expect(experienceSource).toContain('case "target-workflow":');
   });
 
-  it("top nav renders the theme toggle", () => {
+  it("guided mode renders a display-only seven-stage progress indicator", () => {
+    const experienceSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-experience.tsx"),
+      "utf8",
+    );
+    const progressSource = readFileSync(
+      path.join(
+        repoRoot,
+        "apps/gui/components/custom/guided-setup-progress.tsx",
+      ),
+      "utf8",
+    );
+
+    expect(experienceSource).toContain("GuidedSetupProgress");
+    expect(experienceSource).toContain("deriveGuidedProgressStages");
+    expect(experienceSource).toContain("<GuidedSetupProgress stages={guidedProgressStages} />");
+    expect(progressSource).toContain('aria-label="Guided setup progress"');
+    expect(progressSource).toContain('aria-current={isCurrent ? "step" : undefined}');
+    expect(progressSource).toContain("useReducedMotion");
+    expect(progressSource).not.toContain("onClick");
+    expect(progressSource).not.toContain("<button");
+    expect(progressSource).not.toContain('role="tab"');
+  });
+
+  it("guided Step 1 uses concise workspace setup button labels", () => {
+    const workflowSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-workflow.tsx"),
+      "utf8",
+    );
+
+    expect(workflowSource).toContain("Set up workspace");
+    expect(workflowSource).toContain("GuidedOperationPanel");
+    expect(workflowSource).toContain("Creating private workspace");
+    expect(workflowSource).toContain("GuidedStepSuccessPanel");
+    expect(workflowSource).not.toContain(
+      "Continue and set up private p-dev workspace",
+    );
+    expect(workflowSource).not.toContain(
+      "Setting up your private p-dev workspace",
+    );
+  });
+
+  it("top nav renders the settings menu instead of a standalone theme toggle", () => {
     const appShellSource = readFileSync(
       path.join(repoRoot, "apps/gui/components/custom/app-shell.tsx"),
       "utf8",
     );
+    const settingsMenuSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/settings-menu.tsx"),
+      "utf8",
+    );
 
-    expect(appShellSource).toContain("ThemeToggle");
+    expect(appShellSource).toContain("ApplicationHeader");
+    expect(appShellSource).not.toContain("ThemeToggle");
+    expect(settingsMenuSource).toContain("Settings");
+    expect(settingsMenuSource).toContain("Workflow");
+    expect(settingsMenuSource).not.toContain("Setup wizard");
+    expect(settingsMenuSource).not.toContain("Data sharing");
+    expect(settingsMenuSource).toContain("Dark mode");
+    expect(settingsMenuSource).toContain("Light mode");
   });
 
   it("guided linear workspace card loads teams and projects from linear-options", () => {
@@ -881,4 +1000,27 @@ describe("M6 configure GUI boundaries", () => {
     expect(linearCardSource).not.toContain('placeholder="Project ID"');
     expect(linearCardSource).toContain("Select a project…");
   });
+
+  it("guided Step 4 supports create/connect target repo provisioning without silent local apply", () => {
+    const workflowSource = readFileSync(
+      path.join(repoRoot, "apps/gui/components/custom/configure-workflow.tsx"),
+      "utf8",
+    );
+    const createConnectSource = readFileSync(
+      path.join(
+        repoRoot,
+        "apps/gui/components/custom/target-repo-create-connect.tsx",
+      ),
+      "utf8",
+    );
+
+    expect(workflowSource).toContain("TargetRepoCreateConnect");
+    expect(workflowSource).toContain("targetRepoSelectionMode");
+    expect(workflowSource).toContain("handleTargetRepoCreated");
+    expect(createConnectSource).toContain(
+      "/api/setup/preview-target-repo-provisioning",
+    );
+    expect(createConnectSource).not.toContain("apply-local-files");
+    expect(createConnectSource).not.toContain("onGuidedLocalApplySuccess");
+  });
 });