p-dev-harness 0.3.1 → 0.4.0

package/workspace-snapshot/files/src/runner/phases/merge.ts

@@ -31,6 +31,9 @@ import {
   writeCommentsArtifact,
 } from "../../linear/comments.js";
 import { parseHarnessMarkers } from "../../linear/markers.js";
+import { syncProjectHarnessMetadataAfterFoundationMerge } from "../../linear/project-metadata-sync.js";
+import { runLinearAssociationGate } from "../../config/linear-association-gate.js";
+import { getLinearProject } from "../../setup/linear-setup-client.js";
 import { fetchLinearIssue } from "../../linear/client.js";
 import { findLatestMergeSourceComment } from "../../linear/merge-source-comment.js";
 import {
@@ -39,6 +42,7 @@ import {
   postErrorComment,
   postMergeCompletionComment,
   postPhaseStartCommentIfNeeded,
+  postIssueComment,
   transitionIssueStatus,
 } from "../../linear/writer.js";
 import { GitHubClient } from "../../github/client.js";
@@ -56,9 +60,10 @@ import {
 } from "../../github/pr-inspector.js";
 import { parsePrUrl, type ParsedPrUrl } from "../../github/pr-url.js";
 import { pollForProductionDeployment, inferVercelReadyFromComments } from "../../preview/production-from-merge.js";
+import { shouldCaptureApplicationPreview } from "../../preview/preview-capability.js";
 import { resolvePreviewLinks } from "../../preview/urls.js";
 import { normalizeRepoUrl } from "../../resolver/normalize-repo.js";
-import { resolveModelId } from "../../agents/index.js";
+import { manifestModelEvidence } from "../../cursor/model.js";
 import { MergeError } from "../errors.js";
 import { attemptIntegrationRepair } from "./integration-repair.js";
 import { runPreflight } from "../preflight.js";
@@ -352,7 +357,7 @@ export async function executeMergePhase(
       prUrl: null,
       previewUrl: null,
       validationSummary: null,
-      model: preflight.config ? resolveModelId(preflight.config) : null,
+      model: null,
       ...emptyMergeManifestFields(),
     };
     return writeFinalManifest(
@@ -398,14 +403,18 @@ export async function executeMergePhase(
   let deploymentUrl: string | null = null;
   let enteredMerging = false;
   let prMerged = false;
-  const model = resolveModelId(config);
+  let manifestModel: string | null = null;
+  let manifestModelRole: "builder" | null = null;
+  let manifestModelParams: Array<{ id: string; value: string }> | null = null;
+  let repairCursorAgentId: string | null = null;
+  let repairCursorRunId: string | null = null;
   const commentsWritten: string[] = [];
 
+  let footerModel = "";
   const footerBase = {
     orchestratorMarker: config.orchestratorMarker,
     phase: "merge",
     runId,
-    model,
     promptVersion: MERGE_PROMPT_VERSION,
     targetRepo: resolved.targetRepo,
     baseBranch: resolved.baseBranch,
@@ -512,7 +521,7 @@ export async function executeMergePhase(
         mergeMethod,
         mergedAt: null,
         deploymentUrl,
-        model,
+        model: null,
       };
       return writeFinalManifest(
         manifest,
@@ -546,7 +555,7 @@ export async function executeMergePhase(
           issueKey: issue.identifier,
           targetRepo: markerTargetRepo,
           baseBranch: resolved.baseBranch,
-          model,
+          model: footerModel,
           promptVersion: MERGE_PROMPT_VERSION,
           branch: branch ?? undefined,
           prUrl,
@@ -647,7 +656,7 @@ export async function executeMergePhase(
         mergeMethod,
         mergedAt: preInspection.mergedAt,
         deploymentUrl,
-        model,
+        model: null,
       };
       return writeFinalManifest(
         manifest,
@@ -723,6 +732,7 @@ export async function executeMergePhase(
         checkPolicy.decision === "block" &&
         (checkPolicy.classification === "checks_pending" ||
           checkPolicy.classification === "checks_unknown") &&
+        shouldCaptureApplicationPreview(resolved.previewProvider) &&
         inferVercelReadyFromComments(preInspection.comments)
       ) {
         const warning =
@@ -819,11 +829,19 @@ export async function executeMergePhase(
             runId,
             runDirectory,
             events,
-            model,
+            model: manifestModelEvidence(config, "builder").model,
             initialInspection: preInspection,
             cursorApiKey: process.env.CURSOR_API_KEY,
           });
           preInspection = repair.inspection;
+          if (repair.agentEvidence) {
+            manifestModel = repair.agentEvidence.model;
+            manifestModelRole = repair.agentEvidence.modelRole;
+            manifestModelParams = repair.agentEvidence.modelParams;
+            repairCursorAgentId = repair.agentEvidence.cursorAgentId;
+            repairCursorRunId = repair.agentEvidence.cursorRunId;
+            footerModel = repair.agentEvidence.model;
+          }
           changedFiles = preInspection.changedFiles.map((f) => f.path);
           checkSummary = preInspection.checkSummary;
           validationSummary = [validationSummary, repair.validationSummary]
@@ -929,67 +947,76 @@ export async function executeMergePhase(
     );
 
     if (mergedToProduction) {
-      const deploymentPollTimeout =
-        config.merge?.deploymentPollTimeoutSeconds ??
-        DEFAULT_MERGE_DEPLOYMENT_POLL_TIMEOUT_SECONDS;
-      const deploymentPollInterval =
-        config.merge?.deploymentPollIntervalSeconds ??
-        DEFAULT_MERGE_DEPLOYMENT_POLL_INTERVAL_SECONDS;
-
-      await events.log("deployment_poll_started", "info", {
-        pollTimeoutSeconds: deploymentPollTimeout,
-        mergedToProduction: true,
-      });
-
-      const deploymentResult = await pollForProductionDeployment(
-        async () => {
-          const latest = await inspectPullRequestPostMerge(
-            github,
-            parsedPr,
-            markerTargetRepo,
-          ).catch(() => postInspection);
-          return {
-            comments: latest.comments,
-            checks: latest.checks,
-          };
-        },
-        {
+      if (shouldCaptureApplicationPreview(resolved.previewProvider)) {
+        const deploymentPollTimeout =
+          config.merge?.deploymentPollTimeoutSeconds ??
+          DEFAULT_MERGE_DEPLOYMENT_POLL_TIMEOUT_SECONDS;
+        const deploymentPollInterval =
+          config.merge?.deploymentPollIntervalSeconds ??
+          DEFAULT_MERGE_DEPLOYMENT_POLL_INTERVAL_SECONDS;
+
+        await events.log("deployment_poll_started", "info", {
           pollTimeoutSeconds: deploymentPollTimeout,
-          pollIntervalSeconds: deploymentPollInterval,
-          productionUrlReference: productionReference,
-        },
-      );
+          mergedToProduction: true,
+        });
 
-      deploymentUrl = deploymentResult.deploymentUrl;
-      await mkdir(`${runDirectory}/vercel`, { recursive: true });
-      await writeFile(
-        getProductionDeploymentPath(runDirectory),
-        `${JSON.stringify(deploymentResult, null, 2)}\n`,
-        "utf8",
-      );
+        const deploymentResult = await pollForProductionDeployment(
+          async () => {
+            const latest = await inspectPullRequestPostMerge(
+              github,
+              parsedPr,
+              markerTargetRepo,
+            ).catch(() => postInspection);
+            return {
+              comments: latest.comments,
+              checks: latest.checks,
+            };
+          },
+          {
+            pollTimeoutSeconds: deploymentPollTimeout,
+            pollIntervalSeconds: deploymentPollInterval,
+            productionUrlReference: productionReference,
+          },
+        );
 
-      const deploymentRequired =
-        config.merge?.deploymentRequiredForSuccess ??
-        DEFAULT_MERGE_DEPLOYMENT_REQUIRED;
-
-      let deploymentWarning: string | null = null;
-      if (!deploymentUrl) {
-        deploymentWarning =
-          deploymentResult.warnings.join("; ") ||
-          "Production deployment URL not captured";
-        await events.log("deployment_not_found", "warn", {
-          warnings: deploymentResult.warnings,
-        });
-        if (deploymentRequired) {
-          throw new MergeError("deployment_not_found", deploymentWarning);
+        deploymentUrl = deploymentResult.deploymentUrl;
+        await mkdir(`${runDirectory}/vercel`, { recursive: true });
+        await writeFile(
+          getProductionDeploymentPath(runDirectory),
+          `${JSON.stringify(deploymentResult, null, 2)}\n`,
+          "utf8",
+        );
+
+        const deploymentRequired =
+          config.merge?.deploymentRequiredForSuccess ??
+          DEFAULT_MERGE_DEPLOYMENT_REQUIRED;
+
+        let deploymentWarning: string | null = null;
+        if (!deploymentUrl) {
+          deploymentWarning =
+            deploymentResult.warnings.join("; ") ||
+            "Production deployment URL not captured";
+          await events.log("deployment_not_found", "warn", {
+            warnings: deploymentResult.warnings,
+          });
+          if (deploymentRequired) {
+            throw new MergeError("deployment_not_found", deploymentWarning);
+          }
+          validationSummary = [validationSummary, deploymentWarning]
+            .filter(Boolean)
+            .join("; ");
+        } else {
+          await events.log("deployment_captured", "info", {
+            deploymentUrl,
+            source: deploymentResult.source,
+          });
         }
-        validationSummary = [validationSummary, deploymentWarning]
-          .filter(Boolean)
-          .join("; ");
       } else {
-        await events.log("deployment_captured", "info", {
-          deploymentUrl,
-          source: deploymentResult.source,
+        await events.log("deployment_poll_skipped", "info", {
+          reason: "application_preview_not_configured",
+          previewProvider: resolved.previewProvider,
+          baseBranch: resolved.baseBranch,
+          productionBranch: resolved.productionBranch,
         });
       }
     } else {
@@ -1030,6 +1057,7 @@ export async function executeMergePhase(
 
     const mergeFooter = {
       ...footerBase,
+      model: footerModel,
       issueKey: options.issueKey,
       productionBranch: resolved.productionBranch,
       integrationSuccessStatus:
@@ -1076,6 +1104,53 @@ export async function executeMergePhase(
       await writeCommentsArtifact(runDirectory, commentsWritten);
     }
 
+    if (issue.projectId && resolved.baseBranch !== resolved.productionBranch) {
+      const associationGate = runLinearAssociationGate({
+        config,
+        teamId: issue.teamId,
+        projectId: issue.projectId,
+      });
+      if (!associationGate.ok) {
+        await events.log("project_metadata_sync", "info", {
+          updated: false,
+          skippedReason: associationGate.code,
+        });
+      } else {
+      const project = await getLinearProject(client, issue.projectId);
+      if (project) {
+        const metadataSync = await syncProjectHarnessMetadataAfterFoundationMerge({
+          linearClient: client,
+          projectId: issue.projectId,
+          currentDescription: project.description,
+          targetRepo: resolved.targetRepo,
+          developmentBranch: resolved.baseBranch,
+          github,
+          orchestratorMarker: config.orchestratorMarker,
+          mergeRunId: runId,
+          comments,
+        });
+        await events.log("project_metadata_sync", "info", {
+          updated: metadataSync.updated,
+          skippedReason: metadataSync.skippedReason,
+          initializationState: metadataSync.productInitialization?.state,
+        });
+        if (metadataSync.updated) {
+          const syncComment = [
+            "Harness updated Linear project metadata to `Product initialization: initialized` after foundation merge.",
+            "",
+            "<!--",
+            config.orchestratorMarker,
+            "phase: project_metadata_initialized_sync",
+            `run_id: ${runId}`,
+            `target_repo: ${resolved.targetRepo}`,
+            "-->",
+          ].join("\n");
+          await postIssueComment(client, issue.id, syncComment);
+        }
+      }
+      }
+    }
+
     finalOutcome = "success";
     errorClassification = null;
   } catch (error) {
@@ -1090,6 +1165,7 @@ export async function executeMergePhase(
 
     const mergeFooter = {
       ...footerBase,
+      model: footerModel,
       branch: branch ?? undefined,
       prUrl: prUrl ?? undefined,
       previewUrl: previewUrl ?? undefined,
@@ -1171,8 +1247,8 @@ export async function executeMergePhase(
     finishedAt: new Date().toISOString(),
     milestone: MILESTONE,
     promptVersion: MERGE_PROMPT_VERSION,
-    cursorAgentId: null,
-    cursorRunId: null,
+    cursorAgentId: repairCursorAgentId,
+    cursorRunId: repairCursorRunId,
     branch,
     prUrl,
     previewUrl,
@@ -1187,7 +1263,9 @@ export async function executeMergePhase(
     mergeMethod,
     mergedAt,
     deploymentUrl,
-    model,
+    model: manifestModel,
+    modelRole: manifestModelRole,
+    modelParams: manifestModelParams,
   };
 
   return writeFinalManifest(

package/workspace-snapshot/files/src/runner/phases/planning.ts

@@ -25,12 +25,14 @@ import {
 import {
   createPlanningAgent,
   disposeAgent,
-  resolveModelId,
   sendAndObserve,
 } from "../../agents/index.js";
+import { manifestModelEvidence } from "../../cursor/model.js";
 import { buildPlanningPrompt } from "../../prompts/builder.js";
 import { PlanningError } from "../errors.js";
 import { runPreflight } from "../preflight.js";
+import { resolveRunGeneration } from "../run-generation.js";
+import { updateRunStatusPhase } from "../../linear/run-status-comment.js";
 import {
   assertPlanningEligibleStatus,
   checkPlanningIdempotency,
@@ -114,6 +116,8 @@ export async function executePlanningPhase(
   });
 
   if (!preflight.success) {
+    const isDuplicateDelivery =
+      preflight.errorClassification === "duplicate_delivery";
     const manifest: RunManifest = {
       runId: preflight.runId,
       issueKey: options.issueKey,
@@ -125,7 +129,7 @@ export async function executePlanningPhase(
       baseBranch: preflight.resolved?.baseBranch ?? null,
       resolutionSource: preflight.resolved?.resolutionSource ?? null,
       dryRun: false,
-      finalOutcome: "failed",
+      finalOutcome: isDuplicateDelivery ? "duplicate" : "failed",
       errorClassification: preflight.errorClassification,
       startedAt: preflight.startedAt.toISOString(),
       finishedAt: new Date().toISOString(),
@@ -143,7 +147,16 @@ export async function executePlanningPhase(
       previousHandoffRunId: null,
       pmFeedbackCommentId: null,
       ...emptyMergeManifestFields(),
-      model: preflight.config ? resolveModelId(preflight.config) : null,
+      model: preflight.config
+        ? manifestModelEvidence(preflight.config, "planner").model
+        : null,
+      modelRole: preflight.config ? "planner" : null,
+      modelParams: preflight.config
+        ? manifestModelEvidence(preflight.config, "planner").modelParams
+        : null,
+      deliveryId: process.env.LINEAR_DELIVERY_ID ?? null,
+      runGeneration: resolveRunGeneration(),
+      runOwnedStatuses: preflight.issue?.status ? [preflight.issue.status] : null,
     };
     return writeFinalManifest(
       manifest,
@@ -151,16 +164,17 @@ export async function executePlanningPhase(
       preflight.parsed,
       preflight.resolved,
       preflight.events,
-      "failed",
+      isDuplicateDelivery ? "duplicate" : "failed",
       preflight.errorClassification,
     );
   }
 
   const {
     config,
-    issue,
+    issue: preflightIssue,
     parsed,
     resolved,
+    productInitialization,
     runId,
     runDirectory,
     events,
@@ -169,6 +183,7 @@ export async function executePlanningPhase(
     startedAt,
   } = preflight.context;
 
+  let issue = preflightIssue;
   const linearStatusBefore = issue.status;
   let linearStatusAfter = issue.status;
   let finalOutcome: FinalOutcome = "failed";
@@ -176,7 +191,8 @@ export async function executePlanningPhase(
   let cursorAgentId: string | null = null;
   let cursorRunId: string | null = null;
   let promptVersion: string | null = null;
-  const model = resolveModelId(config);
+  const plannerModel = manifestModelEvidence(config, "planner");
+  const model = plannerModel.model;
   let enteredPlanning = false;
   const commentsWritten: string[] = [];
 
@@ -190,11 +206,20 @@ export async function executePlanningPhase(
     baseBranch: resolved.baseBranch,
   };
 
+  const deliveryId = process.env.LINEAR_DELIVERY_ID ?? null;
+  const runGeneration = resolveRunGeneration();
+  let runOwnedStatuses = [linearStatusBefore].filter(Boolean) as string[];
+
   const client = createLinearClient(linearApiKey);
 
   try {
+    const freshIssue = await fetchLinearIssue(options.issueKey, linearApiKey);
+    issue = freshIssue;
+    linearStatusAfter = freshIssue.status;
+    runOwnedStatuses = [linearStatusBefore, freshIssue.status].filter(Boolean) as string[];
+
     try {
-      assertPlanningEligibleStatus(config, issue, Boolean(options.force));
+      assertPlanningEligibleStatus(config, freshIssue, Boolean(options.force));
     } catch (error) {
       throw new PlanningError(
         "wrong_status",
@@ -243,6 +268,9 @@ export async function executePlanningPhase(
       pmFeedbackCommentId: null,
         ...emptyMergeManifestFields(),
         model,
+        deliveryId,
+        runGeneration,
+        runOwnedStatuses,
       };
       return writeFinalManifest(
         manifest,
@@ -259,15 +287,25 @@ export async function executePlanningPhase(
     await transitionIssueStatus(client, issue, planningStatus);
     enteredPlanning = true;
     linearStatusAfter = planningStatus;
+    runOwnedStatuses = [...runOwnedStatuses, planningStatus];
     await events.log("linear_status_changed", "info", {
       from: linearStatusBefore,
       to: planningStatus,
     });
 
+    await updateRunStatusPhase(client, issue.id, {
+      phase: planningStatus,
+      headline: "Planning in progress",
+      runId,
+      deliveryId,
+      generation: runGeneration,
+    });
+
     const { prompt, promptVersion: version } = await buildPlanningPrompt(
       issue,
       parsed,
       resolved,
+      { productInitializationState: productInitialization.state },
     );
     promptVersion = version;
     await mkdir(`${runDirectory}/prompts`, { recursive: true });
@@ -442,6 +480,11 @@ export async function executePlanningPhase(
     pmFeedbackCommentId: null,
     ...emptyMergeManifestFields(),
     model,
+    modelRole: "planner",
+    modelParams: plannerModel.modelParams,
+    deliveryId,
+    runGeneration,
+    runOwnedStatuses,
   };
 
   return writeFinalManifest(

package/workspace-snapshot/files/src/runner/phases/production-sync.ts

@@ -22,10 +22,16 @@ import {
 } from "../../linear/writer.js";
 import { GitHubClient } from "../../github/client.js";
 import { resolvePromotionProof } from "../../github/commit-reachability.js";
-import { resolveModelId } from "../../agents/index.js";
 import { resolveTargetRepo } from "../../resolver/target-repo.js";
+import { shouldCaptureApplicationPreview } from "../../preview/preview-capability.js";
 import { loadHarnessConfig } from "../../config/load-config.js";
+import { resolveHarnessWorkspaceRootFromConfigSource } from "../../config/workspace-root.js";
 import { checkProductionSyncIdempotency } from "../idempotency.js";
+import {
+  CanonicalWorkflowGateError,
+  classifyCanonicalGateError,
+  runAuthoritativeCanonicalWorkflowGate,
+} from "../../workflow/canonical-workflow-gate.js";
 import type { RunManifest, FinalOutcome, ErrorClassification } from "../../types/run.js";
 import type { LinearIssueSnapshot } from "../../linear/client.js";
 import type { ResolvedTarget } from "../../resolver/target-repo.js";
@@ -93,14 +99,16 @@ export async function executeProductionSyncForIssue(
 ): Promise<ProductionSyncIssueResult> {
   const startedAt = new Date();
   const runId = createRunId(options.issueKey, startedAt);
-  const { config } = await loadHarnessConfig({ configPath: options.configPath });
+  const loaded = await loadHarnessConfig({ configPath: options.configPath });
+  const config = loaded.config;
+  const workspaceRoot = resolveHarnessWorkspaceRootFromConfigSource(loaded.source);
   const runDirectory = getRunDirectory(
     config.logDirectory,
     options.issueKey,
     runId,
   );
   const events = new EventLogger(runDirectory);
-  const model = resolveModelId(config);
+  const model = "";
 
   let issue: LinearIssueSnapshot | null = null;
   let resolved: ResolvedTarget | null = null;
@@ -131,6 +139,27 @@ export async function executeProductionSyncForIssue(
       config,
     );
 
+    if (!shouldCaptureApplicationPreview(resolved.previewProvider)) {
+      await events.log("application_preview_not_configured", "info", {
+        previewProvider: resolved.previewProvider,
+        phase: "production_sync",
+      });
+    }
+
+    const gateResult = await runAuthoritativeCanonicalWorkflowGate({
+      linearApiKey,
+      config,
+      issue,
+      workspaceRoot,
+      configPath: options.configPath,
+    });
+    if (!gateResult.ok) {
+      throw new CanonicalWorkflowGateError(
+        gateResult.message,
+        gateResult.errorClassification,
+      );
+    }
+
     if (resolved.baseBranch === resolved.productionBranch) {
       finalOutcome = "skipped";
       skippedReason = "base_branch_equals_production_branch";
@@ -261,7 +290,11 @@ export async function executeProductionSyncForIssue(
     }
   } catch (error) {
     finalOutcome = "failed";
-    errorClassification = "github_api_failure";
+    errorClassification =
+      classifyCanonicalGateError(error) ??
+      (error instanceof Error && error.message.includes("GITHUB_TOKEN")
+        ? "github_auth_failure"
+        : "github_api_failure");
     skippedReason = error instanceof Error ? error.message : String(error);
   }