ostacky 0.6.0 → 0.6.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +9 -9
- package/assets/agents/ostacky.md +311 -310
- package/assets/commands/install-stack.md +510 -536
- package/assets/commands/opsx-sync.md +26 -26
- package/assets/mcp/openspec/index.js +1 -1
- package/assets/mcp/openspec/package.json +1 -1
- package/assets/mcp/ostacky-controller/index.js +989 -994
- package/assets/mcp/ostacky-controller/package.json +10 -10
- package/assets/plugins/engram.ts +537 -537
- package/assets/skills/brainstorming/SKILL.md +197 -197
- package/assets/skills/dispatching-parallel-agents/SKILL.md +182 -182
- package/assets/skills/execution-mode-evaluation/SKILL.md +189 -189
- package/assets/skills/graceful-degradation/SKILL.md +235 -235
- package/assets/skills/openspec-apply-change/SKILL.md +167 -167
- package/assets/skills/openspec-archive-change/SKILL.md +114 -114
- package/assets/skills/openspec-explore/SKILL.md +288 -288
- package/assets/skills/openspec-propose/SKILL.md +114 -114
- package/assets/skills/receiving-code-review/SKILL.md +213 -213
- package/assets/skills/review/SKILL.md +216 -216
- package/assets/skills/subagent-driven-development/SKILL.md +302 -302
- package/assets/skills/tdd/SKILL.md +371 -371
- package/assets/skills/using-git-worktrees/SKILL.md +212 -212
- package/assets/skills/using-superpowers/SKILL.md +111 -111
- package/assets/skills/writing-plans/SKILL.md +149 -149
- package/assets/skills/writing-skills/SKILL.md +655 -655
- package/dist/cli.js +2363 -2001
- package/manifest.json +158 -158
- package/package.json +1 -1
|
@@ -1,114 +1,114 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: openspec-propose
|
|
3
|
-
description: Propose a new change with all artifacts generated in one step. Use when the user wants to quickly describe what they want to build and get a complete proposal with design, specs, and tasks ready for implementation.
|
|
4
|
-
license: MIT
|
|
5
|
-
compatibility: Requires openspec CLI.
|
|
6
|
-
metadata:
|
|
7
|
-
author: openspec
|
|
8
|
-
version: "1.0"
|
|
9
|
-
generatedBy: "1.3.1"
|
|
10
|
-
---
|
|
11
|
-
|
|
12
|
-
**IMPORTANT:** Engram is an **MCP server**, not a skill. Tools `mem_save`, `mem_search`, `mem_context` are MCP tools. Do NOT use `skill("engram")` — it doesn't exist.
|
|
13
|
-
|
|
14
|
-
Propose a new change - create the change and generate all artifacts in one step.
|
|
15
|
-
|
|
16
|
-
I'll create a change with artifacts:
|
|
17
|
-
- proposal.md (what & why)
|
|
18
|
-
- design.md (how)
|
|
19
|
-
- tasks.md (implementation steps)
|
|
20
|
-
|
|
21
|
-
When ready to implement, run /opsx-apply
|
|
22
|
-
|
|
23
|
-
---
|
|
24
|
-
|
|
25
|
-
**Input**: The user's request should include a change name (kebab-case) OR a description of what they want to build.
|
|
26
|
-
|
|
27
|
-
**Steps**
|
|
28
|
-
|
|
29
|
-
1. **Check Engram for similar changes** — `mem_search` with keywords from the user's description. If a similar change was proposed or implemented before, surface it to the user. They may want to extend the existing work instead of starting fresh.
|
|
30
|
-
|
|
31
|
-
2. **If no clear input provided, ask what they want to build**
|
|
32
|
-
|
|
33
|
-
Ask the user in natural language (open-ended, no preset options):
|
|
34
|
-
> "What change do you want to work on? Describe what you want to build or fix."
|
|
35
|
-
|
|
36
|
-
From their description, derive a kebab-case name (e.g., "add user authentication" → `add-user-auth`).
|
|
37
|
-
|
|
38
|
-
**IMPORTANT**: Do NOT proceed without understanding what the user wants to build. After asking, stop and wait for their response.
|
|
39
|
-
|
|
40
|
-
3. **Create the change directory**
|
|
41
|
-
```bash
|
|
42
|
-
openspec new change "<name>"
|
|
43
|
-
```
|
|
44
|
-
This creates a scaffolded change at `openspec/changes/<name>/` with `.openspec.yaml`.
|
|
45
|
-
|
|
46
|
-
4. **Get the artifact build order**
|
|
47
|
-
```bash
|
|
48
|
-
openspec status --change "<name>" --json
|
|
49
|
-
```
|
|
50
|
-
Parse the JSON to get:
|
|
51
|
-
- `applyRequires`: array of artifact IDs needed before implementation (e.g., `["tasks"]`)
|
|
52
|
-
- `artifacts`: list of all artifacts with their status and dependencies
|
|
53
|
-
|
|
54
|
-
5. **Create artifacts in sequence until apply-ready**
|
|
55
|
-
|
|
56
|
-
Use the **todowrite tool** to track progress through the artifacts.
|
|
57
|
-
|
|
58
|
-
Loop through artifacts in dependency order (artifacts with no pending dependencies first):
|
|
59
|
-
|
|
60
|
-
a. **For each artifact that is `ready` (dependencies satisfied)**:
|
|
61
|
-
- Get instructions:
|
|
62
|
-
```bash
|
|
63
|
-
openspec instructions <artifact-id> --change "<name>" --json
|
|
64
|
-
```
|
|
65
|
-
- The instructions JSON includes:
|
|
66
|
-
- `context`: Project background (constraints for you - do NOT include in output)
|
|
67
|
-
- `rules`: Artifact-specific rules (constraints for you - do NOT include in output)
|
|
68
|
-
- `template`: The structure to use for your output file
|
|
69
|
-
- `instruction`: Schema-specific guidance for this artifact type
|
|
70
|
-
- `outputPath`: Where to write the artifact
|
|
71
|
-
- `dependencies`: Completed artifacts to read for context
|
|
72
|
-
- Read any completed dependency files for context
|
|
73
|
-
- Create the artifact file using `template` as the structure
|
|
74
|
-
- Apply `context` and `rules` as constraints - but do NOT copy them into the file
|
|
75
|
-
- Show brief progress: "Created <artifact-id>"
|
|
76
|
-
|
|
77
|
-
b. **Continue until all `applyRequires` artifacts are complete**
|
|
78
|
-
- After creating each artifact, re-run `openspec status --change "<name>" --json`
|
|
79
|
-
- Check if every artifact ID in `applyRequires` has `status: "done"` in the artifacts array
|
|
80
|
-
- Stop when all `applyRequires` artifacts are done
|
|
81
|
-
|
|
82
|
-
c. **If an artifact requires user input** (unclear context):
|
|
83
|
-
- Ask the user in natural language to clarify, then stop and wait for the answer
|
|
84
|
-
- Then continue with creation
|
|
85
|
-
|
|
86
|
-
6. **Show final status**
|
|
87
|
-
```bash
|
|
88
|
-
openspec status --change "<name>"
|
|
89
|
-
```
|
|
90
|
-
|
|
91
|
-
**Output**
|
|
92
|
-
|
|
93
|
-
After completing all artifacts, summarize:
|
|
94
|
-
- Change name and location
|
|
95
|
-
- List of artifacts created with brief descriptions
|
|
96
|
-
- What's ready: "All artifacts created! Ready for implementation."
|
|
97
|
-
- Prompt: "Run `/opsx-apply` or ask me to implement to start working on the tasks."
|
|
98
|
-
|
|
99
|
-
**Artifact Creation Guidelines**
|
|
100
|
-
|
|
101
|
-
- Follow the `instruction` field from `openspec instructions` for each artifact type
|
|
102
|
-
- The schema defines what each artifact should contain - follow it
|
|
103
|
-
- Read dependency artifacts for context before creating new ones
|
|
104
|
-
- Use `template` as the structure for your output file - fill in its sections
|
|
105
|
-
- **IMPORTANT**: `context` and `rules` are constraints for YOU, not content for the file
|
|
106
|
-
- Do NOT copy `<context>`, `<rules>`, `<project_context>` blocks into the artifact
|
|
107
|
-
- These guide what you write, but should never appear in the output
|
|
108
|
-
|
|
109
|
-
**Guardrails**
|
|
110
|
-
- Create ALL artifacts needed for implementation (as defined by schema's `apply.requires`)
|
|
111
|
-
- Always read dependency artifacts before creating a new one
|
|
112
|
-
- If context is critically unclear, ask the user - but prefer making reasonable decisions to keep momentum
|
|
113
|
-
- If a change with that name already exists, ask if user wants to continue it or create a new one
|
|
114
|
-
- Verify each artifact file exists after writing before proceeding to next
|
|
1
|
+
---
|
|
2
|
+
name: openspec-propose
|
|
3
|
+
description: Propose a new change with all artifacts generated in one step. Use when the user wants to quickly describe what they want to build and get a complete proposal with design, specs, and tasks ready for implementation.
|
|
4
|
+
license: MIT
|
|
5
|
+
compatibility: Requires openspec CLI.
|
|
6
|
+
metadata:
|
|
7
|
+
author: openspec
|
|
8
|
+
version: "1.0"
|
|
9
|
+
generatedBy: "1.3.1"
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
**IMPORTANT:** Engram is an **MCP server**, not a skill. Tools `mem_save`, `mem_search`, `mem_context` are MCP tools. Do NOT use `skill("engram")` — it doesn't exist.
|
|
13
|
+
|
|
14
|
+
Propose a new change - create the change and generate all artifacts in one step.
|
|
15
|
+
|
|
16
|
+
I'll create a change with artifacts:
|
|
17
|
+
- proposal.md (what & why)
|
|
18
|
+
- design.md (how)
|
|
19
|
+
- tasks.md (implementation steps)
|
|
20
|
+
|
|
21
|
+
When ready to implement, run /opsx-apply
|
|
22
|
+
|
|
23
|
+
---
|
|
24
|
+
|
|
25
|
+
**Input**: The user's request should include a change name (kebab-case) OR a description of what they want to build.
|
|
26
|
+
|
|
27
|
+
**Steps**
|
|
28
|
+
|
|
29
|
+
1. **Check Engram for similar changes** — `mem_search` with keywords from the user's description. If a similar change was proposed or implemented before, surface it to the user. They may want to extend the existing work instead of starting fresh.
|
|
30
|
+
|
|
31
|
+
2. **If no clear input provided, ask what they want to build**
|
|
32
|
+
|
|
33
|
+
Ask the user in natural language (open-ended, no preset options):
|
|
34
|
+
> "What change do you want to work on? Describe what you want to build or fix."
|
|
35
|
+
|
|
36
|
+
From their description, derive a kebab-case name (e.g., "add user authentication" → `add-user-auth`).
|
|
37
|
+
|
|
38
|
+
**IMPORTANT**: Do NOT proceed without understanding what the user wants to build. After asking, stop and wait for their response.
|
|
39
|
+
|
|
40
|
+
3. **Create the change directory**
|
|
41
|
+
```bash
|
|
42
|
+
openspec new change "<name>"
|
|
43
|
+
```
|
|
44
|
+
This creates a scaffolded change at `openspec/changes/<name>/` with `.openspec.yaml`.
|
|
45
|
+
|
|
46
|
+
4. **Get the artifact build order**
|
|
47
|
+
```bash
|
|
48
|
+
openspec status --change "<name>" --json
|
|
49
|
+
```
|
|
50
|
+
Parse the JSON to get:
|
|
51
|
+
- `applyRequires`: array of artifact IDs needed before implementation (e.g., `["tasks"]`)
|
|
52
|
+
- `artifacts`: list of all artifacts with their status and dependencies
|
|
53
|
+
|
|
54
|
+
5. **Create artifacts in sequence until apply-ready**
|
|
55
|
+
|
|
56
|
+
Use the **todowrite tool** to track progress through the artifacts.
|
|
57
|
+
|
|
58
|
+
Loop through artifacts in dependency order (artifacts with no pending dependencies first):
|
|
59
|
+
|
|
60
|
+
a. **For each artifact that is `ready` (dependencies satisfied)**:
|
|
61
|
+
- Get instructions:
|
|
62
|
+
```bash
|
|
63
|
+
openspec instructions <artifact-id> --change "<name>" --json
|
|
64
|
+
```
|
|
65
|
+
- The instructions JSON includes:
|
|
66
|
+
- `context`: Project background (constraints for you - do NOT include in output)
|
|
67
|
+
- `rules`: Artifact-specific rules (constraints for you - do NOT include in output)
|
|
68
|
+
- `template`: The structure to use for your output file
|
|
69
|
+
- `instruction`: Schema-specific guidance for this artifact type
|
|
70
|
+
- `outputPath`: Where to write the artifact
|
|
71
|
+
- `dependencies`: Completed artifacts to read for context
|
|
72
|
+
- Read any completed dependency files for context
|
|
73
|
+
- Create the artifact file using `template` as the structure
|
|
74
|
+
- Apply `context` and `rules` as constraints - but do NOT copy them into the file
|
|
75
|
+
- Show brief progress: "Created <artifact-id>"
|
|
76
|
+
|
|
77
|
+
b. **Continue until all `applyRequires` artifacts are complete**
|
|
78
|
+
- After creating each artifact, re-run `openspec status --change "<name>" --json`
|
|
79
|
+
- Check if every artifact ID in `applyRequires` has `status: "done"` in the artifacts array
|
|
80
|
+
- Stop when all `applyRequires` artifacts are done
|
|
81
|
+
|
|
82
|
+
c. **If an artifact requires user input** (unclear context):
|
|
83
|
+
- Ask the user in natural language to clarify, then stop and wait for the answer
|
|
84
|
+
- Then continue with creation
|
|
85
|
+
|
|
86
|
+
6. **Show final status**
|
|
87
|
+
```bash
|
|
88
|
+
openspec status --change "<name>"
|
|
89
|
+
```
|
|
90
|
+
|
|
91
|
+
**Output**
|
|
92
|
+
|
|
93
|
+
After completing all artifacts, summarize:
|
|
94
|
+
- Change name and location
|
|
95
|
+
- List of artifacts created with brief descriptions
|
|
96
|
+
- What's ready: "All artifacts created! Ready for implementation."
|
|
97
|
+
- Prompt: "Run `/opsx-apply` or ask me to implement to start working on the tasks."
|
|
98
|
+
|
|
99
|
+
**Artifact Creation Guidelines**
|
|
100
|
+
|
|
101
|
+
- Follow the `instruction` field from `openspec instructions` for each artifact type
|
|
102
|
+
- The schema defines what each artifact should contain - follow it
|
|
103
|
+
- Read dependency artifacts for context before creating new ones
|
|
104
|
+
- Use `template` as the structure for your output file - fill in its sections
|
|
105
|
+
- **IMPORTANT**: `context` and `rules` are constraints for YOU, not content for the file
|
|
106
|
+
- Do NOT copy `<context>`, `<rules>`, `<project_context>` blocks into the artifact
|
|
107
|
+
- These guide what you write, but should never appear in the output
|
|
108
|
+
|
|
109
|
+
**Guardrails**
|
|
110
|
+
- Create ALL artifacts needed for implementation (as defined by schema's `apply.requires`)
|
|
111
|
+
- Always read dependency artifacts before creating a new one
|
|
112
|
+
- If context is critically unclear, ask the user - but prefer making reasonable decisions to keep momentum
|
|
113
|
+
- If a change with that name already exists, ask if user wants to continue it or create a new one
|
|
114
|
+
- Verify each artifact file exists after writing before proceeding to next
|
|
@@ -1,213 +1,213 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: receiving-code-review
|
|
3
|
-
description: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
|
|
4
|
-
---
|
|
5
|
-
|
|
6
|
-
# Code Review Reception
|
|
7
|
-
|
|
8
|
-
## Overview
|
|
9
|
-
|
|
10
|
-
Code review requires technical evaluation, not emotional performance.
|
|
11
|
-
|
|
12
|
-
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
|
13
|
-
|
|
14
|
-
## The Response Pattern
|
|
15
|
-
|
|
16
|
-
```
|
|
17
|
-
WHEN receiving code review feedback:
|
|
18
|
-
|
|
19
|
-
1. READ: Complete feedback without reacting
|
|
20
|
-
2. UNDERSTAND: Restate requirement in own words (or ask)
|
|
21
|
-
3. VERIFY: Check against codebase reality
|
|
22
|
-
4. EVALUATE: Technically sound for THIS codebase?
|
|
23
|
-
5. RESPOND: Technical acknowledgment or reasoned pushback
|
|
24
|
-
6. IMPLEMENT: One item at a time, test each
|
|
25
|
-
```
|
|
26
|
-
|
|
27
|
-
## Forbidden Responses
|
|
28
|
-
|
|
29
|
-
**NEVER:**
|
|
30
|
-
- "You're absolutely right!" (explicit rule violation)
|
|
31
|
-
- "Great point!" / "Excellent feedback!" (performative)
|
|
32
|
-
- "Let me implement that now" (before verification)
|
|
33
|
-
|
|
34
|
-
**INSTEAD:**
|
|
35
|
-
- Restate the technical requirement
|
|
36
|
-
- Ask clarifying questions
|
|
37
|
-
- Push back with technical reasoning if wrong
|
|
38
|
-
- Just start working (actions > words)
|
|
39
|
-
|
|
40
|
-
## Handling Unclear Feedback
|
|
41
|
-
|
|
42
|
-
```
|
|
43
|
-
IF any item is unclear:
|
|
44
|
-
STOP - do not implement anything yet
|
|
45
|
-
ASK for clarification on unclear items
|
|
46
|
-
|
|
47
|
-
WHY: Items may be related. Partial understanding = wrong implementation.
|
|
48
|
-
```
|
|
49
|
-
|
|
50
|
-
**Example:**
|
|
51
|
-
```
|
|
52
|
-
your human partner: "Fix 1-6"
|
|
53
|
-
You understand 1,2,3,6. Unclear on 4,5.
|
|
54
|
-
|
|
55
|
-
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
|
|
56
|
-
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
|
|
57
|
-
```
|
|
58
|
-
|
|
59
|
-
## Source-Specific Handling
|
|
60
|
-
|
|
61
|
-
### From your human partner
|
|
62
|
-
- **Trusted** - implement after understanding
|
|
63
|
-
- **Still ask** if scope unclear
|
|
64
|
-
- **No performative agreement**
|
|
65
|
-
- **Skip to action** or technical acknowledgment
|
|
66
|
-
|
|
67
|
-
### From External Reviewers
|
|
68
|
-
```
|
|
69
|
-
BEFORE implementing:
|
|
70
|
-
1. Check: Technically correct for THIS codebase?
|
|
71
|
-
2. Check: Breaks existing functionality?
|
|
72
|
-
3. Check: Reason for current implementation?
|
|
73
|
-
4. Check: Works on all platforms/versions?
|
|
74
|
-
5. Check: Does reviewer understand full context?
|
|
75
|
-
|
|
76
|
-
IF suggestion seems wrong:
|
|
77
|
-
Push back with technical reasoning
|
|
78
|
-
|
|
79
|
-
IF can't easily verify:
|
|
80
|
-
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
|
|
81
|
-
|
|
82
|
-
IF conflicts with your human partner's prior decisions:
|
|
83
|
-
Stop and discuss with your human partner first
|
|
84
|
-
```
|
|
85
|
-
|
|
86
|
-
**your human partner's rule:** "External feedback - be skeptical, but check carefully"
|
|
87
|
-
|
|
88
|
-
## YAGNI Check for "Professional" Features
|
|
89
|
-
|
|
90
|
-
```
|
|
91
|
-
IF reviewer suggests "implementing properly":
|
|
92
|
-
grep codebase for actual usage
|
|
93
|
-
|
|
94
|
-
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
|
|
95
|
-
IF used: Then implement properly
|
|
96
|
-
```
|
|
97
|
-
|
|
98
|
-
**your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
|
|
99
|
-
|
|
100
|
-
## Implementation Order
|
|
101
|
-
|
|
102
|
-
```
|
|
103
|
-
FOR multi-item feedback:
|
|
104
|
-
1. Clarify anything unclear FIRST
|
|
105
|
-
2. Then implement in this order:
|
|
106
|
-
- Blocking issues (breaks, security)
|
|
107
|
-
- Simple fixes (typos, imports)
|
|
108
|
-
- Complex fixes (refactoring, logic)
|
|
109
|
-
3. Test each fix individually
|
|
110
|
-
4. Verify no regressions
|
|
111
|
-
```
|
|
112
|
-
|
|
113
|
-
## When To Push Back
|
|
114
|
-
|
|
115
|
-
Push back when:
|
|
116
|
-
- Suggestion breaks existing functionality
|
|
117
|
-
- Reviewer lacks full context
|
|
118
|
-
- Violates YAGNI (unused feature)
|
|
119
|
-
- Technically incorrect for this stack
|
|
120
|
-
- Legacy/compatibility reasons exist
|
|
121
|
-
- Conflicts with your human partner's architectural decisions
|
|
122
|
-
|
|
123
|
-
**How to push back:**
|
|
124
|
-
- Use technical reasoning, not defensiveness
|
|
125
|
-
- Ask specific questions
|
|
126
|
-
- Reference working tests/code
|
|
127
|
-
- Involve your human partner if architectural
|
|
128
|
-
|
|
129
|
-
**Signal if uncomfortable pushing back out loud:** "Strange things are afoot at the Circle K"
|
|
130
|
-
|
|
131
|
-
## Acknowledging Correct Feedback
|
|
132
|
-
|
|
133
|
-
When feedback IS correct:
|
|
134
|
-
```
|
|
135
|
-
✅ "Fixed. [Brief description of what changed]"
|
|
136
|
-
✅ "Good catch - [specific issue]. Fixed in [location]."
|
|
137
|
-
✅ [Just fix it and show in the code]
|
|
138
|
-
|
|
139
|
-
❌ "You're absolutely right!"
|
|
140
|
-
❌ "Great point!"
|
|
141
|
-
❌ "Thanks for catching that!"
|
|
142
|
-
❌ "Thanks for [anything]"
|
|
143
|
-
❌ ANY gratitude expression
|
|
144
|
-
```
|
|
145
|
-
|
|
146
|
-
**Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
|
|
147
|
-
|
|
148
|
-
**If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
|
|
149
|
-
|
|
150
|
-
## Gracefully Correcting Your Pushback
|
|
151
|
-
|
|
152
|
-
If you pushed back and were wrong:
|
|
153
|
-
```
|
|
154
|
-
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
|
|
155
|
-
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
|
|
156
|
-
|
|
157
|
-
❌ Long apology
|
|
158
|
-
❌ Defending why you pushed back
|
|
159
|
-
❌ Over-explaining
|
|
160
|
-
```
|
|
161
|
-
|
|
162
|
-
State the correction factually and move on.
|
|
163
|
-
|
|
164
|
-
## Common Mistakes
|
|
165
|
-
|
|
166
|
-
| Mistake | Fix |
|
|
167
|
-
|---------|-----|
|
|
168
|
-
| Performative agreement | State requirement or just act |
|
|
169
|
-
| Blind implementation | Verify against codebase first |
|
|
170
|
-
| Batch without testing | One at a time, test each |
|
|
171
|
-
| Assuming reviewer is right | Check if breaks things |
|
|
172
|
-
| Avoiding pushback | Technical correctness > comfort |
|
|
173
|
-
| Partial implementation | Clarify all items first |
|
|
174
|
-
| Can't verify, proceed anyway | State limitation, ask for direction |
|
|
175
|
-
|
|
176
|
-
## Real Examples
|
|
177
|
-
|
|
178
|
-
**Performative Agreement (Bad):**
|
|
179
|
-
```
|
|
180
|
-
Reviewer: "Remove legacy code"
|
|
181
|
-
❌ "You're absolutely right! Let me remove that..."
|
|
182
|
-
```
|
|
183
|
-
|
|
184
|
-
**Technical Verification (Good):**
|
|
185
|
-
```
|
|
186
|
-
Reviewer: "Remove legacy code"
|
|
187
|
-
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
|
|
188
|
-
```
|
|
189
|
-
|
|
190
|
-
**YAGNI (Good):**
|
|
191
|
-
```
|
|
192
|
-
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
|
|
193
|
-
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
|
|
194
|
-
```
|
|
195
|
-
|
|
196
|
-
**Unclear Item (Good):**
|
|
197
|
-
```
|
|
198
|
-
your human partner: "Fix items 1-6"
|
|
199
|
-
You understand 1,2,3,6. Unclear on 4,5.
|
|
200
|
-
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
|
|
201
|
-
```
|
|
202
|
-
|
|
203
|
-
## GitHub Thread Replies
|
|
204
|
-
|
|
205
|
-
When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
|
|
206
|
-
|
|
207
|
-
## The Bottom Line
|
|
208
|
-
|
|
209
|
-
**External feedback = suggestions to evaluate, not orders to follow.**
|
|
210
|
-
|
|
211
|
-
Verify. Question. Then implement.
|
|
212
|
-
|
|
213
|
-
No performative agreement. Technical rigor always.
|
|
1
|
+
---
|
|
2
|
+
name: receiving-code-review
|
|
3
|
+
description: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Code Review Reception
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
Code review requires technical evaluation, not emotional performance.
|
|
11
|
+
|
|
12
|
+
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
|
13
|
+
|
|
14
|
+
## The Response Pattern
|
|
15
|
+
|
|
16
|
+
```
|
|
17
|
+
WHEN receiving code review feedback:
|
|
18
|
+
|
|
19
|
+
1. READ: Complete feedback without reacting
|
|
20
|
+
2. UNDERSTAND: Restate requirement in own words (or ask)
|
|
21
|
+
3. VERIFY: Check against codebase reality
|
|
22
|
+
4. EVALUATE: Technically sound for THIS codebase?
|
|
23
|
+
5. RESPOND: Technical acknowledgment or reasoned pushback
|
|
24
|
+
6. IMPLEMENT: One item at a time, test each
|
|
25
|
+
```
|
|
26
|
+
|
|
27
|
+
## Forbidden Responses
|
|
28
|
+
|
|
29
|
+
**NEVER:**
|
|
30
|
+
- "You're absolutely right!" (explicit rule violation)
|
|
31
|
+
- "Great point!" / "Excellent feedback!" (performative)
|
|
32
|
+
- "Let me implement that now" (before verification)
|
|
33
|
+
|
|
34
|
+
**INSTEAD:**
|
|
35
|
+
- Restate the technical requirement
|
|
36
|
+
- Ask clarifying questions
|
|
37
|
+
- Push back with technical reasoning if wrong
|
|
38
|
+
- Just start working (actions > words)
|
|
39
|
+
|
|
40
|
+
## Handling Unclear Feedback
|
|
41
|
+
|
|
42
|
+
```
|
|
43
|
+
IF any item is unclear:
|
|
44
|
+
STOP - do not implement anything yet
|
|
45
|
+
ASK for clarification on unclear items
|
|
46
|
+
|
|
47
|
+
WHY: Items may be related. Partial understanding = wrong implementation.
|
|
48
|
+
```
|
|
49
|
+
|
|
50
|
+
**Example:**
|
|
51
|
+
```
|
|
52
|
+
your human partner: "Fix 1-6"
|
|
53
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
54
|
+
|
|
55
|
+
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
|
|
56
|
+
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
## Source-Specific Handling
|
|
60
|
+
|
|
61
|
+
### From your human partner
|
|
62
|
+
- **Trusted** - implement after understanding
|
|
63
|
+
- **Still ask** if scope unclear
|
|
64
|
+
- **No performative agreement**
|
|
65
|
+
- **Skip to action** or technical acknowledgment
|
|
66
|
+
|
|
67
|
+
### From External Reviewers
|
|
68
|
+
```
|
|
69
|
+
BEFORE implementing:
|
|
70
|
+
1. Check: Technically correct for THIS codebase?
|
|
71
|
+
2. Check: Breaks existing functionality?
|
|
72
|
+
3. Check: Reason for current implementation?
|
|
73
|
+
4. Check: Works on all platforms/versions?
|
|
74
|
+
5. Check: Does reviewer understand full context?
|
|
75
|
+
|
|
76
|
+
IF suggestion seems wrong:
|
|
77
|
+
Push back with technical reasoning
|
|
78
|
+
|
|
79
|
+
IF can't easily verify:
|
|
80
|
+
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
|
|
81
|
+
|
|
82
|
+
IF conflicts with your human partner's prior decisions:
|
|
83
|
+
Stop and discuss with your human partner first
|
|
84
|
+
```
|
|
85
|
+
|
|
86
|
+
**your human partner's rule:** "External feedback - be skeptical, but check carefully"
|
|
87
|
+
|
|
88
|
+
## YAGNI Check for "Professional" Features
|
|
89
|
+
|
|
90
|
+
```
|
|
91
|
+
IF reviewer suggests "implementing properly":
|
|
92
|
+
grep codebase for actual usage
|
|
93
|
+
|
|
94
|
+
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
|
|
95
|
+
IF used: Then implement properly
|
|
96
|
+
```
|
|
97
|
+
|
|
98
|
+
**your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
|
|
99
|
+
|
|
100
|
+
## Implementation Order
|
|
101
|
+
|
|
102
|
+
```
|
|
103
|
+
FOR multi-item feedback:
|
|
104
|
+
1. Clarify anything unclear FIRST
|
|
105
|
+
2. Then implement in this order:
|
|
106
|
+
- Blocking issues (breaks, security)
|
|
107
|
+
- Simple fixes (typos, imports)
|
|
108
|
+
- Complex fixes (refactoring, logic)
|
|
109
|
+
3. Test each fix individually
|
|
110
|
+
4. Verify no regressions
|
|
111
|
+
```
|
|
112
|
+
|
|
113
|
+
## When To Push Back
|
|
114
|
+
|
|
115
|
+
Push back when:
|
|
116
|
+
- Suggestion breaks existing functionality
|
|
117
|
+
- Reviewer lacks full context
|
|
118
|
+
- Violates YAGNI (unused feature)
|
|
119
|
+
- Technically incorrect for this stack
|
|
120
|
+
- Legacy/compatibility reasons exist
|
|
121
|
+
- Conflicts with your human partner's architectural decisions
|
|
122
|
+
|
|
123
|
+
**How to push back:**
|
|
124
|
+
- Use technical reasoning, not defensiveness
|
|
125
|
+
- Ask specific questions
|
|
126
|
+
- Reference working tests/code
|
|
127
|
+
- Involve your human partner if architectural
|
|
128
|
+
|
|
129
|
+
**Signal if uncomfortable pushing back out loud:** "Strange things are afoot at the Circle K"
|
|
130
|
+
|
|
131
|
+
## Acknowledging Correct Feedback
|
|
132
|
+
|
|
133
|
+
When feedback IS correct:
|
|
134
|
+
```
|
|
135
|
+
✅ "Fixed. [Brief description of what changed]"
|
|
136
|
+
✅ "Good catch - [specific issue]. Fixed in [location]."
|
|
137
|
+
✅ [Just fix it and show in the code]
|
|
138
|
+
|
|
139
|
+
❌ "You're absolutely right!"
|
|
140
|
+
❌ "Great point!"
|
|
141
|
+
❌ "Thanks for catching that!"
|
|
142
|
+
❌ "Thanks for [anything]"
|
|
143
|
+
❌ ANY gratitude expression
|
|
144
|
+
```
|
|
145
|
+
|
|
146
|
+
**Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
|
|
147
|
+
|
|
148
|
+
**If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
|
|
149
|
+
|
|
150
|
+
## Gracefully Correcting Your Pushback
|
|
151
|
+
|
|
152
|
+
If you pushed back and were wrong:
|
|
153
|
+
```
|
|
154
|
+
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
|
|
155
|
+
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
|
|
156
|
+
|
|
157
|
+
❌ Long apology
|
|
158
|
+
❌ Defending why you pushed back
|
|
159
|
+
❌ Over-explaining
|
|
160
|
+
```
|
|
161
|
+
|
|
162
|
+
State the correction factually and move on.
|
|
163
|
+
|
|
164
|
+
## Common Mistakes
|
|
165
|
+
|
|
166
|
+
| Mistake | Fix |
|
|
167
|
+
|---------|-----|
|
|
168
|
+
| Performative agreement | State requirement or just act |
|
|
169
|
+
| Blind implementation | Verify against codebase first |
|
|
170
|
+
| Batch without testing | One at a time, test each |
|
|
171
|
+
| Assuming reviewer is right | Check if breaks things |
|
|
172
|
+
| Avoiding pushback | Technical correctness > comfort |
|
|
173
|
+
| Partial implementation | Clarify all items first |
|
|
174
|
+
| Can't verify, proceed anyway | State limitation, ask for direction |
|
|
175
|
+
|
|
176
|
+
## Real Examples
|
|
177
|
+
|
|
178
|
+
**Performative Agreement (Bad):**
|
|
179
|
+
```
|
|
180
|
+
Reviewer: "Remove legacy code"
|
|
181
|
+
❌ "You're absolutely right! Let me remove that..."
|
|
182
|
+
```
|
|
183
|
+
|
|
184
|
+
**Technical Verification (Good):**
|
|
185
|
+
```
|
|
186
|
+
Reviewer: "Remove legacy code"
|
|
187
|
+
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
|
|
188
|
+
```
|
|
189
|
+
|
|
190
|
+
**YAGNI (Good):**
|
|
191
|
+
```
|
|
192
|
+
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
|
|
193
|
+
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
|
|
194
|
+
```
|
|
195
|
+
|
|
196
|
+
**Unclear Item (Good):**
|
|
197
|
+
```
|
|
198
|
+
your human partner: "Fix items 1-6"
|
|
199
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
200
|
+
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
|
|
201
|
+
```
|
|
202
|
+
|
|
203
|
+
## GitHub Thread Replies
|
|
204
|
+
|
|
205
|
+
When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
|
|
206
|
+
|
|
207
|
+
## The Bottom Line
|
|
208
|
+
|
|
209
|
+
**External feedback = suggestions to evaluate, not orders to follow.**
|
|
210
|
+
|
|
211
|
+
Verify. Question. Then implement.
|
|
212
|
+
|
|
213
|
+
No performative agreement. Technical rigor always.
|