ossclip 0.1.33 → 0.1.35

package/src/render-replay-args.ts

@@ -0,0 +1,50 @@
+/**
+ * The argv the editor's Render button replays (2026-08-29).
+ *
+ * A render started FROM the editor must reproduce what the user just
+ * reviewed. Replaying `command.json` verbatim did not: it carried
+ * `--produce`, so every render re-called the LLM, and the beat-sheet cache
+ * key covers the repaired words and the MEASURED framing — both of which the
+ * user's own editor work changes. The plan came back renumbered, edits
+ * anchored to scenes it no longer had were orphaned, and an approved cut was
+ * silently rewritten (the failure `produce.ts`' §143 note already named once,
+ * 2026-08-23; hit again through a different door).
+ *
+ * So the editor pins the plan on screen with `--scenes` (no LLM in the loop)
+ * and drops `--produce`. The two paths stay distinct on purpose:
+ *
+ *  - CLI/CI: `--produce` plans fresh. The command line is the authority.
+ *  - Editor: the reviewed plan is the authority; `replan` opts back in.
+ *
+ * Pure, so the whole matrix is testable without spawning a produce.
+ */
+/** The reviewed plan the editor pins for a render (see the module docstring).
+ * Its own name, never `scenes-<key>.json`: those are keyed to a beat sheet
+ * this render may no longer match. */
+export const REVIEWED_SCENES_BASENAME = "scenes-reviewed.json";
+
+export function renderReplayArgs(
+  recorded: readonly string[],
+  opts: { scenesPath?: string; replan?: boolean },
+): string[] {
+  // A deliberate re-plan replays exactly what was recorded — including
+  // `--produce` when it was there, since that IS the fresh-plan request.
+  if (opts.replan === true || opts.scenesPath === undefined) return [...recorded];
+
+  const out: string[] = [];
+  for (let i = 0; i < recorded.length; i++) {
+    const arg = recorded[i]!;
+    // `--produce` is a boolean flag: drop it alone, never a following value.
+    if (arg === "--produce") continue;
+    // An existing `--scenes <path>` is dropped WITH its value: two of them
+    // would let commander pick one, and the stale one is precisely the plan
+    // the editor is not showing.
+    if (arg === "--scenes") {
+      i++;
+      continue;
+    }
+    out.push(arg);
+  }
+  out.push("--scenes", opts.scenesPath);
+  return out;
+}

package/src/replay-argv.ts

@@ -20,6 +20,9 @@
 // Type-only, so no runtime edge back into produce.ts (which imports this
 // module): the tri-state's vocabulary belongs to its resolver.
 import type { JumpCutsMode } from "./produce";
+// Type-only for the same reason: the level's own zod enum lives in core's
+// producer half, and this module must stay a pure argv builder.
+import type { SfxLevel } from "@ossclip/core";
 
 let stashed: string[] | null = null;
 
@@ -71,6 +74,10 @@ export function recordedProduceArgs(pins: {
   audience?: string;
   /** The RESOLVED thumbnail brief — pinned only when non-empty. */
   thumbnailBrief?: string;
+  /** The RESOLVED `--sfx` switch (flag or config), pinned only when ON. */
+  sfx?: boolean;
+  /** The RESOLVED `--sfx-level`, pinned alongside an ON `sfx`. */
+  sfxLevel?: SfxLevel;
 }): string[] {
   // --review and --no-render are stripped at record (cut-review step 1):
   // command.json exists for exactly one consumer — the editor's Render
@@ -201,5 +208,28 @@ export function recordedProduceArgs(pins: {
   ) {
     args.push("--thumbnail-brief", pins.thumbnailBrief);
   }
+  // The sound-effect pins, the watermark's config-dependent-default rationale
+  // on a pair of flags: `sfx`/`sfxLevel` are both config keys, so an unpinned
+  // record replays a different amount of sound design — or none — the moment
+  // that config is edited or the replay runs on another machine. It matters
+  // more here than for the watermark: an editor render carries the REVIEWED
+  // plan forward from production.json instead of re-placing (produce's
+  // `priorSfxPlan`), so `--sfx` is what decides whether the sound design the
+  // user just dragged into place is in the video at all.
+  //
+  // ON ONLY, and that is the jump-cuts "auto" case rather than the watermark's
+  // both-directions rule: there is no `--no-sfx` spelling to pin an off-run
+  // with (program.ts declares `--sfx` alone, so the config key can still
+  // supply the default). An off-record replayed under a later config-on
+  // therefore GAINS sound effects — the accepted cost of a flag with one
+  // spelling, and the day `--no-sfx` exists this pin becomes unconditional
+  // like the watermark's. `--sfx-level` implies `--sfx`, so a typed level in
+  // the argv already settles the switch and the includes-guard leaves it be.
+  if (pins.sfx === true) {
+    if (!args.includes("--sfx") && !args.includes("--sfx-level")) args.push("--sfx");
+    if (pins.sfxLevel !== undefined && !args.includes("--sfx-level")) {
+      args.push("--sfx-level", pins.sfxLevel);
+    }
+  }
   return args;
 }