ossclip 0.1.33 → 0.1.35

package/src/interactive/offer-editor.ts

@@ -11,7 +11,17 @@ import { renderCommand } from "./render";
  */
 export async function offerEditor(
   result: ProduceResult,
-  opts: { flag: boolean | undefined; port: number },
+  opts: {
+    flag: boolean | undefined;
+    port: number;
+    /**
+     * Whether the user TYPED `--editor-port`. Commander's 5174 default is not
+     * a choice anybody made, so the common case must be free to attach or step
+     * around a busy port; only a typed port is defended (edit-port.ts's
+     * `pinned`, and the `--port` half of the same rule in program.ts).
+     */
+    portPinned: boolean;
+  },
 ): Promise<void> {
   const pref: OpenEditorPref = loadConfig().openEditorAfterProduce ?? "ask";
   const decision = decideOpenEditor({
@@ -64,8 +74,23 @@ export async function offerEditor(
     );
     return;
   }
-  const server = await startEditServer(result.workdir, { port: opts.port, pageDir });
-  console.log(`▸ editor at ${server.url}`);
+  // The same busy-port ladder `ossclip edit` runs (edit-port.ts): a produce
+  // finishing into an already-open editor on THIS project attaches to it
+  // instead of dying on EADDRINUSE — which here would throw away the run's
+  // whole summary behind a stack trace. `liveEditPortDeps` reads the real
+  // `isInteractive()`, so the three-way prompt is available exactly where this
+  // offer already asks questions, and absent in a piped run.
+  const { openEditServer, liveEditPortDeps } = await import("../edit-port");
+  const opened = await openEditServer(
+    result.workdir,
+    { port: opts.port, pinned: opts.portPinned },
+    liveEditPortDeps((port) => startEditServer(result.workdir, { port, pageDir })),
+  );
+  if (opened.kind === "cancelled") return;
+  const url = opened.kind === "attached" ? opened.url : opened.server.url;
+  // The attach path already printed "▸ already open at …"; a second line
+  // underneath it would read as a second server.
+  if (opened.kind === "started") console.log(`▸ editor at ${url}`);
   const { openInBrowser } = await import("../open");
-  openInBrowser(server.url);
+  openInBrowser(url);
 }

package/src/interactive/produce-argv.ts

@@ -1,4 +1,4 @@
-import type { ProviderName } from "@ossclip/core";
+import type { ProviderName, SfxLevel } from "@ossclip/core";
 
 /**
  * Wizard answers → the argv a user could have typed.
@@ -35,6 +35,16 @@ export interface ProduceExtras {
    * it exists to beat a future config-off, and emitting it here would
    * restate the default. */
   jumpCuts?: boolean;
+  /** Sound effects, the watermark's polarity with a level attached: PRESENT
+   * means on (the wizard only ever turns it ON — off is the default, there is
+   * no `--no-sfx` spelling to mirror, and a config-on user who wants silence
+   * for one run edits the config's `sfx` key), and the value is whatever the
+   * level follow-up answered. Typed as core's `SfxLevel`, not an inline
+   * union, for `llm`'s reason: a level added to `SfxLevelSchema` must not be
+   * silently unofferable here. Only reachable under graphics — sound effects
+   * are placed against the producer's beat sheet, so `extrasFor` gates the
+   * entry the way it gates `--clip`. */
+  sfx?: SfxLevel;
   /** The YouTube pack (Y2): the wizard only ever turns it ON — off is the
    * default, and a config-on user who wants it off for one run types
    * `--no-youtube`, flags-only like `--no-watermark`. */
@@ -116,6 +126,13 @@ export function produceArgv(a: ProduceAnswers): string[] {
   // negative spelling — auto must stay an ABSENT flag, or the taught
   // command line restates a default.
   if (e.jumpCuts === false) argv.push("--no-jump-cuts");
+  // One flag, never both: `--sfx-level` already implies `--sfx` (program.ts's
+  // `sfxFlag`), which is why replay-argv pins a level WITHOUT the switch too —
+  // emitting the pair would teach a flag that changes nothing. And `normal` is
+  // the CLI's own default, so naming it would restate a default per the
+  // elision rule above: a normal-level run's whole sound design is `--sfx`.
+  if (e.sfx === "normal") argv.push("--sfx");
+  else if (e.sfx !== undefined) argv.push("--sfx-level", e.sfx);
   // Watermark's shape: only the ON tick emits (off is the default, elided),
   // and the portrait only rides along with a value — the wizard already
   // dropped empty answers.

package/src/interactive/produce-wizard.ts

@@ -12,8 +12,9 @@ import { assertInteractive, confirm, intro, multiselect, select, text, unwrap }
 /**
  * The produce wizard. Forty-one flags (plus the positional input path)
  * sorted into three tiers: six prompts asked directly — the input path, plus
- * five flags (--out, --cleanup, --aspect, --produce, --intent) — eleven
- * behind one "anything else?" multiselect, and the remaining stay flags-only:
+ * five flags (--out, --cleanup, --aspect, --produce, --intent) — twelve
+ * behind one "anything else?" multiselect (--sfx being the twelfth, with
+ * --sfx-level as its follow-up prompt rather than an entry of its own), and the remaining stay flags-only:
  * debug/internal surfaces, replay-only fields, --no-watermark (the
  * multiselect only turns the credit ON; off is already the default),
  * --no-youtube (the same shape: the pack entry only turns it ON),
@@ -48,6 +49,11 @@ const EXTRAS = [
   { value: "sourceIsEdited", label: "Source already has burned-in text", hint: "--source-is-edited" },
   { value: "captionsOff", label: "Turn the burned-in captions off", hint: "--no-captions" },
   { value: "jumpCutsOff", label: "No punch-in zooms at cuts", hint: "--no-jump-cuts" },
+  // Watermark/youtube polarity: OFF is the default and the entry only ever
+  // turns it ON — `--no-sfx` does not exist (program.ts declares `--sfx`
+  // alone so the config's `sfx` key can still supply it), so there is no OFF
+  // spelling to mirror in a second entry.
+  { value: "sfx", label: "Add sound effects (whoosh, ding…)", hint: "--sfx" },
   { value: "watermark", label: 'Credit the tool with a small "made with ossclip"', hint: "--watermark" },
   // The hint says the approval part out loud (thumbnail UX, 2026-08-16):
   // ticking this adds an interactive stop before the render, and a surprise
@@ -69,6 +75,15 @@ const EXTRAS = [
  * graphics is already on. Exported and kept pure so this can be asserted
  * without a TTY.
  *
+ * The sfx entry is gated on the same precedent (2026-08-29). Sound effects
+ * are placed against the producer's beat sheet, so a `--sfx` run without
+ * `--produce` reaches produce.ts's own "sound effects are placed against the
+ * producer's beat sheet — add --produce" warning and renders silent (a
+ * previous run's plan in the workdir is the only thing that saves it, which
+ * is not something a menu can promise). A guaranteed-inert menu item is the
+ * same broken offer as the clip one, softer only in that it warns instead of
+ * throwing — so it is only ever listed once graphics is already on.
+ *
  * `watermarkFromConfig` (review, minor a): on a config-on machine the
  * watermark entry sits UNCHECKED while the credit will render anyway —
  * unchecked is "don't emit the flag", not "off", and the multiselect has no
@@ -81,7 +96,9 @@ export function extrasFor(
   graphics: boolean,
   opts: { watermarkFromConfig?: boolean } = {},
 ): { value: (typeof EXTRAS)[number]["value"]; label: string; hint: string }[] {
-  const list = graphics ? [...EXTRAS] : EXTRAS.filter((e) => e.value !== "graphicsClip");
+  const list = graphics
+    ? [...EXTRAS]
+    : EXTRAS.filter((e) => e.value !== "graphicsClip" && e.value !== "sfx");
   if (opts.watermarkFromConfig !== true) return [...list];
   return list.map((e) =>
     e.value === "watermark"
@@ -346,6 +363,26 @@ export async function produceWizard(
   // Same OFF-switch shape (the punch defaults ON, face-only): a tick maps
   // to `jumpCuts: false` and produceArgv emits `--no-jump-cuts`.
   if (chosen.includes("jumpCutsOff")) extras.jumpCuts = false;
+  if (chosen.includes("sfx")) {
+    // Follow-up under the same extra, like --clip's seconds prompt: the level
+    // only means anything once effects are on. `normal` is preselected
+    // because it is the CLI's own default — and picking it still emits the
+    // bare `--sfx` rather than `--sfx-level normal`, produceArgv's
+    // default-elision rule. The hints say what the level actually CHANGES
+    // (density, and whether the meme-tagged sounds are eligible at all),
+    // because "subtle/normal/meme" alone reads as a volume knob.
+    extras.sfx = unwrap(
+      await select({
+        message: "How much sound design?",
+        initialValue: "normal",
+        options: [
+          { value: "subtle", label: "subtle", hint: "a couple of accents a minute" },
+          { value: "normal", label: "normal", hint: "recommended" },
+          { value: "meme", label: "meme", hint: "denser, and meme-tagged sounds become eligible" },
+        ],
+      }),
+    ) as ProduceExtras["sfx"];
+  }
   if (chosen.includes("watermark")) extras.watermark = true;
   if (chosen.includes("youtube")) {
     extras.youtube = true;