oh-my-opencode 4.16.0 → 4.16.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/skills/codex-qa/SKILL.md +9 -7
- package/.agents/skills/codex-qa/references/logging-debug.md +6 -4
- package/.agents/skills/opencode-qa/SKILL.md +9 -9
- package/.agents/skills/opencode-qa/references/tui-tmux.md +10 -8
- package/dist/cli/codex-ulw-loop.d.ts +8 -0
- package/dist/cli/get-local-version/types.d.ts +1 -1
- package/dist/cli/index.js +260 -207
- package/dist/cli-node/index.js +260 -207
- package/dist/features/background-agent/parent-wake-dedupe.d.ts +1 -0
- package/dist/features/background-agent/parent-wake-flush-runner.d.ts +2 -0
- package/dist/features/background-agent/parent-wake-prompt-dispatch.d.ts +1 -0
- package/dist/features/builtin-commands/templates/refactor-sections/intro-and-analysis.d.ts +1 -1
- package/dist/features/builtin-commands/templates/remove-ai-slops.d.ts +1 -1
- package/dist/features/builtin-commands/templates/start-work.d.ts +1 -1
- package/dist/features/monitor/process.d.ts +17 -1
- package/dist/index.js +1098 -1020
- package/dist/skills/frontend/SKILL.md +9 -9
- package/dist/skills/frontend/references/design/README.md +7 -3
- package/dist/skills/frontend/references/design/_INDEX.md +1 -1
- package/dist/skills/frontend/references/design/design-system-architecture.md +24 -2
- package/dist/skills/frontend/references/designpowers/README.md +2 -2
- package/dist/skills/frontend/references/designpowers/lane-b-execution.md +1 -1
- package/dist/skills/review-work/SKILL.md +3 -1
- package/dist/skills/start-work/SKILL.md +4 -2
- package/dist/skills/ulw-research/SKILL.md +3 -1
- package/dist/skills/visual-qa/SKILL.md +13 -17
- package/docs/reference/web-terminal-visual-qa.md +39 -45
- package/package.json +31 -25
- package/packages/omo-codex/plugin/.codex-plugin/plugin.json +1 -1
- package/packages/omo-codex/plugin/components/bootstrap/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/bootstrap/package.json +1 -1
- package/packages/omo-codex/plugin/components/codegraph/package.json +1 -1
- package/packages/omo-codex/plugin/components/comment-checker/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/comment-checker/package.json +1 -1
- package/packages/omo-codex/plugin/components/git-bash/hooks/hooks.json +2 -2
- package/packages/omo-codex/plugin/components/git-bash/package.json +1 -1
- package/packages/omo-codex/plugin/components/lazycodex-executor-verify/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/lazycodex-executor-verify/package.json +1 -1
- package/packages/omo-codex/plugin/components/lsp/hooks/hooks.json +2 -2
- package/packages/omo-codex/plugin/components/lsp/package.json +1 -1
- package/packages/omo-codex/plugin/components/rules/bundled-rules/hephaestus.md +1 -1
- package/packages/omo-codex/plugin/components/rules/hooks/hooks.json +4 -4
- package/packages/omo-codex/plugin/components/rules/package.json +1 -1
- package/packages/omo-codex/plugin/components/start-work-continuation/directive.md +3 -3
- package/packages/omo-codex/plugin/components/start-work-continuation/hooks/hooks.json +2 -2
- package/packages/omo-codex/plugin/components/start-work-continuation/package.json +1 -1
- package/packages/omo-codex/plugin/components/start-work-continuation/test/codex-hook.test.ts +1 -1
- package/packages/omo-codex/plugin/components/teammode/AGENTS.md +1 -1
- package/packages/omo-codex/plugin/components/teammode/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/teammode/package.json +1 -1
- package/packages/omo-codex/plugin/components/teammode/skills/teammode/SKILL.md +3 -3
- package/packages/omo-codex/plugin/components/telemetry/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/telemetry/package.json +1 -1
- package/packages/omo-codex/plugin/components/ultrawork/directive.md +19 -10
- package/packages/omo-codex/plugin/components/ultrawork/hooks/hooks.json +1 -1
- package/packages/omo-codex/plugin/components/ultrawork/package.json +1 -1
- package/packages/omo-codex/plugin/components/ultrawork/skills/ultrawork/SKILL.md +19 -10
- package/packages/omo-codex/plugin/components/ultrawork/skills/ulw-plan/SKILL.md +13 -0
- package/packages/omo-codex/plugin/components/ultrawork/skills/ulw-plan/references/full-workflow.md +2 -0
- package/packages/omo-codex/plugin/components/ultrawork/test/codex-hook.test.ts +22 -1
- package/packages/omo-codex/plugin/components/ulw-loop/CHANGELOG.md +4 -0
- package/packages/omo-codex/plugin/components/ulw-loop/directive.md +19 -10
- package/packages/omo-codex/plugin/components/ulw-loop/dist/cli-commands.js +15 -2
- package/packages/omo-codex/plugin/components/ulw-loop/dist/cli-steering.js +2 -1
- package/packages/omo-codex/plugin/components/ulw-loop/dist/cli.js +89 -27
- package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-io.d.ts +6 -0
- package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-io.js +55 -9
- package/packages/omo-codex/plugin/components/ulw-loop/dist/steering-snapshot.d.ts +15 -0
- package/packages/omo-codex/plugin/components/ulw-loop/dist/steering-snapshot.js +33 -0
- package/packages/omo-codex/plugin/components/ulw-loop/dist/steering-types.d.ts +10 -3
- package/packages/omo-codex/plugin/components/ulw-loop/dist/steering.js +15 -11
- package/packages/omo-codex/plugin/components/ulw-loop/hooks/hooks.json +2 -2
- package/packages/omo-codex/plugin/components/ulw-loop/package.json +1 -1
- package/packages/omo-codex/plugin/components/ulw-loop/skills/ulw-loop/SKILL.md +3 -1
- package/packages/omo-codex/plugin/components/ulw-loop/skills/ulw-loop/references/full-workflow.md +7 -7
- package/packages/omo-codex/plugin/components/ulw-loop/src/cli-commands.ts +17 -2
- package/packages/omo-codex/plugin/components/ulw-loop/src/cli-steering.ts +2 -1
- package/packages/omo-codex/plugin/components/ulw-loop/src/plan-io.ts +59 -11
- package/packages/omo-codex/plugin/components/ulw-loop/src/steering-snapshot.ts +38 -0
- package/packages/omo-codex/plugin/components/ulw-loop/src/steering-types.ts +11 -3
- package/packages/omo-codex/plugin/components/ulw-loop/src/steering.ts +15 -7
- package/packages/omo-codex/plugin/components/ulw-loop/test/cli-create-goals.test.ts +16 -0
- package/packages/omo-codex/plugin/components/ulw-loop/test/plan-io.test.ts +260 -2
- package/packages/omo-codex/plugin/components/ulw-loop/test/skill-contract.test.ts +1 -1
- package/packages/omo-codex/plugin/components/ulw-loop/test/steering-snapshot.test.ts +124 -0
- package/packages/omo-codex/plugin/components/ulw-loop/test/steering.test.ts +101 -2
- package/packages/omo-codex/plugin/hooks/post-compact-resetting-git-bash-mcp-reminder.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-compact-resetting-lsp-diagnostics-cache.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-compact-resetting-project-rule-cache.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-tool-use-checking-codegraph-init-guidance.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-tool-use-checking-comments.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-tool-use-checking-lsp-diagnostics.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-tool-use-checking-thread-title-hygiene.json +1 -1
- package/packages/omo-codex/plugin/hooks/post-tool-use-matching-project-rules.json +1 -1
- package/packages/omo-codex/plugin/hooks/pre-tool-use-enforcing-unlimited-goal-budget.json +1 -1
- package/packages/omo-codex/plugin/hooks/pre-tool-use-recommending-git-bash-mcp.json +1 -1
- package/packages/omo-codex/plugin/hooks/session-start-checking-auto-update.json +1 -1
- package/packages/omo-codex/plugin/hooks/session-start-checking-bootstrap-provisioning.json +1 -1
- package/packages/omo-codex/plugin/hooks/session-start-checking-codegraph-bootstrap.json +1 -1
- package/packages/omo-codex/plugin/hooks/session-start-loading-project-rules.json +1 -1
- package/packages/omo-codex/plugin/hooks/session-start-recording-session-telemetry.json +1 -1
- package/packages/omo-codex/plugin/hooks/stop-checking-start-work-continuation.json +1 -1
- package/packages/omo-codex/plugin/hooks/subagent-stop-checking-start-work-continuation.json +1 -1
- package/packages/omo-codex/plugin/hooks/subagent-stop-verifying-lazycodex-executor-evidence.json +1 -1
- package/packages/omo-codex/plugin/hooks/user-prompt-submit-checking-ultrawork-trigger.json +1 -1
- package/packages/omo-codex/plugin/hooks/user-prompt-submit-checking-ulw-loop-steering.json +1 -1
- package/packages/omo-codex/plugin/hooks/user-prompt-submit-loading-project-rules.json +1 -1
- package/packages/omo-codex/plugin/package-lock.json +13 -13
- package/packages/omo-codex/plugin/package.json +1 -1
- package/packages/omo-codex/plugin/scripts/auto-update.mjs +64 -17
- package/packages/omo-codex/plugin/scripts/hook-status-message.mjs +10 -6
- package/packages/omo-codex/plugin/scripts/migrate-codex-config/multi-agent-v2-guard.mjs +186 -20
- package/packages/omo-codex/plugin/scripts/migrate-codex-config/subagent-limit-guard.mjs +51 -3
- package/packages/omo-codex/plugin/scripts/migrate-codex-config.mjs +33 -5
- package/packages/omo-codex/plugin/scripts/sync-skills.mjs +1 -1
- package/packages/omo-codex/plugin/skills/frontend/SKILL.md +9 -9
- package/packages/omo-codex/plugin/skills/frontend/references/design/README.md +7 -3
- package/packages/omo-codex/plugin/skills/frontend/references/design/_INDEX.md +1 -1
- package/packages/omo-codex/plugin/skills/frontend/references/design/design-system-architecture.md +24 -2
- package/packages/omo-codex/plugin/skills/frontend/references/designpowers/README.md +2 -2
- package/packages/omo-codex/plugin/skills/frontend/references/designpowers/lane-b-execution.md +1 -1
- package/packages/omo-codex/plugin/skills/init-deep/SKILL.md +1 -1
- package/packages/omo-codex/plugin/skills/refactor/SKILL.md +1 -1
- package/packages/omo-codex/plugin/skills/remove-ai-slops/SKILL.md +1 -1
- package/packages/omo-codex/plugin/skills/review-work/SKILL.md +1 -1
- package/packages/omo-codex/plugin/skills/start-work/SKILL.md +3 -3
- package/packages/omo-codex/plugin/skills/teammode/SKILL.md +3 -3
- package/packages/omo-codex/plugin/skills/ultrawork/SKILL.md +19 -10
- package/packages/omo-codex/plugin/skills/ulw-loop/SKILL.md +3 -1
- package/packages/omo-codex/plugin/skills/ulw-loop/references/full-workflow.md +7 -7
- package/packages/omo-codex/plugin/skills/ulw-plan/SKILL.md +13 -0
- package/packages/omo-codex/plugin/skills/ulw-plan/references/full-workflow.md +2 -0
- package/packages/omo-codex/plugin/skills/ulw-research/SKILL.md +1 -1
- package/packages/omo-codex/plugin/skills/visual-qa/SKILL.md +14 -18
- package/packages/omo-codex/plugin/test/aggregate-hooks.test.mjs +4 -4
- package/packages/omo-codex/plugin/test/aggregate-plugin-fixture.mjs +1 -1
- package/packages/omo-codex/plugin/test/auto-update.test.mjs +35 -1
- package/packages/omo-codex/plugin/test/bootstrap-hooks.test.mjs +1 -1
- package/packages/omo-codex/plugin/test/hook-status-message.test.mjs +22 -9
- package/packages/omo-codex/plugin/test/migrate-codex-config.test.mjs +275 -19
- package/packages/omo-codex/plugin/test/subagent-limit-migration.test.mjs +33 -0
- package/packages/omo-codex/plugin/test/sync-hook-status-messages.test.mjs +6 -6
- package/packages/omo-codex/plugin/test/sync-skills-orchestration.test.mjs +4 -2
- package/packages/omo-codex/plugin/test/ulw-plan-skill-contract.test.mjs +52 -0
- package/packages/omo-codex/scripts/install-dist/install-local.mjs +65 -39
- package/packages/omo-codex/scripts/install-lazycodex-version-stamp.test.mjs +2 -2
- package/packages/shared-skills/skills/frontend/SKILL.md +9 -9
- package/packages/shared-skills/skills/frontend/references/design/README.md +7 -3
- package/packages/shared-skills/skills/frontend/references/design/_INDEX.md +1 -1
- package/packages/shared-skills/skills/frontend/references/design/design-system-architecture.md +24 -2
- package/packages/shared-skills/skills/frontend/references/designpowers/README.md +2 -2
- package/packages/shared-skills/skills/frontend/references/designpowers/lane-b-execution.md +1 -1
- package/packages/shared-skills/skills/review-work/SKILL.md +3 -1
- package/packages/shared-skills/skills/start-work/SKILL.md +4 -2
- package/packages/shared-skills/skills/ulw-research/SKILL.md +3 -1
- package/packages/shared-skills/skills/visual-qa/SKILL.md +13 -17
- package/script/qa/strip-ansi.mjs +10 -0
- package/script/qa/web-terminal-visual-qa.mjs +112 -195
- package/script/qa/xterm-live-terminal.mjs +180 -0
- package/script/qa/web-terminal-renderer.mjs +0 -218
|
@@ -521,7 +521,9 @@ function formatCodexGoalReconciliation(reconciliation) {
|
|
|
521
521
|
}
|
|
522
522
|
|
|
523
523
|
// components/ulw-loop/src/plan-io.ts
|
|
524
|
+
import { createReadStream } from "node:fs";
|
|
524
525
|
import { appendFile, mkdir, readFile as readFile4, rename, writeFile } from "node:fs/promises";
|
|
526
|
+
import { createInterface } from "node:readline";
|
|
525
527
|
var LEGACY_OBJECTIVE_PREFIX = `Complete all ulw-loop stories in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}: `;
|
|
526
528
|
var LEGACY_OBJECTIVE = `Complete all ulw-loop stories listed in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}. Use ${ULW_LOOP_DIR}/${ULW_LOOP_LEDGER} as the durable audit trail.`;
|
|
527
529
|
var locks = new Map;
|
|
@@ -540,11 +542,18 @@ async function withUlwLoopMutationLock(repoRoot, scopeOrFn, maybeFn) {
|
|
|
540
542
|
if (fn === undefined)
|
|
541
543
|
throw new UlwLoopError("Missing ulw-loop mutation body.", "ULW_LOOP_LOCK_BODY_MISSING");
|
|
542
544
|
const lockKey = `${repoRoot}\x00${ulwLoopRelativeDir(scope)}`;
|
|
543
|
-
const prior = locks.get(lockKey) ?? Promise.resolve();
|
|
545
|
+
const prior = locks.get(lockKey) ?? Promise.resolve(undefined);
|
|
544
546
|
const run = prior.then(fn, fn);
|
|
545
|
-
|
|
547
|
+
const gate = run.then(() => {
|
|
546
548
|
return;
|
|
547
|
-
})
|
|
549
|
+
}, () => {
|
|
550
|
+
return;
|
|
551
|
+
});
|
|
552
|
+
locks.set(lockKey, gate);
|
|
553
|
+
gate.then(() => {
|
|
554
|
+
if (locks.get(lockKey) === gate)
|
|
555
|
+
locks.delete(lockKey);
|
|
556
|
+
});
|
|
548
557
|
return run;
|
|
549
558
|
}
|
|
550
559
|
async function readUlwLoopPlan(repoRoot, scope) {
|
|
@@ -591,22 +600,36 @@ async function appendLedger(repoRoot, entry, scope) {
|
|
|
591
600
|
await appendFile(ulwLoopLedgerPath(repoRoot, scope), `${JSON.stringify(entry)}
|
|
592
601
|
`, "utf8");
|
|
593
602
|
}
|
|
594
|
-
async function
|
|
595
|
-
|
|
603
|
+
async function* ledgerLines(repoRoot, scope) {
|
|
604
|
+
const stream = createReadStream(ulwLoopLedgerPath(repoRoot, scope), { encoding: "utf8" });
|
|
605
|
+
const lines = createInterface({ input: stream, crlfDelay: Number.POSITIVE_INFINITY });
|
|
596
606
|
try {
|
|
597
|
-
|
|
607
|
+
for await (const line of lines) {
|
|
608
|
+
if (line.trim().length > 0)
|
|
609
|
+
yield line;
|
|
610
|
+
}
|
|
598
611
|
} catch (error) {
|
|
599
|
-
if (hasCode(error, "ENOENT"))
|
|
600
|
-
|
|
601
|
-
|
|
612
|
+
if (!hasCode(error, "ENOENT"))
|
|
613
|
+
throw error;
|
|
614
|
+
} finally {
|
|
615
|
+
lines.close();
|
|
616
|
+
stream.destroy();
|
|
602
617
|
}
|
|
603
|
-
|
|
604
|
-
|
|
618
|
+
}
|
|
619
|
+
async function findAcceptedSteeringLedgerEntry(repoRoot, key, scope) {
|
|
620
|
+
const probe = JSON.stringify(key);
|
|
621
|
+
for await (const line of ledgerLines(repoRoot, scope)) {
|
|
622
|
+
if (!line.includes(probe))
|
|
623
|
+
continue;
|
|
605
624
|
const entry = JSON.parse(line);
|
|
606
|
-
if (isSteeringKind(entry.kind))
|
|
607
|
-
|
|
625
|
+
if (!isSteeringKind(entry.kind))
|
|
626
|
+
continue;
|
|
627
|
+
if (entry.steering?.invariant.accepted !== true)
|
|
628
|
+
continue;
|
|
629
|
+
if (entry.idempotencyKey === key || entry.steering.idempotencyKey === key || entry.steering.promptSignature === key)
|
|
630
|
+
return entry;
|
|
608
631
|
}
|
|
609
|
-
return
|
|
632
|
+
return;
|
|
610
633
|
}
|
|
611
634
|
|
|
612
635
|
// components/ulw-loop/src/evidence.ts
|
|
@@ -1254,7 +1277,8 @@ function neverKind(kind) {
|
|
|
1254
1277
|
async function parseSteeringProposal(argv) {
|
|
1255
1278
|
const kind = parseSteeringKind(argv);
|
|
1256
1279
|
const source = parseSteeringSource(argv);
|
|
1257
|
-
const
|
|
1280
|
+
const idempotencyKey = text(readValue(argv, "--idempotency-key"), "--idempotency-key");
|
|
1281
|
+
const base = { kind, source, evidence: required2(argv, "--evidence"), rationale: required2(argv, "--rationale"), ...idempotencyKey === undefined ? {} : { idempotencyKey } };
|
|
1258
1282
|
switch (kind) {
|
|
1259
1283
|
case "add_subgoal":
|
|
1260
1284
|
return normalizeSteeringProposal({ ...base, title: required2(argv, "--title"), objective: required2(argv, "--objective") });
|
|
@@ -1725,6 +1749,30 @@ async function recordFinalReviewBlockers(repoRoot, args, scope) {
|
|
|
1725
1749
|
});
|
|
1726
1750
|
}
|
|
1727
1751
|
|
|
1752
|
+
// components/ulw-loop/src/steering-snapshot.ts
|
|
1753
|
+
function buildSteeringPlanSnapshot(plan, changedGoalIds) {
|
|
1754
|
+
const snapshot = {
|
|
1755
|
+
updatedAt: plan.updatedAt,
|
|
1756
|
+
goalCount: plan.goals.length,
|
|
1757
|
+
goalIds: plan.goals.map((goal) => goal.id),
|
|
1758
|
+
goals: plan.goals.filter((goal) => changedGoalIds.has(goal.id))
|
|
1759
|
+
};
|
|
1760
|
+
return plan.activeGoalId === undefined ? snapshot : { ...snapshot, activeGoalId: plan.activeGoalId };
|
|
1761
|
+
}
|
|
1762
|
+
function changedGoalIdsBetween(before, after) {
|
|
1763
|
+
const beforeById = new Map(before.goals.map((goal) => [goal.id, goal]));
|
|
1764
|
+
const changed = new Set;
|
|
1765
|
+
for (const goal of after.goals) {
|
|
1766
|
+
const prior = beforeById.get(goal.id);
|
|
1767
|
+
if (prior === undefined || JSON.stringify(prior) !== JSON.stringify(goal))
|
|
1768
|
+
changed.add(goal.id);
|
|
1769
|
+
beforeById.delete(goal.id);
|
|
1770
|
+
}
|
|
1771
|
+
for (const id of beforeById.keys())
|
|
1772
|
+
changed.add(id);
|
|
1773
|
+
return changed;
|
|
1774
|
+
}
|
|
1775
|
+
|
|
1728
1776
|
// components/ulw-loop/src/steering.ts
|
|
1729
1777
|
var SOURCES2 = ["user_prompt_submit", "finding", "cli"];
|
|
1730
1778
|
var PROTECTED = new Set(["aggregateCompletion", "codexObjective", "codexObjectiveAliases", "originalConstraints", "qualityGate", "status", "completedAt", "completionStatus"]);
|
|
@@ -1982,15 +2030,20 @@ async function steerUlwLoop(repoRoot, proposal, scope) {
|
|
|
1982
2030
|
return withUlwLoopMutationLock(repoRoot, scope, async () => {
|
|
1983
2031
|
const plan = await readUlwLoopPlan(repoRoot, scope);
|
|
1984
2032
|
const key = proposal.idempotencyKey ?? proposal.promptSignature;
|
|
1985
|
-
const prior = key === undefined ? undefined :
|
|
1986
|
-
if (prior?.steering !== undefined)
|
|
1987
|
-
|
|
2033
|
+
const prior = key === undefined ? undefined : await findAcceptedSteeringLedgerEntry(repoRoot, key, scope);
|
|
2034
|
+
if (prior?.steering !== undefined) {
|
|
2035
|
+
const { before: _before, after: _after, ...compactPrior } = prior.steering;
|
|
2036
|
+
return { plan, accepted: true, audit: { ...compactPrior, deduped: true }, rejectedReasons: [], deduped: true };
|
|
2037
|
+
}
|
|
1988
2038
|
const audit = validateUlwLoopSteeringProposal(plan, proposal);
|
|
1989
2039
|
const accepted = audit.invariant.accepted;
|
|
1990
2040
|
const next = accepted ? applySteeringMutation(plan, proposal, audit) : plan;
|
|
1991
|
-
const finalAudit = { ...audit
|
|
1992
|
-
if (accepted)
|
|
1993
|
-
|
|
2041
|
+
const finalAudit = { ...audit };
|
|
2042
|
+
if (accepted) {
|
|
2043
|
+
const changed = changedGoalIdsBetween(plan, next);
|
|
2044
|
+
finalAudit.before = buildSteeringPlanSnapshot(plan, changed);
|
|
2045
|
+
finalAudit.after = buildSteeringPlanSnapshot(next, changed);
|
|
2046
|
+
}
|
|
1994
2047
|
if (accepted)
|
|
1995
2048
|
await writePlan(repoRoot, next, scope);
|
|
1996
2049
|
await appendLedger(repoRoot, ledgerEntry(proposal, finalAudit, proposal.now?.toISOString() ?? iso()), scope);
|
|
@@ -2006,10 +2059,6 @@ function ledgerEntry(proposal, audit, at) {
|
|
|
2006
2059
|
entry.criterionId = proposal.criterionId;
|
|
2007
2060
|
if (proposal.idempotencyKey !== undefined)
|
|
2008
2061
|
entry.idempotencyKey = proposal.idempotencyKey;
|
|
2009
|
-
if (audit.before !== undefined)
|
|
2010
|
-
entry.before = audit.before;
|
|
2011
|
-
if (audit.after !== undefined)
|
|
2012
|
-
entry.after = audit.after;
|
|
2013
2062
|
return entry;
|
|
2014
2063
|
}
|
|
2015
2064
|
|
|
@@ -2205,8 +2254,8 @@ async function ulwLoopCommand(argv) {
|
|
|
2205
2254
|
const rest = argv.slice(1);
|
|
2206
2255
|
const repoRoot = process.cwd();
|
|
2207
2256
|
const json = hasFlag(rest, "--json");
|
|
2208
|
-
const scope = commandScope(rest);
|
|
2209
2257
|
try {
|
|
2258
|
+
const scope = commandScope(rest);
|
|
2210
2259
|
if (!isUlwLoopSubcommand(command)) {
|
|
2211
2260
|
if (json) {
|
|
2212
2261
|
printJsonError(new UlwLoopError(`Unknown ulw-loop subcommand: ${command}.`, "ULW_LOOP_SUBCOMMAND_UNKNOWN", {
|
|
@@ -2264,8 +2313,21 @@ async function ulwLoopCommand(argv) {
|
|
|
2264
2313
|
function unhandledSubcommand(command) {
|
|
2265
2314
|
throw new UlwLoopError(`Unhandled ulw-loop subcommand: ${String(command)}.`, "ULW_LOOP_SUBCOMMAND_UNHANDLED");
|
|
2266
2315
|
}
|
|
2316
|
+
var SESSION_ID_FLAG = "--session-id";
|
|
2317
|
+
function sessionIdFlagPresent(argv) {
|
|
2318
|
+
return hasFlag(argv, SESSION_ID_FLAG) || argv.some((arg) => arg.startsWith(`${SESSION_ID_FLAG}=`));
|
|
2319
|
+
}
|
|
2267
2320
|
function commandScope(argv) {
|
|
2268
|
-
|
|
2321
|
+
if (sessionIdFlagPresent(argv)) {
|
|
2322
|
+
const sessionId2 = readValue(argv, SESSION_ID_FLAG)?.trim();
|
|
2323
|
+
if (!sessionId2) {
|
|
2324
|
+
throw new UlwLoopError(`${SESSION_ID_FLAG} requires a non-empty value.`, "ULW_LOOP_SESSION_ID_REQUIRED", {
|
|
2325
|
+
details: { flag: SESSION_ID_FLAG }
|
|
2326
|
+
});
|
|
2327
|
+
}
|
|
2328
|
+
return { sessionId: sessionId2 };
|
|
2329
|
+
}
|
|
2330
|
+
const sessionId = resolveUlwLoopSessionIdFromEnv();
|
|
2269
2331
|
return sessionId === null ? undefined : { sessionId };
|
|
2270
2332
|
}
|
|
2271
2333
|
|
|
@@ -6,3 +6,9 @@ export declare function readUlwLoopPlan(repoRoot: string, scope?: UlwLoopScope):
|
|
|
6
6
|
export declare function writePlan(repoRoot: string, plan: UlwLoopPlan, scope?: UlwLoopScope): Promise<void>;
|
|
7
7
|
export declare function appendLedger(repoRoot: string, entry: UlwLoopLedgerEntry, scope?: UlwLoopScope): Promise<void>;
|
|
8
8
|
export declare function readSteeringLedgerEntries(repoRoot: string, scope?: UlwLoopScope): Promise<UlwLoopLedgerEntry[]>;
|
|
9
|
+
/**
|
|
10
|
+
* First accepted steering entry matching an idempotency key/prompt signature.
|
|
11
|
+
* A cheap substring probe on the raw line skips JSON.parse for the vast
|
|
12
|
+
* majority of entries, so dedup stays flat even on legacy multi-MB ledgers.
|
|
13
|
+
*/
|
|
14
|
+
export declare function findAcceptedSteeringLedgerEntry(repoRoot: string, key: string, scope?: UlwLoopScope): Promise<UlwLoopLedgerEntry | undefined>;
|
|
@@ -1,4 +1,6 @@
|
|
|
1
|
+
import { createReadStream } from "node:fs";
|
|
1
2
|
import { appendFile, mkdir, readFile, rename, writeFile } from "node:fs/promises";
|
|
3
|
+
import { createInterface } from "node:readline";
|
|
2
4
|
import { aggregateCodexObjectiveForScope } from "./goal-status.js";
|
|
3
5
|
import { repoRelative, ulwLoopDir, ulwLoopGoalsPath, ulwLoopLedgerPath, ulwLoopRelativeDir, } from "./paths.js";
|
|
4
6
|
import { iso, ULW_LOOP_DIR, ULW_LOOP_GOALS, ULW_LOOP_LEDGER, UlwLoopError } from "./types.js";
|
|
@@ -20,9 +22,17 @@ export async function withUlwLoopMutationLock(repoRoot, scopeOrFn, maybeFn) {
|
|
|
20
22
|
if (fn === undefined)
|
|
21
23
|
throw new UlwLoopError("Missing ulw-loop mutation body.", "ULW_LOOP_LOCK_BODY_MISSING");
|
|
22
24
|
const lockKey = `${repoRoot}\0${ulwLoopRelativeDir(scope)}`;
|
|
23
|
-
const prior = locks.get(lockKey) ?? Promise.resolve();
|
|
25
|
+
const prior = locks.get(lockKey) ?? Promise.resolve(undefined);
|
|
24
26
|
const run = prior.then(fn, fn);
|
|
25
|
-
|
|
27
|
+
// The stored gate resolves to undefined so the map never retains fn's result
|
|
28
|
+
// (plans/audits), and it removes itself once no newer waiter replaced it —
|
|
29
|
+
// otherwise a long-lived host leaks one entry per (repo, scope) forever.
|
|
30
|
+
const gate = run.then(() => undefined, () => undefined);
|
|
31
|
+
locks.set(lockKey, gate);
|
|
32
|
+
void gate.then(() => {
|
|
33
|
+
if (locks.get(lockKey) === gate)
|
|
34
|
+
locks.delete(lockKey);
|
|
35
|
+
});
|
|
26
36
|
return run;
|
|
27
37
|
}
|
|
28
38
|
export async function readUlwLoopPlan(repoRoot, scope) {
|
|
@@ -69,21 +79,57 @@ export async function appendLedger(repoRoot, entry, scope) {
|
|
|
69
79
|
await mkdir(ulwLoopDir(repoRoot, scope), { recursive: true });
|
|
70
80
|
await appendFile(ulwLoopLedgerPath(repoRoot, scope), `${JSON.stringify(entry)}\n`, "utf8");
|
|
71
81
|
}
|
|
72
|
-
|
|
73
|
-
|
|
82
|
+
/**
|
|
83
|
+
* Streams raw ledger lines without materializing the file. Real ledgers reach
|
|
84
|
+
* many MB (legacy entries embedded full-plan snapshots), so `readFile` here
|
|
85
|
+
* ballooned every steer/dedup path; line-at-a-time keeps memory O(longest line).
|
|
86
|
+
*/
|
|
87
|
+
async function* ledgerLines(repoRoot, scope) {
|
|
88
|
+
const stream = createReadStream(ulwLoopLedgerPath(repoRoot, scope), { encoding: "utf8" });
|
|
89
|
+
const lines = createInterface({ input: stream, crlfDelay: Number.POSITIVE_INFINITY });
|
|
74
90
|
try {
|
|
75
|
-
|
|
91
|
+
for await (const line of lines) {
|
|
92
|
+
if (line.trim().length > 0)
|
|
93
|
+
yield line;
|
|
94
|
+
}
|
|
76
95
|
}
|
|
77
96
|
catch (error) {
|
|
78
|
-
if (hasCode(error, "ENOENT"))
|
|
79
|
-
|
|
80
|
-
|
|
97
|
+
if (!hasCode(error, "ENOENT"))
|
|
98
|
+
throw error;
|
|
99
|
+
}
|
|
100
|
+
finally {
|
|
101
|
+
lines.close();
|
|
102
|
+
stream.destroy();
|
|
81
103
|
}
|
|
104
|
+
}
|
|
105
|
+
export async function readSteeringLedgerEntries(repoRoot, scope) {
|
|
82
106
|
const entries = [];
|
|
83
|
-
for (const line of
|
|
107
|
+
for await (const line of ledgerLines(repoRoot, scope)) {
|
|
84
108
|
const entry = JSON.parse(line);
|
|
85
109
|
if (isSteeringKind(entry.kind))
|
|
86
110
|
entries.push(entry);
|
|
87
111
|
}
|
|
88
112
|
return entries;
|
|
89
113
|
}
|
|
114
|
+
/**
|
|
115
|
+
* First accepted steering entry matching an idempotency key/prompt signature.
|
|
116
|
+
* A cheap substring probe on the raw line skips JSON.parse for the vast
|
|
117
|
+
* majority of entries, so dedup stays flat even on legacy multi-MB ledgers.
|
|
118
|
+
*/
|
|
119
|
+
export async function findAcceptedSteeringLedgerEntry(repoRoot, key, scope) {
|
|
120
|
+
const probe = JSON.stringify(key);
|
|
121
|
+
for await (const line of ledgerLines(repoRoot, scope)) {
|
|
122
|
+
if (!line.includes(probe))
|
|
123
|
+
continue;
|
|
124
|
+
const entry = JSON.parse(line);
|
|
125
|
+
if (!isSteeringKind(entry.kind))
|
|
126
|
+
continue;
|
|
127
|
+
if (entry.steering?.invariant.accepted !== true)
|
|
128
|
+
continue;
|
|
129
|
+
if (entry.idempotencyKey === key ||
|
|
130
|
+
entry.steering.idempotencyKey === key ||
|
|
131
|
+
entry.steering.promptSignature === key)
|
|
132
|
+
return entry;
|
|
133
|
+
}
|
|
134
|
+
return undefined;
|
|
135
|
+
}
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
import type { UlwLoopPlan } from "./domain-types.js";
|
|
2
|
+
import type { UlwLoopSteeringPlanSnapshot } from "./steering-types.js";
|
|
3
|
+
/**
|
|
4
|
+
* Compact before/after snapshots for steering ledger entries.
|
|
5
|
+
*
|
|
6
|
+
* Ledger entries used to embed the FULL plan (every goal, criterion, and
|
|
7
|
+
* evidence string) twice per audit and twice more at the entry top level.
|
|
8
|
+
* That made each accepted steer O(plan size) on disk, so the ledger grew
|
|
9
|
+
* quadratically over a run, and every dedup scan re-hydrated all of it into
|
|
10
|
+
* memory. A snapshot instead records plan-level counters plus only the goals
|
|
11
|
+
* the mutation actually touched, keeping each entry O(changed goals).
|
|
12
|
+
*/
|
|
13
|
+
export declare function buildSteeringPlanSnapshot(plan: UlwLoopPlan, changedGoalIds: ReadonlySet<string>): UlwLoopSteeringPlanSnapshot;
|
|
14
|
+
/** Ids of goals that differ between two plans, including added or removed goals. */
|
|
15
|
+
export declare function changedGoalIdsBetween(before: UlwLoopPlan, after: UlwLoopPlan): Set<string>;
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Compact before/after snapshots for steering ledger entries.
|
|
3
|
+
*
|
|
4
|
+
* Ledger entries used to embed the FULL plan (every goal, criterion, and
|
|
5
|
+
* evidence string) twice per audit and twice more at the entry top level.
|
|
6
|
+
* That made each accepted steer O(plan size) on disk, so the ledger grew
|
|
7
|
+
* quadratically over a run, and every dedup scan re-hydrated all of it into
|
|
8
|
+
* memory. A snapshot instead records plan-level counters plus only the goals
|
|
9
|
+
* the mutation actually touched, keeping each entry O(changed goals).
|
|
10
|
+
*/
|
|
11
|
+
export function buildSteeringPlanSnapshot(plan, changedGoalIds) {
|
|
12
|
+
const snapshot = {
|
|
13
|
+
updatedAt: plan.updatedAt,
|
|
14
|
+
goalCount: plan.goals.length,
|
|
15
|
+
goalIds: plan.goals.map((goal) => goal.id),
|
|
16
|
+
goals: plan.goals.filter((goal) => changedGoalIds.has(goal.id)),
|
|
17
|
+
};
|
|
18
|
+
return plan.activeGoalId === undefined ? snapshot : { ...snapshot, activeGoalId: plan.activeGoalId };
|
|
19
|
+
}
|
|
20
|
+
/** Ids of goals that differ between two plans, including added or removed goals. */
|
|
21
|
+
export function changedGoalIdsBetween(before, after) {
|
|
22
|
+
const beforeById = new Map(before.goals.map((goal) => [goal.id, goal]));
|
|
23
|
+
const changed = new Set();
|
|
24
|
+
for (const goal of after.goals) {
|
|
25
|
+
const prior = beforeById.get(goal.id);
|
|
26
|
+
if (prior === undefined || JSON.stringify(prior) !== JSON.stringify(goal))
|
|
27
|
+
changed.add(goal.id);
|
|
28
|
+
beforeById.delete(goal.id);
|
|
29
|
+
}
|
|
30
|
+
for (const id of beforeById.keys())
|
|
31
|
+
changed.add(id);
|
|
32
|
+
return changed;
|
|
33
|
+
}
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
import type { UlwLoopSteeringMutationKind, UlwLoopSteeringSource } from "./constants.js";
|
|
2
|
-
import type { UlwLoopPlan } from "./domain-types.js";
|
|
2
|
+
import type { UlwLoopItem, UlwLoopPlan } from "./domain-types.js";
|
|
3
3
|
export interface UlwLoopSteeringInvariantResult {
|
|
4
4
|
accepted: boolean;
|
|
5
5
|
structuralInvariantAccepted: boolean;
|
|
@@ -39,13 +39,20 @@ export interface UlwLoopSteeringProposal {
|
|
|
39
39
|
idempotencyKey?: string;
|
|
40
40
|
now?: Date;
|
|
41
41
|
}
|
|
42
|
+
export interface UlwLoopSteeringPlanSnapshot {
|
|
43
|
+
readonly updatedAt: string;
|
|
44
|
+
readonly activeGoalId?: string;
|
|
45
|
+
readonly goalCount: number;
|
|
46
|
+
readonly goalIds: readonly string[];
|
|
47
|
+
readonly goals: readonly UlwLoopItem[];
|
|
48
|
+
}
|
|
42
49
|
export interface UlwLoopSteeringAudit {
|
|
43
50
|
kind: UlwLoopSteeringMutationKind;
|
|
44
51
|
source: UlwLoopSteeringSource;
|
|
45
52
|
targetGoalIds: string[];
|
|
46
53
|
criterionId?: string;
|
|
47
|
-
before?:
|
|
48
|
-
after?:
|
|
54
|
+
before?: UlwLoopSteeringPlanSnapshot;
|
|
55
|
+
after?: UlwLoopSteeringPlanSnapshot;
|
|
49
56
|
evidence: string;
|
|
50
57
|
rationale: string;
|
|
51
58
|
invariant: UlwLoopSteeringInvariantResult;
|
|
@@ -1,7 +1,8 @@
|
|
|
1
1
|
// biome-ignore-all format: compact steering module must stay below the 240 pure-LOC budget
|
|
2
2
|
import { isUlwLoopDone } from "./goal-status.js";
|
|
3
3
|
import { seedDefaultSuccessCriteria } from "./plan-crud.js";
|
|
4
|
-
import { appendLedger,
|
|
4
|
+
import { appendLedger, findAcceptedSteeringLedgerEntry, readUlwLoopPlan, withUlwLoopMutationLock, writePlan } from "./plan-io.js";
|
|
5
|
+
import { buildSteeringPlanSnapshot, changedGoalIdsBetween } from "./steering-snapshot.js";
|
|
5
6
|
import { iso, ULW_LOOP_STEERING_MUTATION_KINDS, ULW_LOOP_SUCCESS_CRITERION_USER_MODELS } from "./types.js";
|
|
6
7
|
const SOURCES = ["user_prompt_submit", "finding", "cli"];
|
|
7
8
|
const PROTECTED = new Set(["aggregateCompletion", "codexObjective", "codexObjectiveAliases", "originalConstraints", "qualityGate", "status", "completedAt", "completionStatus"]);
|
|
@@ -260,15 +261,22 @@ export async function steerUlwLoop(repoRoot, proposal, scope) {
|
|
|
260
261
|
return withUlwLoopMutationLock(repoRoot, scope, async () => {
|
|
261
262
|
const plan = await readUlwLoopPlan(repoRoot, scope);
|
|
262
263
|
const key = proposal.idempotencyKey ?? proposal.promptSignature;
|
|
263
|
-
const prior = key === undefined ? undefined :
|
|
264
|
-
if (prior?.steering !== undefined)
|
|
265
|
-
|
|
264
|
+
const prior = key === undefined ? undefined : await findAcceptedSteeringLedgerEntry(repoRoot, key, scope);
|
|
265
|
+
if (prior?.steering !== undefined) {
|
|
266
|
+
// Legacy entries embedded full-plan before/after snapshots; never
|
|
267
|
+
// re-surface those multi-MB payloads on the dedup path.
|
|
268
|
+
const { before: _before, after: _after, ...compactPrior } = prior.steering;
|
|
269
|
+
return { plan, accepted: true, audit: { ...compactPrior, deduped: true }, rejectedReasons: [], deduped: true };
|
|
270
|
+
}
|
|
266
271
|
const audit = validateUlwLoopSteeringProposal(plan, proposal);
|
|
267
272
|
const accepted = audit.invariant.accepted;
|
|
268
273
|
const next = accepted ? applySteeringMutation(plan, proposal, audit) : plan;
|
|
269
|
-
const finalAudit = { ...audit
|
|
270
|
-
if (accepted)
|
|
271
|
-
|
|
274
|
+
const finalAudit = { ...audit };
|
|
275
|
+
if (accepted) {
|
|
276
|
+
const changed = changedGoalIdsBetween(plan, next);
|
|
277
|
+
finalAudit.before = buildSteeringPlanSnapshot(plan, changed);
|
|
278
|
+
finalAudit.after = buildSteeringPlanSnapshot(next, changed);
|
|
279
|
+
}
|
|
272
280
|
if (accepted)
|
|
273
281
|
await writePlan(repoRoot, next, scope);
|
|
274
282
|
await appendLedger(repoRoot, ledgerEntry(proposal, finalAudit, proposal.now?.toISOString() ?? iso()), scope);
|
|
@@ -284,9 +292,5 @@ function ledgerEntry(proposal, audit, at) {
|
|
|
284
292
|
entry.criterionId = proposal.criterionId;
|
|
285
293
|
if (proposal.idempotencyKey !== undefined)
|
|
286
294
|
entry.idempotencyKey = proposal.idempotencyKey;
|
|
287
|
-
if (audit.before !== undefined)
|
|
288
|
-
entry.before = audit.before;
|
|
289
|
-
if (audit.after !== undefined)
|
|
290
|
-
entry.after = audit.after;
|
|
291
295
|
return entry;
|
|
292
296
|
}
|
|
@@ -7,7 +7,7 @@
|
|
|
7
7
|
"type": "command",
|
|
8
8
|
"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook user-prompt-submit --with-ultrawork",
|
|
9
9
|
"timeout": 10,
|
|
10
|
-
"statusMessage": "(OmO) Checking Ulw-Loop Steering"
|
|
10
|
+
"statusMessage": "(OmO 4.16.2) Checking Ulw-Loop Steering"
|
|
11
11
|
}
|
|
12
12
|
]
|
|
13
13
|
}
|
|
@@ -20,7 +20,7 @@
|
|
|
20
20
|
"type": "command",
|
|
21
21
|
"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook pre-tool-use",
|
|
22
22
|
"timeout": 5,
|
|
23
|
-
"statusMessage": "(OmO) Enforcing Unlimited Ulw-Loop Budget"
|
|
23
|
+
"statusMessage": "(OmO 4.16.2) Enforcing Unlimited Ulw-Loop Budget"
|
|
24
24
|
}
|
|
25
25
|
]
|
|
26
26
|
}
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@code-yeongyu/codex-ulw-loop",
|
|
3
|
-
"version": "4.16.
|
|
3
|
+
"version": "4.16.2",
|
|
4
4
|
"description": "Codex plugin: durable repo-native multi-goal orchestration with embedded success criteria and observable evidence audit.",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"packageManager": "npm@11.12.1",
|
|
@@ -22,7 +22,7 @@ This skill is intentionally compact. The full workflow lives in `references/full
|
|
|
22
22
|
- Use the ulw-loop CLI state under `.omo/ulw-loop`; do not hand-edit goal state.
|
|
23
23
|
- After any compaction or context loss, re-read brief + goals + ledger FIRST plus `omo ulw-loop status --json`, then resume; never re-plan from scratch.
|
|
24
24
|
- If `omo ulw-loop create-goals` says the existing aggregate is already complete, start unrelated new work with a fresh `--session-id <new-id>` instead of steering or forcing the completed default state. Use `--force` only to intentionally overwrite completed evidence.
|
|
25
|
-
- Every success criterion needs observable evidence from a real surface: a channel (
|
|
25
|
+
- Every success criterion needs observable evidence from a real surface: a channel (terminal/TUI via the xterm.js web terminal, HTTP, browser, computer-use) or, for CLI- or data-shaped criteria, an auxiliary surface (CLI stdout, DB diff, parsed config dump).
|
|
26
26
|
- Record evidence through the CLI only after cleanup receipts are available.
|
|
27
27
|
- Delegate code edits, test writes, fixes, and QA execution to right-sized Codex subagents when the workflow requires it.
|
|
28
28
|
- Every `multi_agent_v1.spawn_agent` message starts with `TASK:`, then names `DELIVERABLE`, `SCOPE`, and `VERIFY`; put role and specialty instructions inside `message`; use `fork_context: false` unless full history is truly required.
|
|
@@ -46,4 +46,6 @@ The full workflow may mention OpenCode-style orchestration examples. In Codex, t
|
|
|
46
46
|
| Wait for background result | `multi_agent_v1.wait_agent(...)` |
|
|
47
47
|
| Clean up finished worker | `multi_agent_v1.close_agent(...)` |
|
|
48
48
|
|
|
49
|
+
Flat `spawn_agent` requiring `task_name` instead (`multi_agent_v2`)? Rewrite rows: add `"task_name"`, `"fork_context":false` → `"fork_turns":"none"`, `wait_agent` takes only `timeout_ms`, no `close_agent` — finished agents end on their own.
|
|
50
|
+
|
|
49
51
|
When translating `load_skills=[...]`, include the requested skill names in the spawned agent's `message`.
|
package/packages/omo-codex/plugin/components/ulw-loop/skills/ulw-loop/references/full-workflow.md
CHANGED
|
@@ -19,16 +19,16 @@ Audit each pass, fail, block, steering change, and checkpoint in `.omo/ulw-loop/
|
|
|
19
19
|
Run each criterion's real-surface proof yourself through the channel that faithfully exercises it; capture the artifact before recording PASS.
|
|
20
20
|
|
|
21
21
|
1. **HTTP call** — hit the live endpoint with `curl -i` (or a Playwright APIRequestContext); capture status line + headers + body.
|
|
22
|
-
2. **
|
|
22
|
+
2. **Terminal / TUI** - prove it through the xterm.js web terminal; tmux `send-keys` is fine for a boot smoke, but NEVER `tmux capture-pane` for color/layout/CJK evidence (it degrades truecolor).
|
|
23
23
|
3. **Browser use** — in Codex, use `browser:control-in-app-browser` first when available and the scenario does not need an authenticated or persistent user browser profile. Otherwise use Chrome to drive the REAL page; if unavailable, use agent-browser. Capture action log + screenshot path. Never downgrade a browser-facing criterion.
|
|
24
24
|
4. **Computer use** — for desktop/GUI apps, drive the running app via OS automation (computer-use, AppleScript, xdotool, etc.); capture action log + screenshot.
|
|
25
25
|
|
|
26
|
-
For TUI visual QA,
|
|
27
|
-
screenshot
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
26
|
+
For TUI visual QA, render the terminal through the real xterm.js web terminal and
|
|
27
|
+
screenshot it - NEVER a `tmux capture-pane` dump (it degrades color and wide-glyph
|
|
28
|
+
width). In this repo run `node script/qa/web-terminal-visual-qa.mjs --command
|
|
29
|
+
"<cmd>" --input "{Enter}" --evidence-dir <dir>` (live pty + xterm.js in Chrome;
|
|
30
|
+
`--from-file` replays a raw stream) and record `terminal.png`, `terminal.txt`, and
|
|
31
|
+
`metadata.json`. Mandatory when a PR or review must inspect the terminal screen.
|
|
32
32
|
|
|
33
33
|
Auxiliary surfaces (CLI stdout / DB state diff / parsed config dump) are first-class evidence for CLI- or data-shaped criteria; use a channel scenario when the behavior is user-facing. `--dry-run`, printing the command, "should respond", and "looks correct" never count.
|
|
34
34
|
|
|
@@ -39,8 +39,8 @@ export async function ulwLoopCommand(argv: readonly string[]): Promise<number> {
|
|
|
39
39
|
const rest = argv.slice(1);
|
|
40
40
|
const repoRoot = process.cwd();
|
|
41
41
|
const json = hasFlag(rest, "--json");
|
|
42
|
-
const scope = commandScope(rest);
|
|
43
42
|
try {
|
|
43
|
+
const scope = commandScope(rest);
|
|
44
44
|
if (!isUlwLoopSubcommand(command)) {
|
|
45
45
|
if (json) {
|
|
46
46
|
printJsonError(
|
|
@@ -94,7 +94,22 @@ function unhandledSubcommand(command: never): never {
|
|
|
94
94
|
throw new UlwLoopError(`Unhandled ulw-loop subcommand: ${String(command)}.`, "ULW_LOOP_SUBCOMMAND_UNHANDLED");
|
|
95
95
|
}
|
|
96
96
|
|
|
97
|
+
const SESSION_ID_FLAG = "--session-id";
|
|
98
|
+
|
|
99
|
+
function sessionIdFlagPresent(argv: readonly string[]): boolean {
|
|
100
|
+
return hasFlag(argv, SESSION_ID_FLAG) || argv.some((arg) => arg.startsWith(`${SESSION_ID_FLAG}=`));
|
|
101
|
+
}
|
|
102
|
+
|
|
97
103
|
function commandScope(argv: readonly string[]): UlwLoopScope | undefined {
|
|
98
|
-
|
|
104
|
+
if (sessionIdFlagPresent(argv)) {
|
|
105
|
+
const sessionId = readValue(argv, SESSION_ID_FLAG)?.trim();
|
|
106
|
+
if (!sessionId) {
|
|
107
|
+
throw new UlwLoopError(`${SESSION_ID_FLAG} requires a non-empty value.`, "ULW_LOOP_SESSION_ID_REQUIRED", {
|
|
108
|
+
details: { flag: SESSION_ID_FLAG },
|
|
109
|
+
});
|
|
110
|
+
}
|
|
111
|
+
return { sessionId };
|
|
112
|
+
}
|
|
113
|
+
const sessionId = resolveUlwLoopSessionIdFromEnv();
|
|
99
114
|
return sessionId === null ? undefined : { sessionId };
|
|
100
115
|
}
|
|
@@ -73,7 +73,8 @@ function model(value: string | undefined): UlwLoopSuccessCriterionUserModel | un
|
|
|
73
73
|
function neverKind(kind: never): never { return fail(`Unsupported steering kind: ${String(kind)}.`, "ULW_LOOP_STEERING_KIND_UNSUPPORTED", { kind }); }
|
|
74
74
|
|
|
75
75
|
export async function parseSteeringProposal(argv: readonly string[]): Promise<CliSteeringProposal> {
|
|
76
|
-
const kind = parseSteeringKind(argv); const source = parseSteeringSource(argv); const
|
|
76
|
+
const kind = parseSteeringKind(argv); const source = parseSteeringSource(argv); const idempotencyKey = text(readValue(argv, "--idempotency-key"), "--idempotency-key");
|
|
77
|
+
const base = { kind, source, evidence: required(argv, "--evidence"), rationale: required(argv, "--rationale"), ...(idempotencyKey === undefined ? {} : { idempotencyKey }) };
|
|
77
78
|
switch (kind) {
|
|
78
79
|
case "add_subgoal": return normalizeSteeringProposal({ ...base, title: required(argv, "--title"), objective: required(argv, "--objective") });
|
|
79
80
|
case "split_subgoal": { const goalId = requiredGoal(argv); return normalizeSteeringProposal({ ...base, goalId, targetGoalId: goalId, childGoals: await children(argv, "--children", true) }); }
|
|
@@ -1,4 +1,6 @@
|
|
|
1
|
+
import { createReadStream } from "node:fs";
|
|
1
2
|
import { appendFile, mkdir, readFile, rename, writeFile } from "node:fs/promises";
|
|
3
|
+
import { createInterface } from "node:readline";
|
|
2
4
|
|
|
3
5
|
import { aggregateCodexObjectiveForScope } from "./goal-status.js";
|
|
4
6
|
import {
|
|
@@ -14,7 +16,7 @@ import { iso, ULW_LOOP_DIR, ULW_LOOP_GOALS, ULW_LOOP_LEDGER, UlwLoopError } from
|
|
|
14
16
|
|
|
15
17
|
const LEGACY_OBJECTIVE_PREFIX = `Complete all ulw-loop stories in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}: `;
|
|
16
18
|
const LEGACY_OBJECTIVE = `Complete all ulw-loop stories listed in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}. Use ${ULW_LOOP_DIR}/${ULW_LOOP_LEDGER} as the durable audit trail.`;
|
|
17
|
-
const locks = new Map<string, Promise<
|
|
19
|
+
const locks = new Map<string, Promise<undefined>>();
|
|
18
20
|
|
|
19
21
|
function hasCode(error: unknown, code: string): boolean {
|
|
20
22
|
return error instanceof Error && "code" in error && error.code === code;
|
|
@@ -43,12 +45,19 @@ export async function withUlwLoopMutationLock<T>(
|
|
|
43
45
|
const fn = typeof scopeOrFn === "function" ? scopeOrFn : maybeFn;
|
|
44
46
|
if (fn === undefined) throw new UlwLoopError("Missing ulw-loop mutation body.", "ULW_LOOP_LOCK_BODY_MISSING");
|
|
45
47
|
const lockKey = `${repoRoot}\0${ulwLoopRelativeDir(scope)}`;
|
|
46
|
-
const prior = locks.get(lockKey) ?? Promise.resolve();
|
|
48
|
+
const prior = locks.get(lockKey) ?? Promise.resolve(undefined);
|
|
47
49
|
const run = prior.then(fn, fn);
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
50
|
+
// The stored gate resolves to undefined so the map never retains fn's result
|
|
51
|
+
// (plans/audits), and it removes itself once no newer waiter replaced it —
|
|
52
|
+
// otherwise a long-lived host leaks one entry per (repo, scope) forever.
|
|
53
|
+
const gate: Promise<undefined> = run.then(
|
|
54
|
+
() => undefined,
|
|
55
|
+
() => undefined,
|
|
51
56
|
);
|
|
57
|
+
locks.set(lockKey, gate);
|
|
58
|
+
void gate.then(() => {
|
|
59
|
+
if (locks.get(lockKey) === gate) locks.delete(lockKey);
|
|
60
|
+
});
|
|
52
61
|
return run;
|
|
53
62
|
}
|
|
54
63
|
|
|
@@ -107,18 +116,57 @@ export async function appendLedger(repoRoot: string, entry: UlwLoopLedgerEntry,
|
|
|
107
116
|
await appendFile(ulwLoopLedgerPath(repoRoot, scope), `${JSON.stringify(entry)}\n`, "utf8");
|
|
108
117
|
}
|
|
109
118
|
|
|
110
|
-
|
|
111
|
-
|
|
119
|
+
/**
|
|
120
|
+
* Streams raw ledger lines without materializing the file. Real ledgers reach
|
|
121
|
+
* many MB (legacy entries embedded full-plan snapshots), so `readFile` here
|
|
122
|
+
* ballooned every steer/dedup path; line-at-a-time keeps memory O(longest line).
|
|
123
|
+
*/
|
|
124
|
+
async function* ledgerLines(repoRoot: string, scope?: UlwLoopScope): AsyncGenerator<string> {
|
|
125
|
+
const stream = createReadStream(ulwLoopLedgerPath(repoRoot, scope), { encoding: "utf8" });
|
|
126
|
+
const lines = createInterface({ input: stream, crlfDelay: Number.POSITIVE_INFINITY });
|
|
112
127
|
try {
|
|
113
|
-
|
|
128
|
+
for await (const line of lines) {
|
|
129
|
+
if (line.trim().length > 0) yield line;
|
|
130
|
+
}
|
|
114
131
|
} catch (error) {
|
|
115
|
-
if (hasCode(error, "ENOENT"))
|
|
116
|
-
|
|
132
|
+
if (!hasCode(error, "ENOENT")) throw error;
|
|
133
|
+
} finally {
|
|
134
|
+
lines.close();
|
|
135
|
+
stream.destroy();
|
|
117
136
|
}
|
|
137
|
+
}
|
|
138
|
+
|
|
139
|
+
export async function readSteeringLedgerEntries(repoRoot: string, scope?: UlwLoopScope): Promise<UlwLoopLedgerEntry[]> {
|
|
118
140
|
const entries: UlwLoopLedgerEntry[] = [];
|
|
119
|
-
for (const line of
|
|
141
|
+
for await (const line of ledgerLines(repoRoot, scope)) {
|
|
120
142
|
const entry: UlwLoopLedgerEntry = JSON.parse(line);
|
|
121
143
|
if (isSteeringKind(entry.kind)) entries.push(entry);
|
|
122
144
|
}
|
|
123
145
|
return entries;
|
|
124
146
|
}
|
|
147
|
+
|
|
148
|
+
/**
|
|
149
|
+
* First accepted steering entry matching an idempotency key/prompt signature.
|
|
150
|
+
* A cheap substring probe on the raw line skips JSON.parse for the vast
|
|
151
|
+
* majority of entries, so dedup stays flat even on legacy multi-MB ledgers.
|
|
152
|
+
*/
|
|
153
|
+
export async function findAcceptedSteeringLedgerEntry(
|
|
154
|
+
repoRoot: string,
|
|
155
|
+
key: string,
|
|
156
|
+
scope?: UlwLoopScope,
|
|
157
|
+
): Promise<UlwLoopLedgerEntry | undefined> {
|
|
158
|
+
const probe = JSON.stringify(key);
|
|
159
|
+
for await (const line of ledgerLines(repoRoot, scope)) {
|
|
160
|
+
if (!line.includes(probe)) continue;
|
|
161
|
+
const entry: UlwLoopLedgerEntry = JSON.parse(line);
|
|
162
|
+
if (!isSteeringKind(entry.kind)) continue;
|
|
163
|
+
if (entry.steering?.invariant.accepted !== true) continue;
|
|
164
|
+
if (
|
|
165
|
+
entry.idempotencyKey === key ||
|
|
166
|
+
entry.steering.idempotencyKey === key ||
|
|
167
|
+
entry.steering.promptSignature === key
|
|
168
|
+
)
|
|
169
|
+
return entry;
|
|
170
|
+
}
|
|
171
|
+
return undefined;
|
|
172
|
+
}
|