nx 21.2.0-beta.1 → 21.2.0-beta.2

package/src/core/graph/styles.js

@@ -1 +1 @@
-"use strict";(self.webpackChunk=self.webpackChunk||[]).push([[869],{7148:()=>{}},s=>{var e;e=7148,s(s.s=e)}]);
+"use strict";(self.webpackChunk=self.webpackChunk||[]).push([[869],{932:()=>{}},s=>{var e;e=932,s(s.s=e)}]);

package/src/executors/run-commands/run-commands.impl.d.ts

@@ -1,4 +1,5 @@
 import { ExecutorContext } from '../../config/misc-interfaces';
+import { NoopChildProcess } from '../../tasks-runner/running-tasks/noop-child-process';
 import { ParallelRunningTasks, SeriallyRunningTasks } from './running-tasks';
 export declare const LARGE_BUFFER: number;
 export type Json = {
@@ -54,5 +55,5 @@ export default function (options: RunCommandsOptions, context: ExecutorContext):
     success: boolean;
     terminalOutput: string;
 }>;
-export declare function runCommands(options: RunCommandsOptions, context: ExecutorContext): Promise<import("../../tasks-runner/pseudo-terminal").PseudoTtyProcess | ParallelRunningTasks | SeriallyRunningTasks>;
+export declare function runCommands(options: RunCommandsOptions, context: ExecutorContext): Promise<import("../../tasks-runner/pseudo-terminal").PseudoTtyProcess | NoopChildProcess | ParallelRunningTasks | SeriallyRunningTasks>;
 export declare function interpolateArgsIntoCommand(command: string, opts: Pick<NormalizedRunCommandsOptions, 'args' | 'parsedArgs' | '__unparsed__' | 'unknownOptions' | 'unparsedCommandArgs'>, forwardAllArgs: boolean): string;

package/src/executors/run-commands/run-commands.impl.js

@@ -7,6 +7,7 @@ exports.interpolateArgsIntoCommand = interpolateArgsIntoCommand;
 const yargsParser = require("yargs-parser");
 const is_tui_enabled_1 = require("../../tasks-runner/is-tui-enabled");
 const pseudo_terminal_1 = require("../../tasks-runner/pseudo-terminal");
+const noop_child_process_1 = require("../../tasks-runner/running-tasks/noop-child-process");
 const running_tasks_1 = require("./running-tasks");
 exports.LARGE_BUFFER = 1024 * 1000000;
 const propKeys = [
@@ -45,6 +46,10 @@ async function runCommands(options, context) {
         !options.parallel) {
         throw new Error('ERROR: Bad executor config for run-commands - "prefix", "prefixColor", "color" and "bgColor" can only be set when "parallel=true".');
     }
+    // Handle empty commands array - return immediately with success
+    if (normalized.commands.length === 0) {
+        return new noop_child_process_1.NoopChildProcess({ code: 0, terminalOutput: '' });
+    }
     const isSingleCommand = normalized.commands.length === 1;
     const usePseudoTerminal = (isSingleCommand || !options.parallel) && pseudo_terminal_1.PseudoTerminal.isSupported();
     const isSingleCommandAndCanUsePseudoTerminal = isSingleCommand &&

package/src/nx-cloud/utilities/url-shorten.d.ts

@@ -7,4 +7,4 @@ export declare function getURLifShortenFailed(usesGithub: boolean, githubSlug: s
 export declare function getNxCloudVersion(apiUrl: string): Promise<string | null>;
 export declare function removeVersionModifier(versionString: string): string;
 export declare function versionIsValid(version: string): boolean;
-export declare function compareCleanCloudVersions(version1: string, version2: string): number;
+export declare function isOldNxCloudVersion(version: string): boolean;

package/src/nx-cloud/utilities/url-shorten.js

@@ -6,7 +6,7 @@ exports.getURLifShortenFailed = getURLifShortenFailed;
 exports.getNxCloudVersion = getNxCloudVersion;
 exports.removeVersionModifier = removeVersionModifier;
 exports.versionIsValid = versionIsValid;
-exports.compareCleanCloudVersions = compareCleanCloudVersions;
+exports.isOldNxCloudVersion = isOldNxCloudVersion;
 const logger_1 = require("../../utils/logger");
 const git_utils_1 = require("../../utils/git-utils");
 const get_cloud_options_1 = require("./get-cloud-options");
@@ -21,8 +21,7 @@ async function createNxCloudOnboardingURL(onboardingSource, accessToken, usesGit
     }
     try {
         const version = await getNxCloudVersion(apiUrl);
-        if ((version && compareCleanCloudVersions(version, '2406.11.5') < 0) ||
-            !version) {
+        if (!version || isOldNxCloudVersion(version)) {
             return apiUrl;
         }
     }
@@ -96,7 +95,7 @@ async function getInstallationSupportsGitHub(apiUrl) {
     }
     catch (e) {
         if (process.env.NX_VERBOSE_LOGGING === 'true') {
-            logger_1.logger.warn(`Failed to access system features. GitHub integration assumed to be disabled. 
+            logger_1.logger.warn(`Failed to access system features. GitHub integration assumed to be disabled.
     ${e}`);
         }
         return false;
@@ -131,26 +130,28 @@ function versionIsValid(version) {
     const pattern = /^\d{4}\.\d{2}\.\d+$/;
     return pattern.test(version);
 }
-function compareCleanCloudVersions(version1, version2) {
-    const parseVersion = (version) => {
-        // The format we're using is YYMM.DD.BuildNumber
-        const parts = version.split('.').map((part) => parseInt(part, 10));
-        return {
-            yearMonth: parts[0],
-            day: parts[1],
-            buildNumber: parts[2],
-        };
-    };
-    const v1 = parseVersion(version1);
-    const v2 = parseVersion(version2);
-    if (v1.yearMonth !== v2.yearMonth) {
-        return v1.yearMonth > v2.yearMonth ? 1 : -1;
-    }
-    if (v1.day !== v2.day) {
-        return v1.day > v2.day ? 1 : -1;
-    }
-    if (v1.buildNumber !== v2.buildNumber) {
-        return v1.buildNumber > v2.buildNumber ? 1 : -1;
-    }
-    return 0;
+function isOldNxCloudVersion(version) {
+    const [major, minor, buildNumber] = version
+        .split('.')
+        .map((part) => parseInt(part, 10));
+    // for on-prem images we are using YYYY.MM.BuildNumber format
+    // the first year is 2025
+    if (major >= 2025 && major < 2300) {
+        return false;
+    }
+    // Previously we used YYMM.DD.BuildNumber
+    // All versions before '2406.11.5' had different URL shortening logic
+    const newVersionMajor = 2406;
+    const newVersionMinor = 11;
+    const newVersionBuildNumber = 5;
+    if (major !== newVersionMajor) {
+        return major < newVersionMajor;
+    }
+    if (minor !== newVersionMinor) {
+        return minor < newVersionMinor;
+    }
+    if (buildNumber !== newVersionBuildNumber) {
+        return buildNumber < newVersionBuildNumber;
+    }
+    return false;
 }

package/src/plugins/js/project-graph/affected/lock-file-changes.js

@@ -51,10 +51,13 @@ const getProjectPathsAffectedByDependencyUpdates = (changedLockFile) => {
     return Array.from(changedProjectPaths);
 };
 const getProjectsNamesFromPaths = (projectGraphNodes, projectPaths) => {
+    if (!projectPaths.length) {
+        return [];
+    }
     const lookup = new RootPathLookup(projectGraphNodes);
-    return projectPaths.map((path) => {
-        return lookup.findNodeNameByRoot(path);
-    });
+    return projectPaths
+        .map((path) => lookup.findNodeNameByRoot(path))
+        .filter(Boolean);
 };
 class RootPathLookup {
     constructor(nodes) {

package/src/tasks-runner/run-command.js

@@ -772,6 +772,17 @@ function getRunner(nxArgs, nxJson) {
 }
 const defaultTasksRunnerPath = require.resolve('./default-tasks-runner');
 function getTasksRunnerPath(runner, nxJson) {
+    // If running inside of Codex, there will be no internet access, so we cannot use the cloud runner, regardless of other config.
+    // We can infer this scenario by checking for certain environment variables defined in their base image: https://github.com/openai/codex-universal
+    if (process.env.CODEX_ENV_NODE_VERSION) {
+        output_1.output.warn({
+            title: 'Codex environment detected, using default tasks runner',
+            bodyLines: [
+                'Codex does not have internet access when it runs tasks, so Nx will use the default tasks runner and only leverage local caching.',
+            ],
+        });
+        return defaultTasksRunnerPath;
+    }
     const isCloudRunner = 
     // No tasksRunnerOptions for given --runner
     nxJson.nxCloudAccessToken ||

package/src/tasks-runner/running-tasks/noop-child-process.d.ts

@@ -11,5 +11,6 @@ export declare class NoopChildProcess implements RunningTask {
         terminalOutput: string;
     }>;
     kill(): void;
-    onExit(cb: (code: number) => void): void;
+    onExit(cb: (code: number, terminalOutput: string) => void): void;
+    onOutput(cb: (terminalOutput: string) => void): void;
 }

package/src/tasks-runner/running-tasks/noop-child-process.js

@@ -13,7 +13,10 @@ class NoopChildProcess {
         return;
     }
     onExit(cb) {
-        cb(this.results.code);
+        cb(this.results.code, this.results.terminalOutput);
+    }
+    onOutput(cb) {
+        cb(this.results.terminalOutput);
     }
 }
 exports.NoopChildProcess = NoopChildProcess;