nx 21.2.0-beta.1 → 21.2.0-beta.2

package/README.md

@@ -22,7 +22,7 @@
 
 # Nx: Smart Repos · Fast Builds
 
-Nx is a build system, optimized for monorepos, with plugins for popular frameworks and tools and advanced CI capabilities including caching and distribution.
+An AI-first build platform that connects everything from your editor to CI. Helping you deliver fast, without breaking things.
 
 ## Getting Started
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "21.2.0-beta.1",
+  "version": "21.2.0-beta.2",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -83,16 +83,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-arm64": "21.2.0-beta.1",
-    "@nx/nx-darwin-x64": "21.2.0-beta.1",
-    "@nx/nx-freebsd-x64": "21.2.0-beta.1",
-    "@nx/nx-linux-arm-gnueabihf": "21.2.0-beta.1",
-    "@nx/nx-linux-arm64-gnu": "21.2.0-beta.1",
-    "@nx/nx-linux-arm64-musl": "21.2.0-beta.1",
-    "@nx/nx-linux-x64-gnu": "21.2.0-beta.1",
-    "@nx/nx-linux-x64-musl": "21.2.0-beta.1",
-    "@nx/nx-win32-arm64-msvc": "21.2.0-beta.1",
-    "@nx/nx-win32-x64-msvc": "21.2.0-beta.1"
+    "@nx/nx-darwin-arm64": "21.2.0-beta.2",
+    "@nx/nx-darwin-x64": "21.2.0-beta.2",
+    "@nx/nx-freebsd-x64": "21.2.0-beta.2",
+    "@nx/nx-linux-arm-gnueabihf": "21.2.0-beta.2",
+    "@nx/nx-linux-arm64-gnu": "21.2.0-beta.2",
+    "@nx/nx-linux-arm64-musl": "21.2.0-beta.2",
+    "@nx/nx-linux-x64-gnu": "21.2.0-beta.2",
+    "@nx/nx-linux-x64-musl": "21.2.0-beta.2",
+    "@nx/nx-win32-arm64-msvc": "21.2.0-beta.2",
+    "@nx/nx-win32-x64-msvc": "21.2.0-beta.2"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/affected/command-object.js

@@ -6,7 +6,7 @@ const documentation_1 = require("../yargs-utils/documentation");
 const shared_options_1 = require("../yargs-utils/shared-options");
 exports.yargsAffectedCommand = {
     command: 'affected',
-    describe: 'Run target for affected projects. See https://nx.dev/ci/features/affected for more details.',
+    describe: 'Run target for affected projects. Affected projects are projects that have been changed and projects that depend on the changed projects. See https://nx.dev/ci/features/affected for more details.',
     builder: (yargs) => (0, documentation_1.linkToNxDevAndExamples)((0, shared_options_1.withAffectedOptions)((0, shared_options_1.withTuiOptions)((0, shared_options_1.withRunOptions)((0, shared_options_1.withOutputStyleOption)((0, shared_options_1.withTargetAndConfigurationOption)((0, shared_options_1.withBatch)(yargs))))))
         .option('all', {
         type: 'boolean',

package/src/command-line/graph/graph.d.ts

@@ -36,6 +36,7 @@ export interface ExpandedTaskInputsReponse {
 }
 export declare function generateGraph(args: {
     file?: string;
+    print?: boolean;
     host?: string;
     port?: number;
     groupByFolder?: boolean;

package/src/command-line/graph/graph.js

@@ -9,6 +9,7 @@ const minimatch_1 = require("minimatch");
 const node_url_1 = require("node:url");
 const open = require("open");
 const path_1 = require("path");
+const net = require("net");
 const perf_hooks_1 = require("perf_hooks");
 const configuration_1 = require("../../config/configuration");
 const fileutils_1 = require("../../utils/fileutils");
@@ -207,7 +208,7 @@ async function generateGraph(args, affectedProjects) {
         }
     }
     if (args.affected) {
-        affectedProjects = (await (0, affected_1.getAffectedGraphNodes)((0, command_line_utils_1.splitArgsIntoNxArgsAndOverrides)(args, 'affected', { printWarnings: args.file !== 'stdout' }, (0, configuration_1.readNxJson)()).nxArgs, rawGraph)).map((n) => n.name);
+        affectedProjects = (await (0, affected_1.getAffectedGraphNodes)((0, command_line_utils_1.splitArgsIntoNxArgsAndOverrides)(args, 'affected', { printWarnings: !args.print && args.file !== 'stdout' }, (0, configuration_1.readNxJson)()).nxArgs, rawGraph)).map((n) => n.name);
     }
     if (args.exclude) {
         const invalidExcludes = [];
@@ -226,13 +227,12 @@ async function generateGraph(args, affectedProjects) {
     }
     let html = (0, node_fs_1.readFileSync)((0, path_1.join)(__dirname, '../../core/graph/index.html'), 'utf-8');
     prunedGraph = filterGraph(prunedGraph, args.focus || null, args.exclude || []);
+    if (args.print || args.file === 'stdout') {
+        console.log(JSON.stringify(await createJsonOutput(prunedGraph, rawGraph, args.projects, args.targets), null, 2));
+        await output_1.output.drain();
+        process.exit(0);
+    }
     if (args.file) {
-        // stdout is a magical constant that doesn't actually write a file
-        if (args.file === 'stdout') {
-            console.log(JSON.stringify(await createJsonOutput(prunedGraph, rawGraph, args.projects, args.targets), null, 2));
-            await output_1.output.drain();
-            process.exit(0);
-        }
         const workspaceFolder = workspace_root_1.workspaceRoot;
         const ext = (0, path_1.extname)(args.file);
         const fullFilePath = (0, path_1.isAbsolute)(args.file)
@@ -287,7 +287,20 @@ async function generateGraph(args, affectedProjects) {
     }
     else {
         const environmentJs = buildEnvironmentJs(args.exclude || [], args.watch, !!args.file && args.file.endsWith('html') ? 'build' : 'serve');
-        const { app, url } = await startServer(html, environmentJs, args.host || '127.0.0.1', args.port || 4211, args.watch, affectedProjects, args.focus, args.groupByFolder, args.exclude);
+        let app;
+        let url;
+        try {
+            const result = await startServer(html, environmentJs, args.host || '127.0.0.1', args.port || 4211, args.watch, affectedProjects, args.focus, args.groupByFolder, args.exclude);
+            app = result.app;
+            url = result.url;
+        }
+        catch (err) {
+            output_1.output.error({
+                title: 'Failed to start graph server',
+                bodyLines: [err.message],
+            });
+            process.exit(1);
+        }
         url.pathname = args.view;
         if (args.focus) {
             url.pathname += '/' + encodeURIComponent(args.focus);
@@ -318,6 +331,28 @@ async function generateGraph(args, affectedProjects) {
         });
     }
 }
+function findAvailablePort(startPort, host = '127.0.0.1') {
+    return new Promise((resolve, reject) => {
+        const server = net.createServer();
+        server.listen(startPort, host, () => {
+            const port = server.address().port;
+            server.close(() => {
+                resolve(port);
+            });
+        });
+        server.on('error', (err) => {
+            if (err.code === 'EADDRINUSE') {
+                // Port is in use, try the next one
+                findAvailablePort(startPort + 1, host)
+                    .then(resolve)
+                    .catch(reject);
+            }
+            else {
+                reject(err);
+            }
+        });
+    });
+}
 async function startServer(html, environmentJs, host, port = 4211, watchForChanges = true, affected = [], focus = null, groupByFolder = false, exclude = []) {
     let unregisterFileWatcher;
     if (watchForChanges && !client_1.daemonClient.enabled()) {
@@ -418,9 +453,19 @@ async function startServer(html, environmentJs, host, port = 4211, watchForChang
     };
     process.on('SIGINT', () => handleTermination(128 + 2));
     process.on('SIGTERM', () => handleTermination(128 + 15));
-    return new Promise((res) => {
-        app.listen(port, host, () => {
-            res({ app, url: new node_url_1.URL(`http://${host}:${port}`) });
+    // Find an available port starting from the requested port
+    const availablePort = await findAvailablePort(port, host);
+    return new Promise((res, rej) => {
+        app.on('error', (err) => {
+            rej(err);
+        });
+        app.listen(availablePort, host, () => {
+            if (availablePort !== port) {
+                output_1.output.note({
+                    title: `Port ${port} was already in use, using port ${availablePort} instead`,
+                });
+            }
+            res({ app, url: new node_url_1.URL(`http://${host}:${availablePort}`) });
         });
     });
 }

package/src/command-line/init/implementation/angular/legacy-angular-versions.js

@@ -5,28 +5,47 @@ const child_process_1 = require("child_process");
 const path_1 = require("path");
 const semver_1 = require("semver");
 const fileutils_1 = require("../../../../utils/fileutils");
+const installation_directory_1 = require("../../../../utils/installation-directory");
 const object_sort_1 = require("../../../../utils/object-sort");
 const output_1 = require("../../../../utils/output");
 const package_json_1 = require("../../../../utils/package-json");
 const package_manager_1 = require("../../../../utils/package-manager");
-const utils_1 = require("../utils");
 const connect_to_nx_cloud_1 = require("../../../connect/connect-to-nx-cloud");
+const utils_1 = require("../utils");
 // map of Angular major versions to Nx versions to use for legacy `nx init` migrations,
 // key is major Angular version and value is Nx version to use
 const nxAngularLegacyVersionMap = {
     14: '~17.0.0',
     15: '~19.0.0',
     16: '~20.1.0',
+    17: '~21.1.0',
 };
 // min major angular version supported in latest Nx
-const minMajorAngularVersionSupported = 17;
+const minMajorAngularVersionSupported = Math.max(...Object.keys(nxAngularLegacyVersionMap).map(Number)) + 1;
 // version when the Nx CLI changed from @nrwl/tao & @nrwl/cli to nx
 const versionWithConsolidatedPackages = '13.9.0';
 // version when packages were rescoped from @nrwl/* to @nx/*
 const versionWithRescopeToNx = '16.0.0-beta.2';
 async function getLegacyMigrationFunctionIfApplicable(repoRoot, options) {
-    const angularVersion = (0, package_json_1.readModulePackageJson)('@angular/core').packageJson.version;
-    const majorAngularVersion = (0, semver_1.major)(angularVersion);
+    let majorAngularVersion;
+    try {
+        const angularVersion = (0, package_json_1.readModulePackageJson)('@angular/core', [
+            repoRoot,
+            ...(0, installation_directory_1.getNxRequirePaths)(),
+        ]).packageJson.version;
+        majorAngularVersion = (0, semver_1.major)(angularVersion);
+    }
+    catch {
+        output_1.output.error({
+            title: 'Could not determine the existing Angular version',
+            bodyLines: [
+                'Please ensure "@angular/core" is installed in the workspace and you are running this command from the root of the workspace.',
+            ],
+        });
+        // errors are caught in the initHandler and not logged to the user, so we
+        // log it first and then throw to ensure it is logged to the user
+        throw new Error('Could not determine the existing Angular version');
+    }
     if (majorAngularVersion >= minMajorAngularVersionSupported) {
         // non-legacy
         return null;

package/src/command-line/migrate/migrate.js

@@ -1175,6 +1175,7 @@ function getImplementationPath(collection, collectionPath, name) {
 }
 function nxCliPath(nxWorkspaceRoot) {
     const version = process.env.NX_MIGRATE_CLI_VERSION || 'latest';
+    const isVerbose = process.env.NX_VERBOSE_LOGGING === 'true';
     try {
         const packageManager = (0, package_manager_1.detectPackageManager)();
         const pmc = (0, package_manager_1.getPackageManagerCommand)(packageManager);
@@ -1187,25 +1188,30 @@ function nxCliPath(nxWorkspaceRoot) {
             license: 'MIT',
         });
         (0, package_manager_1.copyPackageManagerConfigurationFiles)(nxWorkspaceRoot ?? workspace_root_1.workspaceRoot, tmpDir);
+        // Let's print the output of the install process to the console when verbose
+        // is enabled, so it's easier to debug issues with the installation process
+        const stdio = isVerbose
+            ? ['ignore', 'inherit', 'inherit']
+            : 'ignore';
         if (pmc.preInstall) {
             // ensure package.json and repo in tmp folder is set to a proper package manager state
             (0, child_process_1.execSync)(pmc.preInstall, {
                 cwd: tmpDir,
-                stdio: ['ignore', 'ignore', 'ignore'],
+                stdio,
                 windowsHide: false,
             });
             // if it's berry ensure we set the node_linker to node-modules
             if (packageManager === 'yarn' && pmc.ciInstall.includes('immutable')) {
                 (0, child_process_1.execSync)('yarn config set nodeLinker node-modules', {
                     cwd: tmpDir,
-                    stdio: ['ignore', 'ignore', 'ignore'],
+                    stdio,
                     windowsHide: false,
                 });
             }
         }
         (0, child_process_1.execSync)(pmc.install, {
             cwd: tmpDir,
-            stdio: ['ignore', 'ignore', 'ignore'],
+            stdio,
             windowsHide: false,
         });
         // Set NODE_PATH so that these modules can be used for module resolution
@@ -1215,7 +1221,7 @@ function nxCliPath(nxWorkspaceRoot) {
     }
     catch (e) {
         console.error(`Failed to install the ${version} version of the migration script. Using the current version.`);
-        if (process.env.NX_VERBOSE_LOGGING === 'true') {
+        if (isVerbose) {
             console.error(e);
         }
         return null;