nx 19.0.0-canary.20240430-458f2cc → 19.0.0-canary.20240503-dbad02a

package/src/project-graph/error-types.js

@@ -1,7 +1,7 @@
 "use strict";
 var _ProjectGraphError_errors, _ProjectGraphError_partialProjectGraph, _ProjectGraphError_partialSourceMaps;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.LoadPluginError = exports.DaemonProjectGraphError = exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateNodesError = exports.isCreateMetadataError = exports.isAggregateProjectGraphError = exports.AggregateProjectGraphError = exports.ProcessProjectGraphError = exports.ProcessDependenciesError = exports.CreateMetadataError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.CreateNodesError = exports.ProjectConfigurationsError = exports.isProjectsWithNoNameError = exports.ProjectsWithNoNameError = exports.isProjectsWithConflictingNamesError = exports.ProjectsWithConflictingNamesError = exports.ProjectGraphError = void 0;
+exports.LoadPluginError = exports.DaemonProjectGraphError = exports.isMergeNodesError = exports.isAggregateCreateNodesError = exports.isCreateNodesError = exports.isCreateMetadataError = exports.isAggregateProjectGraphError = exports.AggregateProjectGraphError = exports.ProcessProjectGraphError = exports.isWorkspaceValidityError = exports.WorkspaceValidityError = exports.ProcessDependenciesError = exports.CreateMetadataError = exports.MergeNodesError = exports.AggregateCreateNodesError = exports.CreateNodesError = exports.isProjectConfigurationsError = exports.ProjectConfigurationsError = exports.isProjectWithNoNameError = exports.ProjectWithNoNameError = exports.isProjectsWithNoNameError = exports.ProjectsWithNoNameError = exports.isMultipleProjectsWithSameNameError = exports.isProjectWithExistingNameError = exports.ProjectWithExistingNameError = exports.MultipleProjectsWithSameNameError = exports.ProjectGraphError = void 0;
 const tslib_1 = require("tslib");
 class ProjectGraphError extends Error {
     constructor(errors, partialProjectGraph, partialSourceMaps) {
@@ -42,7 +42,7 @@ class ProjectGraphError extends Error {
 }
 exports.ProjectGraphError = ProjectGraphError;
 _ProjectGraphError_errors = new WeakMap(), _ProjectGraphError_partialProjectGraph = new WeakMap(), _ProjectGraphError_partialSourceMaps = new WeakMap();
-class ProjectsWithConflictingNamesError extends Error {
+class MultipleProjectsWithSameNameError extends Error {
     constructor(conflicts, projects) {
         super([
             `The following projects are defined in multiple locations:`,
@@ -50,21 +50,39 @@ class ProjectsWithConflictingNamesError extends Error {
             '',
             "To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.",
         ].join('\n'));
+        this.conflicts = conflicts;
         this.projects = projects;
         this.name = this.constructor.name;
     }
 }
-exports.ProjectsWithConflictingNamesError = ProjectsWithConflictingNamesError;
-function isProjectsWithConflictingNamesError(e) {
-    return (e instanceof ProjectsWithConflictingNamesError ||
+exports.MultipleProjectsWithSameNameError = MultipleProjectsWithSameNameError;
+class ProjectWithExistingNameError extends Error {
+    constructor(projectName, projectRoot) {
+        super(`The project "${projectName}" is defined in multiple locations.`);
+        this.projectName = projectName;
+        this.projectRoot = projectRoot;
+        this.name = this.constructor.name;
+    }
+}
+exports.ProjectWithExistingNameError = ProjectWithExistingNameError;
+function isProjectWithExistingNameError(e) {
+    return (e instanceof ProjectWithExistingNameError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === ProjectWithExistingNameError.name));
+}
+exports.isProjectWithExistingNameError = isProjectWithExistingNameError;
+function isMultipleProjectsWithSameNameError(e) {
+    return (e instanceof MultipleProjectsWithSameNameError ||
         (typeof e === 'object' &&
             'name' in e &&
-            e?.name === ProjectsWithConflictingNamesError.prototype.name));
+            e?.name === MultipleProjectsWithSameNameError.name));
 }
-exports.isProjectsWithConflictingNamesError = isProjectsWithConflictingNamesError;
+exports.isMultipleProjectsWithSameNameError = isMultipleProjectsWithSameNameError;
 class ProjectsWithNoNameError extends Error {
     constructor(projectRoots, projects) {
         super(`The projects in the following directories have no name provided:\n  - ${projectRoots.join('\n  - ')}`);
+        this.projectRoots = projectRoots;
         this.projects = projects;
         this.name = this.constructor.name;
     }
@@ -74,9 +92,24 @@ function isProjectsWithNoNameError(e) {
     return (e instanceof ProjectsWithNoNameError ||
         (typeof e === 'object' &&
             'name' in e &&
-            e?.name === ProjectsWithNoNameError.prototype.name));
+            e?.name === ProjectsWithNoNameError.name));
 }
 exports.isProjectsWithNoNameError = isProjectsWithNoNameError;
+class ProjectWithNoNameError extends Error {
+    constructor(projectRoot) {
+        super(`The project in ${projectRoot} has no name provided.`);
+        this.projectRoot = projectRoot;
+        this.name = this.constructor.name;
+    }
+}
+exports.ProjectWithNoNameError = ProjectWithNoNameError;
+function isProjectWithNoNameError(e) {
+    return (e instanceof ProjectWithNoNameError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === ProjectWithNoNameError.name));
+}
+exports.isProjectWithNoNameError = isProjectWithNoNameError;
 class ProjectConfigurationsError extends Error {
     constructor(errors, partialProjectConfigurationsResult) {
         super('Failed to create project configurations');
@@ -86,6 +119,13 @@ class ProjectConfigurationsError extends Error {
     }
 }
 exports.ProjectConfigurationsError = ProjectConfigurationsError;
+function isProjectConfigurationsError(e) {
+    return (e instanceof ProjectConfigurationsError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === ProjectConfigurationsError.name));
+}
+exports.isProjectConfigurationsError = isProjectConfigurationsError;
 class CreateNodesError extends Error {
     constructor({ file, pluginName, error, }) {
         const msg = `The "${pluginName}" plugin threw an error while creating nodes from ${file}:`;
@@ -140,6 +180,22 @@ class ProcessDependenciesError extends Error {
     }
 }
 exports.ProcessDependenciesError = ProcessDependenciesError;
+class WorkspaceValidityError extends Error {
+    constructor(message) {
+        message = `Configuration Error\n${message}`;
+        super(message);
+        this.message = message;
+        this.name = this.constructor.name;
+    }
+}
+exports.WorkspaceValidityError = WorkspaceValidityError;
+function isWorkspaceValidityError(e) {
+    return (e instanceof WorkspaceValidityError ||
+        (typeof e === 'object' &&
+            'name' in e &&
+            e?.name === WorkspaceValidityError.name));
+}
+exports.isWorkspaceValidityError = isWorkspaceValidityError;
 class ProcessProjectGraphError extends Error {
     constructor(pluginName, { cause }) {
         super(`The "${pluginName}" plugin threw an error while processing the project graph:`, {
@@ -164,14 +220,14 @@ function isAggregateProjectGraphError(e) {
     return (e instanceof AggregateProjectGraphError ||
         (typeof e === 'object' &&
             'name' in e &&
-            e?.name === AggregateProjectGraphError.prototype.name));
+            e?.name === AggregateProjectGraphError.name));
 }
 exports.isAggregateProjectGraphError = isAggregateProjectGraphError;
 function isCreateMetadataError(e) {
     return (e instanceof CreateMetadataError ||
         (typeof e === 'object' &&
             'name' in e &&
-            e?.name === CreateMetadataError.prototype.name));
+            e?.name === CreateMetadataError.name));
 }
 exports.isCreateMetadataError = isCreateMetadataError;
 function isCreateNodesError(e) {

package/src/project-graph/file-utils.d.ts

@@ -18,8 +18,8 @@ export declare function isDeletedFileChange(change: Change): change is DeletedFi
 export declare function calculateFileChanges(files: string[], allWorkspaceFiles: FileData[], nxArgs?: NxArgs, readFileAtRevision?: (f: string, r: void | string) => string, ignore?: any): FileChange[];
 export declare const TEN_MEGABYTES: number;
 /**
- * TODO(v19): Remove this function
- * @deprecated To get projects use {@link retrieveProjectConfigurations} instead
+ * TODO(v20): Remove this function
+ * @deprecated To get projects use {@link retrieveProjectConfigurations} instead. This will be removed in v20.
  */
 export declare function readWorkspaceConfig(opts: {
     format: 'angularCli' | 'nx';
@@ -28,4 +28,3 @@ export declare function readWorkspaceConfig(opts: {
 export declare function defaultFileRead(filePath: string): string | null;
 export declare function readPackageJson(): any;
 export { FileData };
-export { readNxJson, workspaceLayout } from '../config/configuration';

package/src/project-graph/file-utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.workspaceLayout = exports.readNxJson = exports.readPackageJson = exports.defaultFileRead = exports.readWorkspaceConfig = exports.TEN_MEGABYTES = exports.calculateFileChanges = exports.isDeletedFileChange = exports.isWholeFileChange = exports.DeletedFileChange = exports.WholeFileChange = void 0;
+exports.readPackageJson = exports.defaultFileRead = exports.readWorkspaceConfig = exports.TEN_MEGABYTES = exports.calculateFileChanges = exports.isDeletedFileChange = exports.isWholeFileChange = exports.DeletedFileChange = exports.WholeFileChange = void 0;
 const child_process_1 = require("child_process");
 const fs_1 = require("fs");
 const path_1 = require("path");
@@ -98,8 +98,8 @@ function defaultReadFileAtRevision(file, revision) {
     }
 }
 /**
- * TODO(v19): Remove this function
- * @deprecated To get projects use {@link retrieveProjectConfigurations} instead
+ * TODO(v20): Remove this function
+ * @deprecated To get projects use {@link retrieveProjectConfigurations} instead. This will be removed in v20.
  */
 function readWorkspaceConfig(opts) {
     let configuration = null;
@@ -139,12 +139,8 @@ function readPackageJson() {
     }
 }
 exports.readPackageJson = readPackageJson;
-// TODO(17): Remove these exports
-var configuration_2 = require("../config/configuration");
-Object.defineProperty(exports, "readNxJson", { enumerable: true, get: function () { return configuration_2.readNxJson; } });
-Object.defineProperty(exports, "workspaceLayout", { enumerable: true, get: function () { return configuration_2.workspaceLayout; } });
 /**
- * TODO(v19): Remove this function.
+ * TODO(v20): Remove this function.
  */
 function getProjectsSyncNoInference(root, nxJson) {
     const allConfigFiles = (0, retrieve_workspace_files_1.retrieveProjectConfigurationPaths)(root, (0, nx_plugin_deprecated_1.getDefaultPluginsSync)(root));

package/src/project-graph/plugins/loader.js

@@ -8,7 +8,6 @@ const package_json_1 = require("../../utils/package-json");
 const fileutils_1 = require("../../utils/fileutils");
 const workspace_root_1 = require("../../utils/workspace-root");
 const node_fs_1 = require("node:fs");
-const typescript_1 = require("../../utils/typescript");
 const register_1 = require("../../plugins/js/utils/register");
 const find_project_for_path_1 = require("../utils/find-project-for-path");
 const path_1 = require("../../utils/path");
@@ -19,6 +18,7 @@ const utils_1 = require("./utils");
 const internal_api_1 = require("./internal-api");
 const error_types_1 = require("../error-types");
 const path = require("node:path/posix");
+const typescript_1 = require("../../plugins/js/utils/typescript");
 function readPluginPackageJson(pluginName, projects, paths = (0, installation_directory_1.getNxRequirePaths)()) {
     try {
         const result = (0, package_json_1.readModulePackageJsonWithoutFallbacks)(pluginName, paths);

package/src/project-graph/plugins/utils.js

@@ -2,9 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.runCreateNodesInParallel = exports.normalizeNxPlugin = exports.isNxPluginV1 = exports.isNxPluginV2 = void 0;
 const node_path_1 = require("node:path");
-const workspaces_1 = require("../../config/workspaces");
+const to_project_name_1 = require("../../config/to-project-name");
 const globs_1 = require("../../utils/globs");
 const error_types_1 = require("../error-types");
+const perf_hooks_1 = require("perf_hooks");
 function isNxPluginV2(plugin) {
     return 'createNodes' in plugin || 'createDependencies' in plugin;
 }
@@ -27,7 +28,7 @@ function normalizeNxPlugin(plugin) {
                     return {
                         projects: {
                             [root]: {
-                                name: (0, workspaces_1.toProjectName)(configFilePath),
+                                name: (0, to_project_name_1.toProjectName)(configFilePath),
                                 targets: plugin.registerProjectTargets?.(configFilePath),
                             },
                         },
@@ -40,7 +41,7 @@ function normalizeNxPlugin(plugin) {
 }
 exports.normalizeNxPlugin = normalizeNxPlugin;
 async function runCreateNodesInParallel(configFiles, plugin, options, context) {
-    performance.mark(`${plugin.name}:createNodes - start`);
+    perf_hooks_1.performance.mark(`${plugin.name}:createNodes - start`);
     const errors = [];
     const results = [];
     const promises = configFiles.map(async (file) => {
@@ -63,8 +64,8 @@ async function runCreateNodesInParallel(configFiles, plugin, options, context) {
         }
     });
     await Promise.all(promises).then(() => {
-        performance.mark(`${plugin.name}:createNodes - end`);
-        performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
+        perf_hooks_1.performance.mark(`${plugin.name}:createNodes - end`);
+        perf_hooks_1.performance.measure(`${plugin.name}:createNodes`, `${plugin.name}:createNodes - start`, `${plugin.name}:createNodes - end`);
     });
     if (errors.length > 0) {
         throw new error_types_1.AggregateCreateNodesError(plugin.name, errors, results);

package/src/project-graph/project-graph.d.ts

@@ -14,6 +14,9 @@ export declare function buildProjectGraphAndSourceMapsWithoutDaemon(): Promise<{
     projectGraph: ProjectGraph;
     sourceMaps: import("./utils/project-configuration-utils").ConfigurationSourceMaps;
 }>;
+export declare function handleProjectGraphError(opts: {
+    exitOnError: boolean;
+}, e: any): void;
 /**
  * Computes and returns a ProjectGraph.
  *

package/src/project-graph/project-graph.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.createProjectGraphAndSourceMapsAsync = exports.createProjectGraphAsync = exports.buildProjectGraphAndSourceMapsWithoutDaemon = exports.readProjectsConfigurationFromProjectGraph = exports.readCachedProjectConfiguration = exports.readCachedProjectGraph = void 0;
+exports.createProjectGraphAndSourceMapsAsync = exports.createProjectGraphAsync = exports.handleProjectGraphError = exports.buildProjectGraphAndSourceMapsWithoutDaemon = exports.readProjectsConfigurationFromProjectGraph = exports.readCachedProjectConfiguration = exports.readCachedProjectGraph = void 0;
 const perf_hooks_1 = require("perf_hooks");
 const nx_json_1 = require("../config/nx-json");
 const client_1 = require("../daemon/client/client");
@@ -162,6 +162,7 @@ function handleProjectGraphError(opts, e) {
         throw e;
     }
 }
+exports.handleProjectGraphError = handleProjectGraphError;
 /**
  * Computes and returns a ProjectGraph.
  *

package/src/project-graph/utils/normalize-project-nodes.js

@@ -2,7 +2,6 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeImplicitDependencies = exports.normalizeProjectTargets = exports.normalizeProjectNodes = void 0;
 const find_matching_projects_1 = require("../../utils/find-matching-projects");
-const project_configuration_utils_1 = require("../utils/project-configuration-utils");
 async function normalizeProjectNodes({ projects }, builder) {
     // Sorting projects by name to make sure that the order of projects in the graph is deterministic.
     // This is important to ensure that expanded properties referencing projects (e.g. implicit dependencies)
@@ -69,11 +68,6 @@ function normalizeProjectTargets(project, projectName) {
             delete targets[target];
             continue;
         }
-        targets[target].options = (0, project_configuration_utils_1.resolveNxTokensInOptions)(targets[target].options, project, `${projectName}:${target}`);
-        targets[target].configurations ??= {};
-        for (const configuration in targets[target].configurations) {
-            targets[target].configurations[configuration] = (0, project_configuration_utils_1.resolveNxTokensInOptions)(targets[target].configurations[configuration], project, `${projectName}:${target}:${configuration}`);
-        }
     }
     return targets;
 }

package/src/project-graph/utils/project-configuration-utils.d.ts

@@ -9,7 +9,7 @@ export declare function mergeProjectConfigurationIntoRootMap(projectRootMap: Rec
     targets?: Record<string, TargetConfiguration & {
         [ONLY_MODIFIES_EXISTING_TARGET]?: boolean;
     }>;
-}, configurationSourceMaps?: ConfigurationSourceMaps, sourceInformation?: SourceInformation, skipCommandNormalization?: boolean): void;
+}, configurationSourceMaps?: ConfigurationSourceMaps, sourceInformation?: SourceInformation, skipTargetNormalization?: boolean): void;
 export declare function mergeMetadata<T = ProjectMetadata | TargetMetadata>(sourceMap: Record<string, [file: string, plugin: string]>, sourceInformation: [file: string, plugin: string], baseSourceMapPath: string, metadata: T, matchingMetadata?: T): T;
 export type ConfigurationResult = {
     /**
@@ -43,6 +43,7 @@ export type ConfigurationResult = {
 export declare function createProjectConfigurations(root: string, nxJson: NxJsonConfiguration, projectFiles: string[], // making this parameter allows devkit to pick up newly created projects
 plugins: LoadedNxPlugin[]): Promise<ConfigurationResult>;
 export declare function readProjectConfigurationsFromRootMap(projectRootMap: Record<string, ProjectConfiguration>): Record<string, ProjectConfiguration>;
+export declare function validateProject(project: ProjectConfiguration, knownProjects: Record<string, ProjectConfiguration>): void;
 /**
  * Merges two targets.
  *
@@ -67,3 +68,4 @@ export declare function mergeTargetConfigurations(target: TargetConfiguration, b
 export declare function isCompatibleTarget(a: TargetConfiguration, b: TargetConfiguration): boolean;
 export declare function resolveNxTokensInOptions<T extends Object | Array<unknown>>(object: T, project: ProjectConfiguration, key: string): T;
 export declare function readTargetDefaultsForTarget(targetName: string, targetDefaults: TargetDefaults, executor?: string): TargetDefaults[string];
+export declare function normalizeTarget(target: TargetConfiguration, project: ProjectConfiguration): TargetConfiguration<any>;

package/src/project-graph/utils/project-configuration-utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.readTargetDefaultsForTarget = exports.resolveNxTokensInOptions = exports.isCompatibleTarget = exports.mergeTargetConfigurations = exports.readProjectConfigurationsFromRootMap = exports.createProjectConfigurations = exports.mergeMetadata = exports.mergeProjectConfigurationIntoRootMap = void 0;
+exports.normalizeTarget = exports.readTargetDefaultsForTarget = exports.resolveNxTokensInOptions = exports.isCompatibleTarget = exports.mergeTargetConfigurations = exports.validateProject = exports.readProjectConfigurationsFromRootMap = exports.createProjectConfigurations = exports.mergeMetadata = exports.mergeProjectConfigurationIntoRootMap = void 0;
 const logger_1 = require("../../utils/logger");
 const fileutils_1 = require("../../utils/fileutils");
 const workspace_root_1 = require("../../utils/workspace-root");
@@ -12,7 +12,7 @@ const error_types_1 = require("../error-types");
 function mergeProjectConfigurationIntoRootMap(projectRootMap, project, configurationSourceMaps, sourceInformation, 
 // This function is used when reading project configuration
 // in generators, where we don't want to do this.
-skipCommandNormalization) {
+skipTargetNormalization) {
     if (configurationSourceMaps && !configurationSourceMaps[project.root]) {
         configurationSourceMaps[project.root] = {};
     }
@@ -129,9 +129,10 @@ skipCommandNormalization) {
                 !matchingProject.targets?.[targetName]) {
                 continue;
             }
-            const mergedTarget = mergeTargetConfigurations(skipCommandNormalization
+            const normalizedTarget = skipTargetNormalization
                 ? target
-                : resolveCommandSyntacticSugar(target, project.root), matchingProject.targets?.[targetName], sourceMap, sourceInformation, `targets.${targetName}`);
+                : resolveCommandSyntacticSugar(target, project.root);
+            const mergedTarget = mergeTargetConfigurations(normalizedTarget, matchingProject.targets?.[targetName], sourceMap, sourceInformation, `targets.${targetName}`);
             // We don't want the symbol to live on past the merge process
             if (mergedTarget?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET])
                 delete mergedTarget?.[symbols_1.ONLY_MODIFIES_EXISTING_TARGET];
@@ -294,16 +295,11 @@ plugins) {
             Object.assign(externalNodes, pluginExternalNodes);
         }
         try {
-            // We still call this just to assert that the root map
-            // only contains valid project names. This is a safety check.
-            //
-            // The signature itself can't be changed as we need it to return
-            // project configurations for use in devkit.
-            readProjectConfigurationsFromRootMap(projectRootMap);
+            validateAndNormalizeProjectRootMap(projectRootMap);
         }
         catch (e) {
             if ((0, error_types_1.isProjectsWithNoNameError)(e) ||
-                (0, error_types_1.isProjectsWithConflictingNamesError)(e)) {
+                (0, error_types_1.isMultipleProjectsWithSameNameError)(e)) {
                 errors.push(e);
             }
             else {
@@ -344,34 +340,33 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
     const conflicts = new Map();
     const projectRootsWithNoName = [];
     for (const root in projectRootMap) {
-        const configuration = projectRootMap[root];
+        const project = projectRootMap[root];
         // We're setting `// targets` as a comment `targets` is empty due to Project Crystal.
         // Strip it before returning configuration for usage.
-        if (configuration['// targets'])
-            delete configuration['// targets'];
-        if (!configuration.name) {
-            try {
-                const { name } = (0, fileutils_1.readJsonFile)((0, path_1.join)(root, 'package.json'));
-                configuration.name = name;
+        if (project['// targets'])
+            delete project['// targets'];
+        try {
+            validateProject(project, projects);
+            projects[project.name] = project;
+        }
+        catch (e) {
+            if ((0, error_types_1.isProjectWithNoNameError)(e)) {
+                projectRootsWithNoName.push(e.projectRoot);
             }
-            catch {
-                projectRootsWithNoName.push(root);
+            else if ((0, error_types_1.isProjectWithExistingNameError)(e)) {
+                const rootErrors = conflicts.get(e.projectName) ?? [
+                    projects[e.projectName].root,
+                ];
+                rootErrors.push(e.projectRoot);
+                conflicts.set(e.projectName, rootErrors);
+            }
+            else {
+                throw e;
             }
-        }
-        if (configuration.name in projects) {
-            let rootErrors = conflicts.get(configuration.name) ?? [
-                projects[configuration.name].root,
-            ];
-            rootErrors.push(root);
-            conflicts.set(configuration.name, rootErrors);
-            projects[configuration.name] = configuration;
-        }
-        else {
-            projects[configuration.name] = configuration;
         }
     }
     if (conflicts.size > 0) {
-        throw new error_types_1.ProjectsWithConflictingNamesError(conflicts, projects);
+        throw new error_types_1.MultipleProjectsWithSameNameError(conflicts, projects);
     }
     if (projectRootsWithNoName.length > 0) {
         throw new error_types_1.ProjectsWithNoNameError(projectRootsWithNoName, projects);
@@ -379,6 +374,76 @@ function readProjectConfigurationsFromRootMap(projectRootMap) {
     return projects;
 }
 exports.readProjectConfigurationsFromRootMap = readProjectConfigurationsFromRootMap;
+function validateAndNormalizeProjectRootMap(projectRootMap) {
+    // Name -> Project, used to validate that all projects have unique names
+    const projects = {};
+    // If there are projects that have the same name, that is an error.
+    // This object tracks name -> (all roots of projects with that name)
+    // to provide better error messaging.
+    const conflicts = new Map();
+    const projectRootsWithNoName = [];
+    for (const root in projectRootMap) {
+        const project = projectRootMap[root];
+        // We're setting `// targets` as a comment `targets` is empty due to Project Crystal.
+        // Strip it before returning configuration for usage.
+        if (project['// targets'])
+            delete project['// targets'];
+        try {
+            validateProject(project, projects);
+            projects[project.name] = project;
+        }
+        catch (e) {
+            if ((0, error_types_1.isProjectWithNoNameError)(e)) {
+                projectRootsWithNoName.push(e.projectRoot);
+            }
+            else if ((0, error_types_1.isProjectWithExistingNameError)(e)) {
+                const rootErrors = conflicts.get(e.projectName) ?? [
+                    projects[e.projectName].root,
+                ];
+                rootErrors.push(e.projectRoot);
+                conflicts.set(e.projectName, rootErrors);
+            }
+            else {
+                throw e;
+            }
+        }
+        for (const targetName in project.targets) {
+            project.targets[targetName] = normalizeTarget(project.targets[targetName], project);
+            if (!project.targets[targetName].executor &&
+                !project.targets[targetName].command) {
+                delete project.targets[targetName];
+            }
+        }
+    }
+    if (conflicts.size > 0) {
+        throw new error_types_1.MultipleProjectsWithSameNameError(conflicts, projects);
+    }
+    if (projectRootsWithNoName.length > 0) {
+        throw new error_types_1.ProjectsWithNoNameError(projectRootsWithNoName, projects);
+    }
+    return projectRootMap;
+}
+function validateProject(project, 
+// name -> project
+knownProjects) {
+    if (!project.name) {
+        try {
+            const { name } = (0, fileutils_1.readJsonFile)((0, path_1.join)(project.root, 'package.json'));
+            if (!name) {
+                throw new Error(`Project at ${project.root} has no name provided.`);
+            }
+            project.name = name;
+        }
+        catch {
+            throw new error_types_1.ProjectWithNoNameError(project.root);
+        }
+    }
+    else if (knownProjects[project.name] &&
+        knownProjects[project.name].root !== project.root) {
+        throw new error_types_1.ProjectWithExistingNameError(project.name, project.root);
+    }
+}
+exports.validateProject = validateProject;
 /**
  * Merges two targets.
  *
@@ -459,8 +524,8 @@ function isCompatibleTarget(a, b) {
         return false;
     const isRunCommands = a.executor === 'nx:run-commands';
     if (isRunCommands) {
-        const aCommand = a.options?.command ?? a.options?.commands.join(' && ');
-        const bCommand = b.options?.command ?? b.options?.commands.join(' && ');
+        const aCommand = a.options?.command ?? a.options?.commands?.join(' && ');
+        const bCommand = b.options?.command ?? b.options?.commands?.join(' && ');
         const oneHasNoCommand = !aCommand || !bCommand;
         const hasSameCommand = aCommand === bCommand;
         return oneHasNoCommand || hasSameCommand;
@@ -577,3 +642,13 @@ function resolveCommandSyntacticSugar(target, key) {
         };
     }
 }
+function normalizeTarget(target, project) {
+    target = resolveCommandSyntacticSugar(target, project.root);
+    target.options = resolveNxTokensInOptions(target.options, project, `${project.root}:${target}`);
+    target.configurations ??= {};
+    for (const configuration in target.configurations) {
+        target.configurations[configuration] = resolveNxTokensInOptions(target.configurations[configuration], project, `${project.root}:${target}:${configuration}`);
+    }
+    return target;
+}
+exports.normalizeTarget = normalizeTarget;

package/src/tasks-runner/create-task-graph.js

@@ -170,7 +170,6 @@ class ProcessTasks {
             projectRoot: project.data.root,
             overrides: interpolatedOverrides,
             outputs: (0, utils_1.getOutputs)(this.projectGraph.nodes, qualifiedTarget, interpolatedOverrides),
-            // TODO(v19): Remove cast here after typing is moved back onto TargetConfiguration
             cache: project.data.targets[target].cache,
         };
     }

package/src/tasks-runner/life-cycles/dynamic-run-many-terminal-output-life-cycle.js

@@ -265,7 +265,7 @@ async function createRunManyDynamicOutputRenderer({ projectNames, tasks, args, o
                 '',
                 `${failedTasksForPrinting
                     .map((t) => `${EXTENDED_LEFT_PAD}${output_1.output.colors.red('-')} ${output_1.output.formatCommand(t.toString())}`)
-                    .join('\n ')}`,
+                    .join('\n')}`,
             ];
             if (failedTasks.size > numFailedToPrint) {
                 failureSummaryRows.push(output_1.output.dim(`${EXTENDED_LEFT_PAD}...and ${failedTasks.size - numFailedToPrint} more...`));

package/src/tasks-runner/run-command.js

@@ -140,7 +140,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `TaskGraph is now required as an argument to hashTask`,
                         bodyLines: [
                             `The TaskGraph object can be retrieved from the context`,
-                            'This will result in an error in Nx 19',
+                            'This will result in an error in Nx 20',
                         ],
                     });
                     taskGraph_ = taskGraph;
@@ -150,7 +150,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `The environment variables are now required as an argument to hashTask`,
                         bodyLines: [
                             `Please pass the environment variables used when running the task`,
-                            'This will result in an error in Nx 19',
+                            'This will result in an error in Nx 20',
                         ],
                     });
                     env = process.env;
@@ -163,7 +163,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `TaskGraph is now required as an argument to hashTasks`,
                         bodyLines: [
                             `The TaskGraph object can be retrieved from the context`,
-                            'This will result in an error in Nx 19',
+                            'This will result in an error in Nx 20',
                         ],
                     });
                     taskGraph_ = taskGraph;
@@ -173,7 +173,7 @@ async function invokeTasksRunner({ tasks, projectGraph, taskGraph, lifeCycle, nx
                         title: `The environment variables are now required as an argument to hashTasks`,
                         bodyLines: [
                             `Please pass the environment variables used when running the tasks`,
-                            'This will result in an error in Nx 19',
+                            'This will result in an error in Nx 20',
                         ],
                     });
                     env = process.env;

package/src/tasks-runner/utils.js

@@ -78,7 +78,24 @@ class InvalidOutputsError extends Error {
         return `The following outputs are invalid:${invalidOutputsList}\nPlease run "nx repair" to repair your configuration`;
     }
 }
+function assertOutputsAreValidType(outputs) {
+    if (!Array.isArray(outputs)) {
+        throw new Error("The 'outputs' field must be an array");
+    }
+    const typesArray = [];
+    let hasInvalidType = false;
+    for (const output of outputs) {
+        if (typeof output !== 'string') {
+            hasInvalidType = true;
+        }
+        typesArray.push(typeof output);
+    }
+    if (hasInvalidType) {
+        throw new Error(`The 'outputs' field must contain only strings, but received types: [${typesArray.join(', ')}]`);
+    }
+}
 function validateOutputs(outputs) {
+    assertOutputsAreValidType(outputs);
     const invalidOutputs = new Set();
     for (const output of outputs) {
         if (!/^!?{[\s\S]+}/.test(output)) {

package/src/utils/assert-workspace-validity.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.assertWorkspaceValidity = void 0;
 const find_matching_projects_1 = require("./find-matching-projects");
 const output_1 = require("./output");
+const devkit_internals_1 = require("../devkit-internals");
 function assertWorkspaceValidity(projects, nxJson) {
     const projectNames = Object.keys(projects);
     const projectGraphNodes = projectNames.reduce((graph, project) => {
@@ -67,7 +68,7 @@ function assertWorkspaceValidity(projects, nxJson) {
         })
             .join('\n\n');
     }
-    throw new Error(`Configuration Error\n${message}`);
+    throw new devkit_internals_1.WorkspaceValidityError(message);
 }
 exports.assertWorkspaceValidity = assertWorkspaceValidity;
 function detectAndSetInvalidProjectGlobValues(map, sourceName, desiredImplicitDeps, projectConfigurations, projects) {

package/src/utils/nx-plugin.deprecated.d.ts

@@ -26,6 +26,6 @@ export type NxPluginV1 = {
     projectFilePatterns?: string[];
 };
 /**
- * @todo(@agentender) v19: Remove this fn when we remove readWorkspaceConfig
+ * @todo(@agentender) v20: Remove this fn when we remove readWorkspaceConfig
  */
 export declare function getDefaultPluginsSync(root: string): NxPluginV2[];

package/src/utils/nx-plugin.deprecated.js

@@ -6,7 +6,7 @@ const project_json_1 = require("../plugins/project-json/build-nodes/project-json
 const target_defaults_plugin_1 = require("../plugins/target-defaults/target-defaults-plugin");
 const PackageJsonWorkspacesPlugin = require("../plugins/package-json-workspaces");
 /**
- * @todo(@agentender) v19: Remove this fn when we remove readWorkspaceConfig
+ * @todo(@agentender) v20: Remove this fn when we remove readWorkspaceConfig
  */
 function getDefaultPluginsSync(root) {
     const plugins = [

package/src/command-line/repair.d.ts

@@ -1,4 +0,0 @@
-/**
- * @deprecated(v17) This file has moved. The reexport will be removed in Nx 17.
- */
-export * from './repair/repair';