nx 19.0.0-canary.20240430-458f2cc → 19.0.0-canary.20240503-dbad02a

package/migrations.json

@@ -1,29 +1,5 @@
 {
   "generators": {
-    "15.0.0-migrate-to-inputs": {
-      "cli": "nx",
-      "version": "15.0.0-beta.1",
-      "description": "Replace implicitDependencies with namedInputs + target inputs",
-      "implementation": "./src/migrations/update-15-0-0/migrate-to-inputs"
-    },
-    "15.0.0-prefix-outputs": {
-      "cli": "nx",
-      "version": "15.0.0-beta.1",
-      "description": "Prefix outputs with {workspaceRoot}/{projectRoot} if needed",
-      "implementation": "./src/migrations/update-15-0-0/prefix-outputs"
-    },
-    "15.1.0-set-project-names": {
-      "cli": "nx",
-      "version": "15.0.12-beta.1",
-      "description": "Set project names in project.json files",
-      "implementation": "./src/migrations/update-15-1-0/set-project-names"
-    },
-    "15.8.2-update-nx-wrapper": {
-      "cli": "nx",
-      "version": "15.8.2-beta.0",
-      "description": "Updates the nx wrapper.",
-      "implementation": "./src/migrations/update-15-8-2/update-nxw"
-    },
     "16.0.0-remove-nrwl-cli": {
       "cli": "nx",
       "version": "16.0.0-beta.0",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nx",
-  "version": "19.0.0-canary.20240430-458f2cc",
+  "version": "19.0.0-canary.20240503-dbad02a",
   "private": false,
   "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "repository": {
@@ -66,7 +66,7 @@
     "yargs-parser": "21.1.1",
     "node-machine-id": "1.1.12",
     "ora": "5.3.0",
-    "@nrwl/tao": "19.0.0-canary.20240430-458f2cc"
+    "@nrwl/tao": "19.0.0-canary.20240503-dbad02a"
   },
   "peerDependencies": {
     "@swc-node/register": "^1.8.0",
@@ -81,16 +81,16 @@
     }
   },
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-darwin-arm64": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-linux-x64-gnu": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-linux-x64-musl": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-win32-x64-msvc": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-linux-arm64-gnu": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-linux-arm64-musl": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-linux-arm-gnueabihf": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-win32-arm64-msvc": "19.0.0-canary.20240430-458f2cc",
-    "@nx/nx-freebsd-x64": "19.0.0-canary.20240430-458f2cc"
+    "@nx/nx-darwin-x64": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-darwin-arm64": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-linux-x64-gnu": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-linux-x64-musl": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-win32-x64-msvc": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-linux-arm64-gnu": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-linux-arm64-musl": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-linux-arm-gnueabihf": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-win32-arm64-msvc": "19.0.0-canary.20240503-dbad02a",
+    "@nx/nx-freebsd-x64": "19.0.0-canary.20240503-dbad02a"
   },
   "nx-migrations": {
     "migrations": "./migrations.json",

package/src/command-line/add/add.js

@@ -23,15 +23,16 @@ function addHandler(options) {
     return (0, params_1.handleErrors)(isVerbose, async () => {
         output_1.output.addNewline();
         const [pkgName, version] = parsePackageSpecifier(options.packageSpecifier);
-        await installPackage(pkgName, version);
-        await initializePlugin(pkgName, options);
+        const nxJson = (0, nx_json_1.readNxJson)();
+        await installPackage(pkgName, version, nxJson);
+        await initializePlugin(pkgName, options, nxJson);
         output_1.output.success({
             title: `Package ${pkgName} added successfully.`,
         });
     });
 }
 exports.addHandler = addHandler;
-async function installPackage(pkgName, version) {
+async function installPackage(pkgName, version, nxJson) {
     const spinner = ora(`Installing ${pkgName}@${version}...`);
     spinner.start();
     if ((0, fs_1.existsSync)('package.json')) {
@@ -50,7 +51,6 @@ async function installPackage(pkgName, version) {
         }));
     }
     else {
-        const nxJson = (0, nx_json_1.readNxJson)();
         nxJson.installation.plugins ??= {};
         nxJson.installation.plugins[pkgName] = version;
         (0, fileutils_1.writeJsonFile)('nx.json', nxJson);
@@ -72,7 +72,7 @@ async function installPackage(pkgName, version) {
     }
     spinner.succeed();
 }
-async function initializePlugin(pkgName, options) {
+async function initializePlugin(pkgName, options, nxJson) {
     const capabilities = await (0, plugins_1.getPluginCapabilities)(workspace_root_1.workspaceRoot, pkgName, {});
     const generators = capabilities?.generators;
     if (!generators) {
@@ -91,19 +91,20 @@ async function initializePlugin(pkgName, options) {
     const spinner = ora(`Initializing ${pkgName}...`);
     spinner.start();
     try {
-        let updatePackageScripts;
-        if (options.updatePackageScripts !== undefined) {
-            updatePackageScripts = options.updatePackageScripts;
+        const args = [];
+        if (coreNxPlugins.includes(pkgName)) {
+            args.push(`--keepExistingVersions`);
+            if (options.updatePackageScripts ||
+                (options.updatePackageScripts === undefined &&
+                    nxJson.useInferencePlugins !== false &&
+                    process.env.NX_ADD_PLUGINS !== 'false')) {
+                args.push(`--updatePackageScripts`);
+            }
         }
-        else {
-            updatePackageScripts =
-                (0, nx_json_1.readNxJson)().useInferencePlugins !== false &&
-                    process.env.NX_ADD_PLUGINS !== 'false' &&
-                    coreNxPlugins.includes(pkgName);
+        if (options.__overrides_unparsed__.length) {
+            args.push(...options.__overrides_unparsed__);
         }
-        await (0, child_process_2.runNxAsync)(`g ${pkgName}:${initGenerator} --keepExistingVersions${updatePackageScripts ? ' --updatePackageScripts' : ''}${options.__overrides_unparsed__.length
-            ? ' ' + options.__overrides_unparsed__.join(' ')
-            : ''}`, {
+        await (0, child_process_2.runNxAsync)(`g ${pkgName}:${initGenerator} ${args.join(' ')}`, {
             silent: !options.verbose,
         });
     }

package/src/command-line/affected/affected.js

@@ -53,7 +53,7 @@ async function affected(command, args, extraTargetDependencies = {}) {
                     const projectNames = projectsWithTarget.map((t) => t.name);
                     const file = (0, command_line_utils_1.readGraphFileFromGraphArg)(nxArgs);
                     return await (0, graph_1.generateGraph)({
-                        watch: false,
+                        watch: true,
                         open: true,
                         view: 'tasks',
                         targets: nxArgs.targets,

package/src/command-line/graph/graph.d.ts

@@ -1,10 +1,18 @@
 import { ProjectFileMap, ProjectGraphDependency, ProjectGraphProjectNode } from '../../config/project-graph';
 import { TaskGraph } from '../../config/task-graph';
+export interface GraphError {
+    message: string;
+    stack: string;
+    cause: unknown;
+    name: string;
+    pluginName: string;
+    fileName?: string;
+}
 export interface ProjectGraphClientResponse {
     hash: string;
     projects: ProjectGraphProjectNode[];
     dependencies: Record<string, ProjectGraphDependency[]>;
-    fileMap: ProjectFileMap;
+    fileMap?: ProjectFileMap;
     layout: {
         appsDir: string;
         libsDir: string;
@@ -13,6 +21,8 @@ export interface ProjectGraphClientResponse {
     focus: string;
     groupByFolder: boolean;
     exclude: string[];
+    isPartial: boolean;
+    errors?: GraphError[];
 }
 export interface TaskGraphClientResponse {
     taskGraphs: Record<string, TaskGraph>;

package/src/command-line/graph/graph.js

@@ -25,8 +25,9 @@ const native_1 = require("../../native");
 const transform_objects_1 = require("../../native/transform-objects");
 const affected_1 = require("../affected/affected");
 const nx_deps_cache_1 = require("../../project-graph/nx-deps-cache");
-const task_hasher_1 = require("../../hasher/task-hasher");
 const create_task_hasher_1 = require("../../hasher/create-task-hasher");
+const task_hasher_1 = require("../../hasher/task-hasher");
+const error_types_1 = require("../../project-graph/error-types");
 // maps file extention to MIME types
 const mimeType = {
     '.ico': 'image/x-icon',
@@ -156,9 +157,40 @@ async function generateGraph(args, affectedProjects) {
     const target = Array.isArray(args.targets && args.targets.length >= 1)
         ? args.targets[0]
         : args.targets;
-    const { projectGraph: rawGraph, sourceMaps } = await (0, project_graph_1.createProjectGraphAndSourceMapsAsync)({
-        exitOnError: true,
-    });
+    let rawGraph;
+    let sourceMaps;
+    let isPartial = false;
+    try {
+        const projectGraphAndSourceMaps = await (0, project_graph_1.createProjectGraphAndSourceMapsAsync)({
+            exitOnError: false,
+        });
+        rawGraph = projectGraphAndSourceMaps.projectGraph;
+        sourceMaps = projectGraphAndSourceMaps.sourceMaps;
+    }
+    catch (e) {
+        if (e instanceof error_types_1.ProjectGraphError) {
+            rawGraph = e.getPartialProjectGraph();
+            sourceMaps = e.getPartialSourcemaps();
+            isPartial = true;
+        }
+        if (!rawGraph) {
+            (0, project_graph_1.handleProjectGraphError)({ exitOnError: true }, e);
+        }
+        else {
+            const errors = e.getErrors();
+            if (errors?.length > 0) {
+                errors.forEach((e) => {
+                    output_1.output.error({
+                        title: e.message,
+                        bodyLines: [e.stack],
+                    });
+                });
+            }
+            output_1.output.warn({
+                title: `${errors?.length > 1 ? `${errors.length} errors` : `An error`} occured while processing the project graph. Showing partial graph.`,
+            });
+        }
+    }
     let prunedGraph = (0, operators_1.pruneExternalNodes)(rawGraph);
     const projects = Object.values(prunedGraph.nodes);
     projects.sort((a, b) => {
@@ -295,7 +327,7 @@ async function generateGraph(args, affectedProjects) {
     }
 }
 exports.generateGraph = generateGraph;
-async function startServer(html, environmentJs, host, port = 4211, watchForchanges = false, affected = [], focus = null, groupByFolder = false, exclude = []) {
+async function startServer(html, environmentJs, host, port = 4211, watchForchanges = true, affected = [], focus = null, groupByFolder = false, exclude = []) {
     let unregisterFileWatcher;
     if (watchForchanges) {
         unregisterFileWatcher = await createFileWatcher();
@@ -395,6 +427,8 @@ let currentProjectGraphClientResponse = {
     focus: null,
     groupByFolder: false,
     exclude: [],
+    isPartial: false,
+    errors: [],
 };
 let currentSourceMapsClientResponse = {};
 function debounce(fn, time) {
@@ -407,7 +441,11 @@ function debounce(fn, time) {
     };
 }
 function createFileWatcher() {
-    return client_1.daemonClient.registerFileWatcher({ watchProjects: 'all', includeGlobalWorkspaceFiles: true }, debounce(async (error, changes) => {
+    return client_1.daemonClient.registerFileWatcher({
+        watchProjects: 'all',
+        includeGlobalWorkspaceFiles: true,
+        allowPartialGraph: true,
+    }, debounce(async (error, changes) => {
         if (error === 'closed') {
             output_1.output.error({ title: `Watch error: Daemon closed the connection` });
             process.exit(1);
@@ -421,6 +459,19 @@ function createFileWatcher() {
             if (projectGraphClientResponse.hash !==
                 currentProjectGraphClientResponse.hash &&
                 sourceMapResponse) {
+                if (projectGraphClientResponse.errors?.length > 0) {
+                    projectGraphClientResponse.errors.forEach((e) => {
+                        output_1.output.error({
+                            title: e.message,
+                            bodyLines: [e.stack],
+                        });
+                    });
+                    output_1.output.warn({
+                        title: `${projectGraphClientResponse.errors.length > 1
+                            ? `${projectGraphClientResponse.errors.length} errors`
+                            : `An error`} occured while processing the project graph. Showing partial graph.`,
+                    });
+                }
                 output_1.output.note({ title: 'Graph changes updated.' });
                 currentProjectGraphClientResponse = projectGraphClientResponse;
                 currentSourceMapsClientResponse = sourceMapResponse;
@@ -433,16 +484,42 @@ function createFileWatcher() {
 }
 async function createProjectGraphAndSourceMapClientResponse(affected = []) {
     perf_hooks_1.performance.mark('project graph watch calculation:start');
-    const { projectGraph, sourceMaps } = await (0, project_graph_1.createProjectGraphAndSourceMapsAsync)({ exitOnError: true });
+    let projectGraph;
+    let sourceMaps;
+    let isPartial = false;
+    let errors;
+    try {
+        const projectGraphAndSourceMaps = await (0, project_graph_1.createProjectGraphAndSourceMapsAsync)({ exitOnError: false });
+        projectGraph = projectGraphAndSourceMaps.projectGraph;
+        sourceMaps = projectGraphAndSourceMaps.sourceMaps;
+    }
+    catch (e) {
+        if (e instanceof error_types_1.ProjectGraphError) {
+            projectGraph = e.getPartialProjectGraph();
+            sourceMaps = e.getPartialSourcemaps();
+            errors = e.getErrors().map((e) => ({
+                message: e.message,
+                stack: e.stack,
+                cause: e.cause,
+                name: e.name,
+                pluginName: e.pluginName,
+                fileName: e.file ?? e.cause?.errors?.[0]?.location?.file,
+            }));
+            isPartial = true;
+        }
+        if (!projectGraph) {
+            (0, project_graph_1.handleProjectGraphError)({ exitOnError: true }, e);
+        }
+    }
     let graph = (0, operators_1.pruneExternalNodes)(projectGraph);
-    let fileMap = (0, nx_deps_cache_1.readFileMapCache)().fileMap.projectFileMap;
+    let fileMap = (0, nx_deps_cache_1.readFileMapCache)()?.fileMap.projectFileMap;
     perf_hooks_1.performance.mark('project graph watch calculation:end');
     perf_hooks_1.performance.mark('project graph response generation:start');
     const layout = (0, configuration_1.workspaceLayout)();
     const projects = Object.values(graph.nodes);
     const dependencies = graph.dependencies;
     const hasher = (0, crypto_1.createHash)('sha256');
-    hasher.update(JSON.stringify({ layout, projects, dependencies, sourceMaps }));
+    hasher.update(JSON.stringify({ layout, projects, dependencies, sourceMaps, errors }));
     const hash = hasher.digest('hex');
     perf_hooks_1.performance.mark('project graph response generation:end');
     perf_hooks_1.performance.measure('project graph watch calculation', 'project graph watch calculation:start', 'project graph watch calculation:end');
@@ -456,17 +533,24 @@ async function createProjectGraphAndSourceMapClientResponse(affected = []) {
             dependencies,
             affected,
             fileMap,
+            isPartial,
+            errors,
         },
         sourceMapResponse: sourceMaps,
     };
 }
 async function createTaskGraphClientResponse(pruneExternal = false) {
     let graph;
-    if (pruneExternal) {
-        graph = (0, operators_1.pruneExternalNodes)(await (0, project_graph_1.createProjectGraphAsync)({ exitOnError: true }));
+    try {
+        graph = await (0, project_graph_1.createProjectGraphAsync)({ exitOnError: false });
     }
-    else {
-        graph = await (0, project_graph_1.createProjectGraphAsync)({ exitOnError: true });
+    catch (e) {
+        if (e instanceof error_types_1.ProjectGraphError) {
+            graph = e.getPartialProjectGraph();
+        }
+    }
+    if (pruneExternal) {
+        graph = (0, operators_1.pruneExternalNodes)(graph);
     }
     const nxJson = (0, configuration_1.readNxJson)();
     perf_hooks_1.performance.mark('task graph generation:start');

package/src/command-line/release/changelog.js

@@ -16,7 +16,6 @@ const is_ci_1 = require("../../utils/is-ci");
 const output_1 = require("../../utils/output");
 const params_1 = require("../../utils/params");
 const path_1 = require("../../utils/path");
-const typescript_1 = require("../../utils/typescript");
 const workspace_root_1 = require("../../utils/workspace-root");
 const config_1 = require("./config/config");
 const filter_release_groups_1 = require("./config/filter-release-groups");
@@ -27,6 +26,7 @@ const markdown_1 = require("./utils/markdown");
 const print_changes_1 = require("./utils/print-changes");
 const resolve_nx_json_error_message_1 = require("./utils/resolve-nx-json-error-message");
 const shared_1 = require("./utils/shared");
+const typescript_1 = require("../../plugins/js/utils/typescript");
 const releaseChangelogCLIHandler = (args) => (0, params_1.handleErrors)(args.verbose, () => releaseChangelog(args));
 exports.releaseChangelogCLIHandler = releaseChangelogCLIHandler;
 /**

package/src/command-line/release/command-object.js

@@ -2,9 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.yargsReleaseCommand = void 0;
 const yargs_1 = require("yargs");
-const file_utils_1 = require("../../project-graph/file-utils");
 const logger_1 = require("../../utils/logger");
 const shared_options_1 = require("../yargs-utils/shared-options");
+const nx_json_1 = require("../../config/nx-json");
 exports.yargsReleaseCommand = {
     command: 'release',
     describe: 'Orchestrate versioning and publishing of applications and libraries',
@@ -46,7 +46,7 @@ exports.yargsReleaseCommand = {
         if (argv.groups && argv.projects) {
             throw new Error('The --projects and --groups options are mutually exclusive, please use one or the other.');
         }
-        const nxJson = (0, file_utils_1.readNxJson)();
+        const nxJson = (0, nx_json_1.readNxJson)();
         if (argv.groups?.length) {
             for (const group of argv.groups) {
                 if (!nxJson.release?.groups?.[group]) {

package/src/command-line/release/publish.js

@@ -106,7 +106,7 @@ async function runPublishOnProjects(args, projectGraph, nxJson, projectNames, sh
             .map((t) => t.name)
             .filter((projectName) => (0, project_graph_utils_1.projectHasTarget)(projectGraph.nodes[projectName], requiredTargetName));
         await (0, graph_1.generateGraph)({
-            watch: false,
+            watch: true,
             all: false,
             open: true,
             view: 'tasks',

package/src/command-line/report/report.js

@@ -197,7 +197,7 @@ function findRegisteredPluginsBeingUsed(nxJson) {
 exports.findRegisteredPluginsBeingUsed = findRegisteredPluginsBeingUsed;
 function findInstalledPackagesWeCareAbout() {
     const packagesWeMayCareAbout = {};
-    // TODO (v19): Remove workaround for hiding @nrwl packages when matching @nx package is found.
+    // TODO (v20): Remove workaround for hiding @nrwl packages when matching @nx package is found.
     const packageChangeMap = {
         '@nrwl/nx-plugin': '@nx/plugin',
         '@nx/plugin': '@nrwl/nx-plugin',

package/src/command-line/run/run-one.js

@@ -38,7 +38,7 @@ async function runOne(cwd, args, extraTargetDependencies = {}, extraOptions = {
         const projectNames = projects.map((t) => t.name);
         const file = (0, command_line_utils_1.readGraphFileFromGraphArg)(nxArgs);
         return await (0, graph_1.generateGraph)({
-            watch: false,
+            watch: true,
             open: true,
             view: 'tasks',
             targets: nxArgs.targets,

package/src/command-line/run-many/run-many.js

@@ -29,7 +29,7 @@ async function runMany(args, extraTargetDependencies = {}, extraOptions = { excl
         const file = (0, command_line_utils_1.readGraphFileFromGraphArg)(nxArgs);
         const projectNames = projects.map((t) => t.name);
         return await (0, graph_1.generateGraph)({
-            watch: false,
+            watch: true,
             open: true,
             view: 'tasks',
             all: nxArgs.all,

package/src/command-line/yargs-utils/shared-options.js

@@ -249,7 +249,7 @@ function withDepGraphOptions(yargs) {
         .option('watch', {
         describe: 'Watch for changes to project graph and update in-browser',
         type: 'boolean',
-        default: false,
+        default: true,
     })
         .option('open', {
         describe: 'Open the project graph in the browser.',

package/src/config/to-project-name.d.ts

@@ -0,0 +1,5 @@
+/**
+ * Pulled from toFileName in names from @nx/devkit.
+ * Todo: Should refactor, not duplicate.
+ */
+export declare function toProjectName(fileName: string): string;

package/src/config/to-project-name.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.toProjectName = void 0;
+const path_1 = require("path");
+/**
+ * Pulled from toFileName in names from @nx/devkit.
+ * Todo: Should refactor, not duplicate.
+ */
+function toProjectName(fileName) {
+    const parts = (0, path_1.dirname)(fileName).split(/[\/\\]/g);
+    return parts[parts.length - 1].toLowerCase();
+}
+exports.toProjectName = toProjectName;