node-osc 11.2.0 → 11.2.2

package/test/test-promises.mjs

@@ -1,29 +1,51 @@
 import { once } from 'node:events';
-import { beforeEach, test } from 'tap';
-import { bootstrap } from './util.mjs';
+import { test } from 'tap';
 
 import { Server, Client } from 'node-osc';
 
-beforeEach(bootstrap);
-
 test('client: send with promise - array', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const server = new Server(0, '127.0.0.1');
+  await once(server, 'listening');
+  const client = new Client('127.0.0.1', server.port);
 
   t.plan(1);
 
+  server.on('message', (msg) => {
+    server.close();
+    t.same(msg, ['/test', 0, 1, 'testing', true], 'We should receive expected payload');
+  });
+
+  await client.send(['/test', 0, 1, 'testing', true]);
+  await client.close();
+});
+
+test('client: array is not mutated when sent with promise', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
+
+  t.plan(2);
+
+  const originalArray = ['/test', 0, 1, 'testing', true];
+  const expectedArray = ['/test', 0, 1, 'testing', true];
+
   oscServer.on('message', (msg) => {
     oscServer.close();
     t.same(msg, ['/test', 0, 1, 'testing', true], 'We should receive expected payload');
   });
 
-  await client.send(['/test', 0, 1, 'testing', true]);
+  await client.send(originalArray);
+  
+  // Verify the original array was not mutated
+  t.same(originalArray, expectedArray, 'Original array should not be mutated');
+  
   await client.close();
 });
 
 test('client: send with promise - string', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
@@ -37,8 +59,9 @@ test('client: send with promise - string', async (t) => {
 });
 
 test('client: send with promise - message object', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
@@ -55,8 +78,9 @@ test('client: send with promise - message object', async (t) => {
 });
 
 test('client: send with promise - multiple args', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
@@ -70,12 +94,15 @@ test('client: send with promise - multiple args', async (t) => {
 });
 
 test('client: send promise rejection on closed socket', async (t) => {
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
   await client.close();
-  
+  await oscServer.close();
+
   try {
     await client.send('/boom');
     t.fail('Should have thrown an error');
@@ -85,8 +112,9 @@ test('client: send promise rejection on closed socket', async (t) => {
 });
 
 test('client: async/await usage', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
@@ -102,7 +130,7 @@ test('client: async/await usage', async (t) => {
 });
 
 test('server: close with promise', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
+  const oscServer = new Server(0, '127.0.0.1');
   
   t.plan(1);
 
@@ -113,7 +141,7 @@ test('server: close with promise', async (t) => {
 });
 
 test('server: no callback still emits listening event', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
+  const oscServer = new Server(0, '127.0.0.1');
   
   t.plan(1);
 
@@ -124,15 +152,16 @@ test('server: no callback still emits listening event', async (t) => {
 });
 
 test('client and server: full async/await workflow', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
-
-  t.plan(2);
+  t.plan(3);
+  const oscServer = new Server(0, '127.0.0.1');
 
   // Wait for server to be ready
   await once(oscServer, 'listening');
   t.pass('Server started');
 
+  const client = new Client('127.0.0.1', oscServer.port);
+  t.pass('Client created');
+
   // Set up message handler
   const messageReceived = once(oscServer, 'message');
 
@@ -147,9 +176,9 @@ test('client and server: full async/await workflow', async (t) => {
 });
 
 test('client: multiple sends with promises', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
-
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
   t.plan(3);
 
   const messages = [];
@@ -173,6 +202,8 @@ test('client: multiple sends with promises', async (t) => {
 });
 
 test('client: close promise rejection on error', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
   const client = new Client('127.0.0.1', t.context.port);
 
   t.plan(1);
@@ -202,6 +233,7 @@ test('client: close promise rejection on error', async (t) => {
   };
 
   try {
+    await oscServer.close();
     await client.close();
     t.fail('Should have thrown an error');
   } catch (err) {
@@ -210,7 +242,7 @@ test('client: close promise rejection on error', async (t) => {
 });
 
 test('server: close promise rejection on error', async (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
+  const oscServer = new Server(0, '127.0.0.1');
 
   t.plan(1);
 
@@ -247,3 +279,35 @@ test('server: close promise rejection on error', async (t) => {
     t.equal(err.code, 'MOCK_ERROR', 'Should reject with mock error');
   }
 });
+
+test('client: send promise rejection on send error', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
+
+  t.plan(1);
+
+  // Mock the socket's send method to simulate an error
+  const originalSend = client._sock.send;
+  client._sock.send = function(msg, offset, length, port, address, callback) {
+    // Simulate an error being passed to callback
+    const err = new Error('Mock send error');
+    err.code = 'MOCK_SEND_ERROR';
+    if (callback) {
+      setImmediate(() => callback(err));
+    }
+  };
+
+  t.teardown(async () => {
+    client._sock.send = originalSend;
+    await client.close();
+    await oscServer.close();
+  });
+
+  try {
+    await client.send('/test', 'data');
+    t.fail('Should have thrown an error');
+  } catch (err) {
+    t.equal(err.code, 'MOCK_SEND_ERROR', 'Should reject with mock send error');
+  }
+});

package/test/test-server.mjs

@@ -1,21 +1,21 @@
-import { beforeEach, test } from 'tap';
-import { bootstrap } from './util.mjs';
+import { once } from 'node:events';
+import { test } from 'tap';
 
 import { Server, Client } from 'node-osc';
 
-beforeEach(bootstrap);
-
-test('server: create and close', (t) => {
+test('server: create and close', async (t) => {
   t.plan(1);
-  const oscServer = new Server(t.context.port, '127.0.0.1');
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
   oscServer.close((err) => {
     t.error(err);
   });
 });
 
-test('server: listen to message', (t) => {
-  const oscServer = new Server(t.context.port);
-  const client = new Client('127.0.0.1', t.context.port);
+test('server: listen to message', async (t) => {
+  const oscServer = new Server(0);
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(3);
 
@@ -37,9 +37,10 @@ test('server: listen to message', (t) => {
   });
 });
 
-test('server: no defined host', (t) => {
-  const oscServer = new Server(t.context.port);
-  const client = new Client('127.0.0.1', t.context.port);
+test('server: no defined host', async (t) => {
+  const oscServer = new Server(0);
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(3);
 
@@ -61,12 +62,13 @@ test('server: no defined host', (t) => {
   });
 });
 
-test('server: callback as second arg', (t) => {
+test('server: callback as second arg', async (t) => {
   t.plan(4);
-  const oscServer = new Server(t.context.port, () => {
+  const oscServer = new Server(0, () => {
     t.ok('callback called');
   });
-  const client = new Client('127.0.0.1', t.context.port);
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.teardown(() => {
     oscServer.close();
@@ -86,9 +88,10 @@ test('server: callback as second arg', (t) => {
   });
 });
 
-test('server: bad message', (t) => {
+test('server: bad message', async (t) => {
   t.plan(2);
-  const oscServer = new Server(t.context.port, '127.0.0.1');
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
   t.throws(() => {
     oscServer._sock.emit('message', 'whoops');
   }, /can't decode incoming message:/);

package/types/Message.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"Message.d.mts","sourceRoot":"","sources":["../lib/Message.mjs"],"names":[],"mappings":";AAyBA;;;;;;;;;;;;;;;;;;GAkBG;AACH;IACE;;;;;;;;;;;;;;OAcG;IACH,qBAZW,MAAM,WACH,GAAC,EAAA,EAed;IAHC,gBAAwB;IACxB,gBAAsB;IACtB,YAAgB;IAGlB;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAwCG;IACH,YA7BW,GAAC,QA2DX;CACF"}
+{"version":3,"file":"Message.d.mts","sourceRoot":"","sources":["../lib/Message.mjs"],"names":[],"mappings":";AAyBA;;;;;;;;;;;;;;;;;;GAkBG;AACH;IACE;;;;;;;;;;;;;;OAcG;IACH,qBAZW,MAAM,WACH,GAAC,EAAA,EAed;IAHC,gBAAwB;IACxB,gBAAsB;IACtB,YAAgB;IAGlB;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAwCG;IACH,YA7BW,GAAC,QA6DX;CACF"}

package/types/Server.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"Server.d.mts","sourceRoot":"","sources":["../lib/Server.mjs"],"names":[],"mappings":";AAKA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA8CG;AACH;IACE;;;;;;;;;;;;;;;;;;;;;;OAsBG;IACH,kBApBW,MAAM,SACN,MAAM,iBAqEhB;IA1CC,aAAgB;IAChB,aAAgB;IAChB,8BAGE;IAsCJ;;;;;;;;;;;;;;;;;OAiBG;IACH,sBAZa,OAAO,CAAC,IAAI,CAAC,GAAC,SAAS,CAuBnC;CACF;6BA5J4B,aAAa"}
+{"version":3,"file":"Server.d.mts","sourceRoot":"","sources":["../lib/Server.mjs"],"names":[],"mappings":";AAKA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA8CG;AACH;IACE;;;;;;;;;;;;;;;;;;;;;;OAsBG;IACH,kBApBW,MAAM,SACN,MAAM,iBAgEhB;IArCC,aAAgB;IAChB,aAAgB;IAChB,8BAGE;IAiCJ;;;;;;;;;;;;;;;;;OAiBG;IACH,sBAZa,OAAO,CAAC,IAAI,CAAC,GAAC,SAAS,CAuBnC;CACF;6BAvJ4B,aAAa"}

package/types/internal/decode.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"decode.d.mts","sourceRoot":"","sources":["../../lib/internal/decode.mjs"],"names":[],"mappings":";AAmBA,iFAWC;uBA9BsB,YAAY"}
+{"version":3,"file":"decode.d.mts","sourceRoot":"","sources":["../../lib/internal/decode.mjs"],"names":[],"mappings":";AAqBA,iFAWC;uBAhCsB,YAAY"}

package/types/osc.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"osc.d.mts","sourceRoot":"","sources":["../lib/osc.mjs"],"names":[],"mappings":"AA+MA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA6BG;AACH,sCAtBa,MAAM,CA4BlB;AA6CD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AACH,+BAzBW,MAAM,OAgChB;uBAlUsB,aAAa"}
+{"version":3,"file":"osc.d.mts","sourceRoot":"","sources":["../lib/osc.mjs"],"names":[],"mappings":"AAyOA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA6BG;AACH,sCAtBa,MAAM,CA4BlB;AA6CD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AACH,+BAzBW,MAAM,OAgChB;uBA5VsB,aAAa"}

package/dist/test/test-getPort.js

@@ -1,20 +0,0 @@
-'use strict';
-
-var tap = require('tap');
-var util = require('./util.js');
-var node_net = require('node:net');
-
-tap.test('getPort function returns an available port', async (t) => {
-  const port = await util.getPort();
-  t.plan(2);
-  t.type(port, 'number', 'getPort should return a number');
-
-  const server = node_net.createServer();
-  server.listen(port, () => {
-    t.pass('Port is usable');
-  });
-  server.on('close', () => {
-    t.pass('Server closed');
-  });
-  server.close();
-});

package/dist/test/util.js

@@ -1,34 +0,0 @@
-'use strict';
-
-var node_net = require('node:net');
-var promises = require('node:timers/promises');
-
-async function bootstrap(t) {
-  const port = await getPort();
-  t.context = {
-    port
-  };
-}
-
-async function getPort() {
-  const server = node_net.createServer();
-  server.unref();
-  
-  const port = await new Promise((resolve, reject) => {
-    server.on('error', reject);
-    server.listen(() => {
-      resolve(server.address().port);
-    });
-  });
-  
-  await server.close();
-  
-  // Allow the event loop to process and ensure port is fully released
-  // This prevents EACCES errors when immediately rebinding to the same port
-  await promises.setImmediate();
-  
-  return port;
-}
-
-exports.bootstrap = bootstrap;
-exports.getPort = getPort;

package/test/test-getPort.mjs

@@ -1,18 +0,0 @@
-import { test } from 'tap';
-import { getPort } from './util.mjs';
-import { createServer } from 'node:net';
-
-test('getPort function returns an available port', async (t) => {
-  const port = await getPort();
-  t.plan(2);
-  t.type(port, 'number', 'getPort should return a number');
-
-  const server = createServer();
-  server.listen(port, () => {
-    t.pass('Port is usable');
-  });
-  server.on('close', () => {
-    t.pass('Server closed');
-  });
-  server.close();
-});

package/test/util.mjs

@@ -1,34 +0,0 @@
-import { createServer } from 'node:net';
-import { setImmediate } from 'node:timers/promises';
-
-async function bootstrap(t) {
-  const port = await getPort();
-  t.context = {
-    port
-  };
-}
-
-async function getPort() {
-  const server = createServer();
-  server.unref();
-  
-  const port = await new Promise((resolve, reject) => {
-    server.on('error', reject);
-    server.listen(() => {
-      resolve(server.address().port);
-    });
-  });
-  
-  await server.close();
-  
-  // Allow the event loop to process and ensure port is fully released
-  // This prevents EACCES errors when immediately rebinding to the same port
-  await setImmediate();
-  
-  return port;
-}
-
-export {
-  bootstrap,
-  getPort
-};