node-osc 11.2.0 → 11.2.2

package/test/test-client.mjs

@@ -1,13 +1,12 @@
-import { beforeEach, test } from 'tap';
-import { bootstrap } from './util.mjs';
+import { once } from 'node:events';
+import { test } from 'tap';
 
 import { Server, Client } from 'node-osc';
 
-beforeEach(bootstrap);
-
-test('client: with array', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: with array', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -22,9 +21,33 @@ test('client: with array', (t) => {
   });
 });
 
-test('client: with string', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: array is not mutated when sent', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
+
+  t.plan(3);
+
+  const originalArray = ['/test', 0, 1, 'testing', true];
+  const expectedArray = ['/test', 0, 1, 'testing', true];
+
+  oscServer.on('message', (msg) => {
+    oscServer.close();
+    t.same(msg, ['/test', 0, 1, 'testing', true], 'We should receive expected payload');
+    // Verify the original array was not mutated
+    t.same(originalArray, expectedArray, 'Original array should not be mutated');
+  });
+
+  client.send(originalArray, (err) => {
+    t.error(err, 'there should be no error');
+    client.close();
+  });
+});
+
+test('client: with string', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -39,9 +62,10 @@ test('client: with string', (t) => {
   });
 });
 
-test('client: with Message object', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: with Message object', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -65,9 +89,10 @@ test('client: with Message object', (t) => {
   });
 });
 
-test('client: with Bundle object', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: with Bundle object', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -91,8 +116,8 @@ test('client: with Bundle object', (t) => {
   });
 });
 
-test('client: failure', (t) => {
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: failure', async (t) => {
+  const client = new Client('127.0.0.1', 9999);
 
   t.plan(2);
 
@@ -107,8 +132,8 @@ test('client: failure', (t) => {
   });
 });
 
-test('client: close with callback', (t) => {
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: close with callback', async (t) => {
+  const client = new Client('127.0.0.1', 9999);
 
   t.plan(1);
 
@@ -117,9 +142,10 @@ test('client: close with callback', (t) => {
   });
 });
 
-test('client: send bundle with non-numeric timetag', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send bundle with non-numeric timetag', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -146,9 +172,10 @@ test('client: send bundle with non-numeric timetag', (t) => {
   client.send(bundle);
 });
 
-test('client: send bundle with null timetag', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send bundle with null timetag', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -175,9 +202,10 @@ test('client: send bundle with null timetag', (t) => {
   client.send(bundle);
 });
 
-test('client: send message with float type arg', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send message with float type arg', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -196,9 +224,10 @@ test('client: send message with float type arg', (t) => {
   });
 });
 
-test('client: send message with blob type arg', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send message with blob type arg', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -217,9 +246,10 @@ test('client: send message with blob type arg', (t) => {
   });
 });
 
-test('client: send message with double type arg', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send message with double type arg', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 
@@ -238,9 +268,10 @@ test('client: send message with double type arg', (t) => {
   });
 });
 
-test('client: send message with midi type arg', (t) => {
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+test('client: send message with midi type arg', async (t) => {
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);
 

package/test/test-decode.mjs

@@ -106,3 +106,38 @@ test('decode: malformed structure with unexpected oscType', async (t) => {
   
   t.end();
 });
+
+test('decode: message without args defaults to empty array', (t) => {
+  const mockFromBuffer = () => ({
+    oscType: 'message',
+    address: '/test'
+  });
+
+  t.same(
+    decode(Buffer.from('test'), mockFromBuffer),
+    ['/test'],
+    'should default args to empty array'
+  );
+  t.end();
+});
+
+test('decode: bundle element must be message or bundle', (t) => {
+  const mockFromBuffer = () => ({
+    oscType: 'bundle',
+    elements: [
+      {
+        oscType: 'message',
+        address: '/ok',
+        args: []
+      },
+      {
+        oscType: 'nope'
+      }
+    ]
+  });
+
+  t.throws(() => {
+    decode(Buffer.from('test'), mockFromBuffer);
+  }, /Malformed Packet/, 'should throw for invalid bundle element');
+  t.end();
+});

package/test/test-e2e.mjs

@@ -1,10 +1,8 @@
-import { beforeEach, test } from 'tap';
-import { bootstrap } from './util.mjs';
+import { once } from 'node:events';
+import { test } from 'tap';
 
 import { Server, Client } from 'node-osc';
 
-beforeEach(bootstrap);
-
 function flaky() {
   return process.release.lts === 'Dubnium' && process.platform === 'win32';
 }
@@ -14,11 +12,12 @@ function skip(t) {
   t.end();
 }
 
-test('osc: argument message no callback', (t) => {
+test('osc: argument message no callback', async (t) => {
   if (flaky()) return skip(t);
 
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(1);
 
@@ -34,11 +33,12 @@ test('osc: argument message no callback', (t) => {
   client.send('/test', 1, 2, 'testing');
 });
 
-test('osc: client with callback and message as arguments', (t) => {
+test('osc: client with callback and message as arguments', async (t) => {
   if (flaky()) return skip(t);
 
-  const oscServer = new Server(t.context.port, '127.0.0.1');
-  const client = new Client('127.0.0.1', t.context.port);
+  const oscServer = new Server(0, '127.0.0.1');
+  await once(oscServer, 'listening');
+  const client = new Client('127.0.0.1', oscServer.port);
 
   t.plan(2);