nfo-cli 0.0.4-improve-prompting → 0.0.5

package/tests/tui/poll-permission.test.ts

@@ -1,222 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { pollPermissions } from '../../src/tui/poll-permission.js';
-import { makeTmpRepo, type TmpRepo } from '../helpers/tmp-repo.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { ensureOrchestraDir, writeState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { projectKeyFromPath } from '../../src/project-key.js';
-import { createDetachedSession, sessionName, killSession } from '../../src/tmux.js';
-import { execa } from 'execa';
-import type { OrchestraState } from '../../src/state.types.js';
-
-// A realistic claude permission-prompt block that satisfies all three detector signals:
-//   1. An intro line matching /allow\s+\S+/i
-//   2. A numbered choice starting with "1." (yes-line)
-//   3. A numbered choice starting with "3." containing "No" (no-line)
-const PERMISSION_PROMPT_TEXT = [
-  'Allow Bash to run `ls`?',
-  '',
-  ' 1. Yes',
-  ' 2. Yes, and don\'t ask again for Bash commands',
-  ' 3. No, and tell Claude what to do differently',
-  '',
-  '❯ 1',
-].join('\n');
-
-describe('pollPermissions', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const sessionsToKill: string[] = [];
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-
-  afterEach(async () => {
-    for (const s of sessionsToKill) {
-      try { await killSession(s); } catch { /* ignore */ }
-    }
-    sessionsToKill.length = 0;
-    for (const c of cleanups) { await c(); }
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  // Helper: build a minimal OrchestraState with a single musician fixture.
-  function makeStateWithMusician(
-    orchId: string,
-    projectPath: string,
-    musicianStatus: OrchestraState['musicians'][number]['status'],
-    windowId: string,
-  ): OrchestraState {
-    const base = makeInitialState({ orchestraId: orchId, projectPath, permissionLevel: 'supervised' });
-    base.musicians.push({
-      id: 'mus-001',
-      name: 'x',
-      task_summary: 't',
-      status: musicianStatus,
-      pending_permission: null,
-      tmux_window_id: windowId,
-      claude_session_id: null,
-      worktree_path: null,
-      branch: null,
-      spawned_at: '2026-05-29T10:00:00Z',
-      last_activity: '2026-05-29T10:00:00Z',
-    });
-    return base;
-  }
-
-  it('transitions working → awaiting_permission when pane shows a permission prompt', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-
-    const orchId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchId);
-
-    const sess = sessionName(orchId);
-    sessionsToKill.push(sess);
-    await createDetachedSession(sess, repo.path, 220, 50);
-
-    // Create a new window and capture its id.
-    const { stdout: winIdRaw } = await execa('tmux', [
-      'new-window', '-t', sess, '-n', 'mus-001-perm', '-c', repo.path, '-d',
-      '-P', '-F', '#{window_id}',
-    ]);
-    const winId = winIdRaw.trim();
-
-    // Write the permission-prompt text into the pane using printf (literal, no Enter needed).
-    await execa('tmux', ['send-keys', '-l', '-t', `${sess}:${winId}`, '--', PERMISSION_PROMPT_TEXT]);
-    // Give tmux time to render the output.
-    await new Promise((r) => { setTimeout(r, 250); });
-
-    const state = makeStateWithMusician(orchId, repo.path, 'working', winId);
-    await writeState(orchId, state);
-
-    const transitions = await pollPermissions(state);
-
-    expect(transitions).toHaveLength(1);
-    expect(transitions[0].musicianId).toBe('mus-001');
-    expect(transitions[0].newStatus).toBe('awaiting_permission');
-    expect(transitions[0].pendingPermission).not.toBeNull();
-    expect(transitions[0].pendingPermission!.startsWith('Bash')).toBe(true);
-  });
-
-  it('transitions awaiting_permission → working when pane is cleared', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-
-    const orchId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchId);
-
-    const sess = sessionName(orchId);
-    sessionsToKill.push(sess);
-    await createDetachedSession(sess, repo.path, 220, 50);
-
-    const { stdout: winIdRaw } = await execa('tmux', [
-      'new-window', '-t', sess, '-n', 'mus-001-clear', '-c', repo.path, '-d',
-      '-P', '-F', '#{window_id}',
-    ]);
-    const winId = winIdRaw.trim();
-
-    // Clear the pane so no permission-prompt signals are present.
-    await execa('tmux', ['send-keys', '-t', `${sess}:${winId}`, 'clear', 'Enter']);
-    await new Promise((r) => { setTimeout(r, 250); });
-
-    // Musician is currently marked awaiting_permission but pane is clean.
-    const state = makeStateWithMusician(orchId, repo.path, 'awaiting_permission', winId);
-    await writeState(orchId, state);
-
-    const transitions = await pollPermissions(state);
-
-    expect(transitions).toHaveLength(1);
-    expect(transitions[0].musicianId).toBe('mus-001');
-    expect(transitions[0].newStatus).toBe('working');
-    expect(transitions[0].pendingPermission).toBeNull();
-  });
-
-  it('emits no transition for a stopped musician', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-
-    const orchId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchId);
-
-    // No real session needed — stopped musicians are skipped before any I/O.
-    const state = makeStateWithMusician(orchId, repo.path, 'stopped', '@0');
-    await writeState(orchId, state);
-
-    const transitions = await pollPermissions(state);
-
-    expect(transitions).toHaveLength(0);
-  });
-
-  it('swallows errors for a non-existent window and emits no transition', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-
-    const orchId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchId);
-
-    // Musician points at a window id that will never exist.
-    const state = makeStateWithMusician(orchId, repo.path, 'working', '@9999');
-    await writeState(orchId, state);
-
-    let thrown = false;
-    let transitions: Awaited<ReturnType<typeof pollPermissions>> = [];
-    try {
-      transitions = await pollPermissions(state);
-    } catch {
-      thrown = true;
-    }
-
-    expect(thrown).toBe(false);
-    expect(transitions).toHaveLength(0);
-  });
-
-  it('emits no transition when state already matches (awaiting + prompt still visible)', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-
-    const orchId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchId);
-
-    const sess = sessionName(orchId);
-    sessionsToKill.push(sess);
-    await createDetachedSession(sess, repo.path, 220, 50);
-
-    const { stdout: winIdRaw } = await execa('tmux', [
-      'new-window', '-t', sess, '-n', 'mus-001-noop', '-c', repo.path, '-d',
-      '-P', '-F', '#{window_id}',
-    ]);
-    const winId = winIdRaw.trim();
-
-    // Write the prompt so the detector fires.
-    await execa('tmux', ['send-keys', '-l', '-t', `${sess}:${winId}`, '--', PERMISSION_PROMPT_TEXT]);
-    await new Promise((r) => { setTimeout(r, 250); });
-
-    // Musician is ALREADY marked awaiting_permission — no delta to emit.
-    const state = makeStateWithMusician(orchId, repo.path, 'awaiting_permission', winId);
-    await writeState(orchId, state);
-
-    const transitions = await pollPermissions(state);
-
-    expect(transitions).toHaveLength(0);
-  });
-});

package/tests/tui/status-icon.test.ts

@@ -1,27 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import { statusIcon, statusColor } from '../../src/tui/status-icon.js';
-import type { MusicianStatus } from '../../src/state.types.js';
-
-describe('statusIcon', () => {
-  it('maps each status to an icon', () => {
-    expect(statusIcon('working')).toBe('●');
-    expect(statusIcon('idle')).toBe('◐');
-    expect(statusIcon('awaiting_permission')).toBe('⚠');
-    expect(statusIcon('stopped')).toBe('○');
-  });
-});
-
-describe('statusColor', () => {
-  it('maps each status to an ink color name', () => {
-    const colors: Record<MusicianStatus, string> = {
-      working: statusColor('working'),
-      idle: statusColor('idle'),
-      awaiting_permission: statusColor('awaiting_permission'),
-      stopped: statusColor('stopped'),
-    };
-    expect(colors.working).toBe('green');
-    expect(colors.idle).toBe('yellow');
-    expect(colors.awaiting_permission).toBe('red');
-    expect(colors.stopped).toBe('gray');
-  });
-});

package/tests/tui/terminal-input.test.ts

@@ -1,113 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import type { Key } from 'ink';
-import {
-  toTerminalMouseScroll,
-  toTerminalInput,
-  toTerminalViewportCommand,
-} from '../../src/tui/terminal-input.js';
-
-function makeKey(overrides: Partial<Key> = {}): Key {
-  return {
-    upArrow: false,
-    downArrow: false,
-    leftArrow: false,
-    rightArrow: false,
-    pageDown: false,
-    pageUp: false,
-    home: false,
-    end: false,
-    return: false,
-    escape: false,
-    ctrl: false,
-    shift: false,
-    tab: false,
-    backspace: false,
-    delete: false,
-    meta: false,
-    super: false,
-    hyper: false,
-    capsLock: false,
-    numLock: false,
-    ...overrides,
-  };
-}
-
-describe('toTerminalInput', () => {
-  it('maps enter and arrows to terminal control sequences', () => {
-    expect(toTerminalInput('', makeKey({ return: true }))).toBe('\r');
-    expect(toTerminalInput('', makeKey({ upArrow: true }))).toBe('\x1b[A');
-    expect(toTerminalInput('', makeKey({ downArrow: true }))).toBe('\x1b[B');
-  });
-
-  it('maps modified enter variants to a literal newline', () => {
-    expect(toTerminalInput('\r', makeKey({ return: true, shift: true }))).toBe('\n');
-    expect(toTerminalInput('\r', makeKey({ return: true, meta: true }))).toBe('\n');
-  });
-
-  it('maps ctrl keys to control characters', () => {
-    expect(toTerminalInput('c', makeKey({ ctrl: true }))).toBe('\x03');
-    expect(toTerminalInput('l', makeKey({ ctrl: true }))).toBe('\x0c');
-  });
-
-  it('maps tab variants and delete sequences', () => {
-    expect(toTerminalInput('', makeKey({ tab: true }))).toBe('\t');
-    expect(toTerminalInput('', makeKey({ tab: true, shift: true }))).toBe('\x1b[Z');
-    expect(toTerminalInput('', makeKey({ delete: true }))).toBe('\x1b[3~');
-  });
-
-  it('passes through plain input', () => {
-    expect(toTerminalInput('hello', makeKey())).toBe('hello');
-  });
-});
-
-describe('toTerminalViewportCommand', () => {
-  it('maps shift+page keys to viewport scrolling', () => {
-    expect(toTerminalViewportCommand(makeKey({ shift: true, pageUp: true }))).toEqual({
-      kind: 'scroll-pages',
-      pageCount: -1,
-    });
-    expect(toTerminalViewportCommand(makeKey({ shift: true, pageDown: true }))).toEqual({
-      kind: 'scroll-pages',
-      pageCount: 1,
-    });
-  });
-
-  describe('toTerminalMouseScroll', () => {
-    it('maps SGR mouse wheel events to line scrolling', () => {
-      expect(toTerminalMouseScroll('[<64;12;8M')).toEqual({
-        button: 64,
-        lineCount: -3,
-        column: 12,
-        row: 8,
-        sequence: '\u001b[<64;12;8M',
-      });
-      expect(toTerminalMouseScroll('[<65;12;8M')).toEqual({
-        button: 65,
-        lineCount: 3,
-        column: 12,
-        row: 8,
-        sequence: '\u001b[<65;12;8M',
-      });
-    });
-
-    it('ignores non-wheel mouse sequences', () => {
-      expect(toTerminalMouseScroll('[<0;12;8M')).toBeNull();
-      expect(toTerminalMouseScroll('[<64;12;8m')).toBeNull();
-      expect(toTerminalMouseScroll('hello')).toBeNull();
-    });
-  });
-
-  it('maps shift+home/end to top and bottom jumps', () => {
-    expect(toTerminalViewportCommand(makeKey({ shift: true, home: true }))).toEqual({
-      kind: 'scroll-top',
-    });
-    expect(toTerminalViewportCommand(makeKey({ shift: true, end: true }))).toEqual({
-      kind: 'scroll-bottom',
-    });
-  });
-
-  it('ignores unmodified terminal navigation keys', () => {
-    expect(toTerminalViewportCommand(makeKey({ pageUp: true }))).toBeNull();
-    expect(toTerminalViewportCommand(makeKey({ end: true }))).toBeNull();
-  });
-});

package/tests/tui/watch-state.test.ts

@@ -1,54 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { watchOrchestraState } from '../../src/tui/watch-state.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { ensureOrchestraDir, writeState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { setOrchestratorSessionId } from '../../src/state-updaters.js';
-import type { OrchestraState } from '../../src/state.types.js';
-
-describe('watchOrchestraState', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const stops: Array<() => Promise<void>> = [];
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-  afterEach(async () => {
-    for (const stop of stops) { await stop(); }
-    stops.length = 0;
-    for (const c of cleanups) { await c(); }
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  it('emits the current state immediately and again on change', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-    await ensureOrchestraDir('orch-w');
-    await writeState('orch-w', makeInitialState({
-      orchestraId: 'orch-w', projectPath: '/tmp/x', permissionLevel: 'supervised',
-    }));
-
-    const seen: OrchestraState[] = [];
-    const stop = await watchOrchestraState('orch-w', (s) => { seen.push(s); });
-    stops.push(stop);
-
-    // initial emit
-    await waitFor(() => { return seen.length >= 1; });
-    expect(seen[0].orchestra_id).toBe('orch-w');
-
-    // mutate → expect another emit
-    await setOrchestratorSessionId('orch-w', 'sess-123');
-    await waitFor(() => { return seen.some((s) => { return s.orchestrator_session_id === 'sess-123'; }); }, 4000);
-    expect(seen.some((s) => { return s.orchestrator_session_id === 'sess-123'; })).toBe(true);
-  });
-});
-
-async function waitFor(pred: () => boolean, timeoutMs = 3000): Promise<void> {
-  const start = Date.now();
-  while (!pred()) {
-    if (Date.now() - start > timeoutMs) {
-      throw new Error('Timed out');
-    }
-    await new Promise((r) => { setTimeout(r, 25); });
-  }
-}

package/tests/worktree.test.ts

@@ -1,73 +0,0 @@
-import { describe, it, expect, afterEach } from 'vitest';
-import { execa } from 'execa';
-import { mkdtemp, rm } from 'node:fs/promises';
-import { existsSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { makeTmpRepo, type TmpRepo } from './helpers/tmp-repo.js';
-import { addWorktree, removeWorktree, worktreeExists } from '../src/worktree.js';
-
-describe('worktree wrapper', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const dirsToRemove: string[] = [];
-
-  afterEach(async () => {
-    for (const d of dirsToRemove) {
-      try { await rm(d, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-    dirsToRemove.length = 0;
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-  });
-
-  async function track(t: TmpRepo) {
-    cleanups.push(t.cleanup);
-    return t;
-  }
-
-  it('addWorktree creates a worktree on a new branch from HEAD', async () => {
-    const repo = await track(await makeTmpRepo());
-    const workArea = await mkdtemp(join(tmpdir(), 'nfo-wt-'));
-    dirsToRemove.push(workArea);
-    const path = join(workArea, 'mus-001');
-
-    await addWorktree({ repoRoot: repo.path, path, branch: 'nfo/mus-001' });
-
-    expect(existsSync(path)).toBe(true);
-    expect(await worktreeExists(repo.path, path)).toBe(true);
-  });
-
-  it('addWorktree honours baseRef', async () => {
-    const repo = await track(await makeTmpRepo());
-    await execa('git', ['commit', '--allow-empty', '-m', 'second'], { cwd: repo.path });
-    const { stdout: firstSha } = await execa('git', ['rev-parse', 'HEAD~1'], { cwd: repo.path });
-
-    const workArea = await mkdtemp(join(tmpdir(), 'nfo-wt-'));
-    dirsToRemove.push(workArea);
-    const path = join(workArea, 'mus-002');
-
-    await addWorktree({
-      repoRoot: repo.path,
-      path,
-      branch: 'nfo/mus-002',
-      baseRef: firstSha.trim(),
-    });
-
-    const { stdout: branchSha } = await execa('git', ['rev-parse', 'HEAD'], { cwd: path });
-    expect(branchSha.trim()).toBe(firstSha.trim());
-  });
-
-  it('removeWorktree removes the worktree dir and metadata', async () => {
-    const repo = await track(await makeTmpRepo());
-    const workArea = await mkdtemp(join(tmpdir(), 'nfo-wt-'));
-    dirsToRemove.push(workArea);
-    const path = join(workArea, 'mus-003');
-
-    await addWorktree({ repoRoot: repo.path, path, branch: 'nfo/mus-003' });
-    expect(await worktreeExists(repo.path, path)).toBe(true);
-
-    await removeWorktree({ repoRoot: repo.path, path });
-    expect(existsSync(path)).toBe(false);
-    expect(await worktreeExists(repo.path, path)).toBe(false);
-  });
-});

package/tsconfig.json

@@ -1,19 +0,0 @@
-{
-  "compilerOptions": {
-    "target": "ES2022",
-    "module": "ESNext",
-    "moduleResolution": "Bundler",
-    "outDir": "./dist",
-    "rootDir": "./src",
-    "strict": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true,
-    "resolveJsonModule": true,
-    "declaration": false,
-    "jsx": "react-jsx",
-    "sourceMap": true
-  },
-  "include": ["src/**/*"],
-  "exclude": ["node_modules", "dist", "tests"]
-}

package/vitest.config.ts

@@ -1,12 +0,0 @@
-import { defineConfig } from 'vitest/config';
-
-export default defineConfig({
-  test: {
-    include: ['tests/**/*.test.ts', 'tests/**/*.test.tsx'],
-    environment: 'node',
-    testTimeout: 10000,
-  },
-  esbuild: {
-    jsx: 'automatic',
-  },
-});