nfo-cli 0.0.4-improve-prompting → 0.0.5

package/src/tui/terminal-input.ts

@@ -1,136 +0,0 @@
-import type { Key } from 'ink';
-
-export type TerminalViewportCommand =
-  | { kind: 'scroll-pages'; pageCount: number }
-  | { kind: 'scroll-top' }
-  | { kind: 'scroll-bottom' };
-
-export interface TerminalMouseScroll {
-  button: number;
-  lineCount: number;
-  column: number;
-  row: number;
-  sequence: string;
-}
-
-const sgrMouseSequence =
-  /^(?:\u001b)?\[<(?<button>\d+);(?<column>\d+);(?<row>\d+)(?<suffix>[Mm])$/u;
-
-function toControlCharacter(input: string): string | null {
-  if (input.length !== 1) {
-    return null;
-  }
-
-  const code = input.toUpperCase().charCodeAt(0);
-  if (code >= 64 && code <= 95) {
-    return String.fromCharCode(code - 64);
-  }
-
-  return null;
-}
-
-export function toTerminalViewportCommand(
-  key: Key,
-): TerminalViewportCommand | null {
-  if (!key.shift) {
-    return null;
-  }
-  if (key.pageUp) {
-    return { kind: 'scroll-pages', pageCount: -1 };
-  }
-  if (key.pageDown) {
-    return { kind: 'scroll-pages', pageCount: 1 };
-  }
-  if (key.home) {
-    return { kind: 'scroll-top' };
-  }
-  if (key.end) {
-    return { kind: 'scroll-bottom' };
-  }
-
-  return null;
-}
-
-export function toTerminalMouseScroll(input: string): TerminalMouseScroll | null {
-  const match = sgrMouseSequence.exec(input);
-  if (!match?.groups) {
-    return null;
-  }
-
-  if (match.groups.suffix !== 'M') {
-    return null;
-  }
-
-  const button = Number(match.groups.button);
-  const column = Number(match.groups.column);
-  const row = Number(match.groups.row);
-  if (
-    !Number.isFinite(button)
-    || !Number.isFinite(column)
-    || !Number.isFinite(row)
-    || (button & 64) === 0
-  ) {
-    return null;
-  }
-
-  return {
-    button,
-    lineCount: (button & 1) === 0 ? -3 : 3,
-    column,
-    row,
-    sequence: `\u001b[<${button};${column};${row}${match.groups.suffix}`,
-  };
-}
-
-export function toTerminalInput(input: string, key: Key): string | null {
-  if (key.return) {
-    return key.shift || key.meta ? '\n' : '\r';
-  }
-  if (key.tab) {
-    return key.shift ? '\x1b[Z' : '\t';
-  }
-  if (key.backspace) {
-    return '\x7f';
-  }
-  if (key.delete) {
-    return '\x1b[3~';
-  }
-  if (key.escape) {
-    return '\x1b';
-  }
-  if (key.upArrow) {
-    return '\x1b[A';
-  }
-  if (key.downArrow) {
-    return '\x1b[B';
-  }
-  if (key.rightArrow) {
-    return '\x1b[C';
-  }
-  if (key.leftArrow) {
-    return '\x1b[D';
-  }
-  if (key.home) {
-    return '\x1b[H';
-  }
-  if (key.end) {
-    return '\x1b[F';
-  }
-  if (key.pageUp) {
-    return '\x1b[5~';
-  }
-  if (key.pageDown) {
-    return '\x1b[6~';
-  }
-  if (key.ctrl) {
-    return toControlCharacter(input);
-  }
-  if (key.meta && input.length > 0) {
-    return `\x1b${input}`;
-  }
-  if (input.length > 0) {
-    return input;
-  }
-
-  return null;
-}

package/src/tui/watch-state.ts

@@ -1,43 +0,0 @@
-import chokidar from 'chokidar';
-import { stateFile } from '../config.js';
-import { readState } from '../state.js';
-import type { OrchestraState } from '../state.types.js';
-
-export type StopWatching = () => Promise<void>;
-
-/**
- * Watch an orchestra's state.json and invoke `onChange` with the parsed state:
- * once immediately, then on every file change. A chokidar watcher handles the
- * common case; a 1s poll fallback covers filesystems without reliable inotify.
- * Reads that fail mid-write (partial JSON) are swallowed — the next event wins.
- */
-export async function watchOrchestraState(
-  orchestraId: string,
-  onChange: (state: OrchestraState) => void,
-): Promise<StopWatching> {
-  const file = stateFile(orchestraId);
-
-  async function emit(): Promise<void> {
-    try {
-      const state = await readState(orchestraId);
-      if (state) {
-        onChange(state);
-      }
-    } catch {
-      // partial write / transient read error — ignore, next tick re-reads
-    }
-  }
-
-  await emit();
-
-  const watcher = chokidar.watch(file, { ignoreInitial: true });
-  watcher.on('change', () => { void emit(); });
-  watcher.on('add', () => { void emit(); });
-
-  const poll = setInterval(() => { void emit(); }, 1000);
-
-  return async () => {
-    clearInterval(poll);
-    await watcher.close();
-  };
-}

package/src/worktree.ts

@@ -1,41 +0,0 @@
-import { execa } from 'execa';
-
-export interface AddWorktreeArgs {
-  repoRoot: string;
-  path: string;
-  branch: string;
-  baseRef?: string;
-}
-
-export async function addWorktree(args: AddWorktreeArgs): Promise<void> {
-  const cmdArgs = ['worktree', 'add', '-b', args.branch, args.path];
-  if (args.baseRef) {
-    cmdArgs.push(args.baseRef);
-  }
-  await execa('git', cmdArgs, { cwd: args.repoRoot });
-}
-
-export interface RemoveWorktreeArgs {
-  repoRoot: string;
-  path: string;
-  force?: boolean;
-}
-
-export async function removeWorktree(args: RemoveWorktreeArgs): Promise<void> {
-  const cmdArgs = ['worktree', 'remove'];
-  if (args.force) {
-    cmdArgs.push('--force');
-  }
-  cmdArgs.push(args.path);
-  await execa('git', cmdArgs, { cwd: args.repoRoot, reject: false });
-}
-
-export async function worktreeExists(repoRoot: string, path: string): Promise<boolean> {
-  const { stdout } = await execa('git', ['worktree', 'list', '--porcelain'], { cwd: repoRoot });
-  const lines = stdout.split('\n');
-  return lines.some((l) => { return l === `worktree ${path}`; });
-}
-
-export async function deleteBranch(repoRoot: string, branch: string): Promise<void> {
-  await execa('git', ['branch', '-D', branch], { cwd: repoRoot, reject: false });
-}

package/tests/claude-command.test.ts

@@ -1,30 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { buildClaudeCommand } from '../src/claude-command.js';
-
-describe('buildClaudeCommand', () => {
-  it('quotes paths and appends the initial prompt as a positional argument', () => {
-    const command = buildClaudeCommand({
-      flags: ['--permission-mode', 'acceptEdits'],
-      mcpConfigPath: '/tmp/with spaces/mcp-config.json',
-      promptFile: '/tmp/with spaces/musician-prompt.md',
-      model: 'haiku',
-      prompt: "fix the bug in it's startup path",
-    });
-
-    expect(command).toBe(
-      "'claude' '--permission-mode' 'acceptEdits' '--mcp-config' '/tmp/with spaces/mcp-config.json' '--append-system-prompt-file' '/tmp/with spaces/musician-prompt.md' '--model' 'haiku' 'fix the bug in it'\"'\"'s startup path'",
-    );
-  });
-
-  it('includes resume sessions without requiring a prompt', () => {
-    const command = buildClaudeCommand({
-      flags: [],
-      mcpConfigPath: '/tmp/mcp-config.json',
-      resumeSessionId: 'session-123',
-    });
-
-    expect(command).toBe(
-      "'claude' '--resume' 'session-123' '--mcp-config' '/tmp/mcp-config.json'",
-    );
-  });
-});

package/tests/claude-detect.test.ts

@@ -1,14 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import { detectClaude } from '../src/claude-detect.js';
-
-describe('detectClaude', () => {
-  it('returns a parsed version object when claude is installed', async () => {
-    const info = await detectClaude();
-    expect(info).toMatchObject({
-      version: expect.stringMatching(/^\d+\.\d+\.\d+$/),
-      major: expect.any(Number),
-      minor: expect.any(Number),
-      patch: expect.any(Number),
-    });
-  });
-});

package/tests/commands/attach.test.ts

@@ -1,60 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { execa } from 'execa';
-import { attachOrRestore } from '../../src/commands/attach.js';
-import { makeTmpRepo, type TmpRepo } from '../helpers/tmp-repo.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { ensureOrchestraDir, writeState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { projectKeyFromPath } from '../../src/project-key.js';
-import { createDetachedSession, killSession, sessionName } from '../../src/tmux.js';
-
-describe('attachOrRestore', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const sessionsToKill: string[] = [];
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-
-  afterEach(async () => {
-    for (const s of sessionsToKill) {
-      try { await killSession(s); } catch { /* ignore */ }
-    }
-    sessionsToKill.length = 0;
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  it('migrates a legacy split session to a dedicated dashboard window', async () => {
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const orchestraId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchestraId);
-    await writeState(orchestraId, makeInitialState({
-      orchestraId,
-      projectPath: repo.path,
-      permissionLevel: 'supervised',
-    }));
-
-    const name = sessionName(orchestraId);
-    sessionsToKill.push(name);
-    await createDetachedSession(name, repo.path);
-    await execa('tmux', ['split-window', '-h', '-t', `${name}:0`, '-c', repo.path]);
-
-    const result = await attachOrRestore(orchestraId, true);
-    expect(result.action).toBe('attached');
-
-    const { stdout: paneCount } = await execa('tmux', [
-      'list-panes', '-t', `${name}:0`, '-F', '#{pane_index}',
-    ]);
-    expect(paneCount.trim().split('\n').length).toBe(1);
-
-    const { stdout: windows } = await execa('tmux', [
-      'list-windows', '-t', name, '-F', '#{window_name}',
-    ]);
-    expect(windows).toContain('nfo-dashboard');
-  });
-});

package/tests/commands/kill.test.ts

@@ -1,66 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { killOrchestra } from '../../src/commands/kill.js';
-import { makeTmpRepo, type TmpRepo } from '../helpers/tmp-repo.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { ensureOrchestraDir, writeState, readState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { projectKeyFromPath } from '../../src/project-key.js';
-import { sessionExists, killSession, createDetachedSession, sessionName } from '../../src/tmux.js';
-import { existsSync, readdirSync } from 'node:fs';
-import { archiveDir } from '../../src/config.js';
-
-describe('killOrchestra', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const sessionsToKill: string[] = [];
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-
-  afterEach(async () => {
-    for (const s of sessionsToKill) {
-      try { await killSession(s); } catch { /* ignore */ }
-    }
-    sessionsToKill.length = 0;
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  it('throws when orchestra is unknown', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-    await expect(killOrchestra('does-not-exist', { yes: true })).rejects.toThrow(/Unknown orchestra/);
-  });
-
-  it('kills tmux session and archives state.json when -y', async () => {
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const orchestraId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchestraId);
-    await writeState(orchestraId, makeInitialState({
-      orchestraId,
-      projectPath: repo.path,
-      permissionLevel: 'supervised',
-    }));
-
-    const name = sessionName(orchestraId);
-    sessionsToKill.push(name);
-    await createDetachedSession(name, repo.path, 220, 50);
-
-    expect(await sessionExists(name)).toBe(true);
-
-    await killOrchestra(orchestraId, { yes: true });
-
-    expect(await sessionExists(name)).toBe(false);
-    // state.json gone (moved to archive/)
-    const reloaded = await readState(orchestraId);
-    expect(reloaded).toBeNull();
-    // archive/ has at least one state-<ts>.json
-    const archived = readdirSync(archiveDir(orchestraId));
-    expect(archived.some(f => /^state-\d+\.json$/.test(f))).toBe(true);
-  });
-});

package/tests/commands/launch.test.ts

@@ -1,75 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { existsSync, readFileSync } from 'node:fs';
-import { join } from 'node:path';
-import { createOrchestra } from '../../src/commands/launch.js';
-import { makeTmpRepo, type TmpRepo } from '../helpers/tmp-repo.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { readState } from '../../src/state.js';
-import { projectKeyFromPath } from '../../src/project-key.js';
-import { sessionExists, killSession, sessionName } from '../../src/tmux.js';
-import { orchestraDir } from '../../src/config.js';
-
-describe('launch in a repo with no prior orchestra', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const sessionsToKill: string[] = [];
-
-  beforeEach(() => {
-    process.env.NFO_HOME = '';
-  });
-
-  afterEach(async () => {
-    for (const s of sessionsToKill) {
-      try { await killSession(s); } catch { /* ignore */ }
-    }
-    sessionsToKill.length = 0;
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  it('creates an orchestra and a tmux session', async () => {
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-
-    const orchestraId = projectKeyFromPath(repo.path);
-    const result = await createOrchestra({
-      repoRoot: repo.path,
-      orchestraId,
-      permissionLevel: 'supervised',
-      dryRun: true,
-    });
-
-    expect(result.action).toBe('created');
-    expect(result.orchestraId).toBe(orchestraId);
-    sessionsToKill.push(sessionName(result.orchestraId));
-
-    const state = await readState(result.orchestraId);
-    expect(state).not.toBeNull();
-    expect(state!.project_path).toBe(repo.path);
-    expect(state!.permission_level).toBe('supervised');
-    expect(await sessionExists(sessionName(result.orchestraId))).toBe(true);
-
-    const mcpCfg = join(orchestraDir(result.orchestraId), 'mcp-config.json');
-    expect(existsSync(mcpCfg)).toBe(true);
-    const parsed = JSON.parse(readFileSync(mcpCfg, 'utf8'));
-    expect(parsed.mcpServers.nfo.command).toBe('nfo');
-    expect(parsed.mcpServers.nfo.args).toEqual(['mcp-server', '--orchestra-id', result.orchestraId]);
-
-    const { execa } = await import('execa');
-    const { stdout: paneCount } = await execa('tmux', [
-      'list-panes', '-t', `${sessionName(result.orchestraId)}:0`, '-F', '#{pane_index}',
-    ]);
-    expect(paneCount.trim().split('\n').length).toBe(1);
-    const { stdout: windows } = await execa('tmux', [
-      'list-windows', '-t', sessionName(result.orchestraId), '-F', '#{window_name}',
-    ]);
-    expect(windows).toContain('nfo-dashboard');
-    const { stdout: status } = await execa('tmux', [
-      'show-options', '-t', sessionName(result.orchestraId), 'status',
-    ]);
-    expect(status.trim()).toBe('status off');
-  });
-});

package/tests/commands/list.test.ts

@@ -1,47 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import { listOrchestras } from '../../src/commands/list.js';
-import { ensureOrchestraDir, writeState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-
-describe('listOrchestras', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-  afterEach(async () => {
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-  });
-
-  it('returns empty array when no orchestras exist', async () => {
-    const tmp = await makeTmpConfig();
-    cleanups.push(tmp.cleanup);
-    process.env.NFO_HOME = tmp.path;
-    expect(await listOrchestras()).toEqual([]);
-  });
-
-  it('lists all orchestras with summary info', async () => {
-    const tmp = await makeTmpConfig();
-    cleanups.push(tmp.cleanup);
-    process.env.NFO_HOME = tmp.path;
-
-    await ensureOrchestraDir('aaa-one');
-    await writeState('aaa-one', makeInitialState({
-      orchestraId: 'aaa-one',
-      projectPath: '/tmp/one',
-      permissionLevel: 'supervised',
-    }));
-    await ensureOrchestraDir('bbb-two');
-    await writeState('bbb-two', makeInitialState({
-      orchestraId: 'bbb-two',
-      projectPath: '/tmp/two',
-      permissionLevel: 'autonomous',
-    }));
-
-    const list = await listOrchestras();
-    expect(list).toHaveLength(2);
-    const ids = list.map(o => o.id).sort();
-    expect(ids).toEqual(['aaa-one', 'bbb-two']);
-  });
-});

package/tests/commands/notes.test.ts

@@ -1,53 +0,0 @@
-import { describe, it, expect, afterEach, beforeEach } from 'vitest';
-import { openNotes } from '../../src/commands/notes.js';
-import { makeTmpRepo, type TmpRepo } from '../helpers/tmp-repo.js';
-import { makeTmpConfig } from '../helpers/tmp-config.js';
-import { ensureOrchestraDir, writeState } from '../../src/state.js';
-import { makeInitialState } from '../../src/state.types.js';
-import { projectKeyFromPath } from '../../src/project-key.js';
-
-describe('openNotes', () => {
-  const cleanups: Array<() => Promise<void>> = [];
-  const originalEditor = process.env.EDITOR;
-
-  beforeEach(() => { process.env.NFO_HOME = ''; });
-
-  afterEach(async () => {
-    for (const c of cleanups) await c();
-    cleanups.length = 0;
-    delete process.env.NFO_HOME;
-    if (originalEditor === undefined) {
-      delete process.env.EDITOR;
-    } else {
-      process.env.EDITOR = originalEditor;
-    }
-  });
-
-  it('throws when orchestra is unknown', async () => {
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-    await expect(openNotes('nope-doesnt-exist')).rejects.toThrow(/Unknown orchestra/);
-  });
-
-  it('invokes $EDITOR with the notes directory path', async () => {
-    const repo: TmpRepo = await makeTmpRepo();
-    cleanups.push(repo.cleanup);
-    const cfg = await makeTmpConfig();
-    cleanups.push(cfg.cleanup);
-    process.env.NFO_HOME = cfg.path;
-    // Use `true` as EDITOR — it accepts any args and exits 0 with no side effects.
-    process.env.EDITOR = 'true';
-
-    const orchestraId = projectKeyFromPath(repo.path);
-    await ensureOrchestraDir(orchestraId);
-    await writeState(orchestraId, makeInitialState({
-      orchestraId,
-      projectPath: repo.path,
-      permissionLevel: 'supervised',
-    }));
-
-    // Should resolve without throwing — `true` consumes the arg and exits cleanly.
-    await expect(openNotes(orchestraId)).resolves.toBeUndefined();
-  });
-});