neo.mjs 6.17.2 → 6.18.1

package/src/manager/rpc/Message.mjs

@@ -74,8 +74,8 @@ class Message extends Base {
      */
     onMessageAjax(msg, api) {
         return new Promise((resolve, reject) => {
-            let me  = this,
-                url = api.url;
+            let me    = this,
+                {url} = api;
 
             me.register({
                 id           : me.messageId,
@@ -94,10 +94,10 @@ class Message extends Base {
                 me.endPointTimeouts.push(url);
 
                 setTimeout(() => {
-                    me.resolveBufferTimeout(url);
+                    me.resolveBufferTimeout(url)
                 }, me.requestBuffer)
             }
-        });
+        })
     }
 
     /**
@@ -109,27 +109,27 @@ class Message extends Base {
      */
     async onMessageWebsocket(msg, api) {
         let me         = this,
-            url        = api.url,
+            {url}      = api,
             connection = me.socketConnections[url];
 
         if (!connection) {
             let module = await import('../../data/connection/WebSocket.mjs');
 
-            me.socketConnections[url] = connection = Neo.create(module.default, {serverAddress: url});
+            me.socketConnections[url] = connection = Neo.create(module.default, {serverAddress: url})
         }
 
-        return await connection.promiseMessage(msg);
+        return await connection.promiseMessage(msg)
     }
 
     /**
      * @param {String} url
      */
     async resolveBufferTimeout(url) {
-        let me            = this,
-            itemIds       = [],
-            processItems  = me.find({transactionId: 0, url}),
-            requests      = [],
-            transactionId = me.transactionId,
+        let me              = this,
+            itemIds         = [],
+            processItems    = me.find({transactionId: 0, url}),
+            requests        = [],
+            {transactionId} = me,
             response;
 
         processItems.forEach(item => {
@@ -142,7 +142,7 @@ class Message extends Base {
                 method : item.method,
                 params : item.params,
                 service: item.service
-            });
+            })
         });
 
         NeoArray.remove(me.endPointTimeouts, url);
@@ -155,14 +155,12 @@ class Message extends Base {
             // todo: pass the item which is included inside the response object
             // todo: reject the Promise in case the item is missing
 
-            item.resolve();
+            item.resolve()
         });
 
         // todo: remove only the items which are included inside the response
-        me.remove(itemIds);
+        me.remove(itemIds)
     }
 }
 
-let instance = Neo.setupClass(Message);
-
-export default instance;
+export default Neo.setupClass(Message);

package/src/menu/List.mjs

@@ -116,7 +116,7 @@ class List extends BaseList {
      * @protected
      */
     afterSetItems(value, oldValue) {
-        let store = this.store;
+        let {store} = this;
 
         oldValue && store.clear(); // we can not use remove() here, since items are no records => often no id
         value    && store.add(value)
@@ -135,15 +135,15 @@ class List extends BaseList {
             if (me.isRoot) {
                 if (!value) {
                     me.focusTimeoutId = setTimeout(() => {
-                        me[me.floating ? 'unmount' : 'hideSubMenu']();
-                    }, 20);
+                        me[me.floating ? 'unmount' : 'hideSubMenu']()
+                    }, 20)
                 } else {
                     clearTimeout(me.focusTimeoutId);
-                    me.focusTimeoutId = null;
+                    me.focusTimeoutId = null
                 }
             } else {
                 // bubble the focus change upwards
-                me.parentMenu.menuFocus = value;
+                me.parentMenu.menuFocus = value
             }
         }
     }
@@ -179,17 +179,17 @@ class List extends BaseList {
      * @returns {Object|Object[]|String} Either a config object to assign to the item, a vdom cn array or a html string
      */
     createItemContent(record, index) {
-        let me      = this,
-            iconCls = record.iconCls,
-            id      = record[me.store.keyProperty],
-            vdomCn  = [{tag: 'span', cls: ['neo-content'], html: record[me.displayField]}];
+        let me        = this,
+            {iconCls} = record,
+            id        = record[me.store.keyProperty],
+            vdomCn    = [{tag: 'span', cls: ['neo-content'], html: record[me.displayField]}];
 
         if (iconCls && iconCls !== '') {
-            vdomCn.unshift({tag: 'i', cls: ['neo-menu-icon', 'neo-icon', iconCls], id: me.getIconId(id)});
+            vdomCn.unshift({tag: 'i', cls: ['neo-menu-icon', 'neo-icon', iconCls], id: me.getIconId(id)})
         }
 
         if (me.hasChildren(record)) {
-            vdomCn.push({tag: 'i', cls: ['neo-arrow-icon', 'neo-icon', 'fas fa-chevron-right'], id: me.getArrowIconId(id)});
+            vdomCn.push({tag: 'i', cls: ['neo-arrow-icon', 'neo-icon', 'fas fa-chevron-right'], id: me.getArrowIconId(id)})
         }
 
         return vdomCn
@@ -199,9 +199,9 @@ class List extends BaseList {
      *
      */
     destroy(...args) {
-        let me            = this,
-            activeSubMenu = me.activeSubMenu,
-            subMenuMap    = me.subMenuMap || {};
+        let me              = this,
+            {activeSubMenu} = me,
+            subMenuMap      = me.subMenuMap || {};
 
         activeSubMenu?.unmount();
 
@@ -284,7 +284,7 @@ class List extends BaseList {
             for (item of data.oldPath) {
                 if (item.id === parentId) {
                     insideParent = true;
-                    break;
+                    break
                 }
             }
         }
@@ -362,7 +362,7 @@ class List extends BaseList {
     showSubMenu(nodeId, record) {
         const
             me           = this,
-            store        = me.store,
+            {store}      = me,
             recordId     = record[store.keyProperty],
             subMenuMap   = me.subMenuMap || (me.subMenuMap = {}),
             subMenuMapId = me.getMenuMapId(recordId),

package/src/menu/Panel.mjs

@@ -52,7 +52,7 @@ class Panel extends BasePanel {
      * @protected
      */
     afterSetList(value, oldValue) {
-        this.add(value);
+        this.add(value)
     }
 
     /**
@@ -62,7 +62,7 @@ class Panel extends BasePanel {
      * @protected
      */
     afterSetListItems(value, oldValue) {
-        this.list.items = value;
+        this.list.items = value
     }
 
     /**
@@ -72,7 +72,7 @@ class Panel extends BasePanel {
      * @protected
      */
     afterSetSubMenuGap(value, oldValue) {
-        this.list.subMenuGap = value;
+        this.list.subMenuGap = value
     }
 
     /**
@@ -83,7 +83,7 @@ class Panel extends BasePanel {
      */
     beforeSetList(value, oldValue) {
         oldValue && oldValue.destroy();
-        return ClassSystemUtil.beforeSetInstance(value, List, this.listConfig);
+        return ClassSystemUtil.beforeSetInstance(value, List, this.listConfig)
     }
 }
 

package/src/model/Component.mjs

@@ -153,12 +153,14 @@ class Component extends Base {
      * @protected
      */
     beforeSetStores(value, oldValue) {
-        let controller = this.component.getController();
+        if (value) {
+            let controller = this.component.getController();
 
-        value && Object.entries(value).forEach(([key, storeValue]) => {
-            controller?.parseConfig(storeValue);
-            value[key] = ClassSystemUtil.beforeSetInstance(storeValue)
-        });
+            Object.entries(value).forEach(([key, storeValue]) => {
+                controller?.parseConfig(storeValue);
+                value[key] = ClassSystemUtil.beforeSetInstance(storeValue)
+            })
+        }
 
         return value
     }
@@ -319,7 +321,7 @@ class Component extends Base {
     getData(key, originModel=this) {
         let me      = this,
             data    = me.getDataScope(key),
-            scope   = data.scope,
+            {scope} = data,
             keyLeaf = data.key,
             parentModel;
 
@@ -347,7 +349,7 @@ class Component extends Base {
     getDataScope(key) {
         let me      = this,
             keyLeaf = key,
-            data    = me.data;
+            {data}  = me;
 
         if (key.includes('.')) {
             key     = key.split('.');
@@ -445,13 +447,13 @@ class Component extends Base {
      * @returns {Neo.model.Component|null}
      */
     getParent() {
-        let me = this;
+        let {parent} = this;
 
-        if (me.parent) {
-            return me.parent
+        if (parent) {
+            return parent
         }
 
-        return me.component.parent?.getModel() || null
+        return this.component.parent?.getModel() || null
     }
 
     /**
@@ -461,8 +463,8 @@ class Component extends Base {
      * @returns {Neo.data.Store}
      */
     getStore(key, originModel=this) {
-        let me     = this,
-            stores = me.stores,
+        let me       = this,
+            {stores} = me,
             parentModel;
 
         if (stores?.hasOwnProperty(key)) {
@@ -636,7 +638,7 @@ class Component extends Base {
      */
     resolveFormulas(data) {
         let me         = this,
-            formulas   = me.formulas,
+            {formulas} = me,
             initialRun = !data,
             affectFormula, bindObject, fn, key, result, value;
 

package/src/plugin/Base.mjs

@@ -1,6 +1,7 @@
 import CoreBase from '../core/Base.mjs';
 
 /**
+ * Abstract base class for plugin implementations.
  * Plugins are intended to get put into the plugins config of component.Base
  * to enhance them or add additional features
  * @class Neo.plugin.Base
@@ -14,6 +15,7 @@ class Base extends CoreBase {
          */
         className: 'Neo.plugin.Base',
         /**
+         * All plugin ntypes need to start with 'plugin-' to ensure that component.Base: getPlugin() can find them
          * @member {String} ntype='plugin'
          * @protected
          */

package/src/plugin/Popover.mjs

@@ -101,7 +101,7 @@ class Popover extends Base {
      */
     addPopover() {
         const me      = this,
-              owner   = me.owner,
+              {owner} = me,
               parent  = Neo.get(me.owner.parentId),
               popover = {
                   module: Container,

package/src/plugin/PrefixField.mjs

@@ -11,7 +11,6 @@ import Base from './Base.mjs';
  *         labelText: 'Credit Card',
  *         plugins  : [{
  *             module : PrefixPlugin, // import PrefixPlugin from '../../src/plugin/PrefixField.mjs';
- *             flag   : 'prefix',     // textField.getPlugins({flag: 'prefix'})
  *             pattern: 'dd/mm/yyyy',
  *             slots  : 'dmy',        // characters allowed to replace
  *             accept : /\d/          // either '[A-Z]' or regex or undefined
@@ -30,7 +29,6 @@ class PrefixField extends Base {
          * @protected
          */
         ntype: 'plugin-prefixfield',
-
         /**
          * Custom cls added to the inputEl
          * @member {String} inputCls='neo-prefixfield-input'
@@ -46,7 +44,6 @@ class PrefixField extends Base {
          * @member {String} ownerCls='neo-prefixfield'
          */
         ownerCls: 'neo-prefixfield',
-
         /**
          * regex to calculate if entered value is acceptable
          * Preset to numbers only
@@ -70,32 +67,32 @@ class PrefixField extends Base {
      * @member {Number} first
      * @protected
      */
-    first = null;
+    first = null
     /**
      * Array of numbers, which shows the previous entry point
      * @member {Array[]} prev
      * @protected
      */
-    prev = null;
+    prev = null
     /**
      * Position of the cursor inside input element
      * @member {Object} selection
      * @protected
      */
-    selection = null;
+    selection = null
 
     /**
      * State if selection should be updated
      * @member {Boolean} ignoreSelection
      * @protected
      */
-    ignoreSelection = false;
+    ignoreSelection = false
     /**
      * State if last entry was the back button
      * @member {Boolean} back
      * @protected
      */
-    back = false;
+    back = false
 
     /**
      * @param {Object} config
@@ -114,13 +111,13 @@ class PrefixField extends Base {
      */
     addCss() {
         const me      = this,
-              owner   = me.owner,
+              {owner} = me,
               inputEl = owner.getInputEl(),
               labelEl = owner.getLabelEl();
 
         owner    .addCls(me.ownerCls);
         inputEl.cls.push(me.inputCls);
-        labelEl.cls.push(me.labelCls);
+        labelEl.cls.push(me.labelCls)
     }
 
     /**
@@ -128,9 +125,8 @@ class PrefixField extends Base {
      * @protected
      */
     addListeners() {
-        let me    = this,
-            owner = me.owner,
-            listenerId;
+        let me      = this,
+            {owner} = me;
 
         owner.addDomListeners([
             {keydown        : me.onFieldKeyDown        , scope: me},
@@ -139,12 +135,9 @@ class PrefixField extends Base {
             {selectionchange: me.onFieldSelectionChange, scope: me}
         ]);
 
-        listenerId = me.owner.on('mounted', () => {
-            Neo.currentWorker.insertThemeFiles(owner.appName, owner.windowId, me.__proto__);
-
-            owner.un('mounted', listenerId);
-            listenerId = null;
-        })
+        me.owner.on('mounted', () => {
+            Neo.currentWorker.insertThemeFiles(owner.appName, owner.windowId, me.__proto__)
+        }, me, {once: true})
     }
 
 
@@ -155,7 +148,7 @@ class PrefixField extends Base {
      * @protected
      */
     afterSetAccept(value, oldValue) {
-        if (this.owner.value) this.format();
+        this.owner.value && this.format()
     }
 
     /**
@@ -166,7 +159,7 @@ class PrefixField extends Base {
      */
     afterSetPattern(value, oldValue) {
         this.owner.placeholderText = value;
-        this.recalcFirstAndPref();
+        this.recalcFirstAndPref()
     }
 
     /**
@@ -176,7 +169,7 @@ class PrefixField extends Base {
      * @protected
      */
     afterSetSlots(value, oldValue) {
-        this.recalcFirstAndPref();
+        this.recalcFirstAndPref()
     }
 
     /**
@@ -186,7 +179,7 @@ class PrefixField extends Base {
      * @protected
      */
     beforeSetSlots(value) {
-        return new Set(value || "_");
+        return new Set(value || "_")
     }
 
     /**
@@ -204,7 +197,7 @@ class PrefixField extends Base {
             input[0] === c || me.slots.has(c) ? input.shift() || c : c
         );
 
-        return input.slice(0, me.pattern.length);
+        return input.slice(0, me.pattern.length)
     }
 
     /**
@@ -212,25 +205,24 @@ class PrefixField extends Base {
      * @protected
      */
     format() {
-        const me        = this,
-              el        = me.owner,
-              selection = me.selection,
-              prev      = me.prev,
-              clean     = me.clean.bind(me);
-        let value = el.value || '';
+        let me                = this,
+            el                = me.owner,
+            {prev, selection} = me,
+            clean             = me.clean.bind(me),
+            value             = el.value || '';
 
         const [i, j] = [selection.start, selection.end].map(i => {
             i = me.clean(value.slice(0, i)).findIndex(c => me.slots.has(c));
-            return i < 0 ? prev[prev.length - 1] : me.back ? prev[i - 1] || me.first : i;
+            return i < 0 ? prev[prev.length - 1] : me.back ? prev[i - 1] || me.first : i
         });
 
         el.value = clean(value).join``;
-        this.ignoreSelection = true;
+        me.ignoreSelection = true;
 
         Neo.main.DomAccess.selectNode({id: el.getInputElId(), start: i, end: j});
-        this.ignoreSelection = false;
+        me.ignoreSelection = false;
 
-        this.back = false;
+        me.back = false
     }
 
     /**
@@ -240,10 +232,9 @@ class PrefixField extends Base {
      * @protected
      */
     onFieldBlur(data) {
-        const pattern = this.pattern,
-              el      = this.owner;
+        let {owner, pattern} = this;
 
-        return el.value === pattern && (el.value = "");
+        return owner.value === pattern && (owner.value = '')
     }
 
     /**
@@ -252,7 +243,7 @@ class PrefixField extends Base {
      * @protected
      */
     onFieldFocus(data) {
-        this.format();
+        this.format()
     }
 
     /**
@@ -261,7 +252,7 @@ class PrefixField extends Base {
      * @protected
      */
     onFieldKeyDown(data) {
-        this.back = (data.key === "Backspace");
+        this.back = data.key === "Backspace"
     }
 
     /**
@@ -275,11 +266,11 @@ class PrefixField extends Base {
 
         // Do not run, if ignore state or same start and end data
         if (this.ignoreSelection || (dSel.start === sel.start && dSel.end === sel.end)) {
-            return;
+            return
         }
 
         this.selection = dSel;
-        this.format();
+        this.format()
     }
 
     /**
@@ -287,16 +278,15 @@ class PrefixField extends Base {
      * @protected
      */
     recalcFirstAndPref() {
-        const me      = this,
-              pattern = me.pattern,
-              slots   = me.slots;
+        let me               = this,
+            {pattern, slots} = me;
 
         me.prev = (j => Array.from(pattern, (c, i) => slots.has(c) ? j = i + 1 : j))(0);
         me.first = [...pattern].findIndex(c => slots.has(c));
 
         me.selection = {start: me.first, end: me.first};
 
-        if (me.owner.value) me.format();
+        me.owner.value && me.format()
     }
 }