neo.mjs 6.17.2 → 6.18.1

package/src/form/field/ComboBox.mjs

@@ -154,7 +154,7 @@ class ComboBox extends Picker {
      */
     afterSetInputValue(value, oldValue) {
         super.afterSetInputValue(value, oldValue);
-        this.updateTypeAheadValue(value);
+        this.updateTypeAheadValue(value)
     }
 
     /**
@@ -245,9 +245,8 @@ class ComboBox extends Picker {
      * @protected
      */
     beforeSetStore(value, oldValue) {
-        const
-            me                          = this,
-            { valueField, displayField} = me;
+        let me                         = this,
+            {displayField, valueField} = me;
 
         oldValue?.destroy();
 
@@ -300,9 +299,8 @@ class ComboBox extends Picker {
      * @protected
      */
     beforeSetValue(value, oldValue) {
-        let me           = this,
-            displayField = me.displayField,
-            store        = me.store,
+        let me                    = this,
+            {displayField, store} = me,
             record;
 
         // getting a record, nothing to do
@@ -380,11 +378,9 @@ class ComboBox extends Picker {
      * @param {String|null} value The value to filter the picker by
      */
     doFilter(value) {
-        let me     = this,
-            store  = me.store,
-            filter = store.getFilter(me.displayField),
-            picker = me.picker,
-            record = me.value;
+        let me                      = this,
+            {picker, record, store} = me,
+            filter                  = store.getFilter(me.displayField);
 
         if (filter) {
             filter.value = value
@@ -395,9 +391,8 @@ class ComboBox extends Picker {
             me.showPicker();
 
             // List might not exist until the picker is created
-            const
-                { list }           = me,
-                { selectionModel } = list;
+            let {list }          = me,
+                {selectionModel} = list;
 
             // On show, set the active item to be the current selected record or the first
             if (record) {
@@ -474,7 +469,7 @@ class ComboBox extends Picker {
      * @returns {Object}
      */
     getRecord() {
-        let list      = this.list,
+        let {list}    = this,
             recordKey = list.selectionModel.getSelection()[0];
 
         return recordKey && this.store.get(list.getItemRecordId(recordKey)) || null
@@ -551,8 +546,7 @@ class ComboBox extends Picker {
      */
     async onListItemSelectionChange({ selection }) {
         if (selection?.length) {
-            const
-                me       = this,
+            let me       = this,
                 selected = selection[0],
                 record   = typeof selected === 'string' ? me.store.get(me.list.getItemRecordId(selected)) : selected;
 
@@ -592,15 +586,14 @@ class ComboBox extends Picker {
         let {activeIndex} = record;
 
         if (activeIndex >= 0) {
-            const
-                me      = this,
+            let me      = this,
                 {store} = me;
 
             me.activeRecord   = store.getAt(activeIndex);
             me.activeRecordId = me.activeRecord[store.keyProperty || model.keyProperty];
 
             // Update typeahead hint (which updates DOM), or update DOM
-            me.typeAhead ? me.updateTypeAheadValue(me.lastManualInput) : me.update();
+            me.typeAhead ? me.updateTypeAheadValue(me.lastManualInput) : me.update()
         }
     }
 
@@ -701,8 +694,7 @@ class ComboBox extends Picker {
      */
     updateTypeAhead(silent=false) {
         let me      = this,
-            inputEl = VDomUtil.findVdomChild(me.vdom, {flag: 'neo-real-input'}),
-            vdom    = me.vdom;
+            inputEl = VDomUtil.findVdomChild(me.vdom, {flag: 'neo-real-input'});
 
         if (me.typeAhead) {
             inputEl.parentNode.cn[inputEl.index] = {
@@ -719,7 +711,7 @@ class ComboBox extends Picker {
                 }, inputEl.vdom]
             }
         } else {
-            VDomUtil.replaceVdomChild(vdom, inputEl.parentNode.id, inputEl.vdom)
+            VDomUtil.replaceVdomChild(me.vdom, inputEl.parentNode.id, inputEl.vdom)
         }
 
         !silent && me.update()

package/src/form/field/Country.mjs

@@ -49,7 +49,7 @@ class Country extends ComboBox {
             return me.up().getReference(value)
         }
 
-        return value;
+        return value
     }
 }
 

package/src/form/field/Date.mjs

@@ -200,7 +200,7 @@ class DateField extends Picker {
      */
     hasContent() {
         if (this.labelPosition === 'inline') {
-            return true;
+            return true
         }
 
         return super.hasContent()
@@ -221,13 +221,12 @@ class DateField extends Picker {
      * @param {Object} opts
      */
     onDatePickerChange(opts) {
-        let me   = this,
-            vdom = me.vdom;
+        let me = this;
 
         me.clean = false;
 
         if (me.hidePickerOnSelect) {
-            VDomUtil.removeVdomChild(vdom, me.getPickerId());
+            VDomUtil.removeVdomChild(me.vdom, me.getPickerId());
 
             me.promiseUpdate().then(data => {
                 me.value = opts.value

package/src/form/field/Display.mjs

@@ -40,7 +40,7 @@ class Display extends Text {
         inputEl.readonly = 'readonly';
         inputEl.tabindex = '-1';
 
-        me.update();
+        me.update()
     }
 }
 

package/src/form/field/Email.mjs

@@ -42,12 +42,12 @@ class Email extends Text {
     validate(silent=true) {
         let me          = this,
             returnValue = super.validate(silent),
-            value       = me.value;
+            {value}     = me;
 
         if (returnValue) {
             if (value && !Email.emailRegex.test(value)) {
                 me._error = me.errorTextValidEmail;
-                returnValue = false;
+                returnValue = false
             }
         }
 

package/src/form/field/Number.mjs

@@ -105,12 +105,12 @@ class Number extends Text {
             style   = inputEl.style || {};
 
         if (value) {
-            delete style.pointerEvents;
+            delete style.pointerEvents
         } else {
-            style.pointerEvents = 'none';
+            style.pointerEvents = 'none'
         }
 
-        me.update();
+        me.update()
     }
 
     /**
@@ -121,7 +121,7 @@ class Number extends Text {
      */
     afterSetMaxValue(value, oldValue) {
         this.validate(); // silent
-        this.changeInputElKey('max', value);
+        this.changeInputElKey('max', value)
     }
 
     /**
@@ -132,7 +132,7 @@ class Number extends Text {
      */
     afterSetMinValue(value, oldValue) {
         this.validate(); // silent
-        this.changeInputElKey('min', value);
+        this.changeInputElKey('min', value)
     }
 
     /**
@@ -158,15 +158,15 @@ class Number extends Text {
             if (modulo !== 0) { // find the closest valid value
                 if (modulo / value > 0.5) {
                     if (val + value - modulo < me.maxValue) {
-                        me.value = val + value - modulo;
+                        me.value = val + value - modulo
                     } else if (val - modulo > me.minValue) {
-                        me.value = val - modulo;
+                        me.value = val - modulo
                     }
                 } else {
                     if (val - modulo > me.minValue) {
-                        me.value = val - modulo;
+                        me.value = val - modulo
                     } else if (val + value - modulo < me.maxValue) {
-                        me.value = val + value - modulo;
+                        me.value = val + value - modulo
                     }
                 }
             }
@@ -180,7 +180,7 @@ class Number extends Text {
      * @protected
      */
     afterSetTriggerPosition(value, oldValue) {
-        oldValue && this.updateTriggers();
+        oldValue && this.updateTriggers()
     }
 
     /**
@@ -190,8 +190,8 @@ class Number extends Text {
      * @protected
      */
     afterSetUseSpinButtons(value, oldValue) {
-        if (typeof oldValue === 'boolean') {
-            this.updateTriggers();
+        if (Neo.isBoolean(oldValue)) {
+            this.updateTriggers()
         }
     }
 
@@ -206,7 +206,7 @@ class Number extends Text {
             console.warn('input type number does not support maxLength. use maxValue instead.', this)
         }
 
-        return null;
+        return null
     }
 
     /**
@@ -220,7 +220,7 @@ class Number extends Text {
             console.warn('input type number does not support minLength. use minValue instead.', this)
         }
 
-        return null;
+        return null
     }
 
     /**
@@ -230,7 +230,7 @@ class Number extends Text {
      * @protected
      */
     beforeSetTriggerPosition(value, oldValue) {
-        return this.beforeSetEnumValue(value, oldValue, 'triggerPosition');
+        return this.beforeSetEnumValue(value, oldValue, 'triggerPosition')
     }
 
     /**
@@ -241,18 +241,18 @@ class Number extends Text {
      */
     beforeSetValue(value, oldValue) {
         if (value === null || value === '') {
-            return null;
+            return null
         }
 
         if (!Neo.isNumber(value)) {
-            value = +value;
+            value = +value
         }
 
         if (this.stepSizeDigits > 0) {
-            value = +value.toFixed(this.stepSizeDigits);
+            value = +value.toFixed(this.stepSizeDigits)
         }
 
-        return value;
+        return value
     }
 
     /**
@@ -271,25 +271,23 @@ class Number extends Text {
      * @returns {Boolean}
      */
     isValid() {
-        let me       = this,
-            maxValue = me.maxValue,
-            minValue = me.minValue,
-            value    = me.value,
-            isNumber = Neo.isNumber(value);
+        let me                          = this,
+            {maxValue, minValue, value} = me,
+            isNumber                    = Neo.isNumber(value);
 
         if (Neo.isNumber(maxValue) && isNumber && value > maxValue) {
-            return false;
+            return false
         }
 
         if (Neo.isNumber(minValue) && isNumber && value < minValue) {
-            return false;
+            return false
         }
 
         if (!me.fitsStepSize(value)) {
-            return false;
+            return false
         }
 
-        return super.isValid();
+        return super.isValid()
     }
 
     /**
@@ -297,7 +295,7 @@ class Number extends Text {
      */
     onConstructed() {
         this.updateTriggers();
-        super.onConstructed();
+        super.onConstructed()
     }
 
     /**
@@ -306,8 +304,8 @@ class Number extends Text {
      * @protected
      */
     onFocusLeave(data) {
-        let me    = this,
-            value = me.value;
+        let me      = this,
+            {value} = me;
 
         if (value !== null) {
             value = me.stepSizeDigits > 0 ? parseFloat(value) : parseInt(value);
@@ -315,9 +313,9 @@ class Number extends Text {
             value = Math.min(me.maxValue, value);
 
             if (me.value !== value) {
-                me.value = value;
+                me.value = value
             } else {
-                me.getInputEl().value = me.inputValueRenderer(value);
+                me.getInputEl().value = me.inputValueRenderer(value)
             }
         }
 
@@ -328,19 +326,19 @@ class Number extends Text {
      * @protected
      */
     onSpinButtonDownClick() {
-        let me       = this,
-            stepSize = me.stepSize,
-            oldValue = Neo.isNumber(me.value) ? me.value : me.minValue,
-            value    = (oldValue - stepSize) < me.minValue ? me.maxValue : (oldValue - stepSize);
+        let me         = this,
+            {stepSize} = me,
+            oldValue   = Neo.isNumber(me.value) ? me.value : me.minValue,
+            value      = (oldValue - stepSize) < me.minValue ? me.maxValue : (oldValue - stepSize);
 
         if (me.excludedValues) {
             while (me.excludedValues.includes(value)) {
-                value = Math.max(me.minValue, value - stepSize);
+                value = Math.max(me.minValue, value - stepSize)
             }
         }
 
         if (oldValue !== value) {
-            me.value = value;
+            me.value = value
         }
     }
 
@@ -348,19 +346,19 @@ class Number extends Text {
      * @protected
      */
     onSpinButtonUpClick() {
-        let me       = this,
-            stepSize = me.stepSize,
-            oldValue = Neo.isNumber(me.value) ? me.value : me.maxValue,
-            value    = (oldValue + stepSize) > me.maxValue ? me.minValue : (oldValue + stepSize);
+        let me         = this,
+            {stepSize} = me,
+            oldValue   = Neo.isNumber(me.value) ? me.value : me.maxValue,
+            value      = (oldValue + stepSize) > me.maxValue ? me.minValue : (oldValue + stepSize);
 
         if (me.excludedValues) {
             while (me.excludedValues.includes(value)) {
-                value = Math.min(me.maxValue, value + stepSize);
+                value = Math.min(me.maxValue, value + stepSize)
             }
         }
 
         if (oldValue !== value) {
-            me.value = value;
+            me.value = value
         }
     }
 
@@ -374,29 +372,29 @@ class Number extends Text {
         if (me.useSpinButtons) {
             if (me.triggerPosition === 'right') {
                 if (!me.hasTrigger('spinupdown')) {
-                    triggers.push(SpinUpDownTrigger);
+                    triggers.push(SpinUpDownTrigger)
                 }
 
                 me.removeTrigger('spindown', true, triggers);
-                me.removeTrigger('spinup', true, triggers);
+                me.removeTrigger('spinup', true, triggers)
             } else {
                 if (!me.hasTrigger('spindown')) {
-                    triggers.push(SpinDownTrigger);
+                    triggers.push(SpinDownTrigger)
                 }
 
                 if (!me.hasTrigger('spinup')) {
-                    triggers.push(SpinUpTrigger);
+                    triggers.push(SpinUpTrigger)
                 }
 
-                me.removeTrigger('spinupdown', true, triggers);
+                me.removeTrigger('spinupdown', true, triggers)
             }
         } else {
             me.removeTrigger('spindown', true, triggers);
             me.removeTrigger('spinup', true, triggers);
-            me.removeTrigger('spinupdown', true, triggers);
+            me.removeTrigger('spinupdown', true, triggers)
         }
 
-        me.triggers = triggers;
+        me.triggers = triggers
     }
 
     /**
@@ -406,11 +404,8 @@ class Number extends Text {
      */
     validate(silent=true) {
         let me          = this,
-            value       = me.value,
+            {maxValue, minValue, stepSize, value} = me,
             isNumber    = Neo.isNumber(value),
-            maxValue    = me.maxValue,
-            minValue    = me.minValue,
-            stepSize    = me.stepSize,
             returnValue = super.validate(silent),
             errorParam  = {maxValue, minValue, stepSize, value};
 

package/src/form/field/Picker.mjs

@@ -133,7 +133,7 @@ class Picker extends Text {
     createPicker() {
         const
             me              = this,
-            { pickerWidth } = me,
+            {pickerWidth}   = me,
             pickerComponent = me.createPickerComponent();
 
         me.picker =  Neo.create(Container, {
@@ -192,7 +192,7 @@ class Picker extends Text {
      * @param args
      */
     destroy(...args) {
-        let picker = this.picker;
+        let {picker} = this;
 
         if (picker?.hidden === false) {
             picker.unmount()

package/src/form/field/Radio.mjs

@@ -78,7 +78,7 @@ class Radio extends CheckBox {
 
         radios.forEach(item => {
             if (item.id !== me.id && item._checked) {
-                item.checked = false;
+                item.checked = false
             }
         })
     }

package/src/form/field/Range.mjs

@@ -79,7 +79,7 @@ class Range extends Number {
 
         inputEl.cls = ['neo-rangefield-input']; // replace neo-textfield-input
 
-        me.addValueToLabel();
+        me.addValueToLabel()
     }
 
     /**
@@ -93,22 +93,23 @@ class Range extends Number {
     }
 
     /**
-     * Override the NumberField implementation
-     * @param {Object} data
+     * Triggered after the value config got changed
+     * @param {Number} value
+     * @param {Number} oldValue
      */
     afterSetValue(value, oldValue) {
         this.addValueToLabel();
-        super.afterSetValue(value, oldValue);
+        super.afterSetValue(value, oldValue)
     }
 
     /**
      * Update label with value
      */
     addValueToLabel() {
-        const me = this;
+        let me = this;
 
         if (me.showResultInLabel) {
-            me.getLabelEl().innerHTML = `[${me.value}] ` + me.labelText;
+            me.getLabelEl().innerHTML = `[${me.value}] ` + me.labelText
         }
     }
 }

package/src/form/field/Text.mjs

@@ -383,9 +383,8 @@ class Text extends Base {
      * @protected
      */
     afterSetEditable(value, oldValue) {
-        const
-            me      = this,
-            { cls } = me;
+        let me      = this,
+            {cls} = me;
 
         NeoArray.toggle(cls, 'neo-not-editable', !value);
         me.cls = cls;
@@ -486,8 +485,8 @@ class Text extends Base {
      * @protected
      */
     afterSetInputValue(value, oldValue) {
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         me.getInputEl().value = me.containsFocus ? value : me.inputValueRenderer(value);
 
@@ -532,9 +531,8 @@ class Text extends Base {
      * @protected
      */
     afterSetLabelPosition(value, oldValue) {
-        let me   = this,
-            cls  = me.cls,
-            vdom = me.vdom,
+        let me          = this,
+            {cls, vdom} = me,
             centerBorderElCls, isEmpty;
 
         vdom.cn[1].removeDom = value !== 'top' ? true : !Boolean(me.subLabelText);
@@ -622,8 +620,7 @@ class Text extends Base {
     afterSetLabelWidth(value, oldValue) {
         if (this.labelPosition !== 'inline') {
             let me    = this,
-                vdom  = me.vdom,
-                label = vdom.cn[0];
+                label = me.vdom.cn[0];
 
             label.width = value;
             !me.hideLabel && me.updateInputWidth()
@@ -691,8 +688,8 @@ class Text extends Base {
      * @protected
      */
     afterSetPlaceholderText(value, oldValue) {
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         me.changeInputElKey('placeholder', value === '' ? null : value);
 
@@ -711,8 +708,8 @@ class Text extends Base {
      * @protected
      */
     afterSetReadOnly(value, oldValue) {
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         NeoArray[value ? 'add' : 'remove'](cls, 'neo-readonly');
         me.cls = cls;
@@ -771,8 +768,8 @@ class Text extends Base {
      * @protected
      */
     afterSetSubLabelCls(value, oldValue) {
-        let me  = this,
-            cls = me.vdom.cn[1].cls;
+        let me    = this,
+            {cls} = me.vdom.cn[1];
 
         NeoArray.remove(cls, oldValue);
         NeoArray.add(cls, value);
@@ -805,7 +802,7 @@ class Text extends Base {
      */
     afterSetTriggers(value, oldValue) {
         let me           = this,
-            vdom         = me.vdom,
+            {vdom}       = me,
             inputEl      = vdom.cn[2], // inputEl or inputWrapperEl
             preTriggers  = [],
             postTriggers = [],
@@ -1116,7 +1113,7 @@ class Text extends Base {
         let me          = this,
             ignoreLabel = me.hideLabel || me.labelPosition === 'bottom' || me.labelPosition === 'inline' || me.labelPosition === 'top',
             labelWidth  = ignoreLabel ? 0 : me.labelWidth,
-            width       = me.width;
+            {width}     = me;
 
         if (labelWidth && width) {
             return parseInt(width) - parseInt(labelWidth)
@@ -1298,8 +1295,8 @@ class Text extends Base {
     onFocusEnter(data) {
         super.onFocusEnter(data);
 
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         if (!me.readOnly) {
             NeoArray.add(cls, 'neo-focus');
@@ -1379,8 +1376,8 @@ class Text extends Base {
      * @param {Object} data
      */
     onMouseEnter(data) {
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         if (!me.readOnly) {
             NeoArray.add(cls, 'neo-hovered');
@@ -1392,8 +1389,8 @@ class Text extends Base {
      * @param {Object} data
      */
     onMouseLeave(data) {
-        let me  = this,
-            cls = me.cls;
+        let me    = this,
+            {cls} = me;
 
         if (!me.readOnly) {
             NeoArray.remove(cls, 'neo-hovered');
@@ -1479,8 +1476,8 @@ class Text extends Base {
      @param {Boolean} silent=false
      */
     updateError(value, silent = false) {
-        let me  = this,
-            cls = me.cls,
+        let me    = this,
+            {cls} = me,
             errorNode, errorWrapper;
 
         if (!(me.clean && !me.mounted)) {
@@ -1573,16 +1570,12 @@ class Text extends Base {
      * @returns {Boolean} Returns true in case there are no client-side errors
      */
     validate(silent=true) {
-        let me           = this,
-            maxLength    = me.maxLength,
-            minLength    = me.minLength,
-            required     = me.required,
-            returnValue  = true,
-            value        = me.value,
-            valueLength  = value?.toString().length,
-            inputPattern = me.inputPattern,
-            isEmpty      = value !== 0 && (!value || valueLength < 1),
-            errorParam   = {inputPattern, maxLength, minLength, valueLength},
+        let me          = this,
+            {inputPattern, maxLength, minLength, required, value} = me,
+            returnValue = true,
+            valueLength = value?.toString().length,
+            isEmpty     = value !== 0 && (!value || valueLength < 1),
+            errorParam  = {inputPattern, maxLength, minLength, valueLength},
             errorText;
 
         if (!silent) {