nccgs 2.0.0 → 2.1.1

package/.claude/nccgs/studio.json

@@ -35,7 +35,7 @@
       "standard": "opus",
       "deep": "opus",
       "leadership": "opus",
-      "review": "opus"
+      "review": "fable"
     }
   },
   "orchestration": {
@@ -51,7 +51,7 @@
       "modelClass": "lightweight",
       "maxTurns": 12,
       "defaultModel": "sonnet",
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-task-scout",
@@ -59,7 +59,7 @@
       "modelClass": "lightweight",
       "maxTurns": 10,
       "defaultModel": "sonnet",
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-creative-director",
@@ -67,7 +67,7 @@
       "modelClass": "leadership",
       "defaultModel": "opus",
       "maxTurns": 24,
-      "defaultEffort": "high"
+      "defaultEffort": "xhigh"
     },
     {
       "name": "nccgs-technical-director",
@@ -75,7 +75,7 @@
       "modelClass": "leadership",
       "defaultModel": "opus",
       "maxTurns": 24,
-      "defaultEffort": "high"
+      "defaultEffort": "xhigh"
     },
     {
       "name": "nccgs-producer",
@@ -83,7 +83,7 @@
       "modelClass": "leadership",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "high"
+      "defaultEffort": "xhigh"
     },
     {
       "name": "nccgs-game-design-lead",
@@ -91,7 +91,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-programming-lead",
@@ -99,7 +99,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-art-direction-lead",
@@ -107,7 +107,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-audio-direction-lead",
@@ -115,7 +115,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-narrative-lead",
@@ -123,7 +123,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-qa-lead",
@@ -131,7 +131,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-release-lead",
@@ -139,7 +139,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-localization-lead",
@@ -147,7 +147,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-game-designer",
@@ -155,7 +155,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 48,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-systems-designer",
@@ -163,7 +163,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-level-designer",
@@ -171,7 +171,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-economy-designer",
@@ -179,7 +179,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-ux-designer",
@@ -187,7 +187,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-accessibility-specialist",
@@ -195,7 +195,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-prototyper",
@@ -203,7 +203,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-technical-architect",
@@ -211,7 +211,7 @@
       "modelClass": "deep",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "high"
+      "defaultEffort": "xhigh"
     },
     {
       "name": "nccgs-gameplay-programmer",
@@ -219,7 +219,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 120,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-engine-programmer",
@@ -227,7 +227,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-ai-programmer",
@@ -235,7 +235,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-network-programmer",
@@ -243,7 +243,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 24,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-tools-programmer",
@@ -251,7 +251,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-ui-programmer",
@@ -259,7 +259,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-security-engineer",
@@ -267,7 +267,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-performance-analyst",
@@ -275,7 +275,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-technical-artist",
@@ -283,7 +283,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 20,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-sound-designer",
@@ -291,7 +291,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-writer",
@@ -299,7 +299,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-world-builder",
@@ -307,7 +307,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-analytics-engineer",
@@ -315,7 +315,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-live-ops-designer",
@@ -323,7 +323,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-qa-engineer",
@@ -331,7 +331,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-verification-engineer",
@@ -339,13 +339,13 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-adversarial-reviewer",
       "department": "quality",
       "modelClass": "review",
-      "defaultModel": "opus",
+      "defaultModel": "fable",
       "maxTurns": 200,
       "defaultEffort": "high"
     },
@@ -355,7 +355,7 @@
       "modelClass": "lightweight",
       "defaultModel": "sonnet",
       "maxTurns": 14,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-release-engineer",
@@ -363,7 +363,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 24,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-unity-implementer",
@@ -371,7 +371,7 @@
       "modelClass": "deep",
       "defaultModel": "opus",
       "maxTurns": 120,
-      "defaultEffort": "high"
+      "defaultEffort": "xhigh"
     },
     {
       "name": "nccgs-unity-systems-specialist",
@@ -379,7 +379,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-unity-ui-specialist",
@@ -387,7 +387,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-unity-rendering-specialist",
@@ -395,7 +395,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-unity-content-specialist",
@@ -403,7 +403,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 22,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-unity-build-specialist",
@@ -411,7 +411,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 24,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     },
     {
       "name": "nccgs-production-coordinator",
@@ -419,7 +419,7 @@
       "modelClass": "standard",
       "defaultModel": "opus",
       "maxTurns": 18,
-      "defaultEffort": "medium"
+      "defaultEffort": "high"
     }
   ],
   "effortProfiles": {
@@ -452,10 +452,10 @@
       "review": null
     },
     "claude-standalone": {
-      "lightweight": "medium",
-      "standard": "medium",
-      "deep": "high",
-      "leadership": "high",
+      "lightweight": "high",
+      "standard": "high",
+      "deep": "xhigh",
+      "leadership": "xhigh",
       "review": "high"
     }
   },
@@ -466,7 +466,7 @@
     },
     "claude-standalone": {
       "model": "opus",
-      "effortLevel": "medium"
+      "effortLevel": "high"
     }
   }
 }

package/.claude/nccgs/tools/autonomy.mjs

@@ -10,6 +10,19 @@ export function autonomyPolicy(project) {
   return { schemaVersion: 1, mode: value.mode };
 }
 
+// Fixed framework-owned launch prefix. It has exactly one fixed value and is the
+// only argv permitted before strict MCP isolation (see unity-transport.mjs).
+export function permissionModeArgs(mode) {
+  if (!["full", "guarded"].includes(mode)) throw new Error("Invalid NCCGS autonomy policy");
+  return ["--permission-mode", mode === "full" ? "bypassPermissions" : "default"];
+}
+
+// NCCGS owns session permission, root, settings and hook activation. --bare and
+// --safe-mode skip project hooks; --restricted ignores project settings and hooks
+// (installed CLI 2.1.316 help). The installed CLI documents no short aliases.
+// Retained recovery reuses this policy through unity-transport.mjs.
+export const conflictingLaunchOption = /^(?:--permission-mode|--dangerously-skip-permissions|--allow-dangerously-skip-permissions|--settings|--setting-sources|--worktree|--agent|--bare|--safe-mode|--restricted)(?:=|$)|^-w$/;
+
 // Session markers are workflow context, not a sandbox against arbitrary code.
 // Project configuration alone cannot activate Claude's native permission mode.
 export function fullTaskAutonomy(project, env = process.env) {

package/.claude/nccgs/tools/command-tokens.mjs

@@ -0,0 +1,22 @@
+export function commandTokens(command) {
+  if (typeof command !== "string") return null;
+  // Parse data quotes without interpreting a shell. Punctuation inside report
+  // text is data; composition/redirection/expansion outside quotes stays blocked.
+  const tokens = []; let token = "", quote = null, started = false;
+  for (let i = 0; i < command.length; i++) {
+    const c = command[i];
+    if (quote) {
+      if (c === quote) { quote = null; continue; }
+      if (quote === '"' && /[`$]/.test(c)) return null;
+      if (quote === '"' && c === "\\" && ['"', "\\"].includes(command[i + 1])) { token += command[++i]; continue; }
+      token += c; continue;
+    }
+    if (/[;&|<>`$\r\n]/.test(c)) return null;
+    if (c === '"' || c === "'") { quote = c; started = true; continue; }
+    if (/\s/.test(c)) { if (started) { tokens.push(token); token = ""; started = false; } continue; }
+    token += c; started = true;
+  }
+  if (quote) return null;
+  if (started) tokens.push(token);
+  return tokens;
+}

package/.claude/nccgs/tools/compile-policy.mjs

@@ -2,6 +2,7 @@ import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { json, loadPipeline } from "./policy.mjs";
+import { acquireInstallationLease } from "./installation-guard.mjs";
 
 export function renderAgent(template, route) {
   const match = template.match(/^---\r?\n([\s\S]*?)\r?\n---/);
@@ -98,6 +99,8 @@ export function generated(project) {
   return outputs;
 }
 export function compile(project, write = false) {
+  const lease = write ? acquireInstallationLease(project, "nccgs-policy") : null;
+  try {
   const differences = [];
   for (const [relative, content] of generated(project)) {
     const file = path.join(project, relative);
@@ -106,6 +109,7 @@ export function compile(project, write = false) {
     if (write) { fs.mkdirSync(path.dirname(file), { recursive: true }); fs.writeFileSync(file, content, "utf8"); }
   }
   return differences;
+  } finally { lease?.release(); }
 }
 if (process.argv[1] && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
   const project = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../../..");

package/.claude/nccgs/tools/configure-models.mjs

@@ -4,6 +4,7 @@ import { fileURLToPath } from "node:url";
 import { atomicJson, hash, json, profilePolicy, contained, resolveExecution } from "./policy.mjs";
 import { renderAgent } from "./compile-policy.mjs";
 import { fingerprintFile } from "./integrity.mjs";
+import { acquireInstallationLease } from "./installation-guard.mjs";
 
 const args = process.argv.slice(2);
 const values = flag => args.flatMap((arg, index) => {
@@ -12,6 +13,8 @@ const values = flag => args.flatMap((arg, index) => {
   return [args[index + 1]];
 });
 const project = path.resolve(values("--project")[0] || path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../../.."));
+const lease = acquireInstallationLease(project, "nccgs-agents");
+try {
 const explicit = values("--profile")[0];
 const { name, profile, pipeline } = profilePolicy(project, explicit);
 // Profile changes never change the execution policy or pending task obligations.
@@ -90,3 +93,4 @@ console.log(`NCCGS model profile '${name}' configured; ${writes.length} agent fi
 console.log("Model configuration records requested aliases/effort only. Runtime resolution requires Claude Code observation; execution policy and existing task approvals are unchanged.");
 if (legacyPolicy && !policyPattern.test(oldPolicy)) console.log("Legacy project policy preserved; model selection is stored in activation/install metadata until explicit policy migration.");
 for (const warning of warnings) console.warn(warning);
+} finally { lease.release(); }

package/.claude/nccgs/tools/hook-transport.mjs

@@ -0,0 +1,34 @@
+// Exact managed-hook identity across legacy shell and direct-executable forms.
+// Never identify a hook by the executable alone: many custom hooks use node.
+const scriptPattern = /^(?:\$\{CLAUDE_PROJECT_DIR\}\/)?(\.claude\/nccgs\/hooks\/[\w-]+\.mjs)$/;
+const phases = new Set(['pre', 'stop', 'start', 'failure']);
+
+export function managedHookKey(hook) {
+  if (!hook || hook.type !== 'command' || typeof hook.command !== 'string') return null;
+  let script, args;
+  if (Object.hasOwn(hook, 'args')) {
+    if (hook.command !== 'node' || !Array.isArray(hook.args) || !hook.args.every(x => typeof x === 'string')) return null;
+    [script, ...args] = hook.args;
+  } else {
+    const match = hook.command.match(/^node (?:"([^"\r\n]+)"|([^\s"'`$;&|<>]+))(?: (pre|stop|start|failure))?$/);
+    if (!match) return null;
+    script = match[1] ?? match[2];
+    args = match[3] ? [match[3]] : [];
+  }
+  const relative = typeof script === 'string' ? script.match(scriptPattern)?.[1] : null;
+  if (!relative || args.length > 1 || args.some(x => !phases.has(x))) return null;
+  return JSON.stringify([relative, ...args]);
+}
+
+export function requiredHookPresent(actual, expected) {
+  return actual && actual.type === expected.type && actual.command === expected.command
+    && JSON.stringify(actual.args) === JSON.stringify(expected.args)
+    && actual.onFailure === expected.onFailure
+    && actual.if === undefined && actual.once !== true && actual.async !== true
+    && (actual.timeout === undefined || actual.timeout >= expected.timeout);
+}
+
+export function referencesNccgsHook(hook) {
+  return [hook?.command, ...(Array.isArray(hook?.args) ? hook.args : [])]
+    .some(x => typeof x === 'string' && /(?:^|[\\/])\.claude[\\/]nccgs[\\/]/i.test(x));
+}

package/.claude/nccgs/tools/installation-guard.mjs

@@ -0,0 +1,55 @@
+import fs from "node:fs";
+import crypto from "node:crypto";
+import { containedPath } from "./paths.mjs";
+import { acquireLock, ownerState } from "./process-lock.mjs";
+
+const unverifiedAdmission = cause => new Error("NCCGS installation admission is busy or unverified; the lock may be changing or unreadable. Retry after other work finishes; inspect permissions or retained lock records if it persists.", { cause });
+
+export function assertInstallationAvailable(project, ownToken = null) {
+  for (const relative of [".nccgs/uninstall.lock", ".nccgs/uninstall.lock.recovery"]) {
+    const lock = containedPath(project, relative);
+    if (fs.existsSync(lock)) {
+      let record;
+      try {
+        record = JSON.parse(fs.readFileSync(lock, "utf8"));
+        if (!record || typeof record !== "object" || Array.isArray(record)) throw new Error("Invalid lock record");
+      } catch (error) { throw unverifiedAdmission(error); }
+      if (relative === ".nccgs/uninstall.lock" && ownToken && record.token === ownToken) continue;
+      if (ownerState(record) !== "dead")
+        throw new Error(record.operation === "installation-admission"
+          ? "NCCGS installation admission is busy or unverified; another launch or configuration is being admitted. Retry after it finishes."
+          : "NCCGS uninstall is active or unverified; wait for it to finish before starting other work.");
+    }
+  }
+  const directory = containedPath(project, ".nccgs/uninstall");
+  if (!fs.existsSync(directory)) return;
+  for (const entry of fs.readdirSync(directory, { withFileTypes: true })) {
+    const folder = containedPath(project, `.nccgs/uninstall/${entry.name}`);
+    if (!fs.statSync(folder).isDirectory()) continue;
+    const file = containedPath(project, `.nccgs/uninstall/${entry.name}/manifest.json`);
+    if (!fs.existsSync(file)) continue;
+    const manifest = JSON.parse(fs.readFileSync(file, "utf8"));
+    if (!["completed", "restored", "cancelled"].includes(manifest.status))
+      throw new Error(`Interrupted uninstall ${entry.name}; inspect its backup and use uninstall --rollback before starting other work.`);
+  }
+}
+
+// Serialize admission with uninstall/rollback. No new cooperating writer can
+// leave a transient lease during apply/restore; the session lease then protects
+// the entire operation after this short gate is released. Nested configurators
+// may register their own leases without holding the gate for their lifetime.
+export function acquireInstallationLease(project, operation) {
+  assertInstallationAvailable(project);
+  let gate;
+  try { gate = acquireLock(containedPath(project, ".nccgs/uninstall.lock"), { operation: "installation-admission" }); }
+  catch (error) {
+    // A competing admission may have arrived after the first check. Explain the
+    // current holder without retrying, taking over, or changing its lease.
+    assertInstallationAvailable(project);
+    throw unverifiedAdmission(error);
+  }
+  try {
+    assertInstallationAvailable(project, gate.record.token);
+    return acquireLock(containedPath(project, `.nccgs/sessions/${crypto.randomUUID()}.lock`), { operation });
+  } finally { gate.release(); }
+}

package/.claude/nccgs/tools/native-completion.mjs

@@ -1,5 +1,13 @@
 import { hash } from "./policy.mjs";
 
+// This provider-designated block is an inventory, not an incomplete-run notice.
+// Match the entire block and a bounded identifier list; unknown mixed text must
+// continue to fail closed. Never recognize this marker in model-authored prose.
+const toolSummary = /^\s*<tools-used-before-summary>[A-Za-z][A-Za-z0-9_.:-]*(?:\s*,\s*[A-Za-z][A-Za-z0-9_.:-]*)*<\/tools-used-before-summary>\s*$/;
+const informationalNote = block => block?.type === "text"
+  && typeof block.text === "string" && block.text.length <= 4096
+  && toolSummary.test(block.text);
+
 // The native harness reports an ended invocation as "completed" even when its
 // worker hit maxTurns. Inspect only harness-designated blocks, never the model's
 // prose. Store a diagnosis/hash, not prompts or arbitrary tool-result content.
@@ -15,7 +23,8 @@ export function nativeCompletion(response) {
   const limit = noteText.match(/\bthis agent stopped at its (\d+)-turn limit before finishing\b/i);
   // A previously unseen harness advisory needs reconciliation; it cannot silently
   // certify completion. Text outside these provider-designated blocks is ignored.
-  const reason = limit ? "turn-limit" : notes.length ? "unrecognized-harness-notice" : null;
+  const reason = limit ? "turn-limit"
+    : notes.length && !notes.every(informationalNote) ? "unrecognized-harness-notice" : null;
   return { reportedStatus, status: reason ? "failed" : reportedStatus, reason,
     turnLimit: limit ? Number(limit[1]) : null, noteHash: notes.length ? hash(noteText) : null };
 }

package/.claude/nccgs/tools/returned-handoff.mjs

@@ -1,6 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { artifact, contained } from "./policy.mjs";
+import { nativeCompletion } from "./native-completion.mjs";
 
 // Opt-in transport for read-only workers whose native client returns reports as
 // text. Copy the sole model text block verbatim; never synthesize a verdict,
@@ -15,9 +16,17 @@ export function captureReturnedHandoff(project, dispatch, input, completion, cur
       || !dispatch.agentId || dispatch.agentId !== response?.agentId
       || dispatch.agent !== input.tool_input?.subagent_type || dispatch.snapshot !== currentSnapshot)
     return reject("identity-or-snapshot-mismatch");
-  if (completion?.status !== "completed" || completion.reason || response?.harnessNoteCount || response?.harnessTailCount)
+  // Preserve an upstream failure and independently classify the actual response.
+  // A caller-supplied completion cannot certify unknown or incomplete metadata.
+  if (completion?.status !== "completed" || completion.reason)
     return reject("native-incomplete");
-  const blocks = response?.content;
+  const actual = nativeCompletion(response);
+  if (actual.status !== "completed" || actual.reason) return reject("native-incomplete");
+  // Classification validates every designated note and both counts. Strip only
+  // those blocks; model text, including lookalike tags, remains byte-for-byte.
+  const all = response.content;
+  const leading = response.harnessNoteCount ?? 0, tail = response.harnessTailCount ?? 0;
+  const blocks = Array.isArray(all) ? all.slice(leading, all.length - tail) : null;
   if (!Array.isArray(blocks) || blocks.length !== 1 || blocks[0]?.type !== "text"
       || typeof blocks[0].text !== "string" || !blocks[0].text.trim()
       || Buffer.byteLength(blocks[0].text, "utf8") > 262144)