nativescript 9.1.0-alpha.15 → 9.1.0-alpha.16

package/lib/services/platform-environment-requirements.js

@@ -7,13 +7,12 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PlatformEnvironmentRequirements = void 0;
+const constants_1 = require("../constants");
 const helpers_1 = require("../common/helpers");
 const os_1 = require("os");
 const yok_1 = require("../common/yok");
 class PlatformEnvironmentRequirements {
-    constructor($doctorService, $errors, $analyticsService, 
-    // @ts-ignore - required by the hook helper!
-    $injector) {
+    constructor($doctorService, $errors, $analyticsService, $injector) {
         this.$doctorService = $doctorService;
         this.$errors = $errors;
         this.$analyticsService = $analyticsService;
@@ -24,7 +23,7 @@ class PlatformEnvironmentRequirements {
         const selectedOption = null;
         if (process.env.NS_SKIP_ENV_CHECK) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
+                action: constants_1.TrackActionNames.CheckEnvironmentRequirements,
                 additionalData: "Skipped: NS_SKIP_ENV_CHECK is set",
             });
             return {
@@ -39,9 +38,8 @@ class PlatformEnvironmentRequirements {
             forceCheck: input.forceCheck,
         });
         if (!canExecute) {
-            // if (!isInteractive()) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Environment Requirements" /* TrackActionNames.CheckEnvironmentRequirements */,
+                action: constants_1.TrackActionNames.CheckEnvironmentRequirements,
                 additionalData: "Non-interactive terminal, unable to execute local builds.",
             });
             this.fail(this.getNonInteractiveConsoleMessage(platform));
@@ -61,7 +59,6 @@ class PlatformEnvironmentRequirements {
         ].join(os_1.EOL);
     }
     getEnvVerificationMessage(platform) {
-        // map process.platform to OS name used in docs
         const os = {
             linux: "linux",
             win32: "windows",
@@ -80,4 +77,3 @@ __decorate([
     (0, helpers_1.hook)("checkEnvironment")
 ], PlatformEnvironmentRequirements.prototype, "checkEnvironmentRequirements", null);
 yok_1.injector.register("platformEnvironmentRequirements", PlatformEnvironmentRequirements);
-//# sourceMappingURL=platform-environment-requirements.js.map

package/lib/services/platform-project-service-base.js

@@ -30,4 +30,3 @@ class PlatformProjectServiceBase extends events_1.EventEmitter {
     }
 }
 exports.PlatformProjectServiceBase = PlatformProjectServiceBase;
-//# sourceMappingURL=platform-project-service-base.js.map

package/lib/services/platforms-data-service.js

@@ -29,4 +29,3 @@ class PlatformsDataService {
 }
 exports.PlatformsDataService = PlatformsDataService;
 yok_1.injector.register("platformsDataService", PlatformsDataService);
-//# sourceMappingURL=platforms-data-service.js.map

package/lib/services/plugins-service.js

@@ -54,7 +54,6 @@ class PluginsService {
         const realNpmPackageJson = this.$fs.readJson(pathToRealNpmPackageJson);
         if (realNpmPackageJson.nativescript) {
             const pluginData = this.convertToPluginData(realNpmPackageJson, projectData.projectDir);
-            // Validate
             const action = async (pluginDestinationPath, platform, platformData) => {
                 this.isPluginDataValidForPlatform(pluginData, platform, projectData);
             };
@@ -140,9 +139,6 @@ class PluginsService {
                 paths: [projectData.projectDir],
             });
             if (pathToPackage) {
-                // return false if the dependency is installed - we'll filter out boolean values
-                // and end up with an array of dep names that are not installed if we end up
-                // inside the catch block.
                 return false;
             }
             this.$logger.trace(`${dep} is not installed, or couldn't be found`);
@@ -175,9 +171,6 @@ class PluginsService {
         return productionPlugins
             .map((plugin) => this.convertToPluginData(plugin, projectData.projectDir))
             .filter((item, idx, self) => {
-            // Filter out duplicates to speed up build times by not building the same dependency
-            // multiple times. One possible downside is that if there are different versions
-            // of the same native dependency only the first one in the array will be built
             return self.findIndex((p) => p.name === item.name) === idx;
         });
     }
@@ -209,11 +202,9 @@ class PluginsService {
         const dependenciesGroupedByName = _.groupBy(productionDependencies, (p) => p.name);
         _.each(dependenciesGroupedByName, (dependencyOccurrences, dependencyName) => {
             if (dependencyOccurrences.length > 1) {
-                // the dependency exists multiple times in node_modules
                 const dependencyOccurrencesGroupedByVersion = _.groupBy(dependencyOccurrences, (g) => g.version);
                 const versions = _.keys(dependencyOccurrencesGroupedByVersion);
                 if (versions.length === 1) {
-                    // all dependencies with this name have the same version
                     this.$logger.trace(`Detected same versions (${_.first(versions)}) of the ${dependencyName} installed at locations: ${_.map(dependencyOccurrences, (d) => d.directory).join(", ")}`);
                 }
                 else {
@@ -243,11 +234,9 @@ class PluginsService {
             const dependenciesGroupedByFrameworkName = _.groupBy(dependenciesWithFrameworks, (d) => d.frameworkName);
             _.each(dependenciesGroupedByFrameworkName, (dependencyOccurrences, frameworkName) => {
                 if (dependencyOccurrences.length > 1) {
-                    // A framework exists multiple times in node_modules
                     const groupedByName = _.groupBy(dependencyOccurrences, (d) => d.name);
                     const pluginsNames = _.keys(groupedByName);
                     if (pluginsNames.length > 1) {
-                        // fail - the same framework is installed by different dependencies.
                         const locations = dependencyOccurrences.map((d) => d.frameworkLocation);
                         let msg = `Detected the framework ${frameworkName} is installed from multiple plugins at locations:\n${locations.join("\n")}\n`;
                         msg += this.getHelpMessage(projectDir);
@@ -257,7 +246,6 @@ class PluginsService {
                     const dependencyOccurrencesGroupedByVersion = _.groupBy(dependencyOccurrences, (g) => g.version);
                     const versions = _.keys(dependencyOccurrencesGroupedByVersion);
                     if (versions.length === 1) {
-                        // all dependencies with this name have the same version
                         this.$logger.warn(`Detected the framework ${frameworkName} is installed multiple times from the same versions of plugin (${_.first(versions)}) at locations: ${_.map(dependencyOccurrences, (d) => d.directory).join(", ")}`);
                         const selectedPackage = _.minBy(dependencyOccurrences, (d) => d.depth);
                         this.$logger.info(color_1.color.green(`CLI will use only the native code from '${selectedPackage.directory}'.`));
@@ -309,7 +297,7 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
             pluginData.isPlugin = !!cacheData.nativescript;
             pluginData.pluginPlatformsFolderPath = (platform) => {
                 if (this.$mobileHelper.isvisionOSPlatform(platform)) {
-                    platform = "ios" /* constants.PlatformTypes.ios */;
+                    platform = constants.PlatformTypes.ios;
                 }
                 return path.join(pluginData.fullPath, "platforms", platform.toLowerCase());
             };
@@ -367,7 +355,6 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
         return _.keys(require(packageJsonFilePath).dependencies);
     }
     getNodeModuleData(module, projectDir) {
-        // module can be  modulePath or moduleName
         if (!this.$fs.exists(module) || path.basename(module) !== "package.json") {
             const resolvedPath = this.getPackageJsonFilePathForModule(module, projectDir);
             if (!resolvedPath) {
@@ -404,7 +391,7 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
         return this.parseNpmCommandResult(npmCommandArguments);
     }
     parseNpmCommandResult(npmCommandResult) {
-        return npmCommandResult.split("@")[0]; // returns plugin name
+        return npmCommandResult.split("@")[0];
     }
     async executeForAllInstalledPlatforms(action, projectData) {
         const availablePlatforms = this.$mobileHelper.platformNames.map((p) => p.toLowerCase());
@@ -419,8 +406,6 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
     }
     getInstalledFrameworkVersion(platform, projectData) {
         const runtimePackage = this.$projectDataService.getRuntimePackage(projectData.projectDir, platform);
-        // const platformData = this.$platformsDataService.getPlatformData(platform, projectData);
-        // const frameworkData = this.$projectDataService.getNSValue(projectData.projectDir, platformData.frameworkPackageName);
         return runtimePackage.version;
     }
     isPluginDataValidForPlatform(pluginData, platform, projectData) {
@@ -450,7 +435,6 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
     }
     getAllPluginsNativeHashes(pathToPluginsBuildFile) {
         if (this.$options.hostProjectPath) {
-            // TODO: force rebuild plugins for now until we decide where to put .ns-plugins-build-data.json when embedding
             return {};
         }
         let data = {};
@@ -461,7 +445,6 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
     }
     setPluginNativeHashes(opts) {
         if (this.$options.hostProjectPath) {
-            // TODO: force rebuild plugins for now until we decide where to put .ns-plugins-build-data.json when embedding
             return;
         }
         opts.allPluginsNativeHashes[opts.pluginData.name] =
@@ -482,4 +465,3 @@ PluginsService.LOCK_FILES = [
     "pnpm-lock.yaml",
 ];
 yok_1.injector.register("pluginsService", PluginsService);
-//# sourceMappingURL=plugins-service.js.map

package/lib/services/prepare-data-service.js

@@ -19,4 +19,3 @@ class PrepareDataService {
 }
 exports.PrepareDataService = PrepareDataService;
 yok_1.injector.register("prepareDataService", PrepareDataService);
-//# sourceMappingURL=prepare-data-service.js.map

package/lib/services/project-backup-service.js

@@ -47,7 +47,6 @@ ProjectBackupService.Backup = class Backup {
                 backedUpPaths.push(pathToBackup);
             }
         }
-        // create backup.json
         this.$super.$fs.writeJson(path.resolve(this.backupDir, "_backup.json"), {
             name: this.name,
             paths: backedUpPaths,
@@ -68,7 +67,6 @@ ProjectBackupService.Backup = class Backup {
             }
         }
         this.$super.$logger.trace(backupData);
-        // restore files
         return this;
     }
     isUpToDate() {
@@ -78,7 +76,6 @@ ProjectBackupService.Backup = class Backup {
         }
         for (const pathToBackup of backupData.paths) {
             const sourcePath = path.resolve(this.backupDir, pathToBackup);
-            // if any of the files don't exist the backup is not up-to-date
             if (!this.$super.$fs.exists(sourcePath)) {
                 return false;
             }
@@ -115,4 +112,3 @@ ProjectBackupService.Backup = class Backup {
     }
 };
 yok_1.injector.register("projectBackupService", ProjectBackupService);
-//# sourceMappingURL=project-backup-service.js.map

package/lib/services/project-changes-service.js

@@ -64,7 +64,6 @@ class ProjectChangesService {
                 this._prepareInfo.projectFileHash = this.getProjectFileStrippedHash(projectData.projectDir, platformData);
                 this._changesInfo.nativeChanged = this.isProjectFileChanged(projectData.projectDir, platformData);
             }
-            // If this causes too much rebuilds of the plugins or uncecessary builds for Android, move overrideCocoapods to prepareInfo.
             this._changesInfo.nsConfigChanged = this.filesChanged([
                 path.join(projectData.projectDir, constants_1.CONFIG_FILE_NAME_JS),
                 path.join(projectData.projectDir, constants_1.CONFIG_FILE_NAME_TS),
@@ -122,7 +121,6 @@ class ProjectChangesService {
     }
     getPrepareInfo(platformData) {
         if (this.$options.hostProjectPath) {
-            // TODO: always prepare for now until we decide where to keep the .nsprepareinfo file when embedding
             return null;
         }
         const prepareInfoFilePath = this.getPrepareInfoFilePath(platformData);
@@ -142,7 +140,6 @@ class ProjectChangesService {
             await this.ensurePrepareInfo(platformData, projectData, prepareData);
         }
         if (this.$options.hostProjectPath) {
-            // TODO: do not save for now until we decide where to keep the .nsprepareinfo file when embedding
             return null;
         }
         const prepareInfoFilePath = this.getPrepareInfoFilePath(platformData);
@@ -152,7 +149,7 @@ class ProjectChangesService {
         this._prepareInfo = this._prepareInfo || this.getPrepareInfo(platformData);
         if (this._prepareInfo &&
             addedPlatform.nativePlatformStatus ===
-                "3" /* NativePlatformStatus.alreadyPrepared */) {
+                constants_1.NativePlatformStatus.alreadyPrepared) {
             this._prepareInfo.nativePlatformStatus =
                 addedPlatform.nativePlatformStatus;
         }
@@ -176,8 +173,8 @@ class ProjectChangesService {
             return false;
         }
         const nativePlatformStatus = !prepareData.nativePrepare || !prepareData.nativePrepare.skipNativePrepare
-            ? "2" /* NativePlatformStatus.requiresPrepare */
-            : "1" /* NativePlatformStatus.requiresPlatformAdd */;
+            ? constants_1.NativePlatformStatus.requiresPrepare
+            : constants_1.NativePlatformStatus.requiresPlatformAdd;
         this._prepareInfo = {
             time: "",
             nativePlatformStatus,
@@ -200,13 +197,6 @@ class ProjectChangesService {
         const projectFileContents = this.$fs.readJson(projectFilePath);
         const relevantProperties = ["dependencies"];
         const projectFileStrippedContents = _.pick(projectFileContents, relevantProperties);
-        // _(this.$devicePlatformsConstants)
-        // 	.keys()
-        // 	.map(k => k.toLowerCase())
-        // 	.difference([platformData.platformNameLowerCase])
-        // 	.each(otherPlatform => {
-        // 		delete projectFileContents.nativescript[`tns-${otherPlatform}`];
-        // 	});
         return (0, helpers_1.getHash)(JSON.stringify(projectFileStrippedContents));
     }
     isProjectFileChanged(projectDir, platformData) {
@@ -272,4 +262,3 @@ __decorate([
     (0, helpers_1.hook)("checkForChanges")
 ], ProjectChangesService.prototype, "checkForChanges", null);
 yok_1.injector.register("projectChangesService", ProjectChangesService);
-//# sourceMappingURL=project-changes-service.js.map

package/lib/services/project-cleanup-service.js

@@ -28,7 +28,6 @@ class ProjectCleanupService {
             success = success && cleanRes.ok;
         }
         if (!(options === null || options === void 0 ? void 0 : options.silent)) {
-            // required to print an empty line for the spinner to not replace the last status... (probably a bug in the spinners)
             console.log();
         }
         if (stats) {
@@ -88,4 +87,3 @@ class ProjectCleanupService {
 }
 exports.ProjectCleanupService = ProjectCleanupService;
 yok_1.injector.register("projectCleanupService", ProjectCleanupService);
-//# sourceMappingURL=project-cleanup-service.js.map

package/lib/services/project-config-service.js

@@ -35,7 +35,6 @@ class ProjectConfigService {
         return (this.forceUsingLegacyConfig = force);
     }
     requireFromString(src, filename) {
-        // @ts-ignore
         const m = new module.constructor();
         m.paths = module.paths;
         m._compile(src, filename);
@@ -58,7 +57,6 @@ export default {
 } as NativeScriptConfig;`.trim();
     }
     warnUsingLegacyNSConfig() {
-        // todo: remove hack
         const isMigrate = _.get(this.$options, "argv._[0]") === "migrate";
         if (isMigrate) {
             return;
@@ -67,7 +65,6 @@ export default {
     }
     detectProjectConfigs(projectDir) {
         var _a;
-        // allow overriding config name with env variable or --config (or -c)
         let configName = (_a = process.env.NATIVESCRIPT_CONFIG_NAME) !== null && _a !== void 0 ? _a : this.$options.config;
         if (configName === "false") {
             configName = false;
@@ -97,7 +94,6 @@ export default {
         const existingConfigs = possibleConfigPaths.filter((path) => {
             return this.$fs.exists(path);
         });
-        // push the first possible config into the "existing" list
         const hasExistingConfig = !!existingConfigs.length;
         if (!hasExistingConfig) {
             this.$logger.trace(`No config file found - falling back to ${possibleConfigPaths[0]}.`);
@@ -192,8 +188,6 @@ export default {
             this.$fs.writeFile(configFilePath, await (0, prettier_1.format)(newContent, {
                 ...prettierOptions,
                 parser: "typescript",
-                // note: we don't use plugins here, since we are only formatting ts files, and they are supported by default
-                // and this also causes issues with certain plugins, like prettier-plugin-tailwindcss.
                 plugins: [],
             }));
         }
@@ -201,11 +195,9 @@ export default {
             this.$logger.error(`Failed to update config.` + error);
         }
         finally {
-            // verify config is updated correctly
             if (!Array.isArray(this.getValue(key)) && this.getValue(key) !== value) {
                 this.$logger.error(`${os_1.EOL}Failed to update ${hasTSConfig ? constants_1.CONFIG_FILE_NAME_TS : constants_1.CONFIG_FILE_NAME_JS}.${os_1.EOL}`);
                 this.$logger.printMarkdown(`Please manually update \`${hasTSConfig ? constants_1.CONFIG_FILE_NAME_TS : constants_1.CONFIG_FILE_NAME_JS}\` and set \`${key}\` to \`${value}\`.${os_1.EOL}`);
-                // restore original content
                 this.$fs.writeFile(configFilePath, configContent);
                 return false;
             }
@@ -234,11 +226,9 @@ export default {
             ? this.$fs.readJson(info.NSConfigPath)
             : {};
         try {
-            // injecting here to avoid circular dependency
             const projectData = this.$injector.resolve("projectData");
             const embeddedPackageJsonPath = path.resolve(this.projectHelper.projectDir, projectData.getAppDirectoryRelativePath(), constants.PACKAGE_JSON_FILE_NAME);
             const embeddedPackageJson = this.$fs.readJson(embeddedPackageJsonPath);
-            // filter only the supported keys
             additionalData.push(_.pick(embeddedPackageJson, [
                 "android",
                 "ios",
@@ -250,11 +240,9 @@ export default {
         }
         catch (err) {
             this.$logger.trace("failed to add embedded package.json data to config", err);
-            // ignore if the file doesn't exist
         }
         try {
             const packageJson = this.$fs.readJson(path.join(this.projectHelper.projectDir, "package.json"));
-            // add app id to additionalData for backwards compatibility
             if (!NSConfig.id &&
                 packageJson &&
                 packageJson.nativescript &&
@@ -278,10 +266,8 @@ export default {
         }
         catch (err) {
             this.$logger.trace("failed to read package.json data for config", err);
-            // ignore if the file doesn't exist
         }
         return _.defaultsDeep({}, ...additionalData, NSConfig);
-        // return Object.assign({}, ...additionalData, NSConfig);
     }
     async writeLegacyNSConfigIfNeeded(projectDir, runtimePackage) {
         const { usingNSConfig } = this.detectProjectConfigs(projectDir);
@@ -290,8 +276,6 @@ export default {
         }
         if (runtimePackage.version &&
             semver.gte(semver.coerce(runtimePackage.version), "7.0.0-rc.5")) {
-            // runtimes >= 7.0.0-rc.5 support passing appPath and appResourcesPath through gradle project flags
-            // so writing an nsconfig is not necessary.
             return;
         }
         const runtimePackageDisplay = `${runtimePackage.name}${runtimePackage.version ? " v" + runtimePackage.version : ""}`;
@@ -308,10 +292,8 @@ You may add \`nsconfig.json\` to \`.gitignore\` as the CLI will regenerate it as
             appPath: this.getValue("appPath"),
             appResourcesPath: this.getValue("appResourcesPath"),
         });
-        // mark the file for cleanup after the CLI exits
         await this.$cleanupService.addCleanupDeleteAction(nsConfigPath);
     }
-    // todo: move into config manipulation
     flattenObjectToPaths(obj, basePath) {
         const toPath = (key) => [basePath, key].filter(Boolean).join(".");
         return Object.keys(obj).reduce((all, key) => {
@@ -320,7 +302,7 @@ You may add \`nsconfig.json\` to \`.gitignore\` as the CLI will regenerate it as
                     ...all,
                     {
                         key: toPath(key),
-                        value: obj[key], // Preserve arrays as they are
+                        value: obj[key],
                     },
                 ];
             }
@@ -339,7 +321,7 @@ You may add \`nsconfig.json\` to \`.gitignore\` as the CLI will regenerate it as
 }
 exports.ProjectConfigService = ProjectConfigService;
 __decorate([
-    (0, decorators_1.cache)() // @cache should prevent the message being printed multiple times
+    (0, decorators_1.cache)()
 ], ProjectConfigService.prototype, "warnUsingLegacyNSConfig", null);
 __decorate([
     (0, decorators_1.exported)("projectConfigService")
@@ -351,4 +333,3 @@ __decorate([
     (0, decorators_1.exported)("projectConfigService")
 ], ProjectConfigService.prototype, "setValue", null);
 yok_1.injector.register("projectConfigService", ProjectConfigService);
-//# sourceMappingURL=project-config-service.js.map

package/lib/services/project-data-service.js

@@ -28,14 +28,12 @@ class ProjectDataService {
         this.$injector = $injector;
         this.projectDataCache = {};
         try {
-            // add the ProjectData of the default projectDir to the projectData cache
             const projectData = this.$injector.resolve("projectData");
             projectData.initializeProjectData();
             this.defaultProjectDir = projectData.projectDir;
             this.projectDataCache[this.defaultProjectDir] = projectData;
         }
         catch (e) {
-            // the CLI is required as a lib from a non-project folder
         }
     }
     get $pluginsService() {
@@ -64,8 +62,6 @@ class ProjectDataService {
         delete projectFileInfo.projectData[ProjectDataService.DEPENDENCIES_KEY_NAME][dependencyName];
         this.$fs.writeJson(projectFileInfo.projectFilePath, projectFileInfo.projectData);
     }
-    // TODO: Add tests
-    // TODO: Remove $projectData and replace it with $projectDataService.getProjectData
     getProjectData(projectDir) {
         projectDir = projectDir || this.defaultProjectDir;
         this.projectDataCache[projectDir] =
@@ -117,10 +113,6 @@ class ProjectDataService {
         this.$logger.trace(`"${propertyName}" property successfully removed.`);
     }
     async getAndroidAssetsStructure(opts) {
-        // TODO: Use image-size package to get the width and height of an image.
-        // TODO: Parse the splash_screen.xml in nodpi directory and get from it the names of the background and center image.
-        // TODO: Parse the AndroidManifest.xml to get the name of the icon.
-        // This way we'll not use the image-definitions.json and the method will return the real android structure.
         const projectDir = opts.projectDir;
         const projectData = this.getProjectData(projectDir);
         const pathToAndroidDir = path.join(projectData.appResourcesDirectoryPath, this.$devicePlatformsConstants.Android);
@@ -134,7 +126,6 @@ class ProjectDataService {
             useLegacy = !manifest.includes(`android:icon="@mipmap/ic_launcher"`);
         }
         catch (err) {
-            // ignore
         }
         const content = this.getImageDefinitions()[useLegacy ? "android_legacy" : "android"];
         return {
@@ -158,8 +149,6 @@ class ProjectDataService {
             }
             if (fstat.isDirectory()) {
                 if (filePath === pathToProjectNodeModules) {
-                    // we do not want to get the files from node_modules directory of the project.
-                    // We'll get here only when you have nativescript.config with appDirectoryPath set to "."
                     return false;
                 }
                 return true;
@@ -174,9 +163,6 @@ class ProjectDataService {
         }
     }
     updateNsConfigValue(projectDir, updateObject, propertiesToRemove) {
-        // todo: figure out a way to update js/ts configs
-        // most likely needs an ast parser/writer
-        // should be delegated to the config service
         const nsConfigPath = path.join(projectDir, constants.CONFIG_FILE_NAME_JS);
         const currentNsConfig = this.getNsConfig(nsConfigPath);
         let newNsConfig = currentNsConfig;
@@ -217,14 +203,10 @@ class ProjectDataService {
         const imageDefinitions = this.getImageDefinitions().ios;
         _.each(content && content.images, (image) => {
             let foundMatchingDefinition = false;
-            // In some cases the image may not be available, it will just be described.
-            // When this happens, the filename will be empty.
-            // So we'll keep the path empty as well.
             if (image.filename) {
                 image.path = path.join(dirPath, image.filename);
             }
             if (image.size) {
-                // size is basically <width>x<height>
                 const [width, height] = image.size
                     .toString()
                     .split(constants_1.AssetConstants.sizeDelimiter);
@@ -233,7 +215,6 @@ class ProjectDataService {
                     image.height = +height;
                 }
             }
-            // Find the image size based on the hardcoded values in the image-definitions.json
             _.each(imageDefinitions, (assetSubGroup) => {
                 const assetItem = _.find(assetSubGroup, (assetElement) => assetElement.filename === image.filename &&
                     path.basename(assetElement.directory) === path.basename(dirPath));
@@ -253,7 +234,6 @@ class ProjectDataService {
                     image.scale = image.scale || assetItem.scale;
                     image.rgba = assetItem.rgba;
                     finalContent.images.push(image);
-                    // break each
                     return false;
                 }
             });
@@ -356,16 +336,13 @@ class ProjectDataService {
     getRuntimePackage(projectDir, platform) {
         platform = platform.toLowerCase();
         const packageJson = this.$fs.readJson(path.join(projectDir, constants.PACKAGE_JSON_FILE_NAME));
-        const runtimeName = platform === "android" /* PlatformTypes.android */
+        const runtimeName = platform === constants_1.PlatformTypes.android
             ? constants.TNS_ANDROID_RUNTIME_NAME
             : constants.TNS_IOS_RUNTIME_NAME;
         if (packageJson &&
             packageJson.nativescript &&
             packageJson.nativescript[runtimeName] &&
             packageJson.nativescript[runtimeName].version) {
-            // if we have a nativescript key with a runtime version in package.json
-            // that means we are dealing with a legacy project, and should respect
-            // that information
             return {
                 name: runtimeName,
                 version: packageJson.nativescript[runtimeName].version,
@@ -379,17 +356,17 @@ class ProjectDataService {
             .getDependenciesFromPackageJson(projectDir)
             .devDependencies.find((d) => {
             var _a, _b, _c, _d;
-            if (platform === "ios" /* constants.PlatformTypes.ios */) {
+            if (platform === constants.PlatformTypes.ios) {
                 const packageName = ((_b = (_a = this.$projectData.nsConfig) === null || _a === void 0 ? void 0 : _a.ios) === null || _b === void 0 ? void 0 : _b.runtimePackageName) ||
                     constants.SCOPED_IOS_RUNTIME_NAME;
                 return [packageName, constants.TNS_IOS_RUNTIME_NAME].includes(d.name);
             }
-            else if (platform === "android" /* constants.PlatformTypes.android */) {
+            else if (platform === constants.PlatformTypes.android) {
                 const packageName = ((_d = (_c = this.$projectData.nsConfig) === null || _c === void 0 ? void 0 : _c.android) === null || _d === void 0 ? void 0 : _d.runtimePackageName) ||
                     constants.SCOPED_ANDROID_RUNTIME_NAME;
                 return [packageName, constants.TNS_ANDROID_RUNTIME_NAME].includes(d.name);
             }
-            else if (platform === "visionos" /* constants.PlatformTypes.visionos */) {
+            else if (platform === constants.PlatformTypes.visionos) {
                 return d.name === constants.SCOPED_VISIONOS_RUNTIME_NAME;
             }
         });
@@ -397,14 +374,12 @@ class ProjectDataService {
             const coerced = semver.coerce(runtimePackage.version);
             const isRange = !!coerced && coerced.version !== runtimePackage.version;
             const isTag = !coerced;
-            // in case we are using a local tgz for the runtime or a range like ~8.0.0, ^8.0.0 etc. or a tag like JSC
             if (runtimePackage.version.includes("tgz") || isRange || isTag) {
                 try {
                     const runtimePackageJsonPath = (0, package_path_helper_1.resolvePackageJSONPath)(runtimePackage.name, {
                         paths: [projectDir],
                     });
                     if (!runtimePackageJsonPath) {
-                        // caught below
                         throw new Error("Runtime package.json not found.");
                     }
                     runtimePackage.version = this.$fs.readJson(runtimePackageJsonPath).version;
@@ -421,23 +396,22 @@ class ProjectDataService {
             }
             return runtimePackage;
         }
-        // default to the scoped runtimes
         this.$logger.trace("Could not find an installed runtime, falling back to default runtimes");
-        if (platform === "ios" /* constants.PlatformTypes.ios */) {
+        if (platform === constants.PlatformTypes.ios) {
             return {
                 name: ((_b = (_a = this.$projectData.nsConfig) === null || _a === void 0 ? void 0 : _a.ios) === null || _b === void 0 ? void 0 : _b.runtimePackageName) ||
                     constants.SCOPED_IOS_RUNTIME_NAME,
                 version: null,
             };
         }
-        else if (platform === "android" /* constants.PlatformTypes.android */) {
+        else if (platform === constants.PlatformTypes.android) {
             return {
                 name: ((_d = (_c = this.$projectData.nsConfig) === null || _c === void 0 ? void 0 : _c.android) === null || _d === void 0 ? void 0 : _d.runtimePackageName) ||
                     constants.SCOPED_ANDROID_RUNTIME_NAME,
                 version: null,
             };
         }
-        else if (platform === "visionos" /* constants.PlatformTypes.visionos */) {
+        else if (platform === constants.PlatformTypes.visionos) {
             return {
                 name: constants.SCOPED_VISIONOS_RUNTIME_NAME,
                 version: null,
@@ -472,11 +446,9 @@ __decorate([
             return projectDir + ":" + platform;
         },
         shouldCache(result) {
-            // don't cache coerced versions
             if (result._coerced) {
                 return false;
             }
-            // only cache if version is defined
             return !!result.version;
         },
     })
@@ -485,4 +457,3 @@ __decorate([
     (0, decorators_1.exported)("projectDataService")
 ], ProjectDataService.prototype, "getNsConfigDefaultContent", null);
 yok_1.injector.register("projectDataService", ProjectDataService);
-//# sourceMappingURL=project-data-service.js.map

package/lib/services/project-name-service.js

@@ -50,4 +50,3 @@ class ProjectNameService {
 }
 exports.ProjectNameService = ProjectNameService;
 yok_1.injector.register("projectNameService", ProjectNameService);
-//# sourceMappingURL=project-name-service.js.map