nativescript 9.1.0-alpha.15 → 9.1.0-alpha.16

package/lib/services/cocoapods-service.js

@@ -34,12 +34,6 @@ class CocoaPodsService {
         let podTool = this.$config.USE_POD_SANDBOX ? "sandbox-pod" : "pod";
         const args = ["install"];
         if (process.platform === "darwin" && process.arch === "arm64") {
-            // check if pod is installed as an x86_64 binary or a native arm64 one
-            // we run the following:
-            // arch -x86_64 pod --version
-            // if it's an arm64 binary, we'll get something like this as a result:
-            // arch: posix_spawnp: pod: Bad CPU type in executable
-            // in which case, we should run it natively.
             const res = await this.$childProcess
                 .exec("arch -x86_64 pod --version", null, {
                 showStderr: true,
@@ -53,11 +47,8 @@ class CocoaPodsService {
                 podTool = "arch";
             }
         }
-        // cocoapods print a lot of non-error information on stderr. Pipe the `stderr` to `stdout`, so we won't polute CLI's stderr output.
         const podInstallResult = await this.$childProcess.spawnFromEvent(podTool, args, "close", { cwd: projectRoot, stdio: ["pipe", process.stdout, process.stdout] }, { throwError: false });
         if (podInstallResult.exitCode !== 0) {
-            // https://github.com/CocoaPods/CocoaPods/blob/92aaf0f1120d32f3487960b485fb69fcaf61486c/lib/cocoapods/resolver.rb#L498
-            // TODO add article
             const versionResolutionHint = podInstallResult.exitCode === 31
                 ? `For more information on resolving CocoaPod issues in NativeScript read.`
                 : "";
@@ -89,7 +80,6 @@ ${versionResolutionHint}`);
     }
     async applyPodfileArchExclusions(projectData, platformData) {
         const xcodeVersionData = await this.$xcodeSelectService.getXcodeVersion();
-        // only apply EXCLUDED_ARCHS workaround on XCode 12
         if (+xcodeVersionData.major !== 12) {
             return;
         }
@@ -108,7 +98,6 @@ end`.trim();
             this.$fs.writeFile(exclusionsPodfile, exclusions);
         }
         await this.applyPodfileToProject("NativeScript-CLI-Architecture-Exclusions", exclusionsPodfile, projectData, platformData);
-        // clean up
         this.$fs.deleteFile(exclusionsPodfile);
     }
     async applyPodfileFromExtensions(projectData, platformData) {
@@ -131,7 +120,6 @@ end`.trim();
             podfilePath: path.join(extensionFolderPath, name, constants.PODFILE_NAME),
         }));
         extensionsPodfile.forEach(({ targetName, podfilePath }) => {
-            // Remove the data between #Begin Podfile and #EndPodfile
             const regExpToRemove = new RegExp(`${this.getExtensionPodfileHeader(podfilePath, targetName)}[\\s\\S]*?${this.getExtensionPodfileEnd()}`, "mg");
             projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
             if (this.$fs.exists(podfilePath)) {
@@ -158,7 +146,6 @@ end`.trim();
             ? this.$fs.readText(pathToProjectPodfile).trim()
             : "";
         if (projectPodfileContent.indexOf(podfileContent) === -1) {
-            // Remove old occurences of the plugin from the project's Podfile.
             this.removePodfileFromProject(moduleName, podfilePath, projectData, nativeProjectPath);
             let finalPodfileContent = this.$fs.exists(pathToProjectPodfile)
                 ? this.getPodfileContentWithoutTarget(projectData, this.$fs.readText(pathToProjectPodfile))
@@ -176,7 +163,6 @@ end`.trim();
     removePodfileFromProject(moduleName, podfilePath, projectData, projectRoot) {
         if (this.$fs.exists(this.getProjectPodfilePath(projectRoot))) {
             let projectPodFileContent = this.$fs.readText(this.getProjectPodfilePath(projectRoot));
-            // Remove the data between #Begin Podfile and #EndPodfile
             const regExpToRemove = new RegExp(`${this.getPluginPodfileHeader(podfilePath)}[\\s\\S]*?${this.getPluginPodfileEnd()}`, "mg");
             projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
             projectPodFileContent = this.removePostInstallHook(moduleName, projectPodFileContent);
@@ -197,7 +183,7 @@ end`.trim();
         }
     }
     getPluginPodfilePath(pluginData) {
-        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath("ios" /* PlatformTypes.ios */);
+        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath(constants_1.PlatformTypes.ios);
         const pluginPodFilePath = path.join(pluginPlatformsFolderPath, constants_1.PODFILE_NAME);
         return pluginPodFilePath;
     }
@@ -233,7 +219,6 @@ end`.trim();
         if (_.startsWith(projectPodfileContent, podFileHeader)) {
             projectPodfileContent = projectPodfileContent.substr(podFileHeader.length);
             const podFileFooter = this.getPodfileFooter();
-            // Only remove the final end in case the file starts with the podFileHeader
             if (_.endsWith(projectPodfileContent, podFileFooter)) {
                 projectPodfileContent = projectPodfileContent.substr(0, projectPodfileContent.length - podFileFooter.length);
             }
@@ -254,8 +239,6 @@ end`.trim();
         return projectPodFileContent;
     }
     getHookBasicFuncNameForPlugin(hookName, pluginName) {
-        // nativescript-hook and nativescript_hook should have different names, so replace all _ with ___ first and then replace all special symbols with _
-        // This will lead to a clash in case plugins are called nativescript-hook and nativescript___hook
         const replacedPluginName = pluginName
             .replace(/_/g, "___")
             .replace(/[^A-Za-z0-9_]/g, "_");
@@ -269,7 +252,6 @@ end`.trim();
             const newFunctionName = `${this.getHookBasicFuncNameForPlugin(hookName, pluginName)}_${newFunctions.length}`;
             let newDefinition = `def ${newFunctionName}`;
             const rubyFunction = { functionName: newFunctionName };
-            // firstGroup is the block parameter, secondGroup is the block parameter name.
             if (firstGroup && secondGroup) {
                 newDefinition = `${newDefinition} (${secondGroup})`;
                 rubyFunction.functionParameters = secondGroup;
@@ -280,7 +262,6 @@ end`.trim();
         return { replacedContent, newFunctions };
     }
     getPluginPodfileHeader(pluginPodFilePath) {
-        // escape special + from the podfile path (pnpm)
         pluginPodFilePath = pluginPodFilePath.replace(/\+/g, "\\+");
         return `# Begin Podfile - ${pluginPodFilePath}`;
     }
@@ -350,4 +331,3 @@ exports.CocoaPodsService = CocoaPodsService;
 CocoaPodsService.PODFILE_POST_INSTALL_SECTION_NAME = "post_install";
 CocoaPodsService.INSTALLER_BLOCK_PARAMETER_NAME = "installer";
 yok_1.injector.register("cocoapodsService", CocoaPodsService);
-//# sourceMappingURL=cocoapods-service.js.map

package/lib/services/debug-data-service.js

@@ -19,4 +19,3 @@ class DebugDataService {
 }
 exports.DebugDataService = DebugDataService;
 yok_1.injector.register("debugDataService", DebugDataService);
-//# sourceMappingURL=debug-data-service.js.map

package/lib/services/debug-service-base.js

@@ -27,12 +27,6 @@ class DebugServiceBase extends events_1.EventEmitter {
         };
     }
     getChromeDebugUrl(debugOptions, port) {
-        // corresponds to 55.0.2883 Chrome version
-        // SHA is taken from https://chromium.googlesource.com/chromium/src/+/55.0.2883.100
-        // This SHA is old and does not support debugging with HMR.
-        // In case we want to stick with concrete SHA, get it from one of the tags https://chromium.googlesource.com/chromium/src/
-        // IMPORTANT: When you get the SHA, ensure you are using the `parent` commit, not the actual one.
-        // Using the actual commit will result in 404 error in the remote serve.
         const commitSHA = debugOptions.devToolsCommit || "02e6bde1bbe34e43b309d4ef774b1168d25fd024";
         const devToolsProtocol = `devtools`;
         let chromeDevToolsPrefix = `${devToolsProtocol}://devtools/remote/serve_file/@${commitSHA}`;
@@ -48,4 +42,3 @@ class DebugServiceBase extends events_1.EventEmitter {
     }
 }
 exports.DebugServiceBase = DebugServiceBase;
-//# sourceMappingURL=debug-service-base.js.map

package/lib/services/device/device-install-app-service.js

@@ -21,7 +21,7 @@ class DeviceInstallAppService {
         const projectData = this.$projectDataService.getProjectData(buildData.projectDir);
         const platformData = this.$platformsDataService.getPlatformData(platform, projectData);
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Deploy" /* TrackActionNames.Deploy */,
+            action: constants_1.TrackActionNames.Deploy,
             device,
             projectDir: projectData.projectDir,
         });
@@ -77,4 +77,3 @@ class DeviceInstallAppService {
 }
 exports.DeviceInstallAppService = DeviceInstallAppService;
 yok_1.injector.register("deviceInstallAppService", DeviceInstallAppService);
-//# sourceMappingURL=device-install-app-service.js.map

package/lib/services/doctor-service.js

@@ -52,13 +52,9 @@ class DoctorService {
             this.printPackageManagerTip();
         }
         if (!configOptions || configOptions.trackResult) {
-            // TODO(Analytics): Consider sending this information to Google Analytics
-            // await this.$analyticsService.track("DoctorEnvironmentSetup", hasWarnings ? "incorrect" : "correct");
         }
         if (hasWarnings) {
             this.$logger.info("There seem to be issues with your configuration.");
-            // cleanup the cache file as there seems to be issues with the current config
-            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
         }
         else {
@@ -72,7 +68,6 @@ class DoctorService {
         catch (err) {
             this.$logger.error("Cannot get the latest versions information from npm. Please try again later.");
         }
-        // todo: check for deprecated imports from `tns-core-modules`
         this.checkForDeprecatedShortImportsInAppDir(configOptions.projectDir);
         await this.$injector
             .resolve("platformEnvironmentRequirements")
@@ -85,12 +80,12 @@ class DoctorService {
     }
     async runSetupScript() {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+            action: constants_1.TrackActionNames.RunSetupScript,
             additionalData: "Starting",
         });
         if (this.$hostInfo.isLinux) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+                action: constants_1.TrackActionNames.RunSetupScript,
                 additionalData: "Skipped as OS is Linux",
             });
             return;
@@ -103,13 +98,13 @@ class DoctorService {
             await this.runSetupScriptCore(DoctorService.WindowsSetupScriptExecutable, DoctorService.WindowsSetupScriptArguments);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
+            action: constants_1.TrackActionNames.RunSetupScript,
             additionalData: "Finished",
         });
     }
     async canExecuteLocalBuild(configuration) {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+            action: constants_1.TrackActionNames.CheckLocalBuildSetup,
             additionalData: "Starting",
         });
         const sysInfoConfig = {
@@ -121,11 +116,9 @@ class DoctorService {
         const warnings = this.filterInfosByType(infos, doctor_1.constants.WARNING_TYPE_NAME);
         const hasWarnings = warnings.length > 0;
         if (hasWarnings) {
-            // cleanup the cache file as there seems to be issues with the current config
-            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+                action: constants_1.TrackActionNames.CheckLocalBuildSetup,
                 additionalData: `Warnings:${warnings.map((w) => w.message).join("__")}`,
             });
             this.printInfosCore(infos);
@@ -135,7 +128,7 @@ class DoctorService {
             await this.$jsonFileSettingsService.saveSetting(this.getKeyForConfiguration(sysInfoConfig), infos);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
+            action: constants_1.TrackActionNames.CheckLocalBuildSetup,
             additionalData: `Finished: Is setup correct: ${!hasWarnings}`,
         });
         return !hasWarnings;
@@ -183,13 +176,6 @@ class DoctorService {
             .getFsStats(path.join(pathToTnsCoreModules, entry))
             .isDirectory());
         const stringRegularExpressionsPerDir = coreModulesSubDirs.map((c) => {
-            // require("text");
-            // require("text/smth");
-            // require(   "text/smth");
-            // require(   "text/smth"   );
-            // import * as text from "text";
-            // import { a } from "text";
-            // import {a } from "text/abc"
             const subDirPart = `[\"\']${c}[\"\'/]`;
             return `(\\brequire\\s*?\\(\\s*?${subDirPart})|(\\bimport\\b.*?from\\s*?${subDirPart})`;
         });
@@ -287,4 +273,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], DoctorService.prototype, "$jsonFileSettingsService", null);
 yok_1.injector.register("doctorService", DoctorService);
-//# sourceMappingURL=doctor-service.js.map

package/lib/services/extensibility-service.js

@@ -119,17 +119,12 @@ class ExtensibilityService {
         for (const extensionData of allExtensions) {
             const extensionName = extensionData.package.name;
             try {
-                // now get full package.json for the latest version of the package
                 const registryData = await this.$packageManager.getRegistryPackageData(extensionName);
                 const latestPackageData = registryData.versions[registryData["dist-tags"].latest];
                 const commands = latestPackageData &&
                     latestPackageData.nativescript &&
                     latestPackageData.nativescript.commands;
                 if (commands && commands.length) {
-                    // For each default command we need to add its short syntax in the array of commands.
-                    // For example in case there's a default command called devices list, the commands array will contain devices|*list.
-                    // However, in case the user executes just ns devices, CLI will still execute the ns devices list command.
-                    // So we need to add the devices command as well.
                     _.filter(commands, (command) => command.indexOf(inputOpts.defaultCommandDelimiter) !== -1).forEach((defaultCommand) => {
                         commands.push(defaultCommand.replace(defaultCommandRegExp, ""));
                     });
@@ -151,7 +146,6 @@ class ExtensibilityService {
                 }
             }
             catch (err) {
-                // We do not want to stop the whole process in case we are unable to find data for one of the extensions.
                 this.$logger.trace(`Unable to get data for ${extensionName}. Error is: ${err}`);
             }
         }
@@ -184,7 +178,6 @@ class ExtensibilityService {
         this.assertExtensionsDirExists();
         if (!this.$fs.exists(this.pathToPackageJson)) {
             this.$logger.trace(`Creating ${this.pathToPackageJson}.`);
-            // create default package.json
             this.$fs.writeJson(this.pathToPackageJson, {
                 name: "nativescript-extensibility",
                 version: "1.0.0",
@@ -206,4 +199,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], ExtensibilityService.prototype, "assertPackageJsonExists", null);
 yok_1.injector.register("extensibilityService", ExtensibilityService);
-//# sourceMappingURL=extensibility-service.js.map

package/lib/services/files-hash-service.js

@@ -61,4 +61,3 @@ class FilesHashService {
 }
 exports.FilesHashService = FilesHashService;
 yok_1.injector.register("filesHashService", FilesHashService);
-//# sourceMappingURL=files-hash-service.js.map

package/lib/services/hmr-status-service.js

@@ -56,7 +56,6 @@ class HmrStatusService {
             name: "failedLiveSync",
             platform: this.$devicePlatformsConstants.iOS.toLowerCase(),
         });
-        // webpack5
         const statusStringMap = {
             success: constants_1.HmrConstants.HMR_SUCCESS_STATUS,
             failure: constants_1.HmrConstants.HMR_ERROR_STATUS,
@@ -127,4 +126,3 @@ __decorate([
     (0, decorators_1.cache)()
 ], HmrStatusService.prototype, "attachToHmrStatusEvent", null);
 yok_1.injector.register("hmrStatusService", HmrStatusService);
-//# sourceMappingURL=hmr-status-service.js.map

package/lib/services/info-service.js

@@ -12,4 +12,3 @@ class InfoService {
 }
 exports.InfoService = InfoService;
 yok_1.injector.register("infoService", InfoService);
-//# sourceMappingURL=info-service.js.map

package/lib/services/initialize-service.js

@@ -5,9 +5,8 @@ const os_1 = require("os");
 const _ = require("lodash");
 const constants_1 = require("../constants");
 const yok_1 = require("../common/yok");
+const system_warnings_1 = require("../definitions/system-warnings");
 class InitializeService {
-    // NOTE: Do not inject anything here, use $injector.resolve in the code
-    // Injecting something may lead to logger initialization, but we want to initialize it from here.
     constructor($injector) {
         this.$injector = $injector;
     }
@@ -35,7 +34,6 @@ class InitializeService {
             }
         }
         if ($options.json) {
-            // speed up --json commands by not gathering system warnings...
             $logger.trace("Skipping system warnings for --json commands");
         }
         else {
@@ -47,7 +45,7 @@ class InitializeService {
         const systemWarnings = await $sysInfo.getSystemWarnings();
         _.each(systemWarnings, (systemWarning) => {
             const message = `${os_1.EOL}${systemWarning.message}${os_1.EOL}`;
-            if (systemWarning.severity === "high" /* SystemWarningsSeverity.high */) {
+            if (systemWarning.severity === system_warnings_1.SystemWarningsSeverity.high) {
                 $logger.error(message);
             }
             else {
@@ -58,4 +56,3 @@ class InitializeService {
 }
 exports.InitializeService = InitializeService;
 yok_1.injector.register("initializeService", InitializeService);
-//# sourceMappingURL=initialize-service.js.map

package/lib/services/ios/export-options-plist-service.js

@@ -54,13 +54,11 @@ class ExportOptionsPlistService {
         plistTemplate += `
 </dict>
 </plist>`;
-        // Save the options...
         const exportOptionsPlistFilePath = await this.$tempService.path({
             prefix: "export-",
             suffix: ".plist",
         });
         this.$fs.writeFile(exportOptionsPlistFilePath, plistTemplate);
-        // The xcodebuild exportPath expects directory and writes the <project-name>.ipa at that directory.
         const exportFileDir = path.resolve(path.dirname(archivePath));
         const exportFilePath = path.join(exportFileDir, projectData.projectName + ".ipa");
         return { exportFileDir, exportFilePath, exportOptionsPlistFilePath };
@@ -98,7 +96,6 @@ class ExportOptionsPlistService {
     <false/>
 </dict>
 </plist>`;
-        // Save the options...
         const exportOptionsPlistFilePath = await this.$tempService.path({
             prefix: "export-",
             suffix: ".plist",
@@ -121,4 +118,3 @@ class ExportOptionsPlistService {
 }
 exports.ExportOptionsPlistService = ExportOptionsPlistService;
 yok_1.injector.register("exportOptionsPlistService", ExportOptionsPlistService);
-//# sourceMappingURL=export-options-plist-service.js.map

package/lib/services/ios/ios-signing-service.js

@@ -46,7 +46,6 @@ class IOSSigningService {
         let shouldUpdateXcode = false;
         if (signing && signing.style === "Automatic") {
             if (signing.team !== teamId) {
-                // Maybe the provided team is name such as "Telerik AD" and we need to convert it to CH******37
                 const teamIdsForName = await this.$iOSProvisionService.getTeamIdsWithName(teamId);
                 if (!teamIdsForName.some((id) => id === signing.team)) {
                     shouldUpdateXcode = true;
@@ -80,7 +79,6 @@ class IOSSigningService {
     }
     async setupSigningFromProvision(projectRoot, projectData, provision, mobileProvisionData) {
         if (!provision) {
-            // read uuid from Xcode an cache...
             return;
         }
         const xcode = this.$pbxprojDomXcode.Xcode.open(this.getPbxProjPath(projectData, projectRoot));
@@ -113,7 +111,6 @@ class IOSSigningService {
                 this.$logger.trace(`Set Manual signing style and provisioning profile: ${configuration.name} (${configuration.uuid})`);
             });
             xcode.save();
-            // this.cache(uuid);
         }
         else {
             this.$logger.trace(`The specified provisioning profile is already set in the Xcode: ${provision}`);
@@ -276,4 +273,3 @@ class IOSSigningService {
 }
 exports.IOSSigningService = IOSSigningService;
 yok_1.injector.register("iOSSigningService", IOSSigningService);
-//# sourceMappingURL=ios-signing-service.js.map