nativescript 9.0.4-dev.1 → 9.0.4-dev.2

package/lib/common/services/help-service.js

@@ -42,6 +42,7 @@ class HelpService {
         this.$logger.trace("Opening help for command '%s'. FileName is '%s'.", commandName, htmlPage);
         this.$fs.ensureDirectoryExists(this.pathToHtmlPages);
         if (!this.tryOpeningSelectedPage(htmlPage)) {
+            // HTML pages may have been skipped on post-install, lets generate them.
             this.$logger.trace("Required HTML file '%s' is missing. Let's try generating HTML files and see if we'll find it.", htmlPage);
             await this.generateHtmlPages();
             if (!this.tryOpeningSelectedPage(htmlPage)) {
@@ -98,6 +99,11 @@ class HelpService {
         const help = await this.getCommandLineHelpForCommand(commandData);
         this.$logger.printMarkdown(help);
     }
+    /**
+     * Gets the help content for a specific command that should be shown on the terminal.
+     * @param {string} commandName Name of the command for which to read the help.
+     * @returns {Promise<string>} Help content of the command parsed with all terminal rules applied (stripped content that should be shown only for html help).
+     */
     async getCommandLineHelpForCommand(commandData) {
         const helpText = await this.readMdFileForCommand(commandData);
         const commandLineHelp = (await this.$microTemplateService.parseContent(helpText, { isHtml: false }))
@@ -109,6 +115,7 @@ class HelpService {
             .replace(HelpService.NEW_LINE_REGEX, os_1.EOL);
         return commandLineHelp;
     }
+    // This method should return Promise in order to generate all html pages simultaneously.
     async createHtmlPage(htmlPageGenerationData) {
         const { basicHtmlPage, pathToMdFile, pathToMdPages, pathToHtmlPages, extensionName, } = htmlPageGenerationData;
         const mdFileName = path.basename(pathToMdFile);
@@ -155,8 +162,8 @@ class HelpService {
         const commandName = commandData.commandName;
         const commandInfo = {
             inputStrings: [commandName, ...commandData.commandArguments],
-            commandDelimiter: "|",
-            defaultCommandDelimiter: "|*",
+            commandDelimiter: "|" /* CommandsDelimiters.HierarchicalCommand */,
+            defaultCommandDelimiter: "|*" /* CommandsDelimiters.DefaultHierarchicalCommand */,
         };
         const extensionData = await this.$extensibilityService.getExtensionNameWhereCommandIsRegistered(commandInfo);
         if (extensionData) {
@@ -223,5 +230,6 @@ HelpService.RELATIVE_PATH_TO_INDEX_REGEX = /@RELATIVE_PATH_TO_INDEX@/g;
 HelpService.EXTENSION_NAME_REGEX = /@EXTENSION_NAME@/g;
 HelpService.MARKDOWN_LINK_REGEX = /\[([\w \-\`\<\>\*\:\\]+?)\]\([\s\S]+?\)/g;
 HelpService.SPAN_REGEX = /([\s\S]*?)(?:\r?\n)?<span.*?>([\s\S]*?)<\/span>(?:\r?\n)*/g;
-HelpService.NEW_LINE_REGEX = /<\/?\s*?br\s*?\/?>/g;
+HelpService.NEW_LINE_REGEX = /<\/?\s*?br\s*?\/?>/g; // <br>, <br > <br/> <br />
 yok_1.injector.register("helpService", HelpService);
+//# sourceMappingURL=help-service.js.map

package/lib/common/services/hooks-service.js

@@ -52,6 +52,7 @@ class HooksService {
         }
     }
     static formatHookName(commandName) {
+        // Remove everything after | (including the pipe)
         return commandName.replace(/\|[\s\S]*$/, "");
     }
     executeBeforeHooks(commandName, hookArguments) {
@@ -131,6 +132,11 @@ class HooksService {
                 this.$logger.warn(`${hook.fullPath} will NOT be executed because it has invalid arguments - ${color_1.color.grey(invalidArguments.join(", "))}.`);
                 return;
             }
+            // HACK for backwards compatibility:
+            // In case $projectData wasn't resolved by the time we got here (most likely we got here without running a command but through a service directly)
+            // then it is probably passed as a hookArg
+            // if that is the case then pass it directly to the hook instead of trying to resolve $projectData via injector
+            // This helps make hooks stateless
             const projectDataHookArg = hookArguments["hookArgs"] && hookArguments["hookArgs"]["projectData"];
             if (projectDataHookArg) {
                 hookArguments["projectData"] = hookArguments["$projectData"] =
@@ -149,6 +155,7 @@ class HooksService {
                         this.$logger.warn(err.message || err);
                     }
                     else {
+                        // Print the actual error with its callstack, so it is easy to find out which hooks is causing troubles.
                         this.$logger.error(err);
                         throw err || new Error(`Failed to execute hook: ${hook.fullPath}.`);
                     }
@@ -253,6 +260,7 @@ class HooksService {
                 interpreter = sheBangMatch[1];
             }
             if (interpreter) {
+                // Likewise, make /usr/bin/bash work like "bash".
                 shMatch = interpreter.match(/bin\/((?:ba)?sh)$/);
             }
             if (shMatch) {
@@ -293,6 +301,7 @@ class HooksService {
     }
     validateHookArguments(hookConstructor, hookFullPath) {
         const invalidArguments = [];
+        // We need to annotate the hook in order to have the arguments of the constructor.
         (0, helpers_1.annotate)(hookConstructor);
         _.each(hookConstructor.$inject.args, (argument) => {
             try {
@@ -313,8 +322,12 @@ HooksService.HOOKS_DIRECTORY_NAME = "hooks";
 __decorate([
     (0, decorators_1.memoize)({
         shouldCache() {
+            // only cache if we have hooks directories, the only case to
+            // not have hooks directories is when the project dir is
+            // not set yet, ie. when creating a project.
             return !!this.hooksDirectories.length;
         },
     })
 ], HooksService.prototype, "initialize", null);
 yok_1.injector.register("hooksService", HooksService);
+//# sourceMappingURL=hooks-service.js.map

package/lib/common/services/ios-notification-service.js

@@ -34,3 +34,4 @@ class IOSNotificationService {
 }
 exports.IOSNotificationService = IOSNotificationService;
 yok_1.injector.register("iOSNotificationService", IOSNotificationService);
+//# sourceMappingURL=ios-notification-service.js.map

package/lib/common/services/json-file-settings-service.js

@@ -25,6 +25,8 @@ class JsonFileSettingsService {
                 const dataToReturn = data.modifiedByCacheMechanism ? data.value : data;
                 if (cacheOpts && cacheOpts.cacheTimeout) {
                     if (!data.modifiedByCacheMechanism) {
+                        // If data has no cache, but we want to check the timeout, consider the data as outdated.
+                        // this should be a really rare case
                         return null;
                     }
                     const currentTime = Date.now();
@@ -82,6 +84,8 @@ class JsonFileSettingsService {
         if (!this.$fs.exists(this.jsonSettingsFilePath)) {
             const unexistingDirs = this.getUnexistingDirectories(this.jsonSettingsFilePath);
             this.$fs.writeFile(this.jsonSettingsFilePath, null);
+            // when running under 'sudo' we create the <path to home dir>/.local/share/.nativescript-cli dir with root as owner
+            // and other Applications cannot access this directory anymore. (bower/heroku/etc)
             if (process.env.SUDO_USER) {
                 for (const dir of unexistingDirs) {
                     await this.$fs.setCurrentUserAsOwner(dir, process.env.SUDO_USER);
@@ -101,6 +105,7 @@ class JsonFileSettingsService {
         const unexistingDirs = [];
         let currentDir = path.join(filePath, "..");
         while (true) {
+            // this directory won't be created.
             if (this.$fs.exists(currentDir)) {
                 break;
             }
@@ -112,3 +117,4 @@ class JsonFileSettingsService {
 }
 exports.JsonFileSettingsService = JsonFileSettingsService;
 yok_1.injector.register("jsonFileSettingsService", JsonFileSettingsService, false);
+//# sourceMappingURL=json-file-settings-service.js.map

package/lib/common/services/lock-service.js

@@ -22,6 +22,7 @@ class LockService {
     }
     get defaultLockParams() {
         const lockParams = {
+            // https://www.npmjs.com/package/retry#retrytimeoutsoptions
             retriesObj: { retries: 13, minTimeout: 100, maxTimeout: 1000, factor: 2 },
             stale: 10 * 1000,
             realpath: false,
@@ -72,6 +73,8 @@ class LockService {
         }
     }
     getPathsForCleanupAction(lockPath) {
+        // The proper-lockfile creates directory with the passed name and `.lock` at the end.
+        // Ensure we will take care of it as well.
         return [lockPath, `${lockPath}.lock`];
     }
     getLockFileSettings(filePath, fileOpts) {
@@ -87,6 +90,7 @@ class LockService {
             fileOpts.retriesObj.retries = fileOpts.retries;
         }
         if (fileOpts.retryWait) {
+            // backwards compatibility
             fileOpts.retriesObj.minTimeout = fileOpts.retriesObj.maxTimeout =
                 fileOpts.retryWait;
         }
@@ -109,4 +113,6 @@ __decorate([
     (0, decorators_1.cache)()
 ], LockService.prototype, "defaultLockFilePath", null);
 yok_1.injector.register("lockService", LockService);
+// backwards compatibility
 yok_1.injector.register("lockfile", LockService);
+//# sourceMappingURL=lock-service.js.map

package/lib/common/services/message-contract-generator.js

@@ -70,3 +70,4 @@ class MessageContractGenerator {
 }
 exports.MessageContractGenerator = MessageContractGenerator;
 yok_1.injector.register("messageContractGenerator", MessageContractGenerator);
+//# sourceMappingURL=message-contract-generator.js.map

package/lib/common/services/messages-service.js

@@ -75,3 +75,4 @@ class MessagesService {
 }
 exports.MessagesService = MessagesService;
 yok_1.injector.register("messagesService", MessagesService);
+//# sourceMappingURL=messages-service.js.map

package/lib/common/services/micro-templating-service.js

@@ -9,11 +9,15 @@ const _ = require("lodash");
 class MicroTemplateService {
     constructor($injector) {
         this.$injector = $injector;
+        // Injector's dynamicCallRegex doesn't have 'g' option, which we need here.
+        // Use ( ) in order to use $1 to get whole expression later
         this.dynamicCallRegex = new RegExp(util.format("(%s)", this.$injector.dynamicCallRegex.source), "g");
     }
     async parseContent(data, options) {
         const localVariables = this.getLocalVariables(options);
         const compiledTemplate = _.template(data.replace(this.dynamicCallRegex, 'this.$injector.getDynamicCallData("$1")'));
+        // When debugging parsing, uncomment the line below:
+        // console.log(compiledTemplate.source);
         return await compiledTemplate.apply(this, [localVariables]);
     }
     isPlatform(...args) {
@@ -22,6 +26,7 @@ class MicroTemplateService {
     }
     getLocalVariables(options) {
         const isHtml = options.isHtml;
+        // in html help we want to show all help. Only CONSOLE specific help(wrapped in if(isConsole) ) must be omitted
         const localVariables = {
             constants,
         };
@@ -36,3 +41,4 @@ class MicroTemplateService {
 }
 exports.MicroTemplateService = MicroTemplateService;
 yok_1.injector.register("microTemplateService", MicroTemplateService);
+//# sourceMappingURL=micro-templating-service.js.map

package/lib/common/services/net-service.js

@@ -14,6 +14,7 @@ class Net {
     }
     async getFreePort() {
         const server = net.createServer((sock) => {
+            /* empty - noone will connect here */
         });
         return new Promise((resolve, reject) => {
             let isResolved = false;
@@ -45,6 +46,7 @@ class Net {
             });
             server.once("close", () => {
                 if (!isResolved) {
+                    // "close" will be emitted right after "error"
                     isResolved = true;
                     resolve(true);
                 }
@@ -118,3 +120,4 @@ class Net {
 exports.Net = Net;
 Net.DEFAULT_INTERVAL = 1000;
 yok_1.injector.register("net", Net);
+//# sourceMappingURL=net-service.js.map

package/lib/common/services/project-files-manager.js

@@ -53,6 +53,7 @@ class ProjectFilesManager {
         this.processPlatformSpecificFilesCore(platform, files, projectFilesConfig);
     }
     processPlatformSpecificFilesCore(platform, files, projectFilesConfig) {
+        // Renames the files that have `platform` as substring and removes the files from other platform
         _.each(files, (filePath) => {
             const projectFileInfo = this.$projectFilesProvider.getProjectFileInfo(filePath, platform, projectFilesConfig);
             if (!projectFileInfo.shouldIncludeFile) {
@@ -60,6 +61,7 @@ class ProjectFilesManager {
             }
             else if (projectFileInfo.onDeviceFileName) {
                 const onDeviceFilePath = path.join(path.dirname(filePath), projectFileInfo.onDeviceFileName);
+                // Fix .js.map entries
                 const extension = path.extname(projectFileInfo.onDeviceFileName);
                 if (onDeviceFilePath !== filePath) {
                     if (extension === ".js" || extension === ".map") {
@@ -73,6 +75,8 @@ class ProjectFilesManager {
                         fileContent = fileContent.replace(new RegExp(oldName, "g"), newName);
                         this.$fs.writeFile(filePath, fileContent);
                     }
+                    // Rename the file
+                    // this.$fs.rename is not called as it is error prone on some systems with slower hard drives and rigorous antivirus software
                     this.$fs.writeFile(onDeviceFilePath, this.$fs.readText(filePath));
                     this.$fs.deleteFile(filePath);
                 }
@@ -85,3 +89,4 @@ class ProjectFilesManager {
 }
 exports.ProjectFilesManager = ProjectFilesManager;
 yok_1.injector.register("projectFilesManager", ProjectFilesManager);
+//# sourceMappingURL=project-files-manager.js.map

package/lib/common/services/project-files-provider-base.js

@@ -52,3 +52,4 @@ class ProjectFilesProviderBase {
     }
 }
 exports.ProjectFilesProviderBase = ProjectFilesProviderBase;
+//# sourceMappingURL=project-files-provider-base.js.map

package/lib/common/services/proxy-service.js

@@ -51,3 +51,4 @@ class ProxyService {
 }
 exports.ProxyService = ProxyService;
 yok_1.injector.register("proxyService", ProxyService);
+//# sourceMappingURL=proxy-service.js.map

package/lib/common/services/qr.js

@@ -26,3 +26,4 @@ class QrCodeGenerator {
 }
 exports.QrCodeGenerator = QrCodeGenerator;
 yok_1.injector.register("qr", QrCodeGenerator);
+//# sourceMappingURL=qr.js.map

package/lib/common/services/settings-service.js

@@ -40,3 +40,4 @@ __decorate([
     (0, decorators_1.exported)("settingsService")
 ], SettingsService.prototype, "setSettings", null);
 yok_1.injector.register("settingsService", SettingsService);
+//# sourceMappingURL=settings-service.js.map

package/lib/common/services/xcode-select-service.js

@@ -45,3 +45,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], XcodeSelectService.prototype, "getXcodeVersion", null);
 yok_1.injector.register("xcodeSelectService", XcodeSelectService);
+//# sourceMappingURL=xcode-select-service.js.map

package/lib/common/utils.js

@@ -36,3 +36,4 @@ function capitalizeFirstLetter(value) {
     return value.charAt(0).toUpperCase() + value.slice(1);
 }
 yok_1.injector.register("utils", Utils);
+//# sourceMappingURL=utils.js.map

package/lib/common/validators/project-name-validator.js

@@ -86,3 +86,4 @@ ProjectNameValidator.INVALID_FILENAMES = [
 ];
 ProjectNameValidator.INVALID_EXTENSIONS = [];
 yok_1.injector.register("projectNameValidator", ProjectNameValidator);
+//# sourceMappingURL=project-name-validator.js.map

package/lib/common/validators/validation-result.js

@@ -14,3 +14,4 @@ class ValidationResult {
 }
 exports.ValidationResult = ValidationResult;
 ValidationResult.Successful = new ValidationResult(null);
+//# sourceMappingURL=validation-result.js.map

package/lib/common/verify-node-version.js

@@ -1,11 +1,16 @@
 "use strict";
+// This function must be separate to avoid dependencies on C++ modules - it must execute precisely when other functions cannot
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.verifyNodeVersion = verifyNodeVersion;
 exports.getNodeWarning = getNodeWarning;
 const color_1 = require("../color");
+// Use only ES5 code here - pure JavaScript can be executed with any Node.js version (even 0.10, 0.12).
+/* tslint:disable:no-var-keyword no-var-requires prefer-const*/
 var os = require("os");
 var semver = require("semver");
 var util = require("util");
+// These versions cannot be used with CLI due to bugs in the node itself.
+// We are absolutely sure we cannot work with them, so inform the user if he is trying to use any of them and exit the process.
 var versionsCausingFailure = ["0.10.34", "4.0.0", "4.2.0", "5.0.0"];
 var minimumRequiredVersion = "8.0.0";
 function getNodeVersionOpts() {
@@ -69,9 +74,11 @@ function getNodeWarning() {
         if (warningMessage) {
             nodeWarn = {
                 message: warningMessage,
-                severity: "medium",
+                severity: "medium" /* SystemWarningsSeverity.medium */,
             };
         }
     }
     return nodeWarn;
 }
+/* tslint:enable */
+//# sourceMappingURL=verify-node-version.js.map

package/lib/common/yok.js

@@ -9,6 +9,13 @@ const helpers_1 = require("./helpers");
 const constants_1 = require("./constants");
 let indent = "";
 function trace(formatStr, ...args) {
+    // uncomment following lines when debugging dependency injection
+    // const items: any[] = [];
+    // for (let _i = 1; _i < arguments.length; _i++) {
+    // 	items[_i - 1] = arguments[_i];
+    // }
+    // const util = require("util");
+    // console.log(util.format.apply(util, [indent + formatStr].concat(args)));
 }
 function pushIndent() {
     indent += "  ";
@@ -26,6 +33,7 @@ function forEachName(names, action) {
 }
 function register(...rest) {
     return function (target) {
+        // TODO: Check if 'rest' has more arguments that have to be registered
         exports.injector.register(rest[0], target);
     };
 }
@@ -44,7 +52,7 @@ class Yok {
     }
     requireCommand(names, file) {
         forEachName(names, (commandName) => {
-            const commands = commandName.split("|");
+            const commands = commandName.split("|" /* CommandsDelimiters.HierarchicalCommand */);
             if (commands.length > 1) {
                 if (_.startsWith(commands[1], "*") &&
                     this.modules[this.createCommandName(commands[0])]) {
@@ -54,7 +62,7 @@ class Yok {
                 if (!this.hierarchicalCommands[parentCommandName]) {
                     this.hierarchicalCommands[parentCommandName] = [];
                 }
-                this.hierarchicalCommands[parentCommandName].push(_.tail(commands).join("|"));
+                this.hierarchicalCommands[parentCommandName].push(_.tail(commands).join("|" /* CommandsDelimiters.HierarchicalCommand */));
             }
             if (commands.length > 1 &&
                 !this.modules[this.createCommandName(commands[0])]) {
@@ -125,7 +133,7 @@ class Yok {
     }
     registerCommand(names, resolver) {
         forEachName(names, (name) => {
-            const commands = name.split("|");
+            const commands = name.split("|" /* CommandsDelimiters.HierarchicalCommand */);
             this.register(this.createCommandName(name), resolver);
             if (commands.length > 1) {
                 this.createHierarchicalCommand(commands[0]);
@@ -137,7 +145,7 @@ class Yok {
     }
     getDefaultCommand(name, commandArguments) {
         const subCommands = this.hierarchicalCommands[name];
-        const defaultCommand = _.find(subCommands, (command) => _.some(command.split("|"), (c) => _.startsWith(c, "*")));
+        const defaultCommand = _.find(subCommands, (command) => _.some(command.split("|" /* CommandsDelimiters.HierarchicalCommand */), (c) => _.startsWith(c, "*" /* CommandsDelimiters.DefaultCommandSymbol */)));
         return defaultCommand;
     }
     buildHierarchicalCommand(parentCommandName, commandLineArguments) {
@@ -153,7 +161,7 @@ class Yok {
             remainingArguments = _.tail(remainingArguments);
             if ((matchingSubCommandName = _.find(subCommands, (sc) => sc === currentSubCommandName ||
                 sc ===
-                    `${"*"}${currentSubCommandName}`))) {
+                    `${"*" /* CommandsDelimiters.DefaultCommandSymbol */}${currentSubCommandName}`))) {
                 finalSubCommandName = matchingSubCommandName;
                 finalRemainingArguments = remainingArguments;
             }
@@ -162,8 +170,8 @@ class Yok {
             finalSubCommandName =
                 this.getDefaultCommand(parentCommandName, commandLineArguments) || "";
             finalRemainingArguments = _.difference(commandLineArguments, finalSubCommandName
-                .split("|")
-                .map((command) => _.startsWith(command, "*")
+                .split("|" /* CommandsDelimiters.HierarchicalCommand */)
+                .map((command) => _.startsWith(command, "*" /* CommandsDelimiters.DefaultCommandSymbol */)
                 ? command.substr(1)
                 : command));
         }
@@ -194,7 +202,9 @@ class Yok {
                             commandName = defaultCommand
                                 ? this.getHierarchicalCommandName(name, defaultCommand)
                                 : "help";
-                            if (_.includes(this.hierarchicalCommands[name], "*" + args[0])) {
+                            // If we'll execute the default command, but it's full name had been written by the user
+                            // for example "ns run ios", we have to remove the "ios" option from the arguments that we'll pass to the command.
+                            if (_.includes(this.hierarchicalCommands[name], "*" /* CommandsDelimiters.DefaultCommandSymbol */ + args[0])) {
                                 commandArguments = _.tail(args);
                             }
                             else {
@@ -203,11 +213,13 @@ class Yok {
                         }
                     }
                     else {
+                        //Execute only default command without arguments
                         if (defaultCommand) {
                             commandName = this.getHierarchicalCommandName(name, defaultCommand);
                         }
                         else {
                             commandName = "help";
+                            // Show command-line help
                             const options = this.resolve("options");
                             options.help = true;
                         }
@@ -219,7 +231,7 @@ class Yok {
         exports.injector.registerCommand(name, factory);
     }
     getHierarchicalCommandName(parentCommandName, subCommandName) {
-        return [parentCommandName, subCommandName].join("|");
+        return [parentCommandName, subCommandName].join("|" /* CommandsDelimiters.HierarchicalCommand */);
     }
     async isValidHierarchicalCommand(commandName, commandArguments) {
         if (_.includes(Object.keys(this.hierarchicalCommands), commandName)) {
@@ -227,6 +239,8 @@ class Yok {
             if (subCommands) {
                 const fullCommandName = this.buildHierarchicalCommand(commandName, commandArguments);
                 if (!fullCommandName) {
+                    // In case buildHierarchicalCommand doesn't find a valid command
+                    // there isn't a valid command or default with those arguments
                     const errors = exports.injector.resolve("errors");
                     errors.failWithHelp(constants_1.ERROR_NO_VALID_SUBCOMMAND_FORMAT, commandName);
                 }
@@ -236,8 +250,8 @@ class Yok {
         return false;
     }
     isDefaultCommand(commandName) {
-        return (commandName.indexOf("*") > 0 &&
-            commandName.indexOf("|") > 0);
+        return (commandName.indexOf("*" /* CommandsDelimiters.DefaultCommandSymbol */) > 0 &&
+            commandName.indexOf("|" /* CommandsDelimiters.HierarchicalCommand */) > 0);
     }
     register(name, resolver, shared) {
         shared = shared === undefined ? true : shared;
@@ -284,6 +298,12 @@ class Yok {
             return this.resolveByName(param, ctorArguments);
         }
     }
+    /* Regex to match dynamic calls in the following format:
+        #{moduleName.functionName} or
+        #{moduleName.functionName(param1)} or
+        #{moduleName.functionName(param1, param2)} - multiple parameters separated with comma are supported
+        Check dynamicCall method for sample usage of this regular expression and see how to determine the passed parameters
+    */
     get dynamicCallRegex() {
         return /#{([^.]+)\.([^}]+?)(\((.+)\))*}/;
     }
@@ -411,3 +431,4 @@ function setGlobalInjector(inj) {
     global.$injector = exports.injector = inj;
     return inj;
 }
+//# sourceMappingURL=yok.js.map

package/lib/config.js

@@ -7,8 +7,10 @@ const os = require("os");
 const _ = require("lodash");
 const yok_1 = require("./common/yok");
 class Configuration {
+    /*don't require logger and everything that has logger as dependency in config.js due to cyclic dependency*/
     constructor($fs) {
         this.$fs = $fs;
+        // User specific config
         this.DEBUG = false;
         this.ANDROID_DEBUG_UI = null;
         this.USE_POD_SANDBOX = false;
@@ -47,6 +49,7 @@ class StaticConfig {
         this._userAgent = null;
     }
     get disableCommandHooks() {
+        // Never set this to false because it will duplicate execution of hooks realized through method decoration
         return true;
     }
     get HTML_CLI_HELPERS_DIR() {
@@ -88,6 +91,7 @@ class StaticConfig {
     async getAdbFilePathCore() {
         const $childProcess = this.$injector.resolve("$childProcess");
         try {
+            // Do NOT use the adb wrapper because it will end blow up with Segmentation fault because the wrapper uses this method!!!
             const proc = await $childProcess.spawnFromEvent("adb", ["version"], "exit", undefined, { throwError: false });
             if (proc.stderr) {
                 return await this.spawnPrivateAdb();
@@ -100,23 +104,40 @@ class StaticConfig {
         }
         return "adb";
     }
+    /*
+        Problem:
+        1. Adb forks itself as a server which keeps running until adb kill-server is invoked or crashes
+        2. On Windows running processes lock their image files due to memory mapping. Locked files prevent their parent directories from deletion and cannot be overwritten.
+        3. Update and uninstall scenarios are broken
+        Solution:
+        - Copy adb and associated files into a temporary directory. Let this copy of adb run persistently
+        - On Posix OSes, immediately delete the file to not take file space
+        - Tie common lib version to updates of adb, so that when we integrate a newer adb we can use it
+        - Adb is named differently on OSes and may have additional files. The code is hairy to accommodate these differences
+     */
     async spawnPrivateAdb() {
         const $fs = this.$injector.resolve("$fs"), $childProcess = this.$injector.resolve("$childProcess"), $hostInfo = this.$injector.resolve("$hostInfo");
+        // prepare the directory to host our copy of adb
         const defaultAdbDirPath = path.join(__dirname, "common", "resources", "platform-tools", "android", process.platform);
         const pathToPackageJson = path.join(__dirname, "..", "package.json");
         const nsCliVersion = require(pathToPackageJson).version;
         const tmpDir = path.join(os.tmpdir(), `nativescript-cli-${nsCliVersion}`);
         $fs.createDirectory(tmpDir);
+        // copy the adb and associated files
         const targetAdb = path.join(tmpDir, "adb");
+        // In case directory is missing or it's empty, copy the new adb
         if (!$fs.exists(tmpDir) || !$fs.readDirectory(tmpDir).length) {
-            shelljs.cp(path.join(defaultAdbDirPath, "*"), tmpDir);
+            shelljs.cp(path.join(defaultAdbDirPath, "*"), tmpDir); // deliberately ignore copy errors
+            // adb loses its executable bit when packed inside electron asar file. Manually fix the issue
             if (!$hostInfo.isWindows) {
                 shelljs.chmod("+x", targetAdb);
             }
         }
+        // let adb start its global server
         await $childProcess.spawnFromEvent(targetAdb, ["start-server"], "exit");
         return targetAdb;
     }
 }
 exports.StaticConfig = StaticConfig;
 yok_1.injector.register("staticConfig", StaticConfig);
+//# sourceMappingURL=config.js.map

package/lib/constants-provider.js

@@ -10,3 +10,4 @@ class Constants {
 }
 exports.Constants = Constants;
 yok_1.injector.register("constants", Constants);
+//# sourceMappingURL=constants-provider.js.map