nativescript 9.0.4-dev.1 → 9.0.4-dev.2

package/lib/common/commands/package-manager-set.js

@@ -24,3 +24,4 @@ class PackageManagerCommand {
 }
 exports.PackageManagerCommand = PackageManagerCommand;
 yok_1.injector.registerCommand("package-manager|set", PackageManagerCommand);
+//# sourceMappingURL=package-manager-set.js.map

package/lib/common/commands/post-install.js

@@ -14,3 +14,4 @@ class PostInstallCommand {
 }
 exports.PostInstallCommand = PostInstallCommand;
 yok_1.injector.registerCommand("dev-post-install", PostInstallCommand);
+//# sourceMappingURL=post-install.js.map

package/lib/common/commands/preuninstall.js

@@ -6,12 +6,16 @@ const helpers_1 = require("../helpers");
 const constants_1 = require("../../constants");
 const yok_1 = require("../yok");
 class PreUninstallCommand {
-    constructor($analyticsService, $extensibilityService, $fs, $packageInstallationManager, $settingsService) {
+    constructor($analyticsService, $extensibilityService, $fs, 
+    // private $opener: IOpener,
+    $packageInstallationManager, $settingsService) {
         this.$analyticsService = $analyticsService;
         this.$extensibilityService = $extensibilityService;
         this.$fs = $fs;
         this.$packageInstallationManager = $packageInstallationManager;
         this.$settingsService = $settingsService;
+        // disabled for now (6/24/2020)
+        // private static FEEDBACK_FORM_URL = "https://www.nativescript.org/uninstall-feedback";
         this.allowedParameters = [];
     }
     async execute(args) {
@@ -24,7 +28,7 @@ class PreUninstallCommand {
             /^unlink$/,
         ]);
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Uninstall CLI",
+            action: "Uninstall CLI" /* TrackActionNames.UninstallCLI */,
             additionalData: `isIntentionalUninstall${constants_1.AnalyticsEventLabelDelimiter}${isIntentionalUninstall}${constants_1.AnalyticsEventLabelDelimiter}isInteractive${constants_1.AnalyticsEventLabelDelimiter}${!!(0, helpers_1.isInteractive)()}`,
         });
         if (isIntentionalUninstall) {
@@ -39,8 +43,13 @@ class PreUninstallCommand {
         await this.handleFeedbackForm();
     }
     async handleFeedbackForm() {
+        // disabled for now (6/24/2020)
+        // if (isInteractive()) {
+        // 	this.$opener.open(PreUninstallCommand.FEEDBACK_FORM_URL);
+        // }
         return Promise.resolve();
     }
 }
 exports.PreUninstallCommand = PreUninstallCommand;
 yok_1.injector.registerCommand("dev-preuninstall", PreUninstallCommand);
+//# sourceMappingURL=preuninstall.js.map

package/lib/common/commands/proxy/proxy-base.js

@@ -12,7 +12,10 @@ class ProxyCommandBase {
     }
     async tryTrackUsage() {
         try {
+            // TODO(Analytics): Check why we have set the `disableAnalytics` to true and we track the command as separate one
+            // instead of tracking it through the commandsService.
             this.$logger.trace(this.commandName);
+            // await this.$analyticsService.trackFeature(this.commandName);
         }
         catch (ex) {
             this.$logger.trace("Error in trying to track proxy command usage:");
@@ -21,3 +24,4 @@ class ProxyCommandBase {
     }
 }
 exports.ProxyCommandBase = ProxyCommandBase;
+//# sourceMappingURL=proxy-base.js.map

package/lib/common/commands/proxy/proxy-clear.js

@@ -19,3 +19,4 @@ class ProxyClearCommand extends proxy_base_1.ProxyCommandBase {
 }
 exports.ProxyClearCommand = ProxyClearCommand;
 yok_1.injector.registerCommand(proxyClearCommandName, ProxyClearCommand);
+//# sourceMappingURL=proxy-clear.js.map

package/lib/common/commands/proxy/proxy-get.js

@@ -18,3 +18,4 @@ class ProxyGetCommand extends proxy_base_1.ProxyCommandBase {
 }
 exports.ProxyGetCommand = ProxyGetCommand;
 yok_1.injector.registerCommand(proxyGetCommandName, ProxyGetCommand);
+//# sourceMappingURL=proxy-get.js.map

package/lib/common/commands/proxy/proxy-set.js

@@ -135,3 +135,4 @@ class ProxySetCommand extends proxy_base_1.ProxyCommandBase {
 }
 exports.ProxySetCommand = ProxySetCommand;
 yok_1.injector.registerCommand(proxySetCommandName, ProxySetCommand);
+//# sourceMappingURL=proxy-set.js.map

package/lib/common/common-lib.js

@@ -3,3 +3,4 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const yok_1 = require("./yok");
 require("./appbuilder/proton-bootstrap");
 module.exports = yok_1.injector.publicApi;
+//# sourceMappingURL=common-lib.js.map

package/lib/common/constants.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SOCKET_CONNECTION_TIMEOUT_MS = exports.AndroidVirtualDevice = exports.ATTACH_REQUEST_EVENT_NAME = exports.DEBUGGER_PORT_FOUND_EVENT_NAME = exports.DEFAULT_CHUNK_SIZE = exports.HttpProtocolToPort = exports.HttpStatusCodes = exports.Proxy = exports.IOS_RELAY_NOTIFICATION_COMMAND_TYPE = exports.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE = exports.IOS_POST_NOTIFICATION_COMMAND_TYPE = exports.FileExtensions = exports.TNS_CORE_MODULES = exports.NODE_MODULES_DIR_NAME = exports.Configurations = exports.TARGET_FRAMEWORK_IDENTIFIERS = exports.FAIL_LIVESYNC_LOG_REGEX = exports.IOS_APP_CRASH_LOG_REG_EXP = exports.IOS_LOG_PREDICATE = exports.DEVICE_LOG_EVENT_NAME = exports.EmulatorDiscoveryNames = exports.DeviceDiscoveryEventNames = exports.HmrConstants = exports.LiveSyncPaths = exports.APPLE_VENDOR_NAME = exports.NOT_RUNNING_EMULATOR_STATUS = exports.RUNNING_EMULATOR_STATUS = exports.CONNECTED_STATUS = exports.UNREACHABLE_STATUS = exports.ERROR_NO_VALID_SUBCOMMAND_FORMAT = exports.ERROR_CANNOT_RESOLVE_DEVICE = exports.ERROR_NO_DEVICES_CANT_USE_IOS_SIMULATOR = exports.ERROR_CANT_USE_SIMULATOR = exports.ERROR_NO_DEVICES = exports.APP_RESOURCES_FOLDER_NAME = exports.DeviceTypes = exports.ProvisionType = void 0;
+// enumeration taken from ProvisionType.cs
 class ProvisionType {
 }
 exports.ProvisionType = ProvisionType;
@@ -82,6 +83,9 @@ Proxy.CACHE_FILE_NAME = "proxy-cache.json";
 Proxy.USE_PROXY = "USE_PROXY";
 Proxy.PROXY_PORT = "PROXY_PORT";
 Proxy.PROXY_HOSTNAME = "PROXY_HOSTNAME";
+/**
+ * Http status codes available from `require("http").STATUS_CODES`.
+ */
 class HttpStatusCodes {
 }
 exports.HttpStatusCodes = HttpStatusCodes;
@@ -107,7 +111,13 @@ AndroidVirtualDevice.INI_FILES_MASK = /^(.*)\.ini$/i;
 AndroidVirtualDevice.AVD_FILES_MASK = /^(.*)\.avd$/i;
 AndroidVirtualDevice.MIN_ANDROID_APILEVEL = 17;
 AndroidVirtualDevice.MIN_ANDROID_VERSION = "4.2";
+/**
+ * The message that is printed from `avdmanager list avds`
+ */
 AndroidVirtualDevice.AVAILABLE_AVDS_MESSAGE = "Available Android Virtual Devices:";
+/**
+ * The delimiter between devices that is used from `avdmanager list avds`
+ */
 AndroidVirtualDevice.AVD_LIST_DELIMITER = "---------";
 AndroidVirtualDevice.CONFIG_INI_FILE_NAME = "config.ini";
 AndroidVirtualDevice.INI_FILE_EXTENSION = ".ini";
@@ -120,3 +130,4 @@ AndroidVirtualDevice.TIMEOUT_SECONDS = 120;
 AndroidVirtualDevice.GENYMOTION_DEFAULT_STDERR_STRING = "Logging activities to file";
 AndroidVirtualDevice.UNABLE_TO_START_EMULATOR_MESSAGE = "Cannot run the app in the selected native emulator. Try to restart the adb server by running the `adb kill-server` command in the Command Prompt, or increase the allocated RAM of the virtual device through the Android Virtual Device manager. NativeScript CLI users can try to increase the timeout of the operation by adding the `--timeout` flag.";
 exports.SOCKET_CONNECTION_TIMEOUT_MS = 30000;
+//# sourceMappingURL=constants.js.map

package/lib/common/decorators.js

@@ -9,6 +9,32 @@ exports.performanceLog = performanceLog;
 exports.deprecated = deprecated;
 const constants_1 = require("../constants");
 const yok_1 = require("./yok");
+/**
+ * Caches the result of the first execution of the method and returns it whenever it is called instead of executing it again.
+ * Works with methods and getters.
+ * @example
+ * ```
+ * class CacheDecoratorsTest {
+ *
+ * 	@cache()
+ * 	public method(num: number): number {
+ * 		return num;
+ * 	}
+ *
+ * 	@cache()
+ * 	public get property(): any {
+ * 		// execute some heavy operation.
+ * 		return result;
+ * 	}
+ * }
+ *
+ * const instance = new CacheDecoratorsTest();
+ * const result = instance.method(1); // returns 1;
+ *
+ * // all consecutive calls to instance.method will return 1.
+ * const result2 = instance.method(2); // returns 1;
+ * ```
+ */
 function cache() {
     return (target, propertyKey, descriptor) => {
         let result;
@@ -28,6 +54,7 @@ function cache() {
 let memoizeIDCounter = 0;
 function memoize(options) {
     return (target, propertyKey, descriptor) => {
+        // todo: remove once surely working as intended.
         const DEBUG = false;
         const memoizeID = memoizeIDCounter++;
         const valueOrGet = descriptor.value ? "value" : "get";
@@ -48,6 +75,7 @@ function memoize(options) {
                     cacheMapName,
                     hashKey,
                 });
+            // initialize cache map if not exists
             if (!this.hasOwnProperty(cacheMapName)) {
                 DEBUG && console.log("NO CACHE MAP YET, CREATING ONE NOW");
                 Object.defineProperty(this, cacheMapName, {
@@ -62,12 +90,16 @@ function memoize(options) {
                 console.log({
                     cacheMap,
                 });
+            // check if has memoized value based on hashFn
             if (cacheMap.has(hashKey)) {
                 DEBUG && console.log("CACHE HIT");
+                // if yes, return cached value
                 return cacheMap.get(hashKey);
             }
             DEBUG && console.log("CACHE MISS");
+            // if not call original and get result
             const result = originalMethod.apply(this, args);
+            // call shouldCache (if passed) with the result or default to true
             let shouldCache = true;
             if (options.shouldCache) {
                 shouldCache = options.shouldCache.call(this, result);
@@ -77,12 +109,21 @@ function memoize(options) {
                 DEBUG && console.log("CACHING NOW");
                 cacheMap.set(hashKey, result);
             }
+            // if shouldCache: save result
             DEBUG && console.log("RETURNING", result);
             return result;
         };
         return descriptor;
     };
 }
+/**
+ * Calls specific method of the instance before executing the decorated method.
+ * This is usable when some of your methods depend on initialize async method, that cannot be invoked in constructor of the class.
+ * IMPORTANT: The decorated method must be async.
+ * @param {string} methodName The name of the method that will be invoked before calling the decorated method.
+ * @param {any[]} methodArgs Args that will be passed to the method that will be invoked before calling the decorated one.
+ * @return {any} Result of the decorated method.
+ */
 function invokeBefore(methodName, methodArgs) {
     return (target, propertyKey, descriptor) => {
         const originalValue = descriptor.value;
@@ -114,6 +155,7 @@ function performanceLog(localInjector) {
         const className = target.constructor.name;
         const trackName = `${className}${constants_1.AnalyticsEventLabelDelimiter}${propertyKey}`;
         const performanceService = localInjector.resolve("performanceService");
+        //needed for the returned function to have the same name as the original - used in hooks decorator
         const functionWrapper = {
             [originalMethod.name]: function (...args) {
                 const start = performanceService.now();
@@ -139,12 +181,14 @@ function performanceLog(localInjector) {
             },
         };
         descriptor.value = functionWrapper[originalMethod.name];
+        // used to get parameter names in hooks decorator
         descriptor.value.toString = () => {
             return originalMethod.toString();
         };
         return descriptor;
     };
 }
+// inspired by https://github.com/NativeScript/NativeScript/blob/55dfe25938569edbec89255008e5ad9804901305/tns-core-modules/globals/globals.ts#L121-L137
 function deprecated(additionalInfo, localInjector) {
     const isDeprecatedMessage = " is deprecated.";
     return (target, key, descriptor) => {
@@ -153,6 +197,7 @@ function deprecated(additionalInfo, localInjector) {
         const $logger = localInjector.resolve("logger");
         if (descriptor) {
             if (descriptor.value) {
+                // method
                 const originalMethod = descriptor.value;
                 descriptor.value = function (...args) {
                     $logger.warn(`${key.toString()}${isDeprecatedMessage} ${additionalInfo}`);
@@ -161,6 +206,7 @@ function deprecated(additionalInfo, localInjector) {
                 return descriptor;
             }
             else {
+                // property
                 if (descriptor.set) {
                     const originalSetter = descriptor.set;
                     descriptor.set = function (...args) {
@@ -179,6 +225,7 @@ function deprecated(additionalInfo, localInjector) {
             }
         }
         else {
+            // class
             $logger.warn(`${(target &&
                 (target.name ||
                     (target.constructor && target.constructor.name))) ||
@@ -187,3 +234,4 @@ function deprecated(additionalInfo, localInjector) {
         }
     };
 }
+//# sourceMappingURL=decorators.js.map

package/lib/common/dispatchers.js

@@ -15,7 +15,9 @@ const yok_1 = require("./yok");
 const constants_1 = require("../constants");
 const semver = require("semver");
 class CommandDispatcher {
-    constructor($logger, $injector, $cancellation, $commandsService, $staticConfig, $sysInfo, $options, $versionsService, $packageManager, $terminalSpinnerService) {
+    constructor($logger, 
+    // required by the hooksService
+    $injector, $cancellation, $commandsService, $staticConfig, $sysInfo, $options, $versionsService, $packageManager, $terminalSpinnerService) {
         this.$logger = $logger;
         this.$injector = $injector;
         this.$cancellation = $cancellation;
@@ -32,6 +34,7 @@ class CommandDispatcher {
             return this.printVersion();
         }
         if (this.$logger.getLevel() === "TRACE" && !this.$options.json) {
+            // CommandDispatcher is called from external CLI's only, so pass the path to their package.json
             this.$logger.trace("Collecting system information...");
             const sysInfo = await this.$sysInfo.getSysInfo({
                 pathToNativeScriptCliPackageJson: path.join(__dirname, "..", "..", "package.json"),
@@ -61,6 +64,7 @@ class CommandDispatcher {
         await this.$commandsService.tryExecuteCommand(commandName, commandArguments);
     }
     async resolveCommand(commandName, commandArguments, argv) {
+        // just a hook point
         return { commandName, commandArguments, argv };
     }
     getCommandName() {
@@ -68,12 +72,15 @@ class CommandDispatcher {
         if (remaining.length > 0) {
             return remaining[0].toString().toLowerCase();
         }
+        // if only <CLI_NAME> is specified on console, show console help
         this.$options.help = true;
         return "";
     }
     async printVersion() {
         this.$logger.info(this.$staticConfig.version);
         if (this.$options.json) {
+            // we don't check for updates when --json is passed
+            // useful for tools that rely on the output of the command
             return;
         }
         const spinner = this.$terminalSpinnerService.createSpinner();
@@ -101,6 +108,7 @@ class CommandDispatcher {
         if (semver.gte(nativescriptCliVersion.currentVersion, nativescriptCliVersion.latestVersion, {
             loose: true,
         })) {
+            // up-to-date
             spinner.succeed("Up to date.");
         }
         else {
@@ -132,3 +140,4 @@ class FutureDispatcher {
     }
 }
 yok_1.injector.register("dispatcher", FutureDispatcher, false);
+//# sourceMappingURL=dispatchers.js.map

package/lib/common/errors.js

@@ -15,7 +15,9 @@ const source_map_1 = require("source-map");
 const helpers_1 = require("./helpers");
 const decorators_1 = require("./decorators");
 const yok_1 = require("./yok");
+// we need this to overwrite .stack property (read-only in Error)
 function Exception() {
+    /* intentionally left blank */
 }
 Exception.prototype = new Error();
 async function resolveCallStack(error) {
@@ -60,6 +62,7 @@ async function resolveCallStack(error) {
     }));
     let outputMessage = remapped.join("\n");
     if (outputMessage.indexOf(error.message) === -1) {
+        // when fibers throw error in node 0.12.x, the stack does NOT contain the message
         outputMessage = outputMessage.replace(/Error/, "Error: " + error.message);
     }
     return outputMessage;
@@ -83,7 +86,9 @@ function installUncaughtExceptionListener(actionOnException) {
             }
         }
         catch (err) {
-            process.exit(131);
+            // In case the handler throws error and we do not catch it, we'll go in infinite loop of unhandled rejections.
+            // We cannot do anything here as even `console.error` may fail. So just exit the process.
+            process.exit(131 /* ErrorCodes.UNHANDLED_REJECTION_FAILURE */);
         }
     };
     process.on("uncaughtException", handler);
@@ -95,6 +100,7 @@ async function tryTrackException(error, localInjector) {
         disableAnalytics = localInjector.resolve("staticConfig").disableAnalytics;
     }
     catch (err) {
+        // We should get here only in our unit tests.
         disableAnalytics = true;
     }
     if (!disableAnalytics) {
@@ -103,6 +109,7 @@ async function tryTrackException(error, localInjector) {
             await analyticsService.trackException(error, error.message);
         }
         catch (e) {
+            // Do not replace with logger due to cyclic dependency
             console.error("Error while reporting exception: " + e);
         }
     }
@@ -140,9 +147,10 @@ class Errors {
             exception.message = $messagesService.getMessage.apply($messagesService, [opts.formatStr].concat(argsArray));
         }
         catch (err) {
+            // Ignore
         }
         exception.stack = new Error(exception.message).stack;
-        exception.errorCode = opts.errorCode || 127;
+        exception.errorCode = opts.errorCode || 127 /* ErrorCodes.UNKNOWN */;
         exception.suggestCommandHelp = suggestCommandHelp;
         exception.proxyAuthenticationRequired = !!opts.proxyAuthenticationRequired;
         exception.printOnStdout = opts.printOnStdout;
@@ -174,9 +182,10 @@ class Errors {
                 await printCommandHelpSuggestion();
             }
             await tryTrackException(ex, this.$injector);
-            process.exit(_.isNumber(ex.errorCode) ? ex.errorCode : 127);
+            process.exit(_.isNumber(ex.errorCode) ? ex.errorCode : 127 /* ErrorCodes.UNKNOWN */);
         }
     }
+    // If you want to activate this function, start Node with flags --nouse_idle_notification and --expose_gc
     verifyHeap(message) {
         if (global.gc) {
             console.log("verifyHeap: '%s'", message);
@@ -189,3 +198,4 @@ __decorate([
     (0, decorators_1.deprecated)("Use `fail` instead.")
 ], Errors.prototype, "failWithoutHelp", null);
 yok_1.injector.register("errors", Errors);
+//# sourceMappingURL=errors.js.map

package/lib/common/file-system.js

@@ -20,12 +20,14 @@ const constants_1 = require("../constants");
 const os_1 = require("os");
 const detectNewline = require("detect-newline");
 const archiver_1 = require("archiver");
+// TODO: Add .d.ts for mkdirp module (or use it from @types repo).
 const mkdirp = require("mkdirp");
 let FileSystem = FileSystem_1 = class FileSystem {
     constructor($injector) {
         this.$injector = $injector;
     }
     async zipFiles(zipFile, files, zipPathCallback) {
+        //we are resolving it here instead of in the constructor, because config has dependency on file system and config shouldn't require logger
         const $logger = this.$injector.resolve("logger");
         const zip = (0, archiver_1.create)("zip", {
             zlib: {
@@ -62,10 +64,10 @@ let FileSystem = FileSystem_1 = class FileSystem {
             proc = (0, path_1.join)(__dirname, "resources/platform-tools/unzip/win32/unzip");
         }
         else if ($hostInfo.isDarwin) {
-            proc = "unzip";
+            proc = "unzip"; // darwin unzip is info-zip
         }
         else if ($hostInfo.isLinux) {
-            proc = "unzip";
+            proc = "unzip"; // linux unzip is info-zip
         }
         if (!isCaseSensitive) {
             zipFile = this.findFileCaseInsensitive(zipFile);
@@ -106,6 +108,7 @@ let FileSystem = FileSystem_1 = class FileSystem {
         }
         catch (err) {
             if (err && err.code !== "ENOENT") {
+                // ignore "file doesn't exist" error
                 throw err;
             }
         }
@@ -144,6 +147,7 @@ let FileSystem = FileSystem_1 = class FileSystem {
                 }
             });
             if (root) {
+                // console.log("root", paths);
                 return Array.from(paths.values()).reduce((sum, current) => sum + current, 0);
             }
         };
@@ -216,6 +220,8 @@ let FileSystem = FileSystem_1 = class FileSystem {
     writeFile(filename, data, encoding) {
         this.createDirectory((0, path_1.dirname)(filename));
         if (!data) {
+            // node 14 will no longer coerce unsupported input to strings anymore.
+            // clean any null or undefined data
             data = "";
         }
         fs.writeFileSync(filename, data, { encoding: encoding });
@@ -246,6 +252,8 @@ let FileSystem = FileSystem_1 = class FileSystem {
             return;
         }
         this.createDirectory((0, path_1.dirname)(destinationFileName));
+        // MobileApplication.app is resolved as a directory on Mac,
+        // therefore we need to copy it recursively as it's not a single file.
         shelljs.cp("-rf", sourceFileName, destinationFileName);
         const err = shelljs.error();
         if (err) {
@@ -321,7 +329,9 @@ let FileSystem = FileSystem_1 = class FileSystem {
             });
             await this.futureFromEvent(chown, "close");
         }
+        // nothing to do on Windows, as chown does not work on this platform
     }
+    // filterCallback: function(path: String, stat: fs.Stats): Boolean
     enumerateFilesInDirectorySync(directoryPath, filterCallback, opts, foundFiles) {
         foundFiles = foundFiles || [];
         if (!this.exists(directoryPath)) {
@@ -417,3 +427,4 @@ FileSystem.JSON_OBJECT_REGEXP = new RegExp(`{\\r*\\n*(\\W*)"`, "m");
 exports.FileSystem = FileSystem = FileSystem_1 = __decorate([
     injector.register("fs")
 ], FileSystem);
+//# sourceMappingURL=file-system.js.map

package/lib/common/header.js

@@ -13,11 +13,13 @@ function printHeader() {
         color_1.color.styleText(["cyanBright", "bold"], "{N} NativeScript "),
         color_1.color.styleText(["whiteBright", "bold"], "CLI"),
         color_1.color.dim(` [v${version}] `),
+        // color.dim("  │"),
     ].join("");
     const tagLine = [
         color_1.color.dim("│ "),
         color_1.color.dim(" → "),
         color_1.color.styleText(["whiteBright", "bold"], "Empower JavaScript with native APIs "),
+        // color.dim("  │"),
     ].join("");
     const headerLength = (0, color_1.stripColors)(header).length;
     const tagLineLength = (0, color_1.stripColors)(tagLine).length;
@@ -27,3 +29,4 @@ function printHeader() {
     console.info("  " + tagLine + " ".repeat(width - tagLineLength) + color_1.color.dim("│"));
     console.info("  " + color_1.color.dim("└" + "─".repeat(width - 1) + "┘"));
 }
+//# sourceMappingURL=header.js.map